Skip to content

The open alternative to Salesforce, designed for AI.

Fix campaign page scrolling (#24796)

Félix Malfait2997332c5b75
diff --git a/packages/twenty-front/src/modules/page-layout/components/__tests__/PageLayoutVerticalList.test.tsx b/packages/twenty-front/src/modules/page-layout/components/__tests__/PageLayoutVerticalList.test.tsx
index f916f187411..317bd7f6dcd 100644
--- a/packages/twenty-front/src/modules/page-layout/components/__tests__/PageLayoutVerticalList.test.tsx
+++ b/packages/twenty-front/src/modules/page-layout/components/__tests__/PageLayoutVerticalList.test.tsx
@@ -125,7 +125,6 @@ describe('PageLayoutVerticalList', () => {
makeWidget('emails', WidgetType.EMAILS),
makeWidget('email-thread', WidgetType.EMAIL_THREAD),
makeWidget('files', WidgetType.FILES),
- makeWidget('message-campaign-body', WidgetType.MESSAGE_CAMPAIGN_BODY),
makeWidget('notes', WidgetType.NOTES),
makeWidget('tasks', WidgetType.TASKS),
makeWidget('workflow', WidgetType.WORKFLOW),
@@ -157,6 +156,26 @@ describe('PageLayoutVerticalList', () => {
).toBeNull();
});
+ it('keeps campaign documents fit-content so the tab owns scrolling', () => {
+ render(
+ <PageLayoutVerticalList
+ isInEditMode={false}
+ widgets={[
+ makeWidget('message-campaign-body', WidgetType.MESSAGE_CAMPAIGN_BODY),
+ ]}
+ />,
+ );
+
+ expect(
+ screen
+ .getByTestId('message-campaign-body')
+ .closest('.page-layout-viewport-filling-widget-slot'),
+ ).toBeNull();
+ expect(
+ screen.getByTestId('message-campaign-body-sortable-cell'),
+ ).toHaveAttribute('data-fill', 'false');
+ });
+
it('gives a lone Canvas front component viewport-filling sizing', () => {
mockLayoutMode = PageLayoutTabLayoutMode.CANVAS;
diff --git a/packages/twenty-front/src/modules/page-layout/widgets/utils/__tests__/isViewportFillingWidgetType.test.ts b/packages/twenty-front/src/modules/page-layout/widgets/utils/__tests__/isViewportFillingWidgetType.test.ts
index 155c1a094cd..1fb4ea39040 100644
--- a/packages/twenty-front/src/modules/page-layout/widgets/utils/__tests__/isViewportFillingWidgetType.test.ts
+++ b/packages/twenty-front/src/modules/page-layout/widgets/utils/__tests__/isViewportFillingWidgetType.test.ts
@@ -14,7 +14,7 @@ const expectedIsViewportFillingByWidgetType = {
[WidgetType.FRONT_COMPONENT]: false,
[WidgetType.GRAPH]: false,
[WidgetType.IFRAME]: false,
- [WidgetType.MESSAGE_CAMPAIGN_BODY]: true,
+ [WidgetType.MESSAGE_CAMPAIGN_BODY]: false,
[WidgetType.MESSAGE_CAMPAIGN_DETAILS]: false,
[WidgetType.NOTES]: true,
[WidgetType.RECORD_TABLE]: false,
diff --git a/packages/twenty-front/src/modules/page-layout/widgets/utils/isViewportFillingWidgetType.ts b/packages/twenty-front/src/modules/page-layout/widgets/utils/isViewportFillingWidgetType.ts
index 86f025c8d1d..8439f0e000d 100644
--- a/packages/twenty-front/src/modules/page-layout/widgets/utils/isViewportFillingWidgetType.ts
+++ b/packages/twenty-front/src/modules/page-layout/widgets/utils/isViewportFillingWidgetType.ts
@@ -10,7 +10,6 @@ export const isViewportFillingWidgetType = (
case WidgetType.EMAILS:
case WidgetType.EMAIL_THREAD:
case WidgetType.FILES:
- case WidgetType.MESSAGE_CAMPAIGN_BODY:
case WidgetType.NOTES:
case WidgetType.TASKS:
case WidgetType.TIMELINE:
@@ -27,6 +26,10 @@ export const isViewportFillingWidgetType = (
// Record tables keep their own interactive frame and are not collapsed.
return false;
+ case WidgetType.MESSAGE_CAMPAIGN_BODY:
+ // Campaign documents grow with their content so the tab owns scrolling.
+ return false;
+
case WidgetType.MESSAGE_CAMPAIGN_DETAILS:
// This type is classified even though it currently renders no content.
return false;