Skip to content

The open alternative to Salesforce, designed for AI.

chore: remove useless and stale comments (#27026)

Charles Bochet29be6c685c75
diff --git a/packages/create-twenty-app/jest.config.mjs b/packages/create-twenty-app/jest.config.mjs
index ee70ebd6536..a1ae5c35910 100644
--- a/packages/create-twenty-app/jest.config.mjs
+++ b/packages/create-twenty-app/jest.config.mjs
@@ -30,11 +30,7 @@ const jestConfig = {
'/node_modules/',
'<rootDir>/src/constants/template/',
],
- collectCoverageFrom: [
- 'src/**/*.{ts,js}',
- '!src/**/*.d.ts',
- '!src/cli.ts', // Exclude CLI entry point from coverage
- ],
+ collectCoverageFrom: ['src/**/*.{ts,js}', '!src/**/*.d.ts', '!src/cli.ts'],
coverageThreshold: {
global: {
statements: 1,
diff --git a/packages/create-twenty-app/src/utils/__tests__/app-template.spec.ts b/packages/create-twenty-app/src/utils/__tests__/app-template.spec.ts
index 13671eebd43..cf592802f13 100644
--- a/packages/create-twenty-app/src/utils/__tests__/app-template.spec.ts
+++ b/packages/create-twenty-app/src/utils/__tests__/app-template.spec.ts
@@ -110,7 +110,6 @@ describe('copyBaseApplicationProject', () => {
expect(content).not.toContain('DESCRIPTION-TO-BE-GENERATED');
expect(content).not.toContain('UUID-TO-BE-GENERATED');
- // Both UUIDs should be valid v4 format
const uuidMatches = content.match(
/[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}/g,
);
diff --git a/packages/twenty-agent-skills/scripts/__tests__/source-validation.spec.js b/packages/twenty-agent-skills/scripts/__tests__/source-validation.spec.js
index 17747e86c11..6ba8aa3ad0a 100644
--- a/packages/twenty-agent-skills/scripts/__tests__/source-validation.spec.js
+++ b/packages/twenty-agent-skills/scripts/__tests__/source-validation.spec.js
@@ -60,10 +60,6 @@ const withExtraFile = (filePath, contents, body) => {
}
};
-// ---------------------------------------------------------------------------
-// Smoke tests — every assertion should pass on the current plugin state.
-// ---------------------------------------------------------------------------
-
test('assertJsonMetadata passes on current state', () => {
assert.deepStrictEqual(collectFailures(metadata.assertJsonMetadata), []);
});
@@ -214,10 +210,6 @@ test('assertSetupHelper passes on current state', () => {
assert.deepStrictEqual(collectFailures(setupHelper.assertSetupHelper), []);
});
-// ---------------------------------------------------------------------------
-// Negative cases — each assertion catches its targeted failure.
-// ---------------------------------------------------------------------------
-
test('assertJsonMetadata catches version mismatch between package.json and plugin.json', () => {
withJsonMutation(PACKAGE_JSON_PATH, (pkg) => { pkg.version = '99.99.99'; }, () => {
const failures = collectFailures(metadata.assertJsonMetadata);
diff --git a/packages/twenty-apps/examples/document-generator/src/logic-functions/handlers/generate-document-handler.ts b/packages/twenty-apps/examples/document-generator/src/logic-functions/handlers/generate-document-handler.ts
index e29dbe4a965..5bf58770136 100644
--- a/packages/twenty-apps/examples/document-generator/src/logic-functions/handlers/generate-document-handler.ts
+++ b/packages/twenty-apps/examples/document-generator/src/logic-functions/handlers/generate-document-handler.ts
@@ -12,7 +12,6 @@ import {
} from 'src/logic-functions/utils/load-record-values';
import { renderTemplate } from 'src/logic-functions/utils/render-template';
-// Builds a filesystem-safe PDF filename from the document name.
const toPdfFileName = (documentName: string): string => {
const slug = documentName
.normalize('NFKD')
diff --git a/packages/twenty-apps/examples/document-generator/src/logic-functions/utils/generate-document-pdf.ts b/packages/twenty-apps/examples/document-generator/src/logic-functions/utils/generate-document-pdf.ts
index 3ea1975e75a..860213ca2d5 100644
--- a/packages/twenty-apps/examples/document-generator/src/logic-functions/utils/generate-document-pdf.ts
+++ b/packages/twenty-apps/examples/document-generator/src/logic-functions/utils/generate-document-pdf.ts
@@ -7,9 +7,8 @@ import {
StandardFonts,
} from 'pdf-lib';
-// Renders a document (title + Markdown body) into a marketable, multi-page A4
-// PDF using pdf-lib: a coloured header band, real typography, bold/italic runs,
-// headings and lists.
+// Renders Markdown content into a multi-page A4 PDF using pdf-lib, with
+// bold/italic runs, headings and lists.
const PAGE_WIDTH = 595.28; // A4
const PAGE_HEIGHT = 841.89;
@@ -58,7 +57,6 @@ const pickFont = (fonts: Fonts, run: Run): PDFFont => {
return fonts.regular;
};
-// Flatten marked inline tokens into styled runs.
const toRuns = (
tokens: Token[] | undefined,
style: Omit<Run, 'text'>,
@@ -316,7 +314,6 @@ export const generateDocumentPdf = async (
const ctx: Ctx = { pdf, page: pdf.addPage([PAGE_WIDTH, PAGE_HEIGHT]), y: 0, fonts };
- // Render the template content only — no title header or footer.
ctx.y = PAGE_HEIGHT - MARGIN;
// Match the HTML renderer (breaks: true) so a single newline in a template
diff --git a/packages/twenty-apps/examples/media-notes/playwright.config.ts b/packages/twenty-apps/examples/media-notes/playwright.config.ts
index df73daf6a40..682703c5eb9 100644
--- a/packages/twenty-apps/examples/media-notes/playwright.config.ts
+++ b/packages/twenty-apps/examples/media-notes/playwright.config.ts
@@ -1,7 +1,6 @@
import { defineConfig, devices } from '@playwright/test';
import * as path from 'path';
-// Front-end base URL of the running Twenty instance under test.
const FRONT_BASE_URL = process.env.FRONT_BASE_URL ?? 'http://localhost:3001';
export default defineConfig({
diff --git a/packages/twenty-apps/examples/postcard/e2e/card-front-component.spec.ts b/packages/twenty-apps/examples/postcard/e2e/card-front-component.spec.ts
index b219030b447..da649b06e66 100644
--- a/packages/twenty-apps/examples/postcard/e2e/card-front-component.spec.ts
+++ b/packages/twenty-apps/examples/postcard/e2e/card-front-component.spec.ts
@@ -103,16 +103,12 @@ test.describe('Postcard card front component', () => {
// verifying the computed styles proves the component's own render + the
// remote-dom style bridge ran end-to-end (not just that text leaked onto the
// page). These mirror card.front-component.tsx exactly.
-
- // Root container.
await expect(card).toHaveCSS('padding', '24px');
- // Name.
await expect(cardName).toHaveCSS('font-size', '15px');
await expect(cardName).toHaveCSS('font-weight', '600');
await expect(cardName).toHaveCSS('color', 'rgb(51, 51, 51)');
- // Status badge: white text on a status-dependent colored, rounded chip.
await expect(cardStatus).toHaveCSS('color', 'rgb(255, 255, 255)');
await expect(cardStatus).toHaveCSS('font-size', '11px');
await expect(cardStatus).toHaveCSS('font-weight', '600');
@@ -129,7 +125,6 @@ test.describe('Postcard card front component', () => {
);
}
- // Content.
await expect(cardContent).toHaveCSS('font-size', '14px');
await expect(cardContent).toHaveCSS('color', 'rgb(85, 85, 85)');
await expect(cardContent).toHaveCSS('margin', '0px');
diff --git a/packages/twenty-apps/examples/postcard/playwright.config.ts b/packages/twenty-apps/examples/postcard/playwright.config.ts
index 69d0fd8984b..299e092ea3d 100644
--- a/packages/twenty-apps/examples/postcard/playwright.config.ts
+++ b/packages/twenty-apps/examples/postcard/playwright.config.ts
@@ -9,7 +9,6 @@ import * as path from 'path';
// WebKit actually reads); the browser process Playwright spawns inherits it.
process.env.TZ = 'Europe/Paris';
-// Front-end base URL of the running Twenty instance under test.
const FRONT_BASE_URL = process.env.FRONT_BASE_URL ?? 'http://localhost:3001';
export default defineConfig({
diff --git a/packages/twenty-apps/examples/postcard/src/fields/person-can-receive-postcards.field.ts b/packages/twenty-apps/examples/postcard/src/fields/person-can-receive-postcards.field.ts
index 0a7abb93486..3f61c576751 100644
--- a/packages/twenty-apps/examples/postcard/src/fields/person-can-receive-postcards.field.ts
+++ b/packages/twenty-apps/examples/postcard/src/fields/person-can-receive-postcards.field.ts
@@ -1,6 +1,6 @@
import { defineField, FieldType, STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS } from 'twenty-sdk/define';
-// Field on existing company object
+// Field on existing person object
export default defineField({
universalIdentifier: 'f922fdb8-10a9-4f11-a1d0-992a779f6dff',
objectUniversalIdentifier:
diff --git a/packages/twenty-apps/fixtures/rich-app/src/fields/company-can-receive-postcards.field.ts b/packages/twenty-apps/fixtures/rich-app/src/fields/company-can-receive-postcards.field.ts
index 45a297ff652..96ce4235cc3 100644
--- a/packages/twenty-apps/fixtures/rich-app/src/fields/company-can-receive-postcards.field.ts
+++ b/packages/twenty-apps/fixtures/rich-app/src/fields/company-can-receive-postcards.field.ts
@@ -1,6 +1,5 @@
import { defineField, FieldType, STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS } from 'twenty-sdk/define';
-// Field on existing company object
export default defineField({
universalIdentifier: 'f922fdb8-10a9-4f11-a1d0-992a779f6dff',
objectUniversalIdentifier:
diff --git a/packages/twenty-apps/public/call-recorder/src/__tests__/call-recorder-lifecycle.integration-test.ts b/packages/twenty-apps/public/call-recorder/src/__tests__/call-recorder-lifecycle.integration-test.ts
index 8a89b5feb52..6bee7644cd0 100644
--- a/packages/twenty-apps/public/call-recorder/src/__tests__/call-recorder-lifecycle.integration-test.ts
+++ b/packages/twenty-apps/public/call-recorder/src/__tests__/call-recorder-lifecycle.integration-test.ts
@@ -43,7 +43,6 @@ import { cancelScheduledRecallBots } from 'src/logic-functions/flows/cancel-sche
import { syncCalendarBotSchedulingHandler } from 'src/logic-functions/sync-calendar-bot-scheduling';
import reconcileCalendarEventLogicFunction from 'src/logic-functions/reconcile-call-recorder-calendar-event';
-// ---------------------------------------------------------------------------
// Call Recorder end-to-end behavior against a live Twenty server.
//
// The app is installed on the test server by the vitest global setup, and all
@@ -60,7 +59,6 @@ import reconcileCalendarEventLogicFunction from 'src/logic-functions/reconcile-c
// The suite issues a few hundred API requests; if the test server runs with
// the default API_RATE_LIMITING_LONG_LIMIT of 100 requests per minute,
// raise it (e.g. to 100000) or the runs trip the limiter.
-// ---------------------------------------------------------------------------
const WORKSPACE_API_KEY_ENV = 'TWENTY_API_KEY';
const RECALL_BASE_URL = 'https://us-west-2.recall.ai/api/v1';
@@ -247,11 +245,9 @@ const hoursAgo = (hours: number) =>
new Date(Date.now() - hours * 60 * 60 * 1000).toISOString();
const daysAgo = (days: number) => hoursAgo(days * 24);
-// ---------------------------------------------------------------------------
// Recall API fake, installed as a fetch interceptor. Twenty API traffic falls
// through to the real fetch, except the metadata enqueueJobs mutation, which is
// captured here so fanned-out jobs do not run inside the test.
-// ---------------------------------------------------------------------------
type FakeRecallBotStatusChange = {
code: string;
@@ -729,10 +725,6 @@ class FakeRecallApi {
const jsonResponse = (status: number, body: object): Response =>
new Response(JSON.stringify(body), { status });
-// ---------------------------------------------------------------------------
-// Recall webhook payloads, mirroring the shapes Recall actually delivers.
-// ---------------------------------------------------------------------------
-
const buildBotMetadata = (callRecordingId: string, workspaceId: string) => ({
twentyWorkspaceId: workspaceId,
twentyCallRecordingId: callRecordingId,
@@ -813,11 +805,6 @@ const buildTranscriptDoneWebhook = ({
},
});
-// ---------------------------------------------------------------------------
-// Test workspace helpers: real rows in the test database, cleaned up or
-// restored after each scenario.
-// ---------------------------------------------------------------------------
-
describe('call recorder app lifecycle (integration)', () => {
// Built before the fetch interceptor is installed so the shared client's
// Twenty API traffic always uses the real fetch.
diff --git a/packages/twenty-apps/public/linear/src/components/create-issue-form.front-component.tsx b/packages/twenty-apps/public/linear/src/components/create-issue-form.front-component.tsx
index 84fbdaa387c..75c4c36f5fd 100644
--- a/packages/twenty-apps/public/linear/src/components/create-issue-form.front-component.tsx
+++ b/packages/twenty-apps/public/linear/src/components/create-issue-form.front-component.tsx
@@ -768,7 +768,6 @@ const CreateIssueForm = () => {
<div style={STYLES.outer}>
<style>{'@keyframes spin{to{transform:rotate(360deg)}}'}</style>
<div style={STYLES.container}>
- {/* Top bar with team selector */}
<div style={STYLES.topBar}>
<select
value={teamId}
@@ -789,10 +788,8 @@ const CreateIssueForm = () => {
)}
</div>
- {/* Property chips & labels */}
<div style={STYLES.labelPicker}>
<div style={STYLES.chipsRow}>
- {/* Status */}
{hasStatuses && !optionsLoading && (
<label style={STYLES.chip}>
<span style={STYLES.chipIcon}>{stateIcon}</span>
@@ -811,7 +808,6 @@ const CreateIssueForm = () => {
</label>
)}
- {/* Priority */}
<label style={STYLES.chip}>
<span style={STYLES.chipIcon}>{'≡'}</span>
<select
@@ -827,7 +823,6 @@ const CreateIssueForm = () => {
</select>
</label>
- {/* Assignee */}
<label style={STYLES.chip}>
<span style={STYLES.chipIcon}>{'⬤'}</span>
<select
@@ -845,7 +840,6 @@ const CreateIssueForm = () => {
</select>
</label>
- {/* Estimate */}
{hasEstimates && (
<label style={STYLES.chip}>
<span style={STYLES.chipIcon}>{'△'}</span>
@@ -865,7 +859,6 @@ const CreateIssueForm = () => {
</label>
)}
- {/* Labels toggle */}
{options.labels.length > 0 && (
<button
type="button"
@@ -884,7 +877,6 @@ const CreateIssueForm = () => {
</button>
)}
- {/* Cycle */}
{options.cycles.length > 0 && (
<label style={STYLES.chip}>
<span style={STYLES.chipIcon}>{'▶'}</span>
@@ -904,7 +896,6 @@ const CreateIssueForm = () => {
</label>
)}
- {/* Due date */}
<input
value={dueDate}
onChange={onValueChange(setDueDate)}
@@ -912,7 +903,6 @@ const CreateIssueForm = () => {
type="date"
/>
- {/* Project */}
{options.projects.length > 0 && (
<label style={STYLES.chip}>
<span style={STYLES.chipIcon}>{'⬡'}</span>
diff --git a/packages/twenty-apps/public/linear/src/constants/universal-identifiers.ts b/packages/twenty-apps/public/linear/src/constants/universal-identifiers.ts
index b32feeb8a58..2d191d11196 100644
--- a/packages/twenty-apps/public/linear/src/constants/universal-identifiers.ts
+++ b/packages/twenty-apps/public/linear/src/constants/universal-identifiers.ts
@@ -1,8 +1,3 @@
-// Group all universal identifiers in a single file. Per the codebase
-// convention (see twenty-for-twenty), closely-related constants live
-// together so the rest of the app's source files can stay at one
-// `export default` per file.
-
export const APPLICATION_UNIVERSAL_IDENTIFIER =
'6f4e7c2a-3d8e-4a91-b2cf-9e0b8d5f4a2e';
diff --git a/packages/twenty-docs/navigation/supported-languages.ts b/packages/twenty-docs/navigation/supported-languages.ts
index 7ec016d6b1c..72f2ba4f30e 100644
--- a/packages/twenty-docs/navigation/supported-languages.ts
+++ b/packages/twenty-docs/navigation/supported-languages.ts
@@ -1,4 +1,3 @@
-// Re-export from twenty-shared (source of truth)
// Using relative path because these scripts run via tsx from workspace root
export { DOCUMENTATION_DEFAULT_LANGUAGE as DEFAULT_LANGUAGE } from '../../twenty-shared/src/constants/DocumentationDefaultLanguage';
export {
diff --git a/packages/twenty-docs/scripts/generate-documentation-paths.ts b/packages/twenty-docs/scripts/generate-documentation-paths.ts
index 81fe99ffbbe..a25dee81faf 100644
--- a/packages/twenty-docs/scripts/generate-documentation-paths.ts
+++ b/packages/twenty-docs/scripts/generate-documentation-paths.ts
@@ -74,12 +74,10 @@ const AUTO_GENERATED_HEADER = `/*
`;
-// Generate DocumentationPaths.ts
const pathEntries = sortedPaths
.map((docPath) => {
const constName = pathToConstantName(docPath);
const value = `'/${docPath}'`;
- // Check if line would be too long (80 char limit)
if (` ${constName}: ${value},`.length > 80) {
return ` ${constName}:\n ${value},`;
}
diff --git a/packages/twenty-docs/scripts/generate-halftone-illustrations.mjs b/packages/twenty-docs/scripts/generate-halftone-illustrations.mjs
index 8f944cd9135..fec8b9e2ab9 100644
--- a/packages/twenty-docs/scripts/generate-halftone-illustrations.mjs
+++ b/packages/twenty-docs/scripts/generate-halftone-illustrations.mjs
@@ -1,11 +1,5 @@
-/**
- * Converts existing User Guide illustrations into halftone style.
- * Uses Playwright to run a canvas-based halftone filter in the browser.
- * No dev server needed.
- *
- * Usage:
- * node packages/twenty-docs/scripts/generate-halftone-illustrations.mjs
- */
+// Usage: node packages/twenty-docs/scripts/generate-halftone-illustrations.mjs
+// Runs the halftone canvas filter in headless Playwright, so no dev server is needed.
import { chromium } from 'playwright';
import { writeFileSync, readFileSync, mkdirSync } from 'fs';
@@ -27,7 +21,6 @@ const ILLUSTRATIONS = [
{ name: 'permissions', source: 'user-guide/permissions/permissions.png' },
{ name: 'billing', source: 'user-guide/setup/pricing.png' },
{ name: 'settings', source: 'user-guide/setup/settings.png' },
- // Developers section
{ name: 'dev-apps', source: 'user-guide/integrations/plug.png' },
{ name: 'dev-api', source: 'user-guide/api/api-overview.png' },
{ name: 'dev-self-host', source: 'user-guide/what-is-twenty/20.png' },
@@ -73,7 +66,6 @@ async function main() {
const outW = width * scale;
const outH = height * scale;
- // Read source pixels
const tmp = document.createElement('canvas');
tmp.width = width;
tmp.height = height;
@@ -81,7 +73,6 @@ async function main() {
tmpCtx.drawImage(img, 0, 0);
const px = tmpCtx.getImageData(0, 0, width, height).data;
- // Output canvas
const out = document.createElement('canvas');
out.width = outW;
out.height = outH;
diff --git a/packages/twenty-docs/scripts/prune-orphan-translations.ts b/packages/twenty-docs/scripts/prune-orphan-translations.ts
index 96d6278f368..02fbd9f36ed 100644
--- a/packages/twenty-docs/scripts/prune-orphan-translations.ts
+++ b/packages/twenty-docs/scripts/prune-orphan-translations.ts
@@ -39,7 +39,6 @@ const isLocalizedFile = (file: string): boolean =>
// English source path a localized file mirrors: strip the leading `<lang>/`.
const sourcePathOf = (localizedFile: string): string => {
const segments = path.relative(DOCS_ROOT, localizedFile).split(path.sep);
- // segments[0] is the language code; the rest is the source-relative path.
return path.join(DOCS_ROOT, ...segments.slice(1));
};
@@ -80,7 +79,6 @@ const main = (): void => {
return;
}
- // Per-language blast-radius check.
const filesByLanguage = new Map<string, number>();
const orphansByLanguage = new Map<string, number>();
for (const file of localizedFiles) {
diff --git a/packages/twenty-e2e-testing/playwright.config.ts b/packages/twenty-e2e-testing/playwright.config.ts
index cfa5fa4ac0b..6d3346dbbb3 100644
--- a/packages/twenty-e2e-testing/playwright.config.ts
+++ b/packages/twenty-e2e-testing/playwright.config.ts
@@ -11,26 +11,21 @@ if (envResult.error) {
throw new Error('Failed to load .env file');
}
-/* === Run your local dev server before starting the tests === */
-
-/**
- * See https://playwright.dev/docs/test-configuration.
- */
export default defineConfig({
testDir: './tests',
- outputDir: 'run_results/', // directory for screenshots and videos
- snapshotPathTemplate: '{testDir}/__screenshots__/{testFilePath}/{arg}{ext}', // just in case, do not delete it
- fullyParallel: false, // parallelization of tests will be done later in the future
+ outputDir: 'run_results/',
+ snapshotPathTemplate: '{testDir}/__screenshots__/{testFilePath}/{arg}{ext}',
+ fullyParallel: false,
forbidOnly: !!process.env.CI,
retries: process.env.CI ? 2 : 0,
workers: 1, // 1 worker = 1 test at the time, tests can't be parallelized
- timeout: process.env.CI ? 60_000 : 30 * 1000, // timeout can be changed
+ timeout: process.env.CI ? 60_000 : 30 * 1000,
use: {
baseURL: process.env.FRONTEND_BASE_URL || 'http://localhost:3001',
trace: 'retain-on-failure', // trace takes EVERYTHING from page source, records every single step, should be used only when normal debugging won't work
screenshot: 'on', // either 'on' here or in different method in modules, if 'on' all screenshots are overwritten each time the test is run
headless: true, // instead of changing it to false, run 'yarn test:e2e:debug' or 'yarn test:e2e:ui'
- testIdAttribute: 'data-testid', // taken from Twenty source
+ testIdAttribute: 'data-testid',
},
expect: {
// CI runners are slow enough that post-mutation UI transitions routinely
@@ -51,34 +46,9 @@ export default defineConfig({
use: {
...devices['Desktop Chrome'],
permissions: ['clipboard-read', 'clipboard-write'],
- storageState: AUTH_STORAGE_STATE_PATH, // takes saved cookies from directory
+ storageState: AUTH_STORAGE_STATE_PATH,
},
dependencies: ['setup'],
},
-
- //{
- // name: 'webkit',
- // use: { ...devices['Desktop Safari'] },
- //},
-
- /* Test against mobile viewports. */
- // {
- // name: 'Mobile Chrome',
- // use: { ...devices['Pixel 5'] },
- // },
- // {
- // name: 'Mobile Safari',
- // use: { ...devices['iPhone 12'] },
- // },
-
- /* Test against branded browsers. */
- //{
- // name: 'Microsoft Edge',
- // use: { ...devices['Desktop Edge'], channel: 'msedge' },
- //},
- //{
- // name: 'Google Chrome',
- // use: { ...devices['Desktop Chrome'], channel: 'chrome' },
- //},
],
});
diff --git a/packages/twenty-e2e-testing/tests/create-record.spec.ts b/packages/twenty-e2e-testing/tests/create-record.spec.ts
index f79e1c2b67e..85d693469a3 100644
--- a/packages/twenty-e2e-testing/tests/create-record.spec.ts
+++ b/packages/twenty-e2e-testing/tests/create-record.spec.ts
@@ -69,7 +69,6 @@ test('Create and update record', async ({ page }) => {
await page.goto('/objects/people');
await page.getByRole('button', { name: 'Create Person' }).click();
- // Generate a random email for testing
const randomEmail = `testuser_${Math.random().toString(36).substring(2, 10)}@example.com`;
// Fill the record creation form in the side panel
@@ -104,7 +103,6 @@ test('Create and update record', async ({ page }) => {
timeout: 15_000,
});
- // Fill intro
const introInput = recordFieldList.getByText('Intro', { exact: true }).nth(1);
await expect(introInput).toBeVisible();
await introInput.click({ force: true });
@@ -112,7 +110,6 @@ test('Create and update record', async ({ page }) => {
await page.getByPlaceholder('Intro').fill('This is an intro');
await page.getByPlaceholder('Intro').press('Enter');
- // Fill URL
await recordFieldList.getByText('Linkedin', { exact: true }).first().click();
const urlInput = recordFieldList.getByText('Linkedin', { exact: true }).nth(1);
await expect(urlInput).toBeVisible();
@@ -120,7 +117,6 @@ test('Create and update record', async ({ page }) => {
await page.getByPlaceholder('URL').fill('linkedin.com/johndoe');
await page.getByPlaceholder('URL').press('Enter');
- // Click on 4th star to rate
await recordFieldList
.getByText('Performance Rating', { exact: true })
.first()
@@ -128,7 +124,6 @@ test('Create and update record', async ({ page }) => {
const ratingContainer = recordFieldList.locator('div[aria-label="Rating"]');
await ratingContainer.locator('svg').nth(3).click({ force: true });
- // Fill phone field
await recordFieldList.getByText('Phones', { exact: true }).first().click();
const phoneInput = recordFieldList.getByText('Phones', { exact: true }).nth(1);
await expect(phoneInput).toBeVisible();
@@ -136,7 +131,6 @@ test('Create and update record', async ({ page }) => {
await page.getByPlaceholder('Phone').fill('+336 1 122 3344');
await page.getByPlaceholder('Phone').press('Enter');
- // Fill work preference
await recordFieldList
.getByText('Work Preference', { exact: true })
.first()
@@ -157,7 +151,6 @@ test('Create and update record', async ({ page }) => {
await page.waitForURL(/\/object\/person\//);
const newPersonId = page.url().match(/\/object\/person\/([a-f0-9-]+)/)?.[1];
- // Check data was saved
const findOnePersonResponse = await postBackendGraphQL<FindOnePersonData>({
page,
data: {
diff --git a/packages/twenty-e2e-testing/tests/login.setup.ts b/packages/twenty-e2e-testing/tests/login.setup.ts
index add681c175c..af8252c6fde 100644
--- a/packages/twenty-e2e-testing/tests/login.setup.ts
+++ b/packages/twenty-e2e-testing/tests/login.setup.ts
@@ -2,7 +2,6 @@ import { test as base, expect } from '@playwright/test';
import { AUTH_STORAGE_STATE_PATH } from '../lib/constants/authStorageStatePath';
import { LoginPage } from '../lib/pom/loginPage';
-// fixture
const test = base.extend<{ loginPage: LoginPage }>({
loginPage: async ({ page }, use) => {
const loginPage = new LoginPage(page);
diff --git a/packages/twenty-e2e-testing/tests/workflow-creation.spec.ts b/packages/twenty-e2e-testing/tests/workflow-creation.spec.ts
index 953b133ef96..de42abbb7da 100644
--- a/packages/twenty-e2e-testing/tests/workflow-creation.spec.ts
+++ b/packages/twenty-e2e-testing/tests/workflow-creation.spec.ts
@@ -43,7 +43,6 @@ test('Create workflow', async ({ page }) => {
.getByTestId('top-bar-title')
.getByText(NEW_WORKFLOW_NAME);
- // Wait for the name to be visible and not hidden
await workflowName.waitFor({ state: 'visible' });
await expect(workflowName).toBeVisible();
diff --git a/packages/twenty-front-component-renderer/.storybook/vitest.setup.ts b/packages/twenty-front-component-renderer/.storybook/vitest.setup.ts
index b5c33e4c70b..d23d08fa04f 100644
--- a/packages/twenty-front-component-renderer/.storybook/vitest.setup.ts
+++ b/packages/twenty-front-component-renderer/.storybook/vitest.setup.ts
@@ -1,6 +1,4 @@
import { setProjectAnnotations } from '@storybook/react-vite';
import * as projectAnnotations from './preview';
-// This is an important step to apply the right configuration when testing your stories.
-// More info at: https://storybook.js.org/docs/api/portable-stories/portable-stories-vitest#setprojectannotations
setProjectAnnotations([projectAnnotations]);
diff --git a/packages/twenty-front-component-renderer/src/constants/AllowedHtmlElements.ts b/packages/twenty-front-component-renderer/src/constants/AllowedHtmlElements.ts
index 4b719ed074f..39fab48cad4 100644
--- a/packages/twenty-front-component-renderer/src/constants/AllowedHtmlElements.ts
+++ b/packages/twenty-front-component-renderer/src/constants/AllowedHtmlElements.ts
@@ -271,7 +271,6 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
},
- // Semantic inline text
{ tag: 'html-b', name: 'HtmlB', properties: {} },
{ tag: 'html-i', name: 'HtmlI', properties: {} },
{ tag: 'html-u', name: 'HtmlU', properties: {} },
@@ -295,7 +294,6 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
},
- // Edited/annotated text
{
tag: 'html-del',
name: 'HtmlDel',
@@ -327,17 +325,14 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
},
- // Ruby annotations
{ tag: 'html-ruby', name: 'HtmlRuby', properties: {} },
{ tag: 'html-rt', name: 'HtmlRt', properties: {} },
{ tag: 'html-rp', name: 'HtmlRp', properties: {} },
- // Description lists
{ tag: 'html-dl', name: 'HtmlDl', properties: {} },
{ tag: 'html-dt', name: 'HtmlDt', properties: {} },
{ tag: 'html-dd', name: 'HtmlDd', properties: {} },
- // Structural/semantic
{ tag: 'html-figure', name: 'HtmlFigure', properties: {} },
{ tag: 'html-figcaption', name: 'HtmlFigcaption', properties: {} },
{
@@ -361,7 +356,6 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
{ tag: 'html-hgroup', name: 'HtmlHgroup', properties: {} },
{ tag: 'html-search', name: 'HtmlSearch', properties: {} },
- // Table additions
{ tag: 'html-caption', name: 'HtmlCaption', properties: {} },
{
tag: 'html-colgroup',
@@ -378,7 +372,6 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
},
- // Form additions
{
tag: 'html-fieldset',
name: 'HtmlFieldset',
@@ -426,7 +419,6 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
{ tag: 'html-datalist', name: 'HtmlDatalist', properties: {} },
- // Media additions
{ tag: 'html-picture', name: 'HtmlPicture', properties: {} },
{
tag: 'html-track',
@@ -440,11 +432,9 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
},
- // Miscellaneous
{ tag: 'html-wbr', name: 'HtmlWbr', properties: {} },
{ tag: 'html-menu', name: 'HtmlMenu', properties: {} },
- // SVG container/structural
{
tag: 'html-svg',
name: 'HtmlSvg',
@@ -499,7 +489,6 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
},
- // SVG shapes
{
tag: 'html-circle',
name: 'HtmlCircle',
@@ -570,7 +559,6 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
},
- // SVG text
{
tag: 'html-text',
name: 'HtmlText',
@@ -596,7 +584,6 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
},
- // SVG gradients/patterns
{
tag: 'html-lineargradient',
name: 'HtmlLinearGradient',
@@ -646,7 +633,6 @@ export const ALLOWED_HTML_ELEMENTS: AllowedHtmlElement[] = [
},
},
- // SVG other
{
tag: 'html-image',
name: 'HtmlImage',
diff --git a/packages/twenty-front/.storybook/vitest.setup.ts b/packages/twenty-front/.storybook/vitest.setup.ts
index 757baca50da..44a048c6162 100644
--- a/packages/twenty-front/.storybook/vitest.setup.ts
+++ b/packages/twenty-front/.storybook/vitest.setup.ts
@@ -35,6 +35,4 @@ import('@/object-record/record-field/ui/meta-types/input/components/RichTextFiel
import('@/navigation-menu-item/display/sections/favorites/components/FavoritesSectionDispatcher');
import('@/navigation-menu-item/display/sections/workspace/components/WorkspaceSectionDispatcher');
-// This is an important step to apply the right configuration when testing your stories.
-// More info at: https://storybook.js.org/docs/api/portable-stories/portable-stories-vitest#setprojectannotations
setProjectAnnotations([projectAnnotations]);
diff --git a/packages/twenty-front/setupTests.ts b/packages/twenty-front/setupTests.ts
index d8940fa9783..aa6ef48e753 100644
--- a/packages/twenty-front/setupTests.ts
+++ b/packages/twenty-front/setupTests.ts
@@ -68,13 +68,7 @@ declare global {
}
}
-/**
- * The structuredClone global function is not available in jsdom, it needs to be mocked for now.
- *
- * The most naive way to mock structuredClone is to use JSON.stringify and JSON.parse. This works
- * for arguments with simple types like primitives, arrays and objects, but doesn't work with functions,
- * Map, Set, etc.
- */
+// jsdom has no structuredClone; this JSON round-trip drops functions, Map, Set, etc.
global.structuredClone = (val) => {
return JSON.parse(JSON.stringify(val));
};
diff --git a/packages/twenty-front/src/modules/activities/hooks/useRefreshShowPageFindManyActivitiesQueries.ts b/packages/twenty-front/src/modules/activities/hooks/useRefreshShowPageFindManyActivitiesQueries.ts
index db557c279a3..d5354c169e5 100644
--- a/packages/twenty-front/src/modules/activities/hooks/useRefreshShowPageFindManyActivitiesQueries.ts
+++ b/packages/twenty-front/src/modules/activities/hooks/useRefreshShowPageFindManyActivitiesQueries.ts
@@ -4,9 +4,7 @@ import { type CoreObjectNameSingular } from 'twenty-shared/types';
import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';
import { isDefined } from 'twenty-shared/utils';
-// This hook should only be executed if the normalized cache is up-to-date
-// It will take a targetableObject and prepare the queries for the activities
-// based on the activityTargets of the targetableObject
+// Only run this once the normalized cache is up-to-date.
export const useRefreshShowPageFindManyActivitiesQueries = ({
activityObjectNameSingular,
}: {
diff --git a/packages/twenty-front/src/modules/activities/timeline-activities/utils/getTimelineActivityAction.ts b/packages/twenty-front/src/modules/activities/timeline-activities/utils/getTimelineActivityAction.ts
index 02af7ceb23c..0329c1b8694 100644
--- a/packages/twenty-front/src/modules/activities/timeline-activities/utils/getTimelineActivityAction.ts
+++ b/packages/twenty-front/src/modules/activities/timeline-activities/utils/getTimelineActivityAction.ts
@@ -20,8 +20,7 @@ export const getTimelineActivityAction = (
return timelineActivityType.action;
}
- // A 2.33 pod can create a name-only row after the one-time 2.34 backfill
- // while both versions overlap. This fallback disappears with the 2.35 drop.
+ // TODO: remove this legacy name fallback, the name field was dropped in 2.35.
return isDefined(timelineActivity.name)
? parseTimelineActivityAction(timelineActivity.name)
: null;
diff --git a/packages/twenty-front/src/modules/advanced-text-editor/components/__stories__/AdvancedTextEditor.stories.tsx b/packages/twenty-front/src/modules/advanced-text-editor/components/__stories__/AdvancedTextEditor.stories.tsx
index c827c936e72..1250fddbe51 100644
--- a/packages/twenty-front/src/modules/advanced-text-editor/components/__stories__/AdvancedTextEditor.stories.tsx
+++ b/packages/twenty-front/src/modules/advanced-text-editor/components/__stories__/AdvancedTextEditor.stories.tsx
@@ -61,9 +61,7 @@ const EditorWrapper = ({
url: `https://via.placeholder.com/400x200?text=${encodeURIComponent(file.name)}`,
};
},
- onImageUploadError: (_error: Error, _file: File) => {
- // Handle image upload error
- },
+ onImageUploadError: (_error: Error, _file: File) => {},
});
if (!editor) {
diff --git a/packages/twenty-front/src/modules/app/effect-components/PageChangeEffect.tsx b/packages/twenty-front/src/modules/app/effect-components/PageChangeEffect.tsx
index 23272dbc450..344465324b8 100644
--- a/packages/twenty-front/src/modules/app/effect-components/PageChangeEffect.tsx
+++ b/packages/twenty-front/src/modules/app/effect-components/PageChangeEffect.tsx
@@ -41,7 +41,6 @@ import { getPageLayoutIdForLocation } from '~/modules/app/utils/getPageLayoutIdF
import { isMatchingLocation } from '~/utils/isMatchingLocation';
// TODO: break down into smaller functions and / or hooks
-// - moved usePageChangeEffectNavigateLocation into dedicated hook
export const PageChangeEffect = () => {
const store = useStore();
const navigate = useNavigate();
diff --git a/packages/twenty-front/src/modules/app/hooks/useExecuteTasksOnAnyLocationChange.ts b/packages/twenty-front/src/modules/app/hooks/useExecuteTasksOnAnyLocationChange.ts
index 2f1c2573a03..26cfc980b5e 100644
--- a/packages/twenty-front/src/modules/app/hooks/useExecuteTasksOnAnyLocationChange.ts
+++ b/packages/twenty-front/src/modules/app/hooks/useExecuteTasksOnAnyLocationChange.ts
@@ -125,11 +125,7 @@ export const useExecuteTasksOnAnyLocationChange = () => {
}
}, [store]);
- /**
- * Be careful to put idempotent tasks here.
- *
- * Because it might be called multiple times.
- */
+ // Tasks here must be idempotent: this can run several times per location change.
const executeTasksOnAnyLocationChange = () => {
closeAnyOpenDropdown();
diff --git a/packages/twenty-front/src/modules/auth/components/__stories__/VerifyEmail.stories.tsx b/packages/twenty-front/src/modules/auth/components/__stories__/VerifyEmail.stories.tsx
index 8e550b42fb1..b741aef599f 100644
--- a/packages/twenty-front/src/modules/auth/components/__stories__/VerifyEmail.stories.tsx
+++ b/packages/twenty-front/src/modules/auth/components/__stories__/VerifyEmail.stories.tsx
@@ -4,10 +4,10 @@ import { EmailVerificationSent } from '@/auth/sign-in-up/components/EmailVerific
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { MemoryRouter, Route, Routes } from 'react-router-dom';
-// Mock component that just renders the error state of VerifyEmail directly
-// (since normal VerifyEmail has async logic that's hard to test in Storybook)
import { ToastDecorator } from '~/testing/decorators/ToastDecorator';
+// VerifyEmail's async logic is hard to drive in Storybook, so only its error
+// state is rendered directly.
const VerifyEmailErrorState = ({ email = '[email protected]' }) => {
return (
<StyledAuthContent>
diff --git a/packages/twenty-front/src/modules/client-config/hooks/useCaptcha.ts b/packages/twenty-front/src/modules/client-config/hooks/useCaptcha.ts
index f2f45529ffc..b7dc1eed023 100644
--- a/packages/twenty-front/src/modules/client-config/hooks/useCaptcha.ts
+++ b/packages/twenty-front/src/modules/client-config/hooks/useCaptcha.ts
@@ -16,10 +16,6 @@ export const useCaptcha = () => {
const isSiteKeyDefined = isDefined(captcha?.siteKey);
const isTokenAvailable = isDefined(captchaToken);
- // Captcha is ready when:
- // - Client config is loaded
- // - And either captcha is not configured with a site key (no captcha required)
- // - Or, when configured, a captcha token is available
const isCaptchaReady =
isClientConfigLoaded && (!isSiteKeyDefined || isTokenAvailable);
diff --git a/packages/twenty-front/src/modules/geo-map/hooks/__tests__/useGetPlaceApiData.test.tsx b/packages/twenty-front/src/modules/geo-map/hooks/__tests__/useGetPlaceApiData.test.tsx
index c2298995fba..0cbdc108df0 100644
--- a/packages/twenty-front/src/modules/geo-map/hooks/__tests__/useGetPlaceApiData.test.tsx
+++ b/packages/twenty-front/src/modules/geo-map/hooks/__tests__/useGetPlaceApiData.test.tsx
@@ -306,7 +306,6 @@ describe('useGetPlaceApiData', () => {
expect(autocompleteData).toEqual(mockAutocompleteResults);
});
- // Then get place details for the first result
const placeDetailsData = await result.current.getPlaceDetailsData(
'ChIJD7fiBh9u5kcRYJSMaMOCCwQ',
'test-token',
diff --git a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts
index 2c50bfc1840..2bcfc79c023 100644
--- a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts
+++ b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts
@@ -90,7 +90,6 @@ describe('detectCalendarStartDay', () => {
});
it('should handle Intl.Locale with weekInfo support', () => {
- // Temporarily restore original and mock with weekInfo
(global.Intl as any).Locale = jest.fn().mockImplementation(() => ({
weekInfo: { firstDay: 1 }, // Monday
}));
@@ -99,7 +98,6 @@ describe('detectCalendarStartDay', () => {
});
it('should handle Intl.Locale with Saturday firstDay', () => {
- // Temporarily restore original and mock with weekInfo
(global.Intl as any).Locale = jest.fn().mockImplementation(() => ({
weekInfo: { firstDay: 6 }, // Saturday
}));
diff --git a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectDateFormat.test.ts b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectDateFormat.test.ts
index 6b130bef174..bd616a0f4ae 100644
--- a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectDateFormat.test.ts
+++ b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectDateFormat.test.ts
@@ -2,7 +2,6 @@ import { detectDateFormat } from '@/localization/utils/detection/detectDateForma
describe('detectDateFormat', () => {
it('should return MONTH_FIRST if the detected format starts with month', () => {
- // Mock the Intl.DateTimeFormat to return a specific format
const mockDateTimeFormat = jest.fn().mockReturnValue({
formatToParts: () => [
{ type: 'month', value: '01' },
@@ -19,7 +18,6 @@ describe('detectDateFormat', () => {
});
it('should return DAY_FIRST if the detected format starts with day', () => {
- // Mock the Intl.DateTimeFormat to return a specific format
const mockDateTimeFormat = jest.fn().mockReturnValue({
formatToParts: () => [
{ type: 'day', value: '01' },
@@ -35,7 +33,6 @@ describe('detectDateFormat', () => {
});
it('should return YEAR_FIRST if the detected format starts with year', () => {
- // Mock the Intl.DateTimeFormat to return a specific format
const mockDateTimeFormat = jest.fn().mockReturnValue({
formatToParts: () => [
{ type: 'year', value: '2022' },
@@ -51,7 +48,6 @@ describe('detectDateFormat', () => {
});
it('should return MONTH_FIRST by default if the detected format does not match any specific order', () => {
- // Mock the Intl.DateTimeFormat to return a specific format
const mockDateTimeFormat = jest.fn().mockReturnValue({
formatToParts: () => [
{ type: 'hour', value: '12' },
diff --git a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectNumberFormat.test.ts b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectNumberFormat.test.ts
index 9bd198f1cb9..eeec3c85efb 100644
--- a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectNumberFormat.test.ts
+++ b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectNumberFormat.test.ts
@@ -78,7 +78,6 @@ describe('detectNumberFormat', () => {
});
it('should detect SPACES_AND_COMMA format for locales using non-breaking space separator', () => {
- // Mock formatToParts to return non-breaking space
const originalNumberFormat = Intl.NumberFormat;
(global.Intl as any).NumberFormat = Object.assign(
jest.fn().mockImplementation(() => ({
@@ -100,7 +99,6 @@ describe('detectNumberFormat', () => {
});
it('should detect SPACES_AND_COMMA format for locales using narrow no-break space separator', () => {
- // Mock formatToParts to return narrow no-break space
const originalNumberFormat = Intl.NumberFormat;
(global.Intl as any).NumberFormat = Object.assign(
jest.fn().mockImplementation(() => ({
@@ -141,7 +139,6 @@ describe('detectNumberFormat', () => {
});
it('should detect APOSTROPHE_AND_DOT format for locales using right single quotation mark separator', () => {
- // Mock formatToParts to return right single quotation mark
const originalNumberFormat = Intl.NumberFormat;
// @ts-expect-error - Mocking for test
global.Intl.NumberFormat = jest.fn().mockImplementation(() => ({
@@ -199,7 +196,6 @@ describe('detectNumberFormat', () => {
});
it('should handle unknown pattern combinations', () => {
- // Mock formatToParts to return an unknown pattern
const originalNumberFormat = Intl.NumberFormat;
// @ts-expect-error - Mocking for test
global.Intl.NumberFormat = jest.fn().mockImplementation(() => ({
diff --git a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectTimeFormat.test.ts b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectTimeFormat.test.ts
index e7a22cb2d42..b2a41971b19 100644
--- a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectTimeFormat.test.ts
+++ b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectTimeFormat.test.ts
@@ -2,7 +2,6 @@ import { detectTimeFormat } from '@/localization/utils/detection/detectTimeForma
describe('detectTimeFormat', () => {
it('should return HOUR_12 if the hour format is 12-hour', () => {
- // Mock the resolvedOptions method to return hour12 as true
const mockResolvedOptions = jest.fn(() => ({ hour12: true }));
Intl.DateTimeFormat = jest.fn().mockImplementation(() => ({
resolvedOptions: mockResolvedOptions,
@@ -15,7 +14,6 @@ describe('detectTimeFormat', () => {
});
it('should return HOUR_24 if the hour format is 24-hour', () => {
- // Mock the resolvedOptions method to return hour12 as false
const mockResolvedOptions = jest.fn(() => ({ hour12: false }));
Intl.DateTimeFormat = jest.fn().mockImplementation(() => ({
resolvedOptions: mockResolvedOptions,
diff --git a/packages/twenty-front/src/modules/localization/utils/detection/detectCalendarStartDay.ts b/packages/twenty-front/src/modules/localization/utils/detection/detectCalendarStartDay.ts
index c604cec1a07..ae84b1049bf 100644
--- a/packages/twenty-front/src/modules/localization/utils/detection/detectCalendarStartDay.ts
+++ b/packages/twenty-front/src/modules/localization/utils/detection/detectCalendarStartDay.ts
@@ -1,12 +1,9 @@
import { FirstDayOfTheWeek } from 'twenty-shared/types';
export const detectCalendarStartDay = (): FirstDayOfTheWeek => {
- // Use Intl.Locale to get the first day of the week from the user's locale
- // This requires a modern browser that supports Intl.Locale
try {
const locale = new Intl.Locale(navigator?.language || 'en-US');
- // Check if the weekInfo property is available (newer browsers)
if (
'weekInfo' in locale &&
locale.weekInfo !== null &&
@@ -16,7 +13,6 @@ export const detectCalendarStartDay = (): FirstDayOfTheWeek => {
) {
const firstDay = locale.weekInfo.firstDay;
- // Map Intl.Locale firstDay values to our enum keys
// Intl.Locale uses 1=Monday, 7=Sunday, 6=Saturday
switch (firstDay) {
case 1:
@@ -32,7 +28,6 @@ export const detectCalendarStartDay = (): FirstDayOfTheWeek => {
// Fallback if Intl.Locale is not supported or fails
}
- // Fallback: Use a heuristic based on common locale patterns
const language = (navigator?.language || 'en-US').toLowerCase();
// Most European countries, Australia, New Zealand start with Monday
diff --git a/packages/twenty-front/src/modules/object-record/cache/utils/__tests__/getRecordNodeFromRecord.test.ts b/packages/twenty-front/src/modules/object-record/cache/utils/__tests__/getRecordNodeFromRecord.test.ts
index 1b1fc685aaf..27bab8eff1a 100644
--- a/packages/twenty-front/src/modules/object-record/cache/utils/__tests__/getRecordNodeFromRecord.test.ts
+++ b/packages/twenty-front/src/modules/object-record/cache/utils/__tests__/getRecordNodeFromRecord.test.ts
@@ -122,7 +122,6 @@ describe('getRecordNodeFromRecord', () => {
[oneToManyRelationField.name]: true,
};
- // When / Then
expect(() =>
getRecordNodeFromRecord({
objectMetadataItems,
diff --git a/packages/twenty-front/src/modules/object-record/hooks/__tests__/useCreateManyRecords.test.tsx b/packages/twenty-front/src/modules/object-record/hooks/__tests__/useCreateManyRecords.test.tsx
index bb43e731a00..a2842b0c92e 100644
--- a/packages/twenty-front/src/modules/object-record/hooks/__tests__/useCreateManyRecords.test.tsx
+++ b/packages/twenty-front/src/modules/object-record/hooks/__tests__/useCreateManyRecords.test.tsx
@@ -112,7 +112,6 @@ describe('useCreateManyRecords', () => {
expect(res).toEqual(response);
});
- // Verify that the mutation was called with data without IDs
expect(mocks[1].request.variables.data).toEqual(input);
mocks[1].request.variables.data.forEach((record: any) => {
expect(record).not.toHaveProperty('id');
diff --git a/packages/twenty-front/src/modules/object-record/hooks/useBuildRecordInputFromRLSPredicates.ts b/packages/twenty-front/src/modules/object-record/hooks/useBuildRecordInputFromRLSPredicates.ts
index cc349d428a2..96c1d3d78f9 100644
--- a/packages/twenty-front/src/modules/object-record/hooks/useBuildRecordInputFromRLSPredicates.ts
+++ b/packages/twenty-front/src/modules/object-record/hooks/useBuildRecordInputFromRLSPredicates.ts
@@ -179,7 +179,6 @@ export const useBuildRecordInputFromRLSPredicates = ({
}
});
- // Only process filters without rlsDynamicValue in buildRecordInputFromFilter
// Filters with rlsDynamicValue are already handled above
const staticFilters = rlsPredicatesAsRecordFilters.filter(
(filter) => !isDefined(filter.rlsDynamicValue),
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsx
index 4ee0de171a6..c3375b86be7 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsx
@@ -343,10 +343,7 @@ export const ClearField: Story = {
},
};
-/**
- * Line breaks are not authorized in JSON strings. Users should instead put newlines characters themselves.
- * See https://stackoverflow.com/a/42073.
- */
+// Line breaks are not allowed in JSON strings, users type escaped newlines (https://stackoverflow.com/a/42073)
export const DoesNotBreakWhenUserInsertsNewlineInJsonString: Story = {
args: {
placeholder: 'Enter valid json',
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/hooks/useTextVariableEditor.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/hooks/useTextVariableEditor.ts
index f87a15b0ace..0342c4c9764 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/hooks/useTextVariableEditor.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/hooks/useTextVariableEditor.ts
@@ -22,9 +22,6 @@ type UseTextVariableEditorProps = {
ariaLabelledBy?: string;
};
-/**
- * Checks if the given text is a valid JSON object (not array, primitive, or null)
- */
const isJsonObject = (text: string): boolean => {
try {
const parsed = JSON.parse(text);
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/types/ZodHelperLiteral.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/types/ZodHelperLiteral.ts
index 81c9b3dbde0..c7eb9623814 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/types/ZodHelperLiteral.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/types/ZodHelperLiteral.ts
@@ -1,2 +1,2 @@
-/** See https://zod.dev/?id=json-type */
+// See https://zod.dev/?id=json-type
export type ZodHelperLiteral = string | number | boolean | null;
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/extractTargetRecordsFromJunction.test.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/extractTargetRecordsFromJunction.test.ts
index 13ff0f329f1..43b9fab3803 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/extractTargetRecordsFromJunction.test.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/extractTargetRecordsFromJunction.test.ts
@@ -61,7 +61,6 @@ const mockMorphFieldWithRelations: FieldMetadataItem = {
],
} as FieldMetadataItem;
-// Mock multiple regular relation fields (for multiple target testing)
const mockMultipleRelationFields: FieldMetadataItem[] = [
{
id: 'relation-field-company-id',
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/findTargetFieldInfo.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/findTargetFieldInfo.ts
index 7007d5c0a07..63284abd231 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/findTargetFieldInfo.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/findTargetFieldInfo.ts
@@ -44,8 +44,6 @@ const findMorphTargetFieldInfo = (
targetObjectMetadataNamePlural: targetObjectMetadata.namePlural,
});
- // For morph relations, compute the join column name from the computed field name
- // e.g., caretakerPerson → caretakerPersonId
return {
fieldName,
joinColumnName: computeRelationGqlFieldJoinColumnName({ name: fieldName }),
diff --git a/packages/twenty-front/src/modules/object-record/record-picker/single-record-picker/components/__stories__/SingleRecordPicker.stories.tsx b/packages/twenty-front/src/modules/object-record/record-picker/single-record-picker/components/__stories__/SingleRecordPicker.stories.tsx
index 2c8ff9df5c9..d2a4d5233b6 100644
--- a/packages/twenty-front/src/modules/object-record/record-picker/single-record-picker/components/__stories__/SingleRecordPicker.stories.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-picker/single-record-picker/components/__stories__/SingleRecordPicker.stories.tsx
@@ -11,25 +11,6 @@ import { SingleRecordPicker } from '@/object-record/record-picker/single-record-
import { IconUserCircle } from 'twenty-ui/icon';
import { ComponentDecorator } from 'twenty-ui/testing';
-// const records = allMockPersonRecords.map<SearchRecord>((person) => ({
-// id: person.id,
-// label: person.name.firstName + ' ' + person.name.lastName,
-// imageUrl: 'https://picsum.photos/200',
-// objectNameSingular: 'Person',
-// recordId: person.id,
-// tsRank: 0,
-// tsRankCD: 0,
-// }));
-
-// const pickableMorphItems = records.map<RecordPickerPickableMorphItem>(
-// (record) => ({
-// recordId: record.recordId,
-// objectMetadataId: record.objectNameSingular,
-// isSelected: false,
-// isMatchingSearchFilter: true,
-// }),
-// );
-
const meta: Meta<typeof SingleRecordPicker> = {
title: 'UI/RecordPicker/SingleRecordPicker',
component: SingleRecordPicker,
diff --git a/packages/twenty-front/src/modules/page-layout/utils/__tests__/getTabsWithVisibleWidgets.test.ts b/packages/twenty-front/src/modules/page-layout/utils/__tests__/getTabsWithVisibleWidgets.test.ts
index af97a5d7d02..36ba30cd150 100644
--- a/packages/twenty-front/src/modules/page-layout/utils/__tests__/getTabsWithVisibleWidgets.test.ts
+++ b/packages/twenty-front/src/modules/page-layout/utils/__tests__/getTabsWithVisibleWidgets.test.ts
@@ -223,7 +223,7 @@ describe('getTabsWithVisibleWidgets', () => {
});
expect(result).toHaveLength(1);
- expect(result[0].widgets).toHaveLength(2); // All widgets kept in edit mode
+ expect(result[0].widgets).toHaveLength(2);
expect(result[0].widgets[0].id).toBe('widget-1');
expect(result[0].widgets[1].id).toBe('widget-2');
});
@@ -267,8 +267,8 @@ describe('getTabsWithVisibleWidgets', () => {
});
expect(result).toHaveLength(2);
- expect(result[0].widgets).toHaveLength(1); // Kept in edit mode
- expect(result[1].widgets).toHaveLength(1); // Kept in edit mode
+ expect(result[0].widgets).toHaveLength(1);
+ expect(result[1].widgets).toHaveLength(1);
});
});
diff --git a/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx b/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx
index 0832ec5d1b9..8a02bc41570 100644
--- a/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx
+++ b/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx
@@ -130,7 +130,6 @@ const mockCompanyRecord: ObjectRecord = {
},
};
-// Helper function to create a page layout with a widget
const createPageLayoutWithWidget = (
widget: PageLayoutWidget,
pageLayoutType: PageLayoutType = PageLayoutType.DASHBOARD,
diff --git a/packages/twenty-front/src/modules/page-layout/widgets/record-table/components/RecordTableWidgetRendererContent.tsx b/packages/twenty-front/src/modules/page-layout/widgets/record-table/components/RecordTableWidgetRendererContent.tsx
index 4f5ed9f614e..573e775a26a 100644
--- a/packages/twenty-front/src/modules/page-layout/widgets/record-table/components/RecordTableWidgetRendererContent.tsx
+++ b/packages/twenty-front/src/modules/page-layout/widgets/record-table/components/RecordTableWidgetRendererContent.tsx
@@ -75,8 +75,6 @@ export const RecordTableWidgetRendererContent = ({
widgetView?.calendarLayout === ViewCalendarLayout.WEEK;
const canEditCalendar =
isCalendarLayout && !isPageLayoutInEditMode && isCalendarDayOrWeek;
- // Read-only unless this is the explicitly allowed live day/week calendar.
- // Object permissions still gate the drag.
const calendarIsReadOnly = !canEditCalendar;
// Keyed rather than chained so a layout added to RECORD_TABLE_WIDGET_LAYOUTS
diff --git a/packages/twenty-front/src/modules/settings/experience/constants/AvailableTimezoneOptionsByLabel.ts b/packages/twenty-front/src/modules/settings/experience/constants/AvailableTimezoneOptionsByLabel.ts
index 421f76f565e..cf7d6aa3dfd 100644
--- a/packages/twenty-front/src/modules/settings/experience/constants/AvailableTimezoneOptionsByLabel.ts
+++ b/packages/twenty-front/src/modules/settings/experience/constants/AvailableTimezoneOptionsByLabel.ts
@@ -6,8 +6,6 @@ const { AVAILABLE_TIME_ZONE_OPTIONS_BY_LABEL } = {
AVAILABLE_TIME_ZONE_OPTIONS_BY_LABEL: IANA_TIME_ZONES.reduce<
Record<string, SelectOption>
>((result, ianaTimeZone) => {
- // Skip time zones with GMT, UTC, or UCT in their name,
- // and duplicates.
if (
formatTimeZoneLabel(ianaTimeZone).slice(11).includes('GMT') ||
formatTimeZoneLabel(ianaTimeZone).slice(11).includes('UTC') ||
diff --git a/packages/twenty-front/src/modules/side-panel/components/SidePanelContextChip.tsx b/packages/twenty-front/src/modules/side-panel/components/SidePanelContextChip.tsx
index 6e428606905..655465daa09 100644
--- a/packages/twenty-front/src/modules/side-panel/components/SidePanelContextChip.tsx
+++ b/packages/twenty-front/src/modules/side-panel/components/SidePanelContextChip.tsx
@@ -23,7 +23,6 @@ const StyledChip = styled.button<{
cursor: ${({ onClick }) => (isDefined(onClick) ? 'pointer' : 'default')};
display: flex;
font-family: inherit;
- /* If the chip has text, we add extra padding to have a more balanced design */
font-size: ${themeCssVariables.font.size.sm};
font-weight: ${themeCssVariables.font.weight.medium};
gap: ${themeCssVariables.spacing[1]};
diff --git a/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/__tests__/useChartSettingsValues.test.tsx b/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/__tests__/useChartSettingsValues.test.tsx
index e910a6ac882..b93404fe5a4 100644
--- a/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/__tests__/useChartSettingsValues.test.tsx
+++ b/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/__tests__/useChartSettingsValues.test.tsx
@@ -184,7 +184,6 @@ describe('useChartSettingsValues', () => {
CHART_CONFIGURATION_SETTING_IDS.DATA_ON_DISPLAY_X,
);
- // Critical test: horizontal should return the SAME value as vertical
expect(value).toBe('Company Name');
});
@@ -195,7 +194,6 @@ describe('useChartSettingsValues', () => {
CHART_CONFIGURATION_SETTING_IDS.DATA_ON_DISPLAY_Y,
);
- // Critical test: horizontal should return the SAME value as vertical
expect(value).toBe('Amount (Sum)');
});
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts
index f9ec6c12034..9da0bfdaa75 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts
@@ -35,7 +35,6 @@ export type SpreadsheetImportDialogOptions = {
onAbortSubmit?: () => void;
// Allows submitting with errors. Default: true
allowInvalidSubmit?: boolean;
- // Theme configuration passed to underlying Chakra-UI
customTheme?: object;
maxRecords?: number;
maxFileSize?: number;
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportField.ts b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportField.ts
index 71106065f67..9bb59e5ba43 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportField.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportField.ts
@@ -14,7 +14,6 @@ export type SpreadsheetImportField = {
description?: string;
fieldValidationDefinitions?: SpreadsheetImportFieldValidationDefinition[];
fieldType: SpreadsheetImportFieldType;
- // Field metadata type
fieldMetadataType: FieldMetadataType;
// if true, it can be a composite sub-field or a relation connect field (or both)
isNestedField: boolean;
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/utils/dataMutations.ts b/packages/twenty-front/src/modules/spreadsheet-import/utils/dataMutations.ts
index c6c4c6c972e..ef54ce6895a 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/utils/dataMutations.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/utils/dataMutations.ts
@@ -50,15 +50,14 @@ export const addErrorsAndRunHooks = (
case 'unique': {
const values = data.map((entry) => entry[field.key]);
- const taken = new Set(); // Set of items used at least once
- const duplicates = new Set(); // Set of items used multiple times
+ const taken = new Set();
+ const duplicates = new Set();
values.forEach((value) => {
if (
fieldValidationDefinition.allowEmpty === true &&
(isUndefinedOrNull(value) || value === '' || !Boolean(value))
) {
- // If allowEmpty is set, we will not validate falsy fields such as undefined or empty string.
return;
}
diff --git a/packages/twenty-front/src/modules/support/utils/getDocumentationUrl.ts b/packages/twenty-front/src/modules/support/utils/getDocumentationUrl.ts
index d2d0aacfd02..cb46f3526a7 100644
--- a/packages/twenty-front/src/modules/support/utils/getDocumentationUrl.ts
+++ b/packages/twenty-front/src/modules/support/utils/getDocumentationUrl.ts
@@ -17,7 +17,6 @@ export const getDocumentationUrl = ({
return `${DOCUMENTATION_BASE_URL}${path}`;
}
- // Extract language code from locale (e.g., 'fr' from 'fr-FR')
const langCode = locale.split('-')[0].toLowerCase();
// English content is served at root path (no /en/ prefix)
diff --git a/packages/twenty-front/src/modules/ui/field/display/components/EmailDisplay.tsx b/packages/twenty-front/src/modules/ui/field/display/components/EmailDisplay.tsx
index c8054f7f89d..4f88d0da716 100644
--- a/packages/twenty-front/src/modules/ui/field/display/components/EmailDisplay.tsx
+++ b/packages/twenty-front/src/modules/ui/field/display/components/EmailDisplay.tsx
@@ -4,7 +4,6 @@ import { type MouseEvent } from 'react';
import { isDefined } from 'twenty-shared/utils';
const validateEmail = (email: string) => {
- // Record this without using regex
const emailParts = email.split('@');
if (emailParts.length !== 2) {
diff --git a/packages/twenty-front/src/modules/ui/input/components/internal/date/components/StyledDatePickerContainer.tsx b/packages/twenty-front/src/modules/ui/input/components/internal/date/components/StyledDatePickerContainer.tsx
index 821a08a8708..50c2bdd9364 100644
--- a/packages/twenty-front/src/modules/ui/input/components/internal/date/components/StyledDatePickerContainer.tsx
+++ b/packages/twenty-front/src/modules/ui/input/components/internal/date/components/StyledDatePickerContainer.tsx
@@ -42,8 +42,6 @@ export const StyledDatePickerContainer = styled.div<{
display: none;
}
- // Header
-
& .react-datepicker__header {
background: transparent;
border: none;
@@ -166,8 +164,6 @@ export const StyledDatePickerContainer = styled.div<{
float: none;
}
- // Days
-
& .react-datepicker__month {
margin: 0;
diff --git a/packages/twenty-front/src/modules/ui/input/components/internal/date/hooks/__tests__/useUserTimezone.test.tsx b/packages/twenty-front/src/modules/ui/input/components/internal/date/hooks/__tests__/useUserTimezone.test.tsx
index f096e8b8895..0b3b2e27e54 100644
--- a/packages/twenty-front/src/modules/ui/input/components/internal/date/hooks/__tests__/useUserTimezone.test.tsx
+++ b/packages/twenty-front/src/modules/ui/input/components/internal/date/hooks/__tests__/useUserTimezone.test.tsx
@@ -10,7 +10,6 @@ describe('useUserTimezone', () => {
const mockSystemTimezone = 'America/New_York';
beforeAll(() => {
- // Mock Intl.DateTimeFormat to return a consistent system timezone
global.Intl = {
...originalIntl,
DateTimeFormat: jest.fn().mockImplementation(() => ({
diff --git a/packages/twenty-front/src/modules/ui/layout/constants/RootStackingContextZIndices.ts b/packages/twenty-front/src/modules/ui/layout/constants/RootStackingContextZIndices.ts
index 925772d4a29..53730efb9d4 100644
--- a/packages/twenty-front/src/modules/ui/layout/constants/RootStackingContextZIndices.ts
+++ b/packages/twenty-front/src/modules/ui/layout/constants/RootStackingContextZIndices.ts
@@ -1,17 +1,6 @@
-/**
- * Please read this article to understand why we use this enum : https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_positioned_layout/Stacking_context
- *
- * It is important to keep track of the stacking contexts that are created on top of the root stacking context of the document.
- *
- * Right now we have to guess it by looking into the developer console
- *
- * This way we can avoid hazardous fidgeting with z-index CSS properties
- * and having to look down the tree in the developer console to see which component is in the root stacking context or not
- *
- * Using an enum enforces a single z-index for each component in the root stacking context
- *
- * TODO: add the other remaining components that can appear in the root stacking context
- */
+// Every stacking context created on top of the document's root one gets its z-index here, so it no longer has to be
+// guessed from the dev console: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_positioned_layout/Stacking_context
+// TODO: add the other remaining components that can appear in the root stacking context
export enum RootStackingContextZIndices {
LogConsole = 20,
SidePanel = 21,
diff --git a/packages/twenty-front/src/modules/ui/layout/dropdown/components/__stories__/Dropdown.stories.tsx b/packages/twenty-front/src/modules/ui/layout/dropdown/components/__stories__/Dropdown.stories.tsx
index 7afc76c40fb..c3075dbaaa3 100644
--- a/packages/twenty-front/src/modules/ui/layout/dropdown/components/__stories__/Dropdown.stories.tsx
+++ b/packages/twenty-front/src/modules/ui/layout/dropdown/components/__stories__/Dropdown.stories.tsx
@@ -6,8 +6,6 @@ import {
} from '@storybook/react-vite';
import { type PlayFunction } from 'storybook/internal/types';
import { expect, userEvent, waitFor, within } from 'storybook/test';
-// TEMP_DISABLED_TEST: Commented out unused import
-// import { useState } from 'react';
import { DropdownMenuSkeletonItem } from '@/ui/input/relation-picker/components/skeletons/DropdownMenuSkeletonItem';
@@ -200,69 +198,6 @@ const optionsMock = [
},
];
-// return (
-// <LegacyDropdownContent>
-// <DropdownMenuItemsContainer hasMaxHeight>
-// {optionsMock.map((item) => (
-// <MenuItemSelectAvatar
-// key={item.id}
-// selected={selectedItem === item.id}
-// onClick={() => setSelectedItem(item.id)}
-// avatar={
-// hasAvatar ? (
-// <Avatar
-// placeholder="A"
-// avatarUrl={item.avatarUrl}
-// size="md"
-// type="squared"
-// />
-// ) : undefined
-// }
-// text={item.name}
-// />
-// ))}
-// </DropdownMenuItemsContainer>
-// </LegacyDropdownContent>
-// );
-// };
-
-// TEMP_DISABLED_TEST: Commented out unused component
-// const FakeCheckableMenuItemList = ({ hasAvatar }: { hasAvatar?: boolean }) => {
-// const [selectedItemsById, setSelectedItemsById] = useState<
-// Record<string, boolean>
-// >({});
-
-// return (
-// <LegacyDropdownContent>
-// <DropdownMenuItemsContainer hasMaxHeight>
-// {optionsMock.map((item) => (
-// <MenuItemMultiSelectAvatar
-// key={item.id}
-// selected={selectedItemsById[item.id]}
-// onSelectChange={(checked) =>
-// setSelectedItemsById((previous) => ({
-// ...previous,
-// [item.id]: checked,
-// }))
-// }
-// avatar={
-// hasAvatar ? (
-// <Avatar
-// placeholder="A"
-// avatarUrl={item.avatarUrl}
-// size="md"
-// type="squared"
-// />
-// ) : undefined
-// }
-// text={item.name}
-// />
-// ))}
-// </DropdownMenuItemsContainer>
-// </LegacyDropdownContent>
-// );
-// };
-
const playInteraction: PlayFunction<any, any> = async ({ canvasElement }) => {
const canvas = within(canvasElement.ownerDocument.body);
@@ -360,56 +295,3 @@ export const WithInput: Story = {
},
play: playInteraction,
};
-
-// TEMP_DISABLED_TEST: Commented out unused variable
-// const modalId = 'dropdown-modal-test';
-
-// TEMP_DISABLED_TEST: Commented out unused component
-// const ModalWithDropdown = () => {
-// return (
-// <>
-// <Modal modalId={modalId} size="medium" padding="medium" isClosable={true}>
-// <Modal.Header>Modal with Dropdown Test</Modal.Header>
-// <Modal.Content>
-// <p>
-// This modal contains a dropdown that should appear above the modal
-// (higher z-index).
-// </p>
-// <div style={{ marginTop: '20px' }}>
-// <Dropdown
-// clickableComponent={
-// <Button
-// dataTestId="dropdown-button"
-// title="Open Dropdown in Modal"
-// />
-// }
-// dropdownOffset={{ x: 0, y: 8 }}
-// dropdownId="modal-dropdown-test"
-// isDropdownInModal={true}
-// dropdownComponents={
-// <div data-testid="dropdown-content">
-// <FakeSelectableMenuItemList hasAvatar />
-// </div>
-// }
-// />
-// </div>
-// </Modal.Content>
-// </Modal>
-// </>
-// );
-// };
-
-// set(focusStackState, [
-// {
-// focusId: modalId,
-// componentInstance: {
-// componentType: FocusComponentType.MODAL,
-// componentInstanceId: modalId,
-// },
-// globalHotkeysConfig: {
-// enableGlobalHotkeysWithModifiers: true,
-// enableGlobalHotkeysConflictingWithKeyboard: true,
-// },
-// },
-// ]);
-// };
diff --git a/packages/twenty-front/src/modules/ui/navigation/step-bar/components/StepBar.tsx b/packages/twenty-front/src/modules/ui/navigation/step-bar/components/StepBar.tsx
index a76f265c4e3..22580185626 100644
--- a/packages/twenty-front/src/modules/ui/navigation/step-bar/components/StepBar.tsx
+++ b/packages/twenty-front/src/modules/ui/navigation/step-bar/components/StepBar.tsx
@@ -31,7 +31,6 @@ export const StepBar = ({ activeStep, children }: StepBarProps) => {
return null;
}
- // If the child is not a Step, return it as-is
// oxlint-disable-next-line typescript/ban-ts-comment
// @ts-expect-error
if (child.type?.displayName !== Step.displayName) {
diff --git a/packages/twenty-front/src/modules/ui/navigation/utils/hooks/useMouseDownNavigation.ts b/packages/twenty-front/src/modules/ui/navigation/utils/hooks/useMouseDownNavigation.ts
index ec9ce628202..a9fc5cc7ec4 100644
--- a/packages/twenty-front/src/modules/ui/navigation/utils/hooks/useMouseDownNavigation.ts
+++ b/packages/twenty-front/src/modules/ui/navigation/utils/hooks/useMouseDownNavigation.ts
@@ -25,7 +25,6 @@ export const useMouseDownNavigation = ({
const handleClick = (event: MouseEvent<HTMLElement>) => {
if (disabled) return;
- // For modifier keys, let the default browser behavior handle it
if (isNavigationModifierPressed(event)) {
onBeforeNavigation?.();
if (isDefined(onClick) && !isDefined(to)) {
diff --git a/packages/twenty-front/src/modules/views/constants/ViewBarFilterDropdownIds.ts b/packages/twenty-front/src/modules/views/constants/ViewBarFilterDropdownIds.ts
index 2e03781a8fd..e95b93849a8 100644
--- a/packages/twenty-front/src/modules/views/constants/ViewBarFilterDropdownIds.ts
+++ b/packages/twenty-front/src/modules/views/constants/ViewBarFilterDropdownIds.ts
@@ -1,5 +1,4 @@
export enum ViewBarFilterDropdownIds {
MAIN = 'view-bar-main-filter-dropdown-id',
ADVANCED = 'view-bar-advanced-filter-dropdown-id',
- // We also have editable chip dropdown, in this case use the getEditableChipDropdownId
}
diff --git a/packages/twenty-front/src/modules/views/hooks/useCanPersistViewChanges.ts b/packages/twenty-front/src/modules/views/hooks/useCanPersistViewChanges.ts
index 50df6c77cbd..fa3f7a6b05b 100644
--- a/packages/twenty-front/src/modules/views/hooks/useCanPersistViewChanges.ts
+++ b/packages/twenty-front/src/modules/views/hooks/useCanPersistViewChanges.ts
@@ -13,7 +13,6 @@ export const useCanPersistViewChanges = () => {
return { canPersistChanges: false };
}
- // Users with VIEWS permission can persist all views
if (hasViewsPermission) {
return { canPersistChanges: true };
}
diff --git a/packages/twenty-front/src/modules/views/utils/mapViewFieldsToColumnDefinitions.ts b/packages/twenty-front/src/modules/views/utils/mapViewFieldsToColumnDefinitions.ts
index e0aba636ff6..6b7eb4e5dc0 100644
--- a/packages/twenty-front/src/modules/views/utils/mapViewFieldsToColumnDefinitions.ts
+++ b/packages/twenty-front/src/modules/views/utils/mapViewFieldsToColumnDefinitions.ts
@@ -64,8 +64,6 @@ export const mapViewFieldsToColumnDefinitions = ({
({ fieldMetadataId }) => fieldMetadataId === labelIdentifierFieldMetadataId,
);
- // Label identifier field found in view fields
- // => move it to the start of the list
return moveArrayItem(columnDefinitionsFromViewFields, {
fromIndex: labelIdentifierIndex,
toIndex: 0,
diff --git a/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerOptionDropdown.tsx b/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerOptionDropdown.tsx
index d86fb787969..37c91a801c0 100644
--- a/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerOptionDropdown.tsx
+++ b/packages/twenty-front/src/modules/views/view-picker/components/ViewPickerOptionDropdown.tsx
@@ -65,7 +65,6 @@ export const ViewPickerOptionDropdown = ({
const { deleteManyNavigationMenuItems } = useDeleteManyNavigationMenuItems();
- // Users with VIEWS permission can edit all views
// Users without VIEWS permission can only edit unlisted views (which are always their own, filtered by backend)
const canEditView =
hasViewsPermission || view.visibility === ViewVisibility.UNLISTED;
diff --git a/packages/twenty-front/src/modules/workflow/utils/findStepPosition.ts b/packages/twenty-front/src/modules/workflow/utils/findStepPosition.ts
index 9507288b920..0ce6d1c113a 100644
--- a/packages/twenty-front/src/modules/workflow/utils/findStepPosition.ts
+++ b/packages/twenty-front/src/modules/workflow/utils/findStepPosition.ts
@@ -2,10 +2,6 @@ import { type WorkflowStep } from '@/workflow/types/Workflow';
import { isDefined } from 'twenty-shared/utils';
import { TRIGGER_STEP_ID } from 'twenty-shared/workflow';
-/**
- * This function returns the reference of the array where the step should be positioned
- * and at which index.
- */
export const findStepPosition = ({
steps,
stepId,
@@ -29,12 +25,6 @@ export const findStepPosition = ({
}
// TODO: When condition will have been implemented, put recursivity here.
- // if (step.type === "CONDITION") {
- // return findNodePosition({
- // workflowSteps: step.conditions,
- // stepId,
- // })
- // }
}
return undefined;
diff --git a/packages/twenty-front/src/modules/workflow/workflow-diagram/hooks/useStartNodeCreation.ts b/packages/twenty-front/src/modules/workflow/workflow-diagram/hooks/useStartNodeCreation.ts
index 0a239118e32..a04214a4fff 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-diagram/hooks/useStartNodeCreation.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-diagram/hooks/useStartNodeCreation.ts
@@ -35,10 +35,7 @@ export const useStartNodeCreation = () => {
sidePanelNavigationStackState,
);
- /**
- * This function is used in a context where dependencies shouldn't change much.
- * That's why its wrapped in a `useCallback` hook. Removing memoization might break the app unexpectedly.
- */
+ // Callers depend on a stable reference, so removing the useCallback can break them.
const startNodeCreation = useCallback(
({
parentStepId,
diff --git a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx
index 800ed17c3bf..6454dd088c9 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx
+++ b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx
@@ -110,8 +110,6 @@ export const NoVariables: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
- // Should not render anything when there are no variables
- // With no variables, there should be no input fields
const inputs = canvas.queryAllByRole('textbox');
expect(inputs).toHaveLength(0);
},
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfWeekDescription.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfWeekDescription.ts
index 12b42b62385..29c48b173cc 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfWeekDescription.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfWeekDescription.ts
@@ -14,7 +14,6 @@ const getDayName = (
): string => {
const normalizedDay = dayNum === 7 ? 0 : dayNum;
- // Create a date for the given day (using a Sunday as base: 2024-01-07)
const baseDate = new Date(2024, 0, 7); // Sunday
const dayDate = new Date(
baseDate.getTime() + normalizedDay * 24 * 60 * 60 * 1000,
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getMonthsDescription.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getMonthsDescription.ts
index 8b6fd4ed702..93868fc547d 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getMonthsDescription.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getMonthsDescription.ts
@@ -14,7 +14,6 @@ const getMonthName = (
): string => {
const index = monthStartIndexZero ? monthNum : monthNum - 1;
- // Create a date for the given month (using January 1st as base)
const monthDate = new Date(2024, index, 1);
if (isDefined(localeCatalog)) {
diff --git a/packages/twenty-front/src/pages/settings/__stories__/SettingsWorkspaceMembers.stories.tsx b/packages/twenty-front/src/pages/settings/__stories__/SettingsWorkspaceMembers.stories.tsx
index ffd918f4832..9a51464783a 100644
--- a/packages/twenty-front/src/pages/settings/__stories__/SettingsWorkspaceMembers.stories.tsx
+++ b/packages/twenty-front/src/pages/settings/__stories__/SettingsWorkspaceMembers.stories.tsx
@@ -5,8 +5,6 @@ import {
type PageDecoratorArgs,
} from '~/testing/decorators/PageDecorator';
import { graphqlMocks } from '~/testing/graphqlMocks';
-// TEMP_DISABLED_TEST: Removed unused import due to commented test
-// import { sleep } from '~/utils/sleep';
import { SettingsWorkspaceMembers } from '~/pages/settings/members/SettingsWorkspaceMembers';
diff --git a/packages/twenty-front/src/pages/settings/developers/__stories__/api-keys/SettingsDevelopersApiKeysNew.stories.tsx b/packages/twenty-front/src/pages/settings/developers/__stories__/api-keys/SettingsDevelopersApiKeysNew.stories.tsx
index 4835795d77d..e4687cdb3be 100644
--- a/packages/twenty-front/src/pages/settings/developers/__stories__/api-keys/SettingsDevelopersApiKeysNew.stories.tsx
+++ b/packages/twenty-front/src/pages/settings/developers/__stories__/api-keys/SettingsDevelopersApiKeysNew.stories.tsx
@@ -9,9 +9,6 @@ import {
} from '~/testing/decorators/PageDecorator';
import { graphqlMocks } from '~/testing/graphqlMocks';
-// TEMP_DISABLED_TEST: Removed unused import due to commented test
-// import { sleep } from '~/utils/sleep';
-
const meta: Meta<PageDecoratorArgs> = {
title: 'Pages/Settings/ApiKeys/SettingsDevelopersApiKeysNew',
component: SettingsDevelopersApiKeysNew,
diff --git a/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts b/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts
index 83caa9ed9d9..0f153eb4b93 100644
--- a/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts
+++ b/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts
@@ -55,7 +55,6 @@ describe('getDirtyFields', () => {
const draft = { a: 1 };
const persisted = { a: 1, b: 2 };
// When a field is removed, its value in draft effectively becomes undefined
- // Cast persisted to any to satisfy TS in this test scenario
expect(getDirtyFields(draft, persisted as any)).toEqual({ b: undefined });
});
diff --git a/packages/twenty-front/src/utils/normalizeGQLField.ts b/packages/twenty-front/src/utils/normalizeGQLField.ts
index ede9253dad2..733210d89a4 100644
--- a/packages/twenty-front/src/utils/normalizeGQLField.ts
+++ b/packages/twenty-front/src/utils/normalizeGQLField.ts
@@ -1,8 +1,5 @@
import { parse } from 'graphql';
export const normalizeGQLField = (query: string) => {
- // Parse the query to an AST, then print it back to a string.
- // This normalizes whitespace and sorts fields alphabetically.
- // Used in tests to compare fields regardless of order.
return parse('{' + query + '}').toString();
};
diff --git a/packages/twenty-front/src/utils/normalizeGQLQuery.ts b/packages/twenty-front/src/utils/normalizeGQLQuery.ts
index fecdae3be7f..cf0427a79e4 100644
--- a/packages/twenty-front/src/utils/normalizeGQLQuery.ts
+++ b/packages/twenty-front/src/utils/normalizeGQLQuery.ts
@@ -1,8 +1,5 @@
import { parse } from 'graphql';
export const normalizeGQLQuery = (query: string) => {
- // Parse the query to an AST, then print it back to a string.
- // This normalizes whitespace and sorts fields alphabetically.
- // Used in tests to compare queries.
return parse(query).toString();
};
diff --git a/packages/twenty-front/vite.config.ts b/packages/twenty-front/vite.config.ts
index bd6837cc575..661970f0cb1 100644
--- a/packages/twenty-front/vite.config.ts
+++ b/packages/twenty-front/vite.config.ts
@@ -214,46 +214,6 @@ export default defineConfig(({ mode }) => {
},
// TODO; later - think about prefetching modules such
// as date time picker, phone input etc...
- /*
- {
- name: 'add-prefetched-modules',
- transformIndexHtml(html: string,
- ctx: {
- path: string;
- filename: string;
- server?: ViteDevServer;
- bundle?: import('rollup').OutputBundle;
- chunk?: import('rollup').OutputChunk;
- }) {
-
- const bundles = Object.keys(ctx.bundle ?? {});
-
- let modernBundles = bundles.filter(
- (bundle) => bundle.endsWith('.map') === false
- );
-
-
- // Remove existing files and concatenate them into link tags
- const prefechBundlesString = modernBundles
- .filter((bundle) => html.includes(bundle) === false)
- .map((bundle) => `<link rel="prefetch" href="${ctx.server?.config.base}${bundle}">`)
- .join('');
-
- // Use regular expression to get the content within <head> </head>
- const headContent = html.match(/<head>([\s\S]*)<\/head>/)?.[1] ?? '';
- // Insert the content of prefetch into the head
- const newHeadContent = `${headContent}${prefechBundlesString}`;
- // Replace the original head
- html = html.replace(
- /<head>([\s\S]*)<\/head>/,
- `<head>${newHeadContent}</head>`
- );
-
- return html;
-
-
- },
- }*/
],
},
},
diff --git a/packages/twenty-sdk/src/cli/__tests__/integration/utils/run-cli-command.util.ts b/packages/twenty-sdk/src/cli/__tests__/integration/utils/run-cli-command.util.ts
index 835d1fa6e7f..013f4b77dc1 100644
--- a/packages/twenty-sdk/src/cli/__tests__/integration/utils/run-cli-command.util.ts
+++ b/packages/twenty-sdk/src/cli/__tests__/integration/utils/run-cli-command.util.ts
@@ -2,7 +2,6 @@ import { spawn, type ChildProcess } from 'child_process';
import path from 'path';
import { fileURLToPath } from 'url';
-// CLI path and working directory (twenty-sdk src directory)
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const CLI_DIR = path.resolve(__dirname, '../../../..');
diff --git a/packages/twenty-sdk/src/cli/__tests__/integration/utils/sanitize-output.util.ts b/packages/twenty-sdk/src/cli/__tests__/integration/utils/sanitize-output.util.ts
index 9d44acc36d4..350d076d540 100644
--- a/packages/twenty-sdk/src/cli/__tests__/integration/utils/sanitize-output.util.ts
+++ b/packages/twenty-sdk/src/cli/__tests__/integration/utils/sanitize-output.util.ts
@@ -5,11 +5,8 @@ export const sanitizeOutput = (output: string): string => {
.replace(/\x1B\[[0-9;]*[a-zA-Z]/g, '')
// Normalize file paths (replace any absolute path to a test app)
.replace(/\/[^\s]+\/__tests__\/apps\/[^/]+/g, '<APP_PATH>')
- // Normalize timestamps
.replace(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/g, '<TIMESTAMP>')
- // Normalize durations
.replace(/\d+ms/g, '<DURATION>')
- // Trim trailing whitespace from each line
.split('\n')
.map((line) => line.trimEnd())
.join('\n')
diff --git a/packages/twenty-sdk/src/cli/operations/index.ts b/packages/twenty-sdk/src/cli/operations/index.ts
index 98f37b07787..f0844c7c927 100644
--- a/packages/twenty-sdk/src/cli/operations/index.ts
+++ b/packages/twenty-sdk/src/cli/operations/index.ts
@@ -1,4 +1,3 @@
-// Auth
export { authLogin } from './login';
export type { AuthLoginOptions } from './login';
export { authLoginOAuth } from './login-oauth';
@@ -6,7 +5,6 @@ export type { AuthLoginOAuthOptions } from './login-oauth';
export { authLogout } from './logout';
export type { AuthLogoutOptions } from './logout';
-// App
export { appBuild } from './build';
export type { AppBuildOptions, AppBuildResult } from './build';
export { appDeploy } from './deploy';
@@ -22,11 +20,9 @@ export type { AppPublishOptions, AppPublishResult } from './publish';
export { appUninstall } from './uninstall';
export type { AppUninstallOptions } from './uninstall';
-// Functions
export { functionExecute } from './execute';
export type { FunctionExecuteOptions } from './execute';
-// Server
export { serverStart } from './server-start';
export type { ServerStartOptions, ServerStartResult } from './server-start';
export { serverUpgrade } from './server-upgrade';
@@ -45,13 +41,10 @@ export {
export { getEngineVersionRange } from '@/cli/utilities/version/get-engine-version-range';
export { resolveHighestEngineVersion } from '@/cli/utilities/version/resolve-highest-engine-version';
-// Config
export { ConfigService } from '@/cli/utilities/config/config-service';
-// Constants
export { DEV_API_KEY, DEV_API_URL } from '@/cli/constants/dev-api-key';
-// Shared types and error codes
export {
APP_ERROR_CODES,
AUTH_ERROR_CODES,
diff --git a/packages/twenty-sdk/src/cli/utilities/entity/__tests__/get-view-base-file.spec.ts b/packages/twenty-sdk/src/cli/utilities/entity/__tests__/get-view-base-file.spec.ts
index a8ee2521a1c..e032711fe74 100644
--- a/packages/twenty-sdk/src/cli/utilities/entity/__tests__/get-view-base-file.spec.ts
+++ b/packages/twenty-sdk/src/cli/utilities/entity/__tests__/get-view-base-file.spec.ts
@@ -103,7 +103,6 @@ describe('getViewBaseFile', () => {
],
});
- // Default isVisible is true, default size is 200
expect(result).toContain('isVisible: true');
expect(result).toContain('size: 200');
});
@@ -137,7 +136,6 @@ describe('getViewBaseFile', () => {
],
});
- // The field should get a generated universalIdentifier
const uuidRegex =
/[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}/g;
const matches = result.match(uuidRegex);
diff --git a/packages/twenty-sdk/src/cli/utilities/file/__tests__/append-server-variables.util.spec.ts b/packages/twenty-sdk/src/cli/utilities/file/__tests__/append-server-variables.util.spec.ts
index c6aab9fb56b..c564f3d4e76 100644
--- a/packages/twenty-sdk/src/cli/utilities/file/__tests__/append-server-variables.util.spec.ts
+++ b/packages/twenty-sdk/src/cli/utilities/file/__tests__/append-server-variables.util.spec.ts
@@ -60,7 +60,6 @@ export default defineApplication({
expect(updated).toContain('LINEAR_CLIENT_ID');
expect(updated).toContain('LINEAR_CLIENT_SECRET');
- // Existing entry survives.
expect(updated).toContain('EXISTING_VAR');
// New entries land inside the existing block, not in a new one.
expect(updated.match(/serverVariables\s*:\s*\{/g)?.length).toBe(1);
@@ -91,7 +90,6 @@ export default defineApplication({
expect(updated).toContain('serverVariables: {');
expect(updated).toContain('LINEAR_CLIENT_ID');
expect(updated).toContain('LINEAR_CLIENT_SECRET');
- // The defineApplication() closing should still be there.
expect(updated).toMatch(/\}\)\s*;?\s*$/);
});
diff --git a/packages/twenty-sdk/src/sdk/define/front-component/__tests__/define-front-component.spec.ts b/packages/twenty-sdk/src/sdk/define/front-component/__tests__/define-front-component.spec.ts
index 54d3fb150c6..10f2ec4f2bf 100644
--- a/packages/twenty-sdk/src/sdk/define/front-component/__tests__/define-front-component.spec.ts
+++ b/packages/twenty-sdk/src/sdk/define/front-component/__tests__/define-front-component.spec.ts
@@ -1,6 +1,5 @@
import { defineFrontComponent } from '@/sdk/define';
-// Mock component for testing
const MockComponent = () => null;
describe('defineFrontComponent', () => {
diff --git a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser.ts b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser.ts
index e21e9b576b0..9ba2e60f04b 100644
--- a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser.ts
+++ b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser.ts
@@ -155,7 +155,6 @@ export class GraphqlQueryParser {
): void {
// Add ORDER BY columns with underscore alias for DISTINCT compatibility
// This must be called AFTER setFindOptions because setFindOptions clears addSelect
- // We need to add columns that are in orderBy but NOT in the selected columns
for (const orderByKey of Object.keys(parsedOrderBy)) {
const parts = orderByKey.split('.');
@@ -194,7 +193,6 @@ export class GraphqlQueryParser {
? ` ${orderByCondition.nulls}`
: '';
- // Convert "alias.column" to quoted SQL identifier "alias"."column"
const parts = orderByField.split('.');
const quotedColumn =
parts.length === 2
diff --git a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/utils/cursors.util.ts b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/utils/cursors.util.ts
index 1ee6761fb2f..2ed6649c0e6 100644
--- a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/utils/cursors.util.ts
+++ b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/utils/cursors.util.ts
@@ -82,7 +82,6 @@ export const encodeCursor = <T extends ObjectRecord = ObjectRecord>({
continue;
}
- // Write it back under the same path
let container = orderByValues;
for (const key of leaf.path.slice(0, -1)) {
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-query-builder/utils/composite-field-metadata.util.ts b/packages/twenty-server/src/engine/api/graphql/workspace-query-builder/utils/composite-field-metadata.util.ts
index 4dc21dd6fd3..60a6bdc37ab 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-query-builder/utils/composite-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-query-builder/utils/composite-field-metadata.util.ts
@@ -1,9 +1,3 @@
-/**
- * Composite key are structured as follows:
- * COMPOSITE___{parentFieldName}_{childFieldName}
- * This util are here to pre-process and post-process the composite keys before and after querying the database
- */
-
export const compositeFieldPrefix = 'COMPOSITE___';
export const createCompositeFieldKey = (
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface.ts b/packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface.ts
index 24461cf2611..d73f3be030a 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface.ts
@@ -17,8 +17,6 @@ import { type workspaceResolverBuilderMethodNames } from 'src/engine/api/graphql
// oxlint-disable-next-line typescript/no-explicit-any
export type Resolver<Args = any> = GraphQLFieldResolver<any, any, Args>;
-// Use RESOLVER_METHOD_NAMES as the single source of truth for operation names
-// This avoids duplication and ensures consistency across the codebase
export const ResolverArgsType = RESOLVER_METHOD_NAMES;
export interface FindManyResolverArgs<
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/create-input/composite-field-metadata-create-gql-input-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/create-input/composite-field-metadata-create-gql-input-type.generator.ts
index 6403c289eec..96b7defa427 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/create-input/composite-field-metadata-create-gql-input-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/create-input/composite-field-metadata-create-gql-input-type.generator.ts
@@ -50,7 +50,6 @@ export class CompositeFieldMetadataCreateGqlInputTypeGenerator {
const fields: GraphQLInputFieldConfigMap = {};
for (const property of compositeType.properties) {
- // Relation fields are not supported in composite types
if (isMorphOrRelationFieldMetadataType(property.type)) {
this.logger.error(
'Relation fields are not supported in composite types',
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/filter-input/composite-field-metadata-filter-gql-input-types.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/filter-input/composite-field-metadata-filter-gql-input-types.generator.ts
index 2e355bbf7a5..ea4566b6d4f 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/filter-input/composite-field-metadata-filter-gql-input-types.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/filter-input/composite-field-metadata-filter-gql-input-types.generator.ts
@@ -51,7 +51,6 @@ export class CompositeFieldMetadataFilterGqlInputTypeGenerator {
for (const property of compositeType.properties) {
property.isRequired = false;
- // Relation fields are not supported in composite types
if (isMorphOrRelationFieldMetadataType(property.type)) {
this.logger.error(
'Relation fields are not supported in composite types',
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/group-by-input/composite-field-metadata-group-by-gql-input-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/group-by-input/composite-field-metadata-group-by-gql-input-type.generator.ts
index 46add435f18..b3c8af56077 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/group-by-input/composite-field-metadata-group-by-gql-input-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/group-by-input/composite-field-metadata-group-by-gql-input-type.generator.ts
@@ -45,7 +45,6 @@ export class CompositeFieldMetadataGroupByGqlInputTypeGenerator {
const fields: GraphQLInputFieldConfigMap = {};
for (const property of compositeType.properties) {
- // Relation fields are not supported in composite types
if (isMorphOrRelationFieldMetadataType(property.type)) {
this.logger.error(
'Relation fields are not supported in composite types',
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/order-by-input/composite-field-metadata-order-by-gql-input-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/order-by-input/composite-field-metadata-order-by-gql-input-type.generator.ts
index d75b0999d70..5e93e7dc11b 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/order-by-input/composite-field-metadata-order-by-gql-input-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/order-by-input/composite-field-metadata-order-by-gql-input-type.generator.ts
@@ -46,7 +46,6 @@ export class CompositeFieldMetadataOrderByGqlInputTypeGenerator {
for (const property of compositeType.properties) {
property.isRequired = false;
- // Relation fields are not supported in composite types
if (isMorphOrRelationFieldMetadataType(property.type)) {
this.logger.error(
'Relation fields are not supported in composite types',
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/update-input/composite-field-metadata-update-gql-input-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/update-input/composite-field-metadata-update-gql-input-type.generator.ts
index 3bb9671f193..56bad313be7 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/update-input/composite-field-metadata-update-gql-input-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/update-input/composite-field-metadata-update-gql-input-type.generator.ts
@@ -51,7 +51,6 @@ export class CompositeFieldMetadataUpdateGqlInputTypeGenerator {
for (const property of compositeType.properties) {
property.isRequired = false;
- // Relation fields are not supported in composite types
if (isMorphOrRelationFieldMetadataType(property.type)) {
this.logger.error(
'Relation fields are not supported in composite types',
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/composite-field-metadata-gql-object-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/composite-field-metadata-gql-object-type.generator.ts
index 1fa16e5a047..6de8878a369 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/composite-field-metadata-gql-object-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/composite-field-metadata-gql-object-type.generator.ts
@@ -44,7 +44,6 @@ export class CompositeFieldMetadataGqlObjectTypeGenerator {
const fields: GraphQLOutputTypeFieldConfigMap = {};
for (const property of compositeType.properties) {
- // Relation fields are not supported in composite types
if (isMorphOrRelationFieldMetadataType(property.type)) {
this.logger.error(
'Relation fields are not supported in composite types',
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts
index 3109998cd4d..392877cd394 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts
@@ -61,7 +61,6 @@ export class ObjectMetadataWithRelationsGqlObjectTypeGenerator {
isMorphOrRelationFieldMetadataType(field.type),
);
- // Security check to avoid extending an object that does not need to be extended
if (!containsRelationOrMorphField) {
this.logger.error(
`This object does not need to be extended: ${flatObjectMetadata.id.toString()}`,
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-types/object/page-into.object-type.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-types/object/page-into.object-type.ts
index 142a56e3171..c21e35b6e26 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-types/object/page-into.object-type.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-types/object/page-into.object-type.ts
@@ -2,9 +2,6 @@ import { GraphQLBoolean, GraphQLNonNull, GraphQLObjectType } from 'graphql';
import { ConnectionCursorScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
-/**
- * GraphQL PageInfo type.
- */
export const PageInfoType = new GraphQLObjectType({
name: 'PageInfo',
fields: {
diff --git a/packages/twenty-server/src/engine/api/mcp/utils/__tests__/write-sse-event.util.spec.ts b/packages/twenty-server/src/engine/api/mcp/utils/__tests__/write-sse-event.util.spec.ts
index 03c7eb0df6e..63a248190cc 100644
--- a/packages/twenty-server/src/engine/api/mcp/utils/__tests__/write-sse-event.util.spec.ts
+++ b/packages/twenty-server/src/engine/api/mcp/utils/__tests__/write-sse-event.util.spec.ts
@@ -27,9 +27,7 @@ describe('writeSseEvent', () => {
const written = mockResponse.write.mock.calls[0][0] as string;
- // Must start with "event: message\n"
expect(written.startsWith('event: message\n')).toBe(true);
- // Must contain "data: " followed by valid JSON
const dataLine = written.split('\n')[1];
expect(dataLine).toBeDefined();
diff --git a/packages/twenty-server/src/engine/api/rest/input-request-parsers/filter-parser-utils/parse-base-filter.util.ts b/packages/twenty-server/src/engine/api/rest/input-request-parsers/filter-parser-utils/parse-base-filter.util.ts
index 077def6113b..ec0dbfafdde 100644
--- a/packages/twenty-server/src/engine/api/rest/input-request-parsers/filter-parser-utils/parse-base-filter.util.ts
+++ b/packages/twenty-server/src/engine/api/rest/input-request-parsers/filter-parser-utils/parse-base-filter.util.ts
@@ -14,10 +14,6 @@ export enum FilterComparators {
endsWith = 'endsWith',
like = 'like',
ilike = 'ilike',
-
- // Not handled rigth now
- // regex = 'regex',
- // iregex = 'iregex',
}
export const parseBaseFilter = (
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-health.service.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-health.service.ts
index b8300527c21..3937e302fbc 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-health.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-health.service.ts
@@ -256,23 +256,23 @@ export class AdminPanelHealthService {
switch (timeRange) {
case QueueMetricsTimeRange.OneHour:
- pointsNeeded = 60; // 60 points (1 hour)
+ pointsNeeded = 60;
break;
case QueueMetricsTimeRange.FourHours:
- pointsNeeded = 4 * 60; // 240 points (4 hours)
+ pointsNeeded = 4 * 60;
break;
case QueueMetricsTimeRange.TwelveHours:
- pointsNeeded = 12 * 60; // 720 points (12 hours)
+ pointsNeeded = 12 * 60;
break;
case QueueMetricsTimeRange.OneDay:
- pointsNeeded = 24 * 60; // 1440 points (24 hours)
+ pointsNeeded = 24 * 60;
break;
case QueueMetricsTimeRange.SevenDays:
- pointsNeeded = 7 * 24 * 60; // 10080 points (7 days)
+ pointsNeeded = 7 * 24 * 60;
break;
default:
- pointsNeeded = 24 * 60; // Default to 1 day
+ pointsNeeded = 24 * 60;
}
const samplingFactor =
diff --git a/packages/twenty-server/src/engine/core-modules/api-key/controllers/api-key.controller.ts b/packages/twenty-server/src/engine/core-modules/api-key/controllers/api-key.controller.ts
index 43303e19093..c3f936b0ebe 100644
--- a/packages/twenty-server/src/engine/core-modules/api-key/controllers/api-key.controller.ts
+++ b/packages/twenty-server/src/engine/core-modules/api-key/controllers/api-key.controller.ts
@@ -31,10 +31,7 @@ import { SettingsPermissionGuard } from 'src/engine/guards/settings-permission.g
import { PermissionsRestApiExceptionFilter } from 'src/engine/metadata-modules/permissions/utils/permissions-rest-api-exception.filter';
import { AuthRestApiExceptionFilter } from 'src/engine/core-modules/auth/filters/auth-rest-api-exception.filter';
-/**
- * rest/apiKeys is deprecated, use rest/metadata/apiKeys instead
- * rest/apiKeys will be removed in the future
- */
+// rest/apiKeys is deprecated in favor of rest/metadata/apiKeys and will be removed
@Controller([`${ApiPath.Rest}/apiKeys`, `${ApiPath.Rest}/metadata/apiKeys`])
@UseGuards(
JwtAuthGuard,
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-manifest/application-manifest-migration.service.ts b/packages/twenty-server/src/engine/core-modules/application/application-manifest/application-manifest-migration.service.ts
index 79420f85e69..c421b49f4a4 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-manifest/application-manifest-migration.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-manifest/application-manifest-migration.service.ts
@@ -63,9 +63,6 @@ export class ApplicationManifestMigrationService {
);
}
- // Will be sync with inferDeletionFromMissingEntities: false to produces a purely
- // additive migration that registers the pre-install logic function without
- // touching any previously-synced metadata (important on upgrades).
const preInstallOnlyManifest: Manifest = {
application: manifest.application,
objects: [],
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-marketplace/marketplace.service.ts b/packages/twenty-server/src/engine/core-modules/application/application-marketplace/marketplace.service.ts
index b94c5b46720..9b7a1faac08 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-marketplace/marketplace.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-marketplace/marketplace.service.ts
@@ -8,7 +8,7 @@ import { z } from 'zod';
import { buildRegistryCdnUrl } from 'src/engine/core-modules/application/application-marketplace/utils/build-registry-cdn-url.util';
import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-const MAX_REGISTRY_ASSET_SIZE_BYTES = 10 * 1024 * 1024; // 10Mb
+const MAX_REGISTRY_ASSET_SIZE_BYTES = 10 * 1024 * 1024;
const REGISTRY_SEARCH_PAGE_SIZE = 250;
const REGISTRY_SEARCH_MAX_RESULTS = 10_000;
const REGISTRY_SEARCH_MAX_PAGES = Math.ceil(
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-oauth/controllers/oauth-registration.controller.ts b/packages/twenty-server/src/engine/core-modules/application/application-oauth/controllers/oauth-registration.controller.ts
index 1cdb8d31d7f..1215beef94e 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-oauth/controllers/oauth-registration.controller.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-oauth/controllers/oauth-registration.controller.ts
@@ -34,7 +34,6 @@ import { NoPermissionGuard } from 'src/engine/guards/no-permission.guard';
import { PublicEndpointGuard } from 'src/engine/guards/public-endpoint.guard';
import { Repository } from 'typeorm';
-// RFC 7591: 10 registrations per hour per IP
const REGISTRATION_RATE_LIMIT_MAX =
process.env.NODE_ENV === NodeEnvironment.DEVELOPMENT ? 100 : 10;
const REGISTRATION_RATE_LIMIT_WINDOW_MS = 3_600_000;
@@ -90,7 +89,6 @@ export class OAuthRegistrationController {
};
}
- // Validate grant_types — only authorization_code allowed for dynamic clients
const grantTypes = body.grant_types ?? ['authorization_code'];
for (const grantType of grantTypes) {
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-oauth/oauth.service.ts b/packages/twenty-server/src/engine/core-modules/application/application-oauth/oauth.service.ts
index a69b3c8f9f6..368861758f6 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-oauth/oauth.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-oauth/oauth.service.ts
@@ -358,7 +358,6 @@ export class OAuthService {
const applicationRegistration = clientValidation;
- // Confidential clients (those with a secret) must authenticate
if (
isConfidentialApplicationOAuthClient(applicationRegistration) &&
!isNonEmptyString(clientSecret)
@@ -386,7 +385,6 @@ export class OAuthService {
refreshToken,
);
- // Verify the refresh token belongs to this client
const application = await this.applicationRepository.findOne(
payload.workspaceId,
{
@@ -441,7 +439,6 @@ export class OAuthService {
}
// RFC 7009: Token revocation
- // Returns true if token was successfully processed (even if already invalid)
async revokeToken(params: {
token: string;
clientId?: string;
@@ -553,7 +550,6 @@ export class OAuthService {
return { active: false };
}
- // Verify the token belongs to this client
const application = await this.applicationRepository.findOne(
decoded.workspaceId,
{
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-oauth/stale-registration-cleanup/constants/stale-registration-cleanup-cron-pattern.constant.ts b/packages/twenty-server/src/engine/core-modules/application/application-oauth/stale-registration-cleanup/constants/stale-registration-cleanup-cron-pattern.constant.ts
index 7b7dcf9075a..7af575e3a00 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-oauth/stale-registration-cleanup/constants/stale-registration-cleanup-cron-pattern.constant.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-oauth/stale-registration-cleanup/constants/stale-registration-cleanup-cron-pattern.constant.ts
@@ -1,2 +1 @@
-// Runs daily at 02:30 AM UTC
export const STALE_REGISTRATION_CLEANUP_CRON_PATTERN = '30 2 * * *';
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-registration-variable/application-registration-variable.service.ts b/packages/twenty-server/src/engine/core-modules/application/application-registration-variable/application-registration-variable.service.ts
index 4c063d33ab9..81b833af099 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-registration-variable/application-registration-variable.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-registration-variable/application-registration-variable.service.ts
@@ -98,7 +98,6 @@ export class ApplicationRegistrationVariableService {
return this.toObfuscatedDTO(entity);
}
- // Syncs variable schemas from manifest: creates missing, updates metadata, removes stale
async syncVariableSchemas(
applicationRegistrationId: string,
serverVariables: ServerVariables,
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration-summary.resolver.ts b/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration-summary.resolver.ts
index a412733d5f3..5b022e9b937 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration-summary.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration-summary.resolver.ts
@@ -5,8 +5,6 @@ import { ApplicationRegistrationAssetUrlService } from 'src/engine/core-modules/
import { ApplicationRegistrationEntity } from 'src/engine/core-modules/application/application-registration/application-registration.entity';
import { ApplicationRegistrationSummaryDTO } from 'src/engine/core-modules/application/application-registration/dtos/application-registration-summary.dto';
-// The summary is resolved from ApplicationRegistrationEntity instances loaded
-// through the Application.applicationRegistration relation.
@MetadataResolver(() => ApplicationRegistrationSummaryDTO)
export class ApplicationRegistrationSummaryResolver {
constructor(
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration.service.ts b/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration.service.ts
index 5d895de2347..9cd3f8000d8 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration.service.ts
@@ -1292,7 +1292,6 @@ export class ApplicationRegistrationService {
params.applicationRegistrationId,
);
- // Only unclaimed registrations (no owner workspace) can be claimed.
if (isDefined(registration.ownerWorkspaceId)) {
throw new ApplicationRegistrationException(
'Application registration is already owned by a workspace',
diff --git a/packages/twenty-server/src/engine/core-modules/auth/utils/get-google-apis-oauth-scopes.ts b/packages/twenty-server/src/engine/core-modules/auth/utils/get-google-apis-oauth-scopes.ts
index bf15abced74..c86cc868939 100644
--- a/packages/twenty-server/src/engine/core-modules/auth/utils/get-google-apis-oauth-scopes.ts
+++ b/packages/twenty-server/src/engine/core-modules/auth/utils/get-google-apis-oauth-scopes.ts
@@ -1,6 +1,4 @@
-/** email, profile and openid permission can be called without the https://www.googleapis.com/auth/ prefix
- * see https://developers.google.com/identity/protocols/oauth2/scopes
- */
+// email and profile take no googleapis.com/auth/ prefix, see https://developers.google.com/identity/protocols/oauth2/scopes
export const getGoogleApisOauthScopes = () => {
return [
'email',
diff --git a/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/get-subscription-id-from-invoice.util.ts b/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/get-subscription-id-from-invoice.util.ts
index 0c339151034..638625b6e8e 100644
--- a/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/get-subscription-id-from-invoice.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/get-subscription-id-from-invoice.util.ts
@@ -2,15 +2,9 @@
import type Stripe from 'stripe';
-/**
- * Extracts the subscription ID from a Stripe invoice.
- *
- * In Stripe SDK v19+, the subscription field moved from `Invoice.subscription`
- * to `Invoice.parent.subscription_details.subscription`.
- *
- * This utility handles both structures for backward compatibility with invoices
- * created before the SDK migration.
- */
+// Stripe SDK v19 moved the subscription from `Invoice.subscription` to
+// `Invoice.parent.subscription_details.subscription`; invoices created before
+// the migration still carry the old field.
export const getSubscriptionIdFromInvoice = (
invoice: Stripe.Invoice,
): string | undefined => {
diff --git a/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/transform-stripe-subscription-event-to-database-subscription.util.ts b/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/transform-stripe-subscription-event-to-database-subscription.util.ts
index 2a3e994ba35..8155f2e1a1f 100644
--- a/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/transform-stripe-subscription-event-to-database-subscription.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/transform-stripe-subscription-event-to-database-subscription.util.ts
@@ -12,7 +12,6 @@ import { type SubscriptionInterval } from 'src/engine/core-modules/billing/enums
import { SubscriptionStatus } from 'src/engine/core-modules/billing/enums/billing-subscription-status.enum';
import { type SubscriptionWithSchedule } from 'src/engine/core-modules/billing/types/billing-subscription-with-schedule.type';
-// Converts Stripe AutomaticTax to serialized JSON for JSONB storage
// Normalizes expandable fields (e.g., liability.account) to string IDs
const toAutomaticTaxJson = (
value: Stripe.Subscription.AutomaticTax | null | undefined,
diff --git a/packages/twenty-server/src/engine/core-modules/billing/billing-gauge.service.ts b/packages/twenty-server/src/engine/core-modules/billing/billing-gauge.service.ts
index a5df2aa1141..d93a203dc82 100644
--- a/packages/twenty-server/src/engine/core-modules/billing/billing-gauge.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/billing/billing-gauge.service.ts
@@ -81,7 +81,6 @@ export class BillingGaugeService implements OnModuleInit {
try {
const ageThreshold = new Date(Date.now() - WORKSPACE_AGE_THRESHOLD_MS);
- // Find the most recently created workspace that is older than 1 minute
const lastWorkspace = await this.workspaceRepository.findOne({
where: {
deletedAt: IsNull(),
diff --git a/packages/twenty-server/src/engine/core-modules/billing/billing.resolver.ts b/packages/twenty-server/src/engine/core-modules/billing/billing.resolver.ts
index 4fb7096721e..c955b1d383f 100644
--- a/packages/twenty-server/src/engine/core-modules/billing/billing.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/billing/billing.resolver.ts
@@ -147,8 +147,6 @@ export class BillingResolver {
interval: recurringInterval,
});
- // For 7-day trials (no payment method required), create subscription directly
- // For 30-day trials (payment method required), use checkout session flow
if (!requirePaymentMethod) {
const successUrl =
await this.billingPortalWorkspaceService.createDirectSubscription({
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/billing-credit-grant.service.ts b/packages/twenty-server/src/engine/core-modules/billing/services/billing-credit-grant.service.ts
index ac8aefff865..d23694ee6af 100644
--- a/packages/twenty-server/src/engine/core-modules/billing/services/billing-credit-grant.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/billing/services/billing-credit-grant.service.ts
@@ -168,7 +168,6 @@ export class BillingCreditGrantService {
};
}
- // Grants that were spendable at any point during the given period.
async findGrantsLiveDuringPeriod(
{
workspaceId,
diff --git a/packages/twenty-server/src/engine/core-modules/billing/utils/bigint-column-transformer.util.ts b/packages/twenty-server/src/engine/core-modules/billing/utils/bigint-column-transformer.util.ts
index 9abe0ade85d..e21cf7e6b81 100644
--- a/packages/twenty-server/src/engine/core-modules/billing/utils/bigint-column-transformer.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/billing/utils/bigint-column-transformer.util.ts
@@ -1,8 +1,6 @@
/* @license Enterprise */
-// Postgres returns bigint as a string, so it needs coercing back. Shared by the
-// micro-denominated credit columns so the ledger and the mirror it sums into
-// cannot coerce differently.
+// Postgres returns bigint as a string, so it needs coercing back.
//
// Number() is only lossless below 2^53, which is 9e9 credits at
// INTERNAL_CREDITS_PER_DISPLAY_CREDIT. Balances are bounded well under that by
diff --git a/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts b/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts
index 7835edf36ae..28404c5e1b9 100644
--- a/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts
@@ -185,7 +185,6 @@ export class TimelineCalendarEventService {
})
: [];
- // Resolve current user's userWorkspaceId (workspaceMember → userId → userWorkspace)
const workspaceMemberRepo =
this.workspaceOrmManager.getRepository<WorkspaceMemberWorkspaceEntity>(
'workspaceMember',
diff --git a/packages/twenty-server/src/engine/core-modules/enterprise/constants/organization-key-validation-cron-pattern.constant.ts b/packages/twenty-server/src/engine/core-modules/enterprise/constants/organization-key-validation-cron-pattern.constant.ts
index aac677ba02b..5065a9dac9e 100644
--- a/packages/twenty-server/src/engine/core-modules/enterprise/constants/organization-key-validation-cron-pattern.constant.ts
+++ b/packages/twenty-server/src/engine/core-modules/enterprise/constants/organization-key-validation-cron-pattern.constant.ts
@@ -1,2 +1 @@
-// Run daily at 4 AM UTC
export const ENTERPRISE_KEY_VALIDATION_CRON_PATTERN = '0 4 * * *';
diff --git a/packages/twenty-server/src/engine/core-modules/enterprise/enterprise.resolver.ts b/packages/twenty-server/src/engine/core-modules/enterprise/enterprise.resolver.ts
index 7b0454ece00..86f9dc71b40 100644
--- a/packages/twenty-server/src/engine/core-modules/enterprise/enterprise.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/enterprise/enterprise.resolver.ts
@@ -74,7 +74,6 @@ export class EnterpriseResolver {
@Query(() => String, { nullable: true })
async enterprisePortalSession(
- // for existing subscriptions
@Args('returnUrlPath', { nullable: true }) returnUrlPath?: string,
): Promise<string | null> {
return this.enterprisePlanService.getPortalUrl(returnUrlPath ?? undefined);
@@ -82,7 +81,6 @@ export class EnterpriseResolver {
@Query(() => String, { nullable: true })
async enterpriseCheckoutSession(
- // for new subscriptions
@Args('billingInterval', { nullable: true }) billingInterval?: string,
): Promise<string | null> {
const interval = billingInterval === 'yearly' ? 'yearly' : 'monthly';
diff --git a/packages/twenty-server/src/engine/core-modules/feature-flag/validates/is-public-feature-flag.validate.spec.ts b/packages/twenty-server/src/engine/core-modules/feature-flag/validates/is-public-feature-flag.validate.spec.ts
index 54495b36ecc..f439fd9766d 100644
--- a/packages/twenty-server/src/engine/core-modules/feature-flag/validates/is-public-feature-flag.validate.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/feature-flag/validates/is-public-feature-flag.validate.spec.ts
@@ -37,11 +37,6 @@ jest.mock(
}),
);
-// Note: We're using a single public flag for testing as it's sufficient to verify
-// the validator's behavior. The validator's role is to check if a flag exists in
-// the PUBLIC_FEATURE_FLAGS array, so testing with one flag adequately covers this
-// functionality. Adding more flags wouldn't increase the test coverage meaningfully.
-
describe('publicFeatureFlagValidator', () => {
describe('assertIsPublicFeatureFlag', () => {
const mockException = new AuthException(
diff --git a/packages/twenty-server/src/engine/core-modules/graphql/filters/prevent-nest-to-auto-log-graphql-errors.filter.ts b/packages/twenty-server/src/engine/core-modules/graphql/filters/prevent-nest-to-auto-log-graphql-errors.filter.ts
index 31703a01c5b..fef9c627cb4 100644
--- a/packages/twenty-server/src/engine/core-modules/graphql/filters/prevent-nest-to-auto-log-graphql-errors.filter.ts
+++ b/packages/twenty-server/src/engine/core-modules/graphql/filters/prevent-nest-to-auto-log-graphql-errors.filter.ts
@@ -6,11 +6,7 @@ import {
import { GraphQLError } from 'graphql';
-/**
- * In NestJS, if an exception is not handled, it will shown in the logs
- * This filter is used to prevent NestJS from auto-logging GraphQL errors
- * and leave it to the GraphQL layer to handle the error.
- */
+// NestJS logs every unhandled exception; GraphQL errors are left to the GraphQL layer instead.
@Catch(GraphQLError)
export class PreventNestToAutoLogGraphqlErrorsFilter implements ExceptionFilter {
catch(exception: GraphQLError, _host: ArgumentsHost) {
diff --git a/packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts b/packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts
index 81d58ec9894..8113c7012dd 100644
--- a/packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts
+++ b/packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts
@@ -46,10 +46,7 @@ type GraphQLErrorHandlerHookOptions = {
i18nService: I18nService;
twentyConfigService: TwentyConfigService;
- /**
- * The key of the event id in the error's extension. `null` to disable.
- * @default exceptionEventId
- */
+ // `null` disables the event id extension; any other value falls back to DEFAULT_EVENT_ID_KEY.
eventIdKey?: string | null;
};
diff --git a/packages/twenty-server/src/engine/core-modules/graphql/utils/graphql-errors.util.ts b/packages/twenty-server/src/engine/core-modules/graphql/utils/graphql-errors.util.ts
index b908f124d70..97778737117 100644
--- a/packages/twenty-server/src/engine/core-modules/graphql/utils/graphql-errors.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/graphql/utils/graphql-errors.util.ts
@@ -248,10 +248,6 @@ export class InternalServerError extends BaseGraphQLError {
}
}
-/**
- * Converts a GraphQLError to a BaseGraphQLError with the appropriate ErrorCode
- * based on HTTP status code if present in extensions.
- */
export const convertGraphQLErrorToBaseGraphQLError = (
error: GraphQLError,
): BaseGraphQLError => {
diff --git a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/drivers/lambda/constants/lambda-driver.constant.ts b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/drivers/lambda/constants/lambda-driver.constant.ts
index db962e44024..b7dbcf90c27 100644
--- a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/drivers/lambda/constants/lambda-driver.constant.ts
+++ b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/drivers/lambda/constants/lambda-driver.constant.ts
@@ -3,7 +3,7 @@ import { join, resolve } from 'path';
import { ASSET_PATH } from 'src/constants/assets-path';
export const UPDATE_FUNCTION_DURATION_TIMEOUT_IN_SECONDS = 60;
-export const CREDENTIALS_DURATION_IN_SECONDS = 60 * 60; // 1h
+export const CREDENTIALS_DURATION_IN_SECONDS = 60 * 60;
export const LAMBDA_CLIENT_MAX_ATTEMPTS = 8;
export const LAMBDA_CLIENT_RETRY_MODE = 'adaptive' as const;
diff --git a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/utils/create-zip-file.ts b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/utils/create-zip-file.ts
index e6fe0b827a1..be633769aef 100644
--- a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/utils/create-zip-file.ts
+++ b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/utils/create-zip-file.ts
@@ -9,7 +9,7 @@ export const createZipFile = async (
): Promise<void> => {
const output = fs.createWriteStream(outPath);
const archive = archiver('zip', {
- zlib: { level: 9 }, // Compression level
+ zlib: { level: 9 },
});
const p = pipeline(archive, output);
diff --git a/packages/twenty-server/src/engine/core-modules/message-queue/decorators/processor.decorator.ts b/packages/twenty-server/src/engine/core-modules/message-queue/decorators/processor.decorator.ts
index de3608444de..ae8dfb8fdeb 100644
--- a/packages/twenty-server/src/engine/core-modules/message-queue/decorators/processor.decorator.ts
+++ b/packages/twenty-server/src/engine/core-modules/message-queue/decorators/processor.decorator.ts
@@ -7,13 +7,7 @@ import {
} from 'src/engine/core-modules/message-queue/message-queue.constants';
export interface MessageQueueProcessorOptions {
- /**
- * Specifies the name of the queue to subscribe to.
- */
queueName: MessageQueue;
- /**
- * Specifies the lifetime of an injected Processor.
- */
scope?: Scope;
}
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/services/create-record.service.ts b/packages/twenty-server/src/engine/core-modules/record-crud/services/create-record.service.ts
index c503e6844e6..376b357e95c 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/services/create-record.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/services/create-record.service.ts
@@ -62,8 +62,6 @@ export class CreateRecordService {
name: 'Workflow',
};
- // Clean undefined values from the record data (including nested composite fields)
- // This prevents validation errors for partial composite field inputs
const cleanedRecord = removeUndefinedFromRecord(objectRecord);
const dataWithActor = { ...cleanedRecord, createdBy: actorMetadata };
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/services/update-record.service.ts b/packages/twenty-server/src/engine/core-modules/record-crud/services/update-record.service.ts
index 4435045fa22..0f8d3d8ed7a 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/services/update-record.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/services/update-record.service.ts
@@ -90,8 +90,6 @@ export class UpdateRecordService {
};
}
- // Clean undefined values from the record data (including nested composite fields)
- // This prevents validation errors for partial composite field inputs
const cleanedRecord = removeUndefinedFromRecord(filteredObjectRecord);
const { results: updatedRecord } =
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/services/upsert-record.service.ts b/packages/twenty-server/src/engine/core-modules/record-crud/services/upsert-record.service.ts
index cd2ca173087..0c19ef9e71f 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/services/upsert-record.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/services/upsert-record.service.ts
@@ -44,11 +44,8 @@ export class UpsertRecordService {
);
}
- // Clean undefined values from the record data (including nested composite fields)
- // This prevents validation errors for partial composite field inputs
const cleanedRecord = removeUndefinedFromRecord(objectRecord);
- // Use Common API with upsert flag - it handles conflict detection automatically
const { results: upsertedRecord } =
await this.commonCreateOneRunner.execute(
{
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/utils/remove-undefined-from-record.util.ts b/packages/twenty-server/src/engine/core-modules/record-crud/utils/remove-undefined-from-record.util.ts
index 056fae931eb..82ae30f7db0 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/utils/remove-undefined-from-record.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/utils/remove-undefined-from-record.util.ts
@@ -1,4 +1,3 @@
-// Recursively removes undefined values from an object
// This is needed because workflows/tools may pass partial composite fields
// with undefined sub-properties, but the validation layer expects either
// a value or null (not undefined)
@@ -12,8 +11,6 @@ export const removeUndefinedFromRecord = <T extends Record<string, unknown>>(
continue;
}
- // Recursively clean nested objects (composite fields like LINKS, ADDRESS, etc.)
- // but preserve arrays as-is (they should be handled separately if needed)
if (typeof value === 'object' && !Array.isArray(value) && value !== null) {
const cleaned = removeUndefinedFromRecord(
value as Record<string, unknown>,
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/zod-schemas/record-filter.zod-schema.ts b/packages/twenty-server/src/engine/core-modules/record-crud/zod-schemas/record-filter.zod-schema.ts
index 3d8b8a828d1..9c74784f7b5 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/zod-schemas/record-filter.zod-schema.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/zod-schemas/record-filter.zod-schema.ts
@@ -10,8 +10,6 @@ import { type ObjectMetadataForToolSchema } from 'src/engine/core-modules/record
import { generateFieldFilterZodSchema } from 'src/engine/core-modules/record-crud/zod-schemas/field-filters.zod-schema';
import { isFieldMetadataEntityOfType } from 'src/engine/utils/is-field-metadata-of-type.util';
-// Builds the per-field filter shape and full recursive filter schema
-// for a given object metadata, reusable across find, delete, and updateMany tools
export const generateRecordFilterSchema = ({
objectMetadata,
restrictedFields,
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/zod-schemas/shared-filter-defs.zod-schema.ts b/packages/twenty-server/src/engine/core-modules/record-crud/zod-schemas/shared-filter-defs.zod-schema.ts
index f87acecb1a4..204c7353a6c 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/zod-schemas/shared-filter-defs.zod-schema.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/zod-schemas/shared-filter-defs.zod-schema.ts
@@ -89,7 +89,6 @@ export const ArrayFieldFilterSchema = z
})
.optional();
-// Composite filter schemas — A1.3
// Each is a shared constant so all LINKS/ADDRESS/etc. fields share one $def.
export const LinksFilterSchema = z
diff --git a/packages/twenty-server/src/engine/core-modules/sso/workspace-sso-identity-provider.entity.ts b/packages/twenty-server/src/engine/core-modules/sso/workspace-sso-identity-provider.entity.ts
index 4343b4aa686..cfb58c27ee8 100644
--- a/packages/twenty-server/src/engine/core-modules/sso/workspace-sso-identity-provider.entity.ts
+++ b/packages/twenty-server/src/engine/core-modules/sso/workspace-sso-identity-provider.entity.ts
@@ -42,7 +42,6 @@ registerEnumType(SsoIdentityProviderStatus, {
@Entity({ name: 'workspaceSSOIdentityProvider', schema: 'core' })
@ObjectType('WorkspaceSSOIdentityProvider')
export class WorkspaceSsoIdentityProviderEntity extends WorkspaceRelatedEntity {
- // COMMON
@Field(() => UUIDScalarType)
@PrimaryGeneratedColumn('uuid')
id: string;
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/compact-tool-output.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/compact-tool-output.util.ts
index 856692e60db..6a5eb4916e3 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/compact-tool-output.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/compact-tool-output.util.ts
@@ -1,9 +1,5 @@
import { stripEmptyValues } from './strip-empty-values.util';
-// Compacts a tool output by stripping empty values and flattening
-// the result structure for efficient LLM token consumption.
-// This is applied as a post-processing step on all tool results
-// before they are returned to the AI model.
export const compactToolOutput = (output: unknown): unknown => {
if (!output || typeof output !== 'object') {
return output;
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/strip-empty-values.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/strip-empty-values.util.ts
index 81c9ee92d03..9897f8b116e 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/strip-empty-values.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/strip-empty-values.util.ts
@@ -1,9 +1,5 @@
-// Recursively strips null, undefined, empty strings, empty objects,
-// and empty arrays from a value. Returns undefined if the entire
-
import { isDate } from '@sniptt/guards';
-// value is empty so the caller can decide whether to include it.
export const stripEmptyValues = (value: unknown): unknown => {
if (value === null || value === undefined || value === '') {
return undefined;
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/resolve-object-icon.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/resolve-object-icon.util.ts
index ea923f7bc65..c638943de99 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/resolve-object-icon.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/resolve-object-icon.util.ts
@@ -1,8 +1,5 @@
import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-// Looks up a core object's icon by its nameSingular. Shared by providers that
-// tag descriptor batches with the icon of the underlying object (workflows,
-// dashboards) so the UI can render per-tool icons.
export const resolveObjectIcon = async (
flatEntityMapsCacheService: WorkspaceManyOrAllFlatEntityMapsCacheService,
workspaceId: string,
diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/cache/config-cache.service.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/cache/config-cache.service.ts
index 2a7ccbc1c80..8251f4753c9 100644
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/cache/config-cache.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/twenty-config/cache/config-cache.service.ts
@@ -76,9 +76,6 @@ export class ConfigCacheService implements OnModuleDestroy {
return [...new Set([...foundKeys, ...missingKeys])];
}
- /**
- * Helper method for testing edge cases
- */
addToMissingKeysForTesting(key: ConfigKey): void {
this.knownMissingKeysCache.add(key);
}
diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/__tests__/database-config.driver.spec.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/__tests__/database-config.driver.spec.ts
index 3f1af18830b..1cadde10cf4 100644
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/__tests__/database-config.driver.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/__tests__/database-config.driver.spec.ts
@@ -132,7 +132,6 @@ describe('DatabaseConfigDriver', () => {
jest.spyOn(configStorage, 'loadAll').mockRejectedValue(error);
jest.spyOn(driver['logger'], 'error').mockImplementation();
- // Should not throw because we're handling errors internally now
await driver.onModuleInit();
expect(driver['logger'].error).toHaveBeenCalled();
diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/database-config.driver.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/database-config.driver.ts
index 589e383c924..49cb6129d20 100644
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/database-config.driver.ts
+++ b/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/database-config.driver.ts
@@ -116,11 +116,6 @@ export class DatabaseConfigDriver
this.configCache.markKeyAsMissing(key);
}
- /**
- * Refreshes all database-backed config variables.
- * This method runs on a schedule and fetches all configs in one database query,
- * then updates the cache with fresh values.
- */
@Cron(CONFIG_VARIABLES_REFRESH_CRON_INTERVAL)
async refreshAllCache(): Promise<void> {
try {
diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/interfaces/database-config-driver.interface.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/interfaces/database-config-driver.interface.ts
index c550498c055..32a47f8954a 100644
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/interfaces/database-config-driver.interface.ts
+++ b/packages/twenty-server/src/engine/core-modules/twenty-config/drivers/interfaces/database-config-driver.interface.ts
@@ -1,32 +1,15 @@
import { type ConfigVariables } from 'src/engine/core-modules/twenty-config/config-variables';
-/**
- * Interface for drivers that support database-backed configuration
- * with caching capabilities
- */
export interface DatabaseConfigDriverInterface {
- /**
- * Get a configuration value from cache
- * Returns undefined if not in cache
- */
get<T extends keyof ConfigVariables>(key: T): ConfigVariables[T] | undefined;
- /**
- * Update a configuration value in the database and cache
- */
update<T extends keyof ConfigVariables>(
key: T,
value: ConfigVariables[T],
): Promise<void>;
- /**
- * Refreshes all entries in the config cache
- */
refreshAllCache(): Promise<void>;
- /**
- * Get information about the cache state
- */
getCacheInfo(): {
foundConfigValues: number;
knownMissingKeys: number;
diff --git a/packages/twenty-server/src/engine/core-modules/usage/utils/to-dollars.util.ts b/packages/twenty-server/src/engine/core-modules/usage/utils/to-dollars.util.ts
index 0ed019c53ed..9611f8c32a9 100644
--- a/packages/twenty-server/src/engine/core-modules/usage/utils/to-dollars.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/usage/utils/to-dollars.util.ts
@@ -1,6 +1,4 @@
import { DOLLAR_TO_CREDIT_MULTIPLIER } from 'src/engine/metadata-modules/ai/ai-billing/constants/dollar-to-credit-multiplier';
-// Converts internal micro-credits to dollars.
-// Rounds to 2 decimal places (e.g. 7500 → 0.01).
export const toDollars = (internalCredits: number): number =>
Math.round((internalCredits / DOLLAR_TO_CREDIT_MULTIPLIER) * 100) / 100;
diff --git a/packages/twenty-server/src/engine/core-modules/user-workspace/guards/upload-profile-picture-permission.guard.ts b/packages/twenty-server/src/engine/core-modules/user-workspace/guards/upload-profile-picture-permission.guard.ts
index bea4c4f9cdc..8fb51b0fb71 100644
--- a/packages/twenty-server/src/engine/core-modules/user-workspace/guards/upload-profile-picture-permission.guard.ts
+++ b/packages/twenty-server/src/engine/core-modules/user-workspace/guards/upload-profile-picture-permission.guard.ts
@@ -41,7 +41,6 @@ export class UploadProfilePicturePermissionGuard implements CanActivate {
const apiKeyId = request.apiKey?.id;
const applicationId = request.application?.id;
- // Allow during workspace creation
if (
[
WorkspaceActivationStatus.PENDING_CREATION,
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/services/core-workflow-version-write.service.ts b/packages/twenty-server/src/engine/core-modules/workflow/services/core-workflow-version-write.service.ts
index 3d72fae7aa8..58decac8ca6 100644
--- a/packages/twenty-server/src/engine/core-modules/workflow/services/core-workflow-version-write.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/workflow/services/core-workflow-version-write.service.ts
@@ -176,9 +176,9 @@ export class CoreWorkflowVersionWriteService {
steps,
});
- // main compared the previous content inside the UPDATE itself to catch two
- // people editing the same draft. The runner cannot express that condition,
- // so the comparison and the write it guards are serialized on this lock.
+ // The runner cannot compare the previous content inside its UPDATE to catch
+ // two people editing the same draft, so the comparison and the write it
+ // guards are serialized on this lock.
await this.withCoreWorkflowVersionEditLock(
coreWorkflowVersionId,
async () => {
diff --git a/packages/twenty-server/src/engine/core-modules/workspace/workspace.resolver.ts b/packages/twenty-server/src/engine/core-modules/workspace/workspace.resolver.ts
index d07886434f1..355df0088d7 100644
--- a/packages/twenty-server/src/engine/core-modules/workspace/workspace.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/workspace/workspace.resolver.ts
@@ -300,7 +300,7 @@ export class WorkspaceResolver {
workspaceCustomFlatApplication,
);
} catch {
- // Temporary should be removed after CreateWorkspaceCustomApplicationCommand is run
+ // TODO: remove this fallback, added while workspaces were being backfilled with a custom application
return null;
}
}
diff --git a/packages/twenty-server/src/engine/guards/public-endpoint.guard.ts b/packages/twenty-server/src/engine/guards/public-endpoint.guard.ts
index c609e005219..cb881f48dd2 100644
--- a/packages/twenty-server/src/engine/guards/public-endpoint.guard.ts
+++ b/packages/twenty-server/src/engine/guards/public-endpoint.guard.ts
@@ -4,17 +4,11 @@ import {
Injectable,
} from '@nestjs/common';
-/**
- * Guard that explicitly marks an endpoint as public/unprotected.
- * This guard always returns true and serves as documentation
- * that the endpoint is intentionally accessible without authentication.
- *
- * Usage: @UseGuards(PublicEndpointGuard)
- */
+// Always passes: an explicit marker that the endpoint is intentionally
+// accessible without authentication.
@Injectable()
export class PublicEndpointGuard implements CanActivate {
canActivate(_context: ExecutionContext): boolean {
- // Always allow access - this is an explicit marker for public endpoints
return true;
}
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/mapDBPartToUIMessagePart.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/mapDBPartToUIMessagePart.ts
index a265a64949b..79a8e6abe19 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/mapDBPartToUIMessagePart.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/mapDBPartToUIMessagePart.ts
@@ -5,7 +5,6 @@ import {
import { AgentMessagePartWorkspaceEntity } from 'src/engine/metadata-modules/ai/ai-history/standard-objects/agent-message-part.workspace-entity';
-// Maps TypeORM entity fields to UI message parts.
// A parallel mapping for GraphQL DTOs exists in the frontend at:
// packages/twenty-front/src/modules/ai/utils/mapDBPartToUIMessagePart.ts
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util.ts
index cf7f935049d..8a62fe6ff60 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util.ts
@@ -44,7 +44,6 @@ export const repairToolCall = async ({
model: LanguageModel;
billingContext?: RepairToolCallBillingContext;
}): Promise<ToolCall | null> => {
- // Don't attempt to fix invalid tool names
if (NoSuchToolError.isInstance(error)) {
return null;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-billing/constants/dollar-to-credit-multiplier.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-billing/constants/dollar-to-credit-multiplier.ts
index 5b979215d13..dfafa20d25c 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-billing/constants/dollar-to-credit-multiplier.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-billing/constants/dollar-to-credit-multiplier.ts
@@ -1,2 +1,2 @@
// Configuration: $0.000_001 = 1 credit
-export const DOLLAR_TO_CREDIT_MULTIPLIER = 1_000_000; // 1 / 0.000_001 = 1_000_000 credits per dollar
+export const DOLLAR_TO_CREDIT_MULTIPLIER = 1_000_000;
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/dtos/agent-chat-thread.dto.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/dtos/agent-chat-thread.dto.ts
index 246c2c934e1..b401ea25eb2 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/dtos/agent-chat-thread.dto.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/dtos/agent-chat-thread.dto.ts
@@ -23,8 +23,7 @@ export class AgentChatThreadDTO {
@Field(() => Int)
conversationSize: number;
- // Credits are converted from internal precision to display precision
- // (internal / 1000) at the resolver level
+ // In display credits; the resolver converts from the stored internal credits
@Field(() => Float)
totalInputCredits: number;
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/jobs/stream-agent-chat.job.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/jobs/stream-agent-chat.job.ts
index 97da0773a74..14fd961f90c 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/jobs/stream-agent-chat.job.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/jobs/stream-agent-chat.job.ts
@@ -603,7 +603,7 @@ export class StreamAgentChatJob {
});
}
} catch {
- // best-effort; the authoritative persist runs onFinish
+ // best-effort; the authoritative persist runs onEnd
}
})();
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/filters/ai-api-exception.filter.ts b/packages/twenty-server/src/engine/metadata-modules/ai/filters/ai-api-exception.filter.ts
index 72cb761e925..db0988450df 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/filters/ai-api-exception.filter.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/filters/ai-api-exception.filter.ts
@@ -38,7 +38,7 @@ export class AiRestApiExceptionFilter implements ExceptionFilter {
return this.httpExceptionHandlerService.handleError(
exception,
response,
- 503, // Service Unavailable - the AI service is not configured
+ 503, // the AI service is not configured
);
case AiExceptionCode.TOOL_CALL_RESOLUTION_FORBIDDEN:
return this.httpExceptionHandlerService.handleError(
diff --git a/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.entity.ts b/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.entity.ts
index f6b7c0690fd..f05aac9f5fb 100644
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.entity.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.entity.ts
@@ -44,8 +44,8 @@ import { SyncableEntity } from 'src/engine/workspace-manager/types/syncable-enti
import { type AuthoredOverrides } from 'src/engine/metadata-modules/overrides/types/authored-overrides.type';
import { JsonbProperty } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/jsonb-property.type';
-// This entity is used as a reference test case for type utilities in:
-// Modifying relations or properties may require updating type test expectations for Typecheck to pass.
+// Reference case for the type tests in types/__tests__/field-metadata-entity.test-type.ts:
+// modifying relations or properties may require updating their expectations for typecheck to pass.
@Entity('fieldMetadata')
@Index('IDX_FIELD_METADATA_APPLICATION_ID', ['applicationId'])
@Check(
@@ -172,7 +172,6 @@ export class FieldMetadataEntity<
@Column({ type: 'boolean', default: false })
isUIReadOnly: WasRemovedInUpgrade<boolean>;
- // Is this really nullable ?
@Column({ nullable: true, default: true, type: 'boolean' })
isNullable: boolean | null;
diff --git a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/compute-column-name.util.ts b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/compute-column-name.util.ts
index babb088ac21..97329dd718d 100644
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/compute-column-name.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/compute-column-name.util.ts
@@ -17,7 +17,6 @@ export type FieldTypeAndNameMetadata = {
type: FieldMetadataType;
};
-// TODO: If we need to implement custom name logic for columns, we can do it here
export function computeColumnName(
fieldMetadataOrFieldName: FieldTypeAndNameMetadata | string,
options?: ComputeColumnNameOptions,
diff --git a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-default-value.ts b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-default-value.ts
index ad3aba4a8f7..65e88227fc4 100644
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-default-value.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-default-value.ts
@@ -4,7 +4,6 @@ import {
FieldMetadataType,
} from 'twenty-shared/types';
-// No need to refactor as unused in workspace migration v2
export function generateDefaultValue(
type: FieldMetadataType,
): FieldMetadataDefaultValue {
diff --git a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/is-field-metadata-settings-of-type.util.ts b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/is-field-metadata-settings-of-type.util.ts
index 51ce9fe5a7d..e9f01d655e5 100644
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/is-field-metadata-settings-of-type.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/is-field-metadata-settings-of-type.util.ts
@@ -14,7 +14,6 @@ export const isFieldMetadataSettingsOfType = <
fieldMetadataType: T,
): settings is FieldMetadataSettingsMapping[T] => {
// Settings don't have a discriminator - the type is determined by fieldMetadataType
- // For required settings types (RELATION, MORPH_RELATION, FILES), ensure settings is defined
if (
fieldMetadataType === FieldMetadataType.RELATION ||
fieldMetadataType === FieldMetadataType.MORPH_RELATION ||
@@ -33,7 +32,6 @@ export const isUniversalFieldMetadataSettingsOftype = <
fieldMetadataType: T,
): settings is UniversalFlatFieldMetadata<T>['universalSettings'] => {
// Settings don't have a discriminator - the type is determined by fieldMetadataType
- // For required settings types (RELATION, MORPH_RELATION, FILES), ensure settings is defined
if (
fieldMetadataType === FieldMetadataType.RELATION ||
fieldMetadataType === FieldMetadataType.MORPH_RELATION ||
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/extract-junction-target-settings-from-settings.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/extract-junction-target-settings-from-settings.util.ts
index 310f9858f67..1afc36ee6ab 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/extract-junction-target-settings-from-settings.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/extract-junction-target-settings-from-settings.util.ts
@@ -6,8 +6,6 @@ type JunctionTargetSettings = {
};
// TODO refactor using either type predicate or FieldMetadataType discriminating union
-// Extracts junction target settings from untyped settings input
-// This function handles the boundary where settings come from external API input
export const extractJunctionTargetSettingsFromSettings = (
settings: AllFieldMetadataSettings | null | undefined,
): JunctionTargetSettings => {
diff --git a/packages/twenty-server/src/engine/metadata-modules/index-metadata/services/index-metadata.service.ts b/packages/twenty-server/src/engine/metadata-modules/index-metadata/services/index-metadata.service.ts
index 74fdf6de75d..5c89e1cdccb 100644
--- a/packages/twenty-server/src/engine/metadata-modules/index-metadata/services/index-metadata.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/index-metadata/services/index-metadata.service.ts
@@ -99,8 +99,6 @@ export class IndexMetadataService {
);
}
- // Resolve each input to a flat field + validated subFieldName (or null
- // for scalar/relation parents).
const resolvedInputs = fieldInputs.map((input) => {
const flatField = findFlatEntityByIdInFlatEntityMaps({
flatEntityMaps: existingFlatFieldMetadataMaps,
@@ -161,7 +159,6 @@ export class IndexMetadataService {
);
}
} else if (isNonEmptyString(input.subFieldName)) {
- // Scalar / relation parent — sub-field doesn't apply.
throw new IndexMetadataException(
`Field ${flatField.name} is not composite — subFieldName must not be set`,
IndexMetadataExceptionCode.INDEX_NOT_SUPPORTED_FOR_COMPOSITE_FIELD,
diff --git a/packages/twenty-server/src/engine/metadata-modules/message-channel/resolvers/message-channel.resolver.ts b/packages/twenty-server/src/engine/metadata-modules/message-channel/resolvers/message-channel.resolver.ts
index 8563a5010be..3592f890cb1 100644
--- a/packages/twenty-server/src/engine/metadata-modules/message-channel/resolvers/message-channel.resolver.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/message-channel/resolvers/message-channel.resolver.ts
@@ -218,7 +218,6 @@ export class MessageChannelResolver {
isDefined(input.update.excludeGroupEmails) &&
input.update.excludeGroupEmails !== messageChannel.excludeGroupEmails
) {
- // Service expects WorkspaceEntity type but only reads .id
await this.messagingProcessGroupEmailActionsService.markMessageChannelAsPendingGroupEmailsAction(
messageChannel as unknown as MessageChannelEntity,
workspace.id,
diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/constants/partial-system-flat-field-metadatas.constant.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/constants/partial-system-flat-field-metadatas.constant.ts
index 9595d03a5b4..99fb5245797 100644
--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/constants/partial-system-flat-field-metadatas.constant.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/constants/partial-system-flat-field-metadatas.constant.ts
@@ -271,8 +271,7 @@ const PARTIAL_SEARCH_VECTOR_FIELD = {
options: null,
overrides: null,
morphId: null,
- // universalSettings for searchVector is computed at runtime
- // based on the name field (getTsVectorColumnExpressionFromFields)
+ // universalSettings for searchVector is computed at runtime from the object's searchFieldMetadata targets
universalSettings: null,
relationTargetObjectMetadataUniversalIdentifier: null,
relationTargetFieldMetadataUniversalIdentifier: null,
diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/create-object.input.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/create-object.input.ts
index 8581bc7b2bd..aaaf0f4929b 100644
--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/create-object.input.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/create-object.input.ts
@@ -86,7 +86,7 @@ export class CreateObjectInput {
@IsBoolean()
@IsOptional()
- @Field({ nullable: true }) // Not nullable to me
+ @Field({ nullable: true })
isLabelSyncedWithName?: boolean;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/utils/compute-metadata-name-from-label-or-throw.util.ts b/packages/twenty-server/src/engine/metadata-modules/utils/compute-metadata-name-from-label-or-throw.util.ts
index 14fccce18d1..3667fc6157b 100644
--- a/packages/twenty-server/src/engine/metadata-modules/utils/compute-metadata-name-from-label-or-throw.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/utils/compute-metadata-name-from-label-or-throw.util.ts
@@ -6,8 +6,6 @@ import {
InvalidMetadataExceptionCode,
} from 'src/engine/metadata-modules/utils/exceptions/invalid-metadata.exception';
-// Server-specific wrapper that converts generic errors to InvalidMetadataException
-// This provides consistent error handling with proper exception codes for the server
export const computeMetadataNameFromLabelOrThrow = (label: string): string => {
if (!isDefined(label)) {
throw new InvalidMetadataException(
diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/format-result.util.ts b/packages/twenty-server/src/engine/twenty-orm/utils/format-result.util.ts
index 89fee3d2da5..33657237374 100644
--- a/packages/twenty-server/src/engine/twenty-orm/utils/format-result.util.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/utils/format-result.util.ts
@@ -365,14 +365,9 @@ function transformCompositeFieldNullValue(
);
}
-/**
- * Handles composite fields with missing required subfields.
- * - For nullable fields: sets to null if all required subfields are null
- * - For non-nullable fields: provides a default value to prevent GraphQL errors
- *
- * This handles existing records that were created before the field was added
- * or records with incomplete data.
- */
+// Records created before the composite field was added, or with incomplete
+// data, can miss required subfields: nullable fields become null and
+// non-nullable ones get a default value so GraphQL does not error.
function handleEmptyCompositeFields(
// oxlint-disable-next-line typescript/no-explicit-any
data: Record<string, any>,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts
index 7ef5657fb57..bec8bcc9624 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts
@@ -61,19 +61,14 @@ const GENERATE_CALENDAR_CHANNEL_EVENT_ASSOCIATION_SEEDS =
const CHANNEL_RAND = Math.random();
if (CHANNEL_RAND < 0.3) {
- // 30% - Tim's personal calendar
CHANNEL_ID = CHANNEL_IDS[0]; // TIM
} else if (CHANNEL_RAND < 0.45) {
- // 15% - Jony's personal calendar
CHANNEL_ID = CHANNEL_IDS[1]; // JONY
} else if (CHANNEL_RAND < 0.6) {
- // 15% - Phil's personal calendar
CHANNEL_ID = CHANNEL_IDS[2]; // PHIL
} else if (CHANNEL_RAND < 0.8) {
- // 20% - Company main calendar
CHANNEL_ID = CHANNEL_IDS[3]; // COMPANY_MAIN
} else {
- // 20% - Team calendar
CHANNEL_ID = CHANNEL_IDS[4]; // TEAM_CALENDAR
}
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts
index 1f94cc721a7..b3a76a7b0b8 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts
@@ -160,14 +160,12 @@ const GENERATE_CALENDAR_EVENT_SEEDS = (): CalendarEventDataSeed[] => {
const TEMPLATE_INDEX = (INDEX - 1) % EVENT_TEMPLATES.length;
const TEMPLATE = EVENT_TEMPLATES[TEMPLATE_INDEX];
- // Random date within the last 6 months and next 6 months
const NOW = new Date();
const RANDOM_DAYS_OFFSET = Math.floor(Math.random() * 365) - 182; // -182 to +182 days
const EVENT_DATE = new Date(
NOW.getTime() + RANDOM_DAYS_OFFSET * 24 * 60 * 60 * 1000,
);
- // Random time between 9 AM and 6 PM
const START_HOUR = 9 + Math.floor(Math.random() * 9);
const START_MINUTE = Math.floor(Math.random() * 4) * 15; // 0, 15, 30, or 45 minutes
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-participant-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-participant-data-seeds.constant.ts
index 3cbb2979a36..89eb20111e4 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-participant-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-participant-data-seeds.constant.ts
@@ -186,7 +186,6 @@ const CREATE_EVENT_PARTICIPANT_DATA = (
if (PERSON_PARTICIPANT) return PERSON_PARTICIPANT;
}
- // Try workspace member participant (20% chance, 0.4-0.6 range)
if (PARTICIPANT_TYPE >= 0.4 && PARTICIPANT_TYPE < 0.6) {
const WORKSPACE_PARTICIPANT = CREATE_WORKSPACE_MEMBER_EVENT_PARTICIPANT(
workspaceMemberIds,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts
index 1e03ff4f194..edeb98b0167 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts
@@ -66,24 +66,15 @@ const GENERATE_MESSAGE_CHANNEL_MESSAGE_ASSOCIATION_SEEDS =
const CHANNEL_WEIGHT = Math.random();
let CHANNEL_ID: string;
- // Tim's email (40% weight)
if (CHANNEL_WEIGHT < 0.4) {
CHANNEL_ID = MESSAGE_CHANNEL_DATA_SEED_IDS.TIM;
- }
- // Jony's email (20% weight)
- else if (CHANNEL_WEIGHT < 0.6) {
+ } else if (CHANNEL_WEIGHT < 0.6) {
CHANNEL_ID = MESSAGE_CHANNEL_DATA_SEED_IDS.JONY;
- }
- // Phil's email (15% weight)
- else if (CHANNEL_WEIGHT < 0.75) {
+ } else if (CHANNEL_WEIGHT < 0.75) {
CHANNEL_ID = MESSAGE_CHANNEL_DATA_SEED_IDS.PHIL;
- }
- // Support channel (15% weight)
- else if (CHANNEL_WEIGHT < 0.9) {
+ } else if (CHANNEL_WEIGHT < 0.9) {
CHANNEL_ID = MESSAGE_CHANNEL_DATA_SEED_IDS.SUPPORT;
- }
- // Sales channel (10% weight)
- else {
+ } else {
CHANNEL_ID = MESSAGE_CHANNEL_DATA_SEED_IDS.SALES;
}
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-data-seeds.constant.ts
index d57fde3f285..9e97ef6dd7d 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-data-seeds.constant.ts
@@ -103,7 +103,6 @@ const GENERATE_MESSAGE_SEEDS = (): MessageDataSeed[] => {
const TEMPLATE_INDEX = (INDEX - 1) % EMAIL_TEMPLATES.length;
const TEMPLATE = EMAIL_TEMPLATES[TEMPLATE_INDEX];
- // Assign messages to threads (some threads will have multiple messages)
const THREAD_INDEX = Math.floor((INDEX - 1) / 2); // 2 messages per thread on average
const THREAD_ID = THREAD_IDS[THREAD_INDEX % THREAD_IDS.length];
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-participant-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-participant-data-seeds.constant.ts
index 502b4b41b4a..ad108142008 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-participant-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-participant-data-seeds.constant.ts
@@ -204,7 +204,6 @@ const CREATE_PARTICIPANT_DATA = (
if (PERSON_PARTICIPANT) return PERSON_PARTICIPANT;
}
- // Try workspace member participant (30% chance, 0.4-0.7 range)
if (PARTICIPANT_TYPE >= 0.4 && PARTICIPANT_TYPE < 0.7) {
const WORKSPACE_PARTICIPANT = CREATE_WORKSPACE_MEMBER_PARTICIPANT(
workspaceMemberIds,
@@ -237,7 +236,6 @@ const CREATE_MESSAGE_PARTICIPANTS = (
? MessageParticipantRole.FROM
: MessageParticipantRole.TO;
- // Random date within the last 3 months
const NOW = new Date();
const RANDOM_DAYS_OFFSET = Math.floor(Math.random() * 90);
const PARTICIPANT_DATE = new Date(
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-thread-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-thread-data-seeds.constant.ts
index 024de6c5e11..548cf9c2b86 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-thread-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-thread-data-seeds.constant.ts
@@ -48,7 +48,6 @@ const GENERATE_MESSAGE_THREAD_SEEDS = (): MessageThreadDataSeed[] => {
NOW.getTime() - RANDOM_DAYS_OFFSET * 24 * 60 * 60 * 1000,
);
- // Updated date is between created date and now
const DAYS_SINCE_CREATED = Math.floor(
(NOW.getTime() - CREATED_DATE.getTime()) / (24 * 60 * 60 * 1000),
);
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-data-seeds.constant.ts
index 059552d1a08..31f74a706dc 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-data-seeds.constant.ts
@@ -158,7 +158,6 @@ const COMPANY_TASK_TEMPLATES = [
},
];
-// Helper function to get random workspace member
const GET_RANDOM_ASSIGNEE = (): string => {
const MEMBERS = [
WORKSPACE_MEMBER_DATA_SEED_IDS.TIM,
@@ -169,7 +168,6 @@ const GET_RANDOM_ASSIGNEE = (): string => {
return MEMBERS[Math.floor(Math.random() * MEMBERS.length)];
};
-// Helper function to format due date
const FORMAT_DUE_DATE = (daysFromNow: number | null): string | null => {
if (daysFromNow === null) return null;
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-view-fields.util.ts
index 66912de9a1d..ab0a13192a8 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-view-fields.util.ts
@@ -69,8 +69,6 @@ export const computeStandardNoteViewFields = (
},
}),
- // noteRecordPageFields view fields
- // General group
noteRecordPageFieldsNoteTargets: createStandardViewFieldFlatMetadata({
...args,
objectName: 'note',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-opportunity-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-opportunity-view-fields.util.ts
index d1032674431..9c05d48e221 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-opportunity-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-opportunity-view-fields.util.ts
@@ -158,8 +158,6 @@ export const computeStandardOpportunityViewFields = (
},
}),
- // opportunityRecordPageFields view fields
- // Deal group
opportunityRecordPageFieldsAmount: createStandardViewFieldFlatMetadata({
...args,
objectName: 'opportunity',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts
index 438f4f38928..6a2edda7f27 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts
@@ -110,8 +110,6 @@ export const computeStandardPersonViewFields = (
},
}),
- // personRecordPageFields view fields
- // General group
personRecordPageFieldsEmails: createStandardViewFieldFlatMetadata({
...args,
objectName: 'person',
@@ -351,7 +349,6 @@ export const computeStandardPersonViewFields = (
},
}),
- // messageListRecordPageMembers view fields
messageListRecordPageMembersName: createStandardViewFieldFlatMetadata({
...args,
objectName: 'person',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-view-fields.util.ts
index a9a6df7da37..c64b7f666af 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-view-fields.util.ts
@@ -251,8 +251,6 @@ export const computeStandardTaskViewFields = (
},
}),
- // taskRecordPageFields view fields
- // General group
taskRecordPageFieldsDueAt: createStandardViewFieldFlatMetadata({
...args,
objectName: 'task',
diff --git a/packages/twenty-server/src/engine/workspace-manager/types/all-non-workspace-related-entity.type.ts b/packages/twenty-server/src/engine/workspace-manager/types/all-non-workspace-related-entity.type.ts
index a94c0452f56..51d26bebe48 100644
--- a/packages/twenty-server/src/engine/workspace-manager/types/all-non-workspace-related-entity.type.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/types/all-non-workspace-related-entity.type.ts
@@ -19,20 +19,9 @@ import { type AgentChatThreadEntity } from 'src/engine/metadata-modules/ai/ai-ch
import { type IndexFieldMetadataEntity } from 'src/engine/metadata-modules/index-metadata/index-field-metadata.entity';
import { type SyncableEntity } from 'src/engine/workspace-manager/types/syncable-entity.interface';
-/**
- * Union of all entities that don't extend `WorkspaceRelatedEntity`.
- *
- * Membership is about the base class, not the column: several members declare
- * their own `workspaceId`, so this is not a "has no workspaceId" predicate and
- * must not be used as one.
- *
- * This type is used alongside `WorkspaceRelatedEntity` to enable TypeScript
- * to properly extract entity relation properties for dynamic typing purposes.
- *
- * @see ExtractEntityRelatedEntityProperties
- * @see ExtractEntityManyToOneEntityRelationProperties
- * @see ExtractEntityOneToManyEntityRelationProperties
- */
+// Membership is about the base class (not extending `WorkspaceRelatedEntity`),
+// not the column: several members declare their own `workspaceId`, so this is
+// not a "has no workspaceId" predicate and must not be used as one.
export type AllNonWorkspaceRelatedEntity =
| AgentChatThreadEntity
| AgentMessagePartEntity
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/types/entity-relation.interface.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/types/entity-relation.interface.ts
index 62c5b74e0cc..390e459465e 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/types/entity-relation.interface.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/types/entity-relation.interface.ts
@@ -1,5 +1,3 @@
-/**
- * Wrapper type used to circumvent ESM modules circular dependency issue
- * caused by reflection metadata saving the type of the property.
- */
+// Wrapper type that circumvents the ESM circular dependency caused by
+// reflection metadata saving the type of the property.
export type EntityRelation<T> = T;
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/types/workspace-migration-orchestrator.type.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/types/workspace-migration-orchestrator.type.ts
index 0738efc0621..2c0c10869d3 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/types/workspace-migration-orchestrator.type.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/types/workspace-migration-orchestrator.type.ts
@@ -22,9 +22,7 @@ export type WorkspaceMigrationOrchestratorBuildArgs = {
buildOptions: WorkspaceMigrationBuilderOptions;
fromToAllFlatEntityMaps: FromToAllUniversalFlatEntityMaps;
additionalCacheDataMaps: WorkspaceMigrationBuilderAdditionalCacheDataMaps;
- /**
- * Dependency maps must contain current application and its dependent app app flat entity maps
- */
+ // Must contain the flat entity maps of the current application and of the applications it depends on
dependencyAllFlatEntityMaps?: Partial<AllUniversalFlatEntityMaps>;
};
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/constants/all-jsonb-properties-with-serialized-relation-by-metadata-name.constant.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/constants/all-jsonb-properties-with-serialized-relation-by-metadata-name.constant.ts
index 71cd94da9ef..d86914d583b 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/constants/all-jsonb-properties-with-serialized-relation-by-metadata-name.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/constants/all-jsonb-properties-with-serialized-relation-by-metadata-name.constant.ts
@@ -3,10 +3,8 @@ import { type AllMetadataName } from 'twenty-shared/metadata';
import { type MetadataEntity } from 'src/engine/metadata-modules/flat-entity/types/metadata-entity.type';
import { type ExtractJsonbProperties } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/extract-jsonb-properties.type';
-/**
- * Important notice: This file is not strictly typed and needs manual referencement
- * of jsonb properties that may contain a serialized relation
- */
+// Not strictly typed: every jsonb property that may contain a serialized
+// relation has to be referenced here by hand.
export const ALL_JSONB_PROPERTIES_WITH_SERIALIZED_RELATION_BY_METADATA_NAME = {
fieldMetadata: {
settings: 'settings',
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/compute-ordered-migration-actions.util.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/compute-ordered-migration-actions.util.ts
index 727264c2c3f..5682c1eb24a 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/compute-ordered-migration-actions.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/compute-ordered-migration-actions.util.ts
@@ -151,6 +151,5 @@ export const computeOrderedMigrationActions = (
...aggregatedOrchestratorActionsReport.validationRule.delete,
...aggregatedOrchestratorActionsReport.validationRule.create,
...aggregatedOrchestratorActionsReport.validationRule.update,
- ///
];
};
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-skill-validator.service.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-skill-validator.service.ts
index d51a913d22e..6f5bed9d0a8 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-skill-validator.service.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-skill-validator.service.ts
@@ -165,7 +165,6 @@ export class FlatSkillValidatorService {
});
}
- // If only isActive is being updated on a standard skill, allow it
if (
isTwentyStandardSkill &&
isDefined(isActiveUpdate) &&
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/field-metadata-type-to-column-type.util.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/field-metadata-type-to-column-type.util.ts
index c4a95eddf58..dad603612d9 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/field-metadata-type-to-column-type.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/field-metadata-type-to-column-type.util.ts
@@ -10,10 +10,8 @@ export const fieldMetadataTypeToColumnType = <Type extends FieldMetadataType>(
fieldMetadataType: Type,
// Should be columnType
): string => {
- /**
- * Composite types are not implemented here, as they are flattened by their composite definitions.
- * See src/metadata/field-metadata/composite-types for more information.
- */
+ // Composite types never reach here: they are flattened into their sub-fields'
+ // column types (see twenty-shared/src/types/composite-types).
if (isTextColumnType(fieldMetadataType)) {
return 'text';
}
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/constants/calendar-import-ongoing-sync-timeout.constant.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/constants/calendar-import-ongoing-sync-timeout.constant.ts
index b95233a5eec..8f5f3b357c4 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/constants/calendar-import-ongoing-sync-timeout.constant.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/constants/calendar-import-ongoing-sync-timeout.constant.ts
@@ -1 +1 @@
-export const CALENDAR_IMPORT_ONGOING_SYNC_TIMEOUT = 1000 * 60 * 30; // 30 minutes
+export const CALENDAR_IMPORT_ONGOING_SYNC_TIMEOUT = 1000 * 60 * 30;
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/lib/auth/create-basic-digest-auth-fetch.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/lib/auth/create-basic-digest-auth-fetch.ts
index a13e39fb9bb..7f9faa8645e 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/lib/auth/create-basic-digest-auth-fetch.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/lib/auth/create-basic-digest-auth-fetch.ts
@@ -2,12 +2,6 @@ import DigestFetch from 'digest-fetch';
import { getBasicAuthHeaders } from 'tsdav';
import { isDefined } from 'twenty-shared/utils';
-/**
- * Decorates a base fetch with HTTP Basic + Digest authentication.
- *
- * Delegates RFC 7235 / RFC 7616 challenge parsing, hash computation,
- * and 401-then-retry orchestration to `digest-fetch`
- */
export const createBasicDigestAuthFetch = (
username: string,
password: string,
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/lib/utils/icalDataExtractPropertyValue.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/lib/utils/icalDataExtractPropertyValue.ts
index 3387ddde92c..0f9420393cb 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/lib/utils/icalDataExtractPropertyValue.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/lib/utils/icalDataExtractPropertyValue.ts
@@ -1,21 +1,12 @@
import { isNonEmptyString, isString } from '@sniptt/guards';
import { isDefined } from 'class-validator';
-/**
- * Extracts the string value from an iCal property that may have parameters.
- * Per RFC 5545, properties can have parameters like LANGUAGE=de-DE, which causes
- * node-ical to return an object with `val` and `params` instead of a plain string.
- *
- * RFC 5545 Section 3.1.2 also allows multiple values in a single property.
- *
- * @see https://datatracker.ietf.org/doc/html/rfc5545#section-3.2 (Property Parameters)
- * @see https://datatracker.ietf.org/doc/html/rfc5545#section-3.1.2 (Multiple Values)
- */
+// node-ical returns an object with `val` and `params` instead of a plain string
+// when a property has parameters (RFC 5545 3.2, e.g. LANGUAGE=de-DE), and an
+// array when it has multiple values (RFC 5545 3.1.2).
export const icalDataExtractPropertyValue = (
property:
- | string
- | { val?: string; params?: Record<string, unknown> }
- | undefined,
+ string | { val?: string; params?: Record<string, unknown> } | undefined,
defaultValue = '',
): string => {
if (!isDefined(property)) {
diff --git a/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/drivers/google/constants/google-permanent-oauth-error-codes.constant.ts b/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/drivers/google/constants/google-permanent-oauth-error-codes.constant.ts
index 93352702ef7..69f0c021fc5 100644
--- a/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/drivers/google/constants/google-permanent-oauth-error-codes.constant.ts
+++ b/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/drivers/google/constants/google-permanent-oauth-error-codes.constant.ts
@@ -1,6 +1,4 @@
-/**
- * @see https://developers.google.com/identity/protocols/oauth2/web-server#authorization-errors
- */
+// @see https://developers.google.com/identity/protocols/oauth2/web-server#authorization-errors
export const GOOGLE_PERMANENT_OAUTH_ERROR_CODES = new Set([
'invalid_grant',
'invalid_client',
diff --git a/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/drivers/microsoft/constants/microsoft-permanent-auth-error-codes.constant.ts b/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/drivers/microsoft/constants/microsoft-permanent-auth-error-codes.constant.ts
index df9d04b7e72..25f52fdbb3e 100644
--- a/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/drivers/microsoft/constants/microsoft-permanent-auth-error-codes.constant.ts
+++ b/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/drivers/microsoft/constants/microsoft-permanent-auth-error-codes.constant.ts
@@ -1,6 +1,4 @@
-/**
- * @see https://learn.microsoft.com/en-us/entra/identity-platform/reference-error-codes
- */
+// @see https://learn.microsoft.com/en-us/entra/identity-platform/reference-error-codes
export const MICROSOFT_PERMANENT_AUTH_ERROR_CODES = new Set([
'invalid_grant',
'invalid_client',
diff --git a/packages/twenty-server/src/modules/messaging/message-folder-manager/drivers/microsoft/services/microsoft-get-all-folders.service.ts b/packages/twenty-server/src/modules/messaging/message-folder-manager/drivers/microsoft/services/microsoft-get-all-folders.service.ts
index ff58d6a592f..854e9b58537 100644
--- a/packages/twenty-server/src/modules/messaging/message-folder-manager/drivers/microsoft/services/microsoft-get-all-folders.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-folder-manager/drivers/microsoft/services/microsoft-get-all-folders.service.ts
@@ -134,11 +134,8 @@ export class MicrosoftGetAllFoldersService implements MessageFolderDriver {
return standardFolder === StandardFolder.SENT;
}
- /*
- * All Microsoft folders have a parentFolderId including the standard folders
- * which point to root node which doesn't exits in the API response.
- * We remove this to simplify the folder hierarchy on frontend.
- */
+ // Standard folders point at a root parentFolderId that the API response never
+ // includes, so it is detected here and stripped to flatten the hierarchy.
private getRootFolderId(folders: MicrosoftGraphFolder[]): string | null {
for (const folder of folders) {
if (isDefined(folder.wellKnownName) && isDefined(folder.parentFolderId)) {
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/constants/messaging-import-ongoing-sync-timeout.constant.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/constants/messaging-import-ongoing-sync-timeout.constant.ts
index 93b37c88023..e9d826e9ede 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/constants/messaging-import-ongoing-sync-timeout.constant.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/constants/messaging-import-ongoing-sync-timeout.constant.ts
@@ -1 +1 @@
-export const MESSAGING_IMPORT_ONGOING_SYNC_TIMEOUT = 1000 * 60 * 30; // 30 minutes
+export const MESSAGING_IMPORT_ONGOING_SYNC_TIMEOUT = 1000 * 60 * 30;
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/constants/messaging-throttle-duration.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/constants/messaging-throttle-duration.ts
index 1938101021c..bd5f531edf1 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/constants/messaging-throttle-duration.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/constants/messaging-throttle-duration.ts
@@ -1 +1 @@
-export const MESSAGING_THROTTLE_DURATION = 1000 * 60 * 1; // 1 minute
+export const MESSAGING_THROTTLE_DURATION = 1000 * 60 * 1;
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
index b4fd616af22..fe66cbd0e99 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
@@ -89,7 +89,6 @@ const gaxiosErrorMocks = {
response: undefined,
},
- // Helper function to get error by code
getError: function (code: string) {
switch (code) {
case 'ECONNRESET':
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/imap/services/imap-find-sent-folder.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/imap/services/imap-find-sent-folder.service.ts
index 1a6581cf9ab..ab2fec0f0e1 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/imap/services/imap-find-sent-folder.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/imap/services/imap-find-sent-folder.service.ts
@@ -10,16 +10,8 @@ type SentFolderResult = {
path: string;
} | null;
-/**
- * Service to find sent folder using IMAP special-use flags
- *
- * This service uses IMAP special-use extension (RFC 6154) to identify
- * the sent folder by looking for the \Sent flag rather than relying on
- * folder names which can vary across providers and locales.
- *
- * Falls back to regex-based detection if special-use flags are not available.
- * The regex pattern is inspired by imapsync's comprehensive folder mapping.
- */
+// The RFC 6154 \Sent special-use flag is preferred over folder names, which vary
+// across providers and locales; the regex fallback follows imapsync's folder mapping.
@Injectable()
export class ImapFindSentFolderService {
private readonly logger = new Logger(ImapFindSentFolderService.name);
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/utils/sanitize-string.util.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/utils/sanitize-string.util.ts
index f38eede5a20..45c2e8cf59a 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/utils/sanitize-string.util.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/utils/sanitize-string.util.ts
@@ -1,8 +1,5 @@
const NULL_CHAR_REGEX = /\0/g;
-/**
- * Removes null characters (\0) from a string to prevent unexpected errors
- */
export const sanitizeString = (str: string) => {
return str.replace(NULL_CHAR_REGEX, '');
};
diff --git a/packages/twenty-server/src/modules/messaging/message-outbound-manager/utils/extract-message-id-from-buffer.util.ts b/packages/twenty-server/src/modules/messaging/message-outbound-manager/utils/extract-message-id-from-buffer.util.ts
index ebf4341df32..afb2b0f5104 100644
--- a/packages/twenty-server/src/modules/messaging/message-outbound-manager/utils/extract-message-id-from-buffer.util.ts
+++ b/packages/twenty-server/src/modules/messaging/message-outbound-manager/utils/extract-message-id-from-buffer.util.ts
@@ -1,5 +1,3 @@
-// Extracts the RFC 2822 Message-ID header from a raw email buffer.
-// Handles folded headers (continuation lines starting with whitespace).
// MailComposer always generates this header; if missing, falls back to empty string.
export const extractMessageIdFromBuffer = (messageBuffer: Buffer): string => {
const headerSection = messageBuffer.toString('utf-8').split('\r\n\r\n')[0];
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/utils/__tests__/compute-workflow-version-step-changes.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/utils/__tests__/compute-workflow-version-step-changes.util.spec.ts
index 3a7ab2584e9..fb3afcb9442 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/utils/__tests__/compute-workflow-version-step-changes.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/utils/__tests__/compute-workflow-version-step-changes.util.spec.ts
@@ -76,9 +76,8 @@ describe('computeWorkflowVersionStepChanges', () => {
{ path: ['trigger', 'nextStepIds', 1], type: 'CREATE', value: 'step-3' },
]);
expect(result.stepsDiff).toMatchObject([]);
- expect(result.stepsDiff.length).toBe(0); // No steps changed
+ expect(result.stepsDiff.length).toBe(0);
- // Verify the trigger diff contains the nextStepIds change
const nextStepIdsDiff = result.triggerDiff.find((diff) =>
diff.path.includes('nextStepIds'),
);
@@ -124,7 +123,7 @@ describe('computeWorkflowVersionStepChanges', () => {
expect(result.stepsDiff).toBeDefined();
expect(result.stepsDiff.length).toBeGreaterThan(0);
expect(result.triggerDiff).toBeDefined();
- expect(result.triggerDiff.length).toBe(0); // No trigger changed
+ expect(result.triggerDiff.length).toBe(0);
const createDiff = result.stepsDiff.find((diff) => diff.type === 'CREATE');
@@ -178,7 +177,6 @@ describe('computeWorkflowVersionStepChanges', () => {
const result = computeWorkflowVersionStepChanges({
existingTrigger: mockTrigger,
existingSteps: mockSteps,
- // updatedTrigger and updatedSteps are undefined
});
expect(result.triggerDiff).toBeDefined();
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/services/workflow-execution-context.service.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/services/workflow-execution-context.service.ts
index b53fb0519cc..9e1000b597e 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/services/workflow-execution-context.service.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/services/workflow-execution-context.service.ts
@@ -98,7 +98,6 @@ export class WorkflowExecutionContextService {
workspaceId,
);
- // Use the application's role if set, otherwise fall back to admin role
// In the future we should probably assign the Admin role to the Standard Application
let roleId = application.defaultRoleId;
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts
index 805a2f19e50..79ff82ef012 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts
@@ -1500,7 +1500,6 @@ describe('evaluateFilterConditions', () => {
'UNSUPPORTED_TYPE',
);
- // Unsupported types fall through to default filter logic
expect(evaluateFilterConditions({ filters: [filter] })).toBe(true);
});
});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-relative-date-filter.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-relative-date-filter.util.spec.ts
index d18cde79980..59bb3ff12d4 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-relative-date-filter.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-relative-date-filter.util.spec.ts
@@ -25,7 +25,6 @@ describe('Relative Date Filter Utils', () => {
const now = new Date('2024-01-15T12:00:00Z'); // Monday, January 15, 2024 at noon
beforeEach(() => {
- // Mock Date constructor to return a fixed date for consistent testing
jest.useFakeTimers();
jest.setSystemTime(now);
});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/should-execute-iterator-step.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/should-execute-iterator-step.util.spec.ts
index b807f8bbd14..b5b43c7836e 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/should-execute-iterator-step.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/should-execute-iterator-step.util.spec.ts
@@ -45,7 +45,6 @@ describe('shouldExecuteIteratorStep', () => {
'step-3': { status: StepStatus.SUCCESS },
};
- // Mock getAllStepIdsInLoop to return the loop step IDs
getAllStepIdsInLoop.mockReturnValue(['step-1', 'step-2']);
const result = shouldExecuteIteratorStep({
@@ -225,7 +224,7 @@ describe('shouldExecuteIteratorStep', () => {
iteratorStep,
];
const stepInfos = {
- 'iterator-1': { status: StepStatus.RUNNING }, // Iterator has been started
+ 'iterator-1': { status: StepStatus.RUNNING },
'step-1': { status: StepStatus.SUCCESS },
'step-2': { status: StepStatus.SUCCESS },
};
@@ -273,9 +272,9 @@ describe('shouldExecuteIteratorStep', () => {
iteratorStep,
];
const stepInfos = {
- 'iterator-1': { status: StepStatus.RUNNING }, // Iterator has been started
+ 'iterator-1': { status: StepStatus.RUNNING },
'step-1': { status: StepStatus.SUCCESS },
- 'step-2': { status: StepStatus.FAILED }, // This step failed
+ 'step-2': { status: StepStatus.FAILED },
};
getAllStepIdsInLoop.mockReturnValue(['step-1']);
@@ -297,9 +296,9 @@ describe('shouldExecuteIteratorStep', () => {
iteratorStep,
];
const stepInfos = {
- 'iterator-1': { status: StepStatus.RUNNING }, // Iterator has been started
+ 'iterator-1': { status: StepStatus.RUNNING },
'step-1': { status: StepStatus.SUCCESS },
- 'step-2': { status: StepStatus.RUNNING }, // This step is still running
+ 'step-2': { status: StepStatus.RUNNING },
};
getAllStepIdsInLoop.mockReturnValue(['step-1']);
@@ -317,7 +316,7 @@ describe('shouldExecuteIteratorStep', () => {
const iteratorStep = createMockIteratorStep('iterator-1');
const steps = [createMockCodeStep('step-1', ['step-2']), iteratorStep];
const stepInfos = {
- 'iterator-1': { status: StepStatus.RUNNING }, // Iterator has been started
+ 'iterator-1': { status: StepStatus.RUNNING },
'step-1': { status: StepStatus.SUCCESS },
};
@@ -340,9 +339,9 @@ describe('shouldExecuteIteratorStep', () => {
iteratorStep,
];
const stepInfos = {
- 'iterator-1': { status: StepStatus.SUCCESS }, // Iterator has been started
- 'step-1': { status: StepStatus.SUCCESS }, // Loop step successful
- 'step-2': { status: StepStatus.SUCCESS }, // Non-loop step successful
+ 'iterator-1': { status: StepStatus.SUCCESS },
+ 'step-1': { status: StepStatus.SUCCESS },
+ 'step-2': { status: StepStatus.SUCCESS },
};
getAllStepIdsInLoop.mockReturnValue(['step-1']);
@@ -364,8 +363,8 @@ describe('shouldExecuteIteratorStep', () => {
iteratorStep,
];
const stepInfos = {
- 'iterator-1': { status: StepStatus.RUNNING }, // Iterator has been started
- 'step-1': { status: StepStatus.NOT_STARTED }, // Loop step not started
+ 'iterator-1': { status: StepStatus.RUNNING },
+ 'step-1': { status: StepStatus.NOT_STARTED },
'step-2': { status: StepStatus.SUCCESS },
};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/staled-runs-threshold.ts b/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/staled-runs-threshold.ts
index a0f7aa3f490..10116ec67e2 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/staled-runs-threshold.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/staled-runs-threshold.ts
@@ -1 +1 @@
-export const STALED_RUNS_THRESHOLD_MS = 60 * 60 * 1000; // 1 hour
+export const STALED_RUNS_THRESHOLD_MS = 60 * 60 * 1000;
diff --git a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/stuck-running-runs-threshold.ts b/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/stuck-running-runs-threshold.ts
index 4db27d06c3e..92ea0740445 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/stuck-running-runs-threshold.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/stuck-running-runs-threshold.ts
@@ -1 +1 @@
-export const STUCK_RUNNING_RUNS_THRESHOLD_MS = 60 * 60 * 1000; // 1 hour
+export const STUCK_RUNNING_RUNS_THRESHOLD_MS = 60 * 60 * 1000;
diff --git a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/stuck-stopping-runs-threshold.ts b/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/stuck-stopping-runs-threshold.ts
index b26b193bfe1..22ded1b67d3 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/stuck-stopping-runs-threshold.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/constants/stuck-stopping-runs-threshold.ts
@@ -1 +1 @@
-export const STUCK_STOPPING_RUNS_THRESHOLD_MS = 60 * 60 * 1000; // 1 hour
+export const STUCK_STOPPING_RUNS_THRESHOLD_MS = 60 * 60 * 1000;
diff --git a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/jobs/workflow-clean-workflow-runs.job.ts b/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/jobs/workflow-clean-workflow-runs.job.ts
index d07b3695fb1..b0a77e7540d 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/jobs/workflow-clean-workflow-runs.job.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/jobs/workflow-clean-workflow-runs.job.ts
@@ -92,7 +92,7 @@ export class WorkflowCleanWorkflowRunsJob {
],
);
- // TypeORM's dataSource.query() for for DELETE ... RETURNING returns a tuple [rows, affectedCount]
+ // TypeORM's dataSource.query() for DELETE ... RETURNING returns a tuple [rows, affectedCount]
deletedCount = result[0].length;
totalDeleted += deletedCount;
} while (deletedCount > 0);
@@ -139,7 +139,7 @@ export class WorkflowCleanWorkflowRunsJob {
],
);
- // TypeORM's dataSource.query() for for DELETE ... RETURNING returns a tuple [rows, affectedCount]
+ // TypeORM's dataSource.query() for DELETE ... RETURNING returns a tuple [rows, affectedCount]
deletedCount = result[0].length;
totalDeleted += deletedCount;
} while (deletedCount > 0);
diff --git a/packages/twenty-server/src/utils/custom-exception.ts b/packages/twenty-server/src/utils/custom-exception.ts
index 98bb0e3ade8..65d7101dbe5 100644
--- a/packages/twenty-server/src/utils/custom-exception.ts
+++ b/packages/twenty-server/src/utils/custom-exception.ts
@@ -39,8 +39,5 @@ export abstract class CustomException<
}
}
-/**
- * Exception class for test scenarios and edge cases.
- * Prefer domain-specific exceptions in production code.
- */
+// For test scenarios and edge cases; prefer domain-specific exceptions in production code.
export class UnknownException extends CustomException {}
diff --git a/packages/twenty-server/test/integration/ai/suites/mcp-tool-catalog.integration-spec.ts b/packages/twenty-server/test/integration/ai/suites/mcp-tool-catalog.integration-spec.ts
index 285d9c93446..1adf9b1ac89 100644
--- a/packages/twenty-server/test/integration/ai/suites/mcp-tool-catalog.integration-spec.ts
+++ b/packages/twenty-server/test/integration/ai/suites/mcp-tool-catalog.integration-spec.ts
@@ -7,21 +7,6 @@ import { makeMetadataApiRequest } from 'test/integration/metadata/suites/utils/m
import { jestExpectToBeDefined } from 'test/utils/jest-expect-to-be-defined.util.test';
import { ToolCategory } from 'twenty-shared/ai';
-/**
- * Contract tests for the MCP tool catalog.
- *
- * 1. Catalog contract: every category advertised by get_tool_catalog must be
- * dispatchable end to end through execute_tool. Dispatchable means the
- * registry resolves and executes the tool: a structured business failure
- * (e.g. a search tool rejecting empty arguments) still proves dispatch,
- * only "not found" / "not available" outputs do not. Scales automatically:
- * a newly registered provider is covered the moment it appears in the
- * catalog, with no new test code.
- * 2. Permission gating: the catalog is role-dependent. An API key bound to a
- * role without settings permissions must not see settings-gated tools
- * (e.g. the ROLE category), while an admin-bound key must.
- */
-
const baseUrl = `http://localhost:${APP_PORT}`;
const postMcp = (body: object, bearer: string, path = '/mcp') =>
diff --git a/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts b/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts
index e20562e94f8..62be004a8d8 100644
--- a/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts
+++ b/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts
@@ -2,13 +2,6 @@ import request from 'supertest';
import { MCP_PROTOCOL_VERSION } from 'src/engine/api/mcp/constants/mcp-protocol-version.const';
-/**
- * Integration tests for MCP core controller
- *
- * These tests hit the real Nest app bootstrapped by test/integration/utils/setup-test.ts
- * and exercise the guarded POST /mcp endpoint using valid/invalid JSON-RPC payloads.
- */
-
describe('MCP Controller (integration)', () => {
const baseUrl = `http://localhost:${APP_PORT}`;
const endpoint = '/mcp';
diff --git a/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/successful-session-cookie-delivery.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/successful-session-cookie-delivery.integration-spec.ts
index 3dc0f3361a8..3dd3abc658b 100644
--- a/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/successful-session-cookie-delivery.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/successful-session-cookie-delivery.integration-spec.ts
@@ -14,7 +14,7 @@ import { setupDatabaseConfigOverrideForSuite } from 'test/integration/graphql/su
// which is the one secure-deployment trigger reachable at runtime: SERVER_URL
// stays plain http in .env.test. The production combination (https SERVER_URL
// with the SameSite=Lax default) is covered by
-// secure-deployment-session-cookie.integration-spec.ts under a dedicated app
+// secure-deployment/suites/secure-session-cookie.integration-spec.ts under a dedicated app
// boot.
describe('successful session cookie delivery on a secure deployment (integration)', () => {
setupDatabaseConfigOverrideForSuite('AUTH_COOKIE_SAME_SITE', 'none');
diff --git a/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/successful-session-creation.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/successful-session-creation.integration-spec.ts
index 231489c94d6..b1e86f82478 100644
--- a/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/successful-session-creation.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/successful-session-creation.integration-spec.ts
@@ -47,7 +47,7 @@ describe('successful user session creation on auth exchanges (integration)', ()
// (plain-http test deployment), and no Domain, which is what makes the
// cookie host-only so browsers never send it to sibling workspace
// subdomains. The secure boot pins its own shape in
- // secure-deployment-session-cookie.integration-spec.ts, so this snapshot
+ // secure-deployment/suites/secure-session-cookie.integration-spec.ts, so this snapshot
// only applies to the insecure one.
if (!IS_SECURE_DEPLOYMENT) {
expect(
diff --git a/packages/twenty-server/test/integration/graphql/suites/dpa/dpa.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/dpa/dpa.integration-spec.ts
index 2e9bb028579..553db607892 100644
--- a/packages/twenty-server/test/integration/graphql/suites/dpa/dpa.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/dpa/dpa.integration-spec.ts
@@ -103,7 +103,6 @@ describe('DPA resolver (integration)', () => {
createdAgreementIds.push(result.agreement.id);
- // The stored copy is downloadable and is a real PDF.
const downloadUrl = new URL(result.downloadUrl);
const downloadResponse = await request(
`http://localhost:${APP_PORT}`,
diff --git a/packages/twenty-server/test/integration/graphql/suites/file-upload/direct-file-upload.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/file-upload/direct-file-upload.integration-spec.ts
index 81278130514..a8049504273 100644
--- a/packages/twenty-server/test/integration/graphql/suites/file-upload/direct-file-upload.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/file-upload/direct-file-upload.integration-spec.ts
@@ -198,7 +198,6 @@ describe('direct file upload (createFileUpload / completeFileUpload)', () => {
`/file/${FileFolder.FilesField}/${uploadTarget.fileId}?token=`,
);
- // The confirmed file is downloadable through the regular file endpoint
const { pathname, search } = new URL(completedFile.url);
const downloadResponse = await request(global.app.getHttpServer()).get(
`${pathname}${search}`,
diff --git a/packages/twenty-server/test/integration/graphql/suites/group-by-with-records-resolver.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/group-by-with-records-resolver.integration-spec.ts
index fd7341c87d2..54c05ecb2b0 100644
--- a/packages/twenty-server/test/integration/graphql/suites/group-by-with-records-resolver.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/group-by-with-records-resolver.integration-spec.ts
@@ -70,7 +70,6 @@ describe('basic group-by with records', () => {
}),
);
- // Create test opportunities with different stages and dates
await makeGraphqlApiRequest(
createOneOperationFactory({
objectMetadataSingularName: 'opportunity',
diff --git a/packages/twenty-server/test/integration/graphql/suites/inputs-validation/utils/get-field-metadata-creation-inputs.util.ts b/packages/twenty-server/test/integration/graphql/suites/inputs-validation/utils/get-field-metadata-creation-inputs.util.ts
index 88fbfa5d8d0..f555707c45b 100644
--- a/packages/twenty-server/test/integration/graphql/suites/inputs-validation/utils/get-field-metadata-creation-inputs.util.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/inputs-validation/utils/get-field-metadata-creation-inputs.util.ts
@@ -219,18 +219,6 @@ export const getFieldMetadataCreationInputs = (
},
],
},
- // {
- // name: 'oneToManyRelationField',
- // label: 'oneToManyRelationField',
- // type: FieldMetadataType.RELATION,
- // objectMetadataId,
- // relationCreationPayload: {
- // targetObjectMetadataId: targetObjectMetadata1Id,
- // targetFieldLabel: 'manyToOneTargetRelationField',
- // targetFieldIcon: 'IconListOpportunity',
- // type: RelationType.ONE_TO_MANY,
- // },
- // },
],
};
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts
index 5428e2bdbbe..b59f2e30a7b 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts
@@ -235,38 +235,6 @@ describe('Field update permissions restrictions', () => {
}
});
- // it('1. updateMany with restricted field', async () => {
- // const graphqlOperation = updateManyOperationFactory({
- // objectMetadataSingularName: 'company',
- // objectMetadataPluralName: 'companies',
- // gqlFields: COMPANY_GQL_FIELDS_WITH_EMPLOYEES,
- // data: { employees: 20 },
- // });
-
- // it('2. updateOne with restricted field', async () => {
- // const graphqlOperation = updateOneOperationFactory({
- // objectMetadataSingularName: 'company',
- // gqlFields: COMPANY_GQL_FIELDS_WITH_EMPLOYEES,
- // recordId: companyId,
- // data: { employees: 20 },
- // });
-
- // it('1. updateMany with non-restricted field', async () => {
- // const graphqlOperation = updateManyOperationFactory({
- // objectMetadataSingularName: 'company',
- // objectMetadataPluralName: 'companies',
- // gqlFields: COMPANY_GQL_FIELDS_WITHOUT_EMPLOYEES,
- // data: { name: 'UpdatedCompany' },
- // });
-
- // it('2. updateOne with non-restricted field', async () => {
- // const graphqlOperation = updateOneOperationFactory({
- // objectMetadataSingularName: 'company',
- // gqlFields: COMPANY_GQL_FIELDS_WITHOUT_EMPLOYEES,
- // recordId: companyId,
- // data: { name: 'UpdatedCompany2' },
- // });
-
describe('should allow employees field when creating if field is in RLS predicate', () => {
beforeEach(async () => {
await restrictUpdateAccessToCompanyEmployee(
diff --git a/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts
index 96b631324ef..0976415a23d 100644
--- a/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts
@@ -32,7 +32,6 @@ const CASE_INSENSITIVE_TEST_PERSON_IDS = [
describe('Order by relation field (e2e)', () => {
beforeAll(async () => {
- // Create test companies with distinct names for sorting verification
const createCompanies = createManyOperationFactory({
objectMetadataSingularName: 'company',
objectMetadataPluralName: 'companies',
@@ -323,7 +322,6 @@ describe('Order by relation field (e2e)', () => {
expect(Array.isArray(secondPageEdges)).toBe(true);
- // Verify different records are returned (no overlap)
const firstPageIds = firstPageEdges.map(
(edge: { node: { id: string } }) => edge.node.id,
);
@@ -814,7 +812,6 @@ describe('Order by relation field (e2e)', () => {
expect(Array.isArray(edges)).toBe(true);
- // Verify the filtered record is not in the results
const resultIds = edges.map(
(edge: { node: { id: string } }) => edge.node.id,
);
diff --git a/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts
index 7642ed9c65b..251ac316845 100644
--- a/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts
@@ -111,7 +111,6 @@ describe('group-by resolvers - order by', () => {
});
afterAll(async () => {
- // cleanup created companies
for (const id of [
testCompanyId1,
testCompanyId2,
diff --git a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts
index e043f0463cf..f6b3cbb5492 100644
--- a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts
@@ -26,7 +26,6 @@ describe('Granular settings permissions', () => {
originalMemberRoleId = memberRole.id;
- // Create a custom role with canUpdateAllSettings = false
// canUpdateAllObjectRecords must be true to allow creating records like workflows
const createRoleQuery = {
query: `
diff --git a/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts
index 0d6a81c1dbf..8af633cef58 100644
--- a/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts
@@ -68,7 +68,6 @@ describe('deleteUser', () => {
});
it('should soft delete user and remove workspace relations when deleting a user in their only workspace', async () => {
- // 1. Arrange
// Enable public invite link to allow sign up without personal token
const enablePublicInviteLinkMutation = {
query: `
diff --git a/packages/twenty-server/test/integration/metadata/suites/application/logic-function-install-performance.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/application/logic-function-install-performance.integration-spec.ts
index 64c6ab21763..33e03a464cc 100644
--- a/packages/twenty-server/test/integration/metadata/suites/application/logic-function-install-performance.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/application/logic-function-install-performance.integration-spec.ts
@@ -8,19 +8,11 @@ import {
} from 'twenty-shared/application';
import { v4 as uuidv4 } from 'uuid';
-/**
- * Performance harness for installing / updating many logic functions through
- * application manifest sync. The goal is to find what could take >10s in prod
- * (which trips the node-postgres `query_timeout` in core.datasource.ts and
- * produces "Migration action 'update' for 'logicFunction' failed" + 504).
- *
- * IMPORTANT: the integration harness boots the NestJS app in-process with
- * `fakeTimers.enableGlobally: true`. We call `jest.useRealTimers()` for the whole
- * suite so timing (`performance.now()`) is real and cache-lock retry delays etc.
- * do not hang.
- */
-
-// Real timers for the whole suite — see note above.
+// Hunts for logic-function syncs slow enough to trip the prod query_timeout
+// (504 on "Migration action 'update' for 'logicFunction' failed").
+
+// The harness enables fake timers globally, which would fake performance.now()
+// and hang cache-lock retry delays.
jest.useRealTimers();
jest.setTimeout(120000);
diff --git a/packages/twenty-server/test/integration/metadata/suites/application/successful-manifest-update-field.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/application/successful-manifest-update-field.integration-spec.ts
index 85775792e00..326d1d4b53e 100644
--- a/packages/twenty-server/test/integration/metadata/suites/application/successful-manifest-update-field.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/application/successful-manifest-update-field.integration-spec.ts
@@ -380,7 +380,6 @@ describe('Manifest update - fields', () => {
}, 60000);
it('should backfill existing null rows when a field becomes non-nullable on second sync', async () => {
- // First sync creates a nullable field with no default.
await syncApplication({
manifest: buildManifest({
fields: [buildEstimateFieldManifest({ isNullable: true })],
@@ -388,7 +387,6 @@ describe('Manifest update - fields', () => {
expectToFail: false,
});
- // Persist a record whose estimate is NULL on the underlying column.
const recordId = uuidv4();
const createdRecord = await createTicketRecord({
id: recordId,
diff --git a/packages/twenty-server/test/integration/metadata/suites/field-metadata/morph-relation/find-many-morph-relation-records.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/field-metadata/morph-relation/find-many-morph-relation-records.integration-spec.ts
index 1c8f03093e1..8334f86161d 100644
--- a/packages/twenty-server/test/integration/metadata/suites/field-metadata/morph-relation/find-many-morph-relation-records.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/field-metadata/morph-relation/find-many-morph-relation-records.integration-spec.ts
@@ -136,21 +136,6 @@ xdescribe('findMany morph relation records', () => {
type: FieldMetadataType.MORPH_RELATION,
}),
},
- // {
- // title:
- // 'should find many records with a MORPH_RELATION field type ONE_TO_MANY',
- // context: ({
- // objectMetadataId,
- // firstTargetObjectMetadataId,
- // secondTargetObjectMetadataId,
- // }) => ({
- // relationType: RelationType.ONE_TO_MANY,
- // objectMetadataId,
- // firstTargetObjectMetadataId,
- // secondTargetObjectMetadataId,
- // type: FieldMetadataType.MORPH_RELATION,
- // }),
- // },
];
it.each(eachTestingContextArray)('$title', async ({ context }) => {
@@ -188,28 +173,6 @@ xdescribe('findMany morph relation records', () => {
}
`;
- // const ONE_TO_MANY_GQL_FIELDS = `
- // id
- // name
- // ownerPersonId
- // ownerPerson {
- // edges {
- // node {
- // id
- // name
- // }
- // }
- // }
- // ownerCompanyId
- // ownerCompany {
- // edges {
- // node {
- // id
- // name
- // }
- // }
- // }
- // `;
const graphqlOperation = findManyOperationFactory({
objectMetadataSingularName: 'opportunityForMorphRelation',
objectMetadataPluralName: 'opportunitiesForMorphRelation',
@@ -222,8 +185,6 @@ xdescribe('findMany morph relation records', () => {
expect(
response.body.data.opportunitiesForMorphRelation.edges,
).toBeDefined();
- // const isManyToOne =
- // contextPayload.relationType === RelationType.MANY_TO_ONE;
await deleteOneFieldMetadata({
input: { idToDelete: createdField.id },
diff --git a/packages/twenty-server/test/integration/rest/suites/rest-api-core-group-by.integration-spec.ts b/packages/twenty-server/test/integration/rest/suites/rest-api-core-group-by.integration-spec.ts
index 97a3886657a..bbb1eb34be3 100644
--- a/packages/twenty-server/test/integration/rest/suites/rest-api-core-group-by.integration-spec.ts
+++ b/packages/twenty-server/test/integration/rest/suites/rest-api-core-group-by.integration-spec.ts
@@ -60,7 +60,6 @@ describe('REST API Core Group By endpoint', () => {
}),
);
- // Create test opportunities with different stages and dates
await makeGraphqlApiRequest(
createOneOperationFactory({
objectMetadataSingularName: 'opportunity',
diff --git a/packages/twenty-server/test/integration/utils/create-app.ts b/packages/twenty-server/test/integration/utils/create-app.ts
index 24aca03703c..f0b476c9e09 100644
--- a/packages/twenty-server/test/integration/utils/create-app.ts
+++ b/packages/twenty-server/test/integration/utils/create-app.ts
@@ -24,16 +24,10 @@ interface TestingModuleCreatePreHook {
(moduleBuilder: TestingModuleBuilder): TestingModuleBuilder;
}
-/**
- * Hook for adding items to nest application
- */
export type TestingAppCreatePreHook = (
app: NestExpressApplication,
) => Promise<void>;
-/**
- * Sets basic integration testing module of app
- */
export const createApp = async (
config: {
moduleBuilderHook?: TestingModuleCreatePreHook;
diff --git a/packages/twenty-server/test/integration/utils/delete-records-by-ids.ts b/packages/twenty-server/test/integration/utils/delete-records-by-ids.ts
index 4d1bcdbe38b..61a371bea1e 100644
--- a/packages/twenty-server/test/integration/utils/delete-records-by-ids.ts
+++ b/packages/twenty-server/test/integration/utils/delete-records-by-ids.ts
@@ -9,7 +9,6 @@ export const deleteRecordsByIds = async (
}
try {
- // Create placeholders for parameterized query: $1, $2, $3, etc.
const placeholders = recordIds
.map((_, index) => `$${index + 1}`)
.join(', ');
diff --git a/packages/twenty-shared/jest.config.mjs b/packages/twenty-shared/jest.config.mjs
index e7d5d687ad4..0a8d9024abe 100644
--- a/packages/twenty-shared/jest.config.mjs
+++ b/packages/twenty-shared/jest.config.mjs
@@ -25,14 +25,6 @@ const jestConfig = {
},
moduleNameMapper: {
// TODO prastoin investigate not working with pathsToModuleNameMapper
- /*
- {
- '^@/(.*)\\.js$': './src/$1',
- '^@/(.*)$': './src/$1',
- '^(\\.{1,2}/.*)\\.js$': '$1'
- } // use esm true
- { '^@/(.*)$': './src/$1' } // useEsm false
- */
'/^@/(.*)$/': './src/$1',
'\\.(jpg|jpeg|png|gif|webp|svg|svg\\?react)$':
'<rootDir>/__mocks__/imageMockShared.js',
diff --git a/packages/twenty-shared/src/application/appConnectionType.ts b/packages/twenty-shared/src/application/appConnectionType.ts
index cdcd769c93a..d49de4d96c3 100644
--- a/packages/twenty-shared/src/application/appConnectionType.ts
+++ b/packages/twenty-shared/src/application/appConnectionType.ts
@@ -26,7 +26,7 @@ export type AppConnection = {
// by the upstream provider.
visibility: 'user' | 'workspace';
// The userWorkspace that originally created the credential (also the owner
- // for `scope: 'user'` credentials). Match against `event.userWorkspaceId`
+ // for `visibility: 'user'` credentials). Match against `event.userWorkspaceId`
// to resolve the request user's connection.
userWorkspaceId: string;
// The workspace member who created the credential. null when the creating
diff --git a/packages/twenty-shared/src/constants/IanaTimeZones.ts b/packages/twenty-shared/src/constants/IanaTimeZones.ts
index a34acd0d0f4..9f04e22c138 100644
--- a/packages/twenty-shared/src/constants/IanaTimeZones.ts
+++ b/packages/twenty-shared/src/constants/IanaTimeZones.ts
@@ -1,4 +1,3 @@
-// Standard IANA time zones
// https://www.iana.org/time-zones
export const IANA_TIME_ZONES = [
'Africa/Abidjan',
diff --git a/packages/twenty-shared/src/testing/types/TestingGenerics.ts b/packages/twenty-shared/src/testing/types/TestingGenerics.ts
index 894018bb92f..59e7b473847 100644
--- a/packages/twenty-shared/src/testing/types/TestingGenerics.ts
+++ b/packages/twenty-shared/src/testing/types/TestingGenerics.ts
@@ -1,33 +1,11 @@
-/**
- * Type testing utilities for TypeScript
- * @module TypeTesting
- */
-
-/**
- * A type utility for testing TypeScript type assertions
- *
- * @template T - The actual type to test
- */
export type Expect<T extends true> = T;
-/**
- * Tests if two types are exactly equal
- *
- * @template A - First type to compare
- * @template B - Second type to compare
- */
export type Equal<A, B> =
(<T>() => T extends A ? 1 : 2) extends <T>() => T extends B ? 1 : 2
? true
: false;
-/**
- * Tests if a type has all required properties of another type
- * Works with both class types and regular object types
- *
- * @template T - Type that should contain the properties
- * @template U - Type whose properties should be contained in T
- */
+// Class types are compared through their instance type
export type HasAllProperties<T, U> = [T] extends [new (...args: any[]) => any]
? HasAllProperties<InstanceType<T>, U>
: [U] extends [new (...args: any[]) => any]
diff --git a/packages/twenty-shared/src/types/RecordGqlOperationOrderBy.ts b/packages/twenty-shared/src/types/RecordGqlOperationOrderBy.ts
index dd0384f9997..c4327c99d49 100644
--- a/packages/twenty-shared/src/types/RecordGqlOperationOrderBy.ts
+++ b/packages/twenty-shared/src/types/RecordGqlOperationOrderBy.ts
@@ -1,6 +1,5 @@
import { type OrderBy } from './OrderBy';
-// Recursive type for nested orderBy values
// Supports: OrderBy | { field: OrderBy } | { field: { subField: OrderBy } } | ...
type OrderByValue = OrderBy | { [fieldName: string]: OrderByValue };
diff --git a/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts b/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts
index a0deb9aa133..39836a37d1d 100644
--- a/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts
+++ b/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts
@@ -20,7 +20,7 @@ describe('applyDiff', () => {
const result = applyDiff(obj, []);
expect(result).toEqual({ test: 'value' });
- expect(result).not.toBe(obj); // Should return a copy
+ expect(result).not.toBe(obj);
});
it('should skip invalid diffs', () => {
@@ -220,8 +220,8 @@ describe('applyDiff', () => {
it('should remove multiple array elements in correct order', () => {
const obj = ['a', 'b', 'c', 'd', 'e'];
const diffs: Difference[] = [
- { type: 'REMOVE', path: [1], oldValue: 'b' }, // Remove 'b'
- { type: 'REMOVE', path: [3], oldValue: 'd' }, // Remove 'd'
+ { type: 'REMOVE', path: [1], oldValue: 'b' },
+ { type: 'REMOVE', path: [3], oldValue: 'd' },
];
const result = applyDiff(obj, diffs);
@@ -231,9 +231,9 @@ describe('applyDiff', () => {
it('should handle complex array removal scenarios', () => {
const obj = ['a', 'b', 'c', 'd', 'e', 'f'];
const diffs: Difference[] = [
- { type: 'REMOVE', path: [0], oldValue: 'a' }, // Remove 'a'
- { type: 'REMOVE', path: [2], oldValue: 'c' }, // Remove 'c'
- { type: 'REMOVE', path: [4], oldValue: 'e' }, // Remove 'e'
+ { type: 'REMOVE', path: [0], oldValue: 'a' },
+ { type: 'REMOVE', path: [2], oldValue: 'c' },
+ { type: 'REMOVE', path: [4], oldValue: 'e' },
];
const result = applyDiff(obj, diffs);
@@ -248,7 +248,7 @@ describe('applyDiff', () => {
],
};
const diffs: Difference[] = [
- { type: 'REMOVE', path: ['items', 0, 'tags', 1], oldValue: 'tag2' }, // Remove 'tag2'
+ { type: 'REMOVE', path: ['items', 0, 'tags', 1], oldValue: 'tag2' },
];
const result = applyDiff(obj, diffs);
@@ -292,7 +292,7 @@ describe('applyDiff', () => {
value: 'newValue',
},
{ type: 'REMOVE', path: ['remove'], oldValue: 'toDelete' },
- { type: 'REMOVE', path: ['nested', 'array', 1], oldValue: 'b' }, // Remove 'b'
+ { type: 'REMOVE', path: ['nested', 'array', 1], oldValue: 'b' },
{ type: 'CREATE', path: ['nested', 'newArray'], value: [1, 2, 3] },
];
@@ -311,10 +311,10 @@ describe('applyDiff', () => {
it('should handle operations on the same array', () => {
const obj = ['a', 'b', 'c', 'd'];
const diffs: Difference[] = [
- { type: 'CHANGE', path: [0], oldValue: 'a', value: 'A' }, // Change 'a' to 'A'
- { type: 'REMOVE', path: [1], oldValue: 'b' }, // Remove 'b'
- { type: 'REMOVE', path: [3], oldValue: 'd' }, // Remove 'd'
- { type: 'REMOVE', path: [3], oldValue: 'd' }, // Remove 'd'
+ { type: 'CHANGE', path: [0], oldValue: 'a', value: 'A' },
+ { type: 'REMOVE', path: [1], oldValue: 'b' },
+ { type: 'REMOVE', path: [3], oldValue: 'd' },
+ { type: 'REMOVE', path: [3], oldValue: 'd' },
];
const result = applyDiff(obj, diffs);
@@ -486,7 +486,7 @@ describe('applyDiff', () => {
const result = applyDiff(obj, diffs);
expect(result).toEqual({ prop: 'newValue' });
- expect(obj.prop).toBe('value'); // Original unchanged
+ expect(obj.prop).toBe('value');
});
});
diff --git a/packages/twenty-shared/src/utils/deepMerge.ts b/packages/twenty-shared/src/utils/deepMerge.ts
index e7d6ab66629..53fe6ce9c6c 100644
--- a/packages/twenty-shared/src/utils/deepMerge.ts
+++ b/packages/twenty-shared/src/utils/deepMerge.ts
@@ -27,7 +27,6 @@ export const deepMerge = <T extends object>(
return;
}
- // Handle Date and RegExp objects - treat them as primitives
if (
targetValue instanceof Date ||
targetValue instanceof RegExp ||
diff --git a/packages/twenty-shared/src/utils/filter/compute-record-gql-operation-filter/for-composite-field/computeGqlOperationFilterForLinks.ts b/packages/twenty-shared/src/utils/filter/compute-record-gql-operation-filter/for-composite-field/computeGqlOperationFilterForLinks.ts
index b7e0b0c879f..0f26f2eb067 100644
--- a/packages/twenty-shared/src/utils/filter/compute-record-gql-operation-filter/for-composite-field/computeGqlOperationFilterForLinks.ts
+++ b/packages/twenty-shared/src/utils/filter/compute-record-gql-operation-filter/for-composite-field/computeGqlOperationFilterForLinks.ts
@@ -92,7 +92,6 @@ export const computeGqlOperationFilterForLinks = ({
default: {
throw new Error( // TODO
`Unknown subfield name ${subFieldName}`,
- // 'UNKNOWN_SUBFIELD_NAME',
);
}
}
diff --git a/packages/twenty-shared/src/utils/validation/__tests__/normalizeLocale.test.ts b/packages/twenty-shared/src/utils/validation/__tests__/normalizeLocale.test.ts
index 242b8cb370f..5acc86288e2 100644
--- a/packages/twenty-shared/src/utils/validation/__tests__/normalizeLocale.test.ts
+++ b/packages/twenty-shared/src/utils/validation/__tests__/normalizeLocale.test.ts
@@ -29,7 +29,6 @@ describe('normalizeLocale', () => {
// For example, 'pt' could map to either 'pt-PT' or 'pt-BR'
// The implementation should map consistently to one of them
expect(normalizeLocale('pt')).toBeTruthy();
- // Verify it's one of the expected values
expect(['pt-PT', 'pt-BR']).toContain(normalizeLocale('pt'));
});
@@ -48,7 +47,6 @@ describe('normalizeLocale', () => {
it('should handle SOURCE_LOCALE and its variants correctly', () => {
expect(normalizeLocale(SOURCE_LOCALE)).toBe(SOURCE_LOCALE);
- // If SOURCE_LOCALE is 'en', test 'en-US', 'en-GB', etc.
if (SOURCE_LOCALE === 'en') {
expect(normalizeLocale('en-US')).toBe(SOURCE_LOCALE);
expect(normalizeLocale('en-GB')).toBe(SOURCE_LOCALE);
diff --git a/packages/twenty-ui/.storybook/main.ts b/packages/twenty-ui/.storybook/main.ts
index abd81a423cd..e40e91920fa 100644
--- a/packages/twenty-ui/.storybook/main.ts
+++ b/packages/twenty-ui/.storybook/main.ts
@@ -53,7 +53,3 @@ const config: StorybookConfig = {
};
export default config;
-
-// To customize your Vite configuration you can use the viteFinal field.
-// Check https://storybook.js.org/docs/react/builders/vite#configuration
-// and https://nx.dev/recipes/storybook/custom-builder-configs
diff --git a/packages/twenty-utils/dangerfile.ts b/packages/twenty-utils/dangerfile.ts
index 187bf8b36d9..e847d17530b 100644
--- a/packages/twenty-utils/dangerfile.ts
+++ b/packages/twenty-utils/dangerfile.ts
@@ -5,7 +5,6 @@ function getMdSection(category: string, message: string) {
return `# ${category} <br>${message}`;
}
-// Check if package.json was changed, but not yarn.lock
const packageChanged = danger.git.modified_files.find((x) =>
x.includes('package.json'),
);
@@ -18,19 +17,16 @@ if (packageChanged && !lockfileChanged) {
warn(`${message} - <i>${idea}</i>`);
}
-// Check environment configuration changes
const envExampleChanged = danger.git.modified_files.find((x) =>
x.includes('.env.example')
);
-// Check if .env.example was changed
if (envExampleChanged) {
const message = 'Changes were made to .env.example';
const idea = 'Please make sure any new environment variables are properly documented with metadata in config-variables.ts';
warn(`${message} - <i>${idea}</i>`);
}
-// CLA alert if first time contributor
if (
danger.github &&
danger.github.pr &&
@@ -47,5 +43,4 @@ By submitting your Pull Request, you acknowledge that you agree with the terms o
);
}
-// TODOS / Fixme
schedule(todos());
diff --git a/packages/twenty-utils/fix-docs-tags.ts b/packages/twenty-utils/fix-docs-tags.ts
index 514a385662d..176f8fc80d2 100644
--- a/packages/twenty-utils/fix-docs-tags.ts
+++ b/packages/twenty-utils/fix-docs-tags.ts
@@ -1,12 +1,5 @@
-/**
- * Script to fix HTML tags in MDX translations that should use Markdown
- *
- * Problem: Some translations use HTML tags (<strong>, <b>, <em>, <i>) instead of
- * Markdown syntax (**, *) causing QA issues and potentially breaking Crowdin builds.
- *
- * Usage:
- * CROWDIN_PERSONAL_TOKEN=xxx npx ts-node packages/twenty-utils/fix-docs-tags.ts
- */
+// HTML emphasis tags in MDX translations trip Crowdin QA and can break the docs build.
+// Usage: CROWDIN_PERSONAL_TOKEN=xxx npx ts-node packages/twenty-utils/fix-docs-tags.ts
const CROWDIN_BASE_URL = 'https://twenty.api.crowdin.com/api/v2';
const CROWDIN_PROJECT_ID = 2; // Docs project
@@ -160,15 +153,12 @@ async function addTranslation(
function fixHtmlTags(text: string): string {
let fixed = text;
- // Fix bold: <strong>...</strong> or <b>...</b> → **...**
fixed = fixed.replace(/<strong>(.*?)<\/strong>/gi, '**$1**');
fixed = fixed.replace(/<b>(.*?)<\/b>/gi, '**$1**');
- // Fix italic: <em>...</em> or <i>...</i> → *...*
fixed = fixed.replace(/<em>(.*?)<\/em>/gi, '*$1*');
fixed = fixed.replace(/<i>(.*?)<\/i>/gi, '*$1*');
- // Fix code: <code>...</code> → `...`
fixed = fixed.replace(/<code>(.*?)<\/code>/gi, '`$1`');
return fixed;
@@ -231,7 +221,6 @@ async function main() {
console.log(` [${key}] Fixing HTML tags...`);
- // Delete old translation
const deleted = await deleteTranslation(token, translation.translationId);
if (!deleted) {
console.error(` [${key}] Failed to delete old translation`);
@@ -239,7 +228,6 @@ async function main() {
continue;
}
- // Add corrected translation
const added = await addTranslation(
token,
issue.stringId,
@@ -270,4 +258,3 @@ main().catch((error) => {
console.error('Error:', error);
process.exit(1);
});
-
diff --git a/packages/twenty-utils/fix-qa-issues.ts b/packages/twenty-utils/fix-qa-issues.ts
index ce2bec657e3..45c97d08360 100644
--- a/packages/twenty-utils/fix-qa-issues.ts
+++ b/packages/twenty-utils/fix-qa-issues.ts
@@ -1,14 +1,4 @@
-/**
- * Script to fix QA issues detected by Crowdin
- *
- * Fixes:
- * - Variables mismatch (translated placeholder names)
- * - Empty translations
- * - Tags mismatch
- *
- * Usage:
- * CROWDIN_PERSONAL_TOKEN=xxx npx ts-node packages/twenty-utils/fix-qa-issues.ts
- */
+// Usage: CROWDIN_PERSONAL_TOKEN=xxx npx ts-node packages/twenty-utils/fix-qa-issues.ts
const CROWDIN_BASE_URL = 'https://twenty.api.crowdin.com/api/v2';
const CROWDIN_PROJECT_ID = 1;
@@ -131,7 +121,6 @@ function extractPlaceholders(text: string): string[] {
return [...new Set(matches)];
}
-// Fix translated placeholder names back to source names
function fixPlaceholderNames(
sourceText: string,
translationText: string,
@@ -141,25 +130,21 @@ function fixPlaceholderNames(
if (sourcePlaceholders.length === 0) return null;
- // Check if any placeholders were translated
const missingInTranslation = sourcePlaceholders.filter(
(p) => !translationPlaceholders.includes(p),
);
if (missingInTranslation.length === 0) return null;
- // Try to find translated versions and replace them
let fixedText = translationText;
for (const sourcePlaceholder of missingInTranslation) {
- // Extract the name from source placeholder
const sourceNameMatch = sourcePlaceholder.match(/\$?\{([^}]+)\}/);
if (!sourceNameMatch) continue;
const sourceName = sourceNameMatch[1];
- // Find potential translations of this placeholder
// Common patterns: {days} -> {jours}, {dae}, {dni}, {días}, etc.
for (const transPlaceholder of translationPlaceholders) {
const transNameMatch = transPlaceholder.match(/\$?\{([^}]+)\}/);
@@ -173,10 +158,7 @@ function fixPlaceholderNames(
!sourcePlaceholders.includes(transPlaceholder) &&
transName !== sourceName
) {
- // Check if this looks like a translation of the source name
- // (same position in ICU structure, similar pattern)
-
- // For ICU plural messages, check if the placeholder appears in same position
+ // A matching occurrence count is the only evidence this is the translated source placeholder
const sourcePattern = new RegExp(
`\\{${sourceName}\\}`,
'g',
@@ -187,7 +169,6 @@ function fixPlaceholderNames(
const transMatches = translationText.match(transPattern)?.length || 0;
if (sourceMatches > 0 && transMatches > 0 && sourceMatches === transMatches) {
- // Replace translated placeholder with source placeholder
fixedText = fixedText.replace(
new RegExp(`\\{${transName}\\}`, 'g'),
`{${sourceName}}`,
@@ -208,7 +189,6 @@ function fixPlaceholderNames(
}
}
- // Return null if nothing changed
if (fixedText === translationText) return null;
return fixedText;
@@ -279,7 +259,6 @@ async function fixVariablesIssues(token: string): Promise<number> {
console.log(` Before: ${translation.text.slice(0, 60)}...`);
console.log(` After: ${fixedText.slice(0, 60)}...`);
- // Delete old translation and add fixed one
await deleteTranslation(token, translation.translationId);
await addTranslation(token, check.stringId, check.languageId, fixedText);
@@ -356,22 +335,18 @@ async function fixTagsIssues(token: string): Promise<number> {
continue;
}
- // Extract tags from source and translation
const sourceTags = sourceText.match(/<\/?[a-zA-Z][^>]*>/g) || [];
const translationTags = translation.text.match(/<\/?[a-zA-Z][^>]*>/g) || [];
- // If translation has extra tags not in source, remove them
if (check.text.includes('extra formatting tags')) {
let fixedText = translation.text;
for (const tag of translationTags) {
if (!sourceTags.includes(tag)) {
- // Remove extra tag
fixedText = fixedText.replace(new RegExp(tag.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'), 'g'), '');
}
}
- // Clean up any double spaces
fixedText = fixedText.replace(/\s+/g, ' ').trim();
if (fixedText !== translation.text) {
@@ -409,13 +384,10 @@ async function main() {
let totalFixed = 0;
- // Fix variables issues
totalFixed += await fixVariablesIssues(token);
- // Fix empty translations
totalFixed += await fixEmptyTranslations(token);
- // Fix tags issues
totalFixed += await fixTagsIssues(token);
console.log(`\n=== Done! Fixed ${totalFixed} issues ===`);
@@ -425,4 +397,3 @@ main().catch((error) => {
console.error('Error:', error);
process.exit(1);
});
-
diff --git a/packages/twenty-utils/translation-qa-report.ts b/packages/twenty-utils/translation-qa-report.ts
index 260ed043f44..022ea71a516 100644
--- a/packages/twenty-utils/translation-qa-report.ts
+++ b/packages/twenty-utils/translation-qa-report.ts
@@ -1,16 +1,5 @@
-/**
- * Script to fetch and display QA issues from Crowdin
- *
- * This script uses Crowdin's native QA checks API to:
- * - Fetch all QA issues detected by Crowdin
- * - Group and display them by category and language
- * - Provide actionable information for fixing
- *
- * Usage:
- * CROWDIN_PERSONAL_TOKEN=xxx npx ts-node packages/twenty-utils/translation-qa-report.ts
- *
- * The token can be obtained from: https://twenty.crowdin.com/u/settings#api-key
- */
+// Usage: CROWDIN_PERSONAL_TOKEN=xxx npx ts-node packages/twenty-utils/translation-qa-report.ts
+// Token: https://twenty.crowdin.com/u/settings#api-key
import * as fs from 'fs';
import * as path from 'path';
@@ -87,7 +76,6 @@ async function fetchAllQAChecks(token: string): Promise<QACheck[]> {
}
function generateReport(checks: QACheck[]): string {
- // Group by category
const byCategory = new Map<string, QACheck[]>();
for (const check of checks) {
@@ -98,7 +86,6 @@ function generateReport(checks: QACheck[]): string {
byCategory.set(key, existing);
}
- // Group by language within each category
let report = `# Crowdin QA Issues Report
Generated: ${new Date().toISOString()}
@@ -134,7 +121,6 @@ Generated: ${new Date().toISOString()}
for (const [category, categoryChecks] of sortedCategories) {
const desc = categoryChecks[0]?.categoryDescription || category;
- // Group by language
const byLang = new Map<string, QACheck[]>();
for (const check of categoryChecks) {
@@ -148,7 +134,6 @@ Generated: ${new Date().toISOString()}
`;
- // Show top issues per language
const sortedLangs = Array.from(byLang.entries()).sort(
(a, b) => b[1].length - a[1].length,
);
@@ -210,7 +195,6 @@ async function main() {
console.log(`\nTotal QA issues: ${checks.length}`);
- // Group by category for summary
const byCategory = new Map<string, number>();
for (const check of checks) {
@@ -223,7 +207,6 @@ async function main() {
console.log(` ${cat}: ${count}`);
}
- // Generate report
const report = generateReport(checks);
const reportPath = path.join(process.cwd(), 'TRANSLATION_QA_REPORT.md');
diff --git a/packages/twenty-website/scripts/pricing-plans-parity.mjs b/packages/twenty-website/scripts/pricing-plans-parity.mjs
index 4541a9eb8b6..9346ab9ee0e 100644
--- a/packages/twenty-website/scripts/pricing-plans-parity.mjs
+++ b/packages/twenty-website/scripts/pricing-plans-parity.mjs
@@ -13,7 +13,6 @@ const { compare, fail, finish, ok } = createBattery('pricing-plans-parity');
const browser = await launchBrowser();
-// Reads the two plan cards: heading, price value/suffix, CTA, bullets.
function readPlanCards(page) {
return page.evaluate(() => {
const headings = [...document.querySelectorAll('h3')].filter((el) =>
@@ -70,7 +69,6 @@ const newPage = await openPage(browser, `${NEW_BASE}/pricing`, {
await scrollToPlans(oldPage);
await scrollToPlans(newPage);
-// --- Default state (cloud + yearly) ------------------------------------
const oldDefault = await readPlanCards(oldPage);
const newDefault = await readPlanCards(newPage);
@@ -97,7 +95,6 @@ if (oldDefault.length !== 2 || newDefault.length !== 2) {
]);
}
-// --- Billing toggle: yearly -> monthly raises Pro to $12 ----------------
await clickToggle(oldPage, 'Monthly');
await clickToggle(newPage, 'Monthly');
const oldMonthly = await readPlanCards(oldPage);
@@ -109,7 +106,6 @@ if (newMonthly[0].price.includes('12')) {
fail('Pro rises to $12 on monthly billing', newMonthly[0].price);
}
-// --- Self-host toggle: Pro drops to $0, bullets swap to self-host -------
await clickToggle(oldPage, 'Selfhosting');
await clickToggle(newPage, 'Selfhosting');
const oldSelfHost = await readPlanCards(oldPage);
diff --git a/packages/twenty-website/scripts/product-feature-parity.mjs b/packages/twenty-website/scripts/product-feature-parity.mjs
index 5447e3de981..96d79168f2d 100644
--- a/packages/twenty-website/scripts/product-feature-parity.mjs
+++ b/packages/twenty-website/scripts/product-feature-parity.mjs
@@ -235,7 +235,6 @@ const pages = [
['new', newPage],
];
-// --- Section anatomy + lattice + entrance + tile styles ---------------
const anatomies = {};
for (const [name, page] of pages) {
// eslint-disable-next-line no-await-in-loop
@@ -293,7 +292,6 @@ if (!anatomies.old || !anatomies.new) {
);
}
-// --- Donut sweep (spotlight active state) ------------------------------
const donuts = {};
for (const [name, page] of pages) {
// eslint-disable-next-line no-await-in-loop
@@ -325,7 +323,6 @@ if (!donuts.old || !donuts.new) {
}
}
-// --- Contacts: checkbox + drag-scroll ----------------------------------
const checkboxes = {};
for (const [name, page] of pages) {
// eslint-disable-next-line no-await-in-loop
@@ -397,7 +394,6 @@ if (scrolls.old && scrolls.new) {
}
}
-// --- Pipeline: drag-drop-reorder + FLIP --------------------------------
for (const [name, page] of pages) {
// eslint-disable-next-line no-await-in-loop
await scrollToText(page, 'All opportunities', 1400);
diff --git a/packages/twenty-website/scripts/product-stepper-parity.mjs b/packages/twenty-website/scripts/product-stepper-parity.mjs
index c2e55b41080..a5a84c90998 100644
--- a/packages/twenty-website/scripts/product-stepper-parity.mjs
+++ b/packages/twenty-website/scripts/product-stepper-parity.mjs
@@ -29,7 +29,6 @@ const compositeOverWhite = (cssColor) => {
const browser = await launchBrowser();
-// Scrolls the stepper section to a fraction of its own scrollable track.
async function scrollSectionTo(page, trackFraction) {
await page.evaluate(
({ needle, fraction }) => {
@@ -146,7 +145,6 @@ const pages = [
['new', newPage],
];
-// --- Step 1: section chrome + initial choreography ---------------------
await scrollSectionTo(oldPage, 0.05);
await scrollSectionTo(newPage, 0.05);
const oldStart = await readStepperState(oldPage);
@@ -189,7 +187,6 @@ if (!oldStart || !newStart) {
}
}
-// --- Mid-track: second step takes over ----------------------------------
await scrollSectionTo(oldPage, 0.5);
await scrollSectionTo(newPage, 0.5);
const oldMid = await readStepperState(oldPage);
@@ -228,7 +225,6 @@ for (const [name, page] of pages) {
}
}
-// --- Back to step 1: entity drag + edges follow -------------------------
for (const [name, page] of pages) {
// eslint-disable-next-line no-await-in-loop
await scrollSectionTo(page, 0.05);
@@ -265,7 +261,6 @@ for (const [name, page] of pages) {
}
}
-// --- Step 3: layout visibility toggle ------------------------------------
for (const [name, page] of pages) {
// eslint-disable-next-line no-await-in-loop
await scrollSectionTo(page, 0.85);
diff --git a/packages/twenty-website/scripts/three-cards-parity.mjs b/packages/twenty-website/scripts/three-cards-parity.mjs
index 91432194c92..33b846e5028 100644
--- a/packages/twenty-website/scripts/three-cards-parity.mjs
+++ b/packages/twenty-website/scripts/three-cards-parity.mjs
@@ -54,7 +54,6 @@ function readSection(page, headingNeedle) {
? `${containerStyle.paddingLeft} ${containerStyle.rowGap}`
: null,
headingStyle: `${headingStyle.fontSize} ${headingStyle.fontWeight} ${headingStyle.maxWidth}`,
- // Per-card anatomy: an h3, a body, and whether a footer rendered.
cards: slots.map((slot) => ({
hasHeading: Boolean(slot.querySelector('h3')),
hasFooter: Boolean(slot.querySelector('footer')),
@@ -85,7 +84,6 @@ async function scrollGridTo(page, gridTop, viewportFraction) {
await page.waitForTimeout(350);
}
-// --- HOME: restored scroll choreography --------------------------------
{
const oldPage = await openSitePage(OLD_BASE, '/');
const newPage = await openSitePage(NEW_BASE, '/');
@@ -194,7 +192,6 @@ async function scrollGridTo(page, gridTop, viewportFraction) {
await newReduced.close();
}
-// --- PRODUCT: intro, rhythm, footerless cards ---------------------------
{
const oldPage = await openSitePage(OLD_BASE, '/product');
const newPage = await openSitePage(NEW_BASE, '/product');
diff --git a/packages/twenty-website/src/app-preview/product-visual/ProductVisual.tsx b/packages/twenty-website/src/app-preview/product-visual/ProductVisual.tsx
index 71f7d7eaa9c..8afd3335072 100644
--- a/packages/twenty-website/src/app-preview/product-visual/ProductVisual.tsx
+++ b/packages/twenty-website/src/app-preview/product-visual/ProductVisual.tsx
@@ -109,7 +109,6 @@ export function ProductVisual({
{ mobile: compactCursorTour },
);
- // The tour drives the page the collaborators look at.
useEffect(() => {
if (collaborative) {
selectPageItem(heroCursor.pageItemId);
diff --git a/packages/twenty-website/src/app-preview/product-visual/cursor-tour-phases.ts b/packages/twenty-website/src/app-preview/product-visual/cursor-tour-phases.ts
index 31b9108f0d0..aafb5db65b6 100644
--- a/packages/twenty-website/src/app-preview/product-visual/cursor-tour-phases.ts
+++ b/packages/twenty-website/src/app-preview/product-visual/cursor-tour-phases.ts
@@ -279,7 +279,6 @@ const MOBILE_PHASES: TourPhase[] = [
},
];
-// The tour replays from the top once the last phase's dwell elapses.
function nextPhaseIndex(current: number, phaseCount: number): number {
return current >= phaseCount - 1 ? LOOP_START_INDEX : current + 1;
}
diff --git a/packages/twenty-website/src/app-preview/product-visual/use-product-visual-autoplay.ts b/packages/twenty-website/src/app-preview/product-visual/use-product-visual-autoplay.ts
index 79828620dc1..11f417b9ad2 100644
--- a/packages/twenty-website/src/app-preview/product-visual/use-product-visual-autoplay.ts
+++ b/packages/twenty-website/src/app-preview/product-visual/use-product-visual-autoplay.ts
@@ -80,7 +80,6 @@ export function useProductVisualAutoplay(
timeouts.schedule(tick, STREAM_TICK_MS);
};
- // Agentic preamble: play the steps in sequence, then stream the answer.
const steps = selectedScene.steps ?? [];
const playStep = (stepIndex: number) => {
diff --git a/packages/twenty-website/src/app/[locale]/(site)/releases/page.tsx b/packages/twenty-website/src/app/[locale]/(site)/releases/page.tsx
index 00abbc410e9..eb69791f344 100644
--- a/packages/twenty-website/src/app/[locale]/(site)/releases/page.tsx
+++ b/packages/twenty-website/src/app/[locale]/(site)/releases/page.tsx
@@ -15,7 +15,6 @@ import { ReleasesHero } from '@/sections/releases-hero';
export const generateMetadata = buildRouteMetadata('releases');
-// Hero only for now; the release feed lands below it as its port arrives.
export default async function ReleasesPage({
params,
}: {
diff --git a/packages/twenty-website/src/case-studies/case-study-types.ts b/packages/twenty-website/src/case-studies/case-study-types.ts
index 3333c0cd5f8..a21fa7b0dc7 100644
--- a/packages/twenty-website/src/case-studies/case-study-types.ts
+++ b/packages/twenty-website/src/case-studies/case-study-types.ts
@@ -13,9 +13,8 @@ export type CaseStudyQuote = {
role: MessageDescriptor;
};
-// The card-facing shape of a customer story. The full /customers/<slug> story
-// (sections, table of contents) extends this in the detail-page phase; the
-// catalog grid needs only these fields.
+// The card-facing shape of a customer story; the /customers/<slug> detail page
+// pairs it with the CaseStudyStory keyed by the same slug.
export type CaseStudyCatalogEntry = {
slug: string;
industry: MessageDescriptor;
diff --git a/packages/twenty-website/src/case-studies/client-logo-config.ts b/packages/twenty-website/src/case-studies/client-logo-config.ts
index fec2eac04f6..212430daab9 100644
--- a/packages/twenty-website/src/case-studies/client-logo-config.ts
+++ b/packages/twenty-website/src/case-studies/client-logo-config.ts
@@ -1,6 +1,6 @@
// The customer wordmarks shown on each case-study card. The old site shipped
// five near-identical SVG files; here they are one config-driven component
-// (client-logo.tsx) plus the dotted Nine Dots mark. viewBox height is always
+// (ClientLogo.tsx) plus the dotted Nine Dots mark. viewBox height is always
// 22 for wordmarks; the dots mark is a fixed 56x56 grid.
export type ClientLogoKey =
| 'nine-dots'
diff --git a/packages/twenty-website/src/icons/ChevronDown.tsx b/packages/twenty-website/src/icons/ChevronDown.tsx
index f491093ca83..f4966857ade 100644
--- a/packages/twenty-website/src/icons/ChevronDown.tsx
+++ b/packages/twenty-website/src/icons/ChevronDown.tsx
@@ -4,7 +4,6 @@ export type ChevronDownProps = {
sizePx?: number;
};
-// A downward chevron on currentColor — the consumer sets the ink via color.
export function ChevronDown({ sizePx = 12 }: ChevronDownProps) {
return (
<svg
diff --git a/packages/twenty-website/src/icons/Search.tsx b/packages/twenty-website/src/icons/Search.tsx
index 2baaf9f2c2c..27e3ccc6bd1 100644
--- a/packages/twenty-website/src/icons/Search.tsx
+++ b/packages/twenty-website/src/icons/Search.tsx
@@ -4,7 +4,6 @@ export type SearchProps = {
sizePx?: number;
};
-// A magnifier on currentColor — the consumer sets the ink via color.
export function Search({ sizePx = 16 }: SearchProps) {
return (
<svg
diff --git a/packages/twenty-website/src/partners-marketplace/case-study-card-aspect-ratio.ts b/packages/twenty-website/src/partners-marketplace/case-study-card-aspect-ratio.ts
index 1ccf5164df9..de154c4e1c5 100644
--- a/packages/twenty-website/src/partners-marketplace/case-study-card-aspect-ratio.ts
+++ b/packages/twenty-website/src/partners-marketplace/case-study-card-aspect-ratio.ts
@@ -1,2 +1 @@
-/** Landscape crop for case-study cards on the profile page. */
export const CASE_STUDY_CARD_ASPECT_RATIO = '16 / 9';
diff --git a/packages/twenty-website/src/partners-marketplace/case-study-modal-image-height.ts b/packages/twenty-website/src/partners-marketplace/case-study-modal-image-height.ts
index f1d3fcdb4f9..76b0dbae10e 100644
--- a/packages/twenty-website/src/partners-marketplace/case-study-modal-image-height.ts
+++ b/packages/twenty-website/src/partners-marketplace/case-study-modal-image-height.ts
@@ -1,2 +1,2 @@
-/** Modal hero strip — capped height so copy stays above the fold. */
+// Capped so the modal copy stays above the fold.
export const CASE_STUDY_MODAL_IMAGE_HEIGHT = 'clamp(148px, 18dvh, 192px)';
diff --git a/packages/twenty-website/src/partners-marketplace/case-study-sample-image.ts b/packages/twenty-website/src/partners-marketplace/case-study-sample-image.ts
index 11ace8624a1..7703ca314f1 100644
--- a/packages/twenty-website/src/partners-marketplace/case-study-sample-image.ts
+++ b/packages/twenty-website/src/partners-marketplace/case-study-sample-image.ts
@@ -1,3 +1,3 @@
-/** PartnerPage-style featured-work screenshot (contain on white), for local dummy data. */
+// PartnerPage-style featured-work screenshot (contain on white), for local dummy data.
export const CASE_STUDY_PARTNERPAGE_SAMPLE =
'https://content.partnerpage.io/eyJidWNrZXQiOiJwYXJ0bmVycGFnZS5wcm9kIiwia2V5IjoibWVkaWEvZmVhdHVyZWRfd29yay9mYzA5MzYzYi0yOWE5LTQ1M2EtYWEyNy1jMDUxNzI2MjE0ZTEvMTc5YWM3MzAtY2NiNy00MzcxLTkzZGQtNzljMWVkMTg2NTRjLnBuZyIsImVkaXRzIjp7InRvRm9ybWF0Ijoid2VicCIsInJlc2l6ZSI6eyJmaXQiOiJjb250YWluIiwiYmFja2dyb3VuZCI6eyJyIjoyNTUsImciOjI1NSwiYiI6MjU1LCJhbHphaCI6MH19fX0=';
diff --git a/packages/twenty-website/src/partners-marketplace/format-partner-link-label.ts b/packages/twenty-website/src/partners-marketplace/format-partner-link-label.ts
index 0b7547a4ca0..4f26b5067d4 100644
--- a/packages/twenty-website/src/partners-marketplace/format-partner-link-label.ts
+++ b/packages/twenty-website/src/partners-marketplace/format-partner-link-label.ts
@@ -1,4 +1,3 @@
-/** Human-readable label from a URL — usually the hostname, path included when useful. */
export function formatPartnerLinkLabel(url: string): string {
try {
const parsed = new URL(url.includes('://') ? url : `https://${url}`);
diff --git a/packages/twenty-website/src/partners-marketplace/marketplace-partner.ts b/packages/twenty-website/src/partners-marketplace/marketplace-partner.ts
index 3c1cdb9e883..d7706c4501f 100644
--- a/packages/twenty-website/src/partners-marketplace/marketplace-partner.ts
+++ b/packages/twenty-website/src/partners-marketplace/marketplace-partner.ts
@@ -29,7 +29,7 @@ export type MarketplacePartner = {
hourlyRateUsd: number | null;
projectBudgetMinUsd: number | null;
links: PartnerLinks;
- /** Flat profile URLs from `/s/partner-by-slug`; preferred over typed `links` on profile pages. */
+ // Flat profile URLs from `/s/partner-by-slug`; preferred over typed `links` on profile pages.
linkUrls?: readonly string[];
profilePictureUrl: string;
city: string;
diff --git a/packages/twenty-website/src/partners-marketplace/toggle-in-set.ts b/packages/twenty-website/src/partners-marketplace/toggle-in-set.ts
index 1b8e2e4f42d..8b0a01dd6ff 100644
--- a/packages/twenty-website/src/partners-marketplace/toggle-in-set.ts
+++ b/packages/twenty-website/src/partners-marketplace/toggle-in-set.ts
@@ -1,4 +1,3 @@
-// Immutable Set toggle: returns a new Set with the value added or removed.
export const toggleInSet = <Value>(
set: ReadonlySet<Value>,
value: Value,
diff --git a/packages/twenty-website/src/platform/motion/animated-number.ts b/packages/twenty-website/src/platform/motion/animated-number.ts
index d665c2fb8fd..28de0692033 100644
--- a/packages/twenty-website/src/platform/motion/animated-number.ts
+++ b/packages/twenty-website/src/platform/motion/animated-number.ts
@@ -1,7 +1,5 @@
export type AnimatedNumberEasing = (progress: number) => number;
-// Pure number-tween math (the pricing cards' price counter): value at an
-// elapsed time, eased and rounded. Ported.
const DEFAULT_DURATION_MS = 500;
function clampUnitInterval(value: number): number {
diff --git a/packages/twenty-website/src/platform/motion/clamp-progress.ts b/packages/twenty-website/src/platform/motion/clamp-progress.ts
index bea71b107af..a129f4d5fe0 100644
--- a/packages/twenty-website/src/platform/motion/clamp-progress.ts
+++ b/packages/twenty-website/src/platform/motion/clamp-progress.ts
@@ -1,4 +1,3 @@
-// Every progress computation shares one clamp to the unit interval.
export function clampProgress(value: number): number {
return Math.max(0, Math.min(1, value));
}
diff --git a/packages/twenty-website/src/platform/motion/clamp-to-range.ts b/packages/twenty-website/src/platform/motion/clamp-to-range.ts
index 4704b1c9f0c..e517f99fa9b 100644
--- a/packages/twenty-website/src/platform/motion/clamp-to-range.ts
+++ b/packages/twenty-website/src/platform/motion/clamp-to-range.ts
@@ -1,4 +1,3 @@
-// Bounds a value to [min, max] (drag clamping and friends).
export function clampToRange(value: number, min: number, max: number): number {
return Math.min(Math.max(value, min), max);
}
diff --git a/packages/twenty-website/src/platform/motion/observe-element-size.ts b/packages/twenty-website/src/platform/motion/observe-element-size.ts
index 002924ffd87..a86977fad6c 100644
--- a/packages/twenty-website/src/platform/motion/observe-element-size.ts
+++ b/packages/twenty-website/src/platform/motion/observe-element-size.ts
@@ -1,5 +1,3 @@
-// ResizeObserver with a window-resize fallback, ported from the old
-// site's dom helper. Returns the stop function.
export function observeElementSize(
element: Element,
onResize: () => void,
diff --git a/packages/twenty-website/src/platform/motion/use-animated-number.ts b/packages/twenty-website/src/platform/motion/use-animated-number.ts
index 4132c01895b..f2aa809b94d 100644
--- a/packages/twenty-website/src/platform/motion/use-animated-number.ts
+++ b/packages/twenty-website/src/platform/motion/use-animated-number.ts
@@ -6,8 +6,6 @@ import { animatedNumber } from './animated-number';
import { createAnimationFrameLoop } from './animation-frame-loop';
import { getReducedMotionSnapshot } from './reduced-motion-snapshot';
-// Tweens the displayed integer toward the target on a rAF loop (the
-// pricing cards' price counter). Reduced motion snaps to the target.
export function useAnimatedNumber(target: number): number {
const [display, setDisplay] = useState(() => Math.round(target));
const displayRef = useRef(display);
diff --git a/packages/twenty-website/src/platform/motion/use-scale-to-fit.ts b/packages/twenty-website/src/platform/motion/use-scale-to-fit.ts
index 0bb147ab679..924fdbd3f04 100644
--- a/packages/twenty-website/src/platform/motion/use-scale-to-fit.ts
+++ b/packages/twenty-website/src/platform/motion/use-scale-to-fit.ts
@@ -4,8 +4,6 @@ import { useEffect, useState, type RefObject } from 'react';
import { observeElementSize } from './observe-element-size';
-// The uniform scale that fits a fixed design box into a live container
-// (feature scenes author at 411x508 and shrink together). Ported.
export function useScaleToFit(
containerRef: RefObject<HTMLElement | null>,
designWidth: number,
diff --git a/packages/twenty-website/src/platform/motion/use-scheduled-on-scroll.ts b/packages/twenty-website/src/platform/motion/use-scheduled-on-scroll.ts
index 673b1462fd9..5d6d40c5d4a 100644
--- a/packages/twenty-website/src/platform/motion/use-scheduled-on-scroll.ts
+++ b/packages/twenty-website/src/platform/motion/use-scheduled-on-scroll.ts
@@ -4,8 +4,6 @@ import { useEffect } from 'react';
import { createAnimationFrameLoop } from './animation-frame-loop';
-// Runs the callback on scroll/resize, batched to one call per animation
-// frame regardless of event rate.
export function useScheduledOnScroll(
callback: () => void,
options: { enabled?: boolean } = {},
diff --git a/packages/twenty-website/src/platform/motion/use-scroll-progress.ts b/packages/twenty-website/src/platform/motion/use-scroll-progress.ts
index c5049743af2..b58e39fde01 100644
--- a/packages/twenty-website/src/platform/motion/use-scroll-progress.ts
+++ b/packages/twenty-website/src/platform/motion/use-scroll-progress.ts
@@ -5,8 +5,6 @@ import { useEffect, type RefObject } from 'react';
import { createAnimationFrameLoop } from './animation-frame-loop';
import { computeScrollProgress } from './compute-scroll-progress';
-// Reports the container's scroll progress, batched to animation frames
-// (one read per frame regardless of scroll event rate).
export function useScrollProgress(
scrollContainerRef: RefObject<HTMLElement | null>,
onProgress: (progress: number) => void,
diff --git a/packages/twenty-website/src/platform/visuals/halftone-studio/engine/image-constants.ts b/packages/twenty-website/src/platform/visuals/halftone-studio/engine/image-constants.ts
index 4b19af25773..c495ed87ee3 100644
--- a/packages/twenty-website/src/platform/visuals/halftone-studio/engine/image-constants.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone-studio/engine/image-constants.ts
@@ -1,4 +1,3 @@
-// Image-mode pointer-follow + hover-fade tuning for the halftone image canvas.
export const HALFTONE_IMAGE_CONSTANTS = {
pointerFollow: 0.38,
pointerVelocityDamping: 0.82,
diff --git a/packages/twenty-website/src/platform/visuals/halftone-studio/engine/studio-settings-defaults.ts b/packages/twenty-website/src/platform/visuals/halftone-studio/engine/studio-settings-defaults.ts
index d19504b8a04..d309a3fc90b 100644
--- a/packages/twenty-website/src/platform/visuals/halftone-studio/engine/studio-settings-defaults.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone-studio/engine/studio-settings-defaults.ts
@@ -175,7 +175,6 @@ const SETTINGS: HalftoneStudioSettings = {
animation: { ...SOLID_ANIMATION },
};
-// Every default the studio settings model draws on, in one place.
export const HALFTONE_STUDIO_DEFAULTS = {
geometrySpecs: GEOMETRY_SPECS,
shapeHalftone: SHAPE_HALFTONE,
diff --git a/packages/twenty-website/src/platform/visuals/halftone-studio/engine/studio-settings-types.ts b/packages/twenty-website/src/platform/visuals/halftone-studio/engine/studio-settings-types.ts
index 4801edcc002..6f89195ecd3 100644
--- a/packages/twenty-website/src/platform/visuals/halftone-studio/engine/studio-settings-types.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone-studio/engine/studio-settings-types.ts
@@ -1,6 +1,3 @@
-// The halftone studio's settings vocabulary (ported from the old
-// lib/halftone state model; interfaces → types per the redone convention).
-
export type HalftoneTabId = 'design' | 'animations' | 'export';
export type HalftoneSourceMode = 'shape' | 'image';
export type HalftoneMaterialSurface = 'solid' | 'glass';
diff --git a/packages/twenty-website/src/platform/visuals/halftone-studio/engine/use-latest-ref.ts b/packages/twenty-website/src/platform/visuals/halftone-studio/engine/use-latest-ref.ts
index 4ce1911e303..a7124ed63f2 100644
--- a/packages/twenty-website/src/platform/visuals/halftone-studio/engine/use-latest-ref.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone-studio/engine/use-latest-ref.ts
@@ -1,7 +1,5 @@
import { type RefObject, useRef } from 'react';
-// Keeps a ref in sync with the latest value every render, so effects and
-// long-lived render loops can read current props/callbacks without resubscribing.
export function useLatestRef<Value>(value: Value): RefObject<Value> {
const reference = useRef(value);
reference.current = value;
diff --git a/packages/twenty-website/src/platform/visuals/halftone/blur-pipeline.ts b/packages/twenty-website/src/platform/visuals/halftone/blur-pipeline.ts
index 090c8fa1dc9..099b00c199f 100644
--- a/packages/twenty-website/src/platform/visuals/halftone/blur-pipeline.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone/blur-pipeline.ts
@@ -15,8 +15,6 @@ type BlurPipeline = {
dispose: () => void;
};
-// The double gaussian blur chain shared by every glow-sampling composite
-// (rows sessions, the transmission materials).
export function createBlurPipeline(
width: number,
height: number,
diff --git a/packages/twenty-website/src/platform/visuals/halftone/create-band-session.ts b/packages/twenty-website/src/platform/visuals/halftone/create-band-session.ts
index f0ebcc71112..bd5ec1e59b8 100644
--- a/packages/twenty-website/src/platform/visuals/halftone/create-band-session.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone/create-band-session.ts
@@ -187,7 +187,7 @@ function getMeshFootprintScale({
// The band-variant model scene: transmission material (solid or glass),
// breathe/float/rotate-preset/spring/parallax animation, per-frame mesh
-// footprint, blur chain, band dash composite. Ported from the old
+// footprint, band dash composite. Ported from the old
// HalftoneCanvas shape mode.
export async function createBandSession({
container,
diff --git a/packages/twenty-website/src/platform/visuals/halftone/create-halftone-session.ts b/packages/twenty-website/src/platform/visuals/halftone/create-halftone-session.ts
index ef47fe91f21..6ee63fca28e 100644
--- a/packages/twenty-website/src/platform/visuals/halftone/create-halftone-session.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone/create-halftone-session.ts
@@ -48,8 +48,7 @@ function setPrimaryLightPosition(
// The complete rows-variant halftone scene: standard-material mesh, double
// gaussian blur chain, row composite — ported from the authored hourglass
-// pipeline. (The band variant with the transmission material arrives with
-// its consumers.)
+// pipeline.
export function createHalftoneSession({
container,
geometry,
diff --git a/packages/twenty-website/src/platform/visuals/halftone/create-image-session.ts b/packages/twenty-website/src/platform/visuals/halftone/create-image-session.ts
index 128d0794915..761bc3048bd 100644
--- a/packages/twenty-website/src/platform/visuals/halftone/create-image-session.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone/create-image-session.ts
@@ -49,7 +49,7 @@ export type ImageSessionSettings = {
// Fades the hover light toward the top/bottom canvas edges (0 = off).
lightVerticalFade?: number;
// Hover radii authored at this preview distance, scaled each frame to the
- // live framing (the partner hero's getHoverScale); omit to keep them fixed.
+ // live framing (the partner hero); omit to keep them fixed.
radiusReferenceDistance?: number;
fadeIn: number;
fadeOut: number;
@@ -243,7 +243,7 @@ function getRelativeImageScale({
return Math.max(Math.sqrt(currentArea / referenceArea), MIN_FOOTPRINT_SCALE);
}
-// The image-backdrop scene: image pass -> blur chain -> band composite,
+// The image-backdrop scene: image pass -> band composite,
// with pointer-follow hover light/flow. One rig replaces the old site's
// four ~700-line per-backdrop hooks.
export function createImageSession({
diff --git a/packages/twenty-website/src/platform/visuals/halftone/create-render-target.ts b/packages/twenty-website/src/platform/visuals/halftone/create-render-target.ts
index 6b85dc1c9f4..ce191b6d143 100644
--- a/packages/twenty-website/src/platform/visuals/halftone/create-render-target.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone/create-render-target.ts
@@ -1,6 +1,5 @@
import * as THREE from 'three';
-// The linear RGBA target every halftone pass renders into.
export function createRenderTarget(width: number, height: number) {
return new THREE.WebGLRenderTarget(width, height, {
format: THREE.RGBAFormat,
diff --git a/packages/twenty-website/src/platform/visuals/halftone/halftone-interaction-state.ts b/packages/twenty-website/src/platform/visuals/halftone/halftone-interaction-state.ts
index d9b5ed92d9f..87499842953 100644
--- a/packages/twenty-website/src/platform/visuals/halftone/halftone-interaction-state.ts
+++ b/packages/twenty-website/src/platform/visuals/halftone/halftone-interaction-state.ts
@@ -113,7 +113,6 @@ const resetState = (
}
};
-// Pure pointer/rotation physics shared by every halftone scene.
export const halftoneInteraction = {
create: createState,
springStep,
diff --git a/packages/twenty-website/src/sections/case-study-promo/CaseStudyPromo.tsx b/packages/twenty-website/src/sections/case-study-promo/CaseStudyPromo.tsx
index eabbc80fecf..2610fe81519 100644
--- a/packages/twenty-website/src/sections/case-study-promo/CaseStudyPromo.tsx
+++ b/packages/twenty-website/src/sections/case-study-promo/CaseStudyPromo.tsx
@@ -79,7 +79,6 @@ const VisualStage = styled.div`
}
`;
-// The floating count chip overlaps the mic visual at its lower-left corner.
const CountChip = styled.div`
align-items: center;
background-color: ${color('white')};
diff --git a/packages/twenty-website/src/sections/case-study-promo/case-studies.ts b/packages/twenty-website/src/sections/case-study-promo/case-studies.ts
index 25140f1e4ed..109c082e881 100644
--- a/packages/twenty-website/src/sections/case-study-promo/case-studies.ts
+++ b/packages/twenty-website/src/sections/case-study-promo/case-studies.ts
@@ -1,6 +1,4 @@
-// The canonical list of customer case studies, each a /customers/<slug> story.
-// The promo reads the count from here; the customers catalog and the
-// /customers/[slug] route family will grow per-entry content off the same list.
+// Mirrors the slugs in @/case-studies/case-study-catalog; the promo counts them, so keep both lists in sync.
export const CASE_STUDY_SLUGS: readonly string[] = [
'9dots',
'alternative-partners',
diff --git a/packages/twenty-website/src/sections/compare/compare-data.ts b/packages/twenty-website/src/sections/compare/compare-data.ts
index 566d380a4e5..2bad2aa4de2 100644
--- a/packages/twenty-website/src/sections/compare/compare-data.ts
+++ b/packages/twenty-website/src/sections/compare/compare-data.ts
@@ -51,7 +51,6 @@ export type CompetitorComparison = {
const HUBSPOT_PRICING_URL = 'https://www.hubspot.com/pricing/sales';
const SALESFORCE_PRICING_URL = 'https://www.salesforce.com/sales/pricing/';
-// const ATTIO_PRICING_URL = 'https://attio.com/pricing';
const PIPEDRIVE_PRICING_URL = 'https://www.pipedrive.com/en/pricing';
const DYNAMICS_PRICING_URL =
'https://www.microsoft.com/en-us/dynamics-365/products/sales/pricing';
@@ -247,93 +246,6 @@ const SALESFORCE_COMPARISON: CompetitorComparison = {
sourceNote: msg`List prices from Salesforce's public pricing page, billed annually, checked on July 30, 2026.`,
};
-// The Attio comparison is parked for now (may return later). The data is
-// kept commented so it only needs re-verification to come back.
-// export const ATTIO_COMPARISON: CompetitorComparison = {
-// competitor: 'Attio',
-// competitorColumnLabel: msg`On Attio`,
-// eyebrow: msg`Twenty vs Attio`,
-// heading: msg`What does\n*Attio* really cost?`,
-// intro: msg`Both are modern CRMs. One is open source.\nHere is the price of the difference.`,
-// migrationLine: msg`Import your data and see your own numbers. Moving a workspace from Attio usually takes an afternoon.`,
-// slug: 'attio',
-// tableTitle: msg`The same features, priced differently`,
-// rows: [
-// {
-// feature: msg`The modern CRM`,
-// description: msg`Objects, pipelines, email sync`,
-// competitor: {
-// price: msg`$35/user/mo`,
-// detail: msg`Plus plan, billed annually`,
-// sourceUrl: ATTIO_PRICING_URL,
-// },
-// twenty: { detail: msg`$9/user on Pro` },
-// },
-// {
-// feature: msg`The full platform`,
-// description: msg`Advanced reporting and workflows`,
-// competitor: {
-// price: msg`$79/user/mo`,
-// detail: msg`Pro plan, billed annually`,
-// sourceUrl: ATTIO_PRICING_URL,
-// },
-// twenty: { detail: msg`Included from Pro, $9/user` },
-// },
-// {
-// feature: msg`SAML SSO & advanced admin`,
-// description: msg`Single sign-on, access control`,
-// competitor: {
-// price: msg`Custom pricing`,
-// detail: msg`Enterprise plan only`,
-// sourceUrl: ATTIO_PRICING_URL,
-// },
-// twenty: { detail: msg`Organization, $19/user` },
-// },
-// {
-// feature: msg`Cost per workflow run`,
-// description: msg`An automation that writes a record`,
-// competitor: {
-// price: msg`From ≈ 1.5¢/run`,
-// detail: msg`One credit per data-writing block, $150 per 10k credits`,
-// sourceUrl: ATTIO_PRICING_URL,
-// },
-// twenty: { detail: msg`Credit allowance included with every plan` },
-// },
-// {
-// feature: msg`Source code`,
-// description: msg`Audit it, extend it, own it`,
-// competitor: {
-// price: msg`Closed`,
-// detail: msg`Proprietary`,
-// },
-// twenty: { detail: msg`Open source` },
-// },
-// ],
-// receipt: {
-// scenario: msg`A 20-person team, billed annually`,
-// competitorLines: [
-// { label: msg`20 × Pro ($79)`, amount: msg`$18,960/yr` },
-// {
-// label: msg`SSO & advanced admin`,
-// amount: msg`Enterprise upgrade`,
-// },
-// ],
-// competitorTotalAmount: msg`$18,960+`,
-// competitorTotalSuffix: msg`per year`,
-// competitorPerUser: msg`$79 per user per month, before Enterprise`,
-// twentyLines: [
-// { label: msg`20 × Organization ($19)`, amount: msg`$4,560/yr` },
-// { label: msg`SSO & advanced admin`, amount: msg`Included` },
-// ],
-// twentyTotalAmount: msg`$4,560`,
-// twentyTotalSuffix: msg`per year`,
-// twentyPerUser: msg`$19 per user per month, SSO included`,
-// multiplier: msg`≈ 4× less`,
-// },
-// honest: msg`Attio is a polished, fast product with strong built-in enrichment. If you never need to extend or own your CRM, it is a credible pick.`,
-// sourceNote: msg`List prices from Attio's public pricing page, billed annually, checked on July 30, 2026.`,
-// };
-
const PIPEDRIVE_COMPARISON: CompetitorComparison = {
competitor: 'Pipedrive',
competitorColumnLabel: msg`On Pipedrive`,
diff --git a/packages/twenty-website/src/sections/customers-hero/CustomersHero.tsx b/packages/twenty-website/src/sections/customers-hero/CustomersHero.tsx
index 678fca173aa..9671178be6f 100644
--- a/packages/twenty-website/src/sections/customers-hero/CustomersHero.tsx
+++ b/packages/twenty-website/src/sections/customers-hero/CustomersHero.tsx
@@ -11,8 +11,7 @@ const GradientBackdrop = styled.div`
position: absolute;
`;
-// Intro-only hero on the shared hero rhythm (Heading->Body 12px); no CTA, no
-// visual. The catalog of case studies lands below later.
+// Intro-only hero on the shared hero rhythm (Heading->Body 12px); no CTA, no visual.
const IntroStack = styled.div`
align-items: center;
display: flex;
diff --git a/packages/twenty-website/src/sections/faq/FaqBackdrop.tsx b/packages/twenty-website/src/sections/faq/FaqBackdrop.tsx
index b2fc7b37a23..a0c6593148e 100644
--- a/packages/twenty-website/src/sections/faq/FaqBackdrop.tsx
+++ b/packages/twenty-website/src/sections/faq/FaqBackdrop.tsx
@@ -9,7 +9,6 @@ import { mediaUp } from '@/tokens';
import { FAQ_BACKDROP } from './faq-backdrop-config';
-// The authored shell: clipped to the section's right edge, faded, lifted.
const BackdropShell = styled.div`
bottom: 0;
display: block;
diff --git a/packages/twenty-website/src/sections/faq/FaqItems.tsx b/packages/twenty-website/src/sections/faq/FaqItems.tsx
index 75046f81728..f5099981dd5 100644
--- a/packages/twenty-website/src/sections/faq/FaqItems.tsx
+++ b/packages/twenty-website/src/sections/faq/FaqItems.tsx
@@ -40,8 +40,6 @@ const QuestionText = styled.span`
transition: color ${DURATION.md} ${EASING.smooth};
`;
-// The question marker is two stacked rectangle states (outline resting,
-// filled when hovered/open) — CSS, not SVG assets.
const MarkerLayer = styled.span`
border-radius: 1px;
display: block;
diff --git a/packages/twenty-website/src/sections/feature-cards/FeatureCard.tsx b/packages/twenty-website/src/sections/feature-cards/FeatureCard.tsx
index cd6e7e75087..a59452c24a0 100644
--- a/packages/twenty-website/src/sections/feature-cards/FeatureCard.tsx
+++ b/packages/twenty-website/src/sections/feature-cards/FeatureCard.tsx
@@ -40,7 +40,6 @@ const CardImage = styled.div`
width: 100%;
`;
-// The scene design box every feature-card visual is authored in.
const SCENE_DESIGN_WIDTH_PX = 411;
const SCENE_DESIGN_HEIGHT_PX = 508;
diff --git a/packages/twenty-website/src/sections/feature-cards/familiar-interface/GrabCursorIcon.tsx b/packages/twenty-website/src/sections/feature-cards/familiar-interface/GrabCursorIcon.tsx
index a955a576775..3db441bbd69 100644
--- a/packages/twenty-website/src/sections/feature-cards/familiar-interface/GrabCursorIcon.tsx
+++ b/packages/twenty-website/src/sections/feature-cards/familiar-interface/GrabCursorIcon.tsx
@@ -2,7 +2,6 @@ import { FAMILIAR_INTERFACE_SCENE } from '@/tokens/feature-scenes/familiar-inter
const INK = FAMILIAR_INTERFACE_SCENE.cursorInk;
-// The old site's authored grab-hand artwork, verbatim.
export function GrabCursorIcon({ size = 72 }: { size?: number }) {
return (
<svg
diff --git a/packages/twenty-website/src/sections/feature-cards/fast-path/PreviewCursorIcon.tsx b/packages/twenty-website/src/sections/feature-cards/fast-path/PreviewCursorIcon.tsx
index b3de32ebcd5..df8abbd6a88 100644
--- a/packages/twenty-website/src/sections/feature-cards/fast-path/PreviewCursorIcon.tsx
+++ b/packages/twenty-website/src/sections/feature-cards/fast-path/PreviewCursorIcon.tsx
@@ -2,7 +2,6 @@ import { FAST_PATH_SCENE } from '@/tokens/feature-scenes/fast-path-scene';
const INK = FAST_PATH_SCENE.cursorInk;
-// The palette's resting hand cursor (authored artwork, verbatim).
export function PreviewCursorIcon() {
return (
<svg
diff --git a/packages/twenty-website/src/sections/feature-cards/feature-cards.data.ts b/packages/twenty-website/src/sections/feature-cards/feature-cards.data.ts
index a8a89debce7..bbfd73cf37e 100644
--- a/packages/twenty-website/src/sections/feature-cards/feature-cards.data.ts
+++ b/packages/twenty-website/src/sections/feature-cards/feature-cards.data.ts
@@ -1,9 +1,6 @@
import { type MessageDescriptor } from '@lingui/core';
import { msg } from '@lingui/core/macro';
-// Which animated product scene mounts in the card frame when the mockup
-// wave (with AppPreview) lands; until then the gradient backdrop — the
-// scene's own bottom layer — fills the frame.
export type FeatureIllustrationId =
| 'familiar-interface'
| 'live-data'
diff --git a/packages/twenty-website/src/sections/feature-cards/live-data/TomCursor.tsx b/packages/twenty-website/src/sections/feature-cards/live-data/TomCursor.tsx
index 752221563d7..d41d1c2269c 100644
--- a/packages/twenty-website/src/sections/feature-cards/live-data/TomCursor.tsx
+++ b/packages/twenty-website/src/sections/feature-cards/live-data/TomCursor.tsx
@@ -11,7 +11,6 @@ const TomCursorGlyph = styled.svg`
width: 41px;
`;
-// Tom's wider cursor arrow (authored glyph, verbatim).
export function TomCursor() {
return (
<TomCursorGlyph
diff --git a/packages/twenty-website/src/sections/helped/HelpedCard.tsx b/packages/twenty-website/src/sections/helped/HelpedCard.tsx
index 61c41701ee2..72007725139 100644
--- a/packages/twenty-website/src/sections/helped/HelpedCard.tsx
+++ b/packages/twenty-website/src/sections/helped/HelpedCard.tsx
@@ -81,8 +81,6 @@ const Rule = styled.div`
width: 100%;
`;
-// The halftone model (target/spaceship/money) renders here with the
-// visual-runtime wave.
const VisualShell = styled.div`
background-color: ${color('black')};
border-radius: ${radius(2)};
diff --git a/packages/twenty-website/src/sections/home-hero/HomeHero.tsx b/packages/twenty-website/src/sections/home-hero/HomeHero.tsx
index ef1e8a944e0..39a166b7041 100644
--- a/packages/twenty-website/src/sections/home-hero/HomeHero.tsx
+++ b/packages/twenty-website/src/sections/home-hero/HomeHero.tsx
@@ -43,9 +43,6 @@ const BodyMeasure = styled.div`
max-width: 591px;
`;
-// Reserves the product mockup's footprint ahead of the DOM landing — CLS
-// settles in this commit, and the frame's opaque surface already hides
-// the bridge center exactly as the old window does.
/* The app window is LIFE-SIZE at every viewport (measured on old at five
widths: fixed 1040x676, centered when it fits, anchored 16px left and
bleeding off the right edge when it does not — the Linear-class
diff --git a/packages/twenty-website/src/sections/pricing-salesfarce/PricingSalesfarce.tsx b/packages/twenty-website/src/sections/pricing-salesfarce/PricingSalesfarce.tsx
index 0a4a2e924be..0ec746d8cd2 100644
--- a/packages/twenty-website/src/sections/pricing-salesfarce/PricingSalesfarce.tsx
+++ b/packages/twenty-website/src/sections/pricing-salesfarce/PricingSalesfarce.tsx
@@ -28,8 +28,6 @@ const COMPARE_LINKS = [
label: msg`Twenty vs Microsoft Dynamics`,
href: '/compare-pricing/microsoft-dynamics',
},
- // Attio comparison parked, may return:
- // { label: msg`Twenty vs Attio`, href: '/compare-pricing/attio' },
];
const Grid = styled.div`
diff --git a/packages/twenty-website/src/sections/product-hero/HeroVisualScroll.tsx b/packages/twenty-website/src/sections/product-hero/HeroVisualScroll.tsx
index f3c06efc8a7..22186e256d5 100644
--- a/packages/twenty-website/src/sections/product-hero/HeroVisualScroll.tsx
+++ b/packages/twenty-website/src/sections/product-hero/HeroVisualScroll.tsx
@@ -176,7 +176,6 @@ const FullLayer = styled.div`
color: ${color('black')};
}
- /* The dark layer wipes up from the bottom as the morph plays. */
&[data-face='dark'] {
${buildSchemeDeclarations('dark')}
background-color: ${PRODUCT_HERO_SCENE.darkSurface};
@@ -531,7 +530,6 @@ export function HeroVisualScroll({
};
}, [menuWriter]);
- // Returning to the top rewinds the demo to the first scene.
useEffect(() => {
if (discrete.heroAtStart) {
setActiveTab(0);
diff --git a/packages/twenty-website/src/sections/releases-feed/ReleasesFeed.tsx b/packages/twenty-website/src/sections/releases-feed/ReleasesFeed.tsx
index d766ca0c263..720cc48bb7c 100644
--- a/packages/twenty-website/src/sections/releases-feed/ReleasesFeed.tsx
+++ b/packages/twenty-website/src/sections/releases-feed/ReleasesFeed.tsx
@@ -24,8 +24,6 @@ const ReadingColumn = styled.div`
width: 100%;
`;
-// Stacked on phones (date above content); a fixed meta rail beside the content
-// from md up.
const ReleaseRow = styled.article`
display: grid;
grid-template-columns: minmax(0, 1fr);
diff --git a/packages/twenty-website/src/sections/testimonials/PartnerTestimonialsCarousel.tsx b/packages/twenty-website/src/sections/testimonials/PartnerTestimonialsCarousel.tsx
index 4200a4e832d..894aef31b5f 100644
--- a/packages/twenty-website/src/sections/testimonials/PartnerTestimonialsCarousel.tsx
+++ b/packages/twenty-website/src/sections/testimonials/PartnerTestimonialsCarousel.tsx
@@ -38,7 +38,6 @@ const CarouselGrid = styled.div`
}
`;
-// Portrait and meta sit at the top of the column, the counter at the bottom.
const LeftColumn = styled.div`
display: grid;
row-gap: ${spacing(6)};
@@ -95,7 +94,6 @@ const CounterText = styled.p`
`;
const SeparatorSlot = styled.div`
- /* The section draws its divider at the strong tier. */
--marked-divider-line: ${semanticColor.lineStrong};
width: 100%;
diff --git a/packages/twenty-website/src/sections/three-cards/IllustrationCard.tsx b/packages/twenty-website/src/sections/three-cards/IllustrationCard.tsx
index 092fa331a51..a2225c8f563 100644
--- a/packages/twenty-website/src/sections/three-cards/IllustrationCard.tsx
+++ b/packages/twenty-website/src/sections/three-cards/IllustrationCard.tsx
@@ -53,8 +53,6 @@ const CardRule = styled.div`
width: 100%;
`;
-// The visual stage: the halftone illustration (diamond/flash/lock) renders
-// here when the visual-runtime port lands.
const CardStage = styled.div`
background-color: ${color('white')};
border-radius: ${radius(2)};
diff --git a/packages/twenty-website/src/sections/three-cards/card-reveal-frame.ts b/packages/twenty-website/src/sections/three-cards/card-reveal-frame.ts
index 65e2cd48cf5..27dd3f8ae06 100644
--- a/packages/twenty-website/src/sections/three-cards/card-reveal-frame.ts
+++ b/packages/twenty-website/src/sections/three-cards/card-reveal-frame.ts
@@ -18,8 +18,6 @@ const STAGGER = 0.25;
const easeOutQuint = (value: number) => 1 - (1 - value) ** 5;
export const cardReveal = {
- // Progress runs while the grid's top edge travels from the viewport
- // bottom to 20% of the viewport height.
progressForGridTop(gridTopPx: number, viewportHeightPx: number): number {
const startEdge = viewportHeightPx;
const endEdge = viewportHeightPx * END_EDGE_RATIO;
diff --git a/packages/twenty-website/src/sections/three-cards/three-cards.data.ts b/packages/twenty-website/src/sections/three-cards/three-cards.data.ts
index 0c8914c1b4a..1bebe9b5170 100644
--- a/packages/twenty-website/src/sections/three-cards/three-cards.data.ts
+++ b/packages/twenty-website/src/sections/three-cards/three-cards.data.ts
@@ -1,7 +1,6 @@
import { type MessageDescriptor } from '@lingui/core';
import { msg } from '@lingui/core/macro';
-// Identifies which halftone model fills the card's stage.
export type IllustrationId =
| 'diamond'
| 'eye'
diff --git a/packages/twenty-website/src/tokens/easing.ts b/packages/twenty-website/src/tokens/easing.ts
index 1514fb60e8c..5b9b26d5b8d 100644
--- a/packages/twenty-website/src/tokens/easing.ts
+++ b/packages/twenty-website/src/tokens/easing.ts
@@ -1,7 +1,5 @@
// The site's four motion curves. Components never write cubic-bezier values
-// inline. Durations stay local for now: the current values were A/B-matched
-// to the old site per component; collapsing them into buckets is a design
-// decision, not a refactor.
+// inline.
export const EASING: Record<
'standard' | 'smooth' | 'gentle' | 'spring',
string
diff --git a/packages/twenty-website/src/tokens/feature-scenes/live-data-scene.ts b/packages/twenty-website/src/tokens/feature-scenes/live-data-scene.ts
index d8c4e686625..7861cac2a27 100644
--- a/packages/twenty-website/src/tokens/feature-scenes/live-data-scene.ts
+++ b/packages/twenty-website/src/tokens/feature-scenes/live-data-scene.ts
@@ -32,7 +32,7 @@ export const LIVE_DATA_SCENE = {
filterPressedWash: 'rgba(25, 97, 237, 0.08)',
filterHoverWash: 'rgba(25, 97, 237, 0.06)',
cursorShadow: CURSOR_GLYPH_SHADOW,
- // The status tag's edited (purple) state inside the table.
+ // The status tag's resting (green) and edited (purple) states in the table.
tagGreen: '#18794e',
tagGreenSurface: '#ddf3e4',
tagPurple: '#793aaf',
diff --git a/packages/twenty-website/src/tokens/reduced-motion.ts b/packages/twenty-website/src/tokens/reduced-motion.ts
index 4edeab4fba8..6b7f96ae73b 100644
--- a/packages/twenty-website/src/tokens/reduced-motion.ts
+++ b/packages/twenty-website/src/tokens/reduced-motion.ts
@@ -1,3 +1,3 @@
-// The single source of the reduced-motion at-rule (five components carry
+// The single source of the reduced-motion at-rule (components carry
// bespoke disable blocks whose bodies legitimately differ).
export const REDUCED_MOTION: string = '@media (prefers-reduced-motion: reduce)';
diff --git a/packages/twenty-website/src/ui/Container.tsx b/packages/twenty-website/src/ui/Container.tsx
index bccd9d5b9cc..9761f6386c6 100644
--- a/packages/twenty-website/src/ui/Container.tsx
+++ b/packages/twenty-website/src/ui/Container.tsx
@@ -2,11 +2,9 @@ import { styled } from '@linaria/react';
import { GUTTER, MAX_CONTENT_WIDTH_PX, mediaUp, spacing } from '@/tokens';
-// Owns the page's horizontal gutter and max content width. SectionShell is
-// the standard consumer; page chrome (menu, footer) composes it directly.
-
-// Owns the page's horizontal frame: max content width plus the only
-// horizontal gutter on the site. Sections never set their own.
+// The only horizontal gutter on the site: sections never set their own.
+// SectionShell is the standard consumer; page chrome (menu, footer)
+// composes it directly.
export const Container = styled.div`
margin-inline: auto;
max-width: ${MAX_CONTENT_WIDTH_PX}px;
diff --git a/packages/twenty-website/src/ui/ExternalArrow.tsx b/packages/twenty-website/src/ui/ExternalArrow.tsx
index 87a95003337..2830e2cbb01 100644
--- a/packages/twenty-website/src/ui/ExternalArrow.tsx
+++ b/packages/twenty-website/src/ui/ExternalArrow.tsx
@@ -8,7 +8,6 @@ const ArrowSlot = styled.span`
display: inline-flex;
`;
-// The blue outbound arrow that marks external destinations.
export function ExternalArrow() {
return (
<ArrowSlot aria-hidden>