Skip to content

The open alternative to Salesforce, designed for AI.

[Onboarding 5/10] Fit credits pill on phones (#26872)

Thomas des Francs29edc093fce1
diff --git a/packages/twenty-front/src/modules/onboarding/components/OnboardingHeader.tsx b/packages/twenty-front/src/modules/onboarding/components/OnboardingHeader.tsx
index 51ab68b710f..ebb08293fbc 100644
--- a/packages/twenty-front/src/modules/onboarding/components/OnboardingHeader.tsx
+++ b/packages/twenty-front/src/modules/onboarding/components/OnboardingHeader.tsx
@@ -33,6 +33,7 @@ const StyledLeftSide = styled(StyledSide)`
padding-right: ${themeCssVariables.spacing[1]};
@media (max-width: ${MOBILE_VIEWPORT}px) {
+ flex: 0 0 auto;
justify-content: flex-start;
}
`;
diff --git a/packages/twenty-front/src/modules/onboarding/components/free-credits/OnboardingFreeCreditsProgress.tsx b/packages/twenty-front/src/modules/onboarding/components/free-credits/OnboardingFreeCreditsProgress.tsx
index f7d41c6f06d..030183b3e9a 100644
--- a/packages/twenty-front/src/modules/onboarding/components/free-credits/OnboardingFreeCreditsProgress.tsx
+++ b/packages/twenty-front/src/modules/onboarding/components/free-credits/OnboardingFreeCreditsProgress.tsx
@@ -5,8 +5,10 @@ import { StyledOnboardingFreeCreditsText } from '@/onboarding/components/free-cr
import { styled } from '@linaria/react';
import { plural } from '@lingui/core/macro';
import { useLingui } from '@lingui/react/macro';
+import { VisibilityHidden } from 'twenty-ui/primitives/accessibility';
import { ProgressBar } from 'twenty-ui/primitives/feedback';
import { themeCssVariables } from 'twenty-ui/theme';
+import { useIsMobile } from 'twenty-ui/utilities';
const StyledProgressBarContainer = styled.div`
flex-shrink: 0;
@@ -31,8 +33,13 @@ export const OnboardingFreeCreditsProgress = ({
onTrackGrown,
}: OnboardingFreeCreditsProgressProps) => {
const { t } = useLingui();
+ const isMobile = useIsMobile();
const displayedCredits = hasTrackGrown ? earnedCredits : seenCredits;
+ const goalCreditsLabel = plural(goalCredits, {
+ one: 'free credit',
+ other: 'free credits',
+ });
return (
<>
@@ -57,12 +64,13 @@ export const OnboardingFreeCreditsProgress = ({
/
<OnboardingFreeCreditsAnimatedCount credits={goalCredits} />
</StyledOnboardingFreeCreditsCount>
- <StyledOnboardingFreeCreditsLabel>
- {plural(goalCredits, {
- one: 'free credit',
- other: 'free credits',
- })}
- </StyledOnboardingFreeCreditsLabel>
+ {isMobile ? (
+ <VisibilityHidden>{goalCreditsLabel}</VisibilityHidden>
+ ) : (
+ <StyledOnboardingFreeCreditsLabel>
+ {goalCreditsLabel}
+ </StyledOnboardingFreeCreditsLabel>
+ )}
</StyledOnboardingFreeCreditsText>
</>
);
diff --git a/packages/twenty-front/src/modules/onboarding/components/free-credits/__stories__/OnboardingHeaderFreeCredits.stories.tsx b/packages/twenty-front/src/modules/onboarding/components/free-credits/__stories__/OnboardingHeaderFreeCredits.stories.tsx
index 4118a155b40..950164b64e4 100644
--- a/packages/twenty-front/src/modules/onboarding/components/free-credits/__stories__/OnboardingHeaderFreeCredits.stories.tsx
+++ b/packages/twenty-front/src/modules/onboarding/components/free-credits/__stories__/OnboardingHeaderFreeCredits.stories.tsx
@@ -1,6 +1,10 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { expect, userEvent, waitFor, within } from 'storybook/test';
-import { ComponentDecorator } from 'twenty-ui/testing';
+import {
+ ComponentDecorator,
+ overrideMediaQueryMatches,
+} from 'twenty-ui/testing';
+import { MOBILE_MEDIA_QUERY } from 'twenty-ui/utilities';
import { currentUserState } from '@/auth/states/currentUserState';
import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
@@ -131,6 +135,35 @@ export const EarnedSoFar: Story = {
},
};
+export const EarnedSoFarOnPhone: Story = {
+ beforeEach: () => {
+ seedOnboardingFreeCredits({
+ onboardingStatus: OnboardingStatus.APPS_INSTALLATION,
+ onboardingFreeCredits: { importContacts: 1, seenCredits: 1 },
+ });
+
+ return overrideMediaQueryMatches({ [MOBILE_MEDIA_QUERY]: true });
+ },
+ parameters: {
+ viewport: {
+ defaultViewport: 'mobile1',
+ },
+ },
+ play: async ({ canvasElement }) => {
+ const pill = await within(canvasElement).findByRole('button', {
+ name: /free credit/,
+ });
+ const freeCreditsLabel = within(pill).getByText('free credit');
+
+ await expect(
+ freeCreditsLabel.getBoundingClientRect().width,
+ ).toBeLessThanOrEqual(1);
+ await expect(
+ freeCreditsLabel.getBoundingClientRect().height,
+ ).toBeLessThanOrEqual(1);
+ },
+};
+
export const NewlyEarned: Story = {
beforeEach: () => {
seedOnboardingFreeCredits({