Skip to content

The open alternative to Salesforce, designed for AI.

Put the record creation form back behind a feature flag (#26472)

Thomas Trompette2ae0934aac65
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
index 29bd3209e17..d31cec441e2 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
@@ -2029,6 +2029,7 @@ enum FeatureFlagKey {
IS_WEBHOOK_RATE_LIMIT_ENABLED
IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED
IS_EXECUTION_QUOTA_ENABLED
+ IS_RECORD_CREATION_FORM_ENABLED
}
type WorkspaceUrls {
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.ts b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
index 46655f18619..c269f74835e 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.ts
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
@@ -1632,7 +1632,7 @@ export interface FeatureFlag {
__typename: 'FeatureFlag'
}
-export type FeatureFlagKey = 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_UNIQUE_INDEXES_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_JUNCTION_RELATIONS_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT' | 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED' | 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED' | 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED' | 'IS_RECORD_SHARING_ENABLED' | 'IS_INITIAL_OBJECT_VIEW_ENABLED' | 'IS_WEBHOOK_RATE_LIMIT_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_EXECUTION_QUOTA_ENABLED'
+export type FeatureFlagKey = 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_UNIQUE_INDEXES_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_JUNCTION_RELATIONS_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT' | 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED' | 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED' | 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED' | 'IS_RECORD_SHARING_ENABLED' | 'IS_INITIAL_OBJECT_VIEW_ENABLED' | 'IS_WEBHOOK_RATE_LIMIT_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_EXECUTION_QUOTA_ENABLED' | 'IS_RECORD_CREATION_FORM_ENABLED'
export interface WorkspaceUrls {
customUrl?: Scalars['String']
@@ -11026,7 +11026,8 @@ export const enumFeatureFlagKey = {
IS_INITIAL_OBJECT_VIEW_ENABLED: 'IS_INITIAL_OBJECT_VIEW_ENABLED' as const,
IS_WEBHOOK_RATE_LIMIT_ENABLED: 'IS_WEBHOOK_RATE_LIMIT_ENABLED' as const,
IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED: 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' as const,
- IS_EXECUTION_QUOTA_ENABLED: 'IS_EXECUTION_QUOTA_ENABLED' as const
+ IS_EXECUTION_QUOTA_ENABLED: 'IS_EXECUTION_QUOTA_ENABLED' as const,
+ IS_RECORD_CREATION_FORM_ENABLED: 'IS_RECORD_CREATION_FORM_ENABLED' as const
}
export const enumIdentityProviderType = {
diff --git a/packages/twenty-front/src/generated-admin/graphql.ts b/packages/twenty-front/src/generated-admin/graphql.ts
index 122b6c65fc2..693efbb3166 100644
--- a/packages/twenty-front/src/generated-admin/graphql.ts
+++ b/packages/twenty-front/src/generated-admin/graphql.ts
@@ -434,6 +434,7 @@ export enum FeatureFlagKey {
IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED = 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED',
IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED = 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED',
IS_MESSAGE_CAMPAIGN_ENABLED = 'IS_MESSAGE_CAMPAIGN_ENABLED',
+ IS_RECORD_CREATION_FORM_ENABLED = 'IS_RECORD_CREATION_FORM_ENABLED',
IS_RECORD_SHARING_ENABLED = 'IS_RECORD_SHARING_ENABLED',
IS_REST_METADATA_API_NEW_FORMAT_DIRECT = 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT',
IS_UNIQUE_INDEXES_ENABLED = 'IS_UNIQUE_INDEXES_ENABLED',
diff --git a/packages/twenty-front/src/generated-metadata/graphql.ts b/packages/twenty-front/src/generated-metadata/graphql.ts
index 7f0209dbc98..bc379900c9d 100644
--- a/packages/twenty-front/src/generated-metadata/graphql.ts
+++ b/packages/twenty-front/src/generated-metadata/graphql.ts
@@ -2116,6 +2116,7 @@ export enum FeatureFlagKey {
IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED = 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED',
IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED = 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED',
IS_MESSAGE_CAMPAIGN_ENABLED = 'IS_MESSAGE_CAMPAIGN_ENABLED',
+ IS_RECORD_CREATION_FORM_ENABLED = 'IS_RECORD_CREATION_FORM_ENABLED',
IS_RECORD_SHARING_ENABLED = 'IS_RECORD_SHARING_ENABLED',
IS_REST_METADATA_API_NEW_FORMAT_DIRECT = 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT',
IS_UNIQUE_INDEXES_ENABLED = 'IS_UNIQUE_INDEXES_ENABLED',
diff --git a/packages/twenty-front/src/modules/command-menu-item/hooks/useGlobalRecordCreationCommandMenuItems.ts b/packages/twenty-front/src/modules/command-menu-item/hooks/useGlobalRecordCreationCommandMenuItems.ts
index 6b5ed20d08e..9651dfb7cd8 100644
--- a/packages/twenty-front/src/modules/command-menu-item/hooks/useGlobalRecordCreationCommandMenuItems.ts
+++ b/packages/twenty-front/src/modules/command-menu-item/hooks/useGlobalRecordCreationCommandMenuItems.ts
@@ -2,10 +2,14 @@ import { buildGlobalRecordCreationCommandMenuItems } from '@/command-menu-item/u
import { type CommandMenuItemDefinition } from '@/command-menu-item/types/CommandMenuItemDefinition';
import { useFilteredObjectMetadataItems } from '@/object-metadata/hooks/useFilteredObjectMetadataItems';
import { useObjectPermissions } from '@/object-record/hooks/useObjectPermissions';
+import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
import { useLingui } from '@lingui/react/macro';
import { useMemo } from 'react';
import { isDefined } from 'twenty-shared/utils';
-import { EngineComponentKey } from '~/generated-metadata/graphql';
+import {
+ EngineComponentKey,
+ FeatureFlagKey,
+} from '~/generated-metadata/graphql';
export const useGlobalRecordCreationCommandMenuItems = (
commandMenuItems: CommandMenuItemDefinition[],
@@ -13,15 +17,19 @@ export const useGlobalRecordCreationCommandMenuItems = (
const { t } = useLingui();
const { activeObjectMetadataItems } = useFilteredObjectMetadataItems();
const { objectPermissionsByObjectMetadataId } = useObjectPermissions();
+ const isRecordCreationFormEnabled = useIsFeatureEnabled(
+ FeatureFlagKey.IS_RECORD_CREATION_FORM_ENABLED,
+ );
const createRecordCommand = commandMenuItems.find(
(item) =>
item.engineComponentKey === EngineComponentKey.CREATE_NEW_RECORD &&
!isDefined(item.availabilityObjectMetadataId),
);
- const hasGlobalRecordCreationCommandTemplate = isDefined(createRecordCommand);
+ const hasGlobalRecordCreationCommandTemplate =
+ isRecordCreationFormEnabled && isDefined(createRecordCommand);
const globalRecordCreationCommandMenuItems = useMemo(() => {
- if (!isDefined(createRecordCommand)) {
+ if (!isRecordCreationFormEnabled || !isDefined(createRecordCommand)) {
return [];
}
@@ -32,6 +40,7 @@ export const useGlobalRecordCreationCommandMenuItems = (
getLabel: (objectLabelSingular) => t`Create ${objectLabelSingular}`,
});
}, [
+ isRecordCreationFormEnabled,
createRecordCommand,
activeObjectMetadataItems,
objectPermissionsByObjectMetadataId,
diff --git a/packages/twenty-front/src/modules/object-record/hooks/useCreateNewRecord.ts b/packages/twenty-front/src/modules/object-record/hooks/useCreateNewRecord.ts
index 34c605a0362..ee5c9761096 100644
--- a/packages/twenty-front/src/modules/object-record/hooks/useCreateNewRecord.ts
+++ b/packages/twenty-front/src/modules/object-record/hooks/useCreateNewRecord.ts
@@ -46,9 +46,10 @@ export const useCreateNewRecord = ({
const { upsertRecordsInStore } = useUpsertRecordsInStore();
- const { requestRecordCreation } = useRecordCreationForm({
- objectMetadataItem,
- });
+ const { isRecordCreationFormEnabled, requestRecordCreation } =
+ useRecordCreationForm({
+ objectMetadataItem,
+ });
const navigate = useNavigateApp();
@@ -83,17 +84,19 @@ export const useCreateNewRecord = ({
async (recordInput?: Partial<ObjectRecord>) => {
let submittedRecordInput = recordInput;
- const createdRecord = await requestRecordCreation({
- initialDraftRecord: {
- ...buildRecordInputFromRLSPredicates(),
- ...buildRecordInput?.(),
- ...recordInput,
- },
- createRecord: (draftRecord) => {
- submittedRecordInput = { ...recordInput, ...draftRecord };
- return createRecord(submittedRecordInput);
- },
- });
+ const createdRecord = isRecordCreationFormEnabled
+ ? await requestRecordCreation({
+ initialDraftRecord: {
+ ...buildRecordInputFromRLSPredicates(),
+ ...buildRecordInput?.(),
+ ...recordInput,
+ },
+ createRecord: (draftRecord) => {
+ submittedRecordInput = { ...recordInput, ...draftRecord };
+ return createRecord(submittedRecordInput);
+ },
+ })
+ : await createRecord(recordInput);
if (!isDefined(createdRecord)) {
return;
@@ -162,6 +165,7 @@ export const useCreateNewRecord = ({
openRecordIn,
closeSidePanelMenu,
workspaceSurface.type,
+ isRecordCreationFormEnabled,
requestRecordCreation,
onRecordCreated,
upsertRecordsInStore,
diff --git a/packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordCreationForm.ts b/packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordCreationForm.ts
index a8576c3cf0d..e385d994349 100644
--- a/packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordCreationForm.ts
+++ b/packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordCreationForm.ts
@@ -1,7 +1,9 @@
import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';
import { useRecordCreationFormContextOrThrow } from '@/object-record/record-form/contexts/RecordCreationFormContext';
import { type ObjectRecord } from '@/object-record/types/ObjectRecord';
+import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
import { useCallback } from 'react';
+import { FeatureFlagKey } from '~/generated-metadata/graphql';
export const useRecordCreationForm = ({
objectMetadataItem,
@@ -11,6 +13,10 @@ export const useRecordCreationForm = ({
const { requestRecordCreation: requestRecordCreationInContext } =
useRecordCreationFormContextOrThrow();
+ const isRecordCreationFormEnabled = useIsFeatureEnabled(
+ FeatureFlagKey.IS_RECORD_CREATION_FORM_ENABLED,
+ );
+
const requestRecordCreation = useCallback(
({
initialDraftRecord,
@@ -29,5 +35,5 @@ export const useRecordCreationForm = ({
[requestRecordCreationInContext, objectMetadataItem],
);
- return { requestRecordCreation };
+ return { isRecordCreationFormEnabled, requestRecordCreation };
};
diff --git a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts
index 449b1ca3ef1..3ca4a49b339 100644
--- a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts
+++ b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts
@@ -62,4 +62,8 @@ export const SETTINGS_ADMIN_FEATURE_FLAG_METADATA: Partial<
label: msg`Execution quotas`,
description: msg`Enforce usage quotas on workflow node runs and logic function executions.`,
},
+ [FeatureFlagKey.IS_RECORD_CREATION_FORM_ENABLED]: {
+ label: msg`Record creation form`,
+ description: msg`Use a dedicated form when creating records.`,
+ },
};
diff --git a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__stories__/RecordCreationFlow.stories.tsx b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__stories__/RecordCreationFlow.stories.tsx
index 70e69cc10b5..edcdde25ed9 100644
--- a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__stories__/RecordCreationFlow.stories.tsx
+++ b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__stories__/RecordCreationFlow.stories.tsx
@@ -45,6 +45,7 @@ import { ComponentDecorator, RouterDecorator } from 'twenty-ui/testing';
import { getOsControlSymbol } from 'twenty-ui/utilities';
import {
EngineComponentKey,
+ FeatureFlagKey,
PageLayoutTabLayoutMode,
PageLayoutType,
WidgetConfigurationType,
@@ -153,7 +154,15 @@ const RecordCreationFlow = ({ commandOrigin }: RecordCreationFlowProps) => {
);
}
applyChanges();
- store.set(currentWorkspaceState.atom, mockCurrentWorkspace);
+ store.set(currentWorkspaceState.atom, {
+ ...mockCurrentWorkspace,
+ featureFlags: [
+ {
+ key: FeatureFlagKey.IS_RECORD_CREATION_FORM_ENABLED,
+ value: true,
+ },
+ ],
+ });
store.set(currentWorkspaceMemberState.atom, (member) =>
isDefined(member)
? { ...member, openRecordIn: OpenRecordIn.SIDE_PANEL }
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts
index e48e42f739d..2e84faf6131 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts
@@ -11,6 +11,7 @@ const DEFAULT_SEEDED_FEATURE_FLAGS: Partial<Record<FeatureFlagKey, boolean>> = {
[FeatureFlagKey.IS_RECORD_SHARING_ENABLED]: false,
[FeatureFlagKey.IS_INITIAL_OBJECT_VIEW_ENABLED]: false,
[FeatureFlagKey.IS_EXECUTION_QUOTA_ENABLED]: true,
+ [FeatureFlagKey.IS_RECORD_CREATION_FORM_ENABLED]: true,
};
type SeedFeatureFlagsArgs = {
diff --git a/packages/twenty-shared/src/types/FeatureFlagKey.ts b/packages/twenty-shared/src/types/FeatureFlagKey.ts
index 0e70d399aca..0dba761b25e 100644
--- a/packages/twenty-shared/src/types/FeatureFlagKey.ts
+++ b/packages/twenty-shared/src/types/FeatureFlagKey.ts
@@ -14,4 +14,5 @@ export enum FeatureFlagKey {
IS_WEBHOOK_RATE_LIMIT_ENABLED = 'IS_WEBHOOK_RATE_LIMIT_ENABLED',
IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED = 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED',
IS_EXECUTION_QUOTA_ENABLED = 'IS_EXECUTION_QUOTA_ENABLED',
+ IS_RECORD_CREATION_FORM_ENABLED = 'IS_RECORD_CREATION_FORM_ENABLED',
}