The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Default application autoUpgrade to true for vetted applications (#29031)
martmull2f1252c71504
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-53/2-53-instance-command-slow-1793170402367-backfill-application-auto-upgrade.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-53/2-53-instance-command-slow-1793170402367-backfill-application-auto-upgrade.tsnew file mode 100644index 00000000000..33ef6be3790--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-53/2-53-instance-command-slow-1793170402367-backfill-application-auto-upgrade.ts@@ -0,0 +1,27 @@+import { DataSource, QueryRunner } from 'typeorm';++import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';+import { SlowInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/slow-instance-command.interface';++@RegisteredInstanceCommand('2.53.0', 1793170402367, { type: 'slow' })+export class BackfillApplicationAutoUpgradeSlowInstanceCommand implements SlowInstanceCommand {+ async runDataMigration(dataSource: DataSource): Promise<void> {+ await dataSource.query(+ `UPDATE "core"."application" AS application+ SET "autoUpgrade" = true+ FROM "core"."applicationRegistration" AS registration+ WHERE application."applicationRegistrationId" = registration.id+ AND registration."isVetted" = true+ AND application."autoUpgrade" = false`,+ );+ }++ public async up(_queryRunner: QueryRunner): Promise<void> {+ return;+ }++ // Not reverted: opted-out rows cannot be told apart from backfilled ones+ public async down(_queryRunner: QueryRunner): Promise<void> {+ return;+ }+}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/instance-commands.constant.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/instance-commands.constant.tsindex d1006a56fb8..c5bc26f5cd2 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/instance-commands.constant.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/instance-commands.constant.ts@@ -259,6 +259,7 @@ import { AddAgentChatChannelNavigationMenuItemFastInstanceCommand } from 'src/daimport { AddParticipantHandleFieldToMessageChannelFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-52/2-52-instance-command-fast-1792907887530-add-participant-handle-field-to-message-channel';import { AddCustomConfigToConnectionProviderFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-52/2-52-instance-command-fast-1793032438836-add-custom-config-to-connection-provider';import { AddObjectMetadataDisabledObjectPermissionActionsFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-53/2-53-instance-command-fast-1793111477950-add-object-metadata-disabled-object-permission-actions';+import { BackfillApplicationAutoUpgradeSlowInstanceCommand } from 'src/database/commands/upgrade-version-command/2-53/2-53-instance-command-slow-1793170402367-backfill-application-auto-upgrade';import { AddMessagingProviderFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-52/2-52-instance-command-fast-1793032438837-add-messaging-provider';import { AddMcpServerFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-53/2-53-instance-command-fast-1793150000000-add-mcp-server';@@ -524,4 +525,5 @@ export const INSTANCE_COMMANDS = [AddMessagingProviderFastInstanceCommand,AddMcpServerFastInstanceCommand,AddObjectMetadataDisabledObjectPermissionActionsFastInstanceCommand,+ BackfillApplicationAutoUpgradeSlowInstanceCommand,];diff --git a/packages/twenty-server/src/engine/core-modules/application/application-install/__tests__/application-install.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-install/__tests__/application-install.service.spec.tsindex adba918c431..db37ebaeceb 100644--- a/packages/twenty-server/src/engine/core-modules/application/application-install/__tests__/application-install.service.spec.ts+++ b/packages/twenty-server/src/engine/core-modules/application/application-install/__tests__/application-install.service.spec.ts@@ -60,16 +60,12 @@ describe('ApplicationInstallService', () => {const fileStorageService = {writeFile: jest.fn(),};+ const appRegistrationRepository = {+ findOne: jest.fn(),+ };const service = new ApplicationInstallService(- {- findOne: jest.fn().mockResolvedValue({- id: APPLICATION_REGISTRATION_ID,- universalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,- sourceType: ApplicationRegistrationSourceType.NPM,- manifest: null,- }),- } as unknown as Repository<ApplicationRegistrationEntity>,+ appRegistrationRepository as unknown as Repository<ApplicationRegistrationEntity>,applicationService as unknown as ApplicationService,applicationLookupService as unknown as ApplicationLookupService,applicationPackageFetcherService as unknown as ApplicationPackageFetcherService,@@ -129,6 +125,13 @@ describe('ApplicationInstallService', () => {);fileStorageService.writeFile.mockResolvedValue({ id: LOGO_FILE_ID });applicationService.update.mockResolvedValue(undefined);+ appRegistrationRepository.findOne.mockResolvedValue({+ id: APPLICATION_REGISTRATION_ID,+ universalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,+ sourceType: ApplicationRegistrationSourceType.NPM,+ manifest: null,+ isVetted: false,+ });});afterEach(async () => {@@ -199,4 +202,35 @@ describe('ApplicationInstallService', () => {expect.objectContaining({ logo: LOGO_PATH }),);});++ it.each([+ { isVetted: true, autoUpgrade: true },+ { isVetted: false, autoUpgrade: false },+ ])(+ 'creates the application with auto upgrade $autoUpgrade when the registration vetting is $isVetted',+ async ({ isVetted, autoUpgrade }) => {+ appRegistrationRepository.findOne.mockResolvedValue({+ id: APPLICATION_REGISTRATION_ID,+ universalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,+ sourceType: ApplicationRegistrationSourceType.NPM,+ manifest: null,+ isVetted,+ });+ applicationLookupService.findByUniversalIdentifier.mockResolvedValue(+ null,+ );+ applicationService.create.mockResolvedValue({+ id: APPLICATION_ID,+ logo: null,+ logoFileId: null,+ version: null,+ });++ await install();++ expect(applicationService.create).toHaveBeenCalledWith(+ expect.objectContaining({ autoUpgrade }),+ );+ },+ );});diff --git a/packages/twenty-server/src/engine/core-modules/application/application-install/application-install.service.ts b/packages/twenty-server/src/engine/core-modules/application/application-install/application-install.service.tsindex de91700d435..214e11934f3 100644--- a/packages/twenty-server/src/engine/core-modules/application/application-install/application-install.service.ts+++ b/packages/twenty-server/src/engine/core-modules/application/application-install/application-install.service.ts@@ -415,6 +415,7 @@ export class ApplicationInstallService {workspaceId: params.workspaceId,applicationRegistrationId: appRegistration.id,sourceType: appRegistration.sourceType,+ autoUpgrade: appRegistration.isVetted,});await progressReporter.reportStepCompleted('CREATE_APPLICATION');@@ -952,6 +953,7 @@ export class ApplicationInstallService {workspaceId,applicationRegistrationId,sourceType,+ autoUpgrade,}: {existingApplication: ApplicationEntity | null;universalIdentifier: string;@@ -960,6 +962,7 @@ export class ApplicationInstallService {workspaceId: string;applicationRegistrationId: string;sourceType: ApplicationRegistrationSourceType;+ autoUpgrade: boolean;}): Promise<ApplicationEntity> {if (isDefined(existingApplication)) {return existingApplication;@@ -972,6 +975,7 @@ export class ApplicationInstallService {sourcePath: universalIdentifier,sourceType,applicationRegistrationId,+ autoUpgrade,workspaceId,});}