The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix(ux): input error messages no longer overlap adjacent fields in forms (#21886)
Emmanuel Hernández Bazán33d2441a936f
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormAdvancedTextFieldInput.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormAdvancedTextFieldInput.tsxindex ac486438bc2..e2afaf6f184 100644--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormAdvancedTextFieldInput.tsx+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormAdvancedTextFieldInput.tsx@@ -5,7 +5,6 @@ import {} from '@/advanced-text-editor/hooks/useAdvancedTextEditor';import { FormFieldInputContainer } from '@/object-record/record-field/ui/form-types/components/FormFieldInputContainer';import { type VariablePickerComponent } from '@/object-record/record-field/ui/form-types/types/VariablePickerComponent';-import { InputErrorHelper } from '@/ui/input/components/InputErrorHelper';import { InputHint } from '@/ui/input/components/InputHint';import { InputLabel } from '@/ui/input/components/InputLabel';import { useFullScreenModal } from '@/ui/layout/fullscreen/hooks/useFullScreenModal';@@ -243,7 +242,7 @@ export const FormAdvancedTextFieldInput = ({</StyledAdvancedTextFieldInnerContainer></StyledAdvancedTextFieldFieldContainer>{hint && <InputHint>{hint}</InputHint>}- {error && <InputErrorHelper>{error}</InputErrorHelper>}+ {error && <InputHint danger>{error}</InputHint>}</FormFieldInputContainer></StyledAdvancedTextFieldContainerWrapper>diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormFilesFieldInput.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormFilesFieldInput.tsxindex c3ca9dd110b..9910380d59a 100644--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormFilesFieldInput.tsx+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormFilesFieldInput.tsx@@ -4,7 +4,7 @@ import { FormFieldInputRowContainer } from '@/object-record/record-field/ui/formimport { TextVariableEditor } from '@/object-record/record-field/ui/form-types/components/TextVariableEditor';import { useTextVariableEditor } from '@/object-record/record-field/ui/form-types/hooks/useTextVariableEditor';import { type VariablePickerComponent } from '@/object-record/record-field/ui/form-types/types/VariablePickerComponent';-import { InputErrorHelper } from '@/ui/input/components/InputErrorHelper';+import { InputHint } from '@/ui/input/components/InputHint';import { InputLabel } from '@/ui/input/components/InputLabel';import { t } from '@lingui/core/macro';import { useId } from 'react';@@ -95,7 +95,7 @@ export const FormFilesFieldInput = ({/>)}</FormFieldInputRowContainer>- <InputErrorHelper>{error}</InputErrorHelper>+ {error && <InputHint danger>{error}</InputHint>}</FormFieldInputContainer>);};diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormRawJsonFieldInput.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormRawJsonFieldInput.tsxindex 41f46b95d34..68ba71af116 100644--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormRawJsonFieldInput.tsx+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormRawJsonFieldInput.tsx@@ -5,7 +5,7 @@ import { FormFieldInputRowContainer } from '@/object-record/record-field/ui/formimport { TextVariableEditor } from '@/object-record/record-field/ui/form-types/components/TextVariableEditor';import { useTextVariableEditor } from '@/object-record/record-field/ui/form-types/hooks/useTextVariableEditor';import { type VariablePickerComponent } from '@/object-record/record-field/ui/form-types/types/VariablePickerComponent';-import { InputErrorHelper } from '@/ui/input/components/InputErrorHelper';+import { InputHint } from '@/ui/input/components/InputHint';import { InputLabel } from '@/ui/input/components/InputLabel';import { useId } from 'react';import { isDefined } from 'twenty-shared/utils';@@ -90,7 +90,7 @@ export const FormRawJsonFieldInput = ({/>)}</FormFieldInputRowContainer>- <InputErrorHelper>{error}</InputErrorHelper>+ {error && <InputHint danger>{error}</InputHint>}</FormFieldInputContainer>);};diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsxindex a3c46f337a9..4ee0de171a6 100644--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsx+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsx@@ -17,6 +17,36 @@ export default meta;type Story = StoryObj<typeof FormRawJsonFieldInput>;+export const WithError: Story = {+ args: {+ label: 'Body',+ placeholder: 'Enter valid json',+ error:+ 'Use only letters, numbers, underscores, dots or hyphens (max 64 characters).',+ onChange: fn(),+ },+ render: (args) => (+ <div style={{ width: 240 }}>+ <FormRawJsonFieldInput {...args} />+ <FormRawJsonFieldInput+ label="Headers"+ placeholder="Enter valid json"+ defaultValue={null}+ onChange={fn()}+ />+ </div>+ ),+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);++ const error = await canvas.findByText(+ 'Use only letters, numbers, underscores, dots or hyphens (max 64 characters).',+ );++ expect(error).toBeVisible();+ },+};+export const Default: Story = {args: {label: 'JSON field',