The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Hide record write commands on objects not writable from user sessions (#28641)
martmull34f7ea66639b
diff --git a/packages/twenty-front/src/modules/command-menu-item/hooks/useCurrentCommandMenuContextApi.ts b/packages/twenty-front/src/modules/command-menu-item/hooks/useCurrentCommandMenuContextApi.tsindex bd10183668d..db24cf3bb64 100644--- a/packages/twenty-front/src/modules/command-menu-item/hooks/useCurrentCommandMenuContextApi.ts+++ b/packages/twenty-front/src/modules/command-menu-item/hooks/useCurrentCommandMenuContextApi.ts@@ -15,6 +15,7 @@ import { useNavigationMenuItemsData } from '@/navigation-menu-item/display/hooksimport { useObjectMetadataItems } from '@/object-metadata/hooks/useObjectMetadataItems';import { useObjectPermissionsForObject } from '@/object-record/hooks/useObjectPermissionsForObject';import { isLayoutCustomizationModeEnabledState } from '@/layout-customization/states/isLayoutCustomizationModeEnabledState';+import { restrictObjectPermissionsToMetadataWritability } from '@/object-record/read-only/utils/restrictObjectPermissionsToMetadataWritability';import { hasAnySoftDeleteFilterOnViewComponentSelector } from '@/object-record/record-filter/states/hasAnySoftDeleteFilterOnView';import { recordPermissionsByRecordIdFamilySelector } from '@/object-record/record-sharing/states/recordPermissionsByRecordIdFamilySelector';import { type ObjectRecord } from '@/object-record/types/ObjectRecord';@@ -129,7 +130,10 @@ export const useCurrentCommandMenuContextApi = (): CommandMenuContextApi => {objectMetadataItem?.id ?? '',);const objectPermissions = isDefined(objectMetadataItem)- ? currentObjectPermissions+ ? restrictObjectPermissionsToMetadataWritability({+ objectPermissions: currentObjectPermissions,+ writability: objectMetadataItem.writability,+ }): EMPTY_COMMAND_MENU_CONTEXT_API.objectPermissions;const contextStoreCurrentViewId = useAtomComponentStateValue(diff --git a/packages/twenty-front/src/modules/object-record/read-only/utils/__tests__/restrictObjectPermissionsToMetadataWritability.test.ts b/packages/twenty-front/src/modules/object-record/read-only/utils/__tests__/restrictObjectPermissionsToMetadataWritability.test.tsnew file mode 100644index 00000000000..4838a5ddd6e--- /dev/null+++ b/packages/twenty-front/src/modules/object-record/read-only/utils/__tests__/restrictObjectPermissionsToMetadataWritability.test.ts@@ -0,0 +1,44 @@+import { restrictObjectPermissionsToMetadataWritability } from '@/object-record/read-only/utils/restrictObjectPermissionsToMetadataWritability';+import { type ObjectPermissions } from 'twenty-shared/types';+import { MetadataWritability } from '~/generated-metadata/graphql';++const FULL_OBJECT_PERMISSIONS: ObjectPermissions = {+ canReadObjectRecords: true,+ canUpdateObjectRecords: true,+ canSoftDeleteObjectRecords: true,+ canDestroyObjectRecords: true,+ restrictedFields: {},+ rowLevelPermissionPredicates: [],+ rowLevelPermissionPredicateGroups: [],+};++describe('restrictObjectPermissionsToMetadataWritability', () => {+ it.each([MetadataWritability.OPEN, null, undefined])(+ 'should keep permissions when writability is %s',+ (writability) => {+ expect(+ restrictObjectPermissionsToMetadataWritability({+ objectPermissions: FULL_OBJECT_PERMISSIONS,+ writability,+ }),+ ).toBe(FULL_OBJECT_PERMISSIONS);+ },+ );++ it.each([MetadataWritability.APPLICATION, MetadataWritability.SYSTEM])(+ 'should revoke write permissions when writability is %s',+ (writability) => {+ expect(+ restrictObjectPermissionsToMetadataWritability({+ objectPermissions: FULL_OBJECT_PERMISSIONS,+ writability,+ }),+ ).toEqual({+ ...FULL_OBJECT_PERMISSIONS,+ canUpdateObjectRecords: false,+ canSoftDeleteObjectRecords: false,+ canDestroyObjectRecords: false,+ });+ },+ );+});diff --git a/packages/twenty-front/src/modules/object-record/read-only/utils/restrictObjectPermissionsToMetadataWritability.ts b/packages/twenty-front/src/modules/object-record/read-only/utils/restrictObjectPermissionsToMetadataWritability.tsnew file mode 100644index 00000000000..92ce12300b8--- /dev/null+++ b/packages/twenty-front/src/modules/object-record/read-only/utils/restrictObjectPermissionsToMetadataWritability.ts@@ -0,0 +1,28 @@+import { isMetadataWritabilityRestricted } from '@/object-record/read-only/utils/internal/isMetadataWritabilityRestricted';+import { type ObjectPermissions } from 'twenty-shared/types';+import { type MetadataWritability } from '~/generated-metadata/graphql';++type RestrictObjectPermissionsToMetadataWritabilityParams<+ TObjectPermissions extends ObjectPermissions,+> = {+ objectPermissions: TObjectPermissions;+ writability: MetadataWritability | null | undefined;+};++export const restrictObjectPermissionsToMetadataWritability = <+ TObjectPermissions extends ObjectPermissions,+>({+ objectPermissions,+ writability,+}: RestrictObjectPermissionsToMetadataWritabilityParams<TObjectPermissions>): TObjectPermissions => {+ if (!isMetadataWritabilityRestricted(writability)) {+ return objectPermissions;+ }++ return {+ ...objectPermissions,+ canUpdateObjectRecords: false,+ canSoftDeleteObjectRecords: false,+ canDestroyObjectRecords: false,+ };+};