The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
[forms 4/4] Name the record creation callback arguments (#26101)
Thomas des Francs3627bb1138e5
diff --git a/packages/twenty-front/src/modules/object-record/hooks/useCreateNewRecord.ts b/packages/twenty-front/src/modules/object-record/hooks/useCreateNewRecord.tsindex 07d347d464c..c6c7d97b401 100644--- a/packages/twenty-front/src/modules/object-record/hooks/useCreateNewRecord.ts+++ b/packages/twenty-front/src/modules/object-record/hooks/useCreateNewRecord.ts@@ -8,6 +8,7 @@ import { useResolveOpenRecordIn } from '@/object-record/record-index/hooks/useReimport { useUpsertRecordsInStore } from '@/object-record/record-store/hooks/useUpsertRecordsInStore';import { newRecordTitleCellToOpenState } from '@/object-record/record-title-cell/states/newRecordTitleCellToOpenState';import { type ObjectRecord } from '@/object-record/types/ObjectRecord';+import { type OnRecordCreated } from '@/object-record/types/OnRecordCreated';import { useOpenRecordInSidePanel } from '@/side-panel/hooks/useOpenRecordInSidePanel';import { useSidePanelMenu } from '@/side-panel/hooks/useSidePanelMenu';import { useWorkspaceSurface } from '@/ui/layout/hooks/useWorkspaceSurface';@@ -21,10 +22,7 @@ import { useNavigateApp } from '~/hooks/useNavigateApp';type UseCreateNewRecordProps = {objectMetadataItem: EnrichedObjectMetadataItem;buildRecordInput?: () => Partial<ObjectRecord>;- onRecordCreated?: (- record: ObjectRecord,- recordInput?: Partial<ObjectRecord>,- ) => void;+ onRecordCreated?: OnRecordCreated;};export const useCreateNewRecord = ({@@ -118,7 +116,7 @@ export const useCreateNewRecord = ({});}- onRecordCreated?.(createdRecord, recordInput);+ onRecordCreated?.({ record: createdRecord, recordInput });upsertRecordsInStore({ partialRecords: [createdRecord] });diff --git a/packages/twenty-front/src/modules/object-record/record-table/hooks/useCreateNewIndexRecord.ts b/packages/twenty-front/src/modules/object-record/record-table/hooks/useCreateNewIndexRecord.tsindex 994e0546aab..e65a20e69e0 100644--- a/packages/twenty-front/src/modules/object-record/record-table/hooks/useCreateNewIndexRecord.ts+++ b/packages/twenty-front/src/modules/object-record/record-table/hooks/useCreateNewIndexRecord.ts@@ -5,7 +5,7 @@ import { recordGroupDefinitionsComponentSelector } from '@/object-record/record-import { recordIndexGroupFieldMetadataItemComponentState } from '@/object-record/record-index/states/recordIndexGroupFieldMetadataComponentState';import { recordIndexRecordIdsByGroupComponentFamilyState } from '@/object-record/record-index/states/recordIndexRecordIdsByGroupComponentFamilyState';import { useBuildRecordInputFromFilters } from '@/object-record/record-table/hooks/useBuildRecordInputFromFilters';-import { type ObjectRecord } from '@/object-record/types/ObjectRecord';+import { type OnRecordCreated } from '@/object-record/types/OnRecordCreated';import { useAtomComponentFamilyStateCallbackState } from '@/ui/utilities/state/jotai/hooks/useAtomComponentFamilyStateCallbackState';import { useAtomComponentSelectorValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentSelectorValue';import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';@@ -44,8 +44,8 @@ export const useCreateNewIndexRecord = ({instanceId,});- const onRecordCreated = useCallback(- (createdRecord: ObjectRecord, recordInput?: Partial<ObjectRecord>) => {+ const onRecordCreated = useCallback<OnRecordCreated>(+ ({ record: createdRecord, recordInput }) => {if (isDefined(recordIndexGroupFieldMetadataItem)) {const recordGroup = recordGroupDefinitions.find(findByProperty(diff --git a/packages/twenty-front/src/modules/object-record/types/OnRecordCreated.ts b/packages/twenty-front/src/modules/object-record/types/OnRecordCreated.tsnew file mode 100644index 00000000000..cc73cc22e50--- /dev/null+++ b/packages/twenty-front/src/modules/object-record/types/OnRecordCreated.ts@@ -0,0 +1,6 @@+import { type ObjectRecord } from '@/object-record/types/ObjectRecord';++export type OnRecordCreated = (args: {+ record: ObjectRecord;+ recordInput?: Partial<ObjectRecord>;+}) => void;diff --git a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__stories__/RecordCreationFlow.stories.tsx b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__stories__/RecordCreationFlow.stories.tsxindex c17fb906b1a..5efb6286b9b 100644--- a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__stories__/RecordCreationFlow.stories.tsx+++ b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__stories__/RecordCreationFlow.stories.tsx@@ -340,10 +340,10 @@ const submitCompany = async (canvasElement: HTMLElement, shortcut?: string) => {expect.objectContaining({ name: 'Acme', employees: 10, position: 'first' }),);await expect(onRecordCreated).toHaveBeenCalledTimes(1);- await expect(onRecordCreated).toHaveBeenCalledWith(- expect.objectContaining({ name: 'Acme', employees: 10 }),- expect.objectContaining({ name: 'Acme', position: 'first' }),- );+ await expect(onRecordCreated).toHaveBeenCalledWith({+ record: expect.objectContaining({ name: 'Acme', employees: 10 }),+ recordInput: expect.objectContaining({ name: 'Acme', position: 'first' }),+ });};export const SubmitWithButton: Story = {