The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Cover session cookie writes without the opt-in header (#29361)
Paul Rastoin38565fd12467
diff --git a/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/failing-session-cookie-writes-without-opt-in.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/failing-session-cookie-writes-without-opt-in.integration-spec.tsnew file mode 100644index 00000000000..d27e9b99afb--- /dev/null+++ b/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/failing-session-cookie-writes-without-opt-in.integration-spec.ts@@ -0,0 +1,61 @@+import {+ extractSessionCookie,+ hasClearingCookie,+ postMetadataOperationWithHeaders,+ signInWithCookieCapture,+} from 'test/integration/graphql/suites/auth/user-sessions/utils/sign-in-with-cookie-capture.util';+import {+ currentUserIdentityQueryFactory,+ signOutQueryFactory,+} from 'test/integration/graphql/suites/auth/user-sessions/utils/user-session-operations.util';++import { ALLOWED_ORIGIN } from 'test/integration/graphql/suites/auth/user-sessions/constants/session-origins.constants';++// Front component fetches send the page's cookies without the opt-in header: they must not change the browser's session.+describe('failing session cookie writes without the opt-in header (integration)', () => {+ it('should not set a session cookie when signing in', async () => {+ const signInResponse = await signInWithCookieCapture({+ originHeader: ALLOWED_ORIGIN,+ omitSessionCookieOptIn: true,+ });++ expect(signInResponse.body.errors).toBeUndefined();+ expect(+ signInResponse.body.data.getAuthTokensFromLoginToken.tokens+ .accessOrWorkspaceAgnosticToken.token,+ ).toBeDefined();+ expect(extractSessionCookie(signInResponse)).toBeUndefined();+ });++ it('should neither revoke nor clear the session when signing out', async () => {+ const signInResponse = await signInWithCookieCapture({+ originHeader: ALLOWED_ORIGIN,+ });+ const sessionCookie = extractSessionCookie(signInResponse);++ if (!sessionCookie) {+ throw new Error('Expected a session cookie from sign-in');+ }++ const signOutResponse = await postMetadataOperationWithHeaders(+ signOutQueryFactory(),+ {+ originHeader: ALLOWED_ORIGIN,+ cookieHeader: sessionCookie.cookieHeader,+ omitSessionCookieOptIn: true,+ },+ );++ expect(hasClearingCookie(signOutResponse)).toBe(false);++ const reuseResponse = await postMetadataOperationWithHeaders(+ currentUserIdentityQueryFactory(),+ {+ originHeader: ALLOWED_ORIGIN,+ cookieHeader: sessionCookie.cookieHeader,+ },+ );++ expect(reuseResponse.body.errors).toBeUndefined();+ });+});diff --git a/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/utils/sign-in-with-cookie-capture.util.ts b/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/utils/sign-in-with-cookie-capture.util.tsindex 114e46dd1b0..115b7f291b4 100644--- a/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/utils/sign-in-with-cookie-capture.util.ts+++ b/packages/twenty-server/test/integration/graphql/suites/auth/user-sessions/utils/sign-in-with-cookie-capture.util.ts@@ -11,6 +11,7 @@ import { USER_SESSION_SECURE_COOKIE_NAME } from 'src/engine/core-modules/user-setype RequestHeaders = {originHeader?: string;cookieHeader?: string;+ omitSessionCookieOptIn?: boolean;};// Supertest requests dispatch lazily, so Origin and Cookie can be set on the@@ -20,13 +21,18 @@ type RequestHeaders = {// util's default admin token.export const postMetadataOperationWithHeaders = (graphqlOperation: Parameters<typeof makeMetadataApiRequest>[0],- { originHeader, cookieHeader }: RequestHeaders,+ {+ originHeader,+ cookieHeader,+ omitSessionCookieOptIn = false,+ }: RequestHeaders,expectedStatus = 200,) => {- const graphqlRequest = makeMetadataApiRequest(graphqlOperation, null).set(- SESSION_COOKIE_OPT_IN_HEADER_NAME,- '1',- );+ const graphqlRequest = makeMetadataApiRequest(graphqlOperation, null);++ if (!omitSessionCookieOptIn) {+ graphqlRequest.set(SESSION_COOKIE_OPT_IN_HEADER_NAME, '1');+ }if (originHeader !== undefined) {graphqlRequest.set('Origin', originHeader);@@ -54,6 +60,7 @@ export const signInWithCookieCapture = async ({workspaceSubdomain = 'apple',originHeader,cookieHeader,+ omitSessionCookieOptIn,}: SignInOptions = {}): Promise<Response> => {const workspaceOrigin = buildWorkspaceOriginForSubdomain(workspaceSubdomain);@@ -63,7 +70,7 @@ export const signInWithCookieCapture = async ({password,origin: workspaceOrigin,}),- { originHeader, cookieHeader },+ { originHeader, cookieHeader, omitSessionCookieOptIn },);const loginToken =@@ -77,7 +84,7 @@ export const signInWithCookieCapture = async ({loginToken,origin: workspaceOrigin,}),- { originHeader, cookieHeader },+ { originHeader, cookieHeader, omitSessionCookieOptIn },);};