Skip to content

The open alternative to Salesforce, designed for AI.

fix(security): enforce object-level role permissions on system object writes (#24309) (#25809)

Pelle38f8f3e4dea8
diff --git a/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts b/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts
index 3ef33d45751..7835edf36ae 100644
--- a/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts
@@ -127,6 +127,7 @@ export class TimelineCalendarEventService {
const callRecordingRepository =
this.workspaceOrmManager.getRepository<CallRecordingWorkspaceEntity>(
'callRecording',
+ { shouldBypassPermissionChecks: true },
);
const callRecordings = await callRecordingRepository.find({
diff --git a/packages/twenty-server/src/engine/core-modules/messaging/services/timeline-messaging.service.ts b/packages/twenty-server/src/engine/core-modules/messaging/services/timeline-messaging.service.ts
index d7d68fd8574..d96d81bc7f7 100644
--- a/packages/twenty-server/src/engine/core-modules/messaging/services/timeline-messaging.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/messaging/services/timeline-messaging.service.ts
@@ -57,6 +57,7 @@ export class TimelineMessagingService {
const messageThreadRepository =
this.workspaceOrmManager.getRepository<MessageThreadWorkspaceEntity>(
'messageThread',
+ { shouldBypassPermissionChecks: true },
);
const totalQueryBuilder = messageThreadRepository
@@ -149,6 +150,7 @@ export class TimelineMessagingService {
const messageParticipantRepository =
this.workspaceOrmManager.getRepository<MessageParticipantWorkspaceEntity>(
'messageParticipant',
+ { shouldBypassPermissionChecks: true },
);
const threadParticipants = await messageParticipantRepository
@@ -285,6 +287,7 @@ export class TimelineMessagingService {
const messageThreadRepository =
this.workspaceOrmManager.getRepository<MessageThreadWorkspaceEntity>(
'messageThread',
+ { shouldBypassPermissionChecks: true },
);
const threadChannelRows = await messageThreadRepository
diff --git a/packages/twenty-server/src/engine/core-modules/tool/tools/email-tool/email-composer.service.ts b/packages/twenty-server/src/engine/core-modules/tool/tools/email-tool/email-composer.service.ts
index 24773c631ef..5541ec7504f 100644
--- a/packages/twenty-server/src/engine/core-modules/tool/tools/email-tool/email-composer.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool/tools/email-tool/email-composer.service.ts
@@ -311,6 +311,7 @@ export class EmailComposerService {
const messageRepository =
this.workspaceOrmManager.getRepository<MessageWorkspaceEntity>(
'message',
+ { shouldBypassPermissionChecks: true },
);
const parentMessage = await messageRepository.findOne({
@@ -328,6 +329,7 @@ export class EmailComposerService {
const associationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
const [association, ancestorMessages] = await Promise.all([
diff --git a/packages/twenty-server/src/engine/twenty-orm/repository/__tests__/permissions.utils.spec.ts b/packages/twenty-server/src/engine/twenty-orm/repository/__tests__/permissions.utils.spec.ts
new file mode 100644
index 00000000000..3351e1ef2d9
--- /dev/null
+++ b/packages/twenty-server/src/engine/twenty-orm/repository/__tests__/permissions.utils.spec.ts
@@ -0,0 +1,223 @@
+import {
+ type ObjectPermissions,
+ type ObjectsPermissions,
+} from 'twenty-shared/types';
+
+import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
+import { type OrmFlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/orm-flat-field-metadata.type';
+import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
+import {
+ PermissionsException,
+ PermissionsExceptionCode,
+ PermissionsExceptionMessage,
+} from 'src/engine/metadata-modules/permissions/permissions.exception';
+import {
+ type OperationType,
+ validateOperationIsPermittedOrThrow,
+} from 'src/engine/twenty-orm/repository/permissions.utils';
+
+describe('validateOperationIsPermittedOrThrow - system objects permissions', () => {
+ const SYSTEM_OBJECT_ID = 'system-obj-message-id';
+ const SYSTEM_OBJECT_NAME = 'message';
+ const SYSTEM_OBJECT_UNIVERSAL_ID = 'message-universal-id';
+
+ const mockFlatObjectMetadataMaps: FlatEntityMaps<FlatObjectMetadata> = {
+ byUniversalIdentifier: {
+ [SYSTEM_OBJECT_UNIVERSAL_ID]: {
+ id: SYSTEM_OBJECT_ID,
+ nameSingular: SYSTEM_OBJECT_NAME,
+ universalIdentifier: SYSTEM_OBJECT_UNIVERSAL_ID,
+ isSystem: true,
+ isCustom: false,
+ fieldIds: [],
+ indexIds: [],
+ } as unknown as FlatObjectMetadata,
+ },
+ universalIdentifierById: {
+ [SYSTEM_OBJECT_ID]: SYSTEM_OBJECT_UNIVERSAL_ID,
+ },
+ universalIdentifiersByApplicationId: {},
+ };
+
+ const mockFlatFieldMetadataMaps: FlatEntityMaps<OrmFlatFieldMetadata> = {
+ byUniversalIdentifier: {},
+ universalIdentifierById: {},
+ universalIdentifiersByApplicationId: {},
+ };
+
+ const objectIdByNameSingular: Record<string, string> = {
+ [SYSTEM_OBJECT_NAME]: SYSTEM_OBJECT_ID,
+ };
+
+ const baseObjectPermissions: ObjectPermissions = {
+ canReadObjectRecords: true,
+ canUpdateObjectRecords: true,
+ canSoftDeleteObjectRecords: true,
+ canDestroyObjectRecords: true,
+ restrictedFields: {},
+ rowLevelPermissionPredicates: [],
+ rowLevelPermissionPredicateGroups: [],
+ };
+
+ const executeValidation = ({
+ operationType,
+ objectsPermissions = {},
+ updatedColumns = [],
+ selectedColumns = [],
+ }: {
+ operationType: OperationType;
+ objectsPermissions?: ObjectsPermissions;
+ updatedColumns?: string[];
+ selectedColumns?: string[] | '*';
+ }) => {
+ return validateOperationIsPermittedOrThrow({
+ entityName: SYSTEM_OBJECT_NAME,
+ operationType,
+ objectsPermissions,
+ flatObjectMetadataMaps: mockFlatObjectMetadataMaps,
+ flatFieldMetadataMaps: mockFlatFieldMetadataMaps,
+ objectIdByNameSingular,
+ selectedColumns,
+ allFieldsSelected: false,
+ updatedColumns,
+ });
+ };
+
+ describe('when effective permissions are missing for the system object', () => {
+ it.each<OperationType>([
+ 'select',
+ 'insert',
+ 'update',
+ 'delete',
+ 'soft-delete',
+ 'restore',
+ ])('should deny %s', (operationType) => {
+ expect(() => executeValidation({ operationType })).toThrow(
+ new PermissionsException(
+ PermissionsExceptionMessage.PERMISSION_DENIED,
+ PermissionsExceptionCode.PERMISSION_DENIED,
+ ),
+ );
+ });
+ });
+
+ describe('when object-level role permissions are defined for the system object', () => {
+ it('should throw PERMISSION_DENIED on insert when canUpdateObjectRecords is false', () => {
+ const objectsPermissions: ObjectsPermissions = {
+ [SYSTEM_OBJECT_ID]: {
+ ...baseObjectPermissions,
+ canUpdateObjectRecords: false,
+ },
+ };
+
+ expect(() =>
+ executeValidation({ operationType: 'insert', objectsPermissions }),
+ ).toThrow(
+ new PermissionsException(
+ PermissionsExceptionMessage.PERMISSION_DENIED,
+ PermissionsExceptionCode.PERMISSION_DENIED,
+ ),
+ );
+ });
+
+ it('should throw PERMISSION_DENIED on update when canUpdateObjectRecords is false', () => {
+ const objectsPermissions: ObjectsPermissions = {
+ [SYSTEM_OBJECT_ID]: {
+ ...baseObjectPermissions,
+ canUpdateObjectRecords: false,
+ },
+ };
+
+ expect(() =>
+ executeValidation({ operationType: 'update', objectsPermissions }),
+ ).toThrow(
+ new PermissionsException(
+ PermissionsExceptionMessage.PERMISSION_DENIED,
+ PermissionsExceptionCode.PERMISSION_DENIED,
+ ),
+ );
+ });
+
+ it('should throw PERMISSION_DENIED on delete when canDestroyObjectRecords is false', () => {
+ const objectsPermissions: ObjectsPermissions = {
+ [SYSTEM_OBJECT_ID]: {
+ ...baseObjectPermissions,
+ canDestroyObjectRecords: false,
+ },
+ };
+
+ expect(() =>
+ executeValidation({ operationType: 'delete', objectsPermissions }),
+ ).toThrow(
+ new PermissionsException(
+ PermissionsExceptionMessage.PERMISSION_DENIED,
+ PermissionsExceptionCode.PERMISSION_DENIED,
+ ),
+ );
+ });
+
+ it('should throw PERMISSION_DENIED on soft-delete when canSoftDeleteObjectRecords is false', () => {
+ const objectsPermissions: ObjectsPermissions = {
+ [SYSTEM_OBJECT_ID]: {
+ ...baseObjectPermissions,
+ canSoftDeleteObjectRecords: false,
+ },
+ };
+
+ expect(() =>
+ executeValidation({ operationType: 'soft-delete', objectsPermissions }),
+ ).toThrow(
+ new PermissionsException(
+ PermissionsExceptionMessage.PERMISSION_DENIED,
+ PermissionsExceptionCode.PERMISSION_DENIED,
+ ),
+ );
+ });
+
+ it('should throw PERMISSION_DENIED on select when canReadObjectRecords is false', () => {
+ const objectsPermissions: ObjectsPermissions = {
+ [SYSTEM_OBJECT_ID]: {
+ ...baseObjectPermissions,
+ canReadObjectRecords: false,
+ },
+ };
+
+ expect(() =>
+ executeValidation({ operationType: 'select', objectsPermissions }),
+ ).toThrow(
+ new PermissionsException(
+ PermissionsExceptionMessage.PERMISSION_DENIED,
+ PermissionsExceptionCode.PERMISSION_DENIED,
+ ),
+ );
+ });
+
+ it('should permit operations when role permissions grant access to the system object', () => {
+ const objectsPermissions: ObjectsPermissions = {
+ [SYSTEM_OBJECT_ID]: {
+ ...baseObjectPermissions,
+ canUpdateObjectRecords: true,
+ canDestroyObjectRecords: true,
+ canSoftDeleteObjectRecords: true,
+ canReadObjectRecords: true,
+ },
+ };
+
+ expect(() =>
+ executeValidation({ operationType: 'insert', objectsPermissions }),
+ ).not.toThrow();
+ expect(() =>
+ executeValidation({ operationType: 'update', objectsPermissions }),
+ ).not.toThrow();
+ expect(() =>
+ executeValidation({ operationType: 'delete', objectsPermissions }),
+ ).not.toThrow();
+ expect(() =>
+ executeValidation({ operationType: 'soft-delete', objectsPermissions }),
+ ).not.toThrow();
+ expect(() =>
+ executeValidation({ operationType: 'select', objectsPermissions }),
+ ).not.toThrow();
+ });
+ });
+});
diff --git a/packages/twenty-server/src/engine/twenty-orm/repository/permissions.utils.ts b/packages/twenty-server/src/engine/twenty-orm/repository/permissions.utils.ts
index 8e031087c27..bab38ceffb6 100644
--- a/packages/twenty-server/src/engine/twenty-orm/repository/permissions.utils.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/repository/permissions.utils.ts
@@ -18,7 +18,6 @@ import {
} from 'src/engine/metadata-modules/permissions/permissions.exception';
import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
import { validateWritabilityOrThrow } from 'src/engine/twenty-orm/repository/validate-writability-or-throw.util';
-import { isExemptFromObjectPermissions } from 'src/engine/twenty-orm/utils/is-exempt-from-object-permissions.util';
import { isObjectOperationPermitted } from 'src/engine/twenty-orm/utils/is-object-operation-permitted.util';
import { getColumnNameToFieldMetadataIdMap } from 'src/engine/twenty-orm/utils/get-column-name-to-field-metadata-id.util';
@@ -90,10 +89,6 @@ export const validateOperationIsPermittedOrThrow = ({
authContext,
});
- if (isExemptFromObjectPermissions(objectMetadata)) {
- return;
- }
-
const permissionsForEntity = objectsPermissions[objectMetadataIdForEntity];
if (
diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/is-exempt-from-object-permissions.util.ts b/packages/twenty-server/src/engine/twenty-orm/utils/is-exempt-from-object-permissions.util.ts
deleted file mode 100644
index 3c63c79e232..00000000000
--- a/packages/twenty-server/src/engine/twenty-orm/utils/is-exempt-from-object-permissions.util.ts
+++ /dev/null
@@ -1,11 +0,0 @@
-import { STANDARD_OBJECTS } from 'twenty-shared/metadata';
-
-import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
-
-// TODO: this should be improved, we may have more complex permission configuration for is system objects
-export const isExemptFromObjectPermissions = (
- objectMetadata: FlatObjectMetadata,
-): boolean =>
- objectMetadata.isSystem === true &&
- objectMetadata.universalIdentifier !==
- STANDARD_OBJECTS.workspaceMember.universalIdentifier;
diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/is-object-operation-permitted.util.ts b/packages/twenty-server/src/engine/twenty-orm/utils/is-object-operation-permitted.util.ts
index 73cdcc5686d..5adf21e8dcd 100644
--- a/packages/twenty-server/src/engine/twenty-orm/utils/is-object-operation-permitted.util.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/utils/is-object-operation-permitted.util.ts
@@ -3,7 +3,6 @@ import { assertUnreachable } from 'twenty-shared/utils';
import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
import { type OperationType } from 'src/engine/twenty-orm/repository/permissions.utils';
-import { isExemptFromObjectPermissions } from 'src/engine/twenty-orm/utils/is-exempt-from-object-permissions.util';
export const isObjectOperationPermitted = ({
objectMetadata,
@@ -14,10 +13,6 @@ export const isObjectOperationPermitted = ({
operationType: OperationType;
objectsPermissions: ObjectsPermissions;
}): boolean => {
- if (isExemptFromObjectPermissions(objectMetadata)) {
- return true;
- }
-
const objectPermissions = objectsPermissions[objectMetadata.id];
switch (operationType) {
diff --git a/packages/twenty-server/src/modules/blocklist/repositories/blocklist.repository.ts b/packages/twenty-server/src/modules/blocklist/repositories/blocklist.repository.ts
index 7274fc2f22e..443eff9a3ef 100644
--- a/packages/twenty-server/src/modules/blocklist/repositories/blocklist.repository.ts
+++ b/packages/twenty-server/src/modules/blocklist/repositories/blocklist.repository.ts
@@ -123,6 +123,7 @@ export class BlocklistRepository {
return this.workspaceOrmManager.executeInWorkspaceContext(async () => {
const blockListRepository = this.workspaceOrmManager.getRepository(
BlocklistWorkspaceEntity,
+ { shouldBypassPermissionChecks: true },
);
return blockListRepository.find({ where });
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-cleaner/services/calendar-event-cleaner.service.ts b/packages/twenty-server/src/modules/calendar/calendar-event-cleaner/services/calendar-event-cleaner.service.ts
index e0275a6611a..a42e78e7aa5 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-cleaner/services/calendar-event-cleaner.service.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-cleaner/services/calendar-event-cleaner.service.ts
@@ -32,6 +32,7 @@ export class CalendarEventCleanerService {
const calendarChannelEventAssociationRepository =
transactionScope.getRepository<CalendarChannelEventAssociationWorkspaceEntity>(
'calendarChannelEventAssociation',
+ { shouldBypassPermissionChecks: true },
);
for (;;) {
@@ -82,10 +83,12 @@ export class CalendarEventCleanerService {
const calendarEventRepository =
transactionScope.getRepository<CalendarEventWorkspaceEntity>(
'calendarEvent',
+ { shouldBypassPermissionChecks: true },
);
const calendarChannelEventAssociationRepository =
transactionScope.getRepository<CalendarChannelEventAssociationWorkspaceEntity>(
'calendarChannelEventAssociation',
+ { shouldBypassPermissionChecks: true },
);
for (
@@ -134,10 +137,12 @@ export class CalendarEventCleanerService {
const calendarEventRepository =
transactionScope.getRepository<CalendarEventWorkspaceEntity>(
'calendarEvent',
+ { shouldBypassPermissionChecks: true },
);
const calendarChannelEventAssociationRepository =
transactionScope.getRepository<CalendarChannelEventAssociationWorkspaceEntity>(
'calendarChannelEventAssociation',
+ { shouldBypassPermissionChecks: true },
);
let cursor: string | undefined;
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts
index d68d22cff3b..0e8689bd9b9 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts
@@ -157,6 +157,7 @@ export class CalendarEventsImportService {
const calendarChannelEventAssociationRepository =
this.workspaceOrmManager.getRepository<CalendarChannelEventAssociationWorkspaceEntity>(
'calendarChannelEventAssociation',
+ { shouldBypassPermissionChecks: true },
);
const associationsToDelete =
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-fetch-events.service.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-fetch-events.service.ts
index 5529fb4ee28..60af0183744 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-fetch-events.service.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-fetch-events.service.ts
@@ -63,6 +63,7 @@ export class CalendarFetchEventsService {
const calendarChannelEventAssociationRepository =
this.workspaceOrmManager.getRepository<CalendarChannelEventAssociationWorkspaceEntity>(
'calendarChannelEventAssociation',
+ { shouldBypassPermissionChecks: true },
);
const associationsToDelete =
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts
index 37cb19d59c5..d0f3e4166f9 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts
@@ -34,6 +34,7 @@ export class CalendarSaveEventsService {
const calendarChannelEventAssociationRepository =
this.workspaceOrmManager.getRepository<CalendarChannelEventAssociationWorkspaceEntity>(
'calendarChannelEventAssociation',
+ { shouldBypassPermissionChecks: true },
);
const existingAssociations =
@@ -79,11 +80,13 @@ export class CalendarSaveEventsService {
const calendarEventRepository =
transactionScope.getRepository<CalendarEventWorkspaceEntity>(
'calendarEvent',
+ { shouldBypassPermissionChecks: true },
);
const associationRepository =
transactionScope.getRepository<CalendarChannelEventAssociationWorkspaceEntity>(
'calendarChannelEventAssociation',
+ { shouldBypassPermissionChecks: true },
);
if (saveOperations.calendarEventsToInsert.length > 0) {
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/services/calendar-event-participant.service.ts b/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/services/calendar-event-participant.service.ts
index 489b46df973..0d196fb1e38 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/services/calendar-event-participant.service.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/services/calendar-event-participant.service.ts
@@ -38,6 +38,7 @@ export class CalendarEventParticipantService {
const calendarEventParticipantRepository =
this.workspaceOrmManager.getRepository<CalendarEventParticipantWorkspaceEntity>(
'calendarEventParticipant',
+ { shouldBypassPermissionChecks: true },
);
return calendarEventParticipantRepository.find({
@@ -55,6 +56,7 @@ export class CalendarEventParticipantService {
const calendarEventParticipantRepository =
transactionScope.getRepository<CalendarEventParticipantWorkspaceEntity>(
'calendarEventParticipant',
+ { shouldBypassPermissionChecks: true },
);
if (operations.participantIdsToDelete.length > 0) {
@@ -98,6 +100,7 @@ export class CalendarEventParticipantService {
const calendarEventParticipantRepository =
this.workspaceOrmManager.getRepository<CalendarEventParticipantWorkspaceEntity>(
'calendarEventParticipant',
+ { shouldBypassPermissionChecks: true },
);
const savedParticipants: CalendarEventParticipantWorkspaceEntity[] = [];
diff --git a/packages/twenty-server/src/modules/calendar/common/query-hooks/calendar-event/services/apply-calendar-events-visibility-restrictions.service.ts b/packages/twenty-server/src/modules/calendar/common/query-hooks/calendar-event/services/apply-calendar-events-visibility-restrictions.service.ts
index c27e12a3536..e17d0d8b2a8 100644
--- a/packages/twenty-server/src/modules/calendar/common/query-hooks/calendar-event/services/apply-calendar-events-visibility-restrictions.service.ts
+++ b/packages/twenty-server/src/modules/calendar/common/query-hooks/calendar-event/services/apply-calendar-events-visibility-restrictions.service.ts
@@ -39,6 +39,7 @@ export class ApplyCalendarEventsVisibilityRestrictionsService {
const calendarChannelEventAssociationRepository =
this.workspaceOrmManager.getRepository<CalendarChannelEventAssociationWorkspaceEntity>(
'calendarChannelEventAssociation',
+ { shouldBypassPermissionChecks: true },
);
const calendarChannelCalendarEventsAssociations =
diff --git a/packages/twenty-server/src/modules/match-participant/match-participant.service.ts b/packages/twenty-server/src/modules/match-participant/match-participant.service.ts
index 510cead5dff..02cdc534540 100644
--- a/packages/twenty-server/src/modules/match-participant/match-participant.service.ts
+++ b/packages/twenty-server/src/modules/match-participant/match-participant.service.ts
@@ -82,6 +82,7 @@ export class MatchParticipantService<
objectMetadataName,
transactionScope,
workspaceOrmManager: this.workspaceOrmManager,
+ rolePermissionConfig: { shouldBypassPermissionChecks: true },
},
);
}
diff --git a/packages/twenty-server/src/modules/messaging/blocklist-manager/jobs/messaging-blocklist-item-delete-messages.job.ts b/packages/twenty-server/src/modules/messaging/blocklist-manager/jobs/messaging-blocklist-item-delete-messages.job.ts
index d46bbeb79ac..b115fdf2d2b 100644
--- a/packages/twenty-server/src/modules/messaging/blocklist-manager/jobs/messaging-blocklist-item-delete-messages.job.ts
+++ b/packages/twenty-server/src/modules/messaging/blocklist-manager/jobs/messaging-blocklist-item-delete-messages.job.ts
@@ -57,6 +57,7 @@ export class BlocklistItemDeleteMessagesJob {
const blocklistRepository =
this.workspaceOrmManager.getRepository<BlocklistWorkspaceEntity>(
'blocklist',
+ { shouldBypassPermissionChecks: true },
);
const blocklist = await blocklistRepository.find({
@@ -176,6 +177,7 @@ export class BlocklistItemDeleteMessagesJob {
const messageChannelMessageAssociationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
const messageParticipantRepository =
diff --git a/packages/twenty-server/src/modules/messaging/common/query-hooks/message/apply-messages-visibility-restrictions.service.ts b/packages/twenty-server/src/modules/messaging/common/query-hooks/message/apply-messages-visibility-restrictions.service.ts
index 502de2088eb..067bae2da6b 100644
--- a/packages/twenty-server/src/modules/messaging/common/query-hooks/message/apply-messages-visibility-restrictions.service.ts
+++ b/packages/twenty-server/src/modules/messaging/common/query-hooks/message/apply-messages-visibility-restrictions.service.ts
@@ -41,6 +41,7 @@ export class ApplyMessagesVisibilityRestrictionsService {
const messageChannelMessageAssociationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
const messageChannelMessagesAssociations =
diff --git a/packages/twenty-server/src/modules/messaging/message-cleaner/services/messaging-message-cleaner.service.ts b/packages/twenty-server/src/modules/messaging/message-cleaner/services/messaging-message-cleaner.service.ts
index 010d9707c23..fb3b126486e 100644
--- a/packages/twenty-server/src/modules/messaging/message-cleaner/services/messaging-message-cleaner.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-cleaner/services/messaging-message-cleaner.service.ts
@@ -38,14 +38,19 @@ export class MessagingMessageCleanerService {
await this.workspaceOrmManager.runInWorkspaceTransaction(
async (transactionScope) => {
const messageRepository =
- transactionScope.getRepository<MessageWorkspaceEntity>('message');
+ transactionScope.getRepository<MessageWorkspaceEntity>(
+ 'message',
+ { shouldBypassPermissionChecks: true },
+ );
const messageChannelMessageAssociationRepository =
transactionScope.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
const messageThreadRepository =
transactionScope.getRepository<MessageThreadWorkspaceEntity>(
'messageThread',
+ { shouldBypassPermissionChecks: true },
);
for (const messageExternalIdsChunk of chunk(
@@ -148,6 +153,7 @@ export class MessagingMessageCleanerService {
const messageChannelMessageAssociationRepository =
transactionScope.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
for (;;) {
@@ -188,12 +194,17 @@ export class MessagingMessageCleanerService {
const messageThreadRepository =
transactionScope.getRepository<MessageThreadWorkspaceEntity>(
'messageThread',
+ { shouldBypassPermissionChecks: true },
);
const messageRepository =
- transactionScope.getRepository<MessageWorkspaceEntity>('message');
+ transactionScope.getRepository<MessageWorkspaceEntity>(
+ 'message',
+ { shouldBypassPermissionChecks: true },
+ );
const messageChannelMessageAssociationRepository =
transactionScope.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
await this.deleteOrphansByKeyset(
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/inbound-email/services/inbound-email-import.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/inbound-email/services/inbound-email-import.service.ts
index 8498048c151..f0297394e24 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/inbound-email/services/inbound-email-import.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/inbound-email/services/inbound-email-import.service.ts
@@ -179,7 +179,9 @@ export class InboundEmailImportService {
);
const referencedMessages = await this.workspaceOrmManager
- .getRepository<MessageWorkspaceEntity>('message')
+ .getRepository<MessageWorkspaceEntity>('message', {
+ shouldBypassPermissionChecks: true,
+ })
.find({
where: {
headerMessageId: In(
@@ -196,6 +198,7 @@ export class InboundEmailImportService {
const channelAssociations = await this.workspaceOrmManager
.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
)
.find({
where: {
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-delete-folder-messages.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-delete-folder-messages.service.ts
index 866b503206e..fa010d14c33 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-delete-folder-messages.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-delete-folder-messages.service.ts
@@ -42,11 +42,13 @@ export class MessagingDeleteFolderMessagesService {
const messageFolderAssociationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationMessageFolderWorkspaceEntity>(
'messageChannelMessageAssociationMessageFolder',
+ { shouldBypassPermissionChecks: true },
);
const messageChannelMessageAssociationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
let hasMoreData = true;
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-delete-group-email-messages.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-delete-group-email-messages.service.ts
index 48885254044..bba2905a4ea 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-delete-group-email-messages.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-delete-group-email-messages.service.ts
@@ -42,11 +42,13 @@ export class MessagingDeleteGroupEmailMessagesService {
const messageChannelMessageAssociationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
const messageParticipantRepository =
this.workspaceOrmManager.getRepository<MessageParticipantWorkspaceEntity>(
'messageParticipant',
+ { shouldBypassPermissionChecks: true },
);
let cursorId: string | undefined;
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-folder-association.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-folder-association.service.ts
index 8d86ebaf3d1..e7d077dc807 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-folder-association.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-folder-association.service.ts
@@ -37,6 +37,7 @@ export class MessagingMessageFolderAssociationService {
const repository =
transactionScope.getRepository<MessageChannelMessageAssociationMessageFolderWorkspaceEntity>(
'messageChannelMessageAssociationMessageFolder',
+ { shouldBypassPermissionChecks: true },
);
const existingRecords = await repository.find({
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-list-fetch.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-list-fetch.service.ts
index a5a9a221ac6..374fae27ec9 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-list-fetch.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-list-fetch.service.ts
@@ -151,6 +151,7 @@ export class MessagingMessageListFetchService {
const messageChannelMessageAssociationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
const messageExternalIdsChunks = chunk(messageExternalIds, 200);
@@ -349,6 +350,7 @@ export class MessagingMessageListFetchService {
const messageChannelMessageAssociationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
const fullSyncMessageChannelMessageAssociationsToDelete = [];
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message.service.ts
index 3da0a94d104..dad2df4f955 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message.service.ts
@@ -64,14 +64,18 @@ export class MessagingMessageService {
const messageChannelMessageAssociationRepository =
transactionScope.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
const messageRepository =
- transactionScope.getRepository<MessageWorkspaceEntity>('message');
+ transactionScope.getRepository<MessageWorkspaceEntity>('message', {
+ shouldBypassPermissionChecks: true,
+ });
const messageThreadRepository =
transactionScope.getRepository<MessageThreadWorkspaceEntity>(
'messageThread',
+ { shouldBypassPermissionChecks: true },
);
const messageAccumulatorMap = new Map<string, MessageAccumulator>();
diff --git a/packages/twenty-server/src/modules/messaging/message-outbound-manager/services/messaging-draft-send.service.ts b/packages/twenty-server/src/modules/messaging/message-outbound-manager/services/messaging-draft-send.service.ts
index 6334d9b9cdf..9999e881acb 100644
--- a/packages/twenty-server/src/modules/messaging/message-outbound-manager/services/messaging-draft-send.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-outbound-manager/services/messaging-draft-send.service.ts
@@ -69,6 +69,7 @@ export class MessagingDraftSendService {
const messageChannelMessageAssociationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
const association =
@@ -137,6 +138,7 @@ export class MessagingDraftSendService {
const messageChannelMessageAssociationRepository =
this.workspaceOrmManager.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
);
return messageChannelMessageAssociationRepository.find({
diff --git a/packages/twenty-server/src/modules/messaging/message-participant-manager/services/messaging-message-participant.service.ts b/packages/twenty-server/src/modules/messaging/message-participant-manager/services/messaging-message-participant.service.ts
index 165019b2432..9276d9e508c 100644
--- a/packages/twenty-server/src/modules/messaging/message-participant-manager/services/messaging-message-participant.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-participant-manager/services/messaging-message-participant.service.ts
@@ -35,6 +35,7 @@ export class MessagingMessageParticipantService {
const messageParticipantRepository =
transactionScope.getRepository<MessageParticipantWorkspaceEntity>(
'messageParticipant',
+ { shouldBypassPermissionChecks: true },
);
const existingParticipantsBasedOnMessageIds =
diff --git a/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/automated-trigger.workspace-service.ts b/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/automated-trigger.workspace-service.ts
index 557a3726e90..ac8d276958a 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/automated-trigger.workspace-service.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/automated-trigger.workspace-service.ts
@@ -31,6 +31,7 @@ export class AutomatedTriggerWorkspaceService {
await transactionScope
.getRepository<WorkflowAutomatedTriggerWorkspaceEntity>(
'workflowAutomatedTrigger',
+ { shouldBypassPermissionChecks: true },
)
.insert({ type, settings, workflowId });
@@ -43,6 +44,7 @@ export class AutomatedTriggerWorkspaceService {
const workflowAutomatedTriggerRepository =
this.workspaceOrmManager.getRepository<WorkflowAutomatedTriggerWorkspaceEntity>(
'workflowAutomatedTrigger',
+ { shouldBypassPermissionChecks: true },
);
await workflowAutomatedTriggerRepository.insert({
@@ -66,6 +68,7 @@ export class AutomatedTriggerWorkspaceService {
await transactionScope
.getRepository<WorkflowAutomatedTriggerWorkspaceEntity>(
'workflowAutomatedTrigger',
+ { shouldBypassPermissionChecks: true },
)
.delete({ workflowId });
@@ -78,6 +81,7 @@ export class AutomatedTriggerWorkspaceService {
const workflowAutomatedTriggerRepository =
this.workspaceOrmManager.getRepository<WorkflowAutomatedTriggerWorkspaceEntity>(
'workflowAutomatedTrigger',
+ { shouldBypassPermissionChecks: true },
);
await workflowAutomatedTriggerRepository.delete({ workflowId });
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/system-object-records-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/system-object-records-permissions.integration-spec.ts
new file mode 100644
index 00000000000..ba0be2eda2b
--- /dev/null
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/system-object-records-permissions.integration-spec.ts
@@ -0,0 +1,335 @@
+import { randomUUID } from 'node:crypto';
+
+import gql from 'graphql-tag';
+import { MESSAGE_GQL_FIELDS } from 'test/integration/constants/message-gql-fields.constants';
+import { PERSON_GQL_FIELDS } from 'test/integration/constants/person-gql-fields.constants';
+import { createOneOperationFactory } from 'test/integration/graphql/utils/create-one-operation-factory.util';
+import { deleteOneOperationFactory } from 'test/integration/graphql/utils/delete-one-operation-factory.util';
+import { destroyOneOperationFactory } from 'test/integration/graphql/utils/destroy-one-operation-factory.util';
+import { findOneOperationFactory } from 'test/integration/graphql/utils/find-one-operation-factory.util';
+import { generateApiKeyToken } from 'test/integration/graphql/utils/generate-api-key-token.util';
+import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
+import { updateOneOperationFactory } from 'test/integration/graphql/utils/update-one-operation-factory.util';
+import { findManyObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata.util';
+import { upsertObjectPermissions } from 'test/integration/metadata/suites/object-permission/utils/upsert-object-permissions.util';
+import { createOneRole } from 'test/integration/metadata/suites/role/utils/create-one-role.util';
+import { deleteOneRole } from 'test/integration/metadata/suites/role/utils/delete-one-role.util';
+import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
+import { deleteRecordsByIds } from 'test/integration/utils/delete-records-by-ids';
+import { jestExpectToBeDefined } from 'test/utils/jest-expect-to-be-defined.util.test';
+import { isDefined } from 'twenty-shared/utils';
+
+import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
+import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
+
+type GraphqlResponse = {
+ body: {
+ data: Record<string, unknown> | null;
+ errors?: { message: string; extensions: { code: string } }[];
+ };
+};
+
+const expectPermissionDenied = (response: GraphqlResponse) => {
+ expect(response.body.errors).toBeDefined();
+ expect(response.body.errors?.[0].message).toBe(
+ PermissionsExceptionMessage.PERMISSION_DENIED,
+ );
+ expect(response.body.errors?.[0].extensions.code).toBe(ErrorCode.FORBIDDEN);
+};
+
+const createApiKeyForRole = async ({
+ name,
+ roleId,
+}: {
+ name: string;
+ roleId: string;
+}) => {
+ const createApiKeyResponse = await makeMetadataAPIRequest({
+ query: gql`
+ mutation CreateApiKey($input: CreateApiKeyInput!) {
+ createApiKey(input: $input) {
+ id
+ }
+ }
+ `,
+ variables: {
+ input: {
+ name,
+ expiresAt: new Date(Date.now() + 60 * 60 * 1000).toISOString(),
+ roleId,
+ },
+ },
+ });
+
+ const apiKeyId: string | undefined =
+ createApiKeyResponse.body.data?.createApiKey?.id;
+
+ jestExpectToBeDefined(apiKeyId);
+
+ const tokenResponse = await generateApiKeyToken({
+ apiKeyId,
+ accessToken: APPLE_JANE_ADMIN_ACCESS_TOKEN,
+ });
+
+ const token: string | undefined =
+ tokenResponse.body.data?.generateApiKeyToken?.token;
+
+ jestExpectToBeDefined(token);
+
+ return { apiKeyId, token };
+};
+
+describe('systemObjectRecordsPermissions', () => {
+ const messageId = randomUUID();
+ const personId = randomUUID();
+ const messageThreadId = randomUUID();
+
+ let readOnlyRoleId: string | undefined;
+ let readOnlyApiKeyId: string | undefined;
+ let readOnlyApiKeyToken: string;
+
+ let noOverrideRoleId: string | undefined;
+ let noOverrideApiKeyId: string | undefined;
+ let noOverrideApiKeyToken: string;
+
+ beforeAll(async () => {
+ const { objects } = await findManyObjectMetadata({
+ expectToFail: false,
+ input: { filter: {}, paging: { first: 1000 } },
+ gqlFields: 'id nameSingular',
+ });
+
+ const messageObjectMetadataId = objects.find(
+ (objectMetadata) => objectMetadata.nameSingular === 'message',
+ )?.id;
+ const messageThreadObjectMetadataId = objects.find(
+ (objectMetadata) => objectMetadata.nameSingular === 'messageThread',
+ )?.id;
+
+ jestExpectToBeDefined(messageObjectMetadataId);
+ jestExpectToBeDefined(messageThreadObjectMetadataId);
+
+ const createMessageResponse = await makeGraphqlAPIRequest(
+ createOneOperationFactory({
+ objectMetadataSingularName: 'message',
+ gqlFields: MESSAGE_GQL_FIELDS,
+ data: {
+ id: messageId,
+ subject: 'System object permissions',
+ text: 'Original text',
+ },
+ }),
+ );
+
+ expect(createMessageResponse.body.errors).toBeUndefined();
+ expect(createMessageResponse.body.data.createMessage.id).toBe(messageId);
+
+ const createPersonResponse = await makeGraphqlAPIRequest(
+ createOneOperationFactory({
+ objectMetadataSingularName: 'person',
+ gqlFields: PERSON_GQL_FIELDS,
+ data: { id: personId, jobTitle: 'Software Engineer' },
+ }),
+ );
+
+ expect(createPersonResponse.body.errors).toBeUndefined();
+ expect(createPersonResponse.body.data.createPerson.id).toBe(personId);
+
+ const { data: readOnlyRoleData } = await createOneRole({
+ expectToFail: false,
+ input: {
+ label: 'Message read-only role',
+ description: 'API key role overriding messaging objects to read-only',
+ icon: 'IconKey',
+ canUpdateAllSettings: false,
+ canAccessAllTools: true,
+ canReadAllObjectRecords: true,
+ canUpdateAllObjectRecords: true,
+ canSoftDeleteAllObjectRecords: true,
+ canDestroyAllObjectRecords: true,
+ canBeAssignedToUsers: false,
+ canBeAssignedToAgents: false,
+ canBeAssignedToApiKeys: true,
+ },
+ });
+
+ readOnlyRoleId = readOnlyRoleData?.createOneRole?.id;
+ jestExpectToBeDefined(readOnlyRoleId);
+
+ await upsertObjectPermissions({
+ expectToFail: false,
+ input: {
+ roleId: readOnlyRoleId,
+ objectPermissions: [
+ messageObjectMetadataId,
+ messageThreadObjectMetadataId,
+ ].map((objectMetadataId) => ({
+ objectMetadataId,
+ canReadObjectRecords: true,
+ canUpdateObjectRecords: false,
+ canSoftDeleteObjectRecords: false,
+ canDestroyObjectRecords: false,
+ })),
+ },
+ });
+
+ ({ apiKeyId: readOnlyApiKeyId, token: readOnlyApiKeyToken } =
+ await createApiKeyForRole({
+ name: 'Message read-only key',
+ roleId: readOnlyRoleId,
+ }));
+
+ const { data: noOverrideRoleData } = await createOneRole({
+ expectToFail: false,
+ input: {
+ label: 'No write permissions role',
+ description: 'API key role with no override on system objects',
+ icon: 'IconKey',
+ canUpdateAllSettings: false,
+ canAccessAllTools: true,
+ canReadAllObjectRecords: true,
+ canUpdateAllObjectRecords: false,
+ canSoftDeleteAllObjectRecords: false,
+ canDestroyAllObjectRecords: false,
+ canBeAssignedToUsers: false,
+ canBeAssignedToAgents: false,
+ canBeAssignedToApiKeys: true,
+ },
+ });
+
+ noOverrideRoleId = noOverrideRoleData?.createOneRole?.id;
+ jestExpectToBeDefined(noOverrideRoleId);
+
+ ({ apiKeyId: noOverrideApiKeyId, token: noOverrideApiKeyToken } =
+ await createApiKeyForRole({
+ name: 'No write permissions key',
+ roleId: noOverrideRoleId,
+ }));
+ });
+
+ afterAll(async () => {
+ await deleteRecordsByIds('message', [messageId]);
+ await deleteRecordsByIds('person', [personId]);
+ await deleteRecordsByIds('messageThread', [messageThreadId]);
+
+ for (const apiKeyId of [readOnlyApiKeyId, noOverrideApiKeyId]) {
+ if (isDefined(apiKeyId)) {
+ await global.testDataSource.query(
+ 'DELETE FROM core."apiKey" WHERE id = $1',
+ [apiKeyId],
+ );
+ }
+ }
+
+ for (const roleId of [readOnlyRoleId, noOverrideRoleId]) {
+ if (isDefined(roleId)) {
+ await deleteOneRole({
+ expectToFail: false,
+ input: { idToDelete: roleId },
+ });
+ }
+ }
+ });
+
+ describe('API key whose role overrides message to read-only', () => {
+ it('should allow reading messages', async () => {
+ const response = await makeGraphqlAPIRequest(
+ findOneOperationFactory({
+ objectMetadataSingularName: 'message',
+ gqlFields: MESSAGE_GQL_FIELDS,
+ filter: { id: { eq: messageId } },
+ }),
+ readOnlyApiKeyToken,
+ );
+
+ expect(response.body.errors).toBeUndefined();
+ expect(response.body.data.message.id).toBe(messageId);
+ });
+
+ it('should deny updating a message', async () => {
+ const response = await makeGraphqlAPIRequest(
+ updateOneOperationFactory({
+ objectMetadataSingularName: 'message',
+ gqlFields: MESSAGE_GQL_FIELDS,
+ recordId: messageId,
+ data: { text: 'Updated by a read-only key' },
+ }),
+ readOnlyApiKeyToken,
+ );
+
+ expectPermissionDenied(response);
+ });
+
+ it('should deny soft-deleting a message', async () => {
+ const response = await makeGraphqlAPIRequest(
+ deleteOneOperationFactory({
+ objectMetadataSingularName: 'message',
+ gqlFields: 'id',
+ recordId: messageId,
+ }),
+ readOnlyApiKeyToken,
+ );
+
+ expectPermissionDenied(response);
+ });
+
+ it('should deny destroying a message', async () => {
+ const response = await makeGraphqlAPIRequest(
+ destroyOneOperationFactory({
+ objectMetadataSingularName: 'message',
+ gqlFields: 'id',
+ recordId: messageId,
+ }),
+ readOnlyApiKeyToken,
+ );
+
+ expectPermissionDenied(response);
+ });
+
+ it('should deny creating a message thread', async () => {
+ const response = await makeGraphqlAPIRequest(
+ createOneOperationFactory({
+ objectMetadataSingularName: 'messageThread',
+ gqlFields: 'id',
+ data: { id: messageThreadId },
+ }),
+ readOnlyApiKeyToken,
+ );
+
+ expectPermissionDenied(response);
+ });
+ });
+
+ describe('API key whose role has no override on message', () => {
+ it('should allow updating a message through the system object default', async () => {
+ const response = await makeGraphqlAPIRequest(
+ updateOneOperationFactory({
+ objectMetadataSingularName: 'message',
+ gqlFields: MESSAGE_GQL_FIELDS,
+ recordId: messageId,
+ data: { text: 'Updated through the system object default' },
+ }),
+ noOverrideApiKeyToken,
+ );
+
+ expect(response.body.errors).toBeUndefined();
+ expect(response.body.data.updateMessage.text).toBe(
+ 'Updated through the system object default',
+ );
+ });
+
+ it('should deny updating a standard object', async () => {
+ const response = await makeGraphqlAPIRequest(
+ updateOneOperationFactory({
+ objectMetadataSingularName: 'person',
+ gqlFields: PERSON_GQL_FIELDS,
+ recordId: personId,
+ data: { jobTitle: 'Senior Software Engineer' },
+ }),
+ noOverrideApiKeyToken,
+ );
+
+ expectPermissionDenied(response);
+ });
+ });
+});
diff --git a/packages/twenty-server/test/integration/resend/suites/inbound-email-body-text.integration-spec.ts b/packages/twenty-server/test/integration/resend/suites/inbound-email-body-text.integration-spec.ts
index c9b810e2e0b..69264b4439c 100644
--- a/packages/twenty-server/test/integration/resend/suites/inbound-email-body-text.integration-spec.ts
+++ b/packages/twenty-server/test/integration/resend/suites/inbound-email-body-text.integration-spec.ts
@@ -87,7 +87,9 @@ describe('Inbound email body text (integration)', () => {
return workspaceOrmManager.executeInWorkspaceContext(
async () => {
const message = await workspaceOrmManager
- .getRepository<MessageWorkspaceEntity>('message')
+ .getRepository<MessageWorkspaceEntity>('message', {
+ shouldBypassPermissionChecks: true,
+ })
.createQueryBuilder('message')
.where('message.headerMessageId = :headerMessageId', {
headerMessageId,
diff --git a/packages/twenty-server/test/integration/resend/suites/inbound-email-exclude-group-emails.integration-spec.ts b/packages/twenty-server/test/integration/resend/suites/inbound-email-exclude-group-emails.integration-spec.ts
index 77d0995c23e..d63ec7cc24b 100644
--- a/packages/twenty-server/test/integration/resend/suites/inbound-email-exclude-group-emails.integration-spec.ts
+++ b/packages/twenty-server/test/integration/resend/suites/inbound-email-exclude-group-emails.integration-spec.ts
@@ -82,7 +82,9 @@ describe('Inbound email exclude group emails (integration)', () => {
return workspaceOrmManager.executeInWorkspaceContext(
() =>
workspaceOrmManager
- .getRepository<MessageWorkspaceEntity>('message')
+ .getRepository<MessageWorkspaceEntity>('message', {
+ shouldBypassPermissionChecks: true,
+ })
.createQueryBuilder('message')
.where('message.headerMessageId = :headerMessageId', {
headerMessageId,
diff --git a/packages/twenty-server/test/integration/resend/suites/inbound-email-reply-threading.integration-spec.ts b/packages/twenty-server/test/integration/resend/suites/inbound-email-reply-threading.integration-spec.ts
index ccef10015d8..3eebddf6833 100644
--- a/packages/twenty-server/test/integration/resend/suites/inbound-email-reply-threading.integration-spec.ts
+++ b/packages/twenty-server/test/integration/resend/suites/inbound-email-reply-threading.integration-spec.ts
@@ -95,11 +95,15 @@ describe('Inbound email reply threading (integration)', () => {
const messageId = randomUUID();
await workspaceOrmManager
- .getRepository<MessageThreadWorkspaceEntity>('messageThread')
+ .getRepository<MessageThreadWorkspaceEntity>('messageThread', {
+ shouldBypassPermissionChecks: true,
+ })
.insert({ id: messageThreadId });
await workspaceOrmManager
- .getRepository<MessageWorkspaceEntity>('message')
+ .getRepository<MessageWorkspaceEntity>('message', {
+ shouldBypassPermissionChecks: true,
+ })
.insert({
id: messageId,
headerMessageId: providerMessageId,
@@ -111,6 +115,7 @@ describe('Inbound email reply threading (integration)', () => {
await workspaceOrmManager
.getRepository<MessageChannelMessageAssociationWorkspaceEntity>(
'messageChannelMessageAssociation',
+ { shouldBypassPermissionChecks: true },
)
.insert({
id: randomUUID(),
@@ -155,7 +160,9 @@ describe('Inbound email reply threading (integration)', () => {
const findThreadIdOfMessage = (headerMessageId: string) =>
inWorkspace(async (workspaceOrmManager) => {
const message = await workspaceOrmManager
- .getRepository<MessageWorkspaceEntity>('message')
+ .getRepository<MessageWorkspaceEntity>('message', {
+ shouldBypassPermissionChecks: true,
+ })
.createQueryBuilder('message')
.where('message.headerMessageId = :headerMessageId', {
headerMessageId,