The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix(slack): let a declined link fall through to the member's own email match (#25229)
Abdellatif Anaflous3ec076fe59b8
diff --git a/packages/twenty-apps/public/slack/src/logic-functions/utils/__tests__/resolve-slack-run-as-workspace-member-id.test.ts b/packages/twenty-apps/public/slack/src/logic-functions/utils/__tests__/resolve-slack-run-as-workspace-member-id.test.tsindex 2b8e6ad1851..1522df8a03c 100644--- a/packages/twenty-apps/public/slack/src/logic-functions/utils/__tests__/resolve-slack-run-as-workspace-member-id.test.ts+++ b/packages/twenty-apps/public/slack/src/logic-functions/utils/__tests__/resolve-slack-run-as-workspace-member-id.test.ts@@ -183,13 +183,42 @@ describe('resolveSlackRunAsWorkspaceMemberId', () => {expect(createSlackUserLinkMock).not.toHaveBeenCalled();});- it('should not run as anyone for a declined manual link, even when the email matches', async () => {+ it('should still grant the member their own email match after a declined manual link to another member', async () => {+ // Declining a link that lends another member's access must not cost the+ // Slack user their own identity: once DECLINED is no longer an early+ // return, run-as still resolves their own member by email (which is all+ // their own permissions) and never re-creates or re-updates the link.findSlackUserLinkMock.mockResolvedValue({...MANUAL_LINK,+ workspaceMemberId: 'member-2',consentState: 'DECLINED',});findWorkspaceMemberIdByEmailMock.mockResolvedValue('member-1');+ expect(+ await resolveSlackRunAsWorkspaceMemberId({+ client,+ slackClient,+ identity: IDENTITY,+ }),+ ).toBe('member-1');+ expect(findWorkspaceMemberIdByEmailMock).toHaveBeenCalledTimes(1);+ expect(findWorkspaceMemberIdByEmailMock).toHaveBeenCalledWith(+ client,+ '[email protected]',+ );+ expect(createSlackUserLinkMock).not.toHaveBeenCalled();+ expect(updateSlackUserLinkMock).not.toHaveBeenCalled();+ });++ it('should not fall back to a declined manual link when the user has no own email match', async () => {+ findSlackUserLinkMock.mockResolvedValue({+ ...MANUAL_LINK,+ workspaceMemberId: 'member-2',+ consentState: 'DECLINED',+ });+ findWorkspaceMemberIdByEmailMock.mockResolvedValue(undefined);+expect(await resolveSlackRunAsWorkspaceMemberId({client,@@ -197,7 +226,6 @@ describe('resolveSlackRunAsWorkspaceMemberId', () => {identity: IDENTITY,}),).toBeUndefined();- expect(findWorkspaceMemberIdByEmailMock).not.toHaveBeenCalled();expect(createSlackUserLinkMock).not.toHaveBeenCalled();expect(updateSlackUserLinkMock).not.toHaveBeenCalled();});diff --git a/packages/twenty-apps/public/slack/src/logic-functions/utils/resolve-slack-run-as-workspace-member-id.ts b/packages/twenty-apps/public/slack/src/logic-functions/utils/resolve-slack-run-as-workspace-member-id.tsindex d65ad028291..61f95c98ef3 100644--- a/packages/twenty-apps/public/slack/src/logic-functions/utils/resolve-slack-run-as-workspace-member-id.ts+++ b/packages/twenty-apps/public/slack/src/logic-functions/utils/resolve-slack-run-as-workspace-member-id.ts@@ -71,10 +71,6 @@ export const resolveSlackRunAsWorkspaceMemberId = async ({? existingLink.workspaceMemberId: undefined;}-- if (existingLink?.consentState === SLACK_USER_LINK_CONSENT_STATE.DECLINED) {- return undefined;- }}const linkableEmail = await resolveLinkableEmail({ slackClient, identity });