The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix(page-layout): let the column surface win over the solo presentation (#23412)
Félix Malfait3f0236b590dd
diff --git a/packages/twenty-front/src/modules/page-layout/widgets/utils/__tests__/getWidgetCardVariant.test.ts b/packages/twenty-front/src/modules/page-layout/widgets/utils/__tests__/getWidgetCardVariant.test.tsindex b72a81a34a0..7d69954ed0d 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/utils/__tests__/getWidgetCardVariant.test.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/utils/__tests__/getWidgetCardVariant.test.ts@@ -72,5 +72,23 @@ describe('getWidgetCardVariant', () => {}),).toBe('side-column');});++ it.each([+ ['isInPinnedTab', { isInPinnedTab: true }],+ ['isMobile', { isMobile: true }],+ ['isInSidePanel', { isInSidePanel: true }],+ ])(+ "returns 'side-column' over 'solo' when %s is true",+ (_label, override) => {+ expect(+ getWidgetCardVariant({+ ...baseParams,+ ...override,+ presentation: 'solo',+ pageLayoutType: PageLayoutType.RECORD_PAGE,+ }),+ ).toBe('side-column');+ },+ );});});diff --git a/packages/twenty-front/src/modules/page-layout/widgets/utils/getWidgetCardVariant.ts b/packages/twenty-front/src/modules/page-layout/widgets/utils/getWidgetCardVariant.tsindex 4b7d9243a02..9cf200d5133 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/utils/getWidgetCardVariant.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/utils/getWidgetCardVariant.ts@@ -17,12 +17,16 @@ export const getWidgetCardVariant = ({isMobile,isInSidePanel,}: GetWidgetCardVariantParams): WidgetCardVariant => {+ const isSideColumnContext = isInPinnedTab || isMobile || isInSidePanel;++ if (isSideColumnContext) {+ return 'side-column';+ }+if (presentation === 'solo') {return 'solo';}- const isSideColumnContext = isInPinnedTab || isMobile || isInSidePanel;-switch (pageLayoutType) {case PageLayoutType.DASHBOARD:return 'dashboard';@@ -31,6 +35,6 @@ export const getWidgetCardVariant = ({case PageLayoutType.RECORD_PAGE:case PageLayoutType.RECORD_INDEX:case null:- return isSideColumnContext ? 'side-column' : 'record-page';+ return 'record-page';}};