Skip to content

The open alternative to Salesforce, designed for AI.

fix(server): fail FIND_RECORDS cleanly on an uncomputable filter (#24215)

Thomas Trompette424f9867e18e
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/record-crud/find-records.workflow-action.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/record-crud/find-records.workflow-action.ts
index ef6e1b11ec3..89a10e494a2 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/record-crud/find-records.workflow-action.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/record-crud/find-records.workflow-action.ts
@@ -1,5 +1,6 @@
import { Injectable } from '@nestjs/common';
+import { type RecordGqlOperationFilter } from 'twenty-shared/types';
import {
computeRecordGqlOperationFilter,
isDefined,
@@ -81,19 +82,28 @@ export class FindRecordsWorkflowAction implements WorkflowAction {
const recordFilters = workflowActionInput.filter?.recordFilters;
- const gqlOperationFilter = isDefined(recordFilters)
- ? computeRecordGqlOperationFilter({
- fieldMetadataItems: Object.values(
- flatFieldMetadataMaps.byUniversalIdentifier,
- ).filter(isDefined),
- recordFilters,
- recordFilterGroups:
- workflowActionInput.filter?.recordFilterGroups ?? [],
- filterValueDependencies: {
- timeZone: 'UTC',
- },
- })
- : {};
+ let gqlOperationFilter: RecordGqlOperationFilter;
+
+ try {
+ gqlOperationFilter = isDefined(recordFilters)
+ ? computeRecordGqlOperationFilter({
+ fieldMetadataItems: Object.values(
+ flatFieldMetadataMaps.byUniversalIdentifier,
+ ).filter(isDefined),
+ recordFilters,
+ recordFilterGroups:
+ workflowActionInput.filter?.recordFilterGroups ?? [],
+ filterValueDependencies: {
+ timeZone: 'UTC',
+ },
+ })
+ : {};
+ } catch (error) {
+ throw new WorkflowStepExecutorException(
+ `Filter could not be computed: ${error.message}`,
+ WorkflowStepExecutorExceptionCode.INVALID_STEP_INPUT,
+ );
+ }
if (isNonEmptyArray(recordFilters) && isEmptyObject(gqlOperationFilter)) {
throw new WorkflowStepExecutorException(