Skip to content

The open alternative to Salesforce, designed for AI.

feat: expose CURRENCY field settings (format/decimals) in shared types (#21090)

Joseph Chiang445c6fe9f6b9
diff --git a/packages/twenty-server/src/engine/metadata-modules/field-metadata/types/__tests__/field-metadata-entity.test-type.ts b/packages/twenty-server/src/engine/metadata-modules/field-metadata/types/__tests__/field-metadata-entity.test-type.ts
index 41aa24e0222..4aac61d93aa 100644
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/types/__tests__/field-metadata-entity.test-type.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/types/__tests__/field-metadata-entity.test-type.ts
@@ -114,7 +114,6 @@ type NotDefinedSettings = {
// oxlint-disable-next-line unused-imports/no-unused-vars
type SettingsAssertions = [
- Expect<HasAllProperties<CurrencyFieldMetadata, NotDefinedSettings>>,
Expect<HasAllProperties<FullNameFieldMetadata, NotDefinedSettings>>,
Expect<HasAllProperties<RatingFieldMetadata, NotDefinedSettings>>,
Expect<HasAllProperties<SelectFieldMetadata, NotDefinedSettings>>,
@@ -145,6 +144,16 @@ type SettingsAssertions = [
}
>
>,
+ Expect<
+ HasAllProperties<
+ CurrencyFieldMetadata,
+ {
+ settings: JsonbProperty<
+ FieldMetadataSettingsMapping[FieldMetadataType.CURRENCY]
+ >;
+ }
+ >
+ >,
Expect<
HasAllProperties<
DateFieldMetadata,
diff --git a/packages/twenty-shared/src/types/FieldMetadataSettings.ts b/packages/twenty-shared/src/types/FieldMetadataSettings.ts
index cee9334ef20..1e122a2f28a 100644
--- a/packages/twenty-shared/src/types/FieldMetadataSettings.ts
+++ b/packages/twenty-shared/src/types/FieldMetadataSettings.ts
@@ -20,12 +20,19 @@ export enum DateDisplayFormat {
export type FieldNumberVariant = 'number' | 'percentage';
+export type FieldCurrencyFormat = 'short' | 'full';
+
type FieldMetadataNumberSettings = {
dataType?: NumberDataType;
decimals?: number;
type?: FieldNumberVariant;
};
+type FieldMetadataCurrencySettings = {
+ format?: FieldCurrencyFormat;
+ decimals?: number;
+};
+
type FieldMetadataTextSettings = {
displayedMaxRows?: number;
};
@@ -62,6 +69,7 @@ type FieldMetadataTsVectorSettings = {
export type FieldMetadataSettingsMapping = {
[FieldMetadataType.NUMBER]: FieldMetadataNumberSettings | null;
+ [FieldMetadataType.CURRENCY]: FieldMetadataCurrencySettings | null;
[FieldMetadataType.DATE]: FieldMetadataDateSettings | null;
[FieldMetadataType.DATE_TIME]: FieldMetadataDateTimeSettings | null;
[FieldMetadataType.TEXT]: FieldMetadataTextSettings | null;
diff --git a/packages/twenty-shared/src/types/index.ts b/packages/twenty-shared/src/types/index.ts
index 647a90a57bf..ade278d81b2 100644
--- a/packages/twenty-shared/src/types/index.ts
+++ b/packages/twenty-shared/src/types/index.ts
@@ -106,6 +106,7 @@ export {
} from './FieldMetadataOptions';
export type {
FieldNumberVariant,
+ FieldCurrencyFormat,
FieldMetadataSettingsMapping,
AllFieldMetadataSettings,
FieldMetadataSettings,