The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Keep the Last Contact app's fields off the record timeline (#27019)
Félix Malfait44e9b873a770
diff --git a/packages/twenty-apps/public/last-contact/CHANGELOG.md b/packages/twenty-apps/public/last-contact/CHANGELOG.mdindex d7b9970583c..13b3b425ba9 100644--- a/packages/twenty-apps/public/last-contact/CHANGELOG.md+++ b/packages/twenty-apps/public/last-contact/CHANGELOG.md@@ -1,5 +1,9 @@# Changelog+## 1.7.0++- Keep the app's fields off the record timeline. The app's fields are frequently rewritten during email and meeting syncs, and each write used to add an `updated Last contact` entry to the person, company or opportunity timeline, burying everything else. All 23 fields now declare `isAuditLogged: false`, so their values still update but no timeline activity is recorded for them. Entries written before this version stay on the timeline.+## 1.6.0- Run the backfill inside the post-install function instead of enqueuing one job per record batch. The batch jobs ran on the logic function queue, which runs many jobs at once, so their API calls competed for the same rate limit. Post-install hooks run on the application lifecycle queue, one at a time, and the backfill now pages through people, then opportunities, then companies, one batch after the other, within a single 900-second run. Upgrading from 1.5.0 or earlier runs it once. The per-batch logic functions and the `LAST_CONTACT_BACKFILL_SLEEP_MS` server variable are removed.diff --git a/packages/twenty-apps/public/last-contact/package.json b/packages/twenty-apps/public/last-contact/package.jsonindex aa1b6bd060e..b66a9d910d8 100644--- a/packages/twenty-apps/public/last-contact/package.json+++ b/packages/twenty-apps/public/last-contact/package.json@@ -1,6 +1,6 @@{"name": "@twentyhq/last-contact",- "version": "1.6.0",+ "version": "1.7.0","license": "MIT","engines": {"node": "^24.5.0",diff --git a/packages/twenty-apps/public/last-contact/src/__tests__/fields.test.ts b/packages/twenty-apps/public/last-contact/src/__tests__/fields.test.tsnew file mode 100644index 00000000000..c90a3f9bca0--- /dev/null+++ b/packages/twenty-apps/public/last-contact/src/__tests__/fields.test.ts@@ -0,0 +1,20 @@+/// <reference types="vite/client" />+import { describe, expect, it } from 'vitest';++const FIELD_MODULES = import.meta.glob<{+ default: { success: boolean; config: { isAuditLogged?: boolean } };+}>(['../fields/**/*.ts', '!../fields/**/__tests__/**'], { eager: true });++describe('fields', () => {+ it('finds the field definitions', () => {+ expect(Object.keys(FIELD_MODULES).length).toBeGreaterThan(0);+ });++ it.each(Object.entries(FIELD_MODULES))(+ 'keeps %s off the record timeline',+ (_path, { default: field }) => {+ expect(field.success).toBe(true);+ expect(field.config.isAuditLogged).toBe(false);+ },+ );+});diff --git a/packages/twenty-apps/public/last-contact/src/__tests__/last-contact.integration-test.ts b/packages/twenty-apps/public/last-contact/src/__tests__/last-contact.integration-test.tsindex c17c5cfb868..4295390834f 100644--- a/packages/twenty-apps/public/last-contact/src/__tests__/last-contact.integration-test.ts+++ b/packages/twenty-apps/public/last-contact/src/__tests__/last-contact.integration-test.ts@@ -342,6 +342,59 @@ const getPersonLastContact = async (};};+const getPersonTimelineDiffFieldNames = async (+ client: CoreApiClient,+ personId: string,+): Promise<string[]> => {+ const result = await client.query({+ timelineActivities: {+ __args: { filter: { targetPersonId: { eq: personId } } },+ edges: { node: { properties: true } },+ },+ });++ const edges = (+ result.timelineActivities as {+ edges?: {+ node: { properties?: { diff?: Record<string, unknown> } | null };+ }[];+ } | null+ )?.edges;++ return (edges ?? []).flatMap(({ node }) =>+ Object.keys(node.properties?.diff ?? {}),+ );+};++const TIMELINE_POLL_TIMEOUT_MS = 30_000;+const TIMELINE_POLL_INTERVAL_MS = 500;++// Timeline activities are written asynchronously by the worker, so an empty+// timeline alone proves nothing; a later write to a regular field gives the+// check something it has to wait for.+const waitForPersonTimelineDiffFieldName = async (+ client: CoreApiClient,+ { personId, fieldName }: { personId: string; fieldName: string },+): Promise<string[]> => {+ const deadline = Date.now() + TIMELINE_POLL_TIMEOUT_MS;++ while (Date.now() < deadline) {+ const fieldNames = await getPersonTimelineDiffFieldNames(client, personId);++ if (fieldNames.includes(fieldName)) {+ return fieldNames;+ }++ await new Promise((resolve) =>+ setTimeout(resolve, TIMELINE_POLL_INTERVAL_MS),+ );+ }++ throw new Error(+ `No timeline activity for ${fieldName} on person ${personId} after ${TIMELINE_POLL_TIMEOUT_MS}ms`,+ );+};+const expectColumns = (actual: PersonLastContact,expected: {@@ -673,6 +726,49 @@ describe('last contact handlers', () => {});});+ it('keeps last contact writes off the person timeline', async () => {+ const workspaceMemberId = await getWorkspaceMemberId(client);+ const personId = await createPerson(client);+ createdPersonIds.push(personId);+ const receivedAt = new Date(Date.now() - 5 * DAY_IN_MS).toISOString();++ const messageId = await recordEmail({+ personId,+ workspaceMemberId,+ receivedAt,+ direction: 'outbound',+ });++ expect((await getPersonLastContact(client, personId)).lastEmailId).toBe(+ messageId,+ );++ await client.mutation({+ updatePerson: {+ __args: { id: personId, data: { jobTitle: 'Timeline control' } },+ id: true,+ },+ });++ const timelineFieldNames = await waitForPersonTimelineDiffFieldName(+ client,+ { personId, fieldName: 'jobTitle' },+ );++ for (const fieldName of [+ 'lastContactAt',+ 'lastContactBy',+ 'lastContactById',+ 'lastContactItemMessage',+ 'lastContactItemMessageId',+ 'lastOutboundAt',+ 'lastEmail',+ 'lastEmailId',+ ]) {+ expect(timelineFieldNames).not.toContain(fieldName);+ }+ });+it('computes all columns for a single received (inbound) email', async () => {const workspaceMemberId = await getWorkspaceMemberId(client);const personId = await createPerson(client);diff --git a/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-at.field.ts b/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-at.field.tsindex 7c89bf32334..5322b5cd446 100644--- a/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-at.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-at.field.ts@@ -18,4 +18,5 @@ export default defineField({icon: 'IconClock',isNullable: true,isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-item-calendar-event.field.ts b/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-item-calendar-event.field.tsindex 7346c619e33..13cdb209679 100644--- a/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-item-calendar-event.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-item-calendar-event.field.ts@@ -35,4 +35,5 @@ export default defineField({joinColumnName: 'lastContactItemCalendarEventId',},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-item-message.field.ts b/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-item-message.field.tsindex 9cf4aad6439..ba7b2ca872c 100644--- a/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-item-message.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/company-last-contact-item-message.field.ts@@ -35,4 +35,5 @@ export default defineField({joinColumnName: 'lastContactItemMessageId',},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-at.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-at.field.tsindex 7ea7c287327..3d3763e88c1 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-at.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-at.field.ts@@ -18,4 +18,5 @@ export default defineField({icon: 'IconClock',isNullable: true,isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-by.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-by.field.tsindex f08aa0ad369..b6feb3b32ca 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-by.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-by.field.ts@@ -32,4 +32,5 @@ export default defineField({joinColumnName: 'lastContactById',},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-companies-on-calendar-event.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-companies-on-calendar-event.field.tsindex 5f39b565f6c..369f7c5c3c3 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-companies-on-calendar-event.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-companies-on-calendar-event.field.ts@@ -29,4 +29,5 @@ export default defineField({relationType: RelationType.ONE_TO_MANY,},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-companies-on-message.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-companies-on-message.field.tsindex 59a4e6ac7c8..87d92c24f87 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-companies-on-message.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-companies-on-message.field.ts@@ -29,4 +29,5 @@ export default defineField({relationType: RelationType.ONE_TO_MANY,},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-opportunities-on-calendar-event.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-opportunities-on-calendar-event.field.tsindex 4d45a494791..fa0dbff2df4 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-opportunities-on-calendar-event.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-opportunities-on-calendar-event.field.ts@@ -29,4 +29,5 @@ export default defineField({relationType: RelationType.ONE_TO_MANY,},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-opportunities-on-message.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-opportunities-on-message.field.tsindex efd1d22ccf5..418f64f40c6 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-opportunities-on-message.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-opportunities-on-message.field.ts@@ -29,4 +29,5 @@ export default defineField({relationType: RelationType.ONE_TO_MANY,},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-calendar-event.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-calendar-event.field.tsindex 2669bd60d65..633841b9196 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-calendar-event.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-calendar-event.field.ts@@ -29,4 +29,5 @@ export default defineField({relationType: RelationType.ONE_TO_MANY,},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-message.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-message.field.tsindex 345f1dfb00a..abb8aca4451 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-message.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-message.field.ts@@ -29,4 +29,5 @@ export default defineField({relationType: RelationType.ONE_TO_MANY,},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-workspace-member.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-workspace-member.field.tsindex 06e56b80b67..8c8b7cc00e1 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-workspace-member.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-for-people-on-workspace-member.field.ts@@ -29,4 +29,5 @@ export default defineField({relationType: RelationType.ONE_TO_MANY,},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-item-calendar-event.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-item-calendar-event.field.tsindex 7674db71ecf..b3b1fa75d69 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-item-calendar-event.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-item-calendar-event.field.ts@@ -34,4 +34,5 @@ export default defineField({joinColumnName: 'lastContactItemCalendarEventId',},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-contact-item-message.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-contact-item-message.field.tsindex 384fd024ccb..9b58cd731e8 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-contact-item-message.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-contact-item-message.field.ts@@ -33,4 +33,5 @@ export default defineField({joinColumnName: 'lastContactItemMessageId',},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-email-for-people-on-message.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-email-for-people-on-message.field.tsindex e1aa9d8f634..12d5b10f675 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-email-for-people-on-message.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-email-for-people-on-message.field.ts@@ -28,4 +28,5 @@ export default defineField({relationType: RelationType.ONE_TO_MANY,},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-email.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-email.field.tsindex 6c8af82e1f4..5e0203bb26a 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-email.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-email.field.ts@@ -31,4 +31,5 @@ export default defineField({joinColumnName: 'lastEmailId',},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-inbound-at.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-inbound-at.field.tsindex 2b7ef0bfcd4..d9383b22425 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-inbound-at.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-inbound-at.field.ts@@ -18,4 +18,5 @@ export default defineField({icon: 'IconMessageDown',isNullable: true,isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-meeting-for-people-on-calendar-event.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-meeting-for-people-on-calendar-event.field.tsindex d829c2251f5..50db94a4bcf 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-meeting-for-people-on-calendar-event.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-meeting-for-people-on-calendar-event.field.ts@@ -28,4 +28,5 @@ export default defineField({relationType: RelationType.ONE_TO_MANY,},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-meeting.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-meeting.field.tsindex 36d5efffb74..7abbcc79ff3 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-meeting.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-meeting.field.ts@@ -31,4 +31,5 @@ export default defineField({joinColumnName: 'lastMeetingId',},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/last-outbound-at.field.ts b/packages/twenty-apps/public/last-contact/src/fields/last-outbound-at.field.tsindex f7378bcd77a..4ac398ba68a 100644--- a/packages/twenty-apps/public/last-contact/src/fields/last-outbound-at.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/last-outbound-at.field.ts@@ -18,4 +18,5 @@ export default defineField({icon: 'IconMessageUp',isNullable: true,isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-at.field.ts b/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-at.field.tsindex 6e0fde060f5..b9ffa862598 100644--- a/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-at.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-at.field.ts@@ -18,4 +18,5 @@ export default defineField({icon: 'IconClock',isNullable: true,isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-item-calendar-event.field.ts b/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-item-calendar-event.field.tsindex 60e8280f9d9..e7a167ea725 100644--- a/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-item-calendar-event.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-item-calendar-event.field.ts@@ -35,4 +35,5 @@ export default defineField({joinColumnName: 'lastContactItemCalendarEventId',},isUIEditable: false,+ isAuditLogged: false,});diff --git a/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-item-message.field.ts b/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-item-message.field.tsindex 2d30e469e3e..13418dea633 100644--- a/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-item-message.field.ts+++ b/packages/twenty-apps/public/last-contact/src/fields/opportunity-last-contact-item-message.field.ts@@ -35,4 +35,5 @@ export default defineField({joinColumnName: 'lastContactItemMessageId',},isUIEditable: false,+ isAuditLogged: false,});