Skip to content

The open alternative to Salesforce, designed for AI.

Replace gray dropdown section bands with quiet labels (#28320)

Thomas des Francs45c30bb6ed23
diff --git a/packages/twenty-front/src/modules/navigation-menu-item/edit/components/NavigationMenuItemAddDropdownContent.tsx b/packages/twenty-front/src/modules/navigation-menu-item/edit/components/NavigationMenuItemAddDropdownContent.tsx
index 5369e8c39e7..d1309a61747 100644
--- a/packages/twenty-front/src/modules/navigation-menu-item/edit/components/NavigationMenuItemAddDropdownContent.tsx
+++ b/packages/twenty-front/src/modules/navigation-menu-item/edit/components/NavigationMenuItemAddDropdownContent.tsx
@@ -8,7 +8,7 @@ import { NavigationMenuItemSelectableItem } from '@/navigation-menu-item/edit/co
import { type NavigationMenuItemOption } from '@/navigation-menu-item/edit/types/NavigationMenuItemOption';
import { useSetAtomState } from '@/ui/utilities/state/jotai/hooks/useSetAtomState';
import { selectedNavigationMenuItemIdInEditModeState } from '@/navigation-menu-item/common/states/selectedNavigationMenuItemIdInEditModeState';
-import { useState } from 'react';
+import { Fragment, useState } from 'react';
import { useLingui } from '@lingui/react/macro';
import { isNonEmptyString } from '@sniptt/guards';
import { NavigationMenuItemType } from 'twenty-shared/types';
@@ -201,15 +201,24 @@ export const NavigationMenuItemAddDropdownContent = ({
<Dropdown.Section scrollable>
{groups
.filter((group) => isNonEmptyArray(group.items))
- .map((group) => (
- <Dropdown.Section
- key={group.label}
- label={isNonEmptyString(group.label) ? group.label : undefined}
- >
- {group.items.map((item) => (
- <NavigationMenuItemSelectableItem key={item.id} item={item} />
- ))}
- </Dropdown.Section>
+ .map((group, index) => (
+ <Fragment key={group.label}>
+ {index > 0 && isNonEmptyString(group.label) && (
+ <Dropdown.Separator />
+ )}
+ <Dropdown.Section
+ label={
+ isNonEmptyString(group.label) ? group.label : undefined
+ }
+ >
+ {group.items.map((item) => (
+ <NavigationMenuItemSelectableItem
+ key={item.id}
+ item={item}
+ />
+ ))}
+ </Dropdown.Section>
+ </Fragment>
))}
{!isNonEmptyArray(items) && (
<Dropdown.Empty>{emptyMessage}</Dropdown.Empty>
diff --git a/packages/twenty-front/src/modules/navigation/components/MultiWorkspaceDropdown/internal/MultiWorkspaceDropdownWorkspacesListComponents.tsx b/packages/twenty-front/src/modules/navigation/components/MultiWorkspaceDropdown/internal/MultiWorkspaceDropdownWorkspacesListComponents.tsx
index 2216ee85412..33edb2f02d8 100644
--- a/packages/twenty-front/src/modules/navigation/components/MultiWorkspaceDropdown/internal/MultiWorkspaceDropdownWorkspacesListComponents.tsx
+++ b/packages/twenty-front/src/modules/navigation/components/MultiWorkspaceDropdown/internal/MultiWorkspaceDropdownWorkspacesListComponents.tsx
@@ -24,7 +24,10 @@ export const MultiWorkspaceDropdownWorkspacesListComponents = () => {
<Dropdown.Separator />
<WorkspacesForSignIn searchValue={searchValue} />
{isNonEmptyArray(availableWorkspaces.availableWorkspacesForSignUp) && (
- <WorkspacesForSignUp searchValue={searchValue} />
+ <>
+ <Dropdown.Separator />
+ <WorkspacesForSignUp searchValue={searchValue} />
+ </>
)}
</>
);
diff --git a/packages/twenty-front/src/modules/object-record/advanced-filter/components/AdvancedFilterFieldSelectMenu.tsx b/packages/twenty-front/src/modules/object-record/advanced-filter/components/AdvancedFilterFieldSelectMenu.tsx
index c1beafc0e52..ace96d277f8 100644
--- a/packages/twenty-front/src/modules/object-record/advanced-filter/components/AdvancedFilterFieldSelectMenu.tsx
+++ b/packages/twenty-front/src/modules/object-record/advanced-filter/components/AdvancedFilterFieldSelectMenu.tsx
@@ -113,9 +113,9 @@ export const AdvancedFilterFieldSelectMenu = ({
aria-label={t`Search fields`}
onValueChange={onSearchInputChange}
/>
- {sections.map((section, index) => (
+ {sections.map((section) => (
<Fragment key={section.id}>
- {index > 0 && <Dropdown.Separator />}
+ <Dropdown.Separator />
<Dropdown.Section label={section.label}>
{section.fields.map((fieldMetadataItem) => (
<Dropdown.OptionItem
diff --git a/packages/twenty-front/src/modules/object-record/object-sort-dropdown/components/ObjectSortDropdownButton.tsx b/packages/twenty-front/src/modules/object-record/object-sort-dropdown/components/ObjectSortDropdownButton.tsx
index 92534a62896..ede53995d37 100644
--- a/packages/twenty-front/src/modules/object-record/object-sort-dropdown/components/ObjectSortDropdownButton.tsx
+++ b/packages/twenty-front/src/modules/object-record/object-sort-dropdown/components/ObjectSortDropdownButton.tsx
@@ -181,6 +181,9 @@ export const ObjectSortDropdownButton = () => {
aria-label={t`Search fields`}
onValueChange={setObjectSortDropdownSearchInput}
/>
+ {(shouldShowVisibleFields || shouldShowHiddenFields) && (
+ <Dropdown.Separator />
+ )}
{shouldShowVisibleFields && (
<Dropdown.Section label={t`Visible fields`}>
{visibleFieldMetadataItems.map((fieldMetadataItem, index) => (
diff --git a/packages/twenty-front/src/modules/settings/admin-panel/apps/components/SettingsAdminApps.tsx b/packages/twenty-front/src/modules/settings/admin-panel/apps/components/SettingsAdminApps.tsx
index 666a978f6d9..e55572d59ce 100644
--- a/packages/twenty-front/src/modules/settings/admin-panel/apps/components/SettingsAdminApps.tsx
+++ b/packages/twenty-front/src/modules/settings/admin-panel/apps/components/SettingsAdminApps.tsx
@@ -216,6 +216,7 @@ export const SettingsAdminApps = () => {
checked={showPreInstalledOnly}
>{t`Pre-installed only`}</SettingsRow>
</Dropdown.Section>
+ <Dropdown.Separator />
<Dropdown.Section label={t`Source`}>
{SOURCE_TYPE_FILTER_OPTIONS.map(({ sourceType, label }) => (
<SettingsRow
@@ -227,6 +228,7 @@ export const SettingsAdminApps = () => {
</SettingsRow>
))}
</Dropdown.Section>
+ <Dropdown.Separator />
<Dropdown.Section label={t`Listed`}>
<SettingsRow
onCheckedChange={() =>
@@ -245,6 +247,7 @@ export const SettingsAdminApps = () => {
checked={isListedFilter === false}
>{t`Not listed`}</SettingsRow>
</Dropdown.Section>
+ <Dropdown.Separator />
<Dropdown.Section label={t`Configured`}>
<SettingsRow
onCheckedChange={() =>
diff --git a/packages/twenty-front/src/modules/settings/roles/role-permissions/object-level-permissions/record-level-permissions/components/SettingsRolePermissionsObjectLevelRecordLevelPermissionFieldSelectFieldMenu.tsx b/packages/twenty-front/src/modules/settings/roles/role-permissions/object-level-permissions/record-level-permissions/components/SettingsRolePermissionsObjectLevelRecordLevelPermissionFieldSelectFieldMenu.tsx
index 3925374c646..8870b50b590 100644
--- a/packages/twenty-front/src/modules/settings/roles/role-permissions/object-level-permissions/record-level-permissions/components/SettingsRolePermissionsObjectLevelRecordLevelPermissionFieldSelectFieldMenu.tsx
+++ b/packages/twenty-front/src/modules/settings/roles/role-permissions/object-level-permissions/record-level-permissions/components/SettingsRolePermissionsObjectLevelRecordLevelPermissionFieldSelectFieldMenu.tsx
@@ -136,6 +136,7 @@ export const SettingsRolePermissionsObjectLevelRecordLevelPermissionFieldSelectF
placeholder={t`Search fields`}
aria-label={t`Search fields`}
/>
+ <Dropdown.Separator />
<Dropdown.Section label={t`Fields`}>
{filteredFieldMetadataItems.map((fieldMetadataItem) => (
<Dropdown.OptionItem
diff --git a/packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuSectionLabel.tsx b/packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuSectionLabel.tsx
index a2d1bc1e287..8c3ff011c19 100644
--- a/packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuSectionLabel.tsx
+++ b/packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuSectionLabel.tsx
@@ -2,16 +2,12 @@ import { themeCssVariables } from 'twenty-ui/theme';
import { styled } from '@linaria/react';
const StyledDropdownMenuSectionLabel = styled.div`
- align-items: center;
- background-color: ${themeCssVariables.background.transparent.lighter};
box-sizing: border-box;
color: ${themeCssVariables.font.color.tertiary};
- display: flex;
- font-size: ${themeCssVariables.font.size.xxs};
- justify-content: flex-start;
- min-height: 20px;
- padding-left: ${themeCssVariables.spacing[2]};
- padding-right: ${themeCssVariables.spacing[2]};
+ font-size: ${themeCssVariables.font.size.xs};
+ font-weight: ${themeCssVariables.font.weight.semiBold};
+ line-height: ${themeCssVariables.text.lineHeight.md};
+ padding: ${themeCssVariables.spacing[2]} ${themeCssVariables.spacing[2]} 0;
user-select: none;
width: 100%;
`;
diff --git a/packages/twenty-front/src/modules/ui/suggestion/components/SuggestionMenu.tsx b/packages/twenty-front/src/modules/ui/suggestion/components/SuggestionMenu.tsx
index 0798766f363..2cb3ff57572 100644
--- a/packages/twenty-front/src/modules/ui/suggestion/components/SuggestionMenu.tsx
+++ b/packages/twenty-front/src/modules/ui/suggestion/components/SuggestionMenu.tsx
@@ -18,6 +18,7 @@ import {
import { RootStackingContextZIndices } from '@/ui/layout/constants/RootStackingContextZIndices';
import { DropdownMenuSectionLabel } from '@/ui/layout/dropdown/components/DropdownMenuSectionLabel';
import { OverlayMenuList } from '@/ui/layout/overlay/components/OverlayMenuList';
+import { OverlayMenuListSeparator } from '@/ui/layout/overlay/components/OverlayMenuListSeparator';
import { OverlayContainer } from '@/ui/layout/overlay/components/OverlayContainer';
import { SuggestionItemPreviewTooltip } from '@/ui/suggestion/components/SuggestionItemPreviewTooltip';
import type { SuggestionMenuProps } from '@/ui/suggestion/types/SuggestionMenuProps';
@@ -223,6 +224,7 @@ const SuggestionMenuInner = <TItem,>(
event.preventDefault();
}}
>
+ {isFirstOfSection && index > 0 && <OverlayMenuListSeparator />}
{isFirstOfSection && (
<DropdownMenuSectionLabel label={section.label} />
)}
diff --git a/packages/twenty-ui/src/components/navigation/Dropdown/Dropdown.module.scss b/packages/twenty-ui/src/components/navigation/Dropdown/Dropdown.module.scss
index b1a78424a73..e6ea291688b 100644
--- a/packages/twenty-ui/src/components/navigation/Dropdown/Dropdown.module.scss
+++ b/packages/twenty-ui/src/components/navigation/Dropdown/Dropdown.module.scss
@@ -27,14 +27,11 @@
}
.groupLabel {
- background: var(--t-background-transparent-lighter);
color: var(--t-font-color-tertiary);
- font-size: var(--t-font-size-xxs);
- padding-inline: var(--t-spacing-2);
- margin-inline: calc(-1 * var(--t-spacing-1));
- min-block-size: 20px;
- display: flex;
- align-items: center;
+ font-size: var(--t-font-size-xs);
+ font-weight: var(--t-font-weight-semi-bold);
+ line-height: var(--t-text-line-height-md);
+ padding: var(--t-spacing-1);
user-select: none;
}