Skip to content

The open alternative to Salesforce, designed for AI.

Restore light description color on menu items (#29239)

Thomas des Francs4a7e9413e511
diff --git a/packages/twenty-ui/src/components/navigation/ListItemButton/__stories__/ListItemButton.stories.tsx b/packages/twenty-ui/src/components/navigation/ListItemButton/__stories__/ListItemButton.stories.tsx
index d5311633852..329e8a7bc63 100644
--- a/packages/twenty-ui/src/components/navigation/ListItemButton/__stories__/ListItemButton.stories.tsx
+++ b/packages/twenty-ui/src/components/navigation/ListItemButton/__stories__/ListItemButton.stories.tsx
@@ -2,7 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { ListItemButton } from '@ui/components/navigation/ListItemButton/ListItemButton';
import { IconCopy, IconUser } from '@ui/icon';
import { Button } from '@ui/primitives/input/Button/Button';
-import { ComponentDecorator } from '@ui/testing';
+import { A11Y_DEFER_COLOR_CONTRAST, ComponentDecorator } from '@ui/testing';
const ROW_STYLE = { width: 280 };
const SIBLING_STYLE = { display: 'flex', alignItems: 'center', gap: 8 };
@@ -12,6 +12,7 @@ const meta: Meta<typeof ListItemButton> = {
title: 'UI/Components/Navigation/ListItemButton',
component: ListItemButton,
decorators: [ComponentDecorator],
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
children: 'Duplicate',
startIcon: <IconCopy />,
diff --git a/packages/twenty-ui/src/primitives/navigation/ListItem/ListItem.module.scss b/packages/twenty-ui/src/primitives/navigation/ListItem/ListItem.module.scss
index 99919b85187..f0ba620b38b 100644
--- a/packages/twenty-ui/src/primitives/navigation/ListItem/ListItem.module.scss
+++ b/packages/twenty-ui/src/primitives/navigation/ListItem/ListItem.module.scss
@@ -1,6 +1,5 @@
.root {
--tw-list-item-color: var(--t-font-color-secondary);
- --tw-list-item-description-color: var(--t-font-color-secondary);
--tw-list-item-background: transparent;
--tw-list-item-hover-background: var(--t-background-transparent-light);
@@ -53,7 +52,6 @@
&[data-disabled] {
--tw-list-item-color: var(--t-font-color-tertiary);
- --tw-list-item-description-color: var(--t-font-color-light);
--tw-list-item-hover-background: transparent;
cursor: default;
@@ -103,7 +101,7 @@
}
.description {
- color: var(--tw-list-item-description-color);
+ color: var(--t-font-color-light);
min-inline-size: 0;
overflow: hidden;
text-overflow: ellipsis;
diff --git a/packages/twenty-ui/src/primitives/navigation/ListItem/__stories__/ListItemMultiline.stories.tsx b/packages/twenty-ui/src/primitives/navigation/ListItem/__stories__/ListItemMultiline.stories.tsx
index ae3bb3cd051..ef96405bb59 100644
--- a/packages/twenty-ui/src/primitives/navigation/ListItem/__stories__/ListItemMultiline.stories.tsx
+++ b/packages/twenty-ui/src/primitives/navigation/ListItem/__stories__/ListItemMultiline.stories.tsx
@@ -21,7 +21,7 @@ const onEndAction = fn();
const meta: Meta<typeof ListItem> = {
title: 'UI/Navigation/ListItem/Multiline',
component: ListItem,
- parameters: { container: { width: 560 } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST, container: { width: 560 } },
args: {
children: 'Quarterly planning',
description:
@@ -305,7 +305,6 @@ export const VisualRegression: CatalogStory<Story, typeof ListItem> = {
selectionAppearance: 'accent',
},
parameters: {
- a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{ name: '', values: [''], props: () => ({}) },
@@ -341,7 +340,6 @@ export const SelectionAppearance: CatalogStory<Story, typeof ListItem> = {
description: 'Team planning',
},
parameters: {
- a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{