Skip to content

The open alternative to Salesforce, designed for AI.

Stop requiring workspace SECURITY permission on admin panel resolvers (#28305)

Charles Bochet4b4acf88cbb5
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-ai-provider.resolver.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-ai-provider.resolver.ts
index 44ab5589f13..68d63e80986 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-ai-provider.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-ai-provider.resolver.ts
@@ -4,7 +4,6 @@ import { UseFilters, UseGuards, UsePipes } from '@nestjs/common';
import { Args, Mutation, Query } from '@nestjs/graphql';
import GraphQLJSON from 'graphql-type-json';
-import { PermissionFlagType } from 'twenty-shared/constants';
import { AdminResolver } from 'src/engine/api/graphql/graphql-config/decorators/admin-resolver.decorator';
import { CustomAiProviderAccessDTO } from 'src/engine/core-modules/admin-panel/dtos/custom-ai-provider-access.dto';
@@ -16,7 +15,7 @@ import { ResolverValidationPipe } from 'src/engine/core-modules/graphql/pipes/re
import { ConfigVariableGraphqlApiExceptionFilter } from 'src/engine/core-modules/twenty-config/filters/config-variable-graphql-api-exception.filter';
import { AdminPanelGuard } from 'src/engine/guards/admin-panel-guard';
import { AuthPrincipalGuard } from 'src/engine/guards/auth-principal.guard';
-import { SettingsPermissionGuard } from 'src/engine/guards/settings-permission.guard';
+import { NoPermissionGuard } from 'src/engine/guards/no-permission.guard';
import { ModelsDevModelSuggestionDTO } from 'src/engine/core-modules/admin-panel/dtos/models-dev-model-suggestion.dto';
import { ModelsDevProviderSuggestionDTO } from 'src/engine/core-modules/admin-panel/dtos/models-dev-provider-suggestion.dto';
import { ModelsDevCatalogService } from 'src/engine/metadata-modules/ai/ai-models/services/models-dev-catalog.service';
@@ -41,7 +40,7 @@ import { ModelsDevCatalogService } from 'src/engine/metadata-modules/ai/ai-model
oauthClient: false,
application: false,
}),
- SettingsPermissionGuard(PermissionFlagType.SECURITY),
+ NoPermissionGuard,
)
export class AdminPanelAiProviderResolver {
constructor(
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-usage-limit.resolver.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-usage-limit.resolver.ts
index 8a3a7c81f0c..8f7f98b0552 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-usage-limit.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-usage-limit.resolver.ts
@@ -1,8 +1,6 @@
import { UseFilters, UseGuards, UsePipes } from '@nestjs/common';
import { Args, Mutation, Query } from '@nestjs/graphql';
-import { PermissionFlagType } from 'twenty-shared/constants';
-
import { AdminResolver } from 'src/engine/api/graphql/graphql-config/decorators/admin-resolver.decorator';
import {
AdminPanelCreateUsageLimitInput,
@@ -23,7 +21,7 @@ import { UsageLimitService } from 'src/engine/core-modules/usage-limit/services/
import { fromUsageLimitEntityToDto } from 'src/engine/core-modules/usage-limit/utils/from-usage-limit-entity-to-dto.util';
import { AdminPanelGuard } from 'src/engine/guards/admin-panel-guard';
import { AuthPrincipalGuard } from 'src/engine/guards/auth-principal.guard';
-import { SettingsPermissionGuard } from 'src/engine/guards/settings-permission.guard';
+import { NoPermissionGuard } from 'src/engine/guards/no-permission.guard';
@UsePipes(ResolverValidationPipe)
@AdminResolver()
@@ -44,7 +42,7 @@ import { SettingsPermissionGuard } from 'src/engine/guards/settings-permission.g
oauthClient: false,
application: false,
}),
- SettingsPermissionGuard(PermissionFlagType.SECURITY),
+ NoPermissionGuard,
AdminPanelGuard,
)
export class AdminPanelUsageLimitResolver {
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel.resolver.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel.resolver.ts
index 9c1e08ebda7..7c66dbc3ea7 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel.resolver.ts
@@ -5,7 +5,6 @@ import { InjectRepository } from '@nestjs/typeorm';
import { type GraphQLResolveInfo } from 'graphql';
import GraphQLJSON from 'graphql-type-json';
import { AI_MODEL_TIERS } from 'twenty-shared/ai';
-import { PermissionFlagType } from 'twenty-shared/constants';
import { isDefined } from 'twenty-shared/utils';
import { In, type Repository } from 'typeorm';
@@ -95,8 +94,8 @@ import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorat
import { AdminPanelGuard } from 'src/engine/guards/admin-panel-guard';
import { AdminPanelOrImpersonateGuard } from 'src/engine/guards/admin-panel-or-impersonate.guard';
import { AuthPrincipalGuard } from 'src/engine/guards/auth-principal.guard';
+import { NoPermissionGuard } from 'src/engine/guards/no-permission.guard';
import { ServerLevelImpersonateGuard } from 'src/engine/guards/server-level-impersonate.guard';
-import { SettingsPermissionGuard } from 'src/engine/guards/settings-permission.guard';
import { MODEL_FAMILY_LABELS } from 'src/engine/metadata-modules/ai/ai-models/constants/model-family-labels.const';
import { AiModelRegistryService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
import { AiModelTier } from 'src/engine/metadata-modules/ai/ai-models/types/ai-model-tier.enum';
@@ -128,7 +127,7 @@ import { getAvailableEfforts } from 'src/engine/metadata-modules/ai/ai-models/ut
oauthClient: false,
application: false,
}),
- SettingsPermissionGuard(PermissionFlagType.SECURITY),
+ NoPermissionGuard,
)
export class AdminPanelResolver {
constructor(
diff --git a/packages/twenty-server/test/integration/graphql/suites/admin-panel/__snapshots__/failing-admin-panel-application-registration-variables.integration-spec.ts.snap b/packages/twenty-server/test/integration/graphql/suites/admin-panel/__snapshots__/failing-admin-panel-application-registration-variables.integration-spec.ts.snap
index e19e854f2b0..c3cdabb309e 100644
--- a/packages/twenty-server/test/integration/graphql/suites/admin-panel/__snapshots__/failing-admin-panel-application-registration-variables.integration-spec.ts.snap
+++ b/packages/twenty-server/test/integration/graphql/suites/admin-panel/__snapshots__/failing-admin-panel-application-registration-variables.integration-spec.ts.snap
@@ -1,25 +1,21 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`Admin panel application registration variables should fail without the SECURITY permission flag should refuse to read them 1`] = `
+exports[`Admin panel application registration variables should fail without server admin access should refuse to read them 1`] = `
{
"extensions": {
"code": "FORBIDDEN",
- "subCode": "PERMISSION_DENIED",
- "userFriendlyMessage": "User does not have permission.",
+ "userFriendlyMessage": "An error occurred.",
},
- "message": "Entity performing the request does not have permission",
- "name": "ForbiddenError",
+ "message": "Forbidden resource",
}
`;
-exports[`Admin panel application registration variables should fail without the SECURITY permission flag should refuse to write them and leave the stored value untouched 1`] = `
+exports[`Admin panel application registration variables should fail without server admin access should refuse to write them and leave the stored value untouched 1`] = `
{
"extensions": {
"code": "FORBIDDEN",
- "subCode": "PERMISSION_DENIED",
- "userFriendlyMessage": "User does not have permission.",
+ "userFriendlyMessage": "An error occurred.",
},
- "message": "Entity performing the request does not have permission",
- "name": "ForbiddenError",
+ "message": "Forbidden resource",
}
`;
diff --git a/packages/twenty-server/test/integration/graphql/suites/admin-panel/admin-panel-application-registration-stats.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/admin-panel/admin-panel-application-registration-stats.integration-spec.ts
index 40c57eadd01..ab7155b8c20 100644
--- a/packages/twenty-server/test/integration/graphql/suites/admin-panel/admin-panel-application-registration-stats.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/admin-panel/admin-panel-application-registration-stats.integration-spec.ts
@@ -5,7 +5,7 @@ import { type DataSource } from 'typeorm';
import { ClickHouseService } from 'src/database/clickhouse/clickhouse.service';
import { getAppProviderByClassName } from 'test/integration/utils/get-app-provider-by-class-name.util';
-import { makeAdminPanelApiRequestWithGuestRole } from 'test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-with-guest-role.util';
+import { makeAdminPanelApiRequestAsNonServerAdmin } from 'test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-as-non-server-admin.util';
import { makeAdminPanelApiRequest } from 'test/integration/twenty-config/utils/make-admin-panel-api-request.util';
import {
@@ -352,7 +352,7 @@ describe('Admin panel application registration stats and installed workspaces (i
const cacheHits = await getQueryCacheHits();
expect((await findStats()).body.data).toEqual(response.body.data);
expect(await getQueryCacheHits()).toBeGreaterThan(cacheHits);
- const forbidden = await makeAdminPanelApiRequestWithGuestRole({
+ const forbidden = await makeAdminPanelApiRequestAsNonServerAdmin({
query: findCreditsUsed,
variables: { id: applicationRegistrationId, ...period },
});
@@ -456,8 +456,8 @@ describe('Admin panel application registration stats and installed workspaces (i
).not.toContain(DELETED_WORKSPACE_ONLY_VERSION);
});
- it('rejects a caller without the SECURITY permission flag', async () => {
- const response = await makeAdminPanelApiRequestWithGuestRole({
+ it('rejects a caller without server admin access', async () => {
+ const response = await makeAdminPanelApiRequestAsNonServerAdmin({
query: FIND_STATS,
variables: { id: applicationRegistrationId },
});
@@ -571,8 +571,8 @@ describe('Admin panel application registration stats and installed workspaces (i
);
});
- it('rejects a caller without the SECURITY permission flag', async () => {
- const response = await makeAdminPanelApiRequestWithGuestRole({
+ it('rejects a caller without server admin access', async () => {
+ const response = await makeAdminPanelApiRequestAsNonServerAdmin({
query: FIND_INSTALLED_WORKSPACES,
variables: { input: { id: applicationRegistrationId, offset: 0 } },
});
@@ -620,8 +620,8 @@ describe('Admin panel application registration stats and installed workspaces (i
expect(result.registrations).toHaveLength(0);
});
- it('rejects a caller without the SECURITY permission flag', async () => {
- const response = await makeAdminPanelApiRequestWithGuestRole({
+ it('rejects a caller without server admin access', async () => {
+ const response = await makeAdminPanelApiRequestAsNonServerAdmin({
query: FIND_ALL_REGISTRATIONS,
variables: { limit: 25, offset: 0 },
});
diff --git a/packages/twenty-server/test/integration/graphql/suites/admin-panel/failing-admin-panel-application-registration-variables.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/admin-panel/failing-admin-panel-application-registration-variables.integration-spec.ts
index b8c3e62f555..781a1419aab 100644
--- a/packages/twenty-server/test/integration/graphql/suites/admin-panel/failing-admin-panel-application-registration-variables.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/admin-panel/failing-admin-panel-application-registration-variables.integration-spec.ts
@@ -2,6 +2,7 @@ import {
findAdminApplicationRegistrationVariables,
updateAdminApplicationRegistrationVariable,
} from 'test/integration/graphql/suites/admin-panel/utils/admin-application-registration-variable-api.util';
+import { getNonServerAdminAccessToken } from 'test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-as-non-server-admin.util';
import { expectOneNotInternalServerErrorSnapshot } from 'test/integration/graphql/utils/expect-one-not-internal-server-error-snapshot.util';
import { isDefined } from 'twenty-shared/utils';
@@ -12,10 +13,9 @@ import {
type SeededRegistration,
} from 'test/integration/graphql/suites/admin-panel/utils/seed-registration-with-variables.util';
-/* global APPLE_PHIL_GUEST_ACCESS_TOKEN */
-
-describe('Admin panel application registration variables should fail without the SECURITY permission flag', () => {
+describe('Admin panel application registration variables should fail without server admin access', () => {
let registration: SeededRegistration;
+ let nonServerAdminAccessToken: string;
const normalizeMessage = (message: string) =>
message
@@ -32,6 +32,7 @@ describe('Admin panel application registration variables should fail without the
registration = await seedRegistrationOwnedByAnotherWorkspace(
'failing-admin-panel-variables-registration',
);
+ nonServerAdminAccessToken = await getNonServerAdminAccessToken();
});
afterAll(async () => {
@@ -45,7 +46,7 @@ describe('Admin panel application registration variables should fail without the
it('should refuse to read them', async () => {
const { data, errors } = await findAdminApplicationRegistrationVariables({
applicationRegistrationId: registration.applicationRegistrationId,
- token: APPLE_PHIL_GUEST_ACCESS_TOKEN,
+ token: nonServerAdminAccessToken,
});
expectOneNotInternalServerErrorSnapshot({ errors, normalizeMessage });
@@ -60,7 +61,7 @@ describe('Admin panel application registration variables should fail without the
const { data, errors } = await updateAdminApplicationRegistrationVariable({
id: registration.secretVariableId,
value: 'value-from-a-caller-without-the-flag',
- token: APPLE_PHIL_GUEST_ACCESS_TOKEN,
+ token: nonServerAdminAccessToken,
});
expectOneNotInternalServerErrorSnapshot({ errors, normalizeMessage });
diff --git a/packages/twenty-server/test/integration/graphql/suites/admin-panel/successful-admin-panel-server-admin-without-security-permission.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/admin-panel/successful-admin-panel-server-admin-without-security-permission.integration-spec.ts
new file mode 100644
index 00000000000..e89cbe26cfb
--- /dev/null
+++ b/packages/twenty-server/test/integration/graphql/suites/admin-panel/successful-admin-panel-server-admin-without-security-permission.integration-spec.ts
@@ -0,0 +1,64 @@
+import { gql } from 'graphql-tag';
+import { makeAdminPanelApiRequest } from 'test/integration/twenty-config/utils/make-admin-panel-api-request.util';
+
+import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';
+
+/* global APPLE_PHIL_GUEST_ACCESS_TOKEN */
+
+// Phil is a full server admin whose guest role lacks the SECURITY permission.
+describe('Admin panel access for a server admin without the SECURITY permission', () => {
+ it('should load server admins', async () => {
+ const response = await makeAdminPanelApiRequest(
+ {
+ query: gql`
+ query GetServerAdmins {
+ getServerAdmins {
+ id
+ }
+ }
+ `,
+ },
+ APPLE_PHIL_GUEST_ACCESS_TOKEN,
+ );
+
+ expect(response.body.errors).toBeUndefined();
+ expect(response.body.data.getServerAdmins.length).toBeGreaterThan(0);
+ });
+
+ it('should load AI providers', async () => {
+ const response = await makeAdminPanelApiRequest(
+ {
+ query: gql`
+ query GetAiProviders {
+ getAiProviders
+ }
+ `,
+ },
+ APPLE_PHIL_GUEST_ACCESS_TOKEN,
+ );
+
+ expect(response.body.errors).toBeUndefined();
+ expect(response.body.data.getAiProviders).toBeDefined();
+ });
+
+ it('should load workspace usage limits', async () => {
+ const response = await makeAdminPanelApiRequest(
+ {
+ query: gql`
+ query WorkspaceUsageLimits($workspaceId: UUID!) {
+ workspaceUsageLimits(workspaceId: $workspaceId) {
+ defaults {
+ limitValue
+ }
+ }
+ }
+ `,
+ variables: { workspaceId: SEED_APPLE_WORKSPACE_ID },
+ },
+ APPLE_PHIL_GUEST_ACCESS_TOKEN,
+ );
+
+ expect(response.body.errors).toBeUndefined();
+ expect(response.body.data.workspaceUsageLimits.defaults).toBeDefined();
+ });
+});
diff --git a/packages/twenty-server/test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-as-non-server-admin.util.ts b/packages/twenty-server/test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-as-non-server-admin.util.ts
new file mode 100644
index 00000000000..33f67855cfa
--- /dev/null
+++ b/packages/twenty-server/test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-as-non-server-admin.util.ts
@@ -0,0 +1,29 @@
+import { type ASTNode, print } from 'graphql';
+import request from 'supertest';
+import { getAccessTokenForCredentials } from 'test/integration/graphql/utils/get-access-token-for-credentials.util';
+
+/* global APP_PORT */
+
+type GraphqlOperation = {
+ query: ASTNode;
+ variables?: Record<string, unknown>;
+};
+
+// Scott is the only seeded user without canAccessFullAdminPanel or canImpersonate.
+export const getNonServerAdminAccessToken = () =>
+ getAccessTokenForCredentials({ email: '[email protected]' });
+
+export const makeAdminPanelApiRequestAsNonServerAdmin = async (
+ graphqlOperation: GraphqlOperation,
+) => {
+ const accessToken = await getNonServerAdminAccessToken();
+
+ return request(`http://localhost:${APP_PORT}`)
+ .post('/admin-panel')
+ .set('Authorization', `Bearer ${accessToken}`)
+ .send({
+ query: print(graphqlOperation.query),
+ variables: graphqlOperation.variables || {},
+ })
+ .expect(200);
+};
diff --git a/packages/twenty-server/test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-with-guest-role.util.ts b/packages/twenty-server/test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-with-guest-role.util.ts
deleted file mode 100644
index 0dbfe57c635..00000000000
--- a/packages/twenty-server/test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-with-guest-role.util.ts
+++ /dev/null
@@ -1,26 +0,0 @@
-import { type ASTNode, print } from 'graphql';
-import request from 'supertest';
-
-/* global APP_PORT, APPLE_PHIL_GUEST_ACCESS_TOKEN */
-
-type GraphqlOperation = {
- query: ASTNode;
- variables?: Record<string, unknown>;
-};
-
-// Hits the admin GraphQL schema (/admin-panel) with a guest user that lacks the
-// SECURITY permission flag, so it can assert the resolver-level guards reject it.
-export const makeAdminPanelApiRequestWithGuestRole = (
- graphqlOperation: GraphqlOperation,
-) => {
- const client = request(`http://localhost:${APP_PORT}`);
-
- return client
- .post('/admin-panel')
- .set('Authorization', `Bearer ${APPLE_PHIL_GUEST_ACCESS_TOKEN}`)
- .send({
- query: print(graphqlOperation.query),
- variables: graphqlOperation.variables || {},
- })
- .expect(200);
-};
diff --git a/packages/twenty-server/test/integration/graphql/suites/admin-panel/workspace-usage-limits.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/admin-panel/workspace-usage-limits.integration-spec.ts
index 6cb9cadf21a..e9fb2d26dd9 100644
--- a/packages/twenty-server/test/integration/graphql/suites/admin-panel/workspace-usage-limits.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/admin-panel/workspace-usage-limits.integration-spec.ts
@@ -1,4 +1,4 @@
-import { makeAdminPanelApiRequestWithGuestRole } from 'test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-with-guest-role.util';
+import { makeAdminPanelApiRequestAsNonServerAdmin } from 'test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-as-non-server-admin.util';
import { makeAdminPanelApiRequest } from 'test/integration/twenty-config/utils/make-admin-panel-api-request.util';
import { getAppProviderByClassName } from 'test/integration/utils/get-app-provider-by-class-name.util';
import { getCoreRepository } from 'test/integration/utils/get-core-repository.util';
@@ -264,8 +264,8 @@ describe('Workspace usage limits from the admin panel', () => {
});
});
- it('refuses a user without the security permission', async () => {
- const response = await makeAdminPanelApiRequestWithGuestRole({
+ it('refuses a user without server admin access', async () => {
+ const response = await makeAdminPanelApiRequestAsNonServerAdmin({
query: WORKSPACE_USAGE_LIMITS,
variables: { workspaceId: SEED_APPLE_WORKSPACE_ID },
});
diff --git a/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/application-registration-instance-flags.integration-spec.ts.snap b/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/application-registration-instance-flags.integration-spec.ts.snap
index 928128258b9..73536e3ac66 100644
--- a/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/application-registration-instance-flags.integration-spec.ts.snap
+++ b/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/application-registration-instance-flags.integration-spec.ts.snap
@@ -1,14 +1,12 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`Application registration instance flags (integration) updateAdminApplicationRegistration should fail for a caller without the SECURITY permission flag 1`] = `
+exports[`Application registration instance flags (integration) updateAdminApplicationRegistration should fail for a caller without server admin access 1`] = `
{
"extensions": {
"code": "FORBIDDEN",
- "subCode": "PERMISSION_DENIED",
- "userFriendlyMessage": "User does not have permission.",
+ "userFriendlyMessage": "An error occurred.",
},
- "message": "Entity performing the request does not have permission",
- "name": "ForbiddenError",
+ "message": "Forbidden resource",
}
`;
diff --git a/packages/twenty-server/test/integration/metadata/suites/application/application-registration-instance-flags.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/application/application-registration-instance-flags.integration-spec.ts
index 5721849780d..21c09771e66 100644
--- a/packages/twenty-server/test/integration/metadata/suites/application/application-registration-instance-flags.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/application/application-registration-instance-flags.integration-spec.ts
@@ -196,13 +196,13 @@ describe('Application registration instance flags (integration)', () => {
});
describe('updateAdminApplicationRegistration', () => {
- it('should fail for a caller without the SECURITY permission flag', async () => {
+ it('should fail for a caller without server admin access', async () => {
const registrationId = registrationIdByOwnership.owned;
const { errors } = await updateAdminApplicationRegistration({
id: registrationId,
update: { isListed: true, isPreInstalled: true, isVetted: true },
- withGuestRole: true,
+ asNonServerAdmin: true,
expectToFail: true,
});
diff --git a/packages/twenty-server/test/integration/metadata/suites/application/utils/update-admin-application-registration.util.ts b/packages/twenty-server/test/integration/metadata/suites/application/utils/update-admin-application-registration.util.ts
index 556046a1dad..2b19b13e577 100644
--- a/packages/twenty-server/test/integration/metadata/suites/application/utils/update-admin-application-registration.util.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/application/utils/update-admin-application-registration.util.ts
@@ -1,4 +1,4 @@
-import { makeAdminPanelApiRequestWithGuestRole } from 'test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-with-guest-role.util';
+import { makeAdminPanelApiRequestAsNonServerAdmin } from 'test/integration/graphql/suites/admin-panel/utils/make-admin-panel-api-request-as-non-server-admin.util';
import {
type UpdateAdminApplicationRegistrationFactoryInput,
updateAdminApplicationRegistrationQueryFactory,
@@ -19,10 +19,10 @@ export const updateAdminApplicationRegistration = async ({
id,
update,
expectToFail = false,
- withGuestRole = false,
+ asNonServerAdmin = false,
}: UpdateAdminApplicationRegistrationFactoryInput & {
expectToFail?: boolean;
- withGuestRole?: boolean;
+ asNonServerAdmin?: boolean;
}): CommonResponseBody<{
updateAdminApplicationRegistration: UpdateAdminApplicationRegistrationResult;
}> => {
@@ -31,8 +31,8 @@ export const updateAdminApplicationRegistration = async ({
update,
});
- const response = withGuestRole
- ? await makeAdminPanelApiRequestWithGuestRole(graphqlOperation)
+ const response = asNonServerAdmin
+ ? await makeAdminPanelApiRequestAsNonServerAdmin(graphqlOperation)
: await makeAdminPanelApiRequest(graphqlOperation);
if (expectToFail === true) {