The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Look workflow versions up through their core workflow (#27477)
Thomas Trompette4ce02b576e2d
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/services/core-workflow-version-list.service.ts b/packages/twenty-server/src/engine/core-modules/workflow/services/core-workflow-version-list.service.tsindex 4c837fa5a7a..c9243b819e9 100644--- a/packages/twenty-server/src/engine/core-modules/workflow/services/core-workflow-version-list.service.ts+++ b/packages/twenty-server/src/engine/core-modules/workflow/services/core-workflow-version-list.service.ts@@ -41,8 +41,11 @@ export class CoreWorkflowVersionListService {{ where: { workspaceWorkflowId }, select: { id: true } },);+ if (!isDefined(parentCoreWorkflow)) {+ return [];+ }+if (- isDefined(parentCoreWorkflow) &&!(await this.coreWorkflowAccessService.isCoreWorkflowAccessible({workspaceId,userWorkspaceId,@@ -55,7 +58,7 @@ export class CoreWorkflowVersionListService {const coreWorkflowVersions = await this.coreWorkflowVersionRepository.find(workspaceId,{- where: { workflowId: workspaceWorkflowId },+ where: { coreWorkflowId: parentCoreWorkflow.id },order: { createdAt: 'ASC', id: 'ASC' },select: {id: true,diff --git a/packages/twenty-server/test/integration/graphql/suites/workflow/core-workflow-visibility.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/workflow/core-workflow-visibility.integration-spec.tsindex e10ab405aad..fe891d70e22 100644--- a/packages/twenty-server/test/integration/graphql/suites/workflow/core-workflow-visibility.integration-spec.ts+++ b/packages/twenty-server/test/integration/graphql/suites/workflow/core-workflow-visibility.integration-spec.ts@@ -89,6 +89,14 @@ const CORE_WORKFLOW_VERSION_QUERY = `}`;+const CORE_WORKFLOW_VERSIONS_QUERY = `+ query CoreWorkflowVersions($workspaceWorkflowId: UUID!) {+ coreWorkflowVersions(workspaceWorkflowId: $workspaceWorkflowId) {+ workspaceWorkflowVersionId+ }+ }+`;+const COMPUTE_STEP_OUTPUT_SCHEMA_MUTATION = `mutation ComputeStepOutputSchema($input: ComputeStepOutputSchemaInput!) {computeStepOutputSchema(input: $input)@@ -554,6 +562,57 @@ describe('core workflow visibility (e2e)', () => {expect(response.body.data?.coreWorkflowVersion ?? null).toBeNull();});+ it('returns no versions for a legacy id that no core workflow carries', async () => {+ await global.testDataSource.query(+ `UPDATE core."workflow" SET "workspaceWorkflowId" = NULL WHERE id = $1`,+ [coreWorkflowId],+ );++ try {+ const response = await asOtherMember(CORE_WORKFLOW_VERSIONS_QUERY, {+ workspaceWorkflowId,+ });++ expect(response.body.errors).toBeUndefined();+ expect(response.body.data.coreWorkflowVersions).toEqual([]);+ } finally {+ await global.testDataSource.query(+ `UPDATE core."workflow" SET "workspaceWorkflowId" = $2 WHERE id = $1`,+ [coreWorkflowId, workspaceWorkflowId],+ );+ }+ });++ it('lists versions through their core workflow, not their legacy workflow id', async () => {+ await global.testDataSource.query(+ `UPDATE core."workflowVersion" SET "workflowId" = NULL WHERE "coreWorkflowId" = $1`,+ [coreWorkflowId],+ );++ try {+ const response = await workflowGraphqlRequest(+ CORE_WORKFLOW_VERSIONS_QUERY,+ { workspaceWorkflowId },+ );++ expect(response.body.errors).toBeUndefined();+ expect(+ response.body.data.coreWorkflowVersions.map(+ ({+ workspaceWorkflowVersionId,+ }: {+ workspaceWorkflowVersionId: string;+ }) => workspaceWorkflowVersionId,+ ),+ ).toContain(workspaceWorkflowVersionId);+ } finally {+ await global.testDataSource.query(+ `UPDATE core."workflowVersion" SET "workflowId" = $2 WHERE "coreWorkflowId" = $1`,+ [coreWorkflowId, workspaceWorkflowId],+ );+ }+ });+// This resolver reads version content straight from its id, bypassing the workflow lookup.it('refuses to compute a step output schema from its version for another member', async () => {const response = await asOtherMember(