Skip to content

The open alternative to Salesforce, designed for AI.

feat(server): validate workflow versions through exceptions, malformed at write and non-activable on activate or validate (#24964)

Charles Bochet4f3f65c27e97
diff --git a/packages/twenty-front/src/generated/graphql.ts b/packages/twenty-front/src/generated/graphql.ts
index 80ad79422d7..ee1cf2a8b81 100644
--- a/packages/twenty-front/src/generated/graphql.ts
+++ b/packages/twenty-front/src/generated/graphql.ts
@@ -356,6 +356,7 @@ export type Mutation = {
updateWorkflowVersionPositions: Scalars['Boolean']['output'];
updateWorkflowVersionStep: WorkflowAction;
updateWorkflowVersionTrigger: WorkflowVersionTrigger;
+ validateWorkflowVersion: Scalars['Boolean']['output'];
};
@@ -478,6 +479,11 @@ export type MutationUpdateWorkflowVersionTriggerArgs = {
input: UpdateWorkflowVersionTriggerInput;
};
+
+export type MutationValidateWorkflowVersionArgs = {
+ workflowVersionId: Scalars['UUID']['input'];
+};
+
export type ObjectRecordFilterInput = {
and?: InputMaybe<Array<ObjectRecordFilterInput>>;
createdAt?: InputMaybe<DateTimeFilter>;
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/filters/workflow-version-validation-graphql-api-exception.filter.ts b/packages/twenty-server/src/engine/core-modules/workflow/filters/workflow-version-validation-graphql-api-exception.filter.ts
new file mode 100644
index 00000000000..ea2ddb0fcc0
--- /dev/null
+++ b/packages/twenty-server/src/engine/core-modules/workflow/filters/workflow-version-validation-graphql-api-exception.filter.ts
@@ -0,0 +1,11 @@
+import { Catch, type ExceptionFilter } from '@nestjs/common';
+
+import { UserInputError } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
+import { WorkflowVersionValidationException } from 'src/modules/workflow/workflow-builder/workflow-validation/exceptions/workflow-version-validation.exception';
+
+@Catch(WorkflowVersionValidationException)
+export class WorkflowVersionValidationGraphqlApiExceptionFilter implements ExceptionFilter {
+ catch(exception: WorkflowVersionValidationException) {
+ throw new UserInputError(exception);
+ }
+}
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-trigger.resolver.ts b/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-trigger.resolver.ts
index 595ec8da8a9..c993f9654cb 100644
--- a/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-trigger.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-trigger.resolver.ts
@@ -18,6 +18,7 @@ import { RunWorkflowVersionInput } from 'src/engine/core-modules/workflow/dtos/r
import { RunWorkflowVersionDTO } from 'src/engine/core-modules/workflow/dtos/run-workflow-version.dto';
import { WorkflowRunDTO } from 'src/engine/core-modules/workflow/dtos/workflow-run.dto';
import { WorkflowTriggerGraphqlApiExceptionFilter } from 'src/engine/core-modules/workflow/filters/workflow-trigger-graphql-api-exception.filter';
+import { WorkflowVersionValidationGraphqlApiExceptionFilter } from 'src/engine/core-modules/workflow/filters/workflow-version-validation-graphql-api-exception.filter';
import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
import { AuthUser } from 'src/engine/decorators/auth/auth-user.decorator';
import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
@@ -38,6 +39,7 @@ import { WorkspaceMemberWorkspaceEntity } from 'src/modules/workspace-member/sta
@UsePipes(ResolverValidationPipe)
@UseFilters(
WorkflowTriggerGraphqlApiExceptionFilter,
+ WorkflowVersionValidationGraphqlApiExceptionFilter,
PermissionsGraphqlApiExceptionFilter,
PreventNestToAutoLogGraphqlErrorsFilter,
)
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version-edge.resolver.ts b/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version-edge.resolver.ts
index df16e730a00..1d902a053cb 100644
--- a/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version-edge.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version-edge.resolver.ts
@@ -8,6 +8,7 @@ import { PreventNestToAutoLogGraphqlErrorsFilter } from 'src/engine/core-modules
import { ResolverValidationPipe } from 'src/engine/core-modules/graphql/pipes/resolver-validation.pipe';
import { CreateWorkflowVersionEdgeInput } from 'src/engine/core-modules/workflow/dtos/create-workflow-version-edge.input';
import { WorkflowVersionStepChangesDTO } from 'src/engine/core-modules/workflow/dtos/workflow-version-step-changes.dto';
+import { WorkflowVersionValidationGraphqlApiExceptionFilter } from 'src/engine/core-modules/workflow/filters/workflow-version-validation-graphql-api-exception.filter';
import { WorkflowVersionEdgeGraphqlApiExceptionFilter } from 'src/engine/core-modules/workflow/filters/workflow-version-edge-graphql-api-exception.filter';
import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
@@ -28,6 +29,7 @@ import { WorkflowVersionEdgeWorkspaceService } from 'src/modules/workflow/workfl
PermissionsGraphqlApiExceptionFilter,
PreventNestToAutoLogGraphqlErrorsFilter,
WorkflowVersionEdgeGraphqlApiExceptionFilter,
+ WorkflowVersionValidationGraphqlApiExceptionFilter,
)
export class WorkflowVersionEdgeResolver {
constructor(
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version-step.resolver.ts b/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version-step.resolver.ts
index 10375049655..f9170e6e8ff 100644
--- a/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version-step.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version-step.resolver.ts
@@ -20,6 +20,7 @@ import { UpdateWorkflowVersionTriggerInput } from 'src/engine/core-modules/workf
import { WorkflowActionDTO } from 'src/engine/core-modules/workflow/dtos/workflow-action.dto';
import { WorkflowVersionStepChangesDTO } from 'src/engine/core-modules/workflow/dtos/workflow-version-step-changes.dto';
import { WorkflowVersionTriggerDTO } from 'src/engine/core-modules/workflow/dtos/workflow-version-trigger.dto';
+import { WorkflowVersionValidationGraphqlApiExceptionFilter } from 'src/engine/core-modules/workflow/filters/workflow-version-validation-graphql-api-exception.filter';
import { WorkflowVersionStepGraphqlApiExceptionFilter } from 'src/engine/core-modules/workflow/filters/workflow-version-step-graphql-api-exception.filter';
import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
@@ -44,6 +45,7 @@ import { WorkflowRunnerWorkspaceService } from 'src/modules/workflow/workflow-ru
PermissionsGraphqlApiExceptionFilter,
PreventNestToAutoLogGraphqlErrorsFilter,
WorkflowVersionStepGraphqlApiExceptionFilter,
+ WorkflowVersionValidationGraphqlApiExceptionFilter,
)
export class WorkflowVersionStepResolver {
constructor(
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version.resolver.ts b/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version.resolver.ts
index 1df26c4b751..0c3a0a4c02c 100644
--- a/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version.resolver.ts
@@ -6,6 +6,7 @@ import { PermissionFlagType } from 'twenty-shared/constants';
import { CoreResolver } from 'src/engine/api/graphql/graphql-config/decorators/core-resolver.decorator';
import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
import { PreventNestToAutoLogGraphqlErrorsFilter } from 'src/engine/core-modules/graphql/filters/prevent-nest-to-auto-log-graphql-errors.filter';
+import { WorkflowVersionValidationGraphqlApiExceptionFilter } from 'src/engine/core-modules/workflow/filters/workflow-version-validation-graphql-api-exception.filter';
import { ResolverValidationPipe } from 'src/engine/core-modules/graphql/pipes/resolver-validation.pipe';
import { CreateDraftFromWorkflowVersionInput } from 'src/engine/core-modules/workflow/dtos/create-draft-from-workflow-version.input';
import { DuplicateWorkflowInput } from 'src/engine/core-modules/workflow/dtos/duplicate-workflow.input';
@@ -19,6 +20,7 @@ import { UserAuthGuard } from 'src/engine/guards/user-auth.guard';
import { WorkspaceAuthGuard } from 'src/engine/guards/workspace-auth.guard';
import { PermissionsGraphqlApiExceptionFilter } from 'src/engine/metadata-modules/permissions/utils/permissions-graphql-api-exception.filter';
import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
+import { WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.workspace-service';
import { WorkflowVersionWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version/workflow-version.workspace-service';
@CoreResolver()
@@ -31,11 +33,13 @@ import { WorkflowVersionWorkspaceService } from 'src/modules/workflow/workflow-b
@UseFilters(
PermissionsGraphqlApiExceptionFilter,
PreventNestToAutoLogGraphqlErrorsFilter,
+ WorkflowVersionValidationGraphqlApiExceptionFilter,
)
export class WorkflowVersionResolver {
constructor(
private readonly workflowVersionWorkspaceService: WorkflowVersionWorkspaceService,
private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
+ private readonly workflowVersionValidationWorkspaceService: WorkflowVersionValidationWorkspaceService,
) {}
@Query(() => WorkflowVersionContentDTO)
@@ -57,6 +61,29 @@ export class WorkflowVersionResolver {
};
}
+ @Mutation(() => Boolean)
+ async validateWorkflowVersion(
+ @AuthWorkspace() { id: workspaceId }: WorkspaceEntity,
+ @Args('workflowVersionId', { type: () => UUIDScalarType })
+ workflowVersionId: string,
+ ): Promise<boolean> {
+ const workflowVersion =
+ await this.workflowCommonWorkspaceService.getWorkflowVersionOrFail({
+ workspaceId,
+ workflowVersionId,
+ });
+
+ await this.workflowVersionValidationWorkspaceService.assertWorkflowVersionIsActivableOrThrow(
+ {
+ workspaceId,
+ trigger: workflowVersion.trigger,
+ steps: workflowVersion.steps,
+ },
+ );
+
+ return true;
+ }
+
@Mutation(() => WorkflowVersionDTO)
async createDraftFromWorkflowVersion(
@AuthWorkspace() { id: workspaceId }: WorkspaceEntity,
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/services/workflow-version-core-sync.service.ts b/packages/twenty-server/src/engine/core-modules/workflow/services/workflow-version-core-sync.service.ts
index c04d271f820..5685490afc4 100644
--- a/packages/twenty-server/src/engine/core-modules/workflow/services/workflow-version-core-sync.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/workflow/services/workflow-version-core-sync.service.ts
@@ -22,6 +22,8 @@ import { buildSystemAuthContext } from 'src/engine/twenty-orm/utils/build-system
import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
+import { WorkflowMetadataReadService } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.workspace-service';
+import { assertWorkflowVersionIsNotMalformedOrThrow } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/assert-workflow-version-is-not-malformed-or-throw.util';
@Injectable()
export class WorkflowVersionCoreSyncService {
@@ -35,6 +37,7 @@ export class WorkflowVersionCoreSyncService {
private readonly workspaceOrmManager: WorkspaceOrmManager,
private readonly workspaceCacheService: WorkspaceCacheService,
private readonly recordPositionService: RecordPositionService,
+ private readonly workflowMetadataReadService: WorkflowMetadataReadService,
) {}
async upsertToCore(
@@ -409,6 +412,23 @@ export class WorkflowVersionCoreSyncService {
});
if (isDefined(workflowVersion)) {
+ const {
+ flatObjectMetadataMaps,
+ flatFieldMetadataMaps,
+ objectIdByNameSingular,
+ } =
+ await this.workflowMetadataReadService.getFlatEntityMaps(
+ workspaceId,
+ );
+
+ assertWorkflowVersionIsNotMalformedOrThrow({
+ trigger: workflowVersion.trigger,
+ steps: workflowVersion.steps,
+ flatObjectMetadataMaps,
+ flatFieldMetadataMaps,
+ objectIdByNameSingular,
+ });
+
await this.mirrorWorkflowVersionWrite({
workspaceId,
transactionScope,
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/workflow-api.module.ts b/packages/twenty-server/src/engine/core-modules/workflow/workflow-api.module.ts
index 387bdcf8d4a..2fd94b5fadf 100644
--- a/packages/twenty-server/src/engine/core-modules/workflow/workflow-api.module.ts
+++ b/packages/twenty-server/src/engine/core-modules/workflow/workflow-api.module.ts
@@ -1,4 +1,6 @@
import { Module } from '@nestjs/common';
+
+import { WorkflowVersionValidationModule } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.module';
import { TypeOrmModule } from '@nestjs/typeorm';
import { ToolModule } from 'src/engine/core-modules/tool/tool.module';
@@ -49,6 +51,7 @@ import { WorkflowTriggerModule } from 'src/modules/workflow/workflow-trigger/wor
WorkspaceManyOrAllFlatEntityMapsCacheModule,
ConnectedAccountMetadataModule,
WorkflowVersionCoreModule,
+ WorkflowVersionValidationModule,
],
controllers: [WorkflowTriggerController],
providers: [
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/workflow-version-core.module.ts b/packages/twenty-server/src/engine/core-modules/workflow/workflow-version-core.module.ts
index 94a68ca8e92..51896bfe7a3 100644
--- a/packages/twenty-server/src/engine/core-modules/workflow/workflow-version-core.module.ts
+++ b/packages/twenty-server/src/engine/core-modules/workflow/workflow-version-core.module.ts
@@ -9,12 +9,14 @@ import { WorkspaceWorkflowAutomatedTriggerMapCacheService } from 'src/engine/cor
import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
import { provideWorkspaceScopedRepository } from 'src/engine/twenty-orm/workspace-scoped-repository/provide-workspace-scoped-repository';
import { WorkspaceCacheModule } from 'src/engine/workspace-cache/workspace-cache.module';
+import { WorkflowMetadataReadModule } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.module';
@Module({
imports: [
RecordPositionModule,
TypeOrmModule.forFeature([WorkflowVersionEntity, WorkspaceEntity]),
WorkspaceCacheModule,
+ WorkflowMetadataReadModule,
],
providers: [
WorkspaceWorkflowAutomatedTriggerMapCacheService,
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/workspace-setup-system-prompt.constant.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/workspace-setup-system-prompt.constant.ts
index 8c569ae7cc6..9f029124ff6 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/workspace-setup-system-prompt.constant.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/workspace-setup-system-prompt.constant.ts
@@ -61,7 +61,7 @@ Never stop after that report: the turn is unfinished until you call ask_question
Their pick is the approval: load the skill for whichever capability they pick, follow its recipe below, build it without asking again, then report it and ask again the same way with what is left, so each round is shorter than the last. When they answer in free text instead, do what they asked, then come back to the question. Once nothing is left to offer, skip it, since a question with one option is rejected, and end the setup as described below, which is also what you do when they pick finishing it, without asking them to confirm.
For whichever they pick:
-- Workflows: load the workflow-building skill, then create_complete_workflow, which rejects code and AI-agent steps whatever the skill says; prefer automations needing no connected mailbox. Fix anything validate_workflow reports until it comes back clean, then activate with activate_workflow_version.
+- Workflows: load the workflow-building skill, then create_complete_workflow, which rejects code and AI-agent steps whatever the skill says; prefer automations needing no connected mailbox. Fix the issues validate_workflow fails with until it succeeds, then activate with activate_workflow_version.
- Dashboards: load the dashboard-building skill and name the counters and charts it will hold and the fields behind them, noting it fills up as records arrive. Build it with create_complete_dashboard using graph widgets, repairing anything in widgetErrors.
- Roles: load the roles skill, call list_roles, and propose one that adds something to the Admin and Member roles already there, in one line: what it can reach and what it cannot.
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/skill-metadata/create-standard-flat-skill-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/skill-metadata/create-standard-flat-skill-metadata.util.ts
index ef303006f7e..387ad77d4aa 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/skill-metadata/create-standard-flat-skill-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/skill-metadata/create-standard-flat-skill-metadata.util.ts
@@ -111,11 +111,9 @@ Always rely on tool schema definitions:
## Validation Strategy
-Build steps fully configured up front so the workflow is correct on the first try. Mutation tools (\`create_complete_workflow\`, \`update_workflow_version_step\`) return a compact validation summary (error codes, messages, suggestions) — fix any reported errors.
+Build steps fully configured up front so the workflow is correct on the first try. Malformed content (a bare string in a rich text field, a step targeting an object that does not exist, a broken graph) is rejected at write time: the mutation tool fails with the error and nothing is saved, so fix the payload and retry.
-Do NOT call \`validate_workflow\` after every change:
-- When making several step edits in a row, pass \`validate: false\` to \`update_workflow_version_step\` to skip per-edit validation.
-- Call \`validate_workflow\` exactly ONCE at the end, before activating. It returns the full report including warnings and available variable paths.
+Do NOT call \`validate_workflow\` after every change. Call it exactly ONCE at the end, before activating: it runs the exact check activation runs and, when the version is not ready, fails with the list of issues (code, message, stepId). Fix them and call it again until it succeeds, then activate.
## Approach
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-query-hook.module.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-query-hook.module.ts
index ea213e3a8d7..aed743d525f 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-query-hook.module.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-query-hook.module.ts
@@ -43,7 +43,7 @@ import { WorkflowVersionUpdateManyPreQueryHook } from 'src/modules/workflow/comm
import { WorkflowVersionUpdateOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook';
import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
import { WorkflowMetadataReadModule } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.module';
-import { WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-version-validation.workspace-service';
+import { WorkflowVersionQueryValidationWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service';
@Module({
imports: [
@@ -85,7 +85,7 @@ import { WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/
WorkflowVersionRestoreManyPreQueryHook,
WorkflowCreateOnePostQueryHook,
WorkflowCreateManyPostQueryHook,
- WorkflowVersionValidationWorkspaceService,
+ WorkflowVersionQueryValidationWorkspaceService,
WorkflowCommonWorkspaceService,
WorkflowDeleteManyPostQueryHook,
WorkflowDeleteOnePostQueryHook,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.pre-query.hook.ts
index 24b1100913c..49b6737c88e 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.pre-query.hook.ts
@@ -5,13 +5,13 @@ import { type DeleteOneResolverArgs } from 'src/engine/api/graphql/workspace-res
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-version-validation.workspace-service';
+import { WorkflowVersionQueryValidationWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service';
import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
@WorkspaceQueryHook(`workflowVersion.deleteOne`)
export class WorkflowVersionDeleteOnePreQueryHook implements WorkspacePreQueryHookInstance {
constructor(
- private readonly workflowVersionValidationWorkspaceService: WorkflowVersionValidationWorkspaceService,
+ private readonly workflowVersionQueryValidationWorkspaceService: WorkflowVersionQueryValidationWorkspaceService,
) {}
async execute(
@@ -23,7 +23,7 @@ export class WorkflowVersionDeleteOnePreQueryHook implements WorkspacePreQueryHo
assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
- await this.workflowVersionValidationWorkspaceService.validateWorkflowVersionForDeleteOne(
+ await this.workflowVersionQueryValidationWorkspaceService.validateWorkflowVersionForDeleteOne(
workspace.id,
payload,
);
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook.ts
index 9466495839a..7955a55a4c3 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook.ts
@@ -6,13 +6,13 @@ import { type UpdateOneResolverArgs } from 'src/engine/api/graphql/workspace-res
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
-import { WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-version-validation.workspace-service';
+import { WorkflowVersionQueryValidationWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service';
import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
@WorkspaceQueryHook(`workflowVersion.updateOne`)
export class WorkflowVersionUpdateOnePreQueryHook implements WorkspacePreQueryHookInstance {
constructor(
- private readonly workflowVersionValidationWorkspaceService: WorkflowVersionValidationWorkspaceService,
+ private readonly workflowVersionQueryValidationWorkspaceService: WorkflowVersionQueryValidationWorkspaceService,
) {}
async execute(
@@ -24,7 +24,7 @@ export class WorkflowVersionUpdateOnePreQueryHook implements WorkspacePreQueryHo
assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
- await this.workflowVersionValidationWorkspaceService.validateWorkflowVersionForUpdateOne(
+ await this.workflowVersionQueryValidationWorkspaceService.validateWorkflowVersionForUpdateOne(
{
workspaceId: workspace.id,
payload,
diff --git a/packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-version-validation.workspace-service.ts b/packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service.ts
similarity index 98%
rename from packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-version-validation.workspace-service.ts
rename to packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service.ts
index ee021bb68d8..0aa1aa4391d 100644
--- a/packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-version-validation.workspace-service.ts
+++ b/packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service.ts
@@ -24,7 +24,7 @@ import { assertWorkflowVersionIsDraft } from 'src/modules/workflow/common/utils/
import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
@Injectable()
-export class WorkflowVersionValidationWorkspaceService {
+export class WorkflowVersionQueryValidationWorkspaceService {
constructor(
private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
private readonly workspaceOrmManager: WorkspaceOrmManager,
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/constants/object-targeting-action-types.constant.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/constants/object-targeting-action-types.constant.ts
new file mode 100644
index 00000000000..1d26daf2ce4
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/constants/object-targeting-action-types.constant.ts
@@ -0,0 +1,8 @@
+import { WorkflowActionType } from 'twenty-shared/workflow';
+
+import { WORKFLOW_RECORD_CRUD_ACTION_TYPES } from 'src/modules/workflow/workflow-builder/workflow-validation/constants/workflow-record-crud-action-types.constant';
+
+export const OBJECT_TARGETING_ACTION_TYPES = new Set<WorkflowActionType>([
+ ...WORKFLOW_RECORD_CRUD_ACTION_TYPES,
+ WorkflowActionType.PICK_RECORD,
+]);
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/exceptions/workflow-version-validation.exception.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/exceptions/workflow-version-validation.exception.ts
new file mode 100644
index 00000000000..351545c82f3
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/exceptions/workflow-version-validation.exception.ts
@@ -0,0 +1,48 @@
+import { type MessageDescriptor } from '@lingui/core';
+import { msg } from '@lingui/core/macro';
+import { assertUnreachable } from 'twenty-shared/utils';
+import { type WorkflowValidationIssue } from 'twenty-shared/workflow';
+
+import { CustomException } from 'src/utils/custom-exception';
+
+export enum WorkflowVersionValidationExceptionCode {
+ MALFORMED_WORKFLOW_VERSION = 'MALFORMED_WORKFLOW_VERSION',
+ NON_ACTIVABLE_WORKFLOW_VERSION = 'NON_ACTIVABLE_WORKFLOW_VERSION',
+}
+
+const getWorkflowVersionValidationExceptionUserFriendlyMessage = (
+ code: WorkflowVersionValidationExceptionCode,
+): MessageDescriptor => {
+ switch (code) {
+ case WorkflowVersionValidationExceptionCode.MALFORMED_WORKFLOW_VERSION:
+ return msg`This workflow version contains malformed data and cannot be saved.`;
+ case WorkflowVersionValidationExceptionCode.NON_ACTIVABLE_WORKFLOW_VERSION:
+ return msg`This workflow version is not ready to be activated.`;
+ default:
+ assertUnreachable(code);
+ }
+};
+
+const describeIssues = (issues: WorkflowValidationIssue[]): string =>
+ issues.map((issue) => issue.message).join('; ');
+
+export class WorkflowVersionValidationException extends CustomException<WorkflowVersionValidationExceptionCode> {
+ readonly issues: WorkflowValidationIssue[];
+
+ constructor(
+ code: WorkflowVersionValidationExceptionCode,
+ issues: WorkflowValidationIssue[],
+ ) {
+ const summary =
+ code === WorkflowVersionValidationExceptionCode.MALFORMED_WORKFLOW_VERSION
+ ? 'Workflow version is malformed'
+ : 'Workflow version cannot be activated';
+
+ super(`${summary}: ${describeIssues(issues)}`, code, {
+ userFriendlyMessage:
+ getWorkflowVersionValidationExceptionUserFriendlyMessage(code),
+ });
+
+ this.issues = issues;
+ }
+}
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/__tests__/get-record-crud-rich-text-issues.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/__tests__/get-record-crud-rich-text-issues.util.spec.ts
new file mode 100644
index 00000000000..a16bad49c88
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/__tests__/get-record-crud-rich-text-issues.util.spec.ts
@@ -0,0 +1,61 @@
+import { FieldMetadataType } from 'twenty-shared/types';
+
+import { type ObjectMetadataInfo } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.workspace-service';
+import { getRecordCrudRichTextIssues } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/get-record-crud-rich-text-issues.util';
+
+type TestField = { id: string; name: string; type: FieldMetadataType };
+
+const buildObjectMetadataInfo = (fields: TestField[]): ObjectMetadataInfo => {
+ const byUniversalIdentifier = Object.fromEntries(
+ fields.map((field) => [field.id, field]),
+ );
+ const universalIdentifierById = Object.fromEntries(
+ fields.map((field) => [field.id, field.id]),
+ );
+
+ return {
+ flatObjectMetadata: { fieldIds: fields.map((field) => field.id) },
+ flatFieldMetadataMaps: { byUniversalIdentifier, universalIdentifierById },
+ } as unknown as ObjectMetadataInfo;
+};
+
+const objectMetadataInfo = buildObjectMetadataInfo([
+ { id: 'field-1', name: 'body', type: FieldMetadataType.RICH_TEXT },
+ { id: 'field-2', name: 'title', type: FieldMetadataType.TEXT },
+]);
+
+const getIssues = (objectRecord: Record<string, unknown>) =>
+ getRecordCrudRichTextIssues({
+ objectRecord,
+ objectMetadataInfo,
+ stepLabel: 'Create task',
+ stepId: 'step-1',
+ });
+
+describe('getRecordCrudRichTextIssues', () => {
+ it('flags a bare-string rich text value', () => {
+ const issues = getIssues({ body: 'Hello {{name}}' });
+
+ expect(issues).toHaveLength(1);
+ expect(issues[0]).toMatchObject({
+ severity: 'error',
+ code: 'INVALID_RICH_TEXT_FIELD',
+ stepId: 'step-1',
+ });
+ });
+
+ it('flags arrays and malformed objects', () => {
+ expect(getIssues({ body: ['x'] })).toHaveLength(1);
+ expect(getIssues({ body: { blocknote: 123 } })).toHaveLength(1);
+ expect(getIssues({ body: { unexpectedKey: 'x' } })).toHaveLength(1);
+ });
+
+ it('accepts valid rich text values and ignores non-rich-text fields', () => {
+ expect(getIssues({ body: { blocknote: '[]', markdown: null } })).toEqual(
+ [],
+ );
+ expect(getIssues({ body: { markdown: 'text' } })).toEqual([]);
+ expect(getIssues({ body: null })).toEqual([]);
+ expect(getIssues({ title: 'a plain string' })).toEqual([]);
+ });
+});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/__tests__/get-workflow-record-step-metadata-issues.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/__tests__/get-workflow-record-step-metadata-issues.util.spec.ts
new file mode 100644
index 00000000000..d1489cb7f32
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/__tests__/get-workflow-record-step-metadata-issues.util.spec.ts
@@ -0,0 +1,105 @@
+import { FieldMetadataType } from 'twenty-shared/types';
+import { WorkflowActionType } from 'twenty-shared/workflow';
+
+import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
+import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
+import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
+import { getWorkflowRecordStepMetadataIssues } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/get-workflow-record-step-metadata-issues.util';
+import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
+
+const NOTE_OBJECT_ID = 'note-object';
+
+const flatObjectMetadataMaps = {
+ byUniversalIdentifier: {
+ [NOTE_OBJECT_ID]: { id: NOTE_OBJECT_ID, fieldIds: ['field-body'] },
+ },
+ universalIdentifierById: { [NOTE_OBJECT_ID]: NOTE_OBJECT_ID },
+} as unknown as FlatEntityMaps<FlatObjectMetadata>;
+
+const flatFieldMetadataMaps = {
+ byUniversalIdentifier: {
+ 'field-body': {
+ id: 'field-body',
+ name: 'body',
+ type: FieldMetadataType.RICH_TEXT,
+ },
+ },
+ universalIdentifierById: { 'field-body': 'field-body' },
+} as unknown as FlatEntityMaps<FlatFieldMetadata>;
+
+const objectIdByNameSingular = { note: NOTE_OBJECT_ID };
+
+const buildCreateStep = (input: unknown): WorkflowAction =>
+ ({
+ id: 'step-1',
+ name: 'Create Record',
+ type: WorkflowActionType.CREATE_RECORD,
+ settings: { input },
+ }) as unknown as WorkflowAction;
+
+const getIssues = (steps: WorkflowAction[]) =>
+ getWorkflowRecordStepMetadataIssues({
+ steps,
+ flatObjectMetadataMaps,
+ flatFieldMetadataMaps,
+ objectIdByNameSingular,
+ });
+
+describe('getWorkflowRecordStepMetadataIssues', () => {
+ it('flags an unknown target object as OBJECT_NOT_FOUND', () => {
+ const issues = getIssues([
+ buildCreateStep({ objectName: 'ghost', objectRecord: {} }),
+ ]);
+
+ expect(issues).toHaveLength(1);
+ expect(issues[0]).toMatchObject({
+ code: 'OBJECT_NOT_FOUND',
+ stepId: 'step-1',
+ });
+ });
+
+ it('flags a non-string object name as OBJECT_NOT_FOUND', () => {
+ const issues = getIssues([
+ buildCreateStep({ objectName: 123, objectRecord: {} }),
+ ]);
+
+ expect(issues).toHaveLength(1);
+ expect(issues[0].code).toBe('OBJECT_NOT_FOUND');
+ });
+
+ it('flags a bare-string rich text value on a known object', () => {
+ const issues = getIssues([
+ buildCreateStep({
+ objectName: 'note',
+ objectRecord: { body: 'plain string' },
+ }),
+ ]);
+
+ expect(issues).toHaveLength(1);
+ expect(issues[0].code).toBe('INVALID_RICH_TEXT_FIELD');
+ });
+
+ it('returns no issues for a valid record step', () => {
+ const issues = getIssues([
+ buildCreateStep({
+ objectName: 'note',
+ objectRecord: { body: { markdown: 'hi' } },
+ }),
+ ]);
+
+ expect(issues).toEqual([]);
+ });
+
+ it('ignores steps that do not target a record object', () => {
+ const issues = getIssues([
+ {
+ id: 'step-1',
+ name: 'Send email',
+ type: WorkflowActionType.SEND_EMAIL,
+ settings: { input: {} },
+ } as unknown as WorkflowAction,
+ ]);
+
+ expect(issues).toEqual([]);
+ });
+});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/__tests__/validate-workflow-steps-have-variable-references.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/__tests__/validate-workflow-steps-have-variable-references.util.spec.ts
deleted file mode 100644
index a1b0a8f4749..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/__tests__/validate-workflow-steps-have-variable-references.util.spec.ts
+++ /dev/null
@@ -1,102 +0,0 @@
-import { WorkflowActionType } from 'twenty-shared/workflow';
-
-import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import { validateWorkflowStepsHaveVariableReferences } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-steps-have-variable-references.util';
-
-const buildStep = ({
- id = 'step-1',
- name = 'Step 1',
- type,
- input,
-}: {
- id?: string;
- name?: string;
- type: WorkflowActionType;
- input?: unknown;
-}): WorkflowAction =>
- ({
- id,
- name,
- type,
- settings: { input },
- }) as WorkflowAction;
-
-describe('validateWorkflowStepsHaveVariableReferences', () => {
- it('should return no issue for an empty step list', () => {
- expect(validateWorkflowStepsHaveVariableReferences([])).toEqual([]);
- });
-
- it('should warn when a variable-consuming step references no variable', () => {
- const issues = validateWorkflowStepsHaveVariableReferences([
- buildStep({
- type: WorkflowActionType.CODE,
- input: { value: 'static' },
- }),
- ]);
-
- expect(issues).toHaveLength(1);
- expect(issues[0].code).toBe('STEP_HAS_NO_VARIABLE_REFERENCE');
- expect(issues[0].severity).toBe('warning');
- expect(issues[0].stepId).toBe('step-1');
- });
-
- it('should not warn when the step references a variable', () => {
- const issues = validateWorkflowStepsHaveVariableReferences([
- buildStep({
- type: WorkflowActionType.CODE,
- input: { value: '{{step-0.output}}' },
- }),
- ]);
-
- expect(issues).toEqual([]);
- });
-
- it('should ignore action types that do not consume variables', () => {
- const issues = validateWorkflowStepsHaveVariableReferences([
- buildStep({
- type: WorkflowActionType.FILTER,
- input: { value: 'static' },
- }),
- ]);
-
- expect(issues).toEqual([]);
- });
-
- it('should fall back to the step id when the step has no name', () => {
- const issues = validateWorkflowStepsHaveVariableReferences([
- {
- id: 'unnamed-step',
- type: WorkflowActionType.CODE,
- settings: { input: {} },
- } as WorkflowAction,
- ]);
-
- expect(issues[0].message).toContain('unnamed-step');
- });
-
- it('should report one issue per offending step', () => {
- const issues = validateWorkflowStepsHaveVariableReferences([
- buildStep({ id: 'a', type: WorkflowActionType.CODE, input: {} }),
- buildStep({ id: 'b', type: WorkflowActionType.HTTP_REQUEST, input: {} }),
- buildStep({
- id: 'c',
- type: WorkflowActionType.CODE,
- input: { value: '{{a.output}}' },
- }),
- ]);
-
- expect(issues.map((issue) => issue.stepId)).toEqual(['a', 'b']);
- });
-
- it('should not throw when settings have no input', () => {
- const issues = validateWorkflowStepsHaveVariableReferences([
- {
- id: 'a',
- type: WorkflowActionType.CODE,
- settings: {},
- } as WorkflowAction,
- ]);
-
- expect(issues).toHaveLength(1);
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/assert-workflow-version-is-not-malformed-or-throw.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/assert-workflow-version-is-not-malformed-or-throw.util.ts
new file mode 100644
index 00000000000..f48e9a0c077
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/assert-workflow-version-is-not-malformed-or-throw.util.ts
@@ -0,0 +1,61 @@
+import {
+ MALFORMED_WORKFLOW_VALIDATION_ISSUE_CODES,
+ validateWorkflowStructure,
+ type WorkflowValidationIssue,
+} from 'twenty-shared/workflow';
+
+import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
+import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
+import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
+import {
+ WorkflowVersionValidationException,
+ WorkflowVersionValidationExceptionCode,
+} from 'src/modules/workflow/workflow-builder/workflow-validation/exceptions/workflow-version-validation.exception';
+import { getWorkflowRecordStepMetadataIssues } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/get-workflow-record-step-metadata-issues.util';
+import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
+import { type WorkflowTrigger } from 'src/modules/workflow/workflow-trigger/types/workflow-trigger.type';
+
+type WorkflowVersionMalformedCheckArgs = {
+ trigger: WorkflowTrigger | null | undefined;
+ steps: WorkflowAction[] | null | undefined;
+ flatObjectMetadataMaps: FlatEntityMaps<FlatObjectMetadata>;
+ flatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata>;
+ objectIdByNameSingular: Record<string, string>;
+};
+
+const getMalformedWorkflowVersionIssues = ({
+ trigger,
+ steps,
+ flatObjectMetadataMaps,
+ flatFieldMetadataMaps,
+ objectIdByNameSingular,
+}: WorkflowVersionMalformedCheckArgs): WorkflowValidationIssue[] => {
+ const structureResult = validateWorkflowStructure({ trigger, steps });
+
+ return [
+ ...structureResult.errors,
+ ...getWorkflowRecordStepMetadataIssues({
+ steps: steps ?? [],
+ flatObjectMetadataMaps,
+ flatFieldMetadataMaps,
+ objectIdByNameSingular,
+ }),
+ ].filter((issue) =>
+ MALFORMED_WORKFLOW_VALIDATION_ISSUE_CODES.has(issue.code),
+ );
+};
+
+export const assertWorkflowVersionIsNotMalformedOrThrow = (
+ args: WorkflowVersionMalformedCheckArgs,
+): void => {
+ const malformedIssues = getMalformedWorkflowVersionIssues(args);
+
+ if (malformedIssues.length === 0) {
+ return;
+ }
+
+ throw new WorkflowVersionValidationException(
+ WorkflowVersionValidationExceptionCode.MALFORMED_WORKFLOW_VERSION,
+ malformedIssues,
+ );
+};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/build-missing-workflow-output-schema-issue.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/build-missing-workflow-output-schema-issue.util.ts
deleted file mode 100644
index 8069705eee9..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/build-missing-workflow-output-schema-issue.util.ts
+++ /dev/null
@@ -1,16 +0,0 @@
-import { type WorkflowValidationIssue } from 'twenty-shared/workflow';
-
-export const buildMissingWorkflowOutputSchemaIssue = ({
- id,
- name,
-}: {
- id: string;
- name?: string;
-}): WorkflowValidationIssue => {
- return {
- severity: 'error',
- code: 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- message: `Step "${name ?? id}" has no output schema. Declare an expected output schema.`,
- stepId: id,
- };
-};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/get-record-crud-rich-text-issues.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/get-record-crud-rich-text-issues.util.ts
new file mode 100644
index 00000000000..096abd2ffbf
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/get-record-crud-rich-text-issues.util.ts
@@ -0,0 +1,43 @@
+import { richTextValueSchema } from 'twenty-shared/types';
+import { isDefined } from 'twenty-shared/utils';
+import { type WorkflowValidationIssue } from 'twenty-shared/workflow';
+
+import { type ObjectMetadataInfo } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.workspace-service';
+import { findRichTextFieldNames } from 'src/modules/workflow/workflow-executor/utils/find-rich-text-field-names.util';
+
+export const getRecordCrudRichTextIssues = ({
+ objectRecord,
+ objectMetadataInfo,
+ stepLabel,
+ stepId,
+}: {
+ objectRecord: Record<string, unknown>;
+ objectMetadataInfo: Pick<
+ ObjectMetadataInfo,
+ 'flatObjectMetadata' | 'flatFieldMetadataMaps'
+ >;
+ stepLabel: string;
+ stepId?: string;
+}): WorkflowValidationIssue[] => {
+ const richTextFieldNames = findRichTextFieldNames(objectMetadataInfo);
+
+ const issues: WorkflowValidationIssue[] = [];
+
+ for (const fieldName of richTextFieldNames) {
+ const fieldValue = objectRecord[fieldName];
+
+ if (
+ isDefined(fieldValue) &&
+ !richTextValueSchema.safeParse(fieldValue).success
+ ) {
+ issues.push({
+ severity: 'error',
+ code: 'INVALID_RICH_TEXT_FIELD',
+ message: `Rich text field "${fieldName}" in step "${stepLabel}" must be a rich text object (e.g. { "markdown": "..." }), not a plain value.`,
+ stepId,
+ });
+ }
+ }
+
+ return issues;
+};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/get-workflow-record-step-metadata-issues.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/get-workflow-record-step-metadata-issues.util.ts
new file mode 100644
index 00000000000..926067ee2d0
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/get-workflow-record-step-metadata-issues.util.ts
@@ -0,0 +1,120 @@
+import { isObject, isString } from '@sniptt/guards';
+import { isDefined } from 'twenty-shared/utils';
+import {
+ WorkflowActionType,
+ type WorkflowValidationIssue,
+} from 'twenty-shared/workflow';
+
+import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
+import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps.util';
+import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
+import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
+import { OBJECT_TARGETING_ACTION_TYPES } from 'src/modules/workflow/workflow-builder/workflow-validation/constants/object-targeting-action-types.constant';
+import { getPickRecordLoadBalanceConfigError } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/get-pick-record-load-balance-config-error.util';
+import { getRecordCrudRichTextIssues } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/get-record-crud-rich-text-issues.util';
+import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
+
+const RECORD_CRUD_ACTION_TYPES_WITH_OBJECT_RECORD = new Set<WorkflowActionType>(
+ [
+ WorkflowActionType.CREATE_RECORD,
+ WorkflowActionType.UPDATE_RECORD,
+ WorkflowActionType.UPSERT_RECORD,
+ ],
+);
+
+export const getWorkflowRecordStepMetadataIssues = ({
+ steps,
+ flatObjectMetadataMaps,
+ flatFieldMetadataMaps,
+ objectIdByNameSingular,
+}: {
+ steps: WorkflowAction[];
+ flatObjectMetadataMaps: FlatEntityMaps<FlatObjectMetadata>;
+ flatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata>;
+ objectIdByNameSingular: Record<string, string>;
+}): WorkflowValidationIssue[] => {
+ const issues: WorkflowValidationIssue[] = [];
+
+ for (const step of steps) {
+ if (!OBJECT_TARGETING_ACTION_TYPES.has(step.type)) {
+ continue;
+ }
+
+ const input = step.settings.input;
+ const objectName =
+ isObject(input) && 'objectName' in input ? input.objectName : undefined;
+
+ if (!isString(objectName)) {
+ issues.push({
+ severity: 'error',
+ code: 'OBJECT_NOT_FOUND',
+ message: `Step "${step.name ?? step.id}" has an invalid object name.`,
+ stepId: step.id,
+ });
+
+ continue;
+ }
+
+ const objectId = objectIdByNameSingular[objectName];
+
+ if (!isDefined(objectId)) {
+ issues.push({
+ severity: 'error',
+ code: 'OBJECT_NOT_FOUND',
+ message: `Step "${step.name ?? step.id}" targets object "${objectName}" which does not exist in this workspace.`,
+ stepId: step.id,
+ });
+
+ continue;
+ }
+
+ if (step.type === WorkflowActionType.PICK_RECORD) {
+ const loadBalanceError = getPickRecordLoadBalanceConfigError({
+ step,
+ objectIdByNameSingular,
+ flatFieldMetadataMaps,
+ });
+
+ if (isDefined(loadBalanceError)) {
+ issues.push({
+ severity: 'error',
+ code: 'INCOMPLETE_PICK_RECORD_CONFIG',
+ message: loadBalanceError,
+ stepId: step.id,
+ });
+ }
+ }
+
+ const objectRecord =
+ RECORD_CRUD_ACTION_TYPES_WITH_OBJECT_RECORD.has(step.type) &&
+ isObject(input) &&
+ 'objectRecord' in input &&
+ isObject(input.objectRecord)
+ ? (input.objectRecord as Record<string, unknown>)
+ : undefined;
+
+ if (!isDefined(objectRecord)) {
+ continue;
+ }
+
+ const flatObjectMetadata = findFlatEntityByIdInFlatEntityMaps({
+ flatEntityId: objectId,
+ flatEntityMaps: flatObjectMetadataMaps,
+ });
+
+ if (!isDefined(flatObjectMetadata)) {
+ continue;
+ }
+
+ issues.push(
+ ...getRecordCrudRichTextIssues({
+ objectRecord,
+ objectMetadataInfo: { flatObjectMetadata, flatFieldMetadataMaps },
+ stepLabel: step.name ?? step.id,
+ stepId: step.id,
+ }),
+ );
+ }
+
+ return issues;
+};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/has-workflow-step-level-output-schema.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/has-workflow-step-level-output-schema.util.ts
deleted file mode 100644
index 515bb2859e5..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/has-workflow-step-level-output-schema.util.ts
+++ /dev/null
@@ -1,8 +0,0 @@
-import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import { hasWorkflowOutputSchema } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/has-workflow-output-schema.util';
-
-export const hasWorkflowStepLevelOutputSchema = (
- step: WorkflowAction,
-): boolean => {
- return hasWorkflowOutputSchema(step.settings);
-};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-iterator-step.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-iterator-step.util.ts
deleted file mode 100644
index 21e4f65f272..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-iterator-step.util.ts
+++ /dev/null
@@ -1,98 +0,0 @@
-import { isNonEmptyArray, isObject, isString } from '@sniptt/guards';
-import { isDefined, isValidVariable } from 'twenty-shared/utils';
-import {
- collectOutputSchemaVariablePaths,
- extractVariablesFromInput,
- parseVariablePath,
- resolveVariablePathInOutputSchema,
- TRIGGER_STEP_ID,
- type WorkflowValidationIssue,
-} from 'twenty-shared/workflow';
-
-import {
- type WorkflowAction,
- type WorkflowIteratorAction,
-} from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import { type WorkflowTrigger } from 'src/modules/workflow/workflow-trigger/types/workflow-trigger.type';
-
-export const validateWorkflowIteratorStep = ({
- step,
- steps,
- trigger,
-}: {
- step: WorkflowIteratorAction;
- steps: WorkflowAction[];
- trigger: WorkflowTrigger | null;
-}): WorkflowValidationIssue[] => {
- const items = step.settings?.input?.items;
-
- if (!isString(items) || !isValidVariable(items)) {
- return [];
- }
-
- const [variable] = extractVariablesFromInput(items);
-
- if (!isDefined(variable)) {
- return [];
- }
-
- const [referencedStepId, ...propertyPath] = parseVariablePath(variable);
-
- if (!isDefined(referencedStepId)) {
- return [];
- }
-
- const outputSchema =
- referencedStepId === TRIGGER_STEP_ID
- ? trigger?.settings?.outputSchema
- : steps.find((currentStep) => currentStep.id === referencedStepId)
- ?.settings?.outputSchema;
-
- if (!isDefined(outputSchema) || !isObject(outputSchema)) {
- return [];
- }
-
- const resolved = resolveVariablePathInOutputSchema({
- schema: outputSchema,
- propertyPath,
- });
-
- if (resolved.found && resolved.type === 'array') {
- return [];
- }
-
- const arrayPathSuggestions = collectOutputSchemaVariablePaths(outputSchema)
- .filter(
- (path) =>
- resolveVariablePathInOutputSchema({
- schema: outputSchema,
- propertyPath: path.split('.'),
- }).type === 'array',
- )
- .map((path) => `${referencedStepId}.${path}`);
-
- const hint = isNonEmptyArray(arrayPathSuggestions)
- ? `Did you mean "{{${arrayPathSuggestions[0]}}}"?${
- arrayPathSuggestions.length > 1
- ? ` Other options: ${arrayPathSuggestions
- .slice(1)
- .map((suggestion) => `{{${suggestion}}}`)
- .join(', ')}.`
- : ''
- }`
- : undefined;
-
- return [
- {
- severity: 'error',
- code: 'ITERATOR_ITEMS_NOT_ARRAY',
- message: `Iterator step "${step.name ?? step.id}" must iterate over an array, but "{{${variable}}}" is not an array.`,
- stepId: step.id,
- path: variable,
- ...(isDefined(hint) ? { hint } : {}),
- ...(isNonEmptyArray(arrayPathSuggestions)
- ? { suggestions: arrayPathSuggestions }
- : {}),
- },
- ];
-};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-logic-function-output-schema-mismatch.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-logic-function-output-schema-mismatch.util.ts
deleted file mode 100644
index 9410b49ccd6..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-logic-function-output-schema-mismatch.util.ts
+++ /dev/null
@@ -1,42 +0,0 @@
-import { isObject } from '@sniptt/guards';
-import {
- getOutputSchemaFromValue,
- getOutputSchemaMismatchIssues,
-} from 'twenty-shared/logic-function';
-import { isDefined } from 'twenty-shared/utils';
-import {
- type BaseOutputSchemaV2,
- type WorkflowValidationIssue,
-} from 'twenty-shared/workflow';
-
-import { type WorkflowLogicFunctionAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-
-export const validateWorkflowLogicFunctionOutputSchemaMismatch = ({
- step,
- declaredOutputSchema,
-}: {
- step: WorkflowLogicFunctionAction;
- declaredOutputSchema: BaseOutputSchemaV2 | undefined;
-}): WorkflowValidationIssue[] => {
- const expectedOutputSchema = step.settings?.expectedOutputSchema;
-
- if (
- !isDefined(declaredOutputSchema) ||
- !isObject(expectedOutputSchema) ||
- Object.keys(expectedOutputSchema).length === 0
- ) {
- return [];
- }
-
- const mismatchIssues = getOutputSchemaMismatchIssues(
- declaredOutputSchema,
- getOutputSchemaFromValue(expectedOutputSchema),
- );
-
- return mismatchIssues.map((mismatchIssue) => ({
- severity: 'warning',
- code: 'LOGIC_FUNCTION_OUTPUT_SCHEMA_MISMATCH',
- message: `Step "${step.name ?? step.id}" expected output schema does not match the function's declared output schema: ${mismatchIssue}`,
- stepId: step.id,
- }));
-};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-runtime-output-step.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-runtime-output-step.util.ts
deleted file mode 100644
index bf40d765431..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-runtime-output-step.util.ts
+++ /dev/null
@@ -1,17 +0,0 @@
-import { type WorkflowValidationIssue } from 'twenty-shared/workflow';
-
-import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import { hasWorkflowStepLevelOutputSchema } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/has-workflow-step-level-output-schema.util';
-import { buildMissingWorkflowOutputSchemaIssue } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/build-missing-workflow-output-schema-issue.util';
-
-export const validateWorkflowRuntimeOutputStep = (
- step: WorkflowAction,
-): WorkflowValidationIssue[] => {
- if (hasWorkflowStepLevelOutputSchema(step)) {
- return [];
- }
-
- return [
- buildMissingWorkflowOutputSchemaIssue({ id: step.id, name: step.name }),
- ];
-};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-steps-have-variable-references.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-steps-have-variable-references.util.ts
deleted file mode 100644
index 928c27c058f..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-steps-have-variable-references.util.ts
+++ /dev/null
@@ -1,34 +0,0 @@
-import {
- extractVariablesFromInput,
- type WorkflowValidationIssue,
-} from 'twenty-shared/workflow';
-
-import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import { WORKFLOW_VARIABLE_CONSUMING_ACTION_TYPES } from 'src/modules/workflow/workflow-builder/workflow-validation/constants/workflow-variable-consuming-action-types.constant';
-
-export const validateWorkflowStepsHaveVariableReferences = (
- steps: WorkflowAction[],
-): WorkflowValidationIssue[] => {
- const issues: WorkflowValidationIssue[] = [];
-
- for (const step of steps) {
- if (!WORKFLOW_VARIABLE_CONSUMING_ACTION_TYPES.has(step.type)) {
- continue;
- }
-
- const variables = extractVariablesFromInput(step.settings?.input);
-
- if (variables.length > 0) {
- continue;
- }
-
- issues.push({
- severity: 'warning',
- code: 'STEP_HAS_NO_VARIABLE_REFERENCE',
- message: `Step "${step.name ?? step.id}" does not reference any variable from previous steps.`,
- stepId: step.id,
- });
- }
-
- return issues;
-};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-trigger-type-requirements.util.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-trigger-type-requirements.util.ts
deleted file mode 100644
index 1f06ddbf8a2..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-trigger-type-requirements.util.ts
+++ /dev/null
@@ -1,30 +0,0 @@
-import {
- TRIGGER_STEP_ID,
- type WorkflowValidationIssue,
-} from 'twenty-shared/workflow';
-
-import {
- type WorkflowTrigger,
- WorkflowTriggerType,
-} from 'src/modules/workflow/workflow-trigger/types/workflow-trigger.type';
-import { hasWorkflowOutputSchema } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/has-workflow-output-schema.util';
-import { buildMissingWorkflowOutputSchemaIssue } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/build-missing-workflow-output-schema-issue.util';
-
-export const validateWorkflowTriggerTypeRequirements = (
- trigger: WorkflowTrigger | null,
-): WorkflowValidationIssue[] => {
- if (trigger?.type !== WorkflowTriggerType.WEBHOOK) {
- return [];
- }
-
- if (hasWorkflowOutputSchema(trigger.settings)) {
- return [];
- }
-
- return [
- buildMissingWorkflowOutputSchemaIssue({
- id: TRIGGER_STEP_ID,
- name: trigger.name,
- }),
- ];
-};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.module.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.module.ts
deleted file mode 100644
index bbeba66e940..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.module.ts
+++ /dev/null
@@ -1,18 +0,0 @@
-import { Module } from '@nestjs/common';
-
-import { WorkflowCommonModule } from 'src/modules/workflow/common/workflow-common.module';
-import { WorkflowMetadataReadModule } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.module';
-import { WorkflowSchemaModule } from 'src/modules/workflow/workflow-builder/workflow-schema/workflow-schema.module';
-
-import { WorkflowValidationWorkspaceService } from './workflow-validation.workspace-service';
-
-@Module({
- imports: [
- WorkflowCommonModule,
- WorkflowMetadataReadModule,
- WorkflowSchemaModule,
- ],
- providers: [WorkflowValidationWorkspaceService],
- exports: [WorkflowValidationWorkspaceService],
-})
-export class WorkflowValidationModule {}
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.workspace-service.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.workspace-service.ts
deleted file mode 100644
index 9736cfd72cc..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.workspace-service.ts
+++ /dev/null
@@ -1,401 +0,0 @@
-import { Injectable } from '@nestjs/common';
-
-import {
- isNonEmptyArray,
- isNonEmptyString,
- isObject,
- isString,
-} from '@sniptt/guards';
-import { inputSchemaToOutputSchema } from 'twenty-shared/logic-function';
-import { isDefined } from 'twenty-shared/utils';
-import {
- type BaseOutputSchemaV2,
- validateWorkflowStructure,
- WorkflowActionType,
- type WorkflowValidationIssue,
- type WorkflowValidationResult,
-} from 'twenty-shared/workflow';
-
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkflowMetadataReadService } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.workspace-service';
-import { WorkflowSchemaWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-schema/workflow-schema.workspace-service';
-import { getPickRecordLoadBalanceConfigError } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/get-pick-record-load-balance-config-error.util';
-import {
- type WorkflowAction,
- type WorkflowLogicFunctionAction,
-} from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import { type WorkflowTrigger } from 'src/modules/workflow/workflow-trigger/types/workflow-trigger.type';
-import { hasWorkflowStepLevelOutputSchema } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/has-workflow-step-level-output-schema.util';
-import { buildMissingWorkflowOutputSchemaIssue } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/build-missing-workflow-output-schema-issue.util';
-import { validateWorkflowTriggerTypeRequirements } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-trigger-type-requirements.util';
-import { validateWorkflowRuntimeOutputStep } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-runtime-output-step.util';
-import { validateWorkflowStepsHaveVariableReferences } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-steps-have-variable-references.util';
-import { validateWorkflowIteratorStep } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-iterator-step.util';
-import { validateWorkflowAiAgentStep } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-ai-agent-step.util';
-import { validateWorkflowLogicFunctionOutputSchemaMismatch } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-logic-function-output-schema-mismatch.util';
-import { WORKFLOW_RECORD_CRUD_ACTION_TYPES } from 'src/modules/workflow/workflow-builder/workflow-validation/constants/workflow-record-crud-action-types.constant';
-
-const OBJECT_TARGETING_ACTION_TYPES = new Set<WorkflowActionType>([
- ...WORKFLOW_RECORD_CRUD_ACTION_TYPES,
- WorkflowActionType.PICK_RECORD,
-]);
-
-@Injectable()
-export class WorkflowValidationWorkspaceService {
- constructor(
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- private readonly workflowMetadataReadService: WorkflowMetadataReadService,
- private readonly workflowSchemaWorkspaceService: WorkflowSchemaWorkspaceService,
- ) {}
-
- async validateWorkflowVersion({
- workspaceId,
- workflowVersionId,
- }: {
- workspaceId: string;
- workflowVersionId: string;
- }): Promise<WorkflowValidationResult> {
- const workflowVersion =
- await this.workflowCommonWorkspaceService.getWorkflowVersionOrFail({
- workspaceId,
- workflowVersionId,
- });
-
- return this.validateWorkflowDefinition({
- workspaceId,
- workflowVersionId,
- trigger: workflowVersion.trigger,
- steps: workflowVersion.steps,
- });
- }
-
- async validateWorkflowDefinition({
- workspaceId,
- workflowVersionId,
- trigger,
- steps,
- }: {
- workspaceId: string;
- workflowVersionId?: string;
- trigger: WorkflowTrigger | null;
- steps: WorkflowAction[] | null;
- }): Promise<WorkflowValidationResult> {
- const { trigger: enrichedTrigger, steps: enrichedSteps } =
- await this.enrichOutputSchemas({
- workspaceId,
- workflowVersionId,
- trigger,
- steps,
- });
-
- const staticResult = validateWorkflowStructure({
- trigger: enrichedTrigger,
- steps: enrichedSteps,
- });
-
- const triggerIssues =
- validateWorkflowTriggerTypeRequirements(enrichedTrigger);
-
- const semanticIssues = await this.validateStepTypeRequirements({
- workspaceId,
- steps: enrichedSteps ?? [],
- trigger: enrichedTrigger,
- });
-
- const metadataIssues = await this.validateWorkspaceMetadata({
- workspaceId,
- steps: enrichedSteps ?? [],
- });
-
- const variableReferenceIssues = validateWorkflowStepsHaveVariableReferences(
- enrichedSteps ?? [],
- );
-
- return mergeValidationResults(staticResult, [
- ...triggerIssues,
- ...semanticIssues,
- ...metadataIssues,
- ...variableReferenceIssues,
- ]);
- }
-
- private async enrichOutputSchemas({
- workspaceId,
- workflowVersionId,
- trigger,
- steps,
- }: {
- workspaceId: string;
- workflowVersionId?: string;
- trigger: WorkflowTrigger | null;
- steps: WorkflowAction[] | null;
- }): Promise<{
- trigger: WorkflowTrigger | null;
- steps: WorkflowAction[] | null;
- }> {
- const enrichedTrigger = isDefined(trigger)
- ? await this.withComputedOutputSchema({
- step: trigger,
- workspaceId,
- workflowVersionId,
- })
- : trigger;
-
- const enrichedSteps = isDefined(steps)
- ? await Promise.all(
- steps.map((step) =>
- this.withComputedOutputSchema({
- step,
- workspaceId,
- workflowVersionId,
- }),
- ),
- )
- : steps;
-
- return { trigger: enrichedTrigger, steps: enrichedSteps };
- }
-
- private async withComputedOutputSchema<
- TStep extends WorkflowTrigger | WorkflowAction,
- >({
- step,
- workspaceId,
- workflowVersionId,
- }: {
- step: TStep;
- workspaceId: string;
- workflowVersionId?: string;
- }): Promise<TStep> {
- try {
- const computedSchema =
- await this.workflowSchemaWorkspaceService.computeStepOutputSchema({
- step,
- workspaceId,
- workflowVersionId,
- });
-
- if (
- !isDefined(computedSchema) ||
- Object.keys(computedSchema).length === 0
- ) {
- return step;
- }
-
- return {
- ...step,
- settings: { ...step.settings, outputSchema: computedSchema },
- };
- } catch {
- // Output schema enrichment is best-effort: if it cannot be computed,
- // validation still runs against the step's existing settings rather
- // than failing the whole validation.
- return step;
- }
- }
-
- private async validateStepTypeRequirements({
- workspaceId,
- steps,
- trigger,
- }: {
- workspaceId: string;
- steps: WorkflowAction[];
- trigger: WorkflowTrigger | null;
- }): Promise<WorkflowValidationIssue[]> {
- const issues: WorkflowValidationIssue[] = [];
-
- for (const step of steps) {
- switch (step.type) {
- case WorkflowActionType.AI_AGENT:
- issues.push(...validateWorkflowAiAgentStep(step));
- break;
- case WorkflowActionType.CODE:
- case WorkflowActionType.HTTP_REQUEST:
- issues.push(...validateWorkflowRuntimeOutputStep(step));
- break;
- case WorkflowActionType.LOGIC_FUNCTION:
- issues.push(
- ...(await this.validateLogicFunctionStep({ step, workspaceId })),
- );
- break;
- case WorkflowActionType.ITERATOR:
- issues.push(
- ...validateWorkflowIteratorStep({ step, steps, trigger }),
- );
- break;
- }
- }
-
- return issues;
- }
-
- private async validateLogicFunctionStep({
- step,
- workspaceId,
- }: {
- step: WorkflowLogicFunctionAction;
- workspaceId: string;
- }): Promise<WorkflowValidationIssue[]> {
- const issues: WorkflowValidationIssue[] = [];
-
- const declaredOutputSchema =
- await this.getLogicFunctionDeclaredOutputSchema({
- step,
- workspaceId,
- });
-
- issues.push(
- ...validateWorkflowLogicFunctionOutputSchemaMismatch({
- step,
- declaredOutputSchema,
- }),
- );
-
- if (hasWorkflowStepLevelOutputSchema(step)) {
- return issues;
- }
-
- if (isDefined(declaredOutputSchema)) {
- return issues;
- }
-
- issues.push(
- buildMissingWorkflowOutputSchemaIssue({ id: step.id, name: step.name }),
- );
-
- return issues;
- }
-
- private async getLogicFunctionDeclaredOutputSchema({
- step,
- workspaceId,
- }: {
- step: WorkflowAction;
- workspaceId: string;
- }): Promise<BaseOutputSchemaV2 | undefined> {
- const input = step.settings?.input;
- const logicFunctionId =
- isObject(input) && 'logicFunctionId' in input
- ? input.logicFunctionId
- : undefined;
-
- if (!isNonEmptyString(logicFunctionId)) {
- return undefined;
- }
-
- try {
- const logicFunction =
- await this.workflowMetadataReadService.getLogicFunctionById({
- logicFunctionId,
- workspaceId,
- });
-
- const declaredInputSchema =
- logicFunction?.workflowActionTriggerSettings?.outputSchema;
-
- if (!isNonEmptyArray(declaredInputSchema)) {
- return undefined;
- }
-
- const declaredOutputSchema =
- inputSchemaToOutputSchema(declaredInputSchema);
-
- if (Object.keys(declaredOutputSchema).length === 0) {
- return undefined;
- }
-
- return declaredOutputSchema;
- } catch {
- return undefined;
- }
- }
-
- private async validateWorkspaceMetadata({
- workspaceId,
- steps,
- }: {
- workspaceId: string;
- steps: WorkflowAction[];
- }): Promise<WorkflowValidationIssue[]> {
- const recordSteps = steps.filter((step) =>
- OBJECT_TARGETING_ACTION_TYPES.has(step.type),
- );
-
- if (recordSteps.length === 0) {
- return [];
- }
-
- const { objectIdByNameSingular, flatFieldMetadataMaps } =
- await this.workflowMetadataReadService.getFlatEntityMaps(workspaceId);
-
- const issues: WorkflowValidationIssue[] = [];
-
- for (const step of recordSteps) {
- const input = step.settings.input;
- const objectName =
- isObject(input) && 'objectName' in input ? input.objectName : undefined;
-
- if (!isString(objectName)) {
- issues.push({
- severity: 'error',
- code: 'INVALID_STEP_PARAMS',
- message: `Step "${step.name ?? step.id}" has an invalid object name.`,
- stepId: step.id,
- });
-
- continue;
- }
-
- if (!isDefined(objectIdByNameSingular[objectName])) {
- issues.push({
- severity: 'error',
- code: 'INVALID_STEP_PARAMS',
- message: `Step "${step.name ?? step.id}" targets object "${objectName}" which does not exist in this workspace.`,
- stepId: step.id,
- });
-
- continue;
- }
-
- if (step.type === WorkflowActionType.PICK_RECORD) {
- const loadBalanceError = getPickRecordLoadBalanceConfigError({
- step,
- objectIdByNameSingular,
- flatFieldMetadataMaps,
- });
-
- if (isDefined(loadBalanceError)) {
- issues.push({
- severity: 'error',
- code: 'INVALID_STEP_PARAMS',
- message: loadBalanceError,
- stepId: step.id,
- });
- }
- }
- }
-
- return issues;
- }
-}
-
-const mergeValidationResults = (
- baseResult: WorkflowValidationResult,
- additionalIssues: WorkflowValidationIssue[],
-): WorkflowValidationResult => {
- const errors = [
- ...baseResult.errors,
- ...additionalIssues.filter((issue) => issue.severity === 'error'),
- ];
- const warnings = [
- ...baseResult.warnings,
- ...additionalIssues.filter((issue) => issue.severity === 'warning'),
- ];
-
- return {
- valid: errors.length === 0,
- errors,
- warnings,
- };
-};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.module.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.module.ts
new file mode 100644
index 00000000000..8d510188cc4
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.module.ts
@@ -0,0 +1,11 @@
+import { Module } from '@nestjs/common';
+
+import { WorkflowMetadataReadModule } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.module';
+import { WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.workspace-service';
+
+@Module({
+ imports: [WorkflowMetadataReadModule],
+ providers: [WorkflowVersionValidationWorkspaceService],
+ exports: [WorkflowVersionValidationWorkspaceService],
+})
+export class WorkflowVersionValidationModule {}
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.workspace-service.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.workspace-service.ts
new file mode 100644
index 00000000000..2dbe127b2d6
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.workspace-service.ts
@@ -0,0 +1,120 @@
+import { Injectable } from '@nestjs/common';
+
+import {
+ MALFORMED_WORKFLOW_VALIDATION_ISSUE_CODES,
+ NON_ACTIVABLE_WORKFLOW_VALIDATION_ISSUE_CODES,
+ validateWorkflowStructure,
+ WorkflowActionType,
+ type WorkflowValidationIssue,
+} from 'twenty-shared/workflow';
+
+import { WorkflowMetadataReadService } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.workspace-service';
+import { OBJECT_TARGETING_ACTION_TYPES } from 'src/modules/workflow/workflow-builder/workflow-validation/constants/object-targeting-action-types.constant';
+import {
+ WorkflowVersionValidationException,
+ WorkflowVersionValidationExceptionCode,
+} from 'src/modules/workflow/workflow-builder/workflow-validation/exceptions/workflow-version-validation.exception';
+import { getWorkflowRecordStepMetadataIssues } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/get-workflow-record-step-metadata-issues.util';
+import { validateWorkflowAiAgentStep } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/validate-workflow-ai-agent-step.util';
+import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
+import { type WorkflowTrigger } from 'src/modules/workflow/workflow-trigger/types/workflow-trigger.type';
+
+const isBlockingActivation = (issue: WorkflowValidationIssue): boolean =>
+ MALFORMED_WORKFLOW_VALIDATION_ISSUE_CODES.has(issue.code) ||
+ NON_ACTIVABLE_WORKFLOW_VALIDATION_ISSUE_CODES.has(issue.code);
+
+@Injectable()
+export class WorkflowVersionValidationWorkspaceService {
+ constructor(
+ private readonly workflowMetadataReadService: WorkflowMetadataReadService,
+ ) {}
+
+ // Malformed content is rejected at the write chokepoint, but legacy versions
+ // written before that gate can still hold some, so activation refuses both
+ // the malformed and the non-activable codes.
+ async assertWorkflowVersionIsActivableOrThrow({
+ workspaceId,
+ trigger,
+ steps,
+ }: {
+ workspaceId: string;
+ trigger: WorkflowTrigger | null | undefined;
+ steps: WorkflowAction[] | null | undefined;
+ }): Promise<void> {
+ const issues = await this.collectIssues({
+ workspaceId,
+ trigger: trigger ?? null,
+ steps: steps ?? [],
+ });
+
+ const blockingIssues = issues.filter(isBlockingActivation);
+
+ if (blockingIssues.length === 0) {
+ return;
+ }
+
+ throw new WorkflowVersionValidationException(
+ WorkflowVersionValidationExceptionCode.NON_ACTIVABLE_WORKFLOW_VERSION,
+ blockingIssues,
+ );
+ }
+
+ private async collectIssues({
+ workspaceId,
+ trigger,
+ steps,
+ }: {
+ workspaceId: string;
+ trigger: WorkflowTrigger | null;
+ steps: WorkflowAction[];
+ }): Promise<WorkflowValidationIssue[]> {
+ const structureResult = validateWorkflowStructure({ trigger, steps });
+
+ const stepTypeIssues = steps.flatMap((step) =>
+ step.type === WorkflowActionType.AI_AGENT
+ ? validateWorkflowAiAgentStep(step)
+ : [],
+ );
+
+ const metadataIssues = await this.validateWorkspaceMetadata({
+ workspaceId,
+ steps,
+ });
+
+ return [
+ ...structureResult.errors,
+ ...structureResult.warnings,
+ ...stepTypeIssues,
+ ...metadataIssues,
+ ];
+ }
+
+ private async validateWorkspaceMetadata({
+ workspaceId,
+ steps,
+ }: {
+ workspaceId: string;
+ steps: WorkflowAction[];
+ }): Promise<WorkflowValidationIssue[]> {
+ const hasRecordStep = steps.some((step) =>
+ OBJECT_TARGETING_ACTION_TYPES.has(step.type),
+ );
+
+ if (!hasRecordStep) {
+ return [];
+ }
+
+ const {
+ objectIdByNameSingular,
+ flatObjectMetadataMaps,
+ flatFieldMetadataMaps,
+ } = await this.workflowMetadataReadService.getFlatEntityMaps(workspaceId);
+
+ return getWorkflowRecordStepMetadataIssues({
+ steps,
+ flatObjectMetadataMaps,
+ flatFieldMetadataMaps,
+ objectIdByNameSingular,
+ });
+ }
+}
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/find-rich-text-field-names.util.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/find-rich-text-field-names.util.ts
new file mode 100644
index 00000000000..28323bb7765
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/find-rich-text-field-names.util.ts
@@ -0,0 +1,22 @@
+import { FieldMetadataType } from 'twenty-shared/types';
+import { isDefined } from 'twenty-shared/utils';
+
+import { findManyFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-many-flat-entity-by-id-in-flat-entity-maps.util';
+import { type ObjectMetadataInfo } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.workspace-service';
+
+export const findRichTextFieldNames = (
+ objectMetadataInfo: Pick<
+ ObjectMetadataInfo,
+ 'flatObjectMetadata' | 'flatFieldMetadataMaps'
+ >,
+): string[] => {
+ const { flatObjectMetadata, flatFieldMetadataMaps } = objectMetadataInfo;
+
+ return findManyFlatEntityByIdInFlatEntityMaps({
+ flatEntityIds: flatObjectMetadata.fieldIds,
+ flatEntityMaps: flatFieldMetadataMaps,
+ })
+ .filter((field) => field?.type === FieldMetadataType.RICH_TEXT)
+ .map((field) => field?.name)
+ .filter(isDefined);
+};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/resolve-rich-text-fields-in-record.util.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/resolve-rich-text-fields-in-record.util.ts
index 81aa46869c0..4e35a7198ff 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/resolve-rich-text-fields-in-record.util.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/resolve-rich-text-fields-in-record.util.ts
@@ -1,24 +1,15 @@
import { isString } from 'class-validator';
-import { FieldMetadataType } from 'twenty-shared/types';
import { isDefined, resolveRichTextVariables } from 'twenty-shared/utils';
-import { findManyFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-many-flat-entity-by-id-in-flat-entity-maps.util';
import { type ObjectMetadataInfo } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
+import { findRichTextFieldNames } from 'src/modules/workflow/workflow-executor/utils/find-rich-text-field-names.util';
export const resolveRichTextFieldsInRecord = (
objectRecord: Record<string, unknown>,
objectMetadataInfo: ObjectMetadataInfo,
context: Record<string, unknown>,
): Record<string, unknown> => {
- const { flatObjectMetadata, flatFieldMetadataMaps } = objectMetadataInfo;
-
- const richTextFieldNames = findManyFlatEntityByIdInFlatEntityMaps({
- flatEntityIds: flatObjectMetadata.fieldIds,
- flatEntityMaps: flatFieldMetadataMaps,
- })
- .filter((field) => field?.type === FieldMetadataType.RICH_TEXT)
- .map((field) => field?.name)
- .filter(isDefined);
+ const richTextFieldNames = findRichTextFieldNames(objectMetadataInfo);
const resolvedRecord = { ...objectRecord };
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/services/workflow-tool.workspace-service.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/services/workflow-tool.workspace-service.ts
index 57895b589ff..86acdf15255 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/services/workflow-tool.workspace-service.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-tools/services/workflow-tool.workspace-service.ts
@@ -11,7 +11,7 @@ import { WorkspaceOrmManager } from 'src/engine/twenty-orm/workspace-orm.manager
import { type RolePermissionConfig } from 'src/engine/twenty-orm/types/role-permission-config';
import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
import { WorkflowSchemaWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-schema/workflow-schema.workspace-service';
-import { WorkflowValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.workspace-service';
+import { WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.workspace-service';
import { WorkflowVersionEdgeWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-edge/workflow-version-edge.workspace-service';
import { WorkflowVersionStepHelpersWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step-helpers.workspace-service';
import { WorkflowVersionStepWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step.workspace-service';
@@ -52,7 +52,7 @@ export class WorkflowToolWorkspaceService {
workflowVersionService: WorkflowVersionWorkspaceService,
workflowTriggerService: WorkflowTriggerWorkspaceService,
workflowSchemaService: WorkflowSchemaWorkspaceService,
- workflowValidationService: WorkflowValidationWorkspaceService,
+ workflowVersionValidationWorkspaceService: WorkflowVersionValidationWorkspaceService,
workspaceOrmManager: WorkspaceOrmManager,
recordPositionService: RecordPositionService,
logicFunctionFromSourceService: LogicFunctionFromSourceService,
@@ -68,7 +68,7 @@ export class WorkflowToolWorkspaceService {
workflowVersionService,
workflowTriggerService,
workflowSchemaService,
- workflowValidationService,
+ workflowVersionValidationWorkspaceService,
workspaceOrmManager,
recordPositionService,
logicFunctionFromSourceService,
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/tools/__tests__/update-workflow-version-step.tool.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/tools/__tests__/update-workflow-version-step.tool.spec.ts
index 8b872b18347..5abe4929f99 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/tools/__tests__/update-workflow-version-step.tool.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-tools/tools/__tests__/update-workflow-version-step.tool.spec.ts
@@ -8,27 +8,17 @@ const mockStep = {
settings: { input: {} },
};
-const buildTool = ({
- validationResult = { valid: true, errors: [], warnings: [] },
-}: {
- validationResult?: object;
-} = {}) => {
+const buildTool = () => {
const workflowVersionStepService = {
updateWorkflowVersionStep: jest.fn().mockResolvedValue(mockStep),
};
- const workflowValidationService = {
- validateWorkflowVersion: jest.fn().mockResolvedValue(validationResult),
- };
const tool = createUpdateWorkflowVersionStepTool(
- {
- workflowVersionStepService,
- workflowValidationService,
- } as never,
+ { workflowVersionStepService } as never,
{ workspaceId: 'workspace-id' },
);
- return { tool, workflowVersionStepService, workflowValidationService };
+ return { tool, workflowVersionStepService };
};
const baseInput = {
@@ -43,63 +33,31 @@ describe('createUpdateWorkflowVersionStepTool', () => {
jest.clearAllMocks();
});
- it('should validate by default and return a compact summary', async () => {
- const { tool, workflowValidationService } = buildTool({
- validationResult: {
- valid: false,
- errors: [
- {
- severity: 'error',
- code: 'DANGLING_REFERENCE',
- message: 'Unknown variable',
- availablePaths: ['{{trigger.x}}'],
- },
- ],
- warnings: [{ severity: 'warning', code: 'NO_STEPS', message: 'w' }],
- },
- });
-
- const result = (await tool.execute(baseInput)) as Record<string, unknown>;
-
- expect(
- workflowValidationService.validateWorkflowVersion,
- ).toHaveBeenCalled();
-
- const validation = result.validation as Record<string, unknown>;
-
- expect(validation.valid).toBe(false);
- expect(validation.errorCount).toBe(1);
- expect(validation.warningCount).toBe(1);
- expect(validation).not.toHaveProperty('warnings');
- expect((validation.errors as object[])[0]).not.toHaveProperty(
- 'availablePaths',
- );
- });
-
- it('should skip validation entirely when validate is false', async () => {
- const { tool, workflowValidationService } = buildTool();
+ it('updates the step and returns the result', async () => {
+ const { tool, workflowVersionStepService } = buildTool();
- const result = (await tool.execute({
- ...baseInput,
- validate: false,
- })) as Record<string, unknown>;
+ const result = await tool.execute(baseInput);
expect(
- workflowValidationService.validateWorkflowVersion,
- ).not.toHaveBeenCalled();
- expect(result).not.toHaveProperty('validation');
+ workflowVersionStepService.updateWorkflowVersionStep,
+ ).toHaveBeenCalledWith({
+ workspaceId: 'workspace-id',
+ workflowVersionId: baseInput.workflowVersionId,
+ step: mockStep,
+ });
+ expect(result).toEqual(mockStep);
});
- it('should still return the step result when validation throws', async () => {
- const { tool, workflowValidationService } = buildTool();
+ it('returns a failure when the update throws', async () => {
+ const { tool, workflowVersionStepService } = buildTool();
- workflowValidationService.validateWorkflowVersion.mockRejectedValue(
+ workflowVersionStepService.updateWorkflowVersionStep.mockRejectedValue(
new Error('boom'),
);
const result = (await tool.execute(baseInput)) as Record<string, unknown>;
- expect(result.validationError).toBe('boom');
- expect(result).not.toHaveProperty('validation');
+ expect(result.success).toBe(false);
+ expect(result.error).toBe('boom');
});
});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/tools/create-complete-workflow.tool.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/tools/create-complete-workflow.tool.ts
index 22c64794cca..04c4bb52715 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/tools/create-complete-workflow.tool.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-tools/tools/create-complete-workflow.tool.ts
@@ -20,7 +20,6 @@ import {
type WorkflowToolContext,
type WorkflowToolDependencies,
} from 'src/modules/workflow/workflow-tools/types/workflow-tool-dependencies.type';
-import { summarizeValidation } from 'src/modules/workflow/workflow-tools/utils/summarize-validation.util';
import { type WorkflowTrigger } from 'src/modules/workflow/workflow-trigger/types/workflow-trigger.type';
const createCompleteWorkflowSchema = z.object({
@@ -60,7 +59,6 @@ type CreateCompleteWorkflowToolDeps = Pick<
| 'workflowTriggerService'
| 'workspaceOrmManager'
| 'recordPositionService'
- | 'workflowValidationService'
| 'workflowVersionCoreSyncService'
>;
@@ -81,6 +79,7 @@ CRITICAL SCHEMA REQUIREMENTS:
- Each step MUST include: id (must be a valid UUID), name, type, valid, settings
- CREATE_RECORD actions MUST have objectName and objectRecord in settings.input
- objectRecord must contain actual field values, not just field names
+- RICH_TEXT fields (e.g. a note/task "body") MUST be an object, not a string: { "markdown": "your text, may contain {{variables}}" }. A bare string is rejected.
- Use "trigger" as the id for the trigger step in edges
- Step positions are computed automatically; do not provide coordinates
@@ -106,7 +105,7 @@ IMPORTANT: The tool schema provides comprehensive field descriptions, examples,
This is the most efficient way for AI to create workflows as it handles all the complexity in one call.
-The response includes a compact validation summary. For the full validation report with available variable paths, call validate_workflow once after your edits — not after every change.`,
+Call validate_workflow once when the workflow is complete, before activating.`,
inputSchema: createCompleteWorkflowSchema,
execute: async (parameters: {
name: string;
@@ -189,12 +188,6 @@ The response includes a compact validation summary. For the full validation repo
});
}
- const validation =
- await deps.workflowValidationService.validateWorkflowVersion({
- workspaceId: context.workspaceId,
- workflowVersionId,
- });
-
return {
success: true,
message: `Workflow "${parameters.name}" created successfully with ${parameters.steps.length} steps`,
@@ -203,7 +196,6 @@ The response includes a compact validation summary. For the full validation repo
workflowVersionId,
name: parameters.name,
stepIds: parameters.steps.map((step) => step.id),
- validation: summarizeValidation(validation),
},
recordReferences: [
{
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/tools/update-workflow-version-step.tool.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/tools/update-workflow-version-step.tool.ts
index 7df70c4208f..1e9f722e0bc 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/tools/update-workflow-version-step.tool.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-tools/tools/update-workflow-version-step.tool.ts
@@ -6,7 +6,6 @@ import {
type WorkflowToolContext,
type WorkflowToolDependencies,
} from 'src/modules/workflow/workflow-tools/types/workflow-tool-dependencies.type';
-import { summarizeValidation } from 'src/modules/workflow/workflow-tools/utils/summarize-validation.util';
const updateWorkflowVersionStepSchema = z.object({
workflowVersionId: z
@@ -16,35 +15,19 @@ const updateWorkflowVersionStepSchema = z.object({
step: z
.union([workflowActionSchema])
.describe('The updated step configuration'),
- validate: z
- .boolean()
- .optional()
- .default(true)
- .describe(
- 'Run a quick validation and return a compact summary (default true). Set to false when making several edits in a row, then call validate_workflow once at the end instead.',
- ),
});
-type UpdateWorkflowVersionStepToolInput = UpdateWorkflowVersionStepInput & {
- validate?: boolean;
-};
-
export const createUpdateWorkflowVersionStepTool = (
- deps: Pick<
- WorkflowToolDependencies,
- 'workflowVersionStepService' | 'workflowValidationService'
- >,
+ deps: Pick<WorkflowToolDependencies, 'workflowVersionStepService'>,
context: WorkflowToolContext,
) => ({
name: 'update_workflow_version_step' as const,
description:
- 'Update an existing step in a workflow version. This modifies the step configuration. Returns a compact validation summary; for the full report with available variable paths, call validate_workflow once after your edits — not after every change.',
+ 'Update an existing step in a workflow version. This modifies the step configuration. Call validate_workflow once after your edits are done, not after every change.',
inputSchema: updateWorkflowVersionStepSchema,
- execute: async (parameters: UpdateWorkflowVersionStepToolInput) => {
- let result;
-
+ execute: async (parameters: UpdateWorkflowVersionStepInput) => {
try {
- result = await deps.workflowVersionStepService.updateWorkflowVersionStep({
+ return await deps.workflowVersionStepService.updateWorkflowVersionStep({
workspaceId: context.workspaceId,
workflowVersionId: parameters.workflowVersionId,
step: parameters.step,
@@ -56,28 +39,5 @@ export const createUpdateWorkflowVersionStepTool = (
message: `Failed to update workflow version step: ${error.message}`,
};
}
-
- if (parameters.validate === false) {
- return result;
- }
-
- try {
- const validation =
- await deps.workflowValidationService.validateWorkflowVersion({
- workspaceId: context.workspaceId,
- workflowVersionId: parameters.workflowVersionId,
- });
-
- return {
- ...result,
- validation: summarizeValidation(validation),
- };
- } catch (error) {
- return {
- ...result,
- validationError: error.message,
- message: `Step updated successfully, but validation could not be computed: ${error.message}`,
- };
- }
},
});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/tools/validate-workflow.tool.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/tools/validate-workflow.tool.ts
index f036e564a90..d74215dd346 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/tools/validate-workflow.tool.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-tools/tools/validate-workflow.tool.ts
@@ -1,6 +1,8 @@
import { z } from 'zod';
-import { type WorkflowValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.workspace-service';
+import { type WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
+import { WorkflowVersionValidationException } from 'src/modules/workflow/workflow-builder/workflow-validation/exceptions/workflow-version-validation.exception';
+import { type WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.workspace-service';
import { type WorkflowToolContext } from 'src/modules/workflow/workflow-tools/types/workflow-tool-dependencies.type';
const validateWorkflowSchema = z.object({
@@ -14,32 +16,49 @@ type ValidateWorkflowInput = z.infer<typeof validateWorkflowSchema>;
export const createValidateWorkflowTool = (
deps: {
- workflowValidationService: WorkflowValidationWorkspaceService;
+ workflowCommonService: WorkflowCommonWorkspaceService;
+ workflowVersionValidationWorkspaceService: WorkflowVersionValidationWorkspaceService;
},
context: WorkflowToolContext,
) => ({
name: 'validate_workflow' as const,
description:
- 'Validate a workflow version for correctness. Checks graph topology (connections, reachability, branches, loops), per-step configuration, references to other objects, and variable references between steps. Returns a list of errors and warnings to fix. Does not block or modify the workflow.',
+ 'Check whether a workflow version can be activated, without activating it. Runs the exact check activation runs: graph topology (connections, reachability, branches, loops), per-step configuration, references to other objects, and variable references between steps. Succeeds when the version is ready; otherwise fails with the list of issues to fix. Does not modify the workflow.',
inputSchema: validateWorkflowSchema,
execute: async (parameters: ValidateWorkflowInput) => {
try {
- const result =
- await deps.workflowValidationService.validateWorkflowVersion({
+ const workflowVersion =
+ await deps.workflowCommonService.getWorkflowVersionOrFail({
workspaceId: context.workspaceId,
workflowVersionId: parameters.workflowVersionId,
});
+ await deps.workflowVersionValidationWorkspaceService.assertWorkflowVersionIsActivableOrThrow(
+ {
+ workspaceId: context.workspaceId,
+ trigger: workflowVersion.trigger,
+ steps: workflowVersion.steps,
+ },
+ );
+
return {
success: true,
- valid: result.valid,
- errors: result.errors,
- warnings: result.warnings,
- message: result.valid
- ? 'The workflow is valid.'
- : `The workflow has ${result.errors.length} error(s) that should be fixed.`,
+ message: 'The workflow version can be activated.',
};
} catch (error) {
+ if (error instanceof WorkflowVersionValidationException) {
+ return {
+ success: false,
+ error: error.message,
+ issues: error.issues.map(({ code, message, stepId }) => ({
+ code,
+ message,
+ stepId,
+ })),
+ message: `The workflow version has ${error.issues.length} issue(s) to fix before it can be activated.`,
+ };
+ }
+
return {
success: false,
error: error.message,
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/types/workflow-tool-dependencies.type.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/types/workflow-tool-dependencies.type.ts
index 272b634a95b..2bf02d53551 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/types/workflow-tool-dependencies.type.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-tools/types/workflow-tool-dependencies.type.ts
@@ -6,7 +6,7 @@ import type { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/me
import type { WorkspaceOrmManager } from 'src/engine/twenty-orm/workspace-orm.manager';
import type { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
import type { WorkflowSchemaWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-schema/workflow-schema.workspace-service';
-import type { WorkflowValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.workspace-service';
+import type { WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.workspace-service';
import type { WorkflowVersionEdgeWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-edge/workflow-version-edge.workspace-service';
import type { WorkflowVersionStepHelpersWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step-helpers.workspace-service';
import type { WorkflowVersionStepWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step.workspace-service';
@@ -20,7 +20,7 @@ export type WorkflowToolDependencies = {
workflowVersionService: WorkflowVersionWorkspaceService;
workflowTriggerService: WorkflowTriggerWorkspaceService;
workflowSchemaService: WorkflowSchemaWorkspaceService;
- workflowValidationService: WorkflowValidationWorkspaceService;
+ workflowVersionValidationWorkspaceService: WorkflowVersionValidationWorkspaceService;
workspaceOrmManager: WorkspaceOrmManager;
recordPositionService: RecordPositionService;
logicFunctionFromSourceService: LogicFunctionFromSourceService;
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/utils/__tests__/summarize-validation.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/utils/__tests__/summarize-validation.util.spec.ts
deleted file mode 100644
index 57b7999d7b8..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/utils/__tests__/summarize-validation.util.spec.ts
+++ /dev/null
@@ -1,97 +0,0 @@
-import { type WorkflowValidationResult } from 'twenty-shared/workflow';
-
-import { summarizeValidation } from 'src/modules/workflow/workflow-tools/utils/summarize-validation.util';
-
-describe('summarizeValidation', () => {
- it('should return a minimal summary for a valid workflow', () => {
- const result: WorkflowValidationResult = {
- valid: true,
- errors: [],
- warnings: [],
- };
-
- expect(summarizeValidation(result)).toEqual({
- valid: true,
- errorCount: 0,
- warningCount: 0,
- errors: [],
- });
- });
-
- it('should keep error essentials and drop availablePaths and hint', () => {
- const result: WorkflowValidationResult = {
- valid: false,
- errors: [
- {
- severity: 'error',
- code: 'DANGLING_REFERENCE',
- message: 'Unknown variable {{step-1.foo}}',
- stepId: 'step-2',
- path: 'settings.input.body',
- hint: 'some long hint',
- suggestions: ['{{step-1.bar}}'],
- availablePaths: ['{{step-1.bar}}', '{{step-1.baz}}', '{{trigger.x}}'],
- },
- ],
- warnings: [],
- };
-
- const summary = summarizeValidation(result);
-
- expect(summary.valid).toBe(false);
- expect(summary.errorCount).toBe(1);
- expect(summary.errors[0]).toEqual({
- code: 'DANGLING_REFERENCE',
- message: 'Unknown variable {{step-1.foo}}',
- stepId: 'step-2',
- path: 'settings.input.body',
- suggestions: ['{{step-1.bar}}'],
- });
- expect(summary.errors[0]).not.toHaveProperty('availablePaths');
- expect(summary.errors[0]).not.toHaveProperty('hint');
- });
-
- it('should collapse warnings to a count', () => {
- const result: WorkflowValidationResult = {
- valid: true,
- errors: [],
- warnings: [
- {
- severity: 'warning',
- code: 'UNREACHABLE_STEP',
- message: 'Step is unreachable',
- },
- {
- severity: 'warning',
- code: 'TRIGGER_HAS_NO_NEXT_STEP',
- message: 'Trigger has no next step',
- },
- ],
- };
-
- const summary = summarizeValidation(result);
-
- expect(summary.warningCount).toBe(2);
- expect(summary).not.toHaveProperty('warnings');
- expect(summary.hint).toContain('validate_workflow');
- });
-
- it('should omit empty suggestions', () => {
- const result: WorkflowValidationResult = {
- valid: false,
- errors: [
- {
- severity: 'error',
- code: 'NO_STEPS',
- message: 'The workflow has no steps.',
- suggestions: [],
- },
- ],
- warnings: [],
- };
-
- expect(summarizeValidation(result).errors[0]).not.toHaveProperty(
- 'suggestions',
- );
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/utils/summarize-validation.util.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/utils/summarize-validation.util.ts
deleted file mode 100644
index 812fa410a85..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/utils/summarize-validation.util.ts
+++ /dev/null
@@ -1,43 +0,0 @@
-import {
- type WorkflowValidationIssue,
- type WorkflowValidationResult,
-} from 'twenty-shared/workflow';
-
-export type WorkflowValidationSummary = {
- valid: boolean;
- errorCount: number;
- warningCount: number;
- errors: Array<
- Pick<
- WorkflowValidationIssue,
- 'code' | 'stepId' | 'path' | 'message' | 'suggestions'
- >
- >;
- hint?: string;
-};
-
-export const summarizeValidation = (
- result: WorkflowValidationResult,
-): WorkflowValidationSummary => {
- const summary: WorkflowValidationSummary = {
- valid: result.valid,
- errorCount: result.errors.length,
- warningCount: result.warnings.length,
- errors: result.errors.map(
- ({ code, stepId, path, message, suggestions }) => ({
- code,
- stepId,
- path,
- message,
- ...(suggestions && suggestions.length > 0 ? { suggestions } : {}),
- }),
- ),
- };
-
- if (!result.valid || result.warnings.length > 0) {
- summary.hint =
- 'Compact summary. For the full report including warnings and available variable paths, call validate_workflow.';
- }
-
- return summary;
-};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/workflow-tools.module.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/workflow-tools.module.ts
index e5183b2e0aa..bca6621d143 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/workflow-tools.module.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-tools/workflow-tools.module.ts
@@ -8,7 +8,7 @@ import { LogicFunctionModule } from 'src/engine/metadata-modules/logic-function/
import { WorkflowVersionCoreModule } from 'src/engine/core-modules/workflow/workflow-version-core.module';
import { WorkflowCommonModule } from 'src/modules/workflow/common/workflow-common.module';
import { WorkflowSchemaModule } from 'src/modules/workflow/workflow-builder/workflow-schema/workflow-schema.module';
-import { WorkflowValidationModule } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.module';
+import { WorkflowVersionValidationModule } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.module';
import { WorkflowVersionEdgeModule } from 'src/modules/workflow/workflow-builder/workflow-version-edge/workflow-version-edge.module';
import { WorkflowVersionStepModule } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step.module';
import { WorkflowVersionModule } from 'src/modules/workflow/workflow-builder/workflow-version/workflow-version.module';
@@ -27,7 +27,7 @@ import { WorkflowToolWorkspaceService } from './services/workflow-tool.workspace
WorkflowTriggerModule,
WorkflowCommonModule,
WorkflowSchemaModule,
- WorkflowValidationModule,
+ WorkflowVersionValidationModule,
RecordPositionModule,
LogicFunctionModule,
WorkspaceManyOrAllFlatEntityMapsCacheModule,
diff --git a/packages/twenty-server/src/modules/workflow/workflow-trigger/workflow-trigger.module.ts b/packages/twenty-server/src/modules/workflow/workflow-trigger/workflow-trigger.module.ts
index 8033f263bd0..4de5f6fa66f 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-trigger/workflow-trigger.module.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-trigger/workflow-trigger.module.ts
@@ -1,5 +1,7 @@
import { Module } from '@nestjs/common';
+import { WorkflowVersionValidationModule } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.module';
+
import { CacheStorageModule } from 'src/engine/core-modules/cache-storage/cache-storage.module';
import { FeatureFlagModule } from 'src/engine/core-modules/feature-flag/feature-flag.module';
import { CommandMenuItemModule } from 'src/engine/metadata-modules/command-menu-item/command-menu-item.module';
@@ -25,6 +27,7 @@ import { WorkflowTriggerWorkspaceService } from 'src/modules/workflow/workflow-t
FeatureFlagModule,
LogicFunctionModule,
WorkflowVersionCoreModule,
+ WorkflowVersionValidationModule,
],
providers: [WorkflowTriggerWorkspaceService, WorkflowTriggerJob],
exports: [WorkflowTriggerWorkspaceService],
diff --git a/packages/twenty-server/src/modules/workflow/workflow-trigger/workspace-services/workflow-trigger.workspace-service.ts b/packages/twenty-server/src/modules/workflow/workflow-trigger/workspace-services/workflow-trigger.workspace-service.ts
index 322ef03193e..23e2744f6ef 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-trigger/workspace-services/workflow-trigger.workspace-service.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-trigger/workspace-services/workflow-trigger.workspace-service.ts
@@ -28,6 +28,7 @@ import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standa
import { assertWorkflowVersionTriggerIsDefined } from 'src/modules/workflow/common/utils/assert-workflow-version-trigger-is-defined.util';
import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
import { getPickRecordLoadBalanceConfigError } from 'src/modules/workflow/workflow-builder/workflow-validation/utils/get-pick-record-load-balance-config-error.util';
+import { WorkflowVersionValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-version-validation.workspace-service';
import { CodeStepBuildService } from 'src/modules/workflow/workflow-builder/workflow-version-step/code-step/services/code-step-build.service';
import {
type WorkflowAction,
@@ -58,6 +59,7 @@ export class WorkflowTriggerWorkspaceService {
private readonly logger = new Logger(WorkflowTriggerWorkspaceService.name);
constructor(
+ private readonly workflowVersionValidationWorkspaceService: WorkflowVersionValidationWorkspaceService,
private readonly workspaceOrmManager: WorkspaceOrmManager,
private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
private readonly codeStepBuildService: CodeStepBuildService,
@@ -136,6 +138,14 @@ export class WorkflowTriggerWorkspaceService {
);
}
+ await this.workflowVersionValidationWorkspaceService.assertWorkflowVersionIsActivableOrThrow(
+ {
+ workspaceId,
+ trigger: workflowVersion.trigger,
+ steps: workflowVersion.steps,
+ },
+ );
+
assertVersionCanBeActivated(workflowVersion, workflow);
await this.assertPickRecordLoadBalanceConfigIsValid({
diff --git a/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-ai-tool-malformed-validation.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-ai-tool-malformed-validation.integration-spec.ts
new file mode 100644
index 00000000000..31b629b3a8a
--- /dev/null
+++ b/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-ai-tool-malformed-validation.integration-spec.ts
@@ -0,0 +1,131 @@
+import { randomUUID } from 'node:crypto';
+
+import request from 'supertest';
+import { deleteRecordsByIds } from 'test/integration/utils/delete-records-by-ids';
+
+const baseUrl = `http://localhost:${APP_PORT}`;
+
+type McpToolCallResult = {
+ content?: Array<{ type: string; text: string }>;
+ isError?: boolean;
+};
+
+const callMcpTool = async (
+ name: string,
+ args: Record<string, unknown>,
+): Promise<McpToolCallResult> => {
+ const res = await request(baseUrl)
+ .post('/mcp')
+ .set('Authorization', `Bearer ${API_KEY_ACCESS_TOKEN}`)
+ .set('Content-Type', 'application/json')
+ .set('Accept', 'application/json')
+ .send(
+ JSON.stringify({
+ jsonrpc: '2.0',
+ method: 'tools/call',
+ id: `call-${randomUUID()}`,
+ params: { name, arguments: args },
+ }),
+ )
+ .expect(200);
+
+ expect(res.body.error).toBeUndefined();
+
+ return res.body.result as McpToolCallResult;
+};
+
+const buildCreateRecordStep = (objectRecord: Record<string, unknown>) => ({
+ id: randomUUID(),
+ name: 'Create Record',
+ type: 'CREATE_RECORD',
+ valid: true,
+ nextStepIds: [],
+ position: { x: 0, y: 100 },
+ settings: {
+ input: { objectName: 'note', objectRecord },
+ outputSchema: {},
+ errorHandlingOptions: {
+ retryOnFailure: { value: false },
+ continueOnFailure: { value: false },
+ },
+ },
+});
+
+const createCompleteWorkflow = (
+ step: ReturnType<typeof buildCreateRecordStep>,
+) =>
+ callMcpTool('execute_tool', {
+ toolName: 'create_complete_workflow',
+ arguments: {
+ name: `AI malformed test ${randomUUID().slice(0, 8)}`,
+ trigger: {
+ name: 'Manual Trigger',
+ type: 'MANUAL',
+ settings: { outputSchema: {} },
+ position: { x: 0, y: 0 },
+ nextStepIds: [step.id],
+ },
+ steps: [step],
+ edges: [{ source: 'trigger', target: step.id }],
+ },
+ });
+
+type ToolPayload = {
+ success: boolean;
+ error?: string;
+ result?: { workflowId?: string };
+};
+
+const parsePayload = (result: McpToolCallResult): ToolPayload =>
+ JSON.parse(result.content?.[0]?.text ?? '{}') as ToolPayload;
+
+describe('Workflow AI tool validation (e2e)', () => {
+ const createdWorkflowIds: string[] = [];
+
+ afterAll(async () => {
+ if (createdWorkflowIds.length > 0) {
+ await deleteRecordsByIds('workflow', createdWorkflowIds);
+ }
+ });
+
+ it('reports a failure (does not crash) when create_complete_workflow carries a bare-string rich text', async () => {
+ const result = await createCompleteWorkflow(
+ buildCreateRecordStep({ bodyV2: 'a plain string' }),
+ );
+
+ expect(result.isError).toBe(true);
+
+ const payload = parsePayload(result);
+
+ expect(payload.success).toBe(false);
+ expect(payload.error).toMatch(/rich text/i);
+ });
+
+ it('creates the workflow when the rich text is a valid object', async () => {
+ const result = await createCompleteWorkflow(
+ buildCreateRecordStep({ bodyV2: { markdown: 'hello', blocknote: null } }),
+ );
+
+ const payload = parsePayload(result);
+
+ expect(payload.success).toBe(true);
+ expect(payload.result?.workflowId).toBeDefined();
+
+ if (payload.result?.workflowId) {
+ createdWorkflowIds.push(payload.result.workflowId);
+ }
+ });
+
+ it('creates the workflow when a record step is incomplete (fields not filled in)', async () => {
+ const result = await createCompleteWorkflow(buildCreateRecordStep({}));
+
+ const payload = parsePayload(result);
+
+ expect(payload.success).toBe(true);
+ expect(payload.result?.workflowId).toBeDefined();
+
+ if (payload.result?.workflowId) {
+ createdWorkflowIds.push(payload.result.workflowId);
+ }
+ });
+});
diff --git a/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-version-activation-validation.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-version-activation-validation.integration-spec.ts
new file mode 100644
index 00000000000..ef2cd98c129
--- /dev/null
+++ b/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-version-activation-validation.integration-spec.ts
@@ -0,0 +1,145 @@
+import request from 'supertest';
+import { updateWorkflowVersionTrigger } from 'test/integration/graphql/suites/workflow/utils/update-workflow-version-trigger.util';
+
+const client = request(`http://localhost:${APP_PORT}`);
+
+const graphql = async (query: string, variables?: Record<string, unknown>) =>
+ client
+ .post('/graphql')
+ .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
+ .send({ query, variables });
+
+const graphqlOrFail = async (
+ query: string,
+ variables?: Record<string, unknown>,
+) => {
+ const response = await graphql(query, variables);
+
+ expect(response.body.errors).toBeUndefined();
+
+ return response.body.data;
+};
+
+const validateWorkflowVersion = (workflowVersionId: string) =>
+ graphql(
+ `
+ mutation ValidateWorkflowVersion($workflowVersionId: UUID!) {
+ validateWorkflowVersion(workflowVersionId: $workflowVersionId)
+ }
+ `,
+ { workflowVersionId },
+ );
+
+const activateWorkflowVersion = (workflowVersionId: string) =>
+ graphql(
+ `
+ mutation ActivateWorkflowVersion($workflowVersionId: UUID!) {
+ activateWorkflowVersion(workflowVersionId: $workflowVersionId)
+ }
+ `,
+ { workflowVersionId },
+ );
+
+describe('Workflow version activation validation (e2e)', () => {
+ let workflowVersionId: string;
+
+ beforeAll(async () => {
+ const createData = await graphqlOrFail(`
+ mutation CreateWorkflow {
+ createWorkflow(data: { name: "Activation validation test" }) {
+ id
+ }
+ }
+ `);
+
+ const workflowData = await graphqlOrFail(
+ `
+ query GetWorkflow($id: UUID!) {
+ workflow(filter: { id: { eq: $id } }) {
+ versions {
+ edges {
+ node {
+ id
+ }
+ }
+ }
+ }
+ }
+ `,
+ { id: createData.createWorkflow.id },
+ );
+
+ workflowVersionId = workflowData.workflow.versions.edges[0].node.id;
+ });
+
+ it('refuses to validate an empty draft, with the issues in the error', async () => {
+ const response = await validateWorkflowVersion(workflowVersionId);
+
+ expect(response.body.errors).toBeDefined();
+ expect(response.body.errors[0].extensions.code).toBe('BAD_USER_INPUT');
+ expect(response.body.errors[0].extensions.subCode).toBe(
+ 'NON_ACTIVABLE_WORKFLOW_VERSION',
+ );
+ expect(response.body.errors[0].message).toMatch(/trigger/i);
+ });
+
+ it('refuses activation with the same error as validation', async () => {
+ const response = await activateWorkflowVersion(workflowVersionId);
+
+ expect(response.body.errors).toBeDefined();
+ expect(response.body.errors[0].extensions.subCode).toBe(
+ 'NON_ACTIVABLE_WORKFLOW_VERSION',
+ );
+ });
+
+ it('validates a version whose trigger and steps are complete without activating it', async () => {
+ await updateWorkflowVersionTrigger({
+ workflowVersionId,
+ trigger: {
+ name: 'Manual Trigger',
+ type: 'MANUAL',
+ settings: { outputSchema: {} },
+ nextStepIds: [],
+ position: { x: 0, y: 0 },
+ },
+ });
+
+ await graphqlOrFail(
+ `
+ mutation CreateWorkflowVersionStep(
+ $input: CreateWorkflowVersionStepInput!
+ ) {
+ createWorkflowVersionStep(input: $input) {
+ stepsDiff
+ }
+ }
+ `,
+ {
+ input: {
+ workflowVersionId,
+ stepType: 'CREATE_RECORD',
+ parentStepId: 'trigger',
+ position: { x: 200, y: 0 },
+ },
+ },
+ );
+
+ const response = await validateWorkflowVersion(workflowVersionId);
+
+ expect(response.body.errors).toBeUndefined();
+ expect(response.body.data.validateWorkflowVersion).toBe(true);
+
+ const statusData = await graphqlOrFail(
+ `
+ query GetWorkflowVersion($id: UUID!) {
+ workflowVersion(filter: { id: { eq: $id } }) {
+ status
+ }
+ }
+ `,
+ { id: workflowVersionId },
+ );
+
+ expect(statusData.workflowVersion.status).toBe('DRAFT');
+ });
+});
diff --git a/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-version-malformed-validation.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-version-malformed-validation.integration-spec.ts
new file mode 100644
index 00000000000..f8106921188
--- /dev/null
+++ b/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-version-malformed-validation.integration-spec.ts
@@ -0,0 +1,193 @@
+import request from 'supertest';
+import { updateWorkflowVersionTrigger } from 'test/integration/graphql/suites/workflow/utils/update-workflow-version-trigger.util';
+import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
+import { updateOneOperationFactory } from 'test/integration/graphql/utils/update-one-operation-factory.util';
+
+const client = request(`http://localhost:${APP_PORT}`);
+
+const graphql = async (query: string, variables?: Record<string, unknown>) => {
+ const response = await client
+ .post('/graphql')
+ .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
+ .send({ query, variables });
+
+ expect(response.body.errors).toBeUndefined();
+
+ return response.body.data;
+};
+
+const updateStepResponse = (
+ workflowVersionId: string,
+ step: Record<string, unknown>,
+) =>
+ client
+ .post('/graphql')
+ .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
+ .send({
+ query: `
+ mutation UpdateWorkflowVersionStep(
+ $input: UpdateWorkflowVersionStepInput!
+ ) {
+ updateWorkflowVersionStep(input: $input) {
+ id
+ }
+ }
+ `,
+ variables: { input: { workflowVersionId, step } },
+ });
+
+describe('Workflow version malformed validation (e2e)', () => {
+ let workflowVersionId: string;
+ let createRecordStep: {
+ id: string;
+ settings: { input: Record<string, unknown> };
+ };
+
+ beforeAll(async () => {
+ const createData = await graphql(`
+ mutation CreateWorkflow {
+ createWorkflow(data: { name: "Malformed validation test" }) {
+ id
+ }
+ }
+ `);
+
+ const workflowData = await graphql(
+ `
+ query GetWorkflow($id: UUID!) {
+ workflow(filter: { id: { eq: $id } }) {
+ versions {
+ edges {
+ node {
+ id
+ }
+ }
+ }
+ }
+ }
+ `,
+ { id: createData.createWorkflow.id },
+ );
+
+ workflowVersionId = workflowData.workflow.versions.edges[0].node.id;
+
+ await updateWorkflowVersionTrigger({
+ workflowVersionId,
+ trigger: {
+ name: 'Manual Trigger',
+ type: 'MANUAL',
+ settings: { outputSchema: {} },
+ nextStepIds: [],
+ position: { x: 0, y: 0 },
+ },
+ });
+
+ await graphql(
+ `
+ mutation CreateWorkflowVersionStep(
+ $input: CreateWorkflowVersionStepInput!
+ ) {
+ createWorkflowVersionStep(input: $input) {
+ stepsDiff
+ }
+ }
+ `,
+ {
+ input: {
+ workflowVersionId,
+ stepType: 'CREATE_RECORD',
+ parentStepId: 'trigger',
+ position: { x: 200, y: 0 },
+ },
+ },
+ );
+
+ const stepsData = await graphql(
+ `
+ query GetWorkflowVersion($id: UUID!) {
+ workflowVersion(filter: { id: { eq: $id } }) {
+ steps
+ }
+ }
+ `,
+ { id: workflowVersionId },
+ );
+
+ createRecordStep = stepsData.workflowVersion.steps.find(
+ (step: { type: string }) => step.type === 'CREATE_RECORD',
+ );
+ });
+
+ const stepWithInput = (input: Record<string, unknown>) => ({
+ ...createRecordStep,
+ settings: { ...createRecordStep.settings, input },
+ });
+
+ it('rejects a bare-string rich text value at write time', async () => {
+ const response = await updateStepResponse(
+ workflowVersionId,
+ stepWithInput({
+ objectName: 'note',
+ objectRecord: { bodyV2: 'a plain string' },
+ }),
+ );
+
+ expect(response.body.errors).toBeDefined();
+ expect(response.body.errors[0].extensions.code).toBe('BAD_USER_INPUT');
+ expect(response.body.errors[0].extensions.subCode).toBe(
+ 'MALFORMED_WORKFLOW_VERSION',
+ );
+ expect(response.body.errors[0].message).toMatch(/rich text/i);
+ });
+
+ it('rejects a record step targeting an unknown object', async () => {
+ const response = await updateStepResponse(
+ workflowVersionId,
+ stepWithInput({ objectName: 'ghost', objectRecord: {} }),
+ );
+
+ expect(response.body.errors).toBeDefined();
+ expect(response.body.errors[0].extensions.subCode).toBe(
+ 'MALFORMED_WORKFLOW_VERSION',
+ );
+ expect(response.body.errors[0].message).toContain('does not exist');
+ });
+
+ it('accepts a valid rich text object', async () => {
+ const response = await updateStepResponse(
+ workflowVersionId,
+ stepWithInput({
+ objectName: 'note',
+ objectRecord: { bodyV2: { markdown: 'hello', blocknote: null } },
+ }),
+ );
+
+ expect(response.body.errors).toBeUndefined();
+ expect(response.body.data.updateWorkflowVersionStep.id).toBe(
+ createRecordStep.id,
+ );
+ });
+
+ it('accepts an incomplete record step whose fields are not filled in yet', async () => {
+ const response = await updateStepResponse(
+ workflowVersionId,
+ stepWithInput({ objectName: 'note', objectRecord: {} }),
+ );
+
+ expect(response.body.errors).toBeUndefined();
+ });
+
+ it('forbids writing steps through the generic updateWorkflowVersion mutation', async () => {
+ const operation = updateOneOperationFactory({
+ objectMetadataSingularName: 'workflowVersion',
+ gqlFields: 'id',
+ recordId: workflowVersionId,
+ data: { steps: [] },
+ });
+
+ const response = await makeGraphqlAPIRequest(operation);
+
+ expect(response.body.errors).toBeDefined();
+ expect(response.body.errors[0].extensions.code).toBe('FORBIDDEN');
+ });
+});
diff --git a/packages/twenty-shared/src/workflow/index.ts b/packages/twenty-shared/src/workflow/index.ts
index d553cb14494..71bfaf24648 100644
--- a/packages/twenty-shared/src/workflow/index.ts
+++ b/packages/twenty-shared/src/workflow/index.ts
@@ -137,6 +137,8 @@ export {
joinVariablePath,
parseVariablePath,
} from './utils/variable-path.util';
+export { MALFORMED_WORKFLOW_VALIDATION_ISSUE_CODES } from './validation/constants/malformed-workflow-validation-issue-codes.constant';
+export { NON_ACTIVABLE_WORKFLOW_VALIDATION_ISSUE_CODES } from './validation/constants/non-activable-workflow-validation-issue-codes.constant';
export { isIfElseStepInput } from './validation/guards/isIfElseStepInput';
export { isIteratorStepInput } from './validation/guards/isIteratorStepInput';
export type {
diff --git a/packages/twenty-shared/src/workflow/validation/constants/malformed-workflow-validation-issue-codes.constant.ts b/packages/twenty-shared/src/workflow/validation/constants/malformed-workflow-validation-issue-codes.constant.ts
new file mode 100644
index 00000000000..d9f132dc308
--- /dev/null
+++ b/packages/twenty-shared/src/workflow/validation/constants/malformed-workflow-validation-issue-codes.constant.ts
@@ -0,0 +1,11 @@
+import { type WorkflowValidationIssueCode } from '@/workflow/validation/types/workflow-validation.type';
+
+export const MALFORMED_WORKFLOW_VALIDATION_ISSUE_CODES: ReadonlySet<WorkflowValidationIssueCode> =
+ new Set([
+ 'INVALID_TRIGGER_PARAMS',
+ 'INVALID_STEP_PARAMS',
+ 'INVALID_RICH_TEXT_FIELD',
+ 'OBJECT_NOT_FOUND',
+ 'DUPLICATE_STEP_ID',
+ 'DANGLING_REFERENCE',
+ ]);
diff --git a/packages/twenty-shared/src/workflow/validation/constants/non-activable-workflow-validation-issue-codes.constant.ts b/packages/twenty-shared/src/workflow/validation/constants/non-activable-workflow-validation-issue-codes.constant.ts
new file mode 100644
index 00000000000..fb82e360b97
--- /dev/null
+++ b/packages/twenty-shared/src/workflow/validation/constants/non-activable-workflow-validation-issue-codes.constant.ts
@@ -0,0 +1,18 @@
+import { type WorkflowValidationIssueCode } from '@/workflow/validation/types/workflow-validation.type';
+
+// Issues a well-formed draft may carry while being edited, but that keep it
+// from being activated because a run could not proceed through them.
+export const NON_ACTIVABLE_WORKFLOW_VALIDATION_ISSUE_CODES: ReadonlySet<WorkflowValidationIssueCode> =
+ new Set([
+ 'MISSING_TRIGGER',
+ 'MISSING_TRIGGER_TYPE',
+ 'NO_STEPS',
+ 'TRIGGER_HAS_NO_NEXT_STEP',
+ 'IF_ELSE_INSUFFICIENT_BRANCHES',
+ 'ITERATOR_MISSING_LOOP_BODY',
+ 'INCOMPLETE_PICK_RECORD_CONFIG',
+ 'AI_AGENT_MISSING_AGENT',
+ 'VARIABLE_INVALID_PATH',
+ 'VARIABLE_UNKNOWN_STEP',
+ 'VARIABLE_NOT_UPSTREAM',
+ ]);
diff --git a/packages/twenty-shared/src/workflow/validation/types/workflow-validation.type.ts b/packages/twenty-shared/src/workflow/validation/types/workflow-validation.type.ts
index e35f8daa6f9..2f98947172a 100644
--- a/packages/twenty-shared/src/workflow/validation/types/workflow-validation.type.ts
+++ b/packages/twenty-shared/src/workflow/validation/types/workflow-validation.type.ts
@@ -21,18 +21,17 @@ export type WorkflowValidationIssueCode =
| 'UNREACHABLE_STEP'
| 'INVALID_TRIGGER_PARAMS'
| 'INVALID_STEP_PARAMS'
+ | 'INVALID_RICH_TEXT_FIELD'
+ | 'OBJECT_NOT_FOUND'
+ | 'INCOMPLETE_PICK_RECORD_CONFIG'
| 'IF_ELSE_INSUFFICIENT_BRANCHES'
| 'IF_ELSE_BRANCH_HAS_NO_NEXT_STEP'
| 'ITERATOR_MISSING_LOOP_BODY'
- | 'ITERATOR_ITEMS_NOT_ARRAY'
| 'VARIABLE_INVALID_PATH'
| 'VARIABLE_UNKNOWN_STEP'
| 'VARIABLE_NOT_UPSTREAM'
| 'VARIABLE_MISSING_OUTPUT_SCHEMA'
| 'VARIABLE_PATH_NOT_FOUND'
- | 'CODE_STEP_MISSING_OUTPUT_SCHEMA'
- | 'STEP_HAS_NO_VARIABLE_REFERENCE'
- | 'LOGIC_FUNCTION_OUTPUT_SCHEMA_MISMATCH'
| 'AI_AGENT_MISSING_AGENT'
| 'AI_AGENT_MISSING_OUTPUT_VARIABLE';