Skip to content

The open alternative to Salesforce, designed for AI.

Give side panel front components the Select all filter (#28447)

Charles Bochet508b5eb13b57
diff --git a/packages/twenty-front/src/modules/command-menu-item/engine-command/utils/buildHeadlessCommandContextApi.ts b/packages/twenty-front/src/modules/command-menu-item/engine-command/utils/buildHeadlessCommandContextApi.ts
index 21e4fc8d4c4..b5a72e46ad8 100644
--- a/packages/twenty-front/src/modules/command-menu-item/engine-command/utils/buildHeadlessCommandContextApi.ts
+++ b/packages/twenty-front/src/modules/command-menu-item/engine-command/utils/buildHeadlessCommandContextApi.ts
@@ -1,16 +1,12 @@
import { isRecordFilterAboutSoftDelete } from '@/object-record/record-filter/utils/isRecordFilterAboutSoftDelete';
import type { Store } from 'jotai/vanilla/store';
-import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';
import { type HeadlessEngineCommandContextApi } from '@/command-menu-item/engine-command/types/HeadlessCommandContextApi';
-import { contextStoreAnyFieldFilterValueComponentState } from '@/context-store/states/contextStoreAnyFieldFilterValueComponentState';
import { contextStoreCurrentObjectMetadataItemIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataItemIdComponentState';
import { contextStoreCurrentViewIdComponentState } from '@/context-store/states/contextStoreCurrentViewIdComponentState';
-import { contextStoreFilterGroupsComponentState } from '@/context-store/states/contextStoreFilterGroupsComponentState';
import { contextStoreFiltersComponentState } from '@/context-store/states/contextStoreFiltersComponentState';
import { contextStoreTargetedRecordsRuleComponentState } from '@/context-store/states/contextStoreTargetedRecordsRuleComponentState';
-import { computeContextStoreFilters } from '@/context-store/utils/computeContextStoreFilters';
-import { flattenedFieldMetadataItemsSelector } from '@/object-metadata/states/flattenedFieldMetadataItemsSelector';
+import { computeContextStoreGraphqlFilterFromStore } from '@/context-store/utils/computeContextStoreGraphqlFilterFromStore';
import { objectMetadataItemsSelector } from '@/object-metadata/states/objectMetadataItemsSelector';
import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';
import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
@@ -76,45 +72,10 @@ export const buildHeadlessCommandContextApi = ({
}),
);
- const filterGroups = store.get(
- contextStoreFilterGroupsComponentState.atomFamily({
- instanceId: contextStoreInstanceId,
- }),
- );
-
- const anyFieldFilterValue = store.get(
- contextStoreAnyFieldFilterValueComponentState.atomFamily({
- instanceId: contextStoreInstanceId,
- }),
- );
-
- const currentWorkspaceMember = store.get(currentWorkspaceMemberState.atom);
-
- const systemTimeZone = Intl.DateTimeFormat().resolvedOptions().timeZone;
-
- const userTimezone =
- currentWorkspaceMember?.timeZone !== 'system'
- ? (currentWorkspaceMember?.timeZone ?? systemTimeZone)
- : systemTimeZone;
-
- const flattenedFieldMetadataItems = store.get(
- flattenedFieldMetadataItemsSelector.atom,
- );
-
- const graphqlFilter = isDefined(objectMetadataItem)
- ? computeContextStoreFilters({
- contextStoreTargetedRecordsRule: targetedRecordsRule,
- contextStoreFilters: filters,
- contextStoreFilterGroups: filterGroups,
- objectMetadataItem,
- fieldMetadataItems: flattenedFieldMetadataItems,
- filterValueDependencies: {
- currentWorkspaceMemberId: currentWorkspaceMember?.id,
- timeZone: userTimezone,
- },
- contextStoreAnyFieldFilterValue: anyFieldFilterValue,
- })
- : null;
+ const graphqlFilter = computeContextStoreGraphqlFilterFromStore({
+ store,
+ contextStoreInstanceId,
+ });
const recordIndexId =
objectMetadataItem && currentViewId
diff --git a/packages/twenty-front/src/modules/command-menu-item/hooks/__tests__/useCommandMenuItemClick.test.tsx b/packages/twenty-front/src/modules/command-menu-item/hooks/__tests__/useCommandMenuItemClick.test.tsx
index 9379808fb22..16e56bad488 100644
--- a/packages/twenty-front/src/modules/command-menu-item/hooks/__tests__/useCommandMenuItemClick.test.tsx
+++ b/packages/twenty-front/src/modules/command-menu-item/hooks/__tests__/useCommandMenuItemClick.test.tsx
@@ -8,9 +8,32 @@ import { EMPTY_COMMAND_MENU_CONTEXT_API } from '@/command-menu-item/constants/Em
import { CommandMenuContext } from '@/command-menu-item/contexts/CommandMenuContext';
import { useCommandMenuItemClick } from '@/command-menu-item/hooks/useCommandMenuItemClick';
import { CommandMenuItemContainerType } from '@/command-menu-item/types/CommandMenuItemContainerType';
-import { contextStoreTargetedRecordsRuleComponentState } from '@/context-store/states/contextStoreTargetedRecordsRuleComponentState';
+import { contextStoreCurrentObjectMetadataItemIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataItemIdComponentState';
+import {
+ type ContextStoreTargetedRecordsRule,
+ contextStoreTargetedRecordsRuleComponentState,
+} from '@/context-store/states/contextStoreTargetedRecordsRuleComponentState';
+import { getTestEnrichedObjectMetadataItemsMock } from '~/testing/utils/getTestEnrichedObjectMetadataItemsMock';
import { type CommandMenuItemDefinition } from '@/command-menu-item/types/CommandMenuItemDefinition';
+const companyObjectMetadataItem = getTestEnrichedObjectMetadataItemsMock().find(
+ (item) => item.nameSingular === 'company',
+)!;
+
+// jest.mock factories run before this file's own constants exist.
+jest.mock('@/object-metadata/states/objectMetadataItemsSelector', () => ({
+ objectMetadataItemsSelector: {
+ atom: jest.requireActual('jotai').atom(
+ jest
+ .requireActual('~/testing/utils/getTestEnrichedObjectMetadataItemsMock')
+ .getTestEnrichedObjectMetadataItemsMock()
+ .filter(
+ (item: { nameSingular: string }) => item.nameSingular === 'company',
+ ),
+ ),
+ },
+}));
+
const mockOpenFrontComponentInSidePanel = jest.fn();
const mockMountCommand = jest.fn();
@@ -59,16 +82,25 @@ const FRONT_COMPONENT_COMMAND_MENU_ITEM = {
},
} as CommandMenuItemDefinition;
-const getWrapper = (
- commandMenuContextApi: CommandMenuContextApi,
- selectedRecordIds: string[],
-) => {
+const getWrapper = ({
+ commandMenuContextApi,
+ targetedRecordsRule,
+}: {
+ commandMenuContextApi: CommandMenuContextApi;
+ targetedRecordsRule: ContextStoreTargetedRecordsRule;
+}) => {
const store = createStore();
+ store.set(
+ contextStoreCurrentObjectMetadataItemIdComponentState.atomFamily({
+ instanceId: 'context-store-instance-id',
+ }),
+ companyObjectMetadataItem.id,
+ );
store.set(
contextStoreTargetedRecordsRuleComponentState.atomFamily({
instanceId: 'context-store-instance-id',
}),
- { mode: 'selection', selectedRecordIds },
+ targetedRecordsRule,
);
return ({ children }: { children: ReactNode }) => (
@@ -102,6 +134,7 @@ describe('useCommandMenuItemClick', () => {
expectedRecordContext: {
objectNameSingular: 'company',
selectedRecordIds: ['record-1'],
+ selectedRecordsFilter: { id: { in: ['record-1'] } },
},
},
{
@@ -112,6 +145,7 @@ describe('useCommandMenuItemClick', () => {
expectedRecordContext: {
objectNameSingular: 'company',
selectedRecordIds: ['record-1', 'record-2'],
+ selectedRecordsFilter: { id: { in: ['record-1', 'record-2'] } },
},
},
{
@@ -122,6 +156,7 @@ describe('useCommandMenuItemClick', () => {
expectedRecordContext: {
objectNameSingular: 'company',
selectedRecordIds: ['record-1', 'record-2'],
+ selectedRecordsFilter: { id: { in: ['record-1', 'record-2'] } },
},
},
{
@@ -132,6 +167,7 @@ describe('useCommandMenuItemClick', () => {
expectedRecordContext: {
objectNameSingular: 'company',
selectedRecordIds: [],
+ selectedRecordsFilter: { id: { in: [] } },
},
},
{
@@ -157,8 +193,8 @@ describe('useCommandMenuItemClick', () => {
label: 'Open front component',
}),
{
- wrapper: getWrapper(
- {
+ wrapper: getWrapper({
+ commandMenuContextApi: {
...EMPTY_COMMAND_MENU_CONTEXT_API,
objectMetadataItem,
selectedRecords: storedRecordIds.map((id) => ({
@@ -166,8 +202,8 @@ describe('useCommandMenuItemClick', () => {
__typename: 'Company',
})),
},
- selectedRecordIds,
- ),
+ targetedRecordsRule: { mode: 'selection', selectedRecordIds },
+ }),
},
);
@@ -184,4 +220,46 @@ describe('useCommandMenuItemClick', () => {
});
},
);
+
+ it('opens a side panel front component with the filter of a Select all', async () => {
+ const { result } = renderHook(
+ () =>
+ useCommandMenuItemClick({
+ item: FRONT_COMPONENT_COMMAND_MENU_ITEM,
+ Icon: IconApps,
+ label: 'Open front component',
+ }),
+ {
+ wrapper: getWrapper({
+ commandMenuContextApi: {
+ ...EMPTY_COMMAND_MENU_CONTEXT_API,
+ objectMetadataItem: { nameSingular: 'company' },
+ selectedRecords: [],
+ },
+ targetedRecordsRule: {
+ mode: 'exclusion',
+ excludedRecordIds: ['record-3'],
+ },
+ }),
+ },
+ );
+
+ await act(async () => {
+ await result.current.handleClick();
+ });
+
+ expect(mockOpenFrontComponentInSidePanel).toHaveBeenCalledWith(
+ expect.objectContaining({
+ recordContext: {
+ objectNameSingular: 'company',
+ selectedRecordIds: [],
+ selectedRecordsFilter: {
+ and: expect.arrayContaining([
+ { not: { id: { in: ['record-3'] } } },
+ ]),
+ },
+ },
+ }),
+ );
+ });
});
diff --git a/packages/twenty-front/src/modules/command-menu-item/hooks/useCommandMenuItemClick.ts b/packages/twenty-front/src/modules/command-menu-item/hooks/useCommandMenuItemClick.ts
index 287bd44f7e9..bfb407c1f67 100644
--- a/packages/twenty-front/src/modules/command-menu-item/hooks/useCommandMenuItemClick.ts
+++ b/packages/twenty-front/src/modules/command-menu-item/hooks/useCommandMenuItemClick.ts
@@ -8,11 +8,13 @@ import { useCloseCommandMenu } from '@/command-menu-item/hooks/useCloseCommandMe
import { commandMenuItemProgressFamilyState } from '@/command-menu-item/states/commandMenuItemProgressFamilyState';
import { ContextStoreComponentInstanceContext } from '@/context-store/states/contexts/ContextStoreComponentInstanceContext';
import { contextStoreTargetedRecordsRuleComponentState } from '@/context-store/states/contextStoreTargetedRecordsRuleComponentState';
+import { computeContextStoreGraphqlFilterFromStore } from '@/context-store/utils/computeContextStoreGraphqlFilterFromStore';
import { useOpenFrontComponentInSidePanel } from '@/side-panel/hooks/useOpenFrontComponentInSidePanel';
import { useAvailableComponentInstanceIdOrThrow } from '@/ui/utilities/state/component-state/hooks/useAvailableComponentInstanceIdOrThrow';
import { useAtomFamilySelectorValue } from '@/ui/utilities/state/jotai/hooks/useAtomFamilySelectorValue';
import { useAtomFamilyStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomFamilyStateValue';
import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';
+import { useStore } from 'jotai';
import { isValidElement, useContext } from 'react';
import { ENGINE_COMPONENT_KEY_COMPONENT_MAP } from '@/command-menu-item/engine-command/constants/EngineComponentKeyHeadlessComponentMap';
import { ExportRecordsCommand } from '@/command-menu-item/engine-command/record/components/ExportRecordsCommand';
@@ -34,6 +36,7 @@ export const useCommandMenuItemClick = ({
);
const { commandMenuContextApi } = useContext(CommandMenuContext);
const mountCommand = useMountCommand();
+ const store = useStore();
const { openFrontComponentInSidePanel } = useOpenFrontComponentInSidePanel();
const contextStoreInstanceId = useAvailableComponentInstanceIdOrThrow(
@@ -135,6 +138,10 @@ export const useCommandMenuItemClick = ({
contextStoreTargetedRecordsRule.mode === 'selection'
? contextStoreTargetedRecordsRule.selectedRecordIds
: [],
+ selectedRecordsFilter: computeContextStoreGraphqlFilterFromStore({
+ store,
+ contextStoreInstanceId,
+ }),
}
: undefined,
});
diff --git a/packages/twenty-front/src/modules/context-store/utils/__tests__/computeContextStoreGraphqlFilterFromStore.test.ts b/packages/twenty-front/src/modules/context-store/utils/__tests__/computeContextStoreGraphqlFilterFromStore.test.ts
new file mode 100644
index 00000000000..cf08be61e72
--- /dev/null
+++ b/packages/twenty-front/src/modules/context-store/utils/__tests__/computeContextStoreGraphqlFilterFromStore.test.ts
@@ -0,0 +1,113 @@
+import { createStore } from 'jotai';
+
+import { contextStoreCurrentObjectMetadataItemIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataItemIdComponentState';
+import { contextStoreTargetedRecordsRuleComponentState } from '@/context-store/states/contextStoreTargetedRecordsRuleComponentState';
+import { computeContextStoreGraphqlFilterFromStore } from '@/context-store/utils/computeContextStoreGraphqlFilterFromStore';
+import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';
+
+function mockGetPersonObjectMetadataItem(): EnrichedObjectMetadataItem {
+ return jest
+ .requireActual('~/testing/utils/getTestEnrichedObjectMetadataItemsMock')
+ .getTestEnrichedObjectMetadataItemsMock()
+ .find((item: EnrichedObjectMetadataItem) => item.nameSingular === 'person');
+}
+
+const personObjectMetadataItem = mockGetPersonObjectMetadataItem();
+
+jest.mock('@/object-metadata/states/objectMetadataItemsSelector', () => ({
+ objectMetadataItemsSelector: {
+ atom: jest.requireActual('jotai').atom([mockGetPersonObjectMetadataItem()]),
+ },
+}));
+
+jest.mock(
+ '@/object-metadata/states/flattenedFieldMetadataItemsSelector',
+ () => ({
+ flattenedFieldMetadataItemsSelector: {
+ atom: jest
+ .requireActual('jotai')
+ .atom(mockGetPersonObjectMetadataItem().fields),
+ },
+ }),
+);
+
+const CONTEXT_STORE_INSTANCE_ID = 'context-store-instance-id';
+
+const buildStore = ({
+ objectMetadataItemId,
+ targetedRecordsRule,
+}: {
+ objectMetadataItemId: string | undefined;
+ targetedRecordsRule:
+ | { mode: 'selection'; selectedRecordIds: string[] }
+ | { mode: 'exclusion'; excludedRecordIds: string[] };
+}) => {
+ const store = createStore();
+
+ store.set(
+ contextStoreCurrentObjectMetadataItemIdComponentState.atomFamily({
+ instanceId: CONTEXT_STORE_INSTANCE_ID,
+ }),
+ objectMetadataItemId,
+ );
+ store.set(
+ contextStoreTargetedRecordsRuleComponentState.atomFamily({
+ instanceId: CONTEXT_STORE_INSTANCE_ID,
+ }),
+ targetedRecordsRule,
+ );
+
+ return store;
+};
+
+describe('computeContextStoreGraphqlFilterFromStore', () => {
+ it('should match the selected records by id', () => {
+ const store = buildStore({
+ objectMetadataItemId: personObjectMetadataItem.id,
+ targetedRecordsRule: {
+ mode: 'selection',
+ selectedRecordIds: ['record-1', 'record-2'],
+ },
+ });
+
+ expect(
+ computeContextStoreGraphqlFilterFromStore({
+ store,
+ contextStoreInstanceId: CONTEXT_STORE_INSTANCE_ID,
+ }),
+ ).toEqual({ id: { in: ['record-1', 'record-2'] } });
+ });
+
+ it('should describe Select all, which has no ids, by what it leaves out', () => {
+ const store = buildStore({
+ objectMetadataItemId: personObjectMetadataItem.id,
+ targetedRecordsRule: {
+ mode: 'exclusion',
+ excludedRecordIds: ['record-3'],
+ },
+ });
+
+ expect(
+ computeContextStoreGraphqlFilterFromStore({
+ store,
+ contextStoreInstanceId: CONTEXT_STORE_INSTANCE_ID,
+ }),
+ ).toEqual({
+ and: expect.arrayContaining([{ not: { id: { in: ['record-3'] } } }]),
+ });
+ });
+
+ it('should return null when the context store is not on an object', () => {
+ const store = buildStore({
+ objectMetadataItemId: undefined,
+ targetedRecordsRule: { mode: 'selection', selectedRecordIds: [] },
+ });
+
+ expect(
+ computeContextStoreGraphqlFilterFromStore({
+ store,
+ contextStoreInstanceId: CONTEXT_STORE_INSTANCE_ID,
+ }),
+ ).toBeNull();
+ });
+});
diff --git a/packages/twenty-front/src/modules/context-store/utils/computeContextStoreGraphqlFilterFromStore.ts b/packages/twenty-front/src/modules/context-store/utils/computeContextStoreGraphqlFilterFromStore.ts
new file mode 100644
index 00000000000..3888e31609c
--- /dev/null
+++ b/packages/twenty-front/src/modules/context-store/utils/computeContextStoreGraphqlFilterFromStore.ts
@@ -0,0 +1,74 @@
+import type { Store } from 'jotai/vanilla/store';
+
+import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';
+import { contextStoreAnyFieldFilterValueComponentState } from '@/context-store/states/contextStoreAnyFieldFilterValueComponentState';
+import { contextStoreCurrentObjectMetadataItemIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataItemIdComponentState';
+import { contextStoreFilterGroupsComponentState } from '@/context-store/states/contextStoreFilterGroupsComponentState';
+import { contextStoreFiltersComponentState } from '@/context-store/states/contextStoreFiltersComponentState';
+import { contextStoreTargetedRecordsRuleComponentState } from '@/context-store/states/contextStoreTargetedRecordsRuleComponentState';
+import { computeContextStoreFilters } from '@/context-store/utils/computeContextStoreFilters';
+import { flattenedFieldMetadataItemsSelector } from '@/object-metadata/states/flattenedFieldMetadataItemsSelector';
+import { objectMetadataItemsSelector } from '@/object-metadata/states/objectMetadataItemsSelector';
+import { isDefined } from 'twenty-shared/utils';
+
+export const computeContextStoreGraphqlFilterFromStore = ({
+ store,
+ contextStoreInstanceId,
+}: {
+ store: Store;
+ contextStoreInstanceId: string;
+}) => {
+ const objectMetadataItemId = store.get(
+ contextStoreCurrentObjectMetadataItemIdComponentState.atomFamily({
+ instanceId: contextStoreInstanceId,
+ }),
+ );
+
+ const objectMetadataItem = store
+ .get(objectMetadataItemsSelector.atom)
+ .find((item) => item.id === objectMetadataItemId);
+
+ if (!isDefined(objectMetadataItem)) {
+ return null;
+ }
+
+ const currentWorkspaceMember = store.get(currentWorkspaceMemberState.atom);
+
+ const systemTimeZone = Intl.DateTimeFormat().resolvedOptions().timeZone;
+
+ const workspaceMemberTimeZone = currentWorkspaceMember?.timeZone;
+
+ const userTimezone =
+ isDefined(workspaceMemberTimeZone) && workspaceMemberTimeZone !== 'system'
+ ? workspaceMemberTimeZone
+ : systemTimeZone;
+
+ return computeContextStoreFilters({
+ contextStoreTargetedRecordsRule: store.get(
+ contextStoreTargetedRecordsRuleComponentState.atomFamily({
+ instanceId: contextStoreInstanceId,
+ }),
+ ),
+ contextStoreFilters: store.get(
+ contextStoreFiltersComponentState.atomFamily({
+ instanceId: contextStoreInstanceId,
+ }),
+ ),
+ contextStoreFilterGroups: store.get(
+ contextStoreFilterGroupsComponentState.atomFamily({
+ instanceId: contextStoreInstanceId,
+ }),
+ ),
+ objectMetadataItem,
+ fieldMetadataItems: store.get(flattenedFieldMetadataItemsSelector.atom),
+ filterValueDependencies: {
+ currentWorkspaceMemberId: currentWorkspaceMember?.id,
+ timeZone: userTimezone,
+ },
+ contextStoreAnyFieldFilterValue: store.get(
+ contextStoreAnyFieldFilterValueComponentState.atomFamily({
+ instanceId: contextStoreInstanceId,
+ }),
+ ),
+ });
+};
diff --git a/packages/twenty-front/src/modules/side-panel/pages/front-component/components/SidePanelFrontComponentPage.tsx b/packages/twenty-front/src/modules/side-panel/pages/front-component/components/SidePanelFrontComponentPage.tsx
index 2fec6981fac..a17fc5dee52 100644
--- a/packages/twenty-front/src/modules/side-panel/pages/front-component/components/SidePanelFrontComponentPage.tsx
+++ b/packages/twenty-front/src/modules/side-panel/pages/front-component/components/SidePanelFrontComponentPage.tsx
@@ -32,6 +32,9 @@ export const SidePanelFrontComponentPage = () => {
selectedRecordIds={
viewableFrontComponentRecordContext?.selectedRecordIds
}
+ selectedRecordsFilter={
+ viewableFrontComponentRecordContext?.selectedRecordsFilter
+ }
objectNameSingular={
viewableFrontComponentRecordContext?.objectNameSingular
}
diff --git a/packages/twenty-front/src/modules/side-panel/pages/front-component/components/__tests__/SidePanelFrontComponentPage.test.tsx b/packages/twenty-front/src/modules/side-panel/pages/front-component/components/__tests__/SidePanelFrontComponentPage.test.tsx
index ce365779b04..4199fc23d58 100644
--- a/packages/twenty-front/src/modules/side-panel/pages/front-component/components/__tests__/SidePanelFrontComponentPage.test.tsx
+++ b/packages/twenty-front/src/modules/side-panel/pages/front-component/components/__tests__/SidePanelFrontComponentPage.test.tsx
@@ -6,19 +6,22 @@ import { viewableFrontComponentIdComponentState } from '@/side-panel/pages/front
import { viewableFrontComponentRecordContextComponentState } from '@/side-panel/pages/front-component/states/viewableFrontComponentRecordContextComponentState';
import { type FrontComponentRecordContext } from '@/side-panel/pages/front-component/types/FrontComponentRecordContext';
import { SidePanelPageComponentInstanceContext } from '@/side-panel/states/contexts/SidePanelPageComponentInstanceContext';
+import { type RecordGqlOperationFilter } from 'twenty-shared/types';
jest.mock('@/front-components/components/FrontComponentRenderer', () => ({
FrontComponentRenderer: ({
frontComponentId,
selectedRecordIds,
+ selectedRecordsFilter,
objectNameSingular,
}: {
frontComponentId: string;
selectedRecordIds?: string[];
+ selectedRecordsFilter?: RecordGqlOperationFilter | null;
objectNameSingular?: string;
}) => (
<div data-testid="front-component">
- {`${frontComponentId}:${objectNameSingular ?? 'no object'}:${selectedRecordIds?.join(',') ?? 'no records'}`}
+ {`${frontComponentId}:${objectNameSingular ?? 'no object'}:${selectedRecordIds?.join(',') ?? 'no records'}:${JSON.stringify(selectedRecordsFilter) ?? 'no filter'}`}
</div>
),
}));
@@ -66,7 +69,7 @@ describe('SidePanelFrontComponentPage', () => {
objectNameSingular: 'company',
selectedRecordIds: ['record-id'],
},
- expectedContent: 'front-component-id:company:record-id',
+ expectedContent: 'front-component-id:company:record-id:no filter',
},
{
description: 'every selected record and its object',
@@ -74,22 +77,33 @@ describe('SidePanelFrontComponentPage', () => {
objectNameSingular: 'company',
selectedRecordIds: ['record-1', 'record-2'],
},
- expectedContent: 'front-component-id:company:record-1,record-2',
+ expectedContent: 'front-component-id:company:record-1,record-2:no filter',
+ },
+ {
+ description: 'the filter of a Select all, which has no ids',
+ recordContext: {
+ objectNameSingular: 'company',
+ selectedRecordIds: [],
+ selectedRecordsFilter: { not: { id: { in: ['record-3'] } } },
+ },
+ expectedContent:
+ 'front-component-id:company::{"not":{"id":{"in":["record-3"]}}}',
},
{
description: 'selected records without an object name',
recordContext: { selectedRecordIds: ['record-1', 'record-2'] },
- expectedContent: 'front-component-id:no object:record-1,record-2',
+ expectedContent:
+ 'front-component-id:no object:record-1,record-2:no filter',
},
{
description: 'the object when no record is selected',
recordContext: { objectNameSingular: 'company' },
- expectedContent: 'front-component-id:company:no records',
+ expectedContent: 'front-component-id:company:no records:no filter',
},
{
description: 'no object without a record context',
recordContext: null,
- expectedContent: 'front-component-id:no object:no records',
+ expectedContent: 'front-component-id:no object:no records:no filter',
},
])(
'hands the component $description',
diff --git a/packages/twenty-front/src/modules/side-panel/pages/front-component/types/FrontComponentRecordContext.ts b/packages/twenty-front/src/modules/side-panel/pages/front-component/types/FrontComponentRecordContext.ts
index c8a0a9e2421..37de3489551 100644
--- a/packages/twenty-front/src/modules/side-panel/pages/front-component/types/FrontComponentRecordContext.ts
+++ b/packages/twenty-front/src/modules/side-panel/pages/front-component/types/FrontComponentRecordContext.ts
@@ -1,4 +1,7 @@
+import { type RecordGqlOperationFilter } from 'twenty-shared/types';
+
export type FrontComponentRecordContext = {
objectNameSingular?: string;
selectedRecordIds?: string[];
+ selectedRecordsFilter?: RecordGqlOperationFilter | null;
};