The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
feat(view): land on the kanban for opportunities and a list for campaigns (#26360)
Thomas Trompette5228b7fbb03a
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/constants/initial-object-view-defaults.constant.ts b/packages/twenty-server/src/engine/metadata-modules/view/constants/initial-object-view-defaults.constant.tsnew file mode 100644index 00000000000..36d736acab5--- /dev/null+++ b/packages/twenty-server/src/engine/metadata-modules/view/constants/initial-object-view-defaults.constant.ts@@ -0,0 +1,9 @@+import { STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS } from 'twenty-shared/metadata';+import { ViewType } from 'twenty-shared/types';++export const INITIAL_OBJECT_VIEW_POSITION = 1;++export const INITIAL_OBJECT_VIEW_TYPE = ViewType.TABLE;++export const OBJECT_UNIVERSAL_IDENTIFIERS_WITHOUT_INITIAL_VIEW =+ new Set<string>([STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS.opportunity]);diff --git a/packages/twenty-server/src/engine/metadata-modules/view/constants/initial-object-view-position.constant.ts b/packages/twenty-server/src/engine/metadata-modules/view/constants/initial-object-view-position.constant.tsdeleted file mode 100644index ed2c3eaef82..00000000000--- a/packages/twenty-server/src/engine/metadata-modules/view/constants/initial-object-view-position.constant.ts+++ /dev/null@@ -1 +0,0 @@-export const INITIAL_OBJECT_VIEW_POSITION = 1;diff --git a/packages/twenty-server/src/engine/metadata-modules/view/utils/__tests__/compute-missing-initial-object-view-operations.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/view/utils/__tests__/compute-missing-initial-object-view-operations.util.spec.tsindex 12007781d3b..9e8aceefe8f 100644--- a/packages/twenty-server/src/engine/metadata-modules/view/utils/__tests__/compute-missing-initial-object-view-operations.util.spec.ts+++ b/packages/twenty-server/src/engine/metadata-modules/view/utils/__tests__/compute-missing-initial-object-view-operations.util.spec.ts@@ -1,4 +1,5 @@import { getViewFieldUniversalIdentifier } from 'twenty-shared/application';+import { STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS } from 'twenty-shared/metadata';import { type AggregateOperations, ViewKey } from 'twenty-shared/types';import { computeMissingInitialObjectViewOperations } from 'src/engine/metadata-modules/view/utils/compute-missing-initial-object-view-operations.util';@@ -220,6 +221,29 @@ describe('computeMissingInitialObjectViewOperations', () => {}});+ it('seeds nothing for an object whose standard view already plays that role', () => {+ const { viewsToCreate, viewFieldsToCreate } =+ computeMissingInitialObjectViewOperations({+ ...buildMaps({+ objects: [+ {+ ...PET_OBJECT,+ universalIdentifier:+ STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS.opportunity,+ labelPlural: 'Opportunities',+ },+ ],+ views: [PET_INDEX_VIEW],+ viewFields: [NAME_INDEX_VIEW_FIELD, AGE_INDEX_VIEW_FIELD],+ }),+ initialViewApplicationUniversalIdentifier:+ WORKSPACE_CUSTOM_APPLICATION_UNIVERSAL_IDENTIFIER,+ });++ expect(viewsToCreate).toHaveLength(0);+ expect(viewFieldsToCreate).toHaveLength(0);+ });+it('skips objects without a live INDEX view, remote objects and system objects', () => {const remoteObject: ObjectFixture = {universalIdentifier: '5f4a1c1e-0000-4000-8000-000000000008',diff --git a/packages/twenty-server/src/engine/metadata-modules/view/utils/compute-initial-object-view-to-create.util.ts b/packages/twenty-server/src/engine/metadata-modules/view/utils/compute-initial-object-view-to-create.util.tsindex a067c869780..c9c98c2158f 100644--- a/packages/twenty-server/src/engine/metadata-modules/view/utils/compute-initial-object-view-to-create.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/view/utils/compute-initial-object-view-to-create.util.ts@@ -1,9 +1,11 @@import { getInitialObjectViewUniversalIdentifier } from 'src/engine/metadata-modules/view/utils/get-initial-object-view-universal-identifier.util';import { VIEW_TYPE_DEFAULT_ICONS } from 'twenty-shared/constants';-import { ViewType } from 'twenty-shared/types';import { buildBaseUniversalFlatView } from 'src/engine/metadata-modules/view/utils/build-base-universal-flat-view.util';-import { INITIAL_OBJECT_VIEW_POSITION } from 'src/engine/metadata-modules/view/constants/initial-object-view-position.constant';+import {+ INITIAL_OBJECT_VIEW_POSITION,+ INITIAL_OBJECT_VIEW_TYPE,+} from 'src/engine/metadata-modules/view/constants/initial-object-view-defaults.constant';import { type UniversalFlatObjectMetadata } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/universal-flat-object-metadata.type';import { type UniversalFlatView } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/universal-flat-view.type';@@ -28,8 +30,8 @@ export const computeInitialObjectViewToCreate = ({}),name: `All ${objectMetadata.labelPlural}`,key: null,- icon: VIEW_TYPE_DEFAULT_ICONS[ViewType.TABLE],- type: ViewType.TABLE,+ icon: VIEW_TYPE_DEFAULT_ICONS[INITIAL_OBJECT_VIEW_TYPE],+ type: INITIAL_OBJECT_VIEW_TYPE,position: INITIAL_OBJECT_VIEW_POSITION,isSystemSideEffect: false,});diff --git a/packages/twenty-server/src/engine/metadata-modules/view/utils/compute-missing-initial-object-view-operations.util.ts b/packages/twenty-server/src/engine/metadata-modules/view/utils/compute-missing-initial-object-view-operations.util.tsindex 795cfdd10ca..4561625feb0 100644--- a/packages/twenty-server/src/engine/metadata-modules/view/utils/compute-missing-initial-object-view-operations.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/view/utils/compute-missing-initial-object-view-operations.util.ts@@ -1,3 +1,4 @@+import { OBJECT_UNIVERSAL_IDENTIFIERS_WITHOUT_INITIAL_VIEW } from 'src/engine/metadata-modules/view/constants/initial-object-view-defaults.constant';import { getInitialObjectViewUniversalIdentifier } from 'src/engine/metadata-modules/view/utils/get-initial-object-view-universal-identifier.util';import { ViewKey } from 'twenty-shared/types';import { isDefined } from 'twenty-shared/utils';@@ -63,7 +64,13 @@ export const computeMissingInitialObjectViewOperations = ({const createdAt = new Date().toISOString();for (const flatObjectMetadata of flatObjectMetadatas) {- if (flatObjectMetadata.isRemote || flatObjectMetadata.isSystem) {+ if (+ flatObjectMetadata.isRemote ||+ flatObjectMetadata.isSystem ||+ OBJECT_UNIVERSAL_IDENTIFIERS_WITHOUT_INITIAL_VIEW.has(+ flatObjectMetadata.universalIdentifier,+ )+ ) {continue;}diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view/compute-standard-message-campaign-views.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view/compute-standard-message-campaign-views.util.tsindex f2c0cefcccb..1bfef0a0990 100644--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view/compute-standard-message-campaign-views.util.ts+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view/compute-standard-message-campaign-views.util.ts@@ -17,7 +17,7 @@ export const computeStandardMessageCampaignViews = (context: {viewName: 'allMessageCampaigns',name: INDEX_VIEW_NAME,- type: ViewType.TABLE,+ type: ViewType.LIST,key: ViewKey.INDEX,position: 0,icon: 'IconSend',