Skip to content

The open alternative to Salesforce, designed for AI.

fix(workflow): delete orphan core workflows left by deleted workflows (#26437)

Thomas Trompette54273197f2f6
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-42/2-42-upgrade-version-command.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-42/2-42-upgrade-version-command.module.ts
index 8ad4e3499f8..27a80df78cd 100644
--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-42/2-42-upgrade-version-command.module.ts
+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-42/2-42-upgrade-version-command.module.ts
@@ -9,6 +9,7 @@ import { BackfillWorkflowExecutionCoreIdsCommand } from 'src/database/commands/u
import { MakeWorkflowRunProjectionRelationsNullableCommand } from 'src/database/commands/upgrade-version-command/2-42/2-42-workspace-command-1789719131002-make-workflow-run-projection-relations-nullable.command';
import { PurgeSoftDeletedViewsCommand } from 'src/database/commands/upgrade-version-command/2-42/2-42-workspace-command-1789744500000-purge-soft-deleted-views.command';
import { PurgeSoftDeletedRowLevelPermissionPredicatesCommand } from 'src/database/commands/upgrade-version-command/2-42/2-42-workspace-command-1789978629000-purge-soft-deleted-row-level-permission-predicates.command';
+import { DeleteOrphanCoreWorkflowsCommand } from 'src/database/commands/upgrade-version-command/2-42/2-42-workspace-command-1790155020340-delete-orphan-core-workflows.command';
import { WorkspaceIteratorModule } from 'src/database/commands/command-runners/workspace-iterator.module';
import { UnpinCreationCommandsOnRecordSelectionCommand } from 'src/database/commands/upgrade-version-command/2-42/2-42-workspace-command-1789634112046-unpin-creation-commands-on-record-selection.command';
import { BackfillMissingSystemRelationIndexesCommand } from 'src/database/commands/upgrade-version-command/2-42/2-42-workspace-command-1789663454000-backfill-missing-system-relation-indexes.command';
@@ -18,6 +19,7 @@ import { SetMessageTextDisplayedMaxRowsCommand } from 'src/database/commands/upg
import { ApplicationModule } from 'src/engine/core-modules/application/application.module';
import { WorkspaceSchemaManagerModule } from 'src/engine/twenty-orm/workspace-schema-manager/workspace-schema-manager.module';
import { WorkspaceCacheModule } from 'src/engine/workspace-cache/workspace-cache.module';
+import { WorkflowCoreModule } from 'src/engine/core-modules/workflow/workflow-core.module';
import { WorkspaceMigrationRunnerModule } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-runner/workspace-migration-runner.module';
import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspace-migration/workspace-migration.module';
import { WorkspaceSchemaMigrationRunnerActionHandlersModule } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/workspace-schema-migration-runner-action-handlers.module';
@@ -29,6 +31,7 @@ import { GateWorkflowFavoritesByCoreIndexFlagCommand } from 'src/database/comman
AgentChatStreamStateModule,
AgentHistoryModule,
ApplicationModule,
+ WorkflowCoreModule,
WorkspaceCacheModule,
WorkspaceIteratorModule,
WorkspaceMigrationModule,
@@ -49,6 +52,7 @@ import { GateWorkflowFavoritesByCoreIndexFlagCommand } from 'src/database/comman
SyncMessageRecordPageCommand,
SetMessageTextDisplayedMaxRowsCommand,
PurgeSoftDeletedRowLevelPermissionPredicatesCommand,
+ DeleteOrphanCoreWorkflowsCommand,
],
exports: [
GateWorkflowFavoritesByCoreIndexFlagCommand,
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-42/2-42-workspace-command-1790155020340-delete-orphan-core-workflows.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-42/2-42-workspace-command-1790155020340-delete-orphan-core-workflows.command.ts
new file mode 100644
index 00000000000..707c111973d
--- /dev/null
+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-42/2-42-workspace-command-1790155020340-delete-orphan-core-workflows.command.ts
@@ -0,0 +1,113 @@
+import { Command } from 'nest-commander';
+import { isDefined } from 'twenty-shared/utils';
+
+import { ProvisionedWorkspaceCommandRunner } from 'src/database/commands/command-runners/provisioned-workspace.command-runner';
+import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';
+import { type RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspace.command-runner';
+import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';
+import { WorkflowCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-core-sync.service';
+import { hasCoreWorkflowWorkspaceWorkflowIdColumn } from 'src/engine/core-modules/workflow/utils/has-core-workflow-workspace-workflow-id-column.util';
+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
+import { getWorkspaceSchemaName } from 'src/engine/workspace-datasource/utils/get-workspace-schema-name.util';
+
+@RegisteredWorkspaceCommand('2.42.0', 1790155020340)
+@Command({
+ name: 'upgrade:2-42:delete-orphan-core-workflows',
+ description:
+ 'Delete custom application core workflows that no live workspace workflow mirrors',
+})
+export class DeleteOrphanCoreWorkflowsCommand extends ProvisionedWorkspaceCommandRunner {
+ constructor(
+ protected readonly workspaceIteratorService: WorkspaceIteratorService,
+ private readonly workspaceCacheService: WorkspaceCacheService,
+ private readonly workflowCoreSyncService: WorkflowCoreSyncService,
+ ) {
+ super(workspaceIteratorService);
+ }
+
+ override async runOnWorkspace({
+ workspaceId,
+ options,
+ dataSource,
+ }: RunOnWorkspaceArgs): Promise<void> {
+ if (!isDefined(dataSource)) {
+ return;
+ }
+
+ const schema = getWorkspaceSchemaName(workspaceId);
+
+ const queryRunner = dataSource.createQueryRunner();
+
+ await queryRunner.connect();
+
+ let orphanCoreWorkflowIds: string[];
+
+ try {
+ if (
+ !(await hasCoreWorkflowWorkspaceWorkflowIdColumn((query) =>
+ queryRunner.query(query),
+ ))
+ ) {
+ return;
+ }
+
+ const workspaceCoreWorkflowIdColumns = await queryRunner.query(
+ `SELECT 1
+ FROM information_schema.columns
+ WHERE table_schema = $1
+ AND table_name = 'workflow'
+ AND column_name = 'coreWorkflowId'
+ LIMIT 1`,
+ [schema],
+ );
+
+ if (workspaceCoreWorkflowIdColumns.length === 0) {
+ return;
+ }
+
+ const rows: { id: string }[] = await queryRunner.query(
+ `SELECT c.id
+ FROM core."workflow" c
+ JOIN core."workspace" w ON w.id = c."workspaceId"
+ WHERE c."workspaceId" = $1
+ AND c."applicationId" = w."workspaceCustomApplicationId"
+ AND NOT EXISTS (
+ SELECT 1
+ FROM "${schema}"."workflow" ww
+ WHERE (ww."coreWorkflowId" = c.id OR ww.id = c."workspaceWorkflowId")
+ AND ww."deletedAt" IS NULL
+ )`,
+ [workspaceId],
+ );
+
+ orphanCoreWorkflowIds = rows.map(({ id }) => id);
+ } finally {
+ await queryRunner.release();
+ }
+
+ if (orphanCoreWorkflowIds.length === 0) {
+ return;
+ }
+
+ if (options.dryRun) {
+ this.logger.log(
+ `[DRY RUN] Would delete ${orphanCoreWorkflowIds.length} orphan core workflow(s) for workspace ${workspaceId}`,
+ );
+
+ return;
+ }
+
+ await this.workspaceCacheService.invalidateAndRecompute(workspaceId, [
+ 'flatWorkflowMaps',
+ ]);
+
+ await this.workflowCoreSyncService.deleteFromCore(
+ workspaceId,
+ orphanCoreWorkflowIds,
+ );
+
+ this.logger.log(
+ `Deleted ${orphanCoreWorkflowIds.length} orphan core workflow(s) for workspace ${workspaceId}`,
+ );
+ }
+}