The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
feat(workflow): show workspace workflow versions only while the core index flag is off (#25280)
Thomas Trompette5436f4e900c8
diff --git a/packages/twenty-front/src/modules/navigation-menu-item/common/hooks/useNavigationObjectMetadataItems.ts b/packages/twenty-front/src/modules/navigation-menu-item/common/hooks/useNavigationObjectMetadataItems.tsnew file mode 100644index 00000000000..1aa600638c6--- /dev/null+++ b/packages/twenty-front/src/modules/navigation-menu-item/common/hooks/useNavigationObjectMetadataItems.ts@@ -0,0 +1,22 @@+import { CoreObjectNameSingular, FeatureFlagKey } from 'twenty-shared/types';++import { objectMetadataItemsSelector } from '@/object-metadata/states/objectMetadataItemsSelector';+import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';+import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';++export const useNavigationObjectMetadataItems = () => {+ const objectMetadataItems = useAtomStateValue(objectMetadataItemsSelector);+ const isWorkflowCoreIndexPageEnabled = useIsFeatureEnabled(+ FeatureFlagKey.IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED,+ );++ if (!isWorkflowCoreIndexPageEnabled) {+ return objectMetadataItems;+ }++ return objectMetadataItems.filter(+ (objectMetadataItem) =>+ objectMetadataItem.nameSingular !==+ CoreObjectNameSingular.WorkflowVersion,+ );+};diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/folder/hooks/useNavigationMenuItemsByFolder.ts b/packages/twenty-front/src/modules/navigation-menu-item/display/folder/hooks/useNavigationMenuItemsByFolder.tsindex 5b8ce1d061e..a1a013c36f4 100644--- a/packages/twenty-front/src/modules/navigation-menu-item/display/folder/hooks/useNavigationMenuItemsByFolder.ts+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/folder/hooks/useNavigationMenuItemsByFolder.ts@@ -3,7 +3,7 @@ import { type NavigationMenuItem } from '~/generated-metadata/graphql';import { filterAndSortNavigationMenuItems } from '@/navigation-menu-item/common/utils/filterAndSortNavigationMenuItems';import { isNavigationMenuItemFolder } from '@/navigation-menu-item/common/utils/isNavigationMenuItemFolder';-import { objectMetadataItemsSelector } from '@/object-metadata/states/objectMetadataItemsSelector';+import { useNavigationObjectMetadataItems } from '@/navigation-menu-item/common/hooks/useNavigationObjectMetadataItems';import { viewsSelector } from '@/views/states/selectors/viewsSelector';import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';@@ -24,7 +24,7 @@ type NavigationMenuItemFolderEntry = Pick<export const useNavigationMenuItemsByFolder = () => {const views = useAtomStateValue(viewsSelector);- const objectMetadataItems = useAtomStateValue(objectMetadataItemsSelector);+ const objectMetadataItems = useNavigationObjectMetadataItems();const { navigationMenuItems, workspaceNavigationMenuItems } =useNavigationMenuItemsData();diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/hooks/useNavigationMenuItemSectionItems.ts b/packages/twenty-front/src/modules/navigation-menu-item/display/hooks/useNavigationMenuItemSectionItems.tsindex 67d8c6e22bc..7658df43b4d 100644--- a/packages/twenty-front/src/modules/navigation-menu-item/display/hooks/useNavigationMenuItemSectionItems.ts+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/hooks/useNavigationMenuItemSectionItems.ts@@ -1,9 +1,9 @@import { type NavigationMenuItem } from '~/generated-metadata/graphql';import { isLayoutCustomizationModeEnabledState } from '@/layout-customization/states/isLayoutCustomizationModeEnabledState';+import { useNavigationObjectMetadataItems } from '@/navigation-menu-item/common/hooks/useNavigationObjectMetadataItems';import { flattenNavigationMenuItemsWithFolderChildren } from '@/navigation-menu-item/common/utils/flattenNavigationMenuItemsWithFolderChildren';import { getWorkspaceSidebarOrphanItemsInDisplayOrder } from '@/navigation-menu-item/display/utils/getWorkspaceSidebarOrphanItemsInDisplayOrder';-import { objectMetadataItemsSelector } from '@/object-metadata/states/objectMetadataItemsSelector';import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';import { useObjectPermissions } from '@/object-record/hooks/useObjectPermissions';import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';@@ -27,7 +27,7 @@ export const useNavigationMenuItemSectionItems = (): NavigationMenuItem[] => {isLayoutCustomizationModeEnabledState,);const views = useAtomStateValue(viewsSelector);- const objectMetadataItems = useAtomStateValue(objectMetadataItemsSelector);+ const objectMetadataItems = useNavigationObjectMetadataItems();const { objectPermissionsByObjectMetadataId } = useObjectPermissions();const flatItems = getWorkspaceSidebarOrphanItemsInDisplayOrder({diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/hooks/useSortedNavigationMenuItems.ts b/packages/twenty-front/src/modules/navigation-menu-item/display/hooks/useSortedNavigationMenuItems.tsindex 66a46837faa..a10c795725f 100644--- a/packages/twenty-front/src/modules/navigation-menu-item/display/hooks/useSortedNavigationMenuItems.ts+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/hooks/useSortedNavigationMenuItems.ts@@ -1,7 +1,7 @@import { useMemo } from 'react';import { filterAndSortNavigationMenuItems } from '@/navigation-menu-item/common/utils/filterAndSortNavigationMenuItems';-import { objectMetadataItemsSelector } from '@/object-metadata/states/objectMetadataItemsSelector';+import { useNavigationObjectMetadataItems } from '@/navigation-menu-item/common/hooks/useNavigationObjectMetadataItems';import { viewsSelector } from '@/views/states/selectors/viewsSelector';import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';@@ -11,7 +11,7 @@ export const useSortedNavigationMenuItems = () => {const { navigationMenuItems, workspaceNavigationMenuItems } =useNavigationMenuItemsData();const views = useAtomStateValue(viewsSelector);- const objectMetadataItems = useAtomStateValue(objectMetadataItemsSelector);+ const objectMetadataItems = useNavigationObjectMetadataItems();const navigationMenuItemsSorted = useMemo(() => {return filterAndSortNavigationMenuItems(diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/utils/__tests__/getWorkspaceSidebarOrphanItemsInDisplayOrder.test.ts b/packages/twenty-front/src/modules/navigation-menu-item/display/utils/__tests__/getWorkspaceSidebarOrphanItemsInDisplayOrder.test.tsnew file mode 100644index 00000000000..d196ce60d91--- /dev/null+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/utils/__tests__/getWorkspaceSidebarOrphanItemsInDisplayOrder.test.ts@@ -0,0 +1,68 @@+import { NavigationMenuItemType } from 'twenty-shared/types';++import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';+import { getWorkspaceSidebarOrphanItemsInDisplayOrder } from '@/navigation-menu-item/display/utils/getWorkspaceSidebarOrphanItemsInDisplayOrder';+import { type NavigationMenuItem } from '~/generated-metadata/graphql';++const objectMetadataItem = {+ id: 'metadata-id',+ nameSingular: 'workflow',+ isActive: true,+} as EnrichedObjectMetadataItem;++const objectBackedItem = {+ id: 'item-id',+ type: NavigationMenuItemType.OBJECT,+ targetObjectMetadataId: 'metadata-id',+ position: 1,+} as NavigationMenuItem;++const hiddenObjectBackedItem = {+ id: 'hidden-item-id',+ type: NavigationMenuItemType.OBJECT,+ targetObjectMetadataId: 'hidden-metadata-id',+ position: 2,+} as NavigationMenuItem;++describe('getWorkspaceSidebarOrphanItemsInDisplayOrder', () => {+ it('drops an object-backed item whose object is absent from the metadata in customization mode', () => {+ const result = getWorkspaceSidebarOrphanItemsInDisplayOrder({+ workspaceNavigationMenuItems: [hiddenObjectBackedItem],+ workspaceNavigationMenuItemsSorted: [],+ objectMetadataItems: [objectMetadataItem],+ views: [],+ objectPermissionsByObjectMetadataId: {},+ includeInaccessibleObjectBackedItems: true,+ });++ expect(result).toEqual([]);+ });++ it('keeps an object-backed item whose object is present in customization mode even when it is not in the sorted list', () => {+ const result = getWorkspaceSidebarOrphanItemsInDisplayOrder({+ workspaceNavigationMenuItems: [objectBackedItem],+ workspaceNavigationMenuItemsSorted: [],+ objectMetadataItems: [objectMetadataItem],+ views: [],+ objectPermissionsByObjectMetadataId: {},+ includeInaccessibleObjectBackedItems: true,+ });++ expect(result).toHaveLength(1);+ expect(result[0].id).toBe('item-id');+ });++ it('keeps a readable object-backed item in normal mode', () => {+ const result = getWorkspaceSidebarOrphanItemsInDisplayOrder({+ workspaceNavigationMenuItems: [objectBackedItem],+ workspaceNavigationMenuItemsSorted: [objectBackedItem],+ objectMetadataItems: [objectMetadataItem],+ views: [],+ objectPermissionsByObjectMetadataId: {},+ includeInaccessibleObjectBackedItems: false,+ });++ expect(result).toHaveLength(1);+ expect(result[0].id).toBe('item-id');+ });+});diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/utils/getWorkspaceSidebarOrphanItemsInDisplayOrder.ts b/packages/twenty-front/src/modules/navigation-menu-item/display/utils/getWorkspaceSidebarOrphanItemsInDisplayOrder.tsindex 1bffd7bd507..babdb6cd077 100644--- a/packages/twenty-front/src/modules/navigation-menu-item/display/utils/getWorkspaceSidebarOrphanItemsInDisplayOrder.ts+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/utils/getWorkspaceSidebarOrphanItemsInDisplayOrder.ts@@ -57,18 +57,22 @@ export const getWorkspaceSidebarOrphanItemsInDisplayOrder = ({return acc;}- if (includeInaccessibleObjectBackedItems) {- acc.push(rowSource);- return acc;- }-const objectMetadataItem = getObjectMetadataForNavigationMenuItem(rowSource,objectMetadataItems,views,);++ if (!isDefined(objectMetadataItem)) {+ return acc;+ }++ if (includeInaccessibleObjectBackedItems) {+ acc.push(rowSource);+ return acc;+ }+if (- isDefined(objectMetadataItem) &&getObjectPermissionsForObject(objectPermissionsByObjectMetadataId,objectMetadataItem.id,diff --git a/packages/twenty-front/src/modules/object-core/workflows/utils/__tests__/isWorkspaceWorkflowVersionRouteHidden.test.ts b/packages/twenty-front/src/modules/object-core/workflows/utils/__tests__/isWorkspaceWorkflowVersionRouteHidden.test.tsnew file mode 100644index 00000000000..5936c31bc58--- /dev/null+++ b/packages/twenty-front/src/modules/object-core/workflows/utils/__tests__/isWorkspaceWorkflowVersionRouteHidden.test.ts@@ -0,0 +1,48 @@+import { CoreObjectNameSingular } from 'twenty-shared/types';++import { isWorkspaceWorkflowVersionRouteHidden } from '@/object-core/workflows/utils/isWorkspaceWorkflowVersionRouteHidden';++describe('isWorkspaceWorkflowVersionRouteHidden', () => {+ it('should hide the workflow version route when the flag is on', () => {+ expect(+ isWorkspaceWorkflowVersionRouteHidden({+ objectNameSingular: CoreObjectNameSingular.WorkflowVersion,+ isWorkflowCoreIndexPageEnabled: true,+ }),+ ).toBe(true);+ });++ it('should keep the workflow version route when the flag is off', () => {+ expect(+ isWorkspaceWorkflowVersionRouteHidden({+ objectNameSingular: CoreObjectNameSingular.WorkflowVersion,+ isWorkflowCoreIndexPageEnabled: false,+ }),+ ).toBe(false);+ });++ it('should not hide other objects when the flag is on', () => {+ expect(+ isWorkspaceWorkflowVersionRouteHidden({+ objectNameSingular: CoreObjectNameSingular.Workflow,+ isWorkflowCoreIndexPageEnabled: true,+ }),+ ).toBe(false);++ expect(+ isWorkspaceWorkflowVersionRouteHidden({+ objectNameSingular: CoreObjectNameSingular.WorkflowRun,+ isWorkflowCoreIndexPageEnabled: true,+ }),+ ).toBe(false);+ });++ it('should not hide anything when the route carries no object', () => {+ expect(+ isWorkspaceWorkflowVersionRouteHidden({+ objectNameSingular: undefined,+ isWorkflowCoreIndexPageEnabled: true,+ }),+ ).toBe(false);+ });+});diff --git a/packages/twenty-front/src/modules/object-core/workflows/utils/isWorkspaceWorkflowVersionRouteHidden.ts b/packages/twenty-front/src/modules/object-core/workflows/utils/isWorkspaceWorkflowVersionRouteHidden.tsnew file mode 100644index 00000000000..7d5827061d0--- /dev/null+++ b/packages/twenty-front/src/modules/object-core/workflows/utils/isWorkspaceWorkflowVersionRouteHidden.ts@@ -0,0 +1,11 @@+import { CoreObjectNameSingular } from 'twenty-shared/types';++export const isWorkspaceWorkflowVersionRouteHidden = ({+ objectNameSingular,+ isWorkflowCoreIndexPageEnabled,+}: {+ objectNameSingular?: string | null;+ isWorkflowCoreIndexPageEnabled: boolean;+}) =>+ isWorkflowCoreIndexPageEnabled &&+ objectNameSingular === CoreObjectNameSingular.WorkflowVersion;diff --git a/packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx b/packages/twenty-front/src/pages/object-record/RecordIndexPage.tsxindex 136f92b14b6..cbec90bebb2 100644--- a/packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx+++ b/packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx@@ -3,6 +3,7 @@ import { contextStoreCurrentObjectMetadataItemIdComponentState } from '@/contextimport { useObjectMetadataItems } from '@/object-metadata/hooks/useObjectMetadataItems';import { RecordIndexContainerGater } from '@/object-record/record-index/components/RecordIndexContainerGater';import { isCoreWorkflowsIndexEnabled } from '@/object-core/workflows/utils/isCoreWorkflowsIndexEnabled';+import { isWorkspaceWorkflowVersionRouteHidden } from '@/object-core/workflows/utils/isWorkspaceWorkflowVersionRouteHidden';import { RecordIndexSkeletonLoader } from '@/object-record/record-index/components/RecordIndexSkeletonLoader';import { useWorkspaceSurface } from '@/ui/layout/hooks/useWorkspaceSurface';import { PageContainer } from '@/ui/layout/page/components/PageContainer';@@ -71,6 +72,15 @@ export const RecordIndexPage = () => {return <RecordIndexSkeletonLoader />;}+ if (+ isWorkspaceWorkflowVersionRouteHidden({+ objectNameSingular: routeObjectMetadataItem?.nameSingular,+ isWorkflowCoreIndexPageEnabled,+ })+ ) {+ return <WorkspaceRouteUnavailable />;+ }+if (isCoreWorkflowsIndexEnabled({objectNameSingular: objectMetadataItem.nameSingular,diff --git a/packages/twenty-front/src/pages/object-record/RecordShowPage.tsx b/packages/twenty-front/src/pages/object-record/RecordShowPage.tsxindex 42bf98aad48..bd94a5799c8 100644--- a/packages/twenty-front/src/pages/object-record/RecordShowPage.tsx+++ b/packages/twenty-front/src/pages/object-record/RecordShowPage.tsx@@ -1,7 +1,10 @@import { useParams } from 'react-router-dom';+import { FeatureFlagKey } from 'twenty-shared/types';import { isDefined } from 'twenty-shared/utils';import { WorkspaceRouteUnavailable } from '@/app/routing/components/WorkspaceRouteUnavailable';+import { isWorkspaceWorkflowVersionRouteHidden } from '@/object-core/workflows/utils/isWorkspaceWorkflowVersionRouteHidden';+import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';import { SidePanelToggleButton } from '@/side-panel/components/SidePanelToggleButton';import { RecordShowCommandMenu } from '@/command-menu-item/components/RecordShowCommandMenu';import { CommandMenuComponentInstanceContext } from '@/command-menu/states/contexts/CommandMenuComponentInstanceContext';@@ -128,6 +131,9 @@ export const RecordShowPage = () => {const parameters = useParams<RecordShowPageParameters>();const workspaceSurface = useWorkspaceSurface();const { objectMetadataItems } = useObjectMetadataItems();+ const isWorkflowCoreIndexPageEnabled = useIsFeatureEnabled(+ FeatureFlagKey.IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED,+ );const isInSidePanel = workspaceSurface.type === 'side-panel';const isRouteObjectMetadataAvailable =@@ -141,5 +147,14 @@ export const RecordShowPage = () => {return <WorkspaceRouteUnavailable />;}+ if (+ isWorkspaceWorkflowVersionRouteHidden({+ objectNameSingular: parameters.objectNameSingular,+ isWorkflowCoreIndexPageEnabled,+ })+ ) {+ return <WorkspaceRouteUnavailable />;+ }+return <RecordShowPageContent parameters={parameters} />;};diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-upgrade-version-command.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-upgrade-version-command.module.tsindex e9caef1e179..31816e408d6 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-upgrade-version-command.module.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-upgrade-version-command.module.ts@@ -17,6 +17,7 @@ import { EnableStandardActivityTargetFieldsCommand } from 'src/database/commandsimport { SimplifyStandardTaskNoteLayoutsCommand } from 'src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1788299312343-simplify-standard-task-note-layouts.command';import { ProvisionMissingObjectSystemRelationsCommand } from 'src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1788266912940-provision-missing-object-system-relations.command';import { HideAskAiInSidePanelCommand } from 'src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1788266562942-hide-ask-ai-in-side-panel.command';+import { GateWorkflowVersionNavigationByCoreIndexFlagCommand } from 'src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1788340845000-gate-workflow-version-navigation-by-core-index-flag.command';import { ApplicationModule } from 'src/engine/core-modules/application/application.module';import { CommandMenuItemEntity } from 'src/engine/metadata-modules/command-menu-item/entities/command-menu-item.entity';import { WorkspaceSchemaManagerModule } from 'src/engine/twenty-orm/workspace-schema-manager/workspace-schema-manager.module';@@ -50,6 +51,7 @@ import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspaceSimplifyStandardTaskNoteLayoutsCommand,ProvisionMissingObjectSystemRelationsCommand,HideAskAiInSidePanelCommand,+ GateWorkflowVersionNavigationByCoreIndexFlagCommand,],})export class V2_38_UpgradeVersionCommandModule {}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1788340845000-gate-workflow-version-navigation-by-core-index-flag.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1788340845000-gate-workflow-version-navigation-by-core-index-flag.command.tsnew file mode 100644index 00000000000..02198a8ca70--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1788340845000-gate-workflow-version-navigation-by-core-index-flag.command.ts@@ -0,0 +1,100 @@+import { Command } from 'nest-commander';+import { TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER } from 'twenty-shared/application';+import { STANDARD_OBJECTS } from 'twenty-shared/metadata';+import { CoreObjectNameSingular } from 'twenty-shared/types';+import { isDefined } from 'twenty-shared/utils';++import { ProvisionedWorkspaceCommandRunner } from 'src/database/commands/command-runners/provisioned-workspace.command-runner';+import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';+import { type RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspace.command-runner';+import {+ buildGateWorkflowVersionNavigationCommandMenuItemUpdate,+ LEGACY_WORKFLOW_VERSION_NAVIGATION_AVAILABILITY_EXPRESSION,+} from 'src/database/commands/upgrade-version-command/2-38/utils/build-gate-workflow-version-navigation-command-menu-item-update.util';+import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';+import { EngineComponentKey } from 'src/engine/metadata-modules/command-menu-item/enums/engine-component-key.enum';+import { buildNavigationConditionalAvailabilityExpression } from 'src/engine/metadata-modules/flat-command-menu-item/utils/build-object-navigation-universal-flat-command-menu-item.util';+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';+import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';++@RegisteredWorkspaceCommand('2.38.0', 1788340845000)+@Command({+ name: 'upgrade:2-38:gate-workflow-version-navigation-by-core-index-flag',+ description:+ 'Hide the Go to Workflow Versions navigation command menu item when the workflow core index feature flag is enabled',+})+export class GateWorkflowVersionNavigationByCoreIndexFlagCommand extends ProvisionedWorkspaceCommandRunner {+ constructor(+ protected readonly workspaceIteratorService: WorkspaceIteratorService,+ private readonly workspaceMigrationValidateBuildAndRunService: WorkspaceMigrationValidateBuildAndRunService,+ private readonly workspaceCacheService: WorkspaceCacheService,+ ) {+ super(workspaceIteratorService);+ }++ override async runOnWorkspace({+ workspaceId,+ options,+ }: RunOnWorkspaceArgs): Promise<void> {+ const { flatCommandMenuItemMaps } =+ await this.workspaceCacheService.getOrRecompute(workspaceId, [+ 'flatCommandMenuItemMaps',+ ]);++ const existingCommandMenuItem = Object.values(+ flatCommandMenuItemMaps.byUniversalIdentifier,+ ).find(+ (commandMenuItem) =>+ isDefined(commandMenuItem) &&+ commandMenuItem.engineComponentKey === EngineComponentKey.NAVIGATION &&+ commandMenuItem.conditionalAvailabilityExpression ===+ LEGACY_WORKFLOW_VERSION_NAVIGATION_AVAILABILITY_EXPRESSION,+ );++ const commandMenuItemToUpdate =+ buildGateWorkflowVersionNavigationCommandMenuItemUpdate({+ existingCommandMenuItem,+ conditionalAvailabilityExpression:+ buildNavigationConditionalAvailabilityExpression({+ universalIdentifier:+ STANDARD_OBJECTS.workflowVersion.universalIdentifier,+ nameSingular: CoreObjectNameSingular.WorkflowVersion,+ }),+ now: new Date().toISOString(),+ });++ if (!isDefined(commandMenuItemToUpdate)) {+ return;+ }++ if (options.dryRun) {+ this.logger.log(+ `Would gate the workflow version navigation command for workspace ${workspaceId}`,+ );++ return;+ }++ const validateAndBuildResult =+ await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(+ {+ allFlatEntityOperationByMetadataName: {+ commandMenuItem: {+ flatEntityToCreate: [],+ flatEntityToDelete: [],+ flatEntityToUpdate: [commandMenuItemToUpdate],+ },+ },+ workspaceId,+ isSystemBuild: true,+ applicationUniversalIdentifier:+ TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER,+ },+ );++ if (validateAndBuildResult.status === 'fail') {+ throw new WorkspaceMigrationBuilderException(validateAndBuildResult);+ }+ }+}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-gate-workflow-version-navigation-command-menu-item-update.util.spec.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-gate-workflow-version-navigation-command-menu-item-update.util.spec.tsnew file mode 100644index 00000000000..36eab248f18--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-gate-workflow-version-navigation-command-menu-item-update.util.spec.ts@@ -0,0 +1,65 @@+import { buildGateWorkflowVersionNavigationCommandMenuItemUpdate } from 'src/database/commands/upgrade-version-command/2-38/utils/build-gate-workflow-version-navigation-command-menu-item-update.util';+import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';+import { createEmptyFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-flat-entity-maps.constant';+import { createStandardCommandMenuItemFlatMetadata } from 'src/engine/workspace-manager/twenty-standard-application/utils/command-menu-item/create-standard-command-menu-item-flat-metadata.util';++const NOW = '2026-09-01T12:00:00.000Z';+const GATED_EXPRESSION =+ 'not featureFlags.IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED and targetObjectReadPermissions.workflowVersion';++const LEGACY_COMMAND_MENU_ITEM: FlatCommandMenuItem = Object.freeze({+ ...createStandardCommandMenuItemFlatMetadata({+ commandMenuItemName: 'askAi',+ commandMenuItemId: 'workflow-version-navigation-command-id',+ workspaceId: 'workspace-id',+ twentyStandardApplicationId: 'application-id',+ dependencyFlatEntityMaps: {+ flatObjectMetadataMaps: createEmptyFlatEntityMaps(),+ },+ now: '2026-08-01T00:00:00.000Z',+ }),+ conditionalAvailabilityExpression: 'targetObjectReadPermissions.workflowVersion',+});++describe('buildGateWorkflowVersionNavigationCommandMenuItemUpdate', () => {+ it('gates the legacy navigation expression behind the flag being off', () => {+ expect(+ buildGateWorkflowVersionNavigationCommandMenuItemUpdate({+ existingCommandMenuItem: LEGACY_COMMAND_MENU_ITEM,+ conditionalAvailabilityExpression: GATED_EXPRESSION,+ now: NOW,+ }),+ ).toEqual({+ ...LEGACY_COMMAND_MENU_ITEM,+ conditionalAvailabilityExpression: GATED_EXPRESSION,+ updatedAt: NOW,+ });+ });++ it.each([+ { name: 'missing command', existingCommandMenuItem: undefined },+ {+ name: 'already gated command',+ existingCommandMenuItem: {+ ...LEGACY_COMMAND_MENU_ITEM,+ conditionalAvailabilityExpression: GATED_EXPRESSION,+ },+ },+ {+ name: 'customized expression',+ existingCommandMenuItem: {+ ...LEGACY_COMMAND_MENU_ITEM,+ conditionalAvailabilityExpression:+ 'targetObjectReadPermissions.workflowVersion and objectPermissions.canReadObjectRecords',+ },+ },+ ])('skips $name', ({ existingCommandMenuItem }) => {+ expect(+ buildGateWorkflowVersionNavigationCommandMenuItemUpdate({+ existingCommandMenuItem,+ conditionalAvailabilityExpression: GATED_EXPRESSION,+ now: NOW,+ }),+ ).toBeUndefined();+ });+});diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-gate-workflow-version-navigation-command-menu-item-update.util.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-gate-workflow-version-navigation-command-menu-item-update.util.tsnew file mode 100644index 00000000000..73df85a5a0a--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-gate-workflow-version-navigation-command-menu-item-update.util.ts@@ -0,0 +1,30 @@+import { isDefined } from 'twenty-shared/utils';++import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';++export const LEGACY_WORKFLOW_VERSION_NAVIGATION_AVAILABILITY_EXPRESSION =+ 'targetObjectReadPermissions.workflowVersion';++export const buildGateWorkflowVersionNavigationCommandMenuItemUpdate = ({+ existingCommandMenuItem,+ conditionalAvailabilityExpression,+ now,+}: {+ existingCommandMenuItem: FlatCommandMenuItem | undefined;+ conditionalAvailabilityExpression: string;+ now: string;+}): FlatCommandMenuItem | undefined => {+ if (+ !isDefined(existingCommandMenuItem) ||+ existingCommandMenuItem.conditionalAvailabilityExpression !==+ LEGACY_WORKFLOW_VERSION_NAVIGATION_AVAILABILITY_EXPRESSION+ ) {+ return undefined;+ }++ return {+ ...existingCommandMenuItem,+ conditionalAvailabilityExpression,+ updatedAt: now,+ };+};diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/__tests__/build-object-navigation-universal-flat-command-menu-item.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/__tests__/build-object-navigation-universal-flat-command-menu-item.util.spec.tsindex 85334b8ad7c..82140411c10 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/__tests__/build-object-navigation-universal-flat-command-menu-item.util.spec.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/__tests__/build-object-navigation-universal-flat-command-menu-item.util.spec.ts@@ -32,4 +32,25 @@ describe('buildNavigationConditionalAvailabilityExpression', () => {}),).toBe('targetObjectReadPermissions.messageCampaign');});++ it('hides a standard object whose flag replaces its navigation', () => {+ expect(+ buildNavigationConditionalAvailabilityExpression({+ universalIdentifier:+ STANDARD_OBJECTS.workflowVersion.universalIdentifier,+ nameSingular: 'workflowVersion',+ }),+ ).toBe(+ 'not featureFlags.IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED and targetObjectReadPermissions.workflowVersion',+ );+ });++ it('does not hide a custom object that reuses a hidden object name', () => {+ expect(+ buildNavigationConditionalAvailabilityExpression({+ universalIdentifier: 'custom-object-universal-id',+ nameSingular: 'workflowVersion',+ }),+ ).toBe('targetObjectReadPermissions.workflowVersion');+ });});diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/build-object-navigation-universal-flat-command-menu-item.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/build-object-navigation-universal-flat-command-menu-item.util.tsindex f130b009fba..6432ba41fc6 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/build-object-navigation-universal-flat-command-menu-item.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/build-object-navigation-universal-flat-command-menu-item.util.ts@@ -34,6 +34,13 @@ const NAVIGATION_FEATURE_FLAG_GATE_BY_OBJECT_UNIVERSAL_IDENTIFIER: Partial<FeatureFlagKey.IS_EMAIL_GROUP_ENABLED,};+const NAVIGATION_HIDING_FEATURE_FLAG_BY_OBJECT_UNIVERSAL_IDENTIFIER: Partial<+ Record<string, FeatureFlagKey>+> = {+ [STANDARD_OBJECTS.workflowVersion.universalIdentifier]:+ FeatureFlagKey.IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED,+};+export const buildNavigationConditionalAvailabilityExpression = ({universalIdentifier,nameSingular,@@ -46,6 +53,14 @@ export const buildNavigationConditionalAvailabilityExpression = ({NAVIGATION_FEATURE_FLAG_GATE_BY_OBJECT_UNIVERSAL_IDENTIFIER[universalIdentifier];+ const hidingFeatureFlagGate =+ NAVIGATION_HIDING_FEATURE_FLAG_BY_OBJECT_UNIVERSAL_IDENTIFIER[+ universalIdentifier+ ];++ if (isDefined(hidingFeatureFlagGate)) {+ return `not featureFlags.${hidingFeatureFlagGate} and ${targetObjectReadPermissionExpression}`;+ }return isDefined(featureFlagGate)? `featureFlags.${featureFlagGate} and ${targetObjectReadPermissionExpression}`