The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Add IS_FEATURE_FLAG_MANAGEMENT_ENABLED to unlock feature flag toggling outside cloud (#23750)
Félix Malfait55707868cd9a
diff --git a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts b/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.tsindex f859ee2ce41..1cdeebd3d09 100644--- a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts+++ b/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts@@ -239,6 +239,7 @@ describe('ClientConfigService', () => {.mockImplementation((key: string) => {if (key === 'NODE_ENV') return NodeEnvironment.PRODUCTION;if (key === 'IS_BILLING_ENABLED') return false;+ if (key === 'IS_FEATURE_FLAG_MANAGEMENT_ENABLED') return false;return undefined;});@@ -295,5 +296,21 @@ describe('ClientConfigService', () => {expect(result.canManageFeatureFlags).toBe(true);});++ it('should allow managing feature flags when IS_FEATURE_FLAG_MANAGEMENT_ENABLED is on', async () => {+ jest+ .spyOn(twentyConfigService, 'get')+ .mockImplementation((key: string) => {+ if (key === 'NODE_ENV') return NodeEnvironment.PRODUCTION;+ if (key === 'IS_BILLING_ENABLED') return false;+ if (key === 'IS_FEATURE_FLAG_MANAGEMENT_ENABLED') return true;++ return undefined;+ });++ const result = await service.getClientConfig();++ expect(result.canManageFeatureFlags).toBe(true);+ });});});diff --git a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.ts b/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.tsindex 5a25a42fa4f..09f3a5b164d 100644--- a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.ts+++ b/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.ts@@ -252,7 +252,9 @@ export class ClientConfigService {analyticsEnabled: this.twentyConfigService.get('ANALYTICS_ENABLED'),canManageFeatureFlags:this.twentyConfigService.get('NODE_ENV') ===- NodeEnvironment.DEVELOPMENT || isBillingEnabled,+ NodeEnvironment.DEVELOPMENT ||+ isBillingEnabled ||+ this.twentyConfigService.get('IS_FEATURE_FLAG_MANAGEMENT_ENABLED'),publicFeatureFlags: PUBLIC_FEATURE_FLAGS,isCookieSessionEnabled: this.twentyConfigService.get('AUTH_COOKIE_SESSIONS_ENABLED',diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.tsindex c35f282b4b6..67341198b6a 100644--- a/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts+++ b/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts@@ -553,6 +553,15 @@ export class ConfigVariables {@IsOptional()IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS = true;+ @ConfigVariablesMetadata({+ group: ConfigVariablesGroup.ADVANCED_SETTINGS,+ description:+ 'When enabled, server admins can toggle any feature flag for any workspace from the admin panel. Always enabled in development mode and when billing is enabled.',+ type: ConfigVariableType.BOOLEAN,+ })+ @IsOptional()+ IS_FEATURE_FLAG_MANAGEMENT_ENABLED = false;+@ConfigVariablesMetadata({group: ConfigVariablesGroup.SERVER_CONFIG,description: