The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Clarify model mode comparisons with an information popup (#25947)
Thomas des Francs579d79d1a449
diff --git a/packages/twenty-front/src/modules/ai/components/AiModelTierInformationButton.tsx b/packages/twenty-front/src/modules/ai/components/AiModelTierInformationButton.tsxnew file mode 100644index 00000000000..e8bbdcb9e89--- /dev/null+++ b/packages/twenty-front/src/modules/ai/components/AiModelTierInformationButton.tsx@@ -0,0 +1,212 @@+import {+ FloatingPortal,+ autoUpdate,+ flip,+ offset,+ safePolygon,+ shift,+ useClick,+ useDismiss,+ useFloating,+ useFocus,+ useHover,+ useInteractions,+ useRole,+} from '@floating-ui/react';+import { styled } from '@linaria/react';+import { useLingui } from '@lingui/react/macro';+import { useState } from 'react';+import { isAiModelEffort } from 'twenty-shared/ai';+import { isDefined } from 'twenty-shared/utils';+import {+ IconBrain,+ IconChartBar,+ IconCpu,+ IconCurrencyDollar,+ IconGauge,+ IconInfoCircle,+} from 'twenty-ui/icon';+import { HorizontalSeparator } from 'twenty-ui/primitives/layout';+import {+ themeCssVariables,+ useThemeContainer,+} from 'twenty-ui/theme-constants';++import { type ResolvedAiModelTier } from '@/ai/types/ResolvedAiModelTier';+import { getAiModelEffortLabel } from '@/ai/utils/getAiModelEffortLabel';+import { getAiModelModeDescription } from '@/settings/ai/utils/getAiModelModeDescription';+import { UsageProgressRow } from '@/ui/feedback/progress-ring/components/UsageProgressRow';+import { StyledInformationCard } from '@/ui/layout/information-card/components/StyledInformationCard';+import { formatNumber } from '~/utils/format/formatNumber';++const StyledTrigger = styled.button`+ align-items: center;+ background: transparent;+ border: none;+ border-radius: ${themeCssVariables.border.radius.sm};+ color: ${themeCssVariables.font.color.tertiary};+ cursor: pointer;+ display: flex;+ height: 20px;+ justify-content: center;+ padding: 0;+ width: 20px;++ &:hover {+ color: ${themeCssVariables.font.color.primary};+ }++ &:focus-visible {+ outline: 2px solid ${themeCssVariables.color.blue};+ }+`;++const StyledHeading = styled.div`+ color: ${themeCssVariables.font.color.secondary};+ font-size: ${themeCssVariables.font.size.xs};+ font-weight: ${themeCssVariables.font.weight.semiBold};+ padding-bottom: ${themeCssVariables.spacing[1]};+ padding-top: ${themeCssVariables.spacing[2]};+`;++const StyledNote = styled.div`+ color: ${themeCssVariables.font.color.tertiary};+ font-size: ${themeCssVariables.font.size.sm};+`;++type AiModelTierInformationButtonProps = {+ resolvedTier: ResolvedAiModelTier;+};++export const AiModelTierInformationButton = ({+ resolvedTier,+}: AiModelTierInformationButtonProps) => {+ const { t } = useLingui();++ const [isOpen, setIsOpen] = useState(false);++ const themeContainer = useThemeContainer();++ const { refs, floatingStyles, context } = useFloating({+ open: isOpen,+ onOpenChange: setIsOpen,+ placement: 'top-end',+ middleware: [offset(8), flip(), shift({ padding: 8 })],+ whileElementsMounted: autoUpdate,+ });++ const hover = useHover(context, { handleClose: safePolygon() });++ const focus = useFocus(context);++ const click = useClick(context);++ const dismiss = useDismiss(context);++ const role = useRole(context, { role: 'tooltip' });++ const { getReferenceProps, getFloatingProps } = useInteractions([+ hover,+ focus,+ click,+ dismiss,+ role,+ ]);++ const model = resolvedTier.model;++ const effort = model?.effort;++ const formatComparison = (delta: number | undefined) =>+ isDefined(delta)+ ? `${delta > 0 ? '+' : ''}${formatNumber(delta, { decimals: 1 })}%`+ : t`Not available`;++ const rows = [+ {+ label: t`Model`,+ Icon: IconCpu,+ value: getAiModelModeDescription(resolvedTier, {+ showAutomatic: false,+ showEffort: false,+ }),+ },+ {+ label: t`Effort`,+ Icon: IconBrain,+ value: !isDefined(model)+ ? t`Not available`+ : isDefined(effort) && isAiModelEffort(effort)+ ? getAiModelEffortLabel(effort)+ : t`Default`,+ },+ ];++ const comparisons = [+ {+ label: t`Intelligence`,+ Icon: IconChartBar,+ value: formatComparison(resolvedTier.intelligenceDeltaPercent),+ },+ {+ label: t`Speed`,+ Icon: IconGauge,+ value: formatComparison(resolvedTier.speedDeltaPercent),+ },+ {+ label: t`Cost index`,+ Icon: IconCurrencyDollar,+ value: isDefined(resolvedTier.costDeltaPercent)+ ? `×${formatNumber(1 + resolvedTier.costDeltaPercent / 100, { decimals: 2 })}`+ : t`Not available`,+ },+ ];++ return (+ <>+ <StyledTrigger+ ref={refs.setReference}+ type="button"+ aria-label={t`Model information`}+ // oxlint-disable-next-line react/jsx-props-no-spreading+ {...getReferenceProps()}+ >+ <IconInfoCircle size={14} />+ </StyledTrigger>+ {isOpen && (+ <FloatingPortal root={themeContainer}>+ <StyledInformationCard+ ref={refs.setFloating}+ style={floatingStyles}+ // oxlint-disable-next-line react/jsx-props-no-spreading+ {...getFloatingProps()}+ >+ {rows.map(({ label, Icon, value }) => (+ <UsageProgressRow+ key={label}+ Icon={Icon}+ label={label}+ value={null}+ valueLabel={value}+ />+ ))}+ <HorizontalSeparator noMargin />+ <StyledHeading>{t`Vs Balanced mode`}</StyledHeading>+ {comparisons.map(({ label, Icon, value }) => (+ <UsageProgressRow+ key={label}+ Icon={Icon}+ label={label}+ value={null}+ valueLabel={value}+ />+ ))}+ {model?.isBenchmarkInherited === true && (+ <StyledNote>{t`Not measured at this effort yet, so these are the base model's readings.`}</StyledNote>+ )}+ </StyledInformationCard>+ </FloatingPortal>+ )}+ </>+ );+};diff --git a/packages/twenty-front/src/modules/ai/components/AiModelTierSlider.tsx b/packages/twenty-front/src/modules/ai/components/AiModelTierSlider.tsxindex 319e8343abe..016729a1687 100644--- a/packages/twenty-front/src/modules/ai/components/AiModelTierSlider.tsx+++ b/packages/twenty-front/src/modules/ai/components/AiModelTierSlider.tsx@@ -1,21 +1,12 @@import { styled } from '@linaria/react';import { useLingui } from '@lingui/react/macro';-import { type ChangeEvent, useContext, useId } from 'react';-import {- AI_MODEL_TIERS,- type AiModelTier,- isAiModelEffort,-} from 'twenty-shared/ai';+import { type ChangeEvent } from 'react';+import { AI_MODEL_TIERS, type AiModelTier } from 'twenty-shared/ai';import { isDefined } from 'twenty-shared/utils';-import { AppTooltip, TooltipDelay } from 'twenty-ui/primitives/surfaces';-import { ThemeContext, themeCssVariables } from 'twenty-ui/theme-constants';+import { themeCssVariables } from 'twenty-ui/theme-constants';+import { AiModelTierInformationButton } from '@/ai/components/AiModelTierInformationButton';import { useAiModelTiers } from '@/ai/hooks/useAiModelTiers';-import { getAiModelEffortLabel } from '@/ai/utils/getAiModelEffortLabel';-import { formatMetricDelta } from '@/ai/utils/formatMetricDelta';-import { getAiModelModeDescription } from '@/settings/ai/utils/getAiModelModeDescription';-import { getModelIcon } from '@/settings/ai/utils/getModelIcon';-import { getAiModelTierMetrics } from '@/ai/utils/getAiModelTierMetrics';const TRACK_HEIGHT_PX = 24;const TRACK_INSET_PX = 0;@@ -47,25 +38,6 @@ const StyledTitle = styled.span`white-space: nowrap;`;-const StyledMetrics = styled.div`- align-items: center;- display: flex;- flex-shrink: 0;- gap: ${themeCssVariables.spacing[2]};-`;--const StyledMetric = styled.span<{ isInherited: boolean }>`- align-items: center;- color: ${({ isInherited }) =>- isInherited- ? themeCssVariables.font.color.light- : themeCssVariables.font.color.tertiary};- display: flex;- font-size: ${themeCssVariables.font.size.sm};- font-weight: ${themeCssVariables.font.weight.regular};- gap: ${themeCssVariables.spacing[1]};-`;-const StyledTrack = styled.div<{ disabled: boolean }>`background: ${themeCssVariables.background.tertiary};border-radius: ${themeCssVariables.border.radius.md};@@ -169,32 +141,10 @@ export const AiModelTierSlider = ({disabled = false,}: AiModelTierSliderProps) => {const { t } = useLingui();- const { theme } = useContext(ThemeContext);const tiers = useAiModelTiers();- const tooltipId = useId().replace(/:/g, '');const selectedStep = AI_MODEL_TIERS.indexOf(selectedTier);const resolvedTier = tiers[selectedStep];- const model = resolvedTier.model;-- // The base model's reading stands in until the sync measures this effort.- const isBenchmarkInherited = model?.isBenchmarkInherited ?? false;- const inheritedNote = isBenchmarkInherited- ? t` Not measured at this effort yet, so this is the base model's reading.`- : '';-- const modelEffort = model?.effort;- const modelName = getAiModelModeDescription(resolvedTier, {- showAutomatic: false,- showEffort: false,- });- const reasoningEffort =- isDefined(modelEffort) && isAiModelEffort(modelEffort)- ? getAiModelEffortLabel(modelEffort)- : t`Default`;-- const metrics = getAiModelTierMetrics(resolvedTier);-const handleChange = (event: ChangeEvent<HTMLInputElement>) => {const tier = AI_MODEL_TIERS[Number(event.target.value)];@@ -206,21 +156,8 @@ export const AiModelTierSlider = ({return (<StyledContainer><StyledHeader>- <StyledTitle id={`ai-model-tier-name-${tooltipId}`}>- {title ?? resolvedTier.label}- </StyledTitle>- <StyledMetrics>- {metrics.map(({ key, Icon, deltaPercent }) => (- <StyledMetric- key={key}- id={`ai-model-tier-${key}-${tooltipId}`}- isInherited={isBenchmarkInherited}- >- <Icon size={theme.icon.size.sm} />- {formatMetricDelta(deltaPercent)}- </StyledMetric>- ))}- </StyledMetrics>+ <StyledTitle>{title ?? resolvedTier.label}</StyledTitle>+ <AiModelTierInformationButton resolvedTier={resolvedTier} /></StyledHeader><StyledTrackdisabled={disabled}@@ -246,27 +183,6 @@ export const AiModelTierSlider = ({aria-valuetext={resolvedTier.label}/></StyledTrack>- {isDefined(model) &&- metrics.map(({ key, description, tooltipTitle }) => (- <AppTooltip- key={key}- anchorSelect={`#ai-model-tier-${key}-${tooltipId}`}- title={tooltipTitle ?? modelName}- description={`${description}${inheritedNote}`}- delay={TooltipDelay.shortDelay}- place="bottom"- />- ))}- {isDefined(model) && (- <AppTooltip- anchorSelect={`#ai-model-tier-name-${tooltipId}`}- Icon={getModelIcon(model.modelFamily, model.providerName)}- title={modelName}- description={t`Reasoning effort: ${reasoningEffort}`}- delay={TooltipDelay.shortDelay}- place="bottom"- />- )}</StyledContainer>);};diff --git a/packages/twenty-front/src/modules/ai/components/__tests__/AiModelTierInformationButton.test.tsx b/packages/twenty-front/src/modules/ai/components/__tests__/AiModelTierInformationButton.test.tsxnew file mode 100644index 00000000000..58152de6246--- /dev/null+++ b/packages/twenty-front/src/modules/ai/components/__tests__/AiModelTierInformationButton.test.tsx@@ -0,0 +1,73 @@+import { i18n } from '@lingui/core';+import { I18nProvider } from '@lingui/react';+import { type ReactNode } from 'react';+import { render, screen, waitFor } from '@testing-library/react';+import userEvent from '@testing-library/user-event';++import { AiModelTierInformationButton } from '@/ai/components/AiModelTierInformationButton';+import { type ResolvedAiModelTier } from '@/ai/types/ResolvedAiModelTier';++const resolvedTier: ResolvedAiModelTier = {+ tier: 'smart',+ label: 'Smart',+ model: {+ modelId: 'test',+ label: 'Test model (high reasoning)',+ effort: 'high',+ },+ isPinned: false,+ intelligenceDeltaPercent: 40,+ speedDeltaPercent: 12,+ costDeltaPercent: 2300,+};++const wrapper = ({ children }: { children: ReactNode }) => (+ <I18nProvider i18n={i18n}>{children}</I18nProvider>+);++describe('AiModelTierInformationButton', () => {+ it('shows explicit comparisons on hover and dismisses with Escape', async () => {+ const user = userEvent.setup();+ render(<AiModelTierInformationButton resolvedTier={resolvedTier} />, {+ wrapper,+ });++ expect(screen.queryByText('×24')).not.toBeInTheDocument();+ await user.hover(screen.getByRole('button', { name: 'Model information' }));++ expect(await screen.findByRole('tooltip')).toBeInTheDocument();+ expect(screen.getByText('Test model')).toBeInTheDocument();+ expect(screen.getByText('High')).toBeInTheDocument();+ expect(screen.getByText('Vs Balanced mode')).toBeInTheDocument();+ expect(screen.getByText('+40%')).toBeInTheDocument();+ expect(screen.getByText('+12%')).toBeInTheDocument();+ expect(screen.getByText('×24')).toBeInTheDocument();++ await user.keyboard('{Escape}');+ await waitFor(() =>+ expect(screen.queryByRole('tooltip')).not.toBeInTheDocument(),+ );+ });++ it('opens on keyboard focus and preserves measured zero comparisons', async () => {+ const user = userEvent.setup();+ render(+ <AiModelTierInformationButton+ resolvedTier={{+ ...resolvedTier,+ intelligenceDeltaPercent: 0,+ speedDeltaPercent: undefined,+ costDeltaPercent: 0,+ }}+ />,+ { wrapper },+ );++ await user.tab();++ expect(await screen.findByRole('tooltip')).toBeInTheDocument();+ expect(screen.getByText('0%')).toBeInTheDocument();+ expect(screen.getByText('×1')).toBeInTheDocument();+ expect(screen.getByText('Not available')).toBeInTheDocument();+ });+});diff --git a/packages/twenty-front/src/modules/ai/utils/__tests__/getAiModelTierMetrics.test.ts b/packages/twenty-front/src/modules/ai/utils/__tests__/getAiModelTierMetrics.test.tsdeleted file mode 100644index 33e6cb3c09b..00000000000--- a/packages/twenty-front/src/modules/ai/utils/__tests__/getAiModelTierMetrics.test.ts+++ /dev/null@@ -1,72 +0,0 @@-import { type ResolvedAiModelTier } from '@/ai/types/ResolvedAiModelTier';-import { getAiModelTierMetrics } from '@/ai/utils/getAiModelTierMetrics';--const tier: ResolvedAiModelTier = {- tier: 'smart',- label: 'Smart',- model: {- modelId: 'test',- label: 'Test',- intelligenceIndex: 51,- outputTokensPerSecond: 113,- },- isPinned: false,- speedDeltaPercent: 10,- costDeltaPercent: -23,- intelligenceDeltaPercent: 8,-};--describe('getAiModelTierMetrics', () => {- it('shows cost and intelligence above Balanced', () => {- expect(getAiModelTierMetrics(tier)).toEqual([- expect.objectContaining({- key: 'cost',- description: '23% lower cost than Balanced.',- }),- expect.objectContaining({- key: 'intelligence',- tooltipTitle: 'Intelligence score: 51',- description: '8% higher score than Balanced',- }),- ]);- });-- it('shows speed and cost below Balanced', () => {- expect(- getAiModelTierMetrics({ ...tier, tier: 'fast' }).map(({ key }) => key),- ).toEqual(['speed', 'cost']);- });-- it('shows no comparison for Balanced', () => {- expect(getAiModelTierMetrics({ ...tier, tier: 'balanced' })).toEqual([]);- });-- it('omits missing readings while preserving measured ties', () => {- expect(- getAiModelTierMetrics({- ...tier,- costDeltaPercent: undefined,- intelligenceDeltaPercent: 0,- }),- ).toEqual([- expect.objectContaining({- key: 'intelligence',- deltaPercent: 0,- description: 'Same score as Balanced',- }),- ]);- });-- it('uses multipliers for increases of at least 100 percent', () => {- expect(- getAiModelTierMetrics({- ...tier,- costDeltaPercent: 100,- intelligenceDeltaPercent: 150,- }),- ).toEqual([- expect.objectContaining({ description: '2× the cost of Balanced.' }),- expect.objectContaining({ description: '2.5× the score of Balanced' }),- ]);- });-});diff --git a/packages/twenty-front/src/modules/ai/utils/getAiModelTierMetrics.ts b/packages/twenty-front/src/modules/ai/utils/getAiModelTierMetrics.tsdeleted file mode 100644index 2dba23e798c..00000000000--- a/packages/twenty-front/src/modules/ai/utils/getAiModelTierMetrics.ts+++ /dev/null@@ -1,99 +0,0 @@-import { t } from '@lingui/core/macro';-import { AI_MODEL_TIERS } from 'twenty-shared/ai';-import { isDefined } from 'twenty-shared/utils';-import {- IconBolt,- IconBrain,- IconCoins,- type IconComponent,-} from 'twenty-ui/icon';--import { type ResolvedAiModelTier } from '@/ai/types/ResolvedAiModelTier';-import { formatMetricDelta } from '@/ai/utils/formatMetricDelta';-import { formatNumber } from '~/utils/format/formatNumber';--const BALANCED_STEP = AI_MODEL_TIERS.indexOf('balanced');--type TierMetric = {- key: string;- Icon: IconComponent;- deltaPercent: number | undefined;- tooltipTitle?: string;- description: string;-};--const getComparison = (- delta: number,- labels: { multiplier: string; lower: string; higher: string; equal: string },-) => {- if (delta >= 100) return labels.multiplier;- if (delta < 0) return labels.lower;- if (delta === 0) return labels.equal;- return labels.higher;-};--const hasDeltaToShow = (- metric: TierMetric,-): metric is TierMetric & { deltaPercent: number } =>- isDefined(metric.deltaPercent);--export const getAiModelTierMetrics = (resolvedTier: ResolvedAiModelTier) => {- const selectedStep = AI_MODEL_TIERS.indexOf(resolvedTier.tier);- const model = resolvedTier.model;-- const intelligenceDelta = resolvedTier.intelligenceDeltaPercent ?? 0;- const intelligenceComparison = getComparison(intelligenceDelta, {- multiplier: t`${formatMetricDelta(intelligenceDelta)} the score of Balanced`,- lower: t`${formatNumber(Math.abs(intelligenceDelta))}% lower score than Balanced`,- higher: t`${formatNumber(intelligenceDelta)}% higher score than Balanced`,- equal: t`Same score as Balanced`,- });- const intelligenceScore = t`Intelligence score: ${formatNumber(model?.intelligenceIndex ?? 0)}`;- const costDelta = resolvedTier.costDeltaPercent ?? 0;- const costComparison = getComparison(costDelta, {- multiplier: t`${formatMetricDelta(costDelta)} the cost of Balanced.`,- lower: t`${formatNumber(Math.abs(costDelta))}% lower cost than Balanced.`,- higher: t`${formatNumber(costDelta)}% higher cost than Balanced.`,- equal: t`Same cost as Balanced.`,- });- // Below Balanced the gain is speed, above it intelligence; cost moves with- // both, so each side shows the two figures that explain the trade.- const candidateMetrics: TierMetric[] = [- ...(selectedStep < BALANCED_STEP- ? [- {- key: 'speed',- Icon: IconBolt,- deltaPercent: resolvedTier.speedDeltaPercent,- description:- (resolvedTier.speedDeltaPercent ?? 0) >= 100- ? t`${formatNumber(model?.outputTokensPerSecond ?? 0)} tokens/s, ${formatMetricDelta(resolvedTier.speedDeltaPercent ?? 0)} the speed of Balanced Mode.`- : t`${formatNumber(model?.outputTokensPerSecond ?? 0)} tokens/s, a ${formatMetricDelta(resolvedTier.speedDeltaPercent ?? 0)} change in speed compared with Balanced Mode.`,- },- ]- : []),- ...(selectedStep !== BALANCED_STEP- ? [- {- key: 'cost',- Icon: IconCoins,- deltaPercent: resolvedTier.costDeltaPercent,- description: costComparison,- },- ]- : []),- ...(selectedStep > BALANCED_STEP- ? [- {- key: 'intelligence',- Icon: IconBrain,- deltaPercent: resolvedTier.intelligenceDeltaPercent,- tooltipTitle: intelligenceScore,- description: intelligenceComparison,- },- ]- : []),- ];-- return candidateMetrics.filter(hasDeltaToShow);-};