The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Update Ask AI command icon and migrate legacy sparkle icon in 2.38 (#25201)
Félix Malfait58787521a79c
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1787938100000-pin-ask-ai-command-menu-item.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1787938100000-pin-ask-ai-command-menu-item.command.tsindex b101e764961..056f26928b3 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1787938100000-pin-ask-ai-command-menu-item.command.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1787938100000-pin-ask-ai-command-menu-item.command.ts@@ -16,7 +16,7 @@ import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspa@Command({name: 'upgrade:2-38:pin-ask-ai-command-menu-item',description:- 'Pin the Ask AI command to page headers as an icon-only action across the app',+ 'Pin the Ask AI command to page headers with its updated icon as an icon-only action across the app',})export class PinAskAiCommandMenuItemCommand extends ProvisionedWorkspaceCommandRunner {constructor(@@ -49,7 +49,9 @@ export class PinAskAiCommandMenuItemCommand extends ProvisionedWorkspaceCommandR}if (options.dryRun) {- this.logger.log(`Would pin the Ask AI command for workspace ${workspaceId}`);+ this.logger.log(+ `Would pin the Ask AI command and update its icon for workspace ${workspaceId}`,+ );return;}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-pin-ask-ai-command-menu-item-update.util.spec.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-pin-ask-ai-command-menu-item-update.util.spec.tsindex 155d6b35120..d37d571b936 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-pin-ask-ai-command-menu-item-update.util.spec.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-pin-ask-ai-command-menu-item-update.util.spec.ts@@ -17,10 +17,11 @@ const LEGACY_COMMAND_MENU_ITEM: FlatCommandMenuItem = Object.freeze({}),isPinned: false,shortLabel: 'Ask AI',+ icon: 'IconSparkles',});describe('buildPinAskAiCommandMenuItemUpdate', () => {- it('pins the command and drops its short label without changing other fields', () => {+ it('pins the command, drops its short label, and updates its icon', () => {expect(buildPinAskAiCommandMenuItemUpdate({existingCommandMenuItem: LEGACY_COMMAND_MENU_ITEM,@@ -30,6 +31,7 @@ describe('buildPinAskAiCommandMenuItemUpdate', () => {...LEGACY_COMMAND_MENU_ITEM,isPinned: true,shortLabel: null,+ icon: 'IconMessageCirclePlus',updatedAt: NOW,});});@@ -50,6 +52,13 @@ describe('buildPinAskAiCommandMenuItemUpdate', () => {shortLabel: 'Ask Twenty',},},+ {+ name: 'custom icon',+ existingCommandMenuItem: {+ ...LEGACY_COMMAND_MENU_ITEM,+ icon: 'IconRobot',+ },+ },{name: 'workspace pinning override',existingCommandMenuItem: {@@ -64,6 +73,13 @@ describe('buildPinAskAiCommandMenuItemUpdate', () => {overrides: { shortLabel: 'Ask AI' },},},+ {+ name: 'workspace icon override',+ existingCommandMenuItem: {+ ...LEGACY_COMMAND_MENU_ITEM,+ overrides: { icon: 'IconSparkles' },+ },+ },])('skips $name', ({ existingCommandMenuItem }) => {expect(buildPinAskAiCommandMenuItemUpdate({ existingCommandMenuItem, now: NOW }),diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-pin-ask-ai-command-menu-item-update.util.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-pin-ask-ai-command-menu-item-update.util.tsindex 040d86bc10b..1e5047621dd 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-pin-ask-ai-command-menu-item-update.util.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-pin-ask-ai-command-menu-item-update.util.ts@@ -4,6 +4,7 @@ import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-commaimport { STANDARD_COMMAND_MENU_ITEMS } from 'src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant';const LEGACY_ASK_AI_SHORT_LABEL = 'Ask AI';+const LEGACY_ASK_AI_ICON = 'IconSparkles';export const buildPinAskAiCommandMenuItemUpdate = ({existingCommandMenuItem,@@ -16,16 +17,18 @@ export const buildPinAskAiCommandMenuItemUpdate = ({return undefined;}- // Pinning and short labels are workspace-editable, so an override means the+ // These properties are workspace-editable, so an override means the// workspace already made its own choice for this command.const hasWorkspaceOverride =isDefined(existingCommandMenuItem.overrides?.isPinned) ||- isDefined(existingCommandMenuItem.overrides?.shortLabel);+ isDefined(existingCommandMenuItem.overrides?.shortLabel) ||+ isDefined(existingCommandMenuItem.overrides?.icon);if (hasWorkspaceOverride ||existingCommandMenuItem.isPinned !== false ||- existingCommandMenuItem.shortLabel !== LEGACY_ASK_AI_SHORT_LABEL+ existingCommandMenuItem.shortLabel !== LEGACY_ASK_AI_SHORT_LABEL ||+ existingCommandMenuItem.icon !== LEGACY_ASK_AI_ICON) {return undefined;}@@ -34,6 +37,7 @@ export const buildPinAskAiCommandMenuItemUpdate = ({...existingCommandMenuItem,isPinned: STANDARD_COMMAND_MENU_ITEMS.askAi.isPinned,shortLabel: STANDARD_COMMAND_MENU_ITEMS.askAi.shortLabel,+ icon: STANDARD_COMMAND_MENU_ITEMS.askAi.icon,updatedAt: now,};};diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.tsindex 622de49e01b..c18d289f4fc 100644--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts@@ -872,7 +872,7 @@ export const STANDARD_COMMAND_MENU_ITEMS = {label: i18nLabel(msg({ message: `Ask AI`, context: 'commandMenuItem.label' }),),- icon: 'IconSparkles',+ icon: 'IconMessageCirclePlus',isPinned: true,position: 43,shortLabel: null,