Skip to content

The open alternative to Salesforce, designed for AI.

chore(members): rename "Access" tab to "Invite" + fix e2e (#20447)

Félix Malfait626455b5348b
diff --git a/packages/twenty-docs/user-guide/settings/capabilities/domains-settings.mdx b/packages/twenty-docs/user-guide/settings/capabilities/domains-settings.mdx
index de369d3dc42..3a8207915fb 100644
--- a/packages/twenty-docs/user-guide/settings/capabilities/domains-settings.mdx
+++ b/packages/twenty-docs/user-guide/settings/capabilities/domains-settings.mdx
@@ -20,7 +20,7 @@ For custom domains, you'll need to configure DNS settings with your domain provi
## Approved Domains
-Configure under **Settings → Members → Access**.
+Configure under **Settings → Members → Invite**.
Anyone with an email address at these domains is allowed to sign up for this workspace automatically.
diff --git a/packages/twenty-docs/user-guide/settings/capabilities/member-management.mdx b/packages/twenty-docs/user-guide/settings/capabilities/member-management.mdx
index 2483a243386..016b37e402a 100644
--- a/packages/twenty-docs/user-guide/settings/capabilities/member-management.mdx
+++ b/packages/twenty-docs/user-guide/settings/capabilities/member-management.mdx
@@ -67,7 +67,7 @@ Manage invitations that haven't been accepted:
Allow team members to join automatically based on their email domain:
-1. Go to **Settings → Members → Access**
+1. Go to **Settings → Members → Invite**
2. Add your company domain (e.g., `yourcompany.com`)
3. Anyone with that email domain can join without an invitation
diff --git a/packages/twenty-docs/user-guide/settings/how-tos/settings-faq.mdx b/packages/twenty-docs/user-guide/settings/how-tos/settings-faq.mdx
index f72a05cef84..bc84c739796 100644
--- a/packages/twenty-docs/user-guide/settings/how-tos/settings-faq.mdx
+++ b/packages/twenty-docs/user-guide/settings/how-tos/settings-faq.mdx
@@ -146,7 +146,7 @@ A subdomain is quick to set up, while a custom domain provides a fully branded e
</Accordion>
<Accordion title="How do approved access domains work?">
-You can configure approved access domains so team members with company email addresses can automatically join your workspace. Go to **Settings → Members → Access** and add your company domain (e.g., `yourcompany.com`).
+You can configure approved access domains so team members with company email addresses can automatically join your workspace. Go to **Settings → Members → Invite** and add your company domain (e.g., `yourcompany.com`).
</Accordion>
</AccordionGroup>
diff --git a/packages/twenty-e2e-testing/lib/pom/settings/membersSection.ts b/packages/twenty-e2e-testing/lib/pom/settings/membersSection.ts
index 4f108665702..aee89b998b6 100644
--- a/packages/twenty-e2e-testing/lib/pom/settings/membersSection.ts
+++ b/packages/twenty-e2e-testing/lib/pom/settings/membersSection.ts
@@ -1,12 +1,14 @@
import { Locator, Page } from '@playwright/test';
export class MembersSection {
+ private readonly inviteTab: Locator;
private readonly inviteMembersField: Locator;
private readonly inviteMembersButton: Locator;
private readonly inviteLinkButton: Locator;
constructor(public readonly page: Page) {
this.page = page;
+ this.inviteTab = page.getByTestId('tab-invite');
this.inviteMembersField = page.getByPlaceholder(
'[email protected], jony.ive@apple',
);
@@ -14,11 +16,17 @@ export class MembersSection {
this.inviteLinkButton = page.getByRole('button', { name: 'Copy link' });
}
+ async goToInviteTab() {
+ await this.inviteTab.click();
+ }
+
async copyInviteLink() {
+ await this.goToInviteTab();
await this.inviteLinkButton.click();
}
async sendInviteEmail(email: string) {
+ await this.goToInviteTab();
await this.inviteMembersField.click();
await this.inviteMembersField.fill(email);
await this.inviteMembersButton.click();
diff --git a/packages/twenty-front/src/pages/settings/members/SettingsWorkspaceMembers.tsx b/packages/twenty-front/src/pages/settings/members/SettingsWorkspaceMembers.tsx
index 72ef55f56fb..e72a38c158c 100644
--- a/packages/twenty-front/src/pages/settings/members/SettingsWorkspaceMembers.tsx
+++ b/packages/twenty-front/src/pages/settings/members/SettingsWorkspaceMembers.tsx
@@ -1,7 +1,7 @@
import { Trans, useLingui } from '@lingui/react/macro';
import { SettingsPath } from 'twenty-shared/types';
import { getSettingsPath } from 'twenty-shared/utils';
-import { IconKey, IconLock, IconUsers } from 'twenty-ui/display';
+import { IconLock, IconUserPlus, IconUsers } from 'twenty-ui/display';
import { useHasPermissionFlag } from '@/settings/roles/hooks/useHasPermissionFlag';
import { SettingsPageContainer } from '@/settings/components/SettingsPageContainer';
@@ -10,14 +10,14 @@ import { TabList } from '@/ui/layout/tab-list/components/TabList';
import { activeTabIdComponentState } from '@/ui/layout/tab-list/states/activeTabIdComponentState';
import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';
import { PermissionFlagType } from '~/generated-metadata/graphql';
-import { SettingsWorkspaceMembersAccessTab } from '~/pages/settings/members/tabs/SettingsWorkspaceMembersAccessTab';
+import { SettingsWorkspaceMembersInviteTab } from '~/pages/settings/members/tabs/SettingsWorkspaceMembersInviteTab';
import { SettingsWorkspaceMembersRolesTab } from '~/pages/settings/members/tabs/SettingsWorkspaceMembersRolesTab';
import { SettingsWorkspaceMembersTeamTab } from '~/pages/settings/members/tabs/SettingsWorkspaceMembersTeamTab';
const MEMBERS_TAB_LIST_ID = 'members-tab-list';
const MEMBERS_TAB_TEAM_ID = 'team';
-const MEMBERS_TAB_ACCESS_ID = 'access';
+const MEMBERS_TAB_INVITE_ID = 'invite';
const MEMBERS_TAB_ROLES_ID = 'roles';
export const SettingsWorkspaceMembers = () => {
@@ -32,7 +32,7 @@ export const SettingsWorkspaceMembers = () => {
const tabs = [
{ id: MEMBERS_TAB_TEAM_ID, title: t`Team`, Icon: IconUsers },
- { id: MEMBERS_TAB_ACCESS_ID, title: t`Access`, Icon: IconKey },
+ { id: MEMBERS_TAB_INVITE_ID, title: t`Invite`, Icon: IconUserPlus },
...(hasRolesPermission
? [{ id: MEMBERS_TAB_ROLES_ID, title: t`Roles`, Icon: IconLock }]
: []),
@@ -40,8 +40,8 @@ export const SettingsWorkspaceMembers = () => {
const renderActiveTabContent = () => {
switch (activeTabId) {
- case MEMBERS_TAB_ACCESS_ID:
- return <SettingsWorkspaceMembersAccessTab />;
+ case MEMBERS_TAB_INVITE_ID:
+ return <SettingsWorkspaceMembersInviteTab />;
case MEMBERS_TAB_ROLES_ID:
return hasRolesPermission ? (
<SettingsWorkspaceMembersRolesTab />
diff --git a/packages/twenty-front/src/pages/settings/members/tabs/SettingsWorkspaceMembersAccessTab.tsx b/packages/twenty-front/src/pages/settings/members/tabs/SettingsWorkspaceMembersInviteTab.tsx
similarity index 99%
rename from packages/twenty-front/src/pages/settings/members/tabs/SettingsWorkspaceMembersAccessTab.tsx
rename to packages/twenty-front/src/pages/settings/members/tabs/SettingsWorkspaceMembersInviteTab.tsx
index 6c6c1794a95..df122d38524 100644
--- a/packages/twenty-front/src/pages/settings/members/tabs/SettingsWorkspaceMembersAccessTab.tsx
+++ b/packages/twenty-front/src/pages/settings/members/tabs/SettingsWorkspaceMembersInviteTab.tsx
@@ -71,7 +71,7 @@ const StyledTableRows = styled.div`
padding-top: ${themeCssVariables.spacing[2]};
`;
-export const SettingsWorkspaceMembersAccessTab = () => {
+export const SettingsWorkspaceMembersInviteTab = () => {
const { theme } = useContext(ThemeContext);
const { t } = useLingui();
const { enqueueErrorSnackBar } = useSnackBar();