Skip to content

The open alternative to Salesforce, designed for AI.

Drop the canProposeToolCalls run capability (#27528)

Félix Malfait63fb120298a9
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run.service.spec.ts
index 3fcfe8b8a61..5297731da5c 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run.service.spec.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run.service.spec.ts
@@ -111,7 +111,6 @@ describe('AgentRunService', () => {
toolLoadingStrategy: 'lazy',
capabilities: {
canAskHumans: false,
- canProposeToolCalls: false,
},
});
expect(prompt).toEqual({
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-runner.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-runner.service.spec.ts
index a2ad11d47e2..6b66340446c 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-runner.service.spec.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-runner.service.spec.ts
@@ -58,7 +58,6 @@ const RUN_INPUT: AgentRunnerRunInput = {
instructions: null,
capabilities: {
canAskHumans: false,
- canProposeToolCalls: false,
},
},
agent: null,
@@ -171,6 +170,28 @@ describe('AgentRunnerService', () => {
);
});
+ it.each([true, false])(
+ 'offers every human-input tool only to a run that can ask humans (%s)',
+ async (canAskHumans) => {
+ const { service, agentAsyncExecutorService } = buildService();
+
+ await service.run({
+ ...RUN_INPUT,
+ spec: { ...RUN_INPUT.spec, capabilities: { canAskHumans } },
+ });
+
+ const [{ pausingTools, canProposeToolCalls }] =
+ agentAsyncExecutorService.executeAgent.mock.calls[0];
+
+ expect(canProposeToolCalls).toBe(canAskHumans);
+ expect(Object.keys(pausingTools)).toEqual(
+ canAskHumans
+ ? expect.arrayContaining(['ask_question', 'request_form'])
+ : expect.not.arrayContaining(['ask_question', 'request_form']),
+ );
+ },
+ );
+
it('locks a conversation it just created without reading it', async () => {
const {
service,
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run.service.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run.service.ts
index 10b057669d1..85bd0c5e1db 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run.service.ts
@@ -198,7 +198,6 @@ export class AgentRunService
// the call returns before anyone could answer, so the run can wait but not ask
capabilities: {
canAskHumans: false,
- canProposeToolCalls: false,
},
toolLoadingStrategy: 'lazy',
},
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-runner.service.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-runner.service.ts
index e51cbe3ed7d..b5094103395 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-runner.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-runner.service.ts
@@ -257,7 +257,7 @@ export class AgentRunnerService {
}
: {}),
},
- canProposeToolCalls: spec.capabilities.canProposeToolCalls,
+ canProposeToolCalls: spec.capabilities.canAskHumans,
actorContext: executionContext.actorContext,
authContext: executionContext.authContext,
workspaceId,
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/types/agent-run-spec.type.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/types/agent-run-spec.type.ts
index 55b2ca9cc86..ac3cfe63b52 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/types/agent-run-spec.type.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/types/agent-run-spec.type.ts
@@ -10,10 +10,8 @@ export type AgentRunSpec = {
// the caller's own instructions, after what the engine says about its pausing tools
instructions: string | null;
capabilities: {
- // ask_question and request_form, answered from the conversation
+ // ask_question, request_form and propose_tool_call, answered from the conversation
canAskHumans: boolean;
- // propose_tool_call, for an action a person approves first
- canProposeToolCalls: boolean;
};
additionalExcludedToolNames?: string[];
toolLoadingStrategy?: AgentToolLoadingStrategy;
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-trigger/services/__tests__/agent-trigger-runner.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-trigger/services/__tests__/agent-trigger-runner.service.spec.ts
index 404802fe2e2..7b7f48d48cf 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-trigger/services/__tests__/agent-trigger-runner.service.spec.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-trigger/services/__tests__/agent-trigger-runner.service.spec.ts
@@ -112,7 +112,6 @@ describe('AgentTriggerRunnerService', () => {
toolLoadingStrategy: 'lazy',
capabilities: {
canAskHumans: false,
- canProposeToolCalls: false,
},
}),
prompt: expect.objectContaining({
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-trigger/services/agent-trigger-runner.service.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-trigger/services/agent-trigger-runner.service.ts
index de5e0f2a4c0..c269a060293 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-trigger/services/agent-trigger-runner.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-trigger/services/agent-trigger-runner.service.ts
@@ -90,7 +90,6 @@ export class AgentTriggerRunnerService
// nobody is there to answer, so the run can wait but not ask
capabilities: {
canAskHumans: false,
- canProposeToolCalls: false,
},
toolLoadingStrategy: 'lazy',
},
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/ai-agent/utils/__tests__/build-workflow-agent-run-spec.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/ai-agent/utils/__tests__/build-workflow-agent-run-spec.util.spec.ts
index 594ac06decd..eafb7a6fed3 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/ai-agent/utils/__tests__/build-workflow-agent-run-spec.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/ai-agent/utils/__tests__/build-workflow-agent-run-spec.util.spec.ts
@@ -38,7 +38,6 @@ describe('buildWorkflowAgentRunSpec', () => {
instructions: null,
capabilities: {
canAskHumans: false,
- canProposeToolCalls: false,
},
});
expect(spec).not.toHaveProperty('additionalExcludedToolNames');
@@ -56,7 +55,6 @@ describe('buildWorkflowAgentRunSpec', () => {
expect(spec.agentId).toBe('agent-id');
expect(spec.capabilities).toEqual({
canAskHumans: true,
- canProposeToolCalls: true,
});
expect(spec.instructions).toMatch(/Ask before choosing a plan\.$/);
});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/ai-agent/utils/build-workflow-agent-run-spec.util.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/ai-agent/utils/build-workflow-agent-run-spec.util.ts
index 9bc3327bce1..38b6c2c122f 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/ai-agent/utils/build-workflow-agent-run-spec.util.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/ai-agent/utils/build-workflow-agent-run-spec.util.ts
@@ -27,7 +27,6 @@ export const buildWorkflowAgentRunSpec = ({
: null,
capabilities: {
canAskHumans,
- canProposeToolCalls: canAskHumans,
},
...(isApplicationBound
? {