Skip to content

The open alternative to Salesforce, designed for AI.

Require registration ownership when exporting applications (#26928)

Weiko647debd508cb
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-manifest/services/application-manifest-export.service.ts b/packages/twenty-server/src/engine/core-modules/application/application-manifest/services/application-manifest-export.service.ts
index e1da250fd86..779d7cda397 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-manifest/services/application-manifest-export.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-manifest/services/application-manifest-export.service.ts
@@ -15,6 +15,7 @@ import { reconstructNavigationMenuItemsManifest } from 'src/engine/core-modules/
import { reconstructPageLayoutsManifest } from 'src/engine/core-modules/application/application-manifest/utils/reconstruct-page-layouts-manifest.util';
import { reconstructRolesManifest } from 'src/engine/core-modules/application/application-manifest/utils/reconstruct-roles-manifest.util';
import { reconstructViewsManifest } from 'src/engine/core-modules/application/application-manifest/utils/reconstruct-views-manifest.util';
+import { ApplicationRegistrationService } from 'src/engine/core-modules/application/application-registration/application-registration.service';
import { ApplicationTranslationCacheService } from 'src/engine/core-modules/application/application-translation/application-translation-cache.service';
import {
ApplicationException,
@@ -42,6 +43,7 @@ export class ApplicationManifestExportService {
constructor(
private readonly workspaceCacheService: WorkspaceCacheService,
private readonly applicationTranslationCacheService: ApplicationTranslationCacheService,
+ private readonly applicationRegistrationService: ApplicationRegistrationService,
) {}
async exportApplication({
@@ -71,6 +73,11 @@ export class ApplicationManifestExportService {
assertFlatApplicationIsExportable(flatApplication);
+ await this.applicationRegistrationService.findOneOwnedByWorkspaceOrThrow({
+ universalIdentifier: applicationUniversalIdentifier,
+ workspaceId,
+ });
+
const applicationAllFlatEntityMaps = getApplicationSubAllFlatEntityMaps({
applicationIds: [flatApplication.id],
fromAllFlatEntityMaps: allFlatEntityMaps,
diff --git a/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/failing-export-application-registration-ownership.integration-spec.ts.snap b/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/failing-export-application-registration-ownership.integration-spec.ts.snap
new file mode 100644
index 00000000000..e17e03c0b6d
--- /dev/null
+++ b/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/failing-export-application-registration-ownership.integration-spec.ts.snap
@@ -0,0 +1,25 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Application export should fail when another workspace owns the application registration 1`] = `
+{
+ "extensions": {
+ "code": "FORBIDDEN",
+ "subCode": "FORBIDDEN",
+ "userFriendlyMessage": "You do not have permission to perform this action.",
+ },
+ "message": ""<applicationUniversalIdentifier>" is registered to another workspace. Change the universalIdentifier in your manifest, or transfer the registration from the owning workspace.",
+ "name": "ForbiddenError",
+}
+`;
+
+exports[`Application export should fail when no workspace has claimed the application registration 1`] = `
+{
+ "extensions": {
+ "code": "FORBIDDEN",
+ "subCode": "FORBIDDEN",
+ "userFriendlyMessage": "You do not have permission to perform this action.",
+ },
+ "message": ""<applicationUniversalIdentifier>" is registered on this instance but claimed by no workspace. Claim its ownership before developing on it.",
+ "name": "ForbiddenError",
+}
+`;
diff --git a/packages/twenty-server/test/integration/metadata/suites/application/failing-export-application-registration-ownership.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/application/failing-export-application-registration-ownership.integration-spec.ts
new file mode 100644
index 00000000000..caa7a176167
--- /dev/null
+++ b/packages/twenty-server/test/integration/metadata/suites/application/failing-export-application-registration-ownership.integration-spec.ts
@@ -0,0 +1,97 @@
+import { expectOneNotInternalServerErrorSnapshot } from 'test/integration/graphql/utils/expect-one-not-internal-server-error-snapshot.util';
+import { cleanupApplicationAndAppRegistration } from 'test/integration/metadata/suites/application/utils/cleanup-application-and-app-registration.util';
+import { exportApplication } from 'test/integration/metadata/suites/application/utils/export-application.util';
+import { setupApplicationForSync } from 'test/integration/metadata/suites/application/utils/setup-application-for-sync.util';
+import {
+ type EachTestingContext,
+ eachTestingContextFilter,
+} from 'twenty-shared/testing';
+import { v4 as uuidv4 } from 'uuid';
+
+import {
+ SEED_APPLE_WORKSPACE_ID,
+ SEED_YCOMBINATOR_WORKSPACE_ID,
+} from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';
+
+const TEST_APP_UID = uuidv4();
+
+type TestContext = {
+ ownerWorkspaceId: string | null;
+};
+
+const FAILING_TEST_CASES: EachTestingContext<TestContext>[] = [
+ {
+ title: 'when another workspace owns the application registration',
+ context: { ownerWorkspaceId: SEED_YCOMBINATOR_WORKSPACE_ID },
+ },
+ {
+ title: 'when no workspace has claimed the application registration',
+ context: { ownerWorkspaceId: null },
+ },
+];
+
+const normalizeMessage = (message: string) =>
+ message.replace(
+ new RegExp(TEST_APP_UID, 'g'),
+ '<applicationUniversalIdentifier>',
+ );
+
+const setTestRegistrationOwnerWorkspaceId = async (
+ ownerWorkspaceId: string | null,
+) => {
+ await globalThis.testDataSource.query(
+ `UPDATE core."applicationRegistration" SET "workspaceId" = $1
+ WHERE "universalIdentifier" = $2`,
+ [ownerWorkspaceId, TEST_APP_UID],
+ );
+};
+
+describe('Application export should fail', () => {
+ beforeAll(async () => {
+ await setupApplicationForSync({
+ applicationUniversalIdentifier: TEST_APP_UID,
+ name: 'Test Application Export Ownership App',
+ description: 'App for verifying registration ownership on export',
+ sourcePath: 'test-application-export-ownership',
+ });
+ }, 60000);
+
+ beforeEach(() => {
+ jest.useRealTimers();
+ });
+
+ afterEach(async () => {
+ await setTestRegistrationOwnerWorkspaceId(SEED_APPLE_WORKSPACE_ID);
+ jest.useFakeTimers();
+ });
+
+ afterAll(async () => {
+ await cleanupApplicationAndAppRegistration({
+ applicationUniversalIdentifier: TEST_APP_UID,
+ });
+ });
+
+ it.each(eachTestingContextFilter(FAILING_TEST_CASES))(
+ '$title',
+ async ({ context }) => {
+ const { data: exportedWhileOwned } = await exportApplication({
+ universalIdentifier: TEST_APP_UID,
+ });
+
+ expect(
+ exportedWhileOwned.exportApplication.application.universalIdentifier,
+ ).toBe(TEST_APP_UID);
+
+ await setTestRegistrationOwnerWorkspaceId(context.ownerWorkspaceId);
+
+ const { data, errors } = await exportApplication({
+ universalIdentifier: TEST_APP_UID,
+ expectToFail: true,
+ });
+
+ expect(data).toBeNull();
+ expectOneNotInternalServerErrorSnapshot({ errors, normalizeMessage });
+ },
+ 30000,
+ );
+});