The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix(messaging): default new channels to METADATA visibility instead of SHARE_EVERYTHING (#24135)
neo77364c62e862551
diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/create-calendar-channel.service.ts b/packages/twenty-server/src/engine/core-modules/auth/services/create-calendar-channel.service.tsindex c10a44c8422..8808c4b6e33 100644--- a/packages/twenty-server/src/engine/core-modules/auth/services/create-calendar-channel.service.ts+++ b/packages/twenty-server/src/engine/core-modules/auth/services/create-calendar-channel.service.ts@@ -49,8 +49,7 @@ export class CreateCalendarChannelService {id: newCalendarChannelId,connectedAccountId,handle,- visibility:- calendarVisibility || CalendarChannelVisibility.SHARE_EVERYTHING,+ visibility: calendarVisibility || CalendarChannelVisibility.METADATA,syncStatus: skipMessageChannelConfiguration? CalendarChannelSyncStatus.ONGOING: CalendarChannelSyncStatus.NOT_SYNCED,diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/create-message-channel.service.ts b/packages/twenty-server/src/engine/core-modules/auth/services/create-message-channel.service.tsindex 7eae3b41f46..4258d38d279 100644--- a/packages/twenty-server/src/engine/core-modules/auth/services/create-message-channel.service.ts+++ b/packages/twenty-server/src/engine/core-modules/auth/services/create-message-channel.service.ts@@ -54,8 +54,7 @@ export class CreateMessageChannelService {connectedAccountId,type: MessageChannelType.EMAIL,handle,- visibility:- messageVisibility || MessageChannelVisibility.SHARE_EVERYTHING,+ visibility: messageVisibility || MessageChannelVisibility.METADATA,syncStatus: skipMessageChannelConfiguration? MessageChannelSyncStatus.ONGOING: MessageChannelSyncStatus.NOT_SYNCED,diff --git a/packages/twenty-server/test/integration/metadata/suites/connected-account/successful-save-imap-smtp-caldav-account.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/connected-account/successful-save-imap-smtp-caldav-account.integration-spec.tsindex a00b6ce2366..d0a24277bb5 100644--- a/packages/twenty-server/test/integration/metadata/suites/connected-account/successful-save-imap-smtp-caldav-account.integration-spec.ts+++ b/packages/twenty-server/test/integration/metadata/suites/connected-account/successful-save-imap-smtp-caldav-account.integration-spec.ts@@ -1,6 +1,15 @@+import {+ CalendarChannelVisibility,+ MessageChannelVisibility,+} from 'twenty-shared/types';+import { deleteConnectedAccount } from 'test/integration/metadata/suites/connected-account/utils/delete-connected-account.util';import { getConnectedImapSmtpCaldavAccount } from 'test/integration/metadata/suites/connected-account/utils/get-connected-imap-smtp-caldav-account.util';import { saveImapSmtpCaldavAccount } from 'test/integration/metadata/suites/connected-account/utils/save-imap-smtp-caldav-account.util';+import {+ queryCalendarChannels,+ queryMessageChannels,+} from 'test/integration/utils/query-messaging.util';import { EmailConnectionSecurity } from 'src/engine/core-modules/imap-smtp-caldav-connection/enums/email-connection-security.enum';@@ -236,4 +245,43 @@ describe('Successful save IMAP/SMTP/CALDAV account', () => {CALDAV: null,});});++ it('should create message and calendar channels with METADATA visibility', async () => {+ const { data } = await saveImapSmtpCaldavAccount({+ expectToFail: false,+ input: {+ handle: '[email protected]',+ connectionParameters: {+ IMAP: {+ host: 'imap.fastmail.com',+ port: 993,+ username: '[email protected]',+ password: 'test-password',+ connectionSecurity: EmailConnectionSecurity.SSL_TLS,+ },+ CALDAV: {+ host: 'caldav.fastmail.com',+ port: 443,+ username: '[email protected]',+ password: 'test-password',+ connectionSecurity: EmailConnectionSecurity.SSL_TLS,+ },+ },+ },+ });++ accountIdsToCleanup.push(data.connectedAccountId);++ const messageChannel = (await queryMessageChannels()).find(+ (channel) => channel.connectedAccountId === data.connectedAccountId,+ );++ expect(messageChannel?.visibility).toBe(MessageChannelVisibility.METADATA);++ const [calendarChannel] = await queryCalendarChannels(+ data.connectedAccountId,+ );++ expect(calendarChannel.visibility).toBe(CalendarChannelVisibility.METADATA);+ });});diff --git a/packages/twenty-server/test/integration/utils/query-messaging.util.ts b/packages/twenty-server/test/integration/utils/query-messaging.util.tsindex 64d66bfa046..0cdcef8b0c7 100644--- a/packages/twenty-server/test/integration/utils/query-messaging.util.ts+++ b/packages/twenty-server/test/integration/utils/query-messaging.util.ts@@ -44,6 +44,7 @@ export type MessageChannelDto = Pick<| 'syncStageStartedAt'| 'throttleFailureCount'| 'throttleRetryAfter'+ | 'visibility'>;export type CalendarChannelDto = Pick<@@ -57,6 +58,7 @@ export type CalendarChannelDto = Pick<| 'throttleFailureCount'| 'isContactAutoCreationEnabled'| 'contactAutoCreationPolicy'+ | 'visibility'>;export type ConnectedAccountDto = Pick<@@ -86,6 +88,7 @@ const MESSAGE_CHANNEL_FIELDS = gql`syncStageStartedAtthrottleFailureCountthrottleRetryAfter+ visibility}`;@@ -169,6 +172,7 @@ export const queryCalendarChannels = async (throttleFailureCountisContactAutoCreationEnabledcontactAutoCreationPolicy+ visibility}}`,