The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Require the roles permission to pick a role when sending invitations (#27820)
Thomas Trompette6630473cd66a
diff --git a/packages/twenty-server/src/engine/core-modules/workspace-invitation/workspace-invitation.resolver.ts b/packages/twenty-server/src/engine/core-modules/workspace-invitation/workspace-invitation.resolver.tsindex 862b76327b2..afa3d4a9cb8 100644--- a/packages/twenty-server/src/engine/core-modules/workspace-invitation/workspace-invitation.resolver.ts+++ b/packages/twenty-server/src/engine/core-modules/workspace-invitation/workspace-invitation.resolver.ts@@ -1,22 +1,33 @@import { UseFilters, UseGuards, UsePipes } from '@nestjs/common';import { Args, Mutation, Query } from '@nestjs/graphql';+import { msg } from '@lingui/core/macro';import { PermissionFlagType } from 'twenty-shared/constants';+import { isDefined } from 'twenty-shared/utils';import { MetadataResolver } from 'src/engine/api/graphql/graphql-config/decorators/metadata-resolver.decorator';import { PreventNestToAutoLogGraphqlErrorsFilter } from 'src/engine/core-modules/graphql/filters/prevent-nest-to-auto-log-graphql-errors.filter';import { ResolverValidationPipe } from 'src/engine/core-modules/graphql/pipes/resolver-validation.pipe';+import { type FlatApplication } from 'src/engine/core-modules/application/types/flat-application.type';import { type AuthContextUser } from 'src/engine/core-modules/auth/types/auth-context.type';import { AuthGraphqlApiExceptionFilter } from 'src/engine/core-modules/auth/filters/auth-graphql-api-exception.filter';import { SendInvitationsDTO } from 'src/engine/core-modules/workspace-invitation/dtos/send-invitations.dto';import { WorkspaceInvitation } from 'src/engine/core-modules/workspace-invitation/dtos/workspace-invitation.dto';import { WorkspaceInvitationService } from 'src/engine/core-modules/workspace-invitation/services/workspace-invitation.service';import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';+import { AuthApplication } from 'src/engine/decorators/auth/auth-application.decorator';+import { AuthUserWorkspaceId } from 'src/engine/decorators/auth/auth-user-workspace-id.decorator';import { AuthUser } from 'src/engine/decorators/auth/auth-user.decorator';import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';import { AllowSuspendedWorkspace } from 'src/engine/decorators/auth/allow-suspended-workspace.decorator';import { SettingsPermissionGuard } from 'src/engine/guards/settings-permission.guard';import { AuthPrincipalGuard } from 'src/engine/guards/auth-principal.guard';+import {+ PermissionsException,+ PermissionsExceptionCode,+ PermissionsExceptionMessage,+} from 'src/engine/metadata-modules/permissions/permissions.exception';+import { PermissionsService } from 'src/engine/metadata-modules/permissions/permissions.service';import { PermissionsGraphqlApiExceptionFilter } from 'src/engine/metadata-modules/permissions/utils/permissions-graphql-api-exception.filter';import { WorkspaceOrmManager } from 'src/engine/twenty-orm/workspace-orm.manager';import { buildSystemAuthContext } from 'src/engine/twenty-orm/utils/build-system-auth-context.util';@@ -49,6 +60,7 @@ export class WorkspaceInvitationResolver {constructor(private readonly workspaceOrmManager: WorkspaceOrmManager,private readonly workspaceInvitationService: WorkspaceInvitationService,+ private readonly permissionsService: PermissionsService,) {}@Mutation(() => String)@@ -142,7 +154,30 @@ export class WorkspaceInvitationResolver {@Args() sendInviteLinkInput: SendInvitationsInput,@AuthUser() user: AuthContextUser,@AuthWorkspace() workspace: WorkspaceEntity,+ @AuthUserWorkspaceId() userWorkspaceId: string,+ @AuthApplication({ allowUndefined: true })+ application: FlatApplication | undefined,): Promise<SendInvitationsDTO> {+ if (isDefined(sendInviteLinkInput.roleId)) {+ const canAssignRoles =+ await this.permissionsService.userHasWorkspaceSettingPermission({+ userWorkspaceId,+ workspaceId: workspace.id,+ setting: PermissionFlagType.ROLES,+ applicationId: application?.id,+ });++ if (!canAssignRoles) {+ throw new PermissionsException(+ PermissionsExceptionMessage.PERMISSION_DENIED,+ PermissionsExceptionCode.PERMISSION_DENIED,+ {+ userFriendlyMessage: msg`You do not have permission to access this feature. Please contact your workspace administrator for access.`,+ },+ );+ }+ }+const authContext = buildSystemAuthContext(workspace.id);const workspaceMember =diff --git a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/workspace-invitation-role-assignment-permission.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/workspace-invitation-role-assignment-permission.integration-spec.tsnew file mode 100644index 00000000000..c0566ac2622--- /dev/null+++ b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/workspace-invitation-role-assignment-permission.integration-spec.ts@@ -0,0 +1,144 @@+import gql from 'graphql-tag';+import request from 'supertest';+import { deleteOneRoleOperationFactory } from 'test/integration/graphql/utils/delete-one-role-operation-factory.util';+import {+ deleteWorkspaceInvitationsByEmail,+ findWorkspaceInvitationsByEmail,+} from 'test/integration/graphql/utils/seed-workspace-invitation.util';+import { sendInvitationsOperationFactory } from 'test/integration/graphql/utils/send-invitations-operation-factory.util';+import { findOneRoleByLabel } from 'test/integration/metadata/suites/role/utils/find-one-role-by-label.util';+import { updateWorkspaceMemberRole } from 'test/integration/metadata/suites/role/utils/update-workspace-member-role.util';+import { makeMetadataApiRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';+import { PermissionFlagType } from 'twenty-shared/constants';++import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';+import { WORKSPACE_MEMBER_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/workspace-member-data-seeds.constant';++const client = request(`http://localhost:${APP_PORT}`);++describe('Workspace invitation role assignment permission', () => {+ let customRoleId: string;+ let adminRoleId: string;+ let originalMemberRoleId: string;+ const invitedEmails: string[] = [];++ const sendInvitationsAs = async ({+ token,+ roleId,+ }: {+ token: string;+ roleId?: string;+ }) => {+ const email = `invitation-role-${Date.now()}-${invitedEmails.length}@example.com`;++ invitedEmails.push(email);++ const response = await makeMetadataApiRequest(+ sendInvitationsOperationFactory({ emails: [email], roleId }),+ token,+ );++ return { email, response };+ };++ beforeAll(async () => {+ originalMemberRoleId = (await findOneRoleByLabel({ label: 'Member' })).id;+ adminRoleId = (await findOneRoleByLabel({ label: 'Admin' })).id;++ const createRoleResponse = await makeMetadataApiRequest({+ query: gql`+ mutation CreateOneRole {+ createOneRole(+ createRoleInput: {+ label: "Workspace Members Only Role"+ canUpdateAllSettings: false+ canReadAllObjectRecords: true+ canUpdateAllObjectRecords: true+ canSoftDeleteAllObjectRecords: false+ canDestroyAllObjectRecords: false+ }+ ) {+ id+ }+ }+ `,+ });++ customRoleId = createRoleResponse.body.data.createOneRole.id;++ await makeMetadataApiRequest({+ query: gql`+ mutation UpsertPermissionFlags {+ upsertPermissionFlags(+ upsertPermissionFlagsInput: {+ roleId: "${customRoleId}"+ permissionFlagKeys: ["${PermissionFlagType.WORKSPACE_MEMBERS}"]+ }+ ) {+ id+ }+ }+ `,+ });++ await updateWorkspaceMemberRole({+ input: {+ roleId: customRoleId,+ workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,+ },+ expectToFail: false,+ });+ });++ afterAll(async () => {+ await updateWorkspaceMemberRole({+ input: {+ roleId: originalMemberRoleId,+ workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,+ },+ expectToFail: false,+ });++ for (const email of invitedEmails) {+ await deleteWorkspaceInvitationsByEmail({ email });+ }++ await client+ .post('/metadata')+ .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)+ .send(deleteOneRoleOperationFactory(customRoleId));+ });++ it('denies inviting with the Admin role when the caller lacks ROLES permission', async () => {+ const { email, response } = await sendInvitationsAs({+ token: APPLE_JONY_MEMBER_ACCESS_TOKEN,+ roleId: adminRoleId,+ });++ expect(response.body.data?.sendInvitations ?? null).toBeNull();+ expect(response.body.errors).toBeDefined();+ expect(response.body.errors[0].extensions.code).toBe(ErrorCode.FORBIDDEN);+ expect(await findWorkspaceInvitationsByEmail({ email })).toHaveLength(0);+ });++ it('allows inviting without a role when the caller only has WORKSPACE_MEMBERS permission', async () => {+ const { email, response } = await sendInvitationsAs({+ token: APPLE_JONY_MEMBER_ACCESS_TOKEN,+ });++ expect(response.body.errors).toBeUndefined();+ expect(response.body.data.sendInvitations.success).toBe(true);+ expect(await findWorkspaceInvitationsByEmail({ email })).toHaveLength(1);+ });++ it('allows inviting with a role when the caller has ROLES permission', async () => {+ const { email, response } = await sendInvitationsAs({+ token: APPLE_JANE_ADMIN_ACCESS_TOKEN,+ roleId: adminRoleId,+ });++ expect(response.body.errors).toBeUndefined();+ expect(response.body.data.sendInvitations.success).toBe(true);+ expect(await findWorkspaceInvitationsByEmail({ email })).toHaveLength(1);+ });+});