The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Deprecate IS_RECORD_TABLE_WIDGET_ENABLED feature flag (#19662)
Félix Malfait69d228d8a157
diff --git a/.github/workflows/ci-zapier.yaml b/.github/workflows/ci-zapier.yamlindex 38a785adcb8..937a3d401cc 100644--- a/.github/workflows/ci-zapier.yaml+++ b/.github/workflows/ci-zapier.yaml@@ -69,13 +69,14 @@ jobs:- name: Server / Startrun: |- npx nx start twenty-server &+ npx nx run twenty-server:start:ci &echo "Waiting for server to be ready..."- timeout 60 bash -c 'until curl -s http://localhost:3000/health; do sleep 2; done'+ timeout 60 bash -c 'until curl -sf http://localhost:3000/healthz; do sleep 2; done'- name: Start worker+ working-directory: packages/twenty-serverrun: |- npx nx run twenty-server:worker &+ NODE_ENV=development node dist/queue-worker/queue-worker.js &echo "Worker started"- name: Zapier / Builddiff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql b/packages/twenty-client-sdk/src/metadata/generated/schema.graphqlindex 0dd22ae576c..82b1f6fbab9 100644--- a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql@@ -1592,7 +1592,6 @@ enum FeatureFlagKey {IS_CONNECTED_ACCOUNT_MIGRATEDIS_RICH_TEXT_V1_MIGRATEDIS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED- IS_RECORD_TABLE_WIDGET_ENABLEDIS_DATASOURCE_MIGRATED}diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.ts b/packages/twenty-client-sdk/src/metadata/generated/schema.tsindex 407f11718cd..0d3f7d1a140 100644--- a/packages/twenty-client-sdk/src/metadata/generated/schema.ts+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.ts@@ -1289,7 +1289,7 @@ export interface FeatureFlag {__typename: 'FeatureFlag'}-export type FeatureFlagKey = 'IS_UNIQUE_INDEXES_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_AI_ENABLED' | 'IS_COMMAND_MENU_ITEM_ENABLED' | 'IS_MARKETPLACE_SETTING_TAB_VISIBLE' | 'IS_RECORD_PAGE_LAYOUT_EDITING_ENABLED' | 'IS_PUBLIC_DOMAIN_ENABLED' | 'IS_EMAILING_DOMAIN_ENABLED' | 'IS_JUNCTION_RELATIONS_ENABLED' | 'IS_DRAFT_EMAIL_ENABLED' | 'IS_CONNECTED_ACCOUNT_MIGRATED' | 'IS_RICH_TEXT_V1_MIGRATED' | 'IS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED' | 'IS_RECORD_TABLE_WIDGET_ENABLED' | 'IS_DATASOURCE_MIGRATED'+export type FeatureFlagKey = 'IS_UNIQUE_INDEXES_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_AI_ENABLED' | 'IS_COMMAND_MENU_ITEM_ENABLED' | 'IS_MARKETPLACE_SETTING_TAB_VISIBLE' | 'IS_RECORD_PAGE_LAYOUT_EDITING_ENABLED' | 'IS_PUBLIC_DOMAIN_ENABLED' | 'IS_EMAILING_DOMAIN_ENABLED' | 'IS_JUNCTION_RELATIONS_ENABLED' | 'IS_DRAFT_EMAIL_ENABLED' | 'IS_CONNECTED_ACCOUNT_MIGRATED' | 'IS_RICH_TEXT_V1_MIGRATED' | 'IS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED' | 'IS_DATASOURCE_MIGRATED'export interface WorkspaceUrls {customUrl?: Scalars['String']@@ -9470,7 +9470,6 @@ export const enumFeatureFlagKey = {IS_CONNECTED_ACCOUNT_MIGRATED: 'IS_CONNECTED_ACCOUNT_MIGRATED' as const,IS_RICH_TEXT_V1_MIGRATED: 'IS_RICH_TEXT_V1_MIGRATED' as const,IS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED: 'IS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED' as const,- IS_RECORD_TABLE_WIDGET_ENABLED: 'IS_RECORD_TABLE_WIDGET_ENABLED' as const,IS_DATASOURCE_MIGRATED: 'IS_DATASOURCE_MIGRATED' as const}diff --git a/packages/twenty-front/src/generated-metadata/graphql.ts b/packages/twenty-front/src/generated-metadata/graphql.tsindex 79036d7b2b9..b25f59d7d08 100644--- a/packages/twenty-front/src/generated-metadata/graphql.ts+++ b/packages/twenty-front/src/generated-metadata/graphql.ts@@ -1823,7 +1823,6 @@ export enum FeatureFlagKey {IS_PUBLIC_DOMAIN_ENABLED = 'IS_PUBLIC_DOMAIN_ENABLED',IS_RECORD_PAGE_LAYOUT_EDITING_ENABLED = 'IS_RECORD_PAGE_LAYOUT_EDITING_ENABLED',IS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED = 'IS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED',- IS_RECORD_TABLE_WIDGET_ENABLED = 'IS_RECORD_TABLE_WIDGET_ENABLED',IS_RICH_TEXT_V1_MIGRATED = 'IS_RICH_TEXT_V1_MIGRATED',IS_UNIQUE_INDEXES_ENABLED = 'IS_UNIQUE_INDEXES_ENABLED'}diff --git a/packages/twenty-front/src/modules/side-panel/pages/page-layout/components/SidePanelPageLayoutDashboardWidgetTypeSelect.tsx b/packages/twenty-front/src/modules/side-panel/pages/page-layout/components/SidePanelPageLayoutDashboardWidgetTypeSelect.tsxindex 34acb3e3312..de63a224910 100644--- a/packages/twenty-front/src/modules/side-panel/pages/page-layout/components/SidePanelPageLayoutDashboardWidgetTypeSelect.tsx+++ b/packages/twenty-front/src/modules/side-panel/pages/page-layout/components/SidePanelPageLayoutDashboardWidgetTypeSelect.tsx@@ -22,7 +22,6 @@ import { isExistingWidgetMissingOrDifferentType } from '@/side-panel/pages/page-import { SelectableListItem } from '@/ui/layout/selectable-list/components/SelectableListItem';import { useAtomComponentState } from '@/ui/utilities/state/jotai/hooks/useAtomComponentState';import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';-import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';import { useQuery } from '@apollo/client/react';import { t } from '@lingui/core/macro';import { CoreObjectNameSingular, SidePanelPages } from 'twenty-shared/types';@@ -34,11 +33,7 @@ import {IconFrame,IconTable,} from 'twenty-ui/display';-import {- FeatureFlagKey,- type FrontComponent,- WidgetType,-} from '~/generated-metadata/graphql';+import { type FrontComponent, WidgetType } from '~/generated-metadata/graphql';export const SidePanelPageLayoutDashboardWidgetTypeSelect = () => {const { pageLayoutId, recordId } = usePageLayoutIdFromContextStore();@@ -101,10 +96,6 @@ export const SidePanelPageLayoutDashboardWidgetTypeSelect = () => {first.labelPlural.localeCompare(second.labelPlural),)[0];- const isRecordTableWidgetEnabled = useIsFeatureEnabled(- FeatureFlagKey.IS_RECORD_TABLE_WIDGET_ENABLED,- );-const { data: frontComponentsData } = useQuery<{frontComponents: FrontComponent[];}>(FIND_MANY_FRONT_COMPONENTS);@@ -246,7 +237,7 @@ export const SidePanelPageLayoutDashboardWidgetTypeSelect = () => {const selectableItemIds = ['chart',- ...(isRecordTableWidgetEnabled ? ['record-table'] : []),+ 'record-table','iframe','rich-text',...frontComponentsWithSelectItemId.map(({ selectItemId }) => selectItemId),@@ -266,19 +257,17 @@ export const SidePanelPageLayoutDashboardWidgetTypeSelect = () => {onClick={handleNavigateToGraphTypeSelect}/></SelectableListItem>- {isRecordTableWidgetEnabled && (- <SelectableListItem- itemId="record-table"- onEnter={handleNavigateToRecordTableSettings}- >- <CommandMenuItem- Icon={IconTable}- label={t`View`}- id="record-table"- onClick={handleNavigateToRecordTableSettings}- />- </SelectableListItem>- )}+ <SelectableListItem+ itemId="record-table"+ onEnter={handleNavigateToRecordTableSettings}+ >+ <CommandMenuItem+ Icon={IconTable}+ label={t`View`}+ id="record-table"+ onClick={handleNavigateToRecordTableSettings}+ />+ </SelectableListItem><SelectableListItemitemId="iframe"onEnter={handleNavigateToIframeSettings}diff --git a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.tsindex c5ce5d4ae10..4f671bded79 100644--- a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts+++ b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts@@ -242,7 +242,6 @@ describe('WorkspaceEntityManager', () => {IS_CONNECTED_ACCOUNT_MIGRATED: false,IS_RICH_TEXT_V1_MIGRATED: false,IS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED: false,- IS_RECORD_TABLE_WIDGET_ENABLED: false,IS_DATASOURCE_MIGRATED: false,IS_COMMAND_MENU_ITEM_ENABLED: false,},diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.tsindex b842a2f2386..77e672b8be6 100644--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts@@ -60,11 +60,6 @@ export const seedFeatureFlags = async ({workspaceId: workspaceId,value: true,},- {- key: FeatureFlagKey.IS_RECORD_TABLE_WIDGET_ENABLED,- workspaceId: workspaceId,- value: true,- },]).execute();};diff --git a/packages/twenty-shared/src/types/FeatureFlagKey.ts b/packages/twenty-shared/src/types/FeatureFlagKey.tsindex 19959e0d8fc..3d82a5c6fdd 100644--- a/packages/twenty-shared/src/types/FeatureFlagKey.ts+++ b/packages/twenty-shared/src/types/FeatureFlagKey.ts@@ -12,7 +12,6 @@ export enum FeatureFlagKey {IS_CONNECTED_ACCOUNT_MIGRATED = 'IS_CONNECTED_ACCOUNT_MIGRATED',IS_RICH_TEXT_V1_MIGRATED = 'IS_RICH_TEXT_V1_MIGRATED',IS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED = 'IS_RECORD_PAGE_LAYOUT_GLOBAL_EDITION_ENABLED',- IS_RECORD_TABLE_WIDGET_ENABLED = 'IS_RECORD_TABLE_WIDGET_ENABLED',// @deprecated - Migration is complete. Kept for backward compatibility// until all workspaces have the flag and the flag can be removed entirely.IS_DATASOURCE_MIGRATED = 'IS_DATASOURCE_MIGRATED',