Skip to content

The open alternative to Salesforce, designed for AI.

Remove dead front code and duplicate tests (#27428)

Félix Malfait7b24e07403df
diff --git a/packages/twenty-front/codegen-metadata.cjs b/packages/twenty-front/codegen-metadata.cjs
index acca989fedd..1369078c0c1 100644
--- a/packages/twenty-front/codegen-metadata.cjs
+++ b/packages/twenty-front/codegen-metadata.cjs
@@ -25,13 +25,11 @@ module.exports = {
'!./src/modules/settings/legal/**/graphql/**/*.{ts,tsx}',
'./src/modules/logic-functions/graphql/**/*.{ts,tsx}',
- './src/modules/databases/graphql/**/*.{ts,tsx}',
'./src/modules/analytics/graphql/**/*.{ts,tsx}',
'./src/modules/object-metadata/graphql/**/*.{ts,tsx}',
'./src/modules/validation-rules/graphql/**/*.{ts,tsx}',
'./src/modules/navigation-menu-item/**/graphql/**/*.{ts,tsx}',
'./src/modules/command-menu-item/graphql/**/*.{ts,tsx}',
- './src/modules/attachments/graphql/**/*.{ts,tsx}',
'./src/modules/file/graphql/**/*.{ts,tsx}',
'./src/modules/onboarding/graphql/**/*.{ts,tsx}',
'./src/modules/front-components/graphql/**/*.{ts,tsx}',
diff --git a/packages/twenty-front/codegen.cjs b/packages/twenty-front/codegen.cjs
index 342b4664fbc..f1070bb5bb5 100644
--- a/packages/twenty-front/codegen.cjs
+++ b/packages/twenty-front/codegen.cjs
@@ -10,7 +10,6 @@ module.exports = {
'./src/modules/activities/emails/graphql/queries/**/*.{ts,tsx}',
'./src/modules/activities/emails/graphql/operation-signatures/**/*.{ts,tsx}',
'./src/modules/activities/calendar/graphql/queries/**/*.{ts,tsx}',
- './src/modules/search/graphql/**/*.{ts,tsx}',
'./src/modules/command-menu/graphql/**/*.{ts,tsx}',
'./src/modules/ai/graphql/mutations/answerToolCall.ts',
diff --git a/packages/twenty-front/src/modules/navigation-menu-item/common/utils/__tests__/validateAndExtractWorkspaceFolderId.test.ts b/packages/twenty-front/src/modules/navigation-menu-item/common/utils/__tests__/validateAndExtractWorkspaceFolderId.test.ts
deleted file mode 100644
index 1b330d3cb88..00000000000
--- a/packages/twenty-front/src/modules/navigation-menu-item/common/utils/__tests__/validateAndExtractWorkspaceFolderId.test.ts
+++ /dev/null
@@ -1,54 +0,0 @@
-import {
- matchesWorkspaceFolderId,
- validateAndExtractWorkspaceFolderId,
-} from '@/navigation-menu-item/common/utils/validateAndExtractWorkspaceFolderId';
-import { type NavigationMenuItem } from '~/generated-metadata/graphql';
-
-describe('matchesWorkspaceFolderId', () => {
- it('should return true when folderId and item folder match (including null for orphan)', () => {
- expect(
- matchesWorkspaceFolderId({ folderId: null } as NavigationMenuItem, null),
- ).toBe(true);
- expect(matchesWorkspaceFolderId({} as NavigationMenuItem, null)).toBe(true);
- expect(
- matchesWorkspaceFolderId({ folderId: 'f1' } as NavigationMenuItem, 'f1'),
- ).toBe(true);
- });
-
- it('should return false when folderId and item folder do not match', () => {
- expect(
- matchesWorkspaceFolderId({ folderId: 'f1' } as NavigationMenuItem, null),
- ).toBe(false);
- expect(
- matchesWorkspaceFolderId({ folderId: 'f1' } as NavigationMenuItem, 'f2'),
- ).toBe(false);
- });
-});
-
-describe('validateAndExtractWorkspaceFolderId', () => {
- it('should return null for orphan and extract folder id from header or folder prefix', () => {
- expect(
- validateAndExtractWorkspaceFolderId(
- 'workspace-orphan-navigation-menu-items',
- ),
- ).toBe(null);
- expect(
- validateAndExtractWorkspaceFolderId('workspace-folder-header-folder-123'),
- ).toBe('folder-123');
- expect(
- validateAndExtractWorkspaceFolderId('workspace-folder-folder-456'),
- ).toBe('folder-456');
- });
-
- it('should throw for invalid or empty folder id after prefix', () => {
- expect(() =>
- validateAndExtractWorkspaceFolderId('workspace-folder-header-'),
- ).toThrow('Invalid workspace folder header ID');
- expect(() =>
- validateAndExtractWorkspaceFolderId('workspace-folder-'),
- ).toThrow('Invalid workspace folder ID');
- expect(() =>
- validateAndExtractWorkspaceFolderId('invalid-droppable-id'),
- ).toThrow('Invalid workspace droppable ID format');
- });
-});
diff --git a/packages/twenty-front/src/modules/navigation-menu-item/common/utils/validateAndExtractWorkspaceFolderId.ts b/packages/twenty-front/src/modules/navigation-menu-item/common/utils/validateAndExtractWorkspaceFolderId.ts
deleted file mode 100644
index aa064466650..00000000000
--- a/packages/twenty-front/src/modules/navigation-menu-item/common/utils/validateAndExtractWorkspaceFolderId.ts
+++ /dev/null
@@ -1,62 +0,0 @@
-import { isNonEmptyString } from '@sniptt/guards';
-import { CustomError, isDefined } from 'twenty-shared/utils';
-import { type NavigationMenuItem } from '~/generated-metadata/graphql';
-
-import { NavigationMenuItemDroppableIds } from '@/navigation-menu-item/common/constants/NavigationMenuItemDroppableIds';
-
-export const matchesWorkspaceFolderId = (
- item: NavigationMenuItem,
- folderId: string | null,
-): boolean =>
- (folderId === null && !isDefined(item.folderId)) ||
- (isDefined(folderId) && item.folderId === folderId);
-
-export const validateAndExtractWorkspaceFolderId = (
- droppableId: string,
-): string | null => {
- if (
- droppableId ===
- NavigationMenuItemDroppableIds.WORKSPACE_ORPHAN_NAVIGATION_MENU_ITEMS
- ) {
- return null;
- }
-
- if (
- droppableId.startsWith(
- NavigationMenuItemDroppableIds.WORKSPACE_FOLDER_HEADER_PREFIX,
- )
- ) {
- const folderId = droppableId.replace(
- NavigationMenuItemDroppableIds.WORKSPACE_FOLDER_HEADER_PREFIX,
- '',
- );
- if (!isNonEmptyString(folderId))
- throw new CustomError(
- `Invalid workspace folder header ID: ${droppableId}`,
- 'INVALID_WORKSPACE_FOLDER_HEADER_ID',
- );
- return folderId;
- }
-
- if (
- droppableId.startsWith(
- NavigationMenuItemDroppableIds.WORKSPACE_FOLDER_PREFIX,
- )
- ) {
- const folderId = droppableId.replace(
- NavigationMenuItemDroppableIds.WORKSPACE_FOLDER_PREFIX,
- '',
- );
- if (!isNonEmptyString(folderId))
- throw new CustomError(
- `Invalid workspace folder ID: ${droppableId}`,
- 'INVALID_WORKSPACE_FOLDER_ID',
- );
- return folderId;
- }
-
- throw new CustomError(
- `Invalid workspace droppable ID format: ${droppableId}`,
- 'INVALID_WORKSPACE_DROPPABLE_ID_FORMAT',
- );
-};
diff --git a/packages/twenty-front/src/modules/object-core/utils/__tests__/doesObjectRecordOperationTargetRecordId.test.ts b/packages/twenty-front/src/modules/object-core/utils/__tests__/doesObjectRecordOperationTargetRecordId.test.ts
deleted file mode 100644
index f186a9fcff6..00000000000
--- a/packages/twenty-front/src/modules/object-core/utils/__tests__/doesObjectRecordOperationTargetRecordId.test.ts
+++ /dev/null
@@ -1,72 +0,0 @@
-import { doesObjectRecordOperationTargetRecordId } from '@/object-core/utils/doesObjectRecordOperationTargetRecordId';
-import { type ObjectRecord } from 'twenty-shared/types';
-
-const RECORD_ID = 'e4d1a2f0-1111-4a2b-9c3d-000000000001';
-const OTHER_RECORD_ID = 'e4d1a2f0-2222-4a2b-9c3d-000000000002';
-
-const buildRecord = (id: string) => ({ id }) as ObjectRecord;
-
-describe('doesObjectRecordOperationTargetRecordId', () => {
- it('matches a delete-one on the same record', () => {
- expect(
- doesObjectRecordOperationTargetRecordId({
- operation: { type: 'delete-one', deletedRecordId: RECORD_ID },
- recordId: RECORD_ID,
- }),
- ).toBe(true);
- });
-
- it('ignores a delete-one on another record', () => {
- expect(
- doesObjectRecordOperationTargetRecordId({
- operation: { type: 'delete-one', deletedRecordId: OTHER_RECORD_ID },
- recordId: RECORD_ID,
- }),
- ).toBe(false);
- });
-
- it('matches a delete-many containing the record', () => {
- expect(
- doesObjectRecordOperationTargetRecordId({
- operation: {
- type: 'delete-many',
- deletedRecordIds: [OTHER_RECORD_ID, RECORD_ID],
- },
- recordId: RECORD_ID,
- }),
- ).toBe(true);
- });
-
- it('matches a restore-one on the same record', () => {
- expect(
- doesObjectRecordOperationTargetRecordId({
- operation: {
- type: 'restore-one',
- restoredRecord: buildRecord(RECORD_ID),
- },
- recordId: RECORD_ID,
- }),
- ).toBe(true);
- });
-
- it('matches a restore-many containing the record', () => {
- expect(
- doesObjectRecordOperationTargetRecordId({
- operation: {
- type: 'restore-many',
- restoredRecords: [buildRecord(RECORD_ID)],
- },
- recordId: RECORD_ID,
- }),
- ).toBe(true);
- });
-
- it('ignores operations that carry no record lifecycle change', () => {
- expect(
- doesObjectRecordOperationTargetRecordId({
- operation: { type: 'destroy-one' },
- recordId: RECORD_ID,
- }),
- ).toBe(false);
- });
-});
diff --git a/packages/twenty-front/src/modules/object-core/utils/__tests__/getDeletedRecordIdsFromOperation.test.ts b/packages/twenty-front/src/modules/object-core/utils/__tests__/getDeletedRecordIdsFromOperation.test.ts
deleted file mode 100644
index f5331f181b8..00000000000
--- a/packages/twenty-front/src/modules/object-core/utils/__tests__/getDeletedRecordIdsFromOperation.test.ts
+++ /dev/null
@@ -1,27 +0,0 @@
-import { getDeletedRecordIdsFromOperation } from '@/object-core/utils/getDeletedRecordIdsFromOperation';
-
-describe('getDeletedRecordIdsFromOperation', () => {
- it('should read the ids of a bulk deletion', () => {
- expect(
- getDeletedRecordIdsFromOperation({
- type: 'delete-many',
- deletedRecordIds: ['workspace-1', 'workspace-2'],
- }),
- ).toEqual(['workspace-1', 'workspace-2']);
- });
-
- it('should read the id of a single deletion', () => {
- expect(
- getDeletedRecordIdsFromOperation({
- type: 'delete-one',
- deletedRecordId: 'workspace-1',
- }),
- ).toEqual(['workspace-1']);
- });
-
- it('should return nothing for an operation that carries no deleted ids', () => {
- expect(getDeletedRecordIdsFromOperation({ type: 'destroy-one' })).toEqual(
- [],
- );
- });
-});
diff --git a/packages/twenty-front/src/modules/object-core/utils/__tests__/isCoreRecordAbsent.test.ts b/packages/twenty-front/src/modules/object-core/utils/__tests__/isCoreRecordAbsent.test.ts
deleted file mode 100644
index 7ac10f956d0..00000000000
--- a/packages/twenty-front/src/modules/object-core/utils/__tests__/isCoreRecordAbsent.test.ts
+++ /dev/null
@@ -1,44 +0,0 @@
-import { type ErrorLike } from '@apollo/client';
-
-import { type ObjectRecord } from '@/object-record/types/ObjectRecord';
-import { isCoreRecordAbsent } from '@/object-core/utils/isCoreRecordAbsent';
-
-const RECORD = { __typename: 'Workflow', id: 'core-id' } as ObjectRecord;
-
-describe('isCoreRecordAbsent', () => {
- it('is true once the query settled without a row', () => {
- expect(
- isCoreRecordAbsent({
- record: undefined,
- loading: false,
- error: undefined,
- }),
- ).toBe(true);
- });
-
- it('is false while the query is still loading', () => {
- expect(
- isCoreRecordAbsent({
- record: undefined,
- loading: true,
- error: undefined,
- }),
- ).toBe(false);
- });
-
- it('is false when the query failed, so an outage is not read as a missing row', () => {
- expect(
- isCoreRecordAbsent({
- record: undefined,
- loading: false,
- error: new Error('core unavailable') as ErrorLike,
- }),
- ).toBe(false);
- });
-
- it('is false when core returned a row', () => {
- expect(
- isCoreRecordAbsent({ record: RECORD, loading: false, error: undefined }),
- ).toBe(false);
- });
-});
diff --git a/packages/twenty-front/src/modules/object-core/utils/doesObjectRecordOperationTargetRecordId.ts b/packages/twenty-front/src/modules/object-core/utils/doesObjectRecordOperationTargetRecordId.ts
deleted file mode 100644
index 35a63043047..00000000000
--- a/packages/twenty-front/src/modules/object-core/utils/doesObjectRecordOperationTargetRecordId.ts
+++ /dev/null
@@ -1,24 +0,0 @@
-import { type ObjectRecordOperation } from '@/object-record/types/ObjectRecordOperation';
-
-export const doesObjectRecordOperationTargetRecordId = ({
- operation,
- recordId,
-}: {
- operation: ObjectRecordOperation;
- recordId: string;
-}): boolean => {
- switch (operation.type) {
- case 'delete-one':
- return operation.deletedRecordId === recordId;
- case 'delete-many':
- return operation.deletedRecordIds.includes(recordId);
- case 'restore-one':
- return operation.restoredRecord.id === recordId;
- case 'restore-many':
- return operation.restoredRecords.some(
- (restoredRecord) => restoredRecord.id === recordId,
- );
- default:
- return false;
- }
-};
diff --git a/packages/twenty-front/src/modules/object-core/utils/getDeletedRecordIdsFromOperation.ts b/packages/twenty-front/src/modules/object-core/utils/getDeletedRecordIdsFromOperation.ts
deleted file mode 100644
index 2b77b58e737..00000000000
--- a/packages/twenty-front/src/modules/object-core/utils/getDeletedRecordIdsFromOperation.ts
+++ /dev/null
@@ -1,15 +0,0 @@
-import { type ObjectRecordOperation } from '@/object-record/types/ObjectRecordOperation';
-
-export const getDeletedRecordIdsFromOperation = (
- operation: ObjectRecordOperation,
-): string[] => {
- if (operation.type === 'delete-many') {
- return operation.deletedRecordIds;
- }
-
- if (operation.type === 'delete-one') {
- return [operation.deletedRecordId];
- }
-
- return [];
-};
diff --git a/packages/twenty-front/src/modules/object-core/utils/isCoreRecordAbsent.ts b/packages/twenty-front/src/modules/object-core/utils/isCoreRecordAbsent.ts
deleted file mode 100644
index b181b8fcdc0..00000000000
--- a/packages/twenty-front/src/modules/object-core/utils/isCoreRecordAbsent.ts
+++ /dev/null
@@ -1,14 +0,0 @@
-import { type ErrorLike } from '@apollo/client';
-import { isDefined } from 'twenty-shared/utils';
-
-import { type ObjectRecord } from '@/object-record/types/ObjectRecord';
-
-export const isCoreRecordAbsent = ({
- record,
- loading,
- error,
-}: {
- record: ObjectRecord | undefined;
- loading: boolean;
- error: ErrorLike | undefined;
-}) => !loading && !isDefined(error) && !isDefined(record);
diff --git a/packages/twenty-front/src/modules/object-metadata/utils/__tests__/mapFieldMetadataToGraphQLQuery.test.ts b/packages/twenty-front/src/modules/object-metadata/utils/__tests__/mapFieldMetadataToGraphQLQuery.test.ts
index 7886e6f0099..4ff84c75902 100644
--- a/packages/twenty-front/src/modules/object-metadata/utils/__tests__/mapFieldMetadataToGraphQLQuery.test.ts
+++ b/packages/twenty-front/src/modules/object-metadata/utils/__tests__/mapFieldMetadataToGraphQLQuery.test.ts
@@ -1,6 +1,6 @@
import { mapFieldMetadataToGraphQLQuery } from '@/object-metadata/utils/mapFieldMetadataToGraphQLQuery';
import { getTestEnrichedObjectMetadataItemsMock } from '~/testing/utils/getTestEnrichedObjectMetadataItemsMock';
-import { normalizeGQLField } from '~/utils/normalizeGQLField';
+import { normalizeGQLField } from '~/testing/utils/normalizeGQLField';
const personObjectMetadataItem = getTestEnrichedObjectMetadataItemsMock().find(
(item) => item.nameSingular === 'person',
diff --git a/packages/twenty-front/src/modules/object-metadata/utils/__tests__/mapObjectMetadataToGraphQLQuery.test.ts b/packages/twenty-front/src/modules/object-metadata/utils/__tests__/mapObjectMetadataToGraphQLQuery.test.ts
index a7d106ffb71..766fe056259 100644
--- a/packages/twenty-front/src/modules/object-metadata/utils/__tests__/mapObjectMetadataToGraphQLQuery.test.ts
+++ b/packages/twenty-front/src/modules/object-metadata/utils/__tests__/mapObjectMetadataToGraphQLQuery.test.ts
@@ -1,6 +1,6 @@
import { mapObjectMetadataToGraphQLQuery } from '@/object-metadata/utils/mapObjectMetadataToGraphQLQuery';
import { getTestEnrichedObjectMetadataItemsMock } from '~/testing/utils/getTestEnrichedObjectMetadataItemsMock';
-import { normalizeGQLQuery } from '~/utils/normalizeGQLQuery';
+import { normalizeGQLQuery } from '~/testing/utils/normalizeGQLQuery';
const personObjectMetadataItem = getTestEnrichedObjectMetadataItemsMock().find(
(item) => item.nameSingular === 'person',
diff --git a/packages/twenty-front/src/modules/object-record/record-index/export/hooks/__tests__/useRecordIndexLazyFetchRecords.test.ts b/packages/twenty-front/src/modules/object-record/record-index/export/hooks/__tests__/useRecordIndexLazyFetchRecords.test.ts
index c292915f1d1..a2d345f14d0 100644
--- a/packages/twenty-front/src/modules/object-record/record-index/export/hooks/__tests__/useRecordIndexLazyFetchRecords.test.ts
+++ b/packages/twenty-front/src/modules/object-record/record-index/export/hooks/__tests__/useRecordIndexLazyFetchRecords.test.ts
@@ -1,10 +1,6 @@
import { renderHook, waitFor } from '@testing-library/react';
import { act } from 'react';
-import {
- percentage,
- sleep,
- useRecordIndexLazyFetchRecords,
-} from '@/object-record/record-index/export/hooks/useRecordIndexLazyFetchRecords';
+import { useRecordIndexLazyFetchRecords } from '@/object-record/record-index/export/hooks/useRecordIndexLazyFetchRecords';
import { useLazyFetchAllRecords } from '@/object-record/hooks/useLazyFetchAllRecords';
import { ViewType } from '@/views/types/ViewType';
@@ -154,18 +150,4 @@ describe('useRecordData', () => {
});
});
});
-
- describe('utils', () => {
- it('should correctly calculate percentage', () => {
- expect(percentage(50, 200)).toBe(25);
- expect(percentage(1, 3)).toBe(33);
- });
-
- it('should resolve sleep after given time', async () => {
- jest.useFakeTimers();
- const sleepPromise = sleep(1000);
- jest.advanceTimersByTime(1000);
- await expect(sleepPromise).resolves.toBeUndefined();
- });
- });
});
diff --git a/packages/twenty-front/src/modules/object-record/record-index/export/hooks/useRecordIndexLazyFetchRecords.ts b/packages/twenty-front/src/modules/object-record/record-index/export/hooks/useRecordIndexLazyFetchRecords.ts
index ee2c08f0f0a..55c70ffad42 100644
--- a/packages/twenty-front/src/modules/object-record/record-index/export/hooks/useRecordIndexLazyFetchRecords.ts
+++ b/packages/twenty-front/src/modules/object-record/record-index/export/hooks/useRecordIndexLazyFetchRecords.ts
@@ -23,13 +23,6 @@ import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomState
import { ViewType } from '@/views/types/ViewType';
import { isDefined } from 'twenty-shared/utils';
-export const sleep = (ms: number) =>
- new Promise((resolve) => setTimeout(resolve, ms));
-
-export const percentage = (part: number, whole: number): number => {
- return Math.round((part / whole) * 100);
-};
-
export type UseRecordDataOptions = {
delayMs: number;
maximumRequests?: number;
diff --git a/packages/twenty-front/src/modules/views/utils/__tests__/viewMapFunctions.test.ts b/packages/twenty-front/src/modules/views/utils/__tests__/viewMapFunctions.test.ts
index fde0083b11a..4d2a12716f2 100644
--- a/packages/twenty-front/src/modules/views/utils/__tests__/viewMapFunctions.test.ts
+++ b/packages/twenty-front/src/modules/views/utils/__tests__/viewMapFunctions.test.ts
@@ -3,7 +3,6 @@ import { type RecordFilter } from '@/object-record/record-filter/types/RecordFil
import { type ColumnDefinition } from '@/object-record/record-table/types/ColumnDefinition';
import { type ViewField } from '@/views/types/ViewField';
import { type ViewFilter } from '@/views/types/ViewFilter';
-import { mapColumnDefinitionsToViewFields } from '@/views/utils/mapColumnDefinitionToViewField';
import { mapViewFieldsToColumnDefinitions } from '@/views/utils/mapViewFieldsToColumnDefinitions';
import { mapViewFiltersToFilters } from '@/views/utils/mapViewFiltersToFilters';
import { ViewFilterOperand } from 'twenty-shared/types';
@@ -169,49 +168,3 @@ describe('mapViewFieldsToColumnDefinitions', () => {
expect(actualColumnDefinitions).toEqual(expectedColumnDefinitions);
});
});
-
-describe('mapColumnDefinitionsToViewFields', () => {
- it('should map ColumnDefinitions to ViewFields, setting defaults and using viewFieldId if present', () => {
- const columnDefinitions = [
- {
- fieldMetadataId: 1,
- position: 1,
- isVisible: true,
- viewFieldId: 'custom-id-1',
- },
- {
- fieldMetadataId: 2,
- position: 2,
- size: 200,
- isVisible: false,
- },
- ];
-
- const expectedViewFields = [
- {
- id: 'custom-id-1',
- fieldMetadataId: 1,
- position: 1,
- isVisible: true,
- isActive: true,
- definition: columnDefinitions[0],
- size: undefined,
- },
- {
- id: '',
- fieldMetadataId: 2,
- position: 2,
- size: 200,
- isVisible: false,
- isActive: true,
- definition: columnDefinitions[1],
- },
- ];
-
- const actualViewFields = mapColumnDefinitionsToViewFields(
- columnDefinitions as unknown as ColumnDefinition<FieldMetadata>[],
- );
-
- expect(actualViewFields).toEqual(expectedViewFields);
- });
-});
diff --git a/packages/twenty-front/src/modules/views/utils/mapColumnDefinitionToViewField.ts b/packages/twenty-front/src/modules/views/utils/mapColumnDefinitionToViewField.ts
deleted file mode 100644
index 1a4080dd75c..00000000000
--- a/packages/twenty-front/src/modules/views/utils/mapColumnDefinitionToViewField.ts
+++ /dev/null
@@ -1,18 +0,0 @@
-import { type FieldMetadata } from '@/object-record/record-field/ui/types/FieldMetadata';
-import { type ColumnDefinition } from '@/object-record/record-table/types/ColumnDefinition';
-
-import { type ViewField } from '@/views/types/ViewField';
-
-export const mapColumnDefinitionsToViewFields = (
- columnDefinitions: ColumnDefinition<FieldMetadata>[],
-): ViewField[] => {
- return columnDefinitions.map((columnDefinition) => ({
- id: columnDefinition.viewFieldId || '',
- fieldMetadataId: columnDefinition.fieldMetadataId,
- position: columnDefinition.position,
- size: columnDefinition.size,
- isVisible: columnDefinition.isVisible ?? true,
- isActive: true,
- definition: columnDefinition,
- }));
-};
diff --git a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/utils/__tests__/hasNonStringValues.test.ts b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/utils/__tests__/hasNonStringValues.test.ts
deleted file mode 100644
index fdb9bb4cb0a..00000000000
--- a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/utils/__tests__/hasNonStringValues.test.ts
+++ /dev/null
@@ -1,35 +0,0 @@
-import { type HttpRequestBody } from '@/workflow/workflow-steps/workflow-actions/http-request-action/constants/HttpRequest';
-import { hasNonStringValues } from '@/workflow/workflow-steps/workflow-actions/http-request-action/utils/hasNonStringValues';
-
-describe('hasNonStringValues', () => {
- it('should return true for empty object', () => {
- expect(hasNonStringValues({})).toBe(true);
- });
-
- it('should return false for object with only string values', () => {
- expect(hasNonStringValues({ key1: 'value1', key2: 'value2' })).toBe(false);
- });
-
- it('should return true for object with null values', () => {
- const body: HttpRequestBody = { key1: null, key2: 'value' };
- expect(hasNonStringValues(body)).toBe(true);
- });
-
- it('should return true for object with number values', () => {
- const body: HttpRequestBody = { key1: 'value1', key2: 123 };
- expect(hasNonStringValues(body)).toBe(true);
- });
-
- it('should return true for object with boolean values', () => {
- const body: HttpRequestBody = { key1: 'value1', key2: true };
- expect(hasNonStringValues(body)).toBe(true);
- });
-
- it('should return true for object with array values', () => {
- const body: HttpRequestBody = {
- key1: 'value1',
- key2: [1, 'two', true, null],
- };
- expect(hasNonStringValues(body)).toBe(true);
- });
-});
diff --git a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/utils/hasNonStringValues.ts b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/utils/hasNonStringValues.ts
deleted file mode 100644
index a808258df39..00000000000
--- a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/utils/hasNonStringValues.ts
+++ /dev/null
@@ -1,12 +0,0 @@
-import { isString } from '@sniptt/guards';
-import { type JsonArray, type JsonObject } from 'type-fest';
-
-export const hasNonStringValues = (obj: JsonObject | JsonArray): boolean => {
- const values = Object.values(obj);
-
- if (values.length === 0) {
- return true;
- }
-
- return !values.every((value) => isString(value));
-};
diff --git a/packages/twenty-front/src/utils/__tests__/normalizeGQLField.test.ts b/packages/twenty-front/src/testing/utils/__tests__/normalizeGQLField.test.ts
similarity index 89%
rename from packages/twenty-front/src/utils/__tests__/normalizeGQLField.test.ts
rename to packages/twenty-front/src/testing/utils/__tests__/normalizeGQLField.test.ts
index 5b030bb018b..6a46515c49b 100644
--- a/packages/twenty-front/src/utils/__tests__/normalizeGQLField.test.ts
+++ b/packages/twenty-front/src/testing/utils/__tests__/normalizeGQLField.test.ts
@@ -1,4 +1,4 @@
-import { normalizeGQLField } from '~/utils/normalizeGQLField';
+import { normalizeGQLField } from '~/testing/utils/normalizeGQLField';
describe('normalizeGQLField', () => {
it('should produce consistent output for the same fields', () => {
diff --git a/packages/twenty-front/src/utils/__tests__/normalizeGQLQuery.test.ts b/packages/twenty-front/src/testing/utils/__tests__/normalizeGQLQuery.test.ts
similarity index 90%
rename from packages/twenty-front/src/utils/__tests__/normalizeGQLQuery.test.ts
rename to packages/twenty-front/src/testing/utils/__tests__/normalizeGQLQuery.test.ts
index 6f9c6d289e2..b2a337325a6 100644
--- a/packages/twenty-front/src/utils/__tests__/normalizeGQLQuery.test.ts
+++ b/packages/twenty-front/src/testing/utils/__tests__/normalizeGQLQuery.test.ts
@@ -1,4 +1,4 @@
-import { normalizeGQLQuery } from '~/utils/normalizeGQLQuery';
+import { normalizeGQLQuery } from '~/testing/utils/normalizeGQLQuery';
describe('normalizeGQLQuery', () => {
it('should produce consistent output for the same query', () => {
diff --git a/packages/twenty-front/src/utils/normalizeGQLField.ts b/packages/twenty-front/src/testing/utils/normalizeGQLField.ts
similarity index 100%
rename from packages/twenty-front/src/utils/normalizeGQLField.ts
rename to packages/twenty-front/src/testing/utils/normalizeGQLField.ts
diff --git a/packages/twenty-front/src/utils/normalizeGQLQuery.ts b/packages/twenty-front/src/testing/utils/normalizeGQLQuery.ts
similarity index 100%
rename from packages/twenty-front/src/utils/normalizeGQLQuery.ts
rename to packages/twenty-front/src/testing/utils/normalizeGQLQuery.ts
diff --git a/packages/twenty-front/src/utils/__tests__/compareNonEmptyString.test.ts b/packages/twenty-front/src/utils/__tests__/compareNonEmptyString.test.ts
deleted file mode 100644
index 54da87e009f..00000000000
--- a/packages/twenty-front/src/utils/__tests__/compareNonEmptyString.test.ts
+++ /dev/null
@@ -1,51 +0,0 @@
-import { compareNonEmptyStrings } from '~/utils/compareNonEmptyStrings';
-
-describe('compareNonEmptyStrings', () => {
- it('should return true for undefined === null', () => {
- expect(compareNonEmptyStrings(undefined, null)).toBe(true);
- });
-
- it('should return true for null === undefined', () => {
- expect(compareNonEmptyStrings(null, undefined)).toBe(true);
- });
-
- it('should return true for undefined === undefined', () => {
- expect(compareNonEmptyStrings(undefined, undefined)).toBe(true);
- });
-
- it('should return true for null === null', () => {
- expect(compareNonEmptyStrings(null, null)).toBe(true);
- });
-
- it('should return true for "" === null', () => {
- expect(compareNonEmptyStrings('', null)).toBe(true);
- });
-
- it('should return true for "" === undefined', () => {
- expect(compareNonEmptyStrings('', undefined)).toBe(true);
- });
-
- it('should return true for "" === ""', () => {
- expect(compareNonEmptyStrings('', '')).toBe(true);
- });
-
- it('should return true for "a" === "a"', () => {
- expect(compareNonEmptyStrings('a', 'a')).toBe(true);
- });
-
- it('should return false for "a" === "b"', () => {
- expect(compareNonEmptyStrings('a', 'b')).toBe(false);
- });
-
- it('should return false for undefined === "a"', () => {
- expect(compareNonEmptyStrings(undefined, 'a')).toBe(false);
- });
-
- it('should return false for null === "a"', () => {
- expect(compareNonEmptyStrings(null, 'a')).toBe(false);
- });
-
- it('should return false for "" === "a"', () => {
- expect(compareNonEmptyStrings('', 'a')).toBe(false);
- });
-});
diff --git a/packages/twenty-front/src/utils/__tests__/compareNonEmptyStrings.test.ts b/packages/twenty-front/src/utils/__tests__/compareNonEmptyStrings.test.ts
index a7a48d65bfc..54da87e009f 100644
--- a/packages/twenty-front/src/utils/__tests__/compareNonEmptyStrings.test.ts
+++ b/packages/twenty-front/src/utils/__tests__/compareNonEmptyStrings.test.ts
@@ -1,19 +1,51 @@
import { compareNonEmptyStrings } from '~/utils/compareNonEmptyStrings';
describe('compareNonEmptyStrings', () => {
- it('should return true when both values are empty or nullish', () => {
+ it('should return true for undefined === null', () => {
+ expect(compareNonEmptyStrings(undefined, null)).toBe(true);
+ });
+
+ it('should return true for null === undefined', () => {
expect(compareNonEmptyStrings(null, undefined)).toBe(true);
+ });
+
+ it('should return true for undefined === undefined', () => {
+ expect(compareNonEmptyStrings(undefined, undefined)).toBe(true);
+ });
+
+ it('should return true for null === null', () => {
+ expect(compareNonEmptyStrings(null, null)).toBe(true);
+ });
+
+ it('should return true for "" === null', () => {
expect(compareNonEmptyStrings('', null)).toBe(true);
+ });
+
+ it('should return true for "" === undefined', () => {
+ expect(compareNonEmptyStrings('', undefined)).toBe(true);
+ });
+
+ it('should return true for "" === ""', () => {
expect(compareNonEmptyStrings('', '')).toBe(true);
});
- it('should return true when both values are equal non-empty strings', () => {
- expect(compareNonEmptyStrings('foo', 'foo')).toBe(true);
+ it('should return true for "a" === "a"', () => {
+ expect(compareNonEmptyStrings('a', 'a')).toBe(true);
+ });
+
+ it('should return false for "a" === "b"', () => {
+ expect(compareNonEmptyStrings('a', 'b')).toBe(false);
+ });
+
+ it('should return false for undefined === "a"', () => {
+ expect(compareNonEmptyStrings(undefined, 'a')).toBe(false);
+ });
+
+ it('should return false for null === "a"', () => {
+ expect(compareNonEmptyStrings(null, 'a')).toBe(false);
});
- it('should return false when values differ', () => {
- expect(compareNonEmptyStrings('foo', 'bar')).toBe(false);
- expect(compareNonEmptyStrings('foo', '')).toBe(false);
- expect(compareNonEmptyStrings('foo', null)).toBe(false);
+ it('should return false for "" === "a"', () => {
+ expect(compareNonEmptyStrings('', 'a')).toBe(false);
});
});
diff --git a/packages/twenty-front/src/utils/__tests__/createApolloStoreFieldName.test.ts b/packages/twenty-front/src/utils/__tests__/createApolloStoreFieldName.test.ts
deleted file mode 100644
index b1a486b16f4..00000000000
--- a/packages/twenty-front/src/utils/__tests__/createApolloStoreFieldName.test.ts
+++ /dev/null
@@ -1,40 +0,0 @@
-import { createApolloStoreFieldName } from '~/utils/createApolloStoreFieldName';
-
-describe('createApolloStoreFieldName', () => {
- it('should create field name with simple variables', () => {
- const result = createApolloStoreFieldName({
- fieldName: 'users',
- fieldVariables: { limit: 10 },
- });
-
- expect(result).toBe('users({"limit":10})');
- });
-
- it('should create field name with complex variables', () => {
- const result = createApolloStoreFieldName({
- fieldName: 'companies',
- fieldVariables: {
- filter: { name: { ilike: '%test%' } },
- orderBy: [{ createdAt: 'DESC' }],
- first: 20,
- },
- });
-
- expect(result).toBe(
- 'companies({"filter":{"name":{"ilike":"%test%"}},"orderBy":[{"createdAt":"DESC"}],"first":20})',
- );
- });
-
- it('should create field name with null and undefined values', () => {
- const result = createApolloStoreFieldName({
- fieldName: 'records',
- fieldVariables: {
- id: null,
- name: undefined,
- active: true,
- },
- });
-
- expect(result).toBe('records({"id":null,"active":true})');
- });
-});
diff --git a/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts b/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts
deleted file mode 100644
index 0f153eb4b93..00000000000
--- a/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts
+++ /dev/null
@@ -1,111 +0,0 @@
-import { getDirtyFields } from '~/utils/getDirtyFields';
-
-describe('getDirtyFields', () => {
- it('should return all defined fields from draft when persisted is null', () => {
- const draft = { a: 1, b: 'hello', c: undefined, d: null };
- const persisted = null;
- expect(getDirtyFields(draft, persisted)).toEqual({
- a: 1,
- b: 'hello',
- d: null,
- });
- });
-
- it('should return all defined fields from draft when persisted is undefined', () => {
- const draft = { a: 1, b: 'hello', c: undefined, d: false };
- const persisted = undefined;
- expect(getDirtyFields(draft, persisted)).toEqual({
- a: 1,
- b: 'hello',
- d: false,
- });
- });
-
- it('should return an empty object when draft and persisted are identical', () => {
- const draft = { a: 1, b: { c: 2 }, d: [1, 2] };
- const persisted = { a: 1, b: { c: 2 }, d: [1, 2] };
- expect(getDirtyFields(draft, persisted)).toEqual({});
- });
-
- it('should detect simple value changes', () => {
- const draft = { a: 1, b: 'world', c: true };
- const persisted = { a: 1, b: 'hello', c: false };
- expect(getDirtyFields(draft, persisted)).toEqual({ b: 'world', c: true });
- });
-
- it('should detect nested object changes', () => {
- const draft = { a: { b: { c: 3 } } };
- const persisted = { a: { b: { c: 2 } } };
- expect(getDirtyFields(draft, persisted)).toEqual({ a: { b: { c: 3 } } });
- });
-
- it('should detect array changes', () => {
- const draft = { a: [1, 3] };
- const persisted = { a: [1, 2] };
- expect(getDirtyFields(draft, persisted)).toEqual({ a: [1, 3] });
- });
-
- it('should detect added fields', () => {
- const draft = { a: 1, b: 2 };
- const persisted = { a: 1 };
- expect(getDirtyFields(draft, persisted)).toEqual({ b: 2 });
- });
-
- it('should detect removed fields (value becomes undefined)', () => {
- const draft = { a: 1 };
- const persisted = { a: 1, b: 2 };
- // When a field is removed, its value in draft effectively becomes undefined
- expect(getDirtyFields(draft, persisted as any)).toEqual({ b: undefined });
- });
-
- it('should detect fields set to undefined', () => {
- const draft = { a: 1, b: undefined };
- const persisted = { a: 1, b: 2 };
- expect(getDirtyFields(draft, persisted as any)).toEqual({ b: undefined });
- });
-
- it('should detect fields set to null', () => {
- const draft = { a: 1, b: null };
- const persisted = { a: 1, b: 2 };
- expect(getDirtyFields(draft, persisted as any)).toEqual({ b: null });
- });
-
- it('should handle complex nested structures with mixed changes', () => {
- const draft = {
- id: 1,
- name: 'new name', // changed
- details: {
- status: 'active', // same
- tags: ['tag1', 'tag3'], // changed
- metadata: { key: 'newValue' }, // changed
- },
- settings: { enabled: true }, // new
- };
- const persisted = {
- id: 1,
- name: 'old name',
- details: {
- status: 'active',
- tags: ['tag1', 'tag2'],
- metadata: { key: 'oldValue' },
- },
- archived: true, // removed
- };
- expect(getDirtyFields(draft, persisted as any)).toEqual({
- name: 'new name',
- details: {
- status: 'active',
- tags: ['tag1', 'tag3'],
- metadata: { key: 'newValue' },
- },
- settings: { enabled: true },
- archived: undefined,
- });
- });
-
- it('should return empty object for deeply equal but different reference objects', () => {
- const draft = { a: { b: 1 } };
- const persisted = JSON.parse(JSON.stringify(draft)); // Deep clone, different reference
- expect(getDirtyFields(draft, persisted)).toEqual({});
- });
-});
diff --git a/packages/twenty-front/src/utils/__tests__/getDirtyFields.test.ts b/packages/twenty-front/src/utils/__tests__/getDirtyFields.test.ts
index a12ed32db44..0f153eb4b93 100644
--- a/packages/twenty-front/src/utils/__tests__/getDirtyFields.test.ts
+++ b/packages/twenty-front/src/utils/__tests__/getDirtyFields.test.ts
@@ -1,55 +1,111 @@
import { getDirtyFields } from '~/utils/getDirtyFields';
describe('getDirtyFields', () => {
- it('should return all defined fields when persisted is null', () => {
- const draft = { name: 'Alice', age: 30, email: undefined };
-
- const result = getDirtyFields(draft, null);
-
- expect(result).toEqual({ name: 'Alice', age: 30 });
+ it('should return all defined fields from draft when persisted is null', () => {
+ const draft = { a: 1, b: 'hello', c: undefined, d: null };
+ const persisted = null;
+ expect(getDirtyFields(draft, persisted)).toEqual({
+ a: 1,
+ b: 'hello',
+ d: null,
+ });
});
- it('should return all defined fields when persisted is undefined', () => {
- const draft = { name: 'Bob' };
-
- const result = getDirtyFields(draft, undefined);
-
- expect(result).toEqual({ name: 'Bob' });
+ it('should return all defined fields from draft when persisted is undefined', () => {
+ const draft = { a: 1, b: 'hello', c: undefined, d: false };
+ const persisted = undefined;
+ expect(getDirtyFields(draft, persisted)).toEqual({
+ a: 1,
+ b: 'hello',
+ d: false,
+ });
});
- it('should return only changed fields', () => {
- const draft = { name: 'Alice', age: 31 };
- const persisted = { name: 'Alice', age: 30 };
-
- const result = getDirtyFields(draft, persisted);
-
- expect(result).toEqual({ age: 31 });
+ it('should return an empty object when draft and persisted are identical', () => {
+ const draft = { a: 1, b: { c: 2 }, d: [1, 2] };
+ const persisted = { a: 1, b: { c: 2 }, d: [1, 2] };
+ expect(getDirtyFields(draft, persisted)).toEqual({});
});
- it('should return empty object when nothing changed', () => {
- const draft = { name: 'Alice', age: 30 };
- const persisted = { name: 'Alice', age: 30 };
+ it('should detect simple value changes', () => {
+ const draft = { a: 1, b: 'world', c: true };
+ const persisted = { a: 1, b: 'hello', c: false };
+ expect(getDirtyFields(draft, persisted)).toEqual({ b: 'world', c: true });
+ });
- const result = getDirtyFields(draft, persisted);
+ it('should detect nested object changes', () => {
+ const draft = { a: { b: { c: 3 } } };
+ const persisted = { a: { b: { c: 2 } } };
+ expect(getDirtyFields(draft, persisted)).toEqual({ a: { b: { c: 3 } } });
+ });
- expect(result).toEqual({});
+ it('should detect array changes', () => {
+ const draft = { a: [1, 3] };
+ const persisted = { a: [1, 2] };
+ expect(getDirtyFields(draft, persisted)).toEqual({ a: [1, 3] });
});
- it('should detect deeply nested changes', () => {
- const draft = { address: { city: 'Paris' } };
- const persisted = { address: { city: 'London' } };
+ it('should detect added fields', () => {
+ const draft = { a: 1, b: 2 };
+ const persisted = { a: 1 };
+ expect(getDirtyFields(draft, persisted)).toEqual({ b: 2 });
+ });
- const result = getDirtyFields(draft, persisted);
+ it('should detect removed fields (value becomes undefined)', () => {
+ const draft = { a: 1 };
+ const persisted = { a: 1, b: 2 };
+ // When a field is removed, its value in draft effectively becomes undefined
+ expect(getDirtyFields(draft, persisted as any)).toEqual({ b: undefined });
+ });
- expect(result).toEqual({ address: { city: 'Paris' } });
+ it('should detect fields set to undefined', () => {
+ const draft = { a: 1, b: undefined };
+ const persisted = { a: 1, b: 2 };
+ expect(getDirtyFields(draft, persisted as any)).toEqual({ b: undefined });
});
- it('should detect new keys in draft', () => {
- const draft = { name: 'Alice', age: 30 } as Record<string, any>;
- const persisted = { name: 'Alice' } as Record<string, any>;
+ it('should detect fields set to null', () => {
+ const draft = { a: 1, b: null };
+ const persisted = { a: 1, b: 2 };
+ expect(getDirtyFields(draft, persisted as any)).toEqual({ b: null });
+ });
- const result = getDirtyFields(draft, persisted);
+ it('should handle complex nested structures with mixed changes', () => {
+ const draft = {
+ id: 1,
+ name: 'new name', // changed
+ details: {
+ status: 'active', // same
+ tags: ['tag1', 'tag3'], // changed
+ metadata: { key: 'newValue' }, // changed
+ },
+ settings: { enabled: true }, // new
+ };
+ const persisted = {
+ id: 1,
+ name: 'old name',
+ details: {
+ status: 'active',
+ tags: ['tag1', 'tag2'],
+ metadata: { key: 'oldValue' },
+ },
+ archived: true, // removed
+ };
+ expect(getDirtyFields(draft, persisted as any)).toEqual({
+ name: 'new name',
+ details: {
+ status: 'active',
+ tags: ['tag1', 'tag3'],
+ metadata: { key: 'newValue' },
+ },
+ settings: { enabled: true },
+ archived: undefined,
+ });
+ });
- expect(result).toEqual({ age: 30 });
+ it('should return empty object for deeply equal but different reference objects', () => {
+ const draft = { a: { b: 1 } };
+ const persisted = JSON.parse(JSON.stringify(draft)); // Deep clone, different reference
+ expect(getDirtyFields(draft, persisted)).toEqual({});
});
});
diff --git a/packages/twenty-front/src/utils/createApolloStoreFieldName.ts b/packages/twenty-front/src/utils/createApolloStoreFieldName.ts
deleted file mode 100644
index 7959a7f2a93..00000000000
--- a/packages/twenty-front/src/utils/createApolloStoreFieldName.ts
+++ /dev/null
@@ -1,9 +0,0 @@
-export const createApolloStoreFieldName = ({
- fieldName,
- fieldVariables,
-}: {
- fieldName: string;
- fieldVariables: Record<string, any>;
-}) => {
- return `${fieldName}(${JSON.stringify(fieldVariables)})`;
-};