Skip to content

The open alternative to Salesforce, designed for AI.

Show hidden fields on the record creation form (#27475)

Thomas Trompette7b4c5ea43676
diff --git a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/SidePanelRecordCreationFormPage.tsx b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/SidePanelRecordCreationFormPage.tsx
index 1ac03fb7cce..58f3ab88a5a 100644
--- a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/SidePanelRecordCreationFormPage.tsx
+++ b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/SidePanelRecordCreationFormPage.tsx
@@ -14,6 +14,7 @@ import { useRecordCreationFormSettle } from '@/object-record/record-form/hooks/u
import { useRecordFormFields } from '@/object-record/record-form/hooks/useRecordFormFields';
import { computeRecordFormCreateRecordInput } from '@/object-record/record-form/utils/computeRecordFormCreateRecordInput';
import { type ObjectRecord } from '@/object-record/types/ObjectRecord';
+import { recordCreationFormAreHiddenFieldsShownComponentState } from '@/side-panel/pages/record-creation-form/states/recordCreationFormAreHiddenFieldsShownComponentState';
import { recordCreationFormDraftComponentState } from '@/side-panel/pages/record-creation-form/states/recordCreationFormDraftComponentState';
import { recordCreationFormRequestComponentState } from '@/side-panel/pages/record-creation-form/states/recordCreationFormRequestComponentState';
import { SidePanelFooter } from '@/ui/layout/side-panel/components/SidePanelFooter';
@@ -29,7 +30,8 @@ import { t } from '@lingui/core/macro';
import { Key } from 'ts-key-enum';
import { type JsonValue } from 'type-fest';
import { isDefined } from 'twenty-shared/utils';
-import { IconPlus } from 'twenty-ui/icon';
+import { LightButton } from 'twenty-ui/components/input';
+import { IconChevronDown, IconChevronUp, IconPlus } from 'twenty-ui/icon';
import { Button } from 'twenty-ui/primitives/input';
import { useTheme, themeCssVariables } from 'twenty-ui/theme';
@@ -67,6 +69,10 @@ const StyledContent = styled.div`
padding: ${themeCssVariables.spacing[4]};
`;
+const StyledHiddenFieldsToggle = styled.div`
+ display: flex;
+`;
+
export const SidePanelRecordCreationFormPage = () => {
const recordCreationFormRequest = useAtomComponentStateValue(
recordCreationFormRequestComponentState,
@@ -106,6 +112,13 @@ const SidePanelRecordCreationForm = ({
const [recordCreationFormDraft, setRecordCreationFormDraft] =
useAtomComponentState(recordCreationFormDraftComponentState);
+ const [
+ recordCreationFormAreHiddenFieldsShown,
+ setRecordCreationFormAreHiddenFieldsShown,
+ ] = useAtomComponentState(
+ recordCreationFormAreHiddenFieldsShownComponentState,
+ );
+
const [isSubmitting, setIsSubmitting] = useState(false);
const [validationRuleViolations, setValidationRuleViolations] = useState<
DraftValidationRuleViolation[]
@@ -133,6 +146,12 @@ const SidePanelRecordCreationForm = ({
.filter((recordFormField) => recordFormField.isVisible)
.map((recordFormField) => recordFormField.fieldMetadataItem);
+ const hiddenFieldMetadataItems = editableRecordFormFields
+ .filter((recordFormField) => !recordFormField.isVisible)
+ .map((recordFormField) => recordFormField.fieldMetadataItem);
+
+ const hiddenFieldsCount = hiddenFieldMetadataItems.length;
+
const computeViolations = (draftRecordToCheck: Partial<ObjectRecord>) =>
computeDraftValidationRuleViolations({
validationRules,
@@ -227,6 +246,37 @@ const SidePanelRecordCreationForm = ({
onFieldValueChange={handleFieldValueChange}
onFieldValueClear={handleFieldValueClear}
/>
+ {hiddenFieldsCount > 0 && (
+ <StyledHiddenFieldsToggle>
+ <LightButton
+ startIcon={
+ recordCreationFormAreHiddenFieldsShown ? (
+ <IconChevronUp />
+ ) : (
+ <IconChevronDown />
+ )
+ }
+ onClick={() =>
+ setRecordCreationFormAreHiddenFieldsShown(
+ !recordCreationFormAreHiddenFieldsShown,
+ )
+ }
+ >
+ {recordCreationFormAreHiddenFieldsShown
+ ? t`Collapse hidden fields`
+ : t`Show hidden fields (${hiddenFieldsCount})`}
+ </LightButton>
+ </StyledHiddenFieldsToggle>
+ )}
+ {recordCreationFormAreHiddenFieldsShown && hiddenFieldsCount > 0 && (
+ <RecordFormFieldInputs
+ objectMetadataItem={objectMetadataItem}
+ fieldMetadataItems={hiddenFieldMetadataItems}
+ draftRecord={draftRecord}
+ onFieldValueChange={handleFieldValueChange}
+ onFieldValueClear={handleFieldValueClear}
+ />
+ )}
</StyledContent>
{validationRuleViolations.length > 0 && (
<StyledValidationRuleErrors>
diff --git a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__tests__/SidePanelRecordCreationFormPage.test.tsx b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__tests__/SidePanelRecordCreationFormPage.test.tsx
index 0ea39317c8f..fa6c0f4da9b 100644
--- a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__tests__/SidePanelRecordCreationFormPage.test.tsx
+++ b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__tests__/SidePanelRecordCreationFormPage.test.tsx
@@ -1,6 +1,7 @@
import { i18n } from '@lingui/core';
import { I18nProvider } from '@lingui/react';
import { render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
import { Provider as JotaiProvider } from 'jotai';
import { type createElement, type Fragment, type ReactNode } from 'react';
import { MemoryRouter } from 'react-router-dom';
@@ -230,4 +231,62 @@ describe('SidePanelRecordCreationFormPage', () => {
expect(screen.queryByLabelText('Internal note')).not.toBeInTheDocument();
expect(screen.queryByLabelText('Nickname')).not.toBeInTheDocument();
});
+
+ it('reveals the hidden fields the user can update on demand', async () => {
+ const user = userEvent.setup();
+
+ renderPage();
+
+ await user.click(
+ screen.getByRole('button', { name: 'Show hidden fields (1)' }),
+ );
+
+ expect(screen.getByLabelText('Nickname')).toBeInTheDocument();
+ expect(screen.queryByLabelText('Secret')).not.toBeInTheDocument();
+
+ await user.click(
+ screen.getByRole('button', { name: 'Collapse hidden fields' }),
+ );
+
+ expect(screen.queryByLabelText('Nickname')).not.toBeInTheDocument();
+ });
+
+ it('submits a value typed in a hidden field after collapsing it', async () => {
+ const user = userEvent.setup();
+
+ renderPage();
+
+ await user.click(
+ screen.getByRole('button', { name: 'Show hidden fields (1)' }),
+ );
+ await user.type(screen.getByLabelText('Nickname'), 'Apple');
+ await user.click(
+ screen.getByRole('button', { name: 'Collapse hidden fields' }),
+ );
+ await user.click(screen.getByTestId('record-creation-form-create-button'));
+
+ expect(settleRecordCreationDraft).toHaveBeenCalledTimes(1);
+ expect(settleRecordCreationDraft).toHaveBeenCalledWith({
+ requestId: REQUEST_ID,
+ draftRecord: { nickname: 'Apple' },
+ });
+ });
+
+ it('restores the draft and revealed fields when the form is shown again', async () => {
+ const user = userEvent.setup();
+
+ const { unmount } = renderPage();
+
+ await user.type(screen.getByLabelText('Name'), 'Apple');
+ await user.click(
+ screen.getByRole('button', { name: 'Show hidden fields (1)' }),
+ );
+ await user.type(screen.getByLabelText('Nickname'), 'Big Apple');
+
+ unmount();
+ renderPage();
+
+ expect(screen.getByLabelText('Name')).toHaveValue('Apple');
+ expect(screen.getByLabelText('Nickname')).toHaveValue('Big Apple');
+ });
});
diff --git a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/states/recordCreationFormAreHiddenFieldsShownComponentState.ts b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/states/recordCreationFormAreHiddenFieldsShownComponentState.ts
new file mode 100644
index 00000000000..ecfd52ad2f5
--- /dev/null
+++ b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/states/recordCreationFormAreHiddenFieldsShownComponentState.ts
@@ -0,0 +1,9 @@
+import { SidePanelPageComponentInstanceContext } from '@/side-panel/states/contexts/SidePanelPageComponentInstanceContext';
+import { createAtomComponentState } from '@/ui/utilities/state/jotai/utils/createAtomComponentState';
+
+export const recordCreationFormAreHiddenFieldsShownComponentState =
+ createAtomComponentState<boolean>({
+ key: 'side-panel/record-creation-form-are-hidden-fields-shown',
+ defaultValue: false,
+ componentInstanceContext: SidePanelPageComponentInstanceContext,
+ });