The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Explain missing call recording summary when transcript is empty or failed (#27658)
nitin7b9ae35fae91
diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/__tests__/useCallRecordingForWidget.test.tsx b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/__tests__/useCallRecordingForWidget.test.tsxindex dc7b4b03108..3ad793fca86 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/__tests__/useCallRecordingForWidget.test.tsx+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/__tests__/useCallRecordingForWidget.test.tsx@@ -60,7 +60,20 @@ describe('useCallRecordingForWidget', () => {},);- it('does not request media for the summary widget', () => {+ it('requests the transcript but not media for the summary widget', () => {+ renderHook(() => useCallRecordingForWidget({ kind: 'summary' }));++ expect(getRequestedFields()).toEqual({+ id: true,+ status: true,+ summary: true,+ transcript: true,+ });+ });++ it('omits the transcript for the summary widget when it is restricted', () => {+ restrictedFields = new Set(['transcript']);+renderHook(() => useCallRecordingForWidget({ kind: 'summary' }));expect(getRequestedFields()).toEqual({diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingForWidget.ts b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingForWidget.tsindex 8adbfd647d6..807eb425566 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingForWidget.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingForWidget.ts@@ -45,6 +45,7 @@ export const useCallRecordingForWidget = ({const isVideoRestricted = isFieldRestricted('video');const isAudioRestricted = isFieldRestricted('audio');+ const isTranscriptRestricted = isFieldRestricted('transcript');// Requesting a field the role cannot read fails the whole query.const recordGqlFields = useMemo(@@ -55,8 +56,11 @@ export const useCallRecordingForWidget = ({...(!isVideoRestricted && { video: true }),...(!isAudioRestricted && { audio: true }),}- : CALL_RECORDING_RECORD_FIELDS_BY_WIDGET_KIND[kind],- [kind, isVideoRestricted, isAudioRestricted],+ : {+ ...CALL_RECORDING_RECORD_FIELDS_BY_WIDGET_KIND.summary,+ ...(!isTranscriptRestricted && { transcript: true }),+ },+ [kind, isVideoRestricted, isAudioRestricted, isTranscriptRestricted],);const {diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/__tests__/getCallRecordingStatusDisplayConfiguration.test.ts b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/__tests__/getCallRecordingStatusDisplayConfiguration.test.tsindex 44bd6afd734..2efac70ed40 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/__tests__/getCallRecordingStatusDisplayConfiguration.test.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/__tests__/getCallRecordingStatusDisplayConfiguration.test.ts@@ -96,6 +96,41 @@ describe('getCallRecordingStatusDisplayConfiguration', () => {);});+ it.each([+ {+ transcript: { status: 'EMPTY' },+ title: 'No Speech Detected',+ subTitle: 'No speech was detected, so there is nothing to summarize.',+ },+ {+ transcript: { status: 'EMPTY', subCode: 'transcript_expired' },+ title: 'Summary Not Available',+ subTitle:+ 'A summary could not be generated because no transcript is available.',+ },+ {+ transcript: { status: 'FAILED' },+ title: 'Summary Not Available',+ subTitle:+ 'A summary could not be generated because no transcript is available.',+ },+ {+ transcript: { status: 'PENDING' },+ title: 'Summary Not Available',+ subTitle: 'A summary is not available for this call recording yet.',+ },+ ])(+ 'explains a missing summary of a completed recording with transcript $transcript',+ ({ transcript, title, subTitle }) => {+ expect(+ getCallRecordingStatusDisplayConfiguration(+ { status: CallRecordingStatus.COMPLETED, transcript },+ 'summary',+ ),+ ).toEqual({ title, subTitle });+ },+ );+it('shows the transcript empty state after recording completion', () => {expect(getCallRecordingStatusDisplayConfiguration(diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/getCallRecordingStatusDisplayConfiguration.ts b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/getCallRecordingStatusDisplayConfiguration.tsindex 4e41a3fe341..9bc5089f2df 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/getCallRecordingStatusDisplayConfiguration.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/getCallRecordingStatusDisplayConfiguration.ts@@ -14,6 +14,32 @@ type CallRecordingStatusDisplayConfiguration = {subTitle: string;};+const getCompletedCallRecordingSummaryDisplayConfiguration = (+ transcript: WidgetCallRecordingCandidate['transcript'],+): CallRecordingStatusDisplayConfiguration => {+ if (+ !isCallRecordingTranscriptStatusMarker(transcript) ||+ transcript.status === 'PENDING'+ ) {+ return {+ title: t`Summary Not Available`,+ subTitle: t`A summary is not available for this call recording yet.`,+ };+ }++ if (transcript.status === 'EMPTY' && !isDefined(transcript.subCode)) {+ return {+ title: t`No Speech Detected`,+ subTitle: t`No speech was detected, so there is nothing to summarize.`,+ };+ }++ return {+ title: t`Summary Not Available`,+ subTitle: t`A summary could not be generated because no transcript is available.`,+ };+};+export const getCallRecordingStatusDisplayConfiguration = (callRecording: Pick<WidgetCallRecordingCandidate, 'status' | 'transcript'>,artifactType: CallRecordingArtifactType,@@ -79,15 +105,16 @@ export const getCallRecordingStatusDisplayConfiguration = (subTitle: t`The call recording is being processed…`,};case CallRecordingStatus.COMPLETED:- return artifactType === 'summary'- ? {- title: t`Summary Not Available`,- subTitle: t`A summary is not available for this call recording yet.`,- }- : {- title: t`No Transcript`,- subTitle: t`No transcript is available for this call recording yet.`,- };+ if (artifactType === 'transcript') {+ return {+ title: t`No Transcript`,+ subTitle: t`No transcript is available for this call recording yet.`,+ };+ }++ return getCompletedCallRecordingSummaryDisplayConfiguration(+ callRecording.transcript,+ );case CallRecordingStatus.FAILED:return {title: t`Recording Failed`,