The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Route any casing of host-sanitized props to their canonical key in front component host elements (#28774)
Charles Bochet7f1e04c438d4
diff --git a/packages/twenty-front-component-renderer/src/constants/HostSanitizedPropNames.ts b/packages/twenty-front-component-renderer/src/constants/HostSanitizedPropNames.tsnew file mode 100644index 00000000000..4931b724ee2--- /dev/null+++ b/packages/twenty-front-component-renderer/src/constants/HostSanitizedPropNames.ts@@ -0,0 +1,4 @@+export const HOST_SANITIZED_PROP_NAMES: ReadonlySet<string> = new Set([+ 'sandbox',+ 'style',+]);diff --git a/packages/twenty-front-component-renderer/src/constants/NonForwardedRemotePropNames.ts b/packages/twenty-front-component-renderer/src/constants/NonForwardedRemotePropNames.tsnew file mode 100644index 00000000000..5817ad01348--- /dev/null+++ b/packages/twenty-front-component-renderer/src/constants/NonForwardedRemotePropNames.ts@@ -0,0 +1,7 @@+export const NON_FORWARDED_REMOTE_PROP_NAMES: ReadonlySet<string> = new Set([+ 'element',+ 'receiver',+ 'components',+ 'ref',+ 'dangerouslySetInnerHTML',+]);diff --git a/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/buildHostReactPropsFromRemoteProps.test.ts b/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/buildHostReactPropsFromRemoteProps.test.tsindex 1ec9e407074..c1e15ee0a05 100644--- a/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/buildHostReactPropsFromRemoteProps.test.ts+++ b/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/buildHostReactPropsFromRemoteProps.test.ts@@ -265,4 +265,34 @@ describe('buildHostReactPropsFromRemoteProps', () => {expect('onClick' in result).toBe(false);expect(result['data-state']).toBe('open');});++ it('should route any casing of sandbox to the sandbox key', () => {+ const result = buildHostReactPropsFromRemoteProps({+ remoteProps: { sandbox: 'allow-forms', SANDBOX: 'allow-same-origin' },+ htmlTag: 'iframe',+ });++ expect(result).toEqual({ sandbox: 'allow-same-origin' });+ });++ it('should parse a differently cased style string', () => {+ const result = buildHostReactPropsFromRemoteProps({+ remoteProps: { STYLE: 'color: red' },+ htmlTag: 'div',+ });++ expect(result).toEqual({ style: { color: 'red' } });+ });++ it('should drop dangerouslySetInnerHTML', () => {+ const result = buildHostReactPropsFromRemoteProps({+ remoteProps: {+ dangerouslySetInnerHTML: { __html: '<b>x</b>' },+ id: 'keep',+ },+ htmlTag: 'div',+ });++ expect(result).toEqual({ id: 'keep' });+ });});diff --git a/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/createHtmlHostWrapper.test.ts b/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/createHtmlHostWrapper.test.tsindex 556661cc29d..0e6233a3d43 100644--- a/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/createHtmlHostWrapper.test.ts+++ b/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/createHtmlHostWrapper.test.ts@@ -165,6 +165,23 @@ describe('createHtmlHostWrapper client events', () => {);});+ it('should keep the host sanitized iframe sandbox when a differently cased one is passed', () => {+ const Wrapper = createHtmlHostWrapper('iframe');++ act(() => {+ root.render(+ createElement(Wrapper, {+ sandbox: 'allow-scripts',+ SANDBOX: 'allow-scripts allow-same-origin',+ }),+ );+ });++ const iframe = container.querySelector('iframe');++ expect(iframe?.getAttribute('sandbox')).toBe('allow-scripts');+ });+it('should forward a click once, from the innermost element listening for it', () => {const handleOuterClick = jest.fn();const handleInnerClick = jest.fn();diff --git a/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/isNonForwardedRemotePropName.test.ts b/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/isNonForwardedRemotePropName.test.tsnew file mode 100644index 00000000000..2e1a52c3a02--- /dev/null+++ b/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/isNonForwardedRemotePropName.test.ts@@ -0,0 +1,19 @@+import { isNonForwardedRemotePropName } from '../isNonForwardedRemotePropName';++describe('isNonForwardedRemotePropName', () => {+ it('should not forward remote-dom internal props', () => {+ expect(isNonForwardedRemotePropName('element')).toBe(true);+ expect(isNonForwardedRemotePropName('receiver')).toBe(true);+ expect(isNonForwardedRemotePropName('components')).toBe(true);+ expect(isNonForwardedRemotePropName('ref')).toBe(true);+ });++ it('should not forward dangerouslySetInnerHTML', () => {+ expect(isNonForwardedRemotePropName('dangerouslySetInnerHTML')).toBe(true);+ });++ it('should forward regular props', () => {+ expect(isNonForwardedRemotePropName('id')).toBe(false);+ expect(isNonForwardedRemotePropName('className')).toBe(false);+ });+});diff --git a/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/normalizeHostSanitizedPropName.test.ts b/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/normalizeHostSanitizedPropName.test.tsnew file mode 100644index 00000000000..eaea23cd5d9--- /dev/null+++ b/packages/twenty-front-component-renderer/src/host/elements/utils/__tests__/normalizeHostSanitizedPropName.test.ts@@ -0,0 +1,20 @@+import { normalizeHostSanitizedPropName } from '../normalizeHostSanitizedPropName';++describe('normalizeHostSanitizedPropName', () => {+ it('should lowercase any casing of a host-sanitized prop name', () => {+ expect(normalizeHostSanitizedPropName('SANDBOX')).toBe('sandbox');+ expect(normalizeHostSanitizedPropName('Sandbox')).toBe('sandbox');+ expect(normalizeHostSanitizedPropName('STYLE')).toBe('style');+ });++ it('should keep a host-sanitized prop name already in canonical casing', () => {+ expect(normalizeHostSanitizedPropName('sandbox')).toBe('sandbox');+ expect(normalizeHostSanitizedPropName('style')).toBe('style');+ });++ it('should keep the casing of other prop names', () => {+ expect(normalizeHostSanitizedPropName('srcDoc')).toBe('srcDoc');+ expect(normalizeHostSanitizedPropName('className')).toBe('className');+ expect(normalizeHostSanitizedPropName('viewBox')).toBe('viewBox');+ });+});diff --git a/packages/twenty-front-component-renderer/src/host/elements/utils/buildHostReactPropsFromRemoteProps.ts b/packages/twenty-front-component-renderer/src/host/elements/utils/buildHostReactPropsFromRemoteProps.tsindex 5f4ed27e505..b2c5e4f56db 100644--- a/packages/twenty-front-component-renderer/src/host/elements/utils/buildHostReactPropsFromRemoteProps.ts+++ b/packages/twenty-front-component-renderer/src/host/elements/utils/buildHostReactPropsFromRemoteProps.ts@@ -4,12 +4,13 @@ import { isDefined } from 'twenty-shared/utils';import { buildHostReactEventHandlerProp } from '@/host/elements/utils/buildHostReactEventHandlerProp';import { hasDangerousUrlScheme } from '@/host/elements/utils/hasDangerousUrlScheme';import { isNavigationUrlAttribute } from '@/host/elements/utils/isNavigationUrlAttribute';+import { isNonForwardedRemotePropName } from '@/host/elements/utils/isNonForwardedRemotePropName';+import { normalizeHostSanitizedPropName } from '@/host/elements/utils/normalizeHostSanitizedPropName';import { parseCssString } from '@/host/elements/utils/parseCssString';import { type ClaimPointerEventForwarding } from '@/host/events/types/ClaimPointerEventForwarding';import { isEventHandlerKey } from '@/host/events/utils/isEventHandlerKey';import { type FindRemoteElementIdContainingNode } from '@/host/geometry/types/FindRemoteElementIdContainingNode';-const INTERNAL_PROPS = new Set(['element', 'receiver', 'components', 'ref']);const FORM_OWNER_ATTRIBUTE = 'form';export const buildHostReactPropsFromRemoteProps = ({@@ -25,11 +26,16 @@ export const buildHostReactPropsFromRemoteProps = ({}): Record<string, unknown> => {const hostReactProps: Record<string, unknown> = {};- for (const [remotePropName, remotePropValue] of Object.entries(remoteProps)) {- if (INTERNAL_PROPS.has(remotePropName) || isUndefined(remotePropValue)) {+ for (const [wirePropName, remotePropValue] of Object.entries(remoteProps)) {+ if (+ isNonForwardedRemotePropName(wirePropName) ||+ isUndefined(remotePropValue)+ ) {continue;}+ const remotePropName = normalizeHostSanitizedPropName(wirePropName);+if (remotePropName.toLowerCase() === FORM_OWNER_ATTRIBUTE) {continue;}diff --git a/packages/twenty-front-component-renderer/src/host/elements/utils/isNonForwardedRemotePropName.ts b/packages/twenty-front-component-renderer/src/host/elements/utils/isNonForwardedRemotePropName.tsnew file mode 100644index 00000000000..3b58acb2de7--- /dev/null+++ b/packages/twenty-front-component-renderer/src/host/elements/utils/isNonForwardedRemotePropName.ts@@ -0,0 +1,4 @@+import { NON_FORWARDED_REMOTE_PROP_NAMES } from '@/constants/NonForwardedRemotePropNames';++export const isNonForwardedRemotePropName = (propName: string): boolean =>+ NON_FORWARDED_REMOTE_PROP_NAMES.has(propName);diff --git a/packages/twenty-front-component-renderer/src/host/elements/utils/normalizeHostSanitizedPropName.ts b/packages/twenty-front-component-renderer/src/host/elements/utils/normalizeHostSanitizedPropName.tsnew file mode 100644index 00000000000..46016fbaf00--- /dev/null+++ b/packages/twenty-front-component-renderer/src/host/elements/utils/normalizeHostSanitizedPropName.ts@@ -0,0 +1,9 @@+import { HOST_SANITIZED_PROP_NAMES } from '@/constants/HostSanitizedPropNames';++export const normalizeHostSanitizedPropName = (propName: string): string => {+ const lowercasedPropName = propName.toLowerCase();++ return HOST_SANITIZED_PROP_NAMES.has(lowercasedPropName)+ ? lowercasedPropName+ : propName;+};