Skip to content

The open alternative to Salesforce, designed for AI.

fix(admin): prevent fallback to 'latest' string when dockerhub tags c… (#22885)

Rehuz7f1e3d35416f
diff --git a/packages/twenty-front/src/generated-admin/graphql.ts b/packages/twenty-front/src/generated-admin/graphql.ts
index 447187c6d1a..3fd11dec6b0 100644
--- a/packages/twenty-front/src/generated-admin/graphql.ts
+++ b/packages/twenty-front/src/generated-admin/graphql.ts
@@ -929,7 +929,7 @@ export type VersionDistributionEntry = {
export type VersionInfo = {
__typename?: 'VersionInfo';
currentVersion?: Maybe<Scalars['String']['output']>;
- latestVersion: Scalars['String']['output'];
+ latestVersion?: Maybe<Scalars['String']['output']>;
};
export type WorkerQueueMetrics = {
@@ -1267,7 +1267,7 @@ export type GetUpgradeStatusQuery = { __typename?: 'Query', getUpgradeStatus: Ar
export type GetVersionInfoQueryVariables = Exact<{ [key: string]: never; }>;
-export type GetVersionInfoQuery = { __typename?: 'Query', versionInfo: { __typename?: 'VersionInfo', currentVersion?: string | null, latestVersion: string } };
+export type GetVersionInfoQuery = { __typename?: 'Query', versionInfo: { __typename?: 'VersionInfo', currentVersion?: string | null, latestVersion?: string | null } };
export type WorkspaceBillingAdminPanelQueryVariables = Exact<{
workspaceId: Scalars['UUID']['input'];
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel.service.spec.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel.service.spec.ts
index 131a5ba6bbe..62e2edc55c3 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel.service.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel.service.spec.ts
@@ -337,7 +337,7 @@ describe('AdminPanelVersionService', () => {
expect(result).toEqual({
currentVersion: '1.0.0',
- latestVersion: 'latest',
+ latestVersion: null,
});
});
@@ -353,7 +353,7 @@ describe('AdminPanelVersionService', () => {
expect(result).toEqual({
currentVersion: '1.0.0',
- latestVersion: 'latest',
+ latestVersion: null,
});
});
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/dtos/version-info.dto.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/dtos/version-info.dto.ts
index 210e6fb0120..2a1bbb49a9a 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/dtos/version-info.dto.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/dtos/version-info.dto.ts
@@ -5,6 +5,6 @@ export class VersionInfoDTO {
@Field(() => String, { nullable: true })
currentVersion?: string;
- @Field(() => String)
- latestVersion: string;
+ @Field(() => String, { nullable: true })
+ latestVersion?: string | null;
}
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/services/admin-panel-version.service.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/services/admin-panel-version.service.ts
index 9e3857dbec6..b4abecb21b9 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/services/admin-panel-version.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/services/admin-panel-version.service.ts
@@ -1,4 +1,4 @@
-import { Injectable } from '@nestjs/common';
+import { Injectable, Logger } from '@nestjs/common';
import semver from 'semver';
import * as z from 'zod';
@@ -9,6 +9,8 @@ import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twent
@Injectable()
export class AdminPanelVersionService {
+ private readonly logger = new Logger(AdminPanelVersionService.name);
+
constructor(
private readonly twentyConfigService: TwentyConfigService,
private readonly secureHttpClientService: SecureHttpClientService,
@@ -36,15 +38,18 @@ export class AdminPanelVersionService {
.filter((name) => name !== 'latest' && semver.valid(name));
if (versions.length === 0) {
- return { currentVersion, latestVersion: 'latest' };
+ return { currentVersion, latestVersion: null };
}
versions.sort((a, b) => semver.compare(b, a));
const latestVersion = versions[0];
return { currentVersion, latestVersion };
- } catch {
- return { currentVersion, latestVersion: 'latest' };
+ } catch (error) {
+ this.logger.warn(
+ `Failed to fetch latest version from DockerHub: ${error instanceof Error ? error.message : String(error)}`,
+ );
+ return { currentVersion, latestVersion: null };
}
}
}