Skip to content

The open alternative to Salesforce, designed for AI.

chore: remove low-value long comments (#24125)

Charles Bochet80901be36121
diff --git a/packages/twenty-emails/src/utils/email-renderer/renderers/render-mark.tsx b/packages/twenty-emails/src/utils/email-renderer/renderers/render-mark.tsx
index 97e6d4d2e82..81f130142c7 100644
--- a/packages/twenty-emails/src/utils/email-renderer/renderers/render-mark.tsx
+++ b/packages/twenty-emails/src/utils/email-renderer/renderers/render-mark.tsx
@@ -28,7 +28,6 @@ export const renderMark = (node: JSONContent): ReactNode => {
const text = node?.text || <>&nbsp;</>;
const marks = [...((node?.marks as TipTapMark[]) || [])];
- // Sort marks according to the defined render order
marks.sort((a, b) => {
return (
TIPTAP_MARKS_RENDER_ORDER.indexOf(a.type) -
@@ -38,7 +37,6 @@ export const renderMark = (node: JSONContent): ReactNode => {
return marks.reduce((children: ReactNode, mark: TipTapMark) => {
if (!isEmailDocumentMarkType(mark.type)) {
- // Fallback for unknown mark types - skip unknown marks
return children;
}
diff --git a/packages/twenty-front/setupTests.ts b/packages/twenty-front/setupTests.ts
index 9b557c44059..4fc4c3798ae 100644
--- a/packages/twenty-front/setupTests.ts
+++ b/packages/twenty-front/setupTests.ts
@@ -50,7 +50,6 @@ if (globalThis.ResizeObserver === undefined) {
ResizeObserverMock as unknown as typeof ResizeObserver;
}
-// Add Jest matchers for toThrowError and other missing methods
declare global {
namespace jest {
interface Matchers<R> {
diff --git a/packages/twenty-front/src/modules/activities/files/components/AttachmentRow.tsx b/packages/twenty-front/src/modules/activities/files/components/AttachmentRow.tsx
index 3d6b1bb0e0b..4b3db811b24 100644
--- a/packages/twenty-front/src/modules/activities/files/components/AttachmentRow.tsx
+++ b/packages/twenty-front/src/modules/activities/files/components/AttachmentRow.tsx
@@ -159,7 +159,6 @@ export const AttachmentRow = ({
return;
}
- // Only prevent default and use preview if onPreview is provided
if (isDefined(onPreview)) {
e.preventDefault();
onPreview(attachment);
diff --git a/packages/twenty-front/src/modules/advanced-text-editor/extensions/resizable-image/ResizableImageView.tsx b/packages/twenty-front/src/modules/advanced-text-editor/extensions/resizable-image/ResizableImageView.tsx
index 0f8a7b6cf05..8cb3ba5e36c 100644
--- a/packages/twenty-front/src/modules/advanced-text-editor/extensions/resizable-image/ResizableImageView.tsx
+++ b/packages/twenty-front/src/modules/advanced-text-editor/extensions/resizable-image/ResizableImageView.tsx
@@ -66,13 +66,11 @@ export const ResizableImageView = (props: ResizableImageViewProps) => {
const imageWrapperRef = useRef<HTMLDivElement>(null);
- // Controls visibility of resize handles when hovering over the image
const [isHovering, setIsHovering] = useState(false);
const [width, setWidth] = useState(initialWidth || 0);
// Controls actual resize operation state (null = not resizing, object = actively resizing)
const [resizeParams, setResizeParams] = useState<ResizeParams | null>(null);
- // Create stable event handlers using a closure approach
const createMouseHandlers = useCallback(() => {
let currentResizeParams: ResizeParams | null = null;
diff --git a/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/DefaultSlashCommands.test.ts b/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/DefaultSlashCommands.test.ts
index 5416b7a2526..780b345ac92 100644
--- a/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/DefaultSlashCommands.test.ts
+++ b/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/DefaultSlashCommands.test.ts
@@ -105,7 +105,6 @@ describe('DefaultSlashCommands', () => {
(cmd) => cmd.id === 'paragraph',
);
- // Paragraph command should have a getIsVisible function
expect(typeof paragraphCommand?.getIsVisible).toBe('function');
expect(typeof paragraphCommand?.getIsVisible(editor)).toBe('boolean');
});
diff --git a/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/SlashCommand.test.ts b/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/SlashCommand.test.ts
index 28a42cae7e0..bb772c3f03f 100644
--- a/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/SlashCommand.test.ts
+++ b/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/SlashCommand.test.ts
@@ -113,14 +113,12 @@ describe('SlashCommand', () => {
describe('Command availability', () => {
it('should allow setting headings when heading extension is present', () => {
- // Editor with heading extension should be able to set headings
expect(editor.can().setHeading({ level: 1 })).toBe(true);
expect(editor.can().setHeading({ level: 2 })).toBe(true);
expect(editor.can().setHeading({ level: 3 })).toBe(true);
});
it('should allow toggling lists when list extension is present', () => {
- // Editor with list extension should be able to toggle lists
expect(editor.can().toggleBulletList()).toBe(true);
expect(editor.can().toggleOrderedList()).toBe(true);
});
diff --git a/packages/twenty-front/src/modules/ai/components/__stories__/AiChatMessage.stories.tsx b/packages/twenty-front/src/modules/ai/components/__stories__/AiChatMessage.stories.tsx
index 09d6f12c5ce..f965c35b47d 100644
--- a/packages/twenty-front/src/modules/ai/components/__stories__/AiChatMessage.stories.tsx
+++ b/packages/twenty-front/src/modules/ai/components/__stories__/AiChatMessage.stories.tsx
@@ -309,7 +309,6 @@ const meta: Meta<typeof AiChatMessage> = {
export default meta;
type Story = StoryObj<typeof AiChatMessage>;
-// Conversation showcase - demonstrates a full AI chat flow
export const ConversationWithCodeExecution: Story = {
render: () => (
<StyledConversationContainer>
diff --git a/packages/twenty-front/src/modules/ai/components/__stories__/CodeExecutionDisplay.stories.tsx b/packages/twenty-front/src/modules/ai/components/__stories__/CodeExecutionDisplay.stories.tsx
index da27181a750..78dca7bd078 100644
--- a/packages/twenty-front/src/modules/ai/components/__stories__/CodeExecutionDisplay.stories.tsx
+++ b/packages/twenty-front/src/modules/ai/components/__stories__/CodeExecutionDisplay.stories.tsx
@@ -74,7 +74,6 @@ export const Success: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
expect(await canvas.findByText('Completed')).toBeVisible();
- // Output content is inside a scrollable container
expect(await canvas.findByText(/Total Revenue/)).toBeInTheDocument();
},
};
diff --git a/packages/twenty-front/src/modules/apollo/components/ApolloProvider.tsx b/packages/twenty-front/src/modules/apollo/components/ApolloProvider.tsx
index dc57de17e27..d17315433c4 100644
--- a/packages/twenty-front/src/modules/apollo/components/ApolloProvider.tsx
+++ b/packages/twenty-front/src/modules/apollo/components/ApolloProvider.tsx
@@ -16,7 +16,6 @@ export const ApolloProvider = ({ children }: React.PropsWithChildren) => {
extraLinks: [captchaRefreshLink],
});
- // Expose Apollo client in development to Apollo Dev Tools
if (process.env.NODE_ENV === 'development') {
window.__APOLLO_CLIENT__ = apolloClient;
}
diff --git a/packages/twenty-front/src/modules/apollo/utils/__tests__/hasTokenPair.test.ts b/packages/twenty-front/src/modules/apollo/utils/__tests__/hasTokenPair.test.ts
index 930e3dc10f4..28e907bccf9 100644
--- a/packages/twenty-front/src/modules/apollo/utils/__tests__/hasTokenPair.test.ts
+++ b/packages/twenty-front/src/modules/apollo/utils/__tests__/hasTokenPair.test.ts
@@ -114,7 +114,6 @@ describe('hasTokenPair', () => {
});
it('should not perform additional validation beyond getTokenPair', () => {
- // This test ensures hasTokenPair doesn't duplicate validation logic
const tokenPair = {
accessOrWorkspaceAgnosticToken: {
token: 'any-token-that-getTokenPair-considers-valid',
@@ -130,7 +129,6 @@ describe('hasTokenPair', () => {
const result = hasTokenPair();
expect(result).toBe(true);
- // Should only call getTokenPair once, no additional validation
expect(mockGetTokenPair).toHaveBeenCalledTimes(1);
});
});
diff --git a/packages/twenty-front/src/modules/domain-manager/hooks/useGetPublicWorkspaceDataByDomain.ts b/packages/twenty-front/src/modules/domain-manager/hooks/useGetPublicWorkspaceDataByDomain.ts
index 25664633814..5f42003460d 100644
--- a/packages/twenty-front/src/modules/domain-manager/hooks/useGetPublicWorkspaceDataByDomain.ts
+++ b/packages/twenty-front/src/modules/domain-manager/hooks/useGetPublicWorkspaceDataByDomain.ts
@@ -64,7 +64,6 @@ export const useGetPublicWorkspaceDataByDomain = () => {
useEffect(() => {
if (error) {
- // Only redirect to default domain if it's a workspace not found error
if (CombinedGraphQLErrors.is(error)) {
const isWorkspaceNotFoundError = error.errors?.some(
(graphQLError) => graphQLError.extensions?.code === 'NOT_FOUND',
diff --git a/packages/twenty-front/src/modules/geo-map/components/__tests__/PlaceAutocompleteSelect.test.tsx b/packages/twenty-front/src/modules/geo-map/components/__tests__/PlaceAutocompleteSelect.test.tsx
index da974946041..eeb30285dca 100644
--- a/packages/twenty-front/src/modules/geo-map/components/__tests__/PlaceAutocompleteSelect.test.tsx
+++ b/packages/twenty-front/src/modules/geo-map/components/__tests__/PlaceAutocompleteSelect.test.tsx
@@ -3,7 +3,6 @@ import { type PlaceAutocompleteResult } from '@/geo-map/types/placeApi';
describe('PlaceAutocompleteSelect Component', () => {
describe('component interface', () => {
it('should have correct prop types', () => {
- // Test that the component accepts the expected props
const mockProps = {
list: [] as PlaceAutocompleteResult[],
onChange: jest.fn(),
@@ -151,7 +150,6 @@ describe('PlaceAutocompleteSelect Component', () => {
describe('component requirements', () => {
it('should require all mandatory props', () => {
- // Test that all required props are defined in the interface
const requiredProps = ['list', 'onChange', 'dropdownId'];
requiredProps.forEach((prop) => {
diff --git a/packages/twenty-front/src/modules/geo-map/constants/__tests__/selectAutocompleteListDropDownId.test.ts b/packages/twenty-front/src/modules/geo-map/constants/__tests__/selectAutocompleteListDropDownId.test.ts
index 38c7dd5be34..e5836289681 100644
--- a/packages/twenty-front/src/modules/geo-map/constants/__tests__/selectAutocompleteListDropDownId.test.ts
+++ b/packages/twenty-front/src/modules/geo-map/constants/__tests__/selectAutocompleteListDropDownId.test.ts
@@ -20,14 +20,12 @@ describe('selectAutocompleteListDropDownId', () => {
});
it('should be a valid HTML ID', () => {
- // HTML IDs should not contain spaces or special characters except hyphens
expect(SELECT_AUTOCOMPLETE_LIST_DROPDOWN_ID).toMatch(
/^[a-zA-Z][a-zA-Z0-9-]*$/,
);
});
it('should be immutable', () => {
- // This test ensures the constant cannot be reassigned
const originalValue = SELECT_AUTOCOMPLETE_LIST_DROPDOWN_ID;
expect(SELECT_AUTOCOMPLETE_LIST_DROPDOWN_ID).toBe(originalValue);
});
diff --git a/packages/twenty-front/src/modules/geo-map/types/__tests__/placeApi.test.ts b/packages/twenty-front/src/modules/geo-map/types/__tests__/placeApi.test.ts
index 16cf286fe7d..6966db3e055 100644
--- a/packages/twenty-front/src/modules/geo-map/types/__tests__/placeApi.test.ts
+++ b/packages/twenty-front/src/modules/geo-map/types/__tests__/placeApi.test.ts
@@ -63,7 +63,6 @@ describe('placeApi types', () => {
});
it('should enforce string types for required fields', () => {
- // This test ensures TypeScript compilation catches type errors
const variables: PlaceAutocompleteVariables = {
address: 'Test Address',
token: 'test-token',
@@ -259,7 +258,6 @@ describe('placeApi types', () => {
isFieldCity: false,
};
- // This should be compatible with PlaceAutocompleteVariables structure
expect(queryVariables.address).toBe('Test');
expect(queryVariables.token).toBe('token');
});
diff --git a/packages/twenty-front/src/modules/localization/hooks/useFormatPreferences.ts b/packages/twenty-front/src/modules/localization/hooks/useFormatPreferences.ts
index 867491f93bf..ebd5c63e360 100644
--- a/packages/twenty-front/src/modules/localization/hooks/useFormatPreferences.ts
+++ b/packages/twenty-front/src/modules/localization/hooks/useFormatPreferences.ts
@@ -42,7 +42,6 @@ export const useFormatPreferences = () => {
return;
}
- // Handle system values by detecting the actual format
let resolvedValue = value;
if (
value === 'SYSTEM' ||
diff --git a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts
index 35f3a3603e1..2c50bfc1840 100644
--- a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts
+++ b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts
@@ -108,7 +108,6 @@ describe('detectCalendarStartDay', () => {
});
it('should handle Intl.Locale throwing error', () => {
- // This test uses the default mock that throws an error
Object.defineProperty(navigator, 'language', {
writable: true,
value: 'de-DE',
diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/dnd/hooks/useNavigationMenuItemDndKit.ts b/packages/twenty-front/src/modules/navigation-menu-item/display/dnd/hooks/useNavigationMenuItemDndKit.ts
index 631e0d77350..69a9f1e90f7 100644
--- a/packages/twenty-front/src/modules/navigation-menu-item/display/dnd/hooks/useNavigationMenuItemDndKit.ts
+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/dnd/hooks/useNavigationMenuItemDndKit.ts
@@ -219,7 +219,6 @@ export const useNavigationMenuItemDndKit = (
return;
}
- // Branch 2: sortable-to-droppable-slot (includes insert-before zones)
if (resolved !== null && sourceIsSortable) {
setActiveDropTargetId(resolved.effectiveDropTargetId);
setAddToNavigationFallbackDestination(resolved.destination);
@@ -278,7 +277,6 @@ export const useNavigationMenuItemDndKit = (
const targetIsSortable = target !== null && isSortable(target);
const resolved = resolveDropTarget(target, getNavItemById, sectionType);
- // Workspace fast path: sortable-to-sortable within workspace
if (
isWorkspaceSection &&
sourceIsSortable &&
diff --git a/packages/twenty-front/src/modules/object-metadata/utils/__tests__/getOrderByForRelationField.test.ts b/packages/twenty-front/src/modules/object-metadata/utils/__tests__/getOrderByForRelationField.test.ts
index 02cb22d35c4..90ffe68230b 100644
--- a/packages/twenty-front/src/modules/object-metadata/utils/__tests__/getOrderByForRelationField.test.ts
+++ b/packages/twenty-front/src/modules/object-metadata/utils/__tests__/getOrderByForRelationField.test.ts
@@ -29,7 +29,6 @@ describe('getOrderByForRelationField', () => {
orderByDirection: 'AscNullsLast',
});
- // Should produce nested structure: { company: { name: 'AscNullsLast' } }
expect(result).toEqual([{ company: { name: 'AscNullsLast' } }]);
});
diff --git a/packages/twenty-front/src/modules/object-record/graphql/record-gql-fields/utils/generateJunctionRelationGqlFields.ts b/packages/twenty-front/src/modules/object-record/graphql/record-gql-fields/utils/generateJunctionRelationGqlFields.ts
index b9bcbfae256..0ca9c755027 100644
--- a/packages/twenty-front/src/modules/object-record/graphql/record-gql-fields/utils/generateJunctionRelationGqlFields.ts
+++ b/packages/twenty-front/src/modules/object-record/graphql/record-gql-fields/utils/generateJunctionRelationGqlFields.ts
@@ -82,7 +82,6 @@ const buildTargetFieldGqlFields = (
return buildRegularTargetFieldGqlFields(targetField, objectMetadataItems);
};
-// Generates GraphQL fields for a junction relation, including the nested target objects
export const generateJunctionRelationGqlFields = ({
fieldMetadataItem,
objectMetadataItems,
diff --git a/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/__tests__/turnSortsIntoOrderBy.test.ts b/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/__tests__/turnSortsIntoOrderBy.test.ts
index 54561071fea..cb24128ce74 100644
--- a/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/__tests__/turnSortsIntoOrderBy.test.ts
+++ b/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/__tests__/turnSortsIntoOrderBy.test.ts
@@ -280,7 +280,6 @@ describe('turnSortsIntoOrderBy', () => {
companyObjectMetadataItem,
]);
- // Should produce nested structure for GraphQL: { company: { name: 'AscNullsFirst' } }
expect(result).toEqual([
{ company: { name: 'AscNullsFirst' } },
{ position: 'AscNullsFirst' },
@@ -300,7 +299,6 @@ describe('turnSortsIntoOrderBy', () => {
companyObjectMetadataItem,
]);
- // Should produce nested structure for GraphQL: { company: { name: 'DescNullsLast' } }
expect(result).toEqual([
{ company: { name: 'DescNullsLast' } },
{ position: 'AscNullsFirst' },
@@ -316,7 +314,6 @@ describe('turnSortsIntoOrderBy', () => {
},
];
- // Pass empty objectMetadataItems array - related object not found
const result = turnSortsIntoOrderBy(personObjectMetadataItem, sorts, []);
expect(result).toEqual([
diff --git a/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/turnSortsIntoOrderBy.ts b/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/turnSortsIntoOrderBy.ts
index eb6cc74bc2e..c9765b74265 100644
--- a/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/turnSortsIntoOrderBy.ts
+++ b/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/turnSortsIntoOrderBy.ts
@@ -41,7 +41,6 @@ export const turnSortsIntoOrderBy = (
? 'AscNullsFirst'
: 'DescNullsLast';
- // Handle RELATION fields by looking up related object metadata
if (correspondingField.type === FieldMetadataType.RELATION) {
const relatedObjectName =
correspondingField.relation?.targetObjectMetadata?.nameSingular;
diff --git a/packages/twenty-front/src/modules/object-record/record-field-list/utils/categorizeRelationFields.ts b/packages/twenty-front/src/modules/object-record/record-field-list/utils/categorizeRelationFields.ts
index 796e7387ec5..e900740aa81 100644
--- a/packages/twenty-front/src/modules/object-record/record-field-list/utils/categorizeRelationFields.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field-list/utils/categorizeRelationFields.ts
@@ -75,13 +75,11 @@ export const categorizeRelationFields = ({
const boxedRelationFields: FieldMetadataItem[] = [];
for (const field of relationFields) {
- // Activity targets are always rendered with ActivityTargetsInlineCell
if (isActivityTargetRelation(field, objectNameSingular)) {
activityTargetFields.push(field);
continue;
}
- // Junction relations (when feature enabled) are rendered inline with other fields
if (isJunctionRelationsEnabled && isJunctionRelationField(field)) {
inlineRelationFields.push(field);
junctionRelationFields.push(field);
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormLinksFieldInput.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormLinksFieldInput.tsx
index 5b3833a5ce1..ea181cf79e4 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormLinksFieldInput.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormLinksFieldInput.tsx
@@ -31,7 +31,6 @@ export const FormLinksFieldInput = ({
primaryLinkUrl: defaultValue?.primaryLinkUrl ?? '',
[field]: updatedLinksPart,
};
- // We need to validate the links and display an error message if the links are not valid
onChange(updatedLinks);
};
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormSingleRecordPicker.stories.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormSingleRecordPicker.stories.tsx
index 2eb6cc3fef3..7d539fada76 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormSingleRecordPicker.stories.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormSingleRecordPicker.stories.tsx
@@ -90,7 +90,6 @@ export const Disabled: Story = {
const dropdown = canvas.queryByRole('button');
expect(dropdown).not.toBeInTheDocument();
- // Variable picker should not be visible when disabled
const variablePicker = canvas.queryByText('VariablePicker');
expect(variablePicker).not.toBeInTheDocument();
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/hooks/useTextVariableEditor.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/hooks/useTextVariableEditor.ts
index 83813b8a241..89b6827f616 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/hooks/useTextVariableEditor.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/hooks/useTextVariableEditor.ts
@@ -70,7 +70,6 @@ export const useTextVariableEditor = ({
if (event.key === 'Enter' && !event.shiftKey) {
event.preventDefault();
- // Insert hard break using the view's state and dispatch
if (multiline === true) {
const { state } = view;
const { tr } = state;
@@ -91,7 +90,6 @@ export const useTextVariableEditor = ({
state: { schema, tr },
} = view;
- // Format pasted JSON content with pretty-printing
if (isJsonObject(plainText)) {
const parsedJson = parseJson<JsonValue>(plainText);
const formattedJson = multiline
@@ -109,7 +107,6 @@ export const useTextVariableEditor = ({
return true;
}
- // In multiline mode, convert newlines to hardBreak nodes
if (multiline && plainText.includes('\n')) {
const docNode = schema.nodeFromJSON(
getInitialEditorContent(plainText),
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/hooks/useOpenFieldInputEditMode.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/hooks/useOpenFieldInputEditMode.ts
index aecaf945ed7..dd3bc2ea63a 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/hooks/useOpenFieldInputEditMode.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/hooks/useOpenFieldInputEditMode.ts
@@ -87,7 +87,6 @@ export const useOpenFieldInputEditMode = () => {
fieldDefinition.metadata.settings,
);
- // Handle Files field with custom behavior for empty state
if (isFieldFiles(fieldDefinition)) {
const objectMetadataItem = objectMetadataItems.find(
(item) =>
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/__stories__/LinksFieldInput.stories.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/__stories__/LinksFieldInput.stories.tsx
index d3116267d52..cb6c51a50e5 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/__stories__/LinksFieldInput.stories.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/__stories__/LinksFieldInput.stories.tsx
@@ -589,7 +589,6 @@ export const CanNotSetPrimaryLinkAsPrimaryLink: Story = {
});
await userEvent.click(openDropdownButton);
- // Should not see "Set as Primary" option for primary link
const setPrimaryOption = within(
canvasElement.ownerDocument.body,
).queryByText('Set as Primary');
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/isFieldValueEmpty.test.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/isFieldValueEmpty.test.ts
index 26873bdecd9..0a96696db5b 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/isFieldValueEmpty.test.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/isFieldValueEmpty.test.ts
@@ -194,7 +194,6 @@ describe('isFieldValueEmpty', () => {
}),
).toBe(true);
- // Multiple secondary links with mix of valid and invalid
expect(
isFieldValueEmpty({
fieldDefinition: linksFieldDefinition,
diff --git a/packages/twenty-front/src/modules/object-record/record-group/hooks/useSetRecordGroups.ts b/packages/twenty-front/src/modules/object-record/record-group/hooks/useSetRecordGroups.ts
index 464764e3121..b12386f8a46 100644
--- a/packages/twenty-front/src/modules/object-record/record-group/hooks/useSetRecordGroups.ts
+++ b/packages/twenty-front/src/modules/object-record/record-group/hooks/useSetRecordGroups.ts
@@ -56,7 +56,6 @@ export const useSetRecordGroups = () => {
});
const currentFieldMetadata = store.get(recordIndexGroupFieldMetadata);
- // Set the field metadata linked to the record groups
if (!isDeeplyEqual(fieldMetadata, currentFieldMetadata)) {
store.set(recordIndexGroupFieldMetadata, fieldMetadata);
}
@@ -78,12 +77,10 @@ export const useSetRecordGroups = () => {
const recordGroupIds = recordGroups.map(({ id }) => id);
- // Get ids that has been removed between the current and new record groups
const removedRecordGroupIds = currentRecordGroupIds.filter(
(id) => !recordGroupIds.includes(id),
);
- // Remove the record groups that has been removed
removedRecordGroupIds.forEach((id) => {
store.set(recordGroupDefinitionFamilyState.atomFamily(id), undefined);
});
diff --git a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldInput.tsx b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldInput.tsx
index 7327fd40012..a7fd3ce3f8f 100644
--- a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldInput.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldInput.tsx
@@ -50,7 +50,6 @@ export const RecordTitleCellTextFieldInput = ({
});
const handleFocus = (event: React.FocusEvent<HTMLInputElement>) => {
- // Ensure draft value is set from field value if it's undefined or empty when focusing
if (isDefined(draftValue)) {
event.target.select();
}
diff --git a/packages/twenty-front/src/modules/page-layout/hooks/useResolveFieldMetadataIdFromNameOrId.ts b/packages/twenty-front/src/modules/page-layout/hooks/useResolveFieldMetadataIdFromNameOrId.ts
index 5edf7be86d6..5b130d3e50e 100644
--- a/packages/twenty-front/src/modules/page-layout/hooks/useResolveFieldMetadataIdFromNameOrId.ts
+++ b/packages/twenty-front/src/modules/page-layout/hooks/useResolveFieldMetadataIdFromNameOrId.ts
@@ -20,7 +20,6 @@ export const useResolveFieldMetadataIdFromNameOrId = (
return fieldByName.id;
}
- // If not found by name, check if it's already an ID
const fieldById = objectMetadataItem.fields.find(
(field) => field.id === fieldMetadataIdOrName,
);
diff --git a/packages/twenty-front/src/modules/page-layout/utils/__tests__/prepareGridLayoutItemsWithPlaceholders.test.ts b/packages/twenty-front/src/modules/page-layout/utils/__tests__/prepareGridLayoutItemsWithPlaceholders.test.ts
index 0478b2950da..4d0583f6767 100644
--- a/packages/twenty-front/src/modules/page-layout/utils/__tests__/prepareGridLayoutItemsWithPlaceholders.test.ts
+++ b/packages/twenty-front/src/modules/page-layout/utils/__tests__/prepareGridLayoutItemsWithPlaceholders.test.ts
@@ -157,7 +157,6 @@ describe('prepareGridLayoutItemsWithPlaceholders', () => {
const result = prepareGridLayoutItemsWithPlaceholders(widgets, true);
expect(result).toHaveLength(6);
- // Check that the last item is the pending placeholder
const lastItem = result[result.length - 1];
expect(lastItem).toEqual({
id: PENDING_WIDGET_PLACEHOLDER_LAYOUT_KEY,
diff --git a/packages/twenty-front/src/modules/page-layout/utils/resolveBeforeTabId.ts b/packages/twenty-front/src/modules/page-layout/utils/resolveBeforeTabId.ts
index c855686e114..6283191a04f 100644
--- a/packages/twenty-front/src/modules/page-layout/utils/resolveBeforeTabId.ts
+++ b/packages/twenty-front/src/modules/page-layout/utils/resolveBeforeTabId.ts
@@ -7,7 +7,6 @@ import { resolveDropFromPointer } from '@/ui/utilities/drag-and-drop/utils/resol
type DragEndEvent = DragDropProviderDragEndEvent<PageLayoutWidgetDndData>;
-// Resolves the tab a dragged tab should be inserted before.
export const resolveBeforeTabId = (
event: DragEndEvent,
targetData: PageLayoutWidgetDndData,
diff --git a/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx b/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx
index 536ad0e8e3c..61acaa11872 100644
--- a/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx
+++ b/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx
@@ -1010,7 +1010,6 @@ export const WithManyToOneRelationFieldWidget: Story = {
recordStoreFamilyState.atomFamily(TEST_RECORD_ID),
mockCompanyRecord,
);
- // Set the related WorkspaceMember record for relation field display
if (
mockCompanyRecord.accountOwner !== null &&
mockCompanyRecord.accountOwner !== undefined
@@ -1252,7 +1251,6 @@ export const OneToManyRelationFieldWidgetWithSeeAllButton: Story = {
recordStoreFamilyState.atomFamily(TEST_PERSON_RECORD_ID),
mockPersonRecord,
);
- // Set hover state to make the "See all" button visible
jotaiStore.set(
widgetCardHoveredComponentFamilyState.atomFamily({
instanceId: PAGE_LAYOUT_TEST_INSTANCE_ID,
@@ -1306,7 +1304,6 @@ export const OneToManyRelationFieldWidgetWithSeeAllButton: Story = {
expect(seeAllLink).toBeVisible();
- // Verify it has a well-formed link (should contain the filter query params)
expect(seeAllLink).toHaveAttribute('href');
const href = seeAllLink.getAttribute('href');
expect(href).toContain('/objects/people');
@@ -1658,7 +1655,6 @@ export const Catalog: CatalogStory<Story, typeof WidgetRenderer> = {
);
}
- // currentUserWorkspaceState is now a Jotai state, set it directly
if (isRestricted === true) {
jotaiStore.set(currentUserWorkspaceState.atom, {
permissionFlags: [],
diff --git a/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx b/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx
index 0e20805e4e2..4597a72bfab 100644
--- a/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx
+++ b/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx
@@ -37,7 +37,6 @@ export const SettingsDataModelFieldRelationJunctionForm = ({
const currentSettings = watch('settings');
const junctionTargetFieldId = currentSettings?.junctionTargetFieldId;
- // Only applies to ONE_TO_MANY with single target
if (
!isAdvancedModeEnabled ||
relationType !== RelationType.ONE_TO_MANY ||
@@ -82,7 +81,6 @@ export const SettingsDataModelFieldRelationJunctionForm = ({
}
});
- // Add regular MANY_TO_ONE relations (not pointing back to source)
junctionObjectMetadataItem.fields
.filter((field) => {
if (
diff --git a/packages/twenty-front/src/modules/settings/data-model/fields/forms/select/components/SettingsDataModelFieldSelectForm.tsx b/packages/twenty-front/src/modules/settings/data-model/fields/forms/select/components/SettingsDataModelFieldSelectForm.tsx
index 194593e120c..211dfe7f613 100644
--- a/packages/twenty-front/src/modules/settings/data-model/fields/forms/select/components/SettingsDataModelFieldSelectForm.tsx
+++ b/packages/twenty-front/src/modules/settings/data-model/fields/forms/select/components/SettingsDataModelFieldSelectForm.tsx
@@ -460,7 +460,6 @@ export const SettingsDataModelFieldSelectForm = ({
);
onChange(nextOptions);
- // Update option value in defaultValue if value has changed
if (
nextOption.value !== option.value &&
isOptionDefaultValue(option.value)
diff --git a/packages/twenty-front/src/modules/settings/data-model/fields/preview/hooks/usePreviewRecord.ts b/packages/twenty-front/src/modules/settings/data-model/fields/preview/hooks/usePreviewRecord.ts
index 90d0feef87f..71dd7ab1232 100644
--- a/packages/twenty-front/src/modules/settings/data-model/fields/preview/hooks/usePreviewRecord.ts
+++ b/packages/twenty-front/src/modules/settings/data-model/fields/preview/hooks/usePreviewRecord.ts
@@ -61,6 +61,5 @@ export const usePreviewRecord = ({
[labelIdentifierFieldMetadataItem.name]: fieldPreviewValue,
};
- // If no record was found, or if the label identifier field value is empty, display a placeholder record
return placeholderRecord;
};
diff --git a/packages/twenty-front/src/modules/settings/developers/hooks/__tests__/useWebhookForm.test.tsx b/packages/twenty-front/src/modules/settings/developers/hooks/__tests__/useWebhookForm.test.tsx
index 910bb0aca27..52c12f96e58 100644
--- a/packages/twenty-front/src/modules/settings/developers/hooks/__tests__/useWebhookForm.test.tsx
+++ b/packages/twenty-front/src/modules/settings/developers/hooks/__tests__/useWebhookForm.test.tsx
@@ -505,7 +505,6 @@ describe('useWebhookForm', () => {
{ wrapper: ({ children }) => <Wrapper>{children}</Wrapper> },
);
- // Initially canSave should be false (form is not valid)
expect(result.current.canSave).toBe(false);
});
});
diff --git a/packages/twenty-front/src/modules/settings/mcp-and-apis/states/playgroundApiKeyState.ts b/packages/twenty-front/src/modules/settings/mcp-and-apis/states/playgroundApiKeyState.ts
index 9483a46b015..2c98afa4339 100644
--- a/packages/twenty-front/src/modules/settings/mcp-and-apis/states/playgroundApiKeyState.ts
+++ b/packages/twenty-front/src/modules/settings/mcp-and-apis/states/playgroundApiKeyState.ts
@@ -8,7 +8,6 @@ export const playgroundApiKeyState = createAtomState<AuthToken | null>({
defaultValue: null,
});
-// Returns true when the token is still valid `bufferMs` from now.
export const isPlaygroundApiKeyFresh = (
token: AuthToken | null,
bufferMs = 0,
diff --git a/packages/twenty-front/src/modules/settings/workspace/components/NameField.tsx b/packages/twenty-front/src/modules/settings/workspace/components/NameField.tsx
index 5cf86e0b9ad..7fb007c1915 100644
--- a/packages/twenty-front/src/modules/settings/workspace/components/NameField.tsx
+++ b/packages/twenty-front/src/modules/settings/workspace/components/NameField.tsx
@@ -47,7 +47,6 @@ export const NameField = ({
const debouncedUpdate = useCallback(
useDebouncedCallback(async (name: string) => {
if (isEmpty(name)) return;
- // update local state when workspace name is updated
setCurrentWorkspace((currentValue) => {
if (currentValue === null) {
return null;
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/__mocks__/mockRsiValues.ts b/packages/twenty-front/src/modules/spreadsheet-import/__mocks__/mockRsiValues.ts
index b5c7fc81c41..c2fe0aeb337 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/__mocks__/mockRsiValues.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/__mocks__/mockRsiValues.ts
@@ -157,7 +157,6 @@ export const mockRsiValues = mockComponentBehaviourForTypes({
importedRows: data,
};
},
- // Runs after column matching and on entry change, more performant
matchColumnsStepHook: async (data) => {
await sleep(4000, (resolve) => resolve(data));
return data;
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts
index e2a6825cf3a..f9ec6c12034 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts
@@ -9,7 +9,6 @@ import { type SpreadsheetImportTableHook } from '@/spreadsheet-import/types/Spre
import { type SpreadsheetImportStep } from '@/spreadsheet-import/steps/types/SpreadsheetImportStep';
export type SpreadsheetImportDialogOptions = {
- // callback when RSI is closed before final submit
onClose: () => void;
spreadsheetImportFields: SpreadsheetImportFields;
// Runs after file upload step, receives and returns raw sheet data
@@ -33,13 +32,11 @@ export type SpreadsheetImportDialogOptions = {
validationResult: SpreadsheetImportImportValidationResult,
file: File,
) => Promise<void>;
- // Function called when user aborts the importing flow
onAbortSubmit?: () => void;
// Allows submitting with errors. Default: true
allowInvalidSubmit?: boolean;
// Theme configuration passed to underlying Chakra-UI
customTheme?: object;
- // Specifies maximum number of rows for a single import
maxRecords?: number;
maxFileSize?: number;
// Automatically map imported headers to specified fields if possible. Default: true
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/utils/__tests__/csvSecurity.test.ts b/packages/twenty-front/src/modules/spreadsheet-import/utils/__tests__/csvSecurity.test.ts
index a3b56e33894..6792ca5e518 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/utils/__tests__/csvSecurity.test.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/utils/__tests__/csvSecurity.test.ts
@@ -204,7 +204,6 @@ describe('csvSecurity', () => {
japaneseTexts.forEach((text) => {
const sanitized = sanitizeValueForCSVExport(text);
- // Should remain unchanged (no dangerous characters at start)
expect(sanitized).toBe(text);
expect(containsCSVProtectionZWJ(sanitized)).toBe(false);
});
@@ -287,7 +286,6 @@ describe('csvSecurity', () => {
const sanitized = sanitizeValueForCSVExport(text);
const restored = cleanZWJFromImportedValue(sanitized);
- // Should be sanitized (starts with dangerous character)
expect(sanitized).toBe(CSV_INJECTION_PREVENTION_ZWJ + text);
expect(containsCSVProtectionZWJ(sanitized)).toBe(true);
@@ -307,10 +305,8 @@ describe('csvSecurity', () => {
unicodeTexts.forEach((text) => {
const sanitized = sanitizeValueForCSVExport(text);
- // Should remain unchanged (no dangerous ASCII characters at start)
expect(sanitized).toBe(text);
- // Should not add our protection ZWJ (unless already present in emoji sequences)
if (!text.includes('\u200D')) {
expect(containsCSVProtectionZWJ(sanitized)).toBe(false);
}
@@ -320,7 +316,6 @@ describe('csvSecurity', () => {
describe('CSV import integration', () => {
it('should work with the mapWorkbook import process', () => {
- // Simulate data that would come from a CSV export with ZWJ protection
const exportedData = [
['Name', 'Formula', 'Phone'],
[
diff --git a/packages/twenty-front/src/modules/ui/input/components/SelectInput.tsx b/packages/twenty-front/src/modules/ui/input/components/SelectInput.tsx
index 2cb3b4352e9..bff6eecfb1f 100644
--- a/packages/twenty-front/src/modules/ui/input/components/SelectInput.tsx
+++ b/packages/twenty-front/src/modules/ui/input/components/SelectInput.tsx
@@ -41,7 +41,6 @@ export const SelectInput = ({
}: SelectInputProps) => {
const containerRef = useRef<HTMLDivElement>(null);
- // Get the SelectableList instance id from context
const selectableListInstanceId = useAvailableComponentInstanceIdOrThrow(
SelectableListComponentInstanceContext,
);
diff --git a/packages/twenty-front/src/modules/ui/input/components/internal/date/components/__stories__/DateTimePicker.stories.tsx b/packages/twenty-front/src/modules/ui/input/components/internal/date/components/__stories__/DateTimePicker.stories.tsx
index ac69752af80..f1b9de3505c 100644
--- a/packages/twenty-front/src/modules/ui/input/components/internal/date/components/__stories__/DateTimePicker.stories.tsx
+++ b/packages/twenty-front/src/modules/ui/input/components/internal/date/components/__stories__/DateTimePicker.stories.tsx
@@ -63,7 +63,6 @@ export const WithOpenMonthSelect: Story = {
const canvas = within(canvasElement);
const body = within(canvasElement.ownerDocument.body);
- // Wait for date picker to load and click calendar icon to open month/year selector
const calendarButton = await canvas.findByRole(
'button',
{ name: 'Select month and year' },
@@ -105,7 +104,6 @@ export const WithOpenYearSelect: Story = {
const canvas = within(canvasElement);
const body = within(canvasElement.ownerDocument.body);
- // Wait for date picker to load and click calendar icon to open month/year selector
const calendarButton = await canvas.findByRole(
'button',
{ name: 'Select month and year' },
diff --git a/packages/twenty-front/src/modules/ui/suggestion/components/__tests__/createSuggestionRenderLifecycle.test.ts b/packages/twenty-front/src/modules/ui/suggestion/components/__tests__/createSuggestionRenderLifecycle.test.ts
index 1f1a3e78b1c..39e45f2adc4 100644
--- a/packages/twenty-front/src/modules/ui/suggestion/components/__tests__/createSuggestionRenderLifecycle.test.ts
+++ b/packages/twenty-front/src/modules/ui/suggestion/components/__tests__/createSuggestionRenderLifecycle.test.ts
@@ -169,7 +169,6 @@ describe('createSuggestionRenderLifecycle', () => {
lifecycle.onStart(createMockCallbackProps({ command: originalCommand }));
- // Extract the onSelect callback from the props passed to ReactRenderer
const { ReactRenderer } = jest.requireMock('@tiptap/react');
const constructorCall = ReactRenderer.mock.calls[0];
const menuProps = constructorCall[1].props;
diff --git a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx
index 1c83f519e0d..800ed17c3bf 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx
+++ b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx
@@ -127,7 +127,6 @@ export const ReadonlyMode: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
- // In readonly mode, variables should still be displayed
expect(await canvas.findByText('user.id')).toBeVisible();
expect(await canvas.findByText('auth.token')).toBeVisible();
},
@@ -211,7 +210,6 @@ export const ComplexNestedVariables: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
- // Should have 10 input fields for all the nested variables
const inputs = canvas.getAllByRole('textbox');
expect(inputs).toHaveLength(10);
diff --git a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/hooks/__tests__/useTestHttpRequest.test.ts b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/hooks/__tests__/useTestHttpRequest.test.ts
index 08fb0001c58..fc053b45d46 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/hooks/__tests__/useTestHttpRequest.test.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/hooks/__tests__/useTestHttpRequest.test.ts
@@ -18,7 +18,6 @@ jest.mock('@/object-metadata/hooks/useApolloCoreClient', () => ({
jest.mock('twenty-shared/utils', () => ({
...jest.requireActual('twenty-shared/utils'),
resolveInput: jest.fn((input, context) => {
- // For testing purposes, we'll actually do the replacement for simple cases
if (typeof input === 'string') {
return input.replace(/{{([^}]+)}}/g, (match, path) => {
const parts = path.split('.');
@@ -343,7 +342,6 @@ describe('useTestHttpRequest', () => {
);
});
- // The mocked resolveInput should have been called with nested context
expect(resolveInput).toHaveBeenCalledWith('https://api.example.com/users', {
auth: { token: 'test-token-123' },
trigger: { properties: { after: { name: 'Yo' } } },
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/__tests__/getMonthsDescription.test.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/__tests__/getMonthsDescription.test.ts
index 1ae4233a19a..8531d187786 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/__tests__/getMonthsDescription.test.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/__tests__/getMonthsDescription.test.ts
@@ -70,7 +70,6 @@ describe('getMonthsDescription', () => {
// Note: These tests would need a mock locale catalog to test properly
// For now, we test that the function doesn't crash with locale
it('should handle locale catalog without crashing', () => {
- // Create a proper mock locale with the required properties for date-fns
const mockLocale = {
localize: {
month: () => 'MockMonth',
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/describeCronExpression.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/describeCronExpression.ts
index c2e94fc47a7..f5f9e381ed3 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/describeCronExpression.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/describeCronExpression.ts
@@ -46,7 +46,6 @@ export const describeCronExpression = (
descriptions.push(minutesDescription);
}
if (isDefined(hoursDescription) && hoursDescription !== '') {
- // Remove "at" prefix from hours description when combining
const cleanHoursDesc = hoursDescription.replace(/^at\s+/, '');
descriptions.push(cleanHoursDesc);
}
@@ -103,7 +102,6 @@ export const describeCronExpression = (
if (descriptions.length === 0) {
return t`every minute`;
}
- // Simple joining - just use spaces, no commas for cleaner descriptions
return descriptions.join(' ');
} catch (error) {
const errorMessage =
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/utils/parseCronExpression.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/utils/parseCronExpression.ts
index 60c338ac3ba..91639201bd6 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/utils/parseCronExpression.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/utils/parseCronExpression.ts
@@ -25,7 +25,6 @@ export const parseCronExpression = (
try {
CronExpressionParser.parse(normalized, { tz: 'UTC' });
- // Handle different cron formats that cron-parser accepts
if (parts.length === 4) {
// Reduced format: hour day month dayOfWeek (minute defaults to 0)
return {
diff --git a/packages/twenty-front/src/pages/settings/__stories__/SettingsWorkspaceMembers.stories.tsx b/packages/twenty-front/src/pages/settings/__stories__/SettingsWorkspaceMembers.stories.tsx
index abb27616a9e..ffd918f4832 100644
--- a/packages/twenty-front/src/pages/settings/__stories__/SettingsWorkspaceMembers.stories.tsx
+++ b/packages/twenty-front/src/pages/settings/__stories__/SettingsWorkspaceMembers.stories.tsx
@@ -1,4 +1,3 @@
-// TEMP_DISABLED_TEST: Removed unused imports due to commented test
import { type Meta, type StoryObj } from '@storybook/react-vite';
import {
diff --git a/packages/twenty-front/src/pages/settings/applications/utils/isNewerSemver.ts b/packages/twenty-front/src/pages/settings/applications/utils/isNewerSemver.ts
index a0677dcc0ba..b199d9fffea 100644
--- a/packages/twenty-front/src/pages/settings/applications/utils/isNewerSemver.ts
+++ b/packages/twenty-front/src/pages/settings/applications/utils/isNewerSemver.ts
@@ -1,4 +1,3 @@
-// Returns true if versionA is strictly greater than versionB (major.minor.patch)
export const isNewerSemver = (versionA: string, versionB: string): boolean => {
const partsA = versionA.split('.').map(Number);
const partsB = versionB.split('.').map(Number);
diff --git a/packages/twenty-front/src/pages/settings/developers/__stories__/api-keys/SettingsDevelopersApiKeysNew.stories.tsx b/packages/twenty-front/src/pages/settings/developers/__stories__/api-keys/SettingsDevelopersApiKeysNew.stories.tsx
index 6798b799c85..4835795d77d 100644
--- a/packages/twenty-front/src/pages/settings/developers/__stories__/api-keys/SettingsDevelopersApiKeysNew.stories.tsx
+++ b/packages/twenty-front/src/pages/settings/developers/__stories__/api-keys/SettingsDevelopersApiKeysNew.stories.tsx
@@ -1,6 +1,5 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { SettingsPath } from 'twenty-shared/types';
-// TEMP_DISABLED_TEST: Removed unused imports due to commented test
import { getSettingsPath } from 'twenty-shared/utils';
import { SettingsDevelopersApiKeysNew } from '~/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew';
diff --git a/packages/twenty-front/src/pages/settings/developers/playground/SettingsGraphQLPlayground.tsx b/packages/twenty-front/src/pages/settings/developers/playground/SettingsGraphQLPlayground.tsx
index dc1e047409b..d7e54ca7ddb 100644
--- a/packages/twenty-front/src/pages/settings/developers/playground/SettingsGraphQLPlayground.tsx
+++ b/packages/twenty-front/src/pages/settings/developers/playground/SettingsGraphQLPlayground.tsx
@@ -13,7 +13,6 @@ export const SettingsGraphQLPlayground = () => {
const navigateSettings = useNavigateSettings();
const { schema: urlSchema = 'core' } = useParams<{ schema: string }>();
- // Convert lowercase URL parameter to PlaygroundSchemas enum
const schema =
urlSchema === 'metadata'
? PlaygroundSchemas.METADATA
diff --git a/packages/twenty-front/src/testing/mock-data/users.ts b/packages/twenty-front/src/testing/mock-data/users.ts
index 97d338372dd..2dcee9302ef 100644
--- a/packages/twenty-front/src/testing/mock-data/users.ts
+++ b/packages/twenty-front/src/testing/mock-data/users.ts
@@ -48,7 +48,6 @@ export const avatarUrl =
export const workspaceLogoUrl =
'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAACXBIWXMAAA7EAAAOxAGVKw4bAAACb0lEQVR4nO2VO4taQRTHr3AblbjxEVlwCwVhg7BoqqCIjy/gAyyFWNlYBOxsfH0KuxgQGwXRUkGuL2S7i1barGAgiwbdW93SnGOc4BonPiKahf3DwXFmuP/fPM4ZlvmlTxAhCBdzHnEQWYiv7Mr4C3NeuVYhQYDPzOUUQgDLBQGcLHNhvQK8DACPx8PTxiqVyvISG43GbyaT6Qfpn06n0m63e/tPAPF4vJ1MJu8kEsnWTCkWi1yr1RKGw+GDRqPBOTfr44vFQvD7/Q/lcpmaaVQAr9fLp1IpO22c47hGOBz+MB6PH+Vy+VYDAL8qlUoGtVotzOfzq4MAgsHgE/6KojiQyWR/bKVSqbSszHFM8Pl8z1YK48JsNltCOBwOnrYLO+8AAIjb+nHbycoTiUQfDJ7tFq4YAHiVSmXBxcD41u8flQU8z7fhzO0r83atVns3Go3u9Xr9x0O/RQXo9/tsIBBg6vX606a52Wz+bZ7P5/WwG29gxSJzhKgA6XTaDoFNF+krFAocmC//4yWEcSf2wTm7mCO19xFgSsKOLI16vV7b7XY7mRNoLwA0JymJ5uQIzgIAuX5PzDElT2m+E8BqtQ4ymcx7Yq7T6a6ZE4sKgOadTucaCwkxp1UzlEKh0GDxIXOwDWHAdi6Xe3swQDQa/Q7mywoolUpvsaptymazDWKxmBHTlWXZm405BFZoNpuGgwEmk4mE2SGtVivii4f1AO7J3ZopkQCQj7Ar1FeRChCJRJzVapX6DKNIfSc1Ax+wtQWQ55h6bH8FWDfYV4fO3wlwDr0C/BcADYiTPCxHqIEA2QsCZAkAKnRGkMbKN/sTX5YHPQ1e7SkAAAAASUVORK5CYII=';
-// Extract Pro monthly base product from mockBillingPlans to use in workspace billing mocks
const PRO_PLAN = mockBillingPlans.listPlans.find((p) => p.planKey === 'PRO')!;
const PRO_BASE_LICENSED_PRODUCT = PRO_PLAN?.baseProducts?.[0]!;
const PRO_BASE_MONTHLY_PRICE = PRO_BASE_LICENSED_PRODUCT?.prices?.find(
diff --git a/packages/twenty-front/src/utils/__tests__/date-utils.test.ts b/packages/twenty-front/src/utils/__tests__/date-utils.test.ts
index 82bc870d75f..29388f9f6e5 100644
--- a/packages/twenty-front/src/utils/__tests__/date-utils.test.ts
+++ b/packages/twenty-front/src/utils/__tests__/date-utils.test.ts
@@ -354,7 +354,6 @@ describe('French locale tests', () => {
const date = '2025-01-05T00:00:00.000Z';
const dateToCompareWith = '2024-01-01T00:00:00.000Z';
const result = beautifyDateDiff(date, dateToCompareWith, false, fr);
- // Should use date-fns which handles French properly
expect(result).toBeTruthy();
expect(result.length).toBeGreaterThan(0);
});
diff --git a/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts b/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts
index 69150891dba..83caa9ed9d9 100644
--- a/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts
+++ b/packages/twenty-front/src/utils/__tests__/getDirtyFields.spec.ts
@@ -62,14 +62,12 @@ describe('getDirtyFields', () => {
it('should detect fields set to undefined', () => {
const draft = { a: 1, b: undefined };
const persisted = { a: 1, b: 2 };
- // Cast persisted to any to satisfy TS in this test scenario
expect(getDirtyFields(draft, persisted as any)).toEqual({ b: undefined });
});
it('should detect fields set to null', () => {
const draft = { a: 1, b: null };
const persisted = { a: 1, b: 2 };
- // Cast persisted to any to satisfy TS in this test scenario
expect(getDirtyFields(draft, persisted as any)).toEqual({ b: null });
});
@@ -94,7 +92,6 @@ describe('getDirtyFields', () => {
},
archived: true, // removed
};
- // Cast persisted to any to satisfy TS in this test scenario
expect(getDirtyFields(draft, persisted as any)).toEqual({
name: 'new name',
details: {
diff --git a/packages/twenty-front/src/utils/date-utils.ts b/packages/twenty-front/src/utils/date-utils.ts
index fe1f6aecf70..46fb11ec959 100644
--- a/packages/twenty-front/src/utils/date-utils.ts
+++ b/packages/twenty-front/src/utils/date-utils.ts
@@ -99,7 +99,6 @@ export const beautifyPastDateRelativeToNow = (
(now.getTime() - parsedDate.getTime()) / 1000,
);
- // For very recent times (less than 30 seconds), show "now"
if (diffInSeconds < 30) {
return t`now`;
}
@@ -169,19 +168,16 @@ export const beautifyDateDiff = (
short = false,
locale?: Locale,
) => {
- // For simple cases, use date-fns which has excellent locale support
if (!short && isDefined(locale)) {
const fromDate = new Date(date);
const toDate = dateToCompareWith ? new Date(dateToCompareWith) : new Date();
return formatDistance(fromDate, toDate, { locale });
}
- // Manual implementation for complex cases or when locale is not available
const fromDate = parseISO(date);
const toDate = dateToCompareWith ? parseISO(dateToCompareWith) : new Date();
const years = differenceInYears(fromDate, toDate);
- // Calculate remaining days after accounting for full years
const startDateForDayCalculation = new Date(toDate);
startDateForDayCalculation.setFullYear(
startDateForDayCalculation.getFullYear() + years,
diff --git a/packages/twenty-front/vite.config.ts b/packages/twenty-front/vite.config.ts
index 6e08b2dae0b..9ff93efa9ad 100644
--- a/packages/twenty-front/vite.config.ts
+++ b/packages/twenty-front/vite.config.ts
@@ -181,7 +181,6 @@ export default defineConfig(({ mode }) => {
// including this one we wasted a lot of time on:
// https://github.com/rollup/rollup/issues/2793
output: {
- // Custom plugin to fail build if chunks exceed max size
plugins: [
{
name: 'chunk-size-limit',
diff --git a/packages/twenty-server/@types/jest.d.ts b/packages/twenty-server/@types/jest.d.ts
index d476966d046..38954c3a655 100644
--- a/packages/twenty-server/@types/jest.d.ts
+++ b/packages/twenty-server/@types/jest.d.ts
@@ -31,7 +31,6 @@ declare global {
const API_KEY_ACCESS_TOKEN: string;
const APPLE_SARAH_IMPERSONATE_TIM_INVALID_ACCESS_TOKEN: string;
- // Additional global properties set during test setup
var testDataSource: DataSource;
var app: INestApplication;
var dataSourceService: DataSourceService;
diff --git a/packages/twenty-server/src/app.module.ts b/packages/twenty-server/src/app.module.ts
index e64f2625696..b68ccc3e4df 100644
--- a/packages/twenty-server/src/app.module.ts
+++ b/packages/twenty-server/src/app.module.ts
@@ -64,7 +64,6 @@ const MIGRATED_REST_METHODS = [
GlobalWorkspaceDataSourceModule,
ClickHouseModule,
CoreEngineModule,
- // Modules module, contains all business logic modules
ModulesModule,
// Needed for the user workspace middleware
WorkspaceCacheStorageModule,
@@ -92,8 +91,6 @@ export class AppModule {
const modules: DynamicModule[] = [];
const frontPath = join(__dirname, 'front');
- // NestJS DevTools - can be useful for debugging and profiling
-
if (existsSync(frontPath)) {
modules.push(
ServeStaticModule.forRoot({
diff --git a/packages/twenty-server/src/database/clickHouse/clickHouse.service.ts b/packages/twenty-server/src/database/clickHouse/clickHouse.service.ts
index 0ba36b6c017..f5fe0829956 100644
--- a/packages/twenty-server/src/database/clickHouse/clickHouse.service.ts
+++ b/packages/twenty-server/src/database/clickHouse/clickHouse.service.ts
@@ -51,7 +51,6 @@ export class ClickHouseService implements OnModuleInit, OnModuleDestroy {
return undefined;
}
- // Wait for a bit before trying again if another initialization is in progress
while (this.isClientInitializing.get(clientId)) {
await new Promise((resolve) => setTimeout(resolve, 10));
}
diff --git a/packages/twenty-server/src/database/clickHouse/migrations/run-migrations.ts b/packages/twenty-server/src/database/clickHouse/migrations/run-migrations.ts
index 18786bf4d0a..244f07911fd 100644
--- a/packages/twenty-server/src/database/clickHouse/migrations/run-migrations.ts
+++ b/packages/twenty-server/src/database/clickHouse/migrations/run-migrations.ts
@@ -104,7 +104,6 @@ async function runMigrations() {
console.log(`⚡ Running ${file}...`);
- // Split by semicolons and filter out empty statements/comments
const statements = sql
.split(';')
.map((stmt) => stmt.trim())
diff --git a/packages/twenty-server/src/database/clickHouse/seeds/fixtures.ts b/packages/twenty-server/src/database/clickHouse/seeds/fixtures.ts
index 77fdece5d42..4ddcec9aac0 100644
--- a/packages/twenty-server/src/database/clickHouse/seeds/fixtures.ts
+++ b/packages/twenty-server/src/database/clickHouse/seeds/fixtures.ts
@@ -180,7 +180,6 @@ const buildUsageEventFixtures = (): UsageEventFixture[] => {
const userWeight = userWeights[userIdx];
for (const op of operations) {
- // Skip some user/operation combos randomly for variety
if (nextRandom() < 0.25) {
continue;
}
diff --git a/packages/twenty-server/src/database/scripts/truncate-db.ts b/packages/twenty-server/src/database/scripts/truncate-db.ts
index fbd7566f47e..002f87f4a0d 100644
--- a/packages/twenty-server/src/database/scripts/truncate-db.ts
+++ b/packages/twenty-server/src/database/scripts/truncate-db.ts
@@ -6,7 +6,6 @@ async function dropSchemasSequentially() {
try {
await rawDataSource.initialize();
- // Fetch all schemas excluding the ones we want to keep
const schemas =
(await performQuery<{ schema_name: string }[]>(
`
diff --git a/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1761749599736-workspace-id-uuid-not-nullable.ts b/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1761749599736-workspace-id-uuid-not-nullable.ts
index 2549826861b..f14e7b1076e 100644
--- a/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1761749599736-workspace-id-uuid-not-nullable.ts
+++ b/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1761749599736-workspace-id-uuid-not-nullable.ts
@@ -4,7 +4,6 @@ export class WorkspaceIdUuidNotNullable1761749599736 implements MigrationInterfa
name = 'WorkspaceIdUuidNotNullable1761749599736';
public async up(queryRunner: QueryRunner): Promise<void> {
- // Delete orphaned rows without workspaceId before migration
await queryRunner.query(
`DELETE FROM "core"."indexMetadata" WHERE "workspaceId" IS NULL`,
);
@@ -19,7 +18,6 @@ export class WorkspaceIdUuidNotNullable1761749599736 implements MigrationInterfa
`ALTER TABLE "core"."indexMetadata" DROP CONSTRAINT "IDX_INDEX_METADATA_NAME_WORKSPACE_ID_OBJECT_METADATA_ID_UNIQUE"`,
);
- // Convert column type from varchar to uuid while preserving data
await queryRunner.query(
`ALTER TABLE "core"."indexMetadata" ALTER COLUMN "workspaceId" TYPE uuid USING "workspaceId"::uuid`,
);
@@ -49,7 +47,6 @@ export class WorkspaceIdUuidNotNullable1761749599736 implements MigrationInterfa
`DROP INDEX "core"."IDX_b27c681286ac581f81498c5d4b"`,
);
- // Convert column type from uuid back to varchar while preserving data
await queryRunner.query(
`ALTER TABLE "core"."indexMetadata" ALTER COLUMN "workspaceId" DROP NOT NULL`,
);
diff --git a/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1772267875869-add-workspace-id-to-application-registration.ts b/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1772267875869-add-workspace-id-to-application-registration.ts
index 2654f96514c..0d78d231ccc 100644
--- a/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1772267875869-add-workspace-id-to-application-registration.ts
+++ b/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1772267875869-add-workspace-id-to-application-registration.ts
@@ -8,7 +8,6 @@ export class AddWorkspaceIdToApplicationRegistration1772267875869 implements Mig
`ALTER TABLE "core"."applicationRegistration" ADD "workspaceId" uuid`,
);
- // Delete any orphaned registrations that can't be assigned a workspace
await queryRunner.query(`
DELETE FROM "core"."applicationRegistration"
WHERE "workspaceId" IS NULL
diff --git a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser.ts b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser.ts
index 0e9ef8bba35..23fe9c13d78 100644
--- a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser.ts
+++ b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser.ts
@@ -200,7 +200,6 @@ export class GraphqlQueryParser {
? `"${parts[0]}"."${parts[1]}"`
: `"${orderByField}"`;
- // Build column expression with optional ::text cast and LOWER()
let columnExpr = quotedColumn;
if (orderByCondition.castToText) {
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/utils/parse-result.util.ts b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/utils/parse-result.util.ts
index e7a147c5346..06cab54be9a 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/utils/parse-result.util.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/utils/parse-result.util.ts
@@ -12,7 +12,6 @@ export const handleCompositeKey = (
): void => {
const parsedFieldKey = parseCompositeFieldKey(key);
- // If composite field key can't be parsed, return
if (!parsedFieldKey) {
return;
}
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/workspace-query-hook.service.ts b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/workspace-query-hook.service.ts
index e8546670592..fb738f02421 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/workspace-query-hook.service.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/workspace-query-hook.service.ts
@@ -38,7 +38,6 @@ export class WorkspaceQueryHookService {
}
for (const preHookInstance of preHookInstances) {
- // Deep merge all return of handleHook into payload before returning it
const hookPayload = await this.workspaceQueryHookExplorer.handlePreHook(
[authContext, objectName, payload],
preHookInstance.instance,
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts
index df89421cff9..2c901079df2 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts
@@ -74,7 +74,6 @@ export class ObjectMetadataWithRelationsGqlObjectTypeGenerator {
const config = gqlType.toConfig();
- // Recreate the same object type with the new fields
this.gqlTypesStorage.addGqlType(
key,
new GraphQLObjectType({
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/utils/clean-entity-name.util.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/utils/clean-entity-name.util.ts
index 0534984475a..6be1bea32cc 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/utils/clean-entity-name.util.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/utils/clean-entity-name.util.ts
@@ -7,7 +7,6 @@ export const cleanEntityName = (entityName: string) => {
camelCasedEntityName = camelCase(camelCasedEntityName);
- // Remove all special characters but keep alphabets and numbers
camelCasedEntityName = camelCasedEntityName.replace(/[^a-zA-Z0-9]/g, '');
return camelCasedEntityName;
diff --git a/packages/twenty-server/src/engine/api/mcp/controllers/__tests__/mcp-core.controller.spec.ts b/packages/twenty-server/src/engine/api/mcp/controllers/__tests__/mcp-core.controller.spec.ts
index a5f64deb7cc..f8eaafdd84f 100644
--- a/packages/twenty-server/src/engine/api/mcp/controllers/__tests__/mcp-core.controller.spec.ts
+++ b/packages/twenty-server/src/engine/api/mcp/controllers/__tests__/mcp-core.controller.spec.ts
@@ -310,7 +310,6 @@ describe('McpCoreController', () => {
mockRes,
);
- // SSE path returns nothing — response is written directly
expect(result).toBeUndefined();
expect(mockRes.setHeader).toHaveBeenCalledWith(
'Content-Type',
@@ -332,7 +331,6 @@ describe('McpCoreController', () => {
`event: message\ndata: ${JSON.stringify(mockResponse)}\n\n`,
);
expect(mockRes.end).toHaveBeenCalled();
- // sseWriter callback should be passed to protocol service
expect(mcpProtocolService.handleMCPCoreQuery).toHaveBeenCalledWith(
mockRequest,
{
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/worker.health.spec.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/worker.health.spec.ts
index 400aa70ea81..28b62f38930 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/worker.health.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/worker.health.spec.ts
@@ -70,7 +70,6 @@ describe('WorkerHealthIndicator', () => {
.mockImplementation(() => {});
jest.useFakeTimers();
- // Reset mocks to their default success state before each test
mockQueueInstance.getWorkers.mockResolvedValue([]);
mockQueueInstance.getMetrics.mockResolvedValue({ count: 0, data: [] });
mockQueueInstance.getWaitingCount.mockResolvedValue(0);
@@ -242,7 +241,6 @@ describe('WorkerHealthIndicator', () => {
describe('getQueueDetails', () => {
beforeEach(() => {
- // Reset mocks to clean state before each test in this describe block
mockQueueInstance.getWorkers.mockResolvedValue([{ id: 'worker1' }]);
mockQueueInstance.getMetrics.mockResolvedValue({ count: 0, data: [] });
});
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/enums/job-state.enum.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/enums/job-state.enum.ts
index 6429e6acbf3..ae313b4fa79 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/enums/job-state.enum.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/enums/job-state.enum.ts
@@ -17,7 +17,6 @@ registerEnumType(JobStateEnum, {
description: 'Job state in the queue',
});
-// Mapping from GraphQL enum to BullMQ state values
export const jobStateEnumToBullMQ: Record<JobStateEnum, BullMQJobState> = {
[JobStateEnum.COMPLETED]: 'completed',
[JobStateEnum.FAILED]: 'failed',
@@ -28,7 +27,6 @@ export const jobStateEnumToBullMQ: Record<JobStateEnum, BullMQJobState> = {
[JobStateEnum.WAITING_CHILDREN]: 'waiting-children',
};
-// Mapping from BullMQ state values to GraphQL enum
export const bullMQToJobStateEnum: Record<BullMQJobState, JobStateEnum> = {
completed: JobStateEnum.COMPLETED,
failed: JobStateEnum.FAILED,
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/indicators/connected-account.health.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/indicators/connected-account.health.ts
index 7a1ef818ced..1a69aaebe60 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/indicators/connected-account.health.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/indicators/connected-account.health.ts
@@ -34,7 +34,6 @@ export class ConnectedAccountHealth {
);
const failedJobs = counters.FAILED_UNKNOWN || 0;
- // + (counters.FAILED_INSUFFICIENT_PERMISSIONS || 0)
const failureRate =
totalJobs > 0
@@ -83,7 +82,6 @@ export class ConnectedAccountHealth {
);
const failedJobs = counters.FAILED_UNKNOWN || 0;
- // + (counters.FAILED_INSUFFICIENT_PERMISSIONS || 0)
const failureRate =
totalJobs > 0
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-oauth/controllers/oauth-registration.controller.ts b/packages/twenty-server/src/engine/core-modules/application/application-oauth/controllers/oauth-registration.controller.ts
index 9146150ba6f..1cdb8d31d7f 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-oauth/controllers/oauth-registration.controller.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-oauth/controllers/oauth-registration.controller.ts
@@ -136,7 +136,6 @@ export class OAuthRegistrationController {
};
}
- // Parse and validate scopes — cap to allowed scopes
const validScopes: readonly string[] = ALL_OAUTH_SCOPES;
const requestedScopes = body.scope
? body.scope.split(' ').filter((s) => validScopes.includes(s))
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-oauth/oauth.service.ts b/packages/twenty-server/src/engine/core-modules/application/application-oauth/oauth.service.ts
index 41b2fff5f3a..eb23b082362 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-oauth/oauth.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-oauth/oauth.service.ts
@@ -544,7 +544,6 @@ export class OAuthService {
iat: decoded.iat,
};
} catch {
- // Try as access token (with signature verification)
try {
const payload =
await this.applicationTokenService.validateApplicationAccessToken(
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-oauth/stale-registration-cleanup/services/stale-registration-cleanup.service.ts b/packages/twenty-server/src/engine/core-modules/application/application-oauth/stale-registration-cleanup/services/stale-registration-cleanup.service.ts
index 6a50107b355..74d30215521 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-oauth/stale-registration-cleanup/services/stale-registration-cleanup.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-oauth/stale-registration-cleanup/services/stale-registration-cleanup.service.ts
@@ -43,7 +43,6 @@ export class StaleRegistrationCleanupService {
(registration) => registration.id,
);
- // Filter out registrations that have active (non-deleted) installations
const registrationsWithInstallations = await this.applicationRepository
.createQueryBuilder('application')
.select('application.applicationRegistrationId')
diff --git a/packages/twenty-server/src/engine/core-modules/application/connection-provider/connections/dtos/list-app-connections.dto.ts b/packages/twenty-server/src/engine/core-modules/application/connection-provider/connections/dtos/list-app-connections.dto.ts
index d100b421b6b..a3276b6212b 100644
--- a/packages/twenty-server/src/engine/core-modules/application/connection-provider/connections/dtos/list-app-connections.dto.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/connection-provider/connections/dtos/list-app-connections.dto.ts
@@ -11,7 +11,6 @@ export class ListAppConnectionsDto {
@IsOptional()
userWorkspaceId?: string;
- // Optional visibility filter — narrow to 'user' or 'workspace' only.
@IsString()
@IsOptional()
visibility?: 'user' | 'workspace';
diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/auth.service.ts b/packages/twenty-server/src/engine/core-modules/auth/services/auth.service.ts
index 19715dcab00..1d59f08afea 100644
--- a/packages/twenty-server/src/engine/core-modules/auth/services/auth.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/auth/services/auth.service.ts
@@ -583,7 +583,6 @@ export class AuthService {
}
}
- // Validate requested scopes are a subset of the registration's allowed scopes
const parsedScopes = authorizeAppInput.scope
? authorizeAppInput.scope.split(' ').filter(Boolean)
: [];
@@ -703,7 +702,6 @@ export class AuthService {
passwordHash: newPasswordHash,
});
- // Invalidate all existing refresh tokens for this user across all workspaces
await this.appTokenRepository.update(
{
userId,
diff --git a/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/__tests__/transform-stripe-subscription-event-to-database-customer.util.spec.ts b/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/__tests__/transform-stripe-subscription-event-to-database-customer.util.spec.ts
index 64eff234406..2dece774771 100644
--- a/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/__tests__/transform-stripe-subscription-event-to-database-customer.util.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/__tests__/transform-stripe-subscription-event-to-database-customer.util.spec.ts
@@ -54,7 +54,6 @@ describe('transformStripeSubscriptionEventToDatabaseCustomer', () => {
it('should work with different subscription event types', () => {
const mockData = createMockSubscriptionData('cus_123');
- // Test with different event types (they should all transform the same way)
['updated', 'created', 'deleted'].forEach(() => {
const result = transformStripeSubscriptionEventToDatabaseCustomer(
mockWorkspaceId,
diff --git a/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/transform-stripe-subscription-event-to-database-subscription.util.ts b/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/transform-stripe-subscription-event-to-database-subscription.util.ts
index 5abbf97bace..2a3e994ba35 100644
--- a/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/transform-stripe-subscription-event-to-database-subscription.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/billing-webhook/utils/transform-stripe-subscription-event-to-database-subscription.util.ts
@@ -36,7 +36,6 @@ const toAutomaticTaxJson = (
};
};
-// Converts Stripe CancellationDetails to serialized JSON for JSONB storage
const toCancellationDetailsJson = (
value: Stripe.Subscription.CancellationDetails | null | undefined,
): CancellationDetailsJson | undefined => {
diff --git a/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts b/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts
index 14858f7bd7b..38de45bafd5 100644
--- a/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts
@@ -193,7 +193,6 @@ export class TimelineCalendarEventService {
)?.id ?? null)
: null;
- // Find which connected accounts the current user owns (1 query)
const connectedAccountIds = [
...new Set(
calendarChannels.map((channel) => channel.connectedAccountId),
diff --git a/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/utils/__test__/is-subdomain-valid.util.spec.ts b/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/utils/__test__/is-subdomain-valid.util.spec.ts
index 720da574270..8aca66468b8 100644
--- a/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/utils/__test__/is-subdomain-valid.util.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/utils/__test__/is-subdomain-valid.util.spec.ts
@@ -304,7 +304,6 @@ describe('isSubdomainValid', () => {
});
it('should validate that reserved subdomains check is case insensitive', () => {
- // Test mixed case variations of reserved subdomains
expect(isSubdomainValid('Trust')).toBe(false);
expect(isSubdomainValid('TRUST')).toBe(false);
expect(isSubdomainValid('tRuSt')).toBe(false);
@@ -314,7 +313,6 @@ describe('isSubdomainValid', () => {
});
it('should accept valid subdomains that are similar to reserved ones but not exact matches', () => {
- // 'testing' is reserved, but 'testing123' is not
expect(isSubdomainValid('testing123')).toBe(true);
expect(isSubdomainValid('myapi')).toBe(true);
expect(isSubdomainValid('adminpanel')).toBe(true);
@@ -338,12 +336,10 @@ describe('isSubdomainValid', () => {
describe('pattern validation specifics', () => {
it('should enforce the exact regex pattern requirements', () => {
- // Test that the pattern requires alphanumeric start and end
expect(isSubdomainValid('a-b')).toBe(true);
expect(isSubdomainValid('1-2')).toBe(true);
expect(isSubdomainValid('test-123')).toBe(true);
- // Test that it rejects patterns not matching the regex
expect(isSubdomainValid('-ab')).toBe(false);
expect(isSubdomainValid('ab-')).toBe(false);
});
diff --git a/packages/twenty-server/src/engine/core-modules/event-emitter/utils/object-record-diff-merge.ts b/packages/twenty-server/src/engine/core-modules/event-emitter/utils/object-record-diff-merge.ts
index adab01344d1..f913a940c29 100644
--- a/packages/twenty-server/src/engine/core-modules/event-emitter/utils/object-record-diff-merge.ts
+++ b/packages/twenty-server/src/engine/core-modules/event-emitter/utils/object-record-diff-merge.ts
@@ -10,21 +10,17 @@ export function objectRecordDiffMerge(
Object.keys(oldRecord.diff ?? {}).forEach((key) => {
if (newRecord.diff && newRecord.diff[key]) {
- // If the key also exists in the newRecord, merge the 'before' from the oldRecord and the 'after' from the newRecord
result.diff[key] = {
before: oldRecord.diff[key].before,
after: newRecord.diff[key].after,
};
} else {
- // If the key does not exist in the newRecord, copy it as is from the oldRecord
result.diff[key] = oldRecord.diff[key];
}
});
- // Iterate over the keys in the newRecord diff to catch any that weren't in the oldRecord
Object.keys(newRecord.diff ?? {}).forEach((key) => {
if (!result.diff[key]) {
- // If the key was not already added from the oldRecord, add it from the newRecord
result.diff[key] = newRecord.diff[key];
}
});
diff --git a/packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts b/packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts
index 4403ebec039..71d2d33de92 100644
--- a/packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts
+++ b/packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts
@@ -120,7 +120,6 @@ export const useGraphQLErrorHandlerHook = <
return;
}
- // Step 1: Process errors - extract original errors and convert to BaseGraphQLError
const processedErrors = result.errors.map((error) => {
const originalError = error.originalError || error;
@@ -184,7 +183,6 @@ export const useGraphQLErrorHandlerHook = <
}
});
- // Step 2: Send errors to monitoring service (with stack traces)
const errorsToCapture = processedErrors.filter(
shouldCaptureException,
);
@@ -212,7 +210,6 @@ export const useGraphQLErrorHandlerHook = <
});
}
- // Step 3: Transform errors for GraphQL response (clean GraphQL errors)
const userLocale = args.contextValue.req.locale ?? SOURCE_LOCALE;
const i18n = options.i18nService.getI18nInstance(userLocale);
const defaultErrorMessage = msg`An error occurred.`;
diff --git a/packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts b/packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts
index 3e719183084..072c774b9e0 100644
--- a/packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts
+++ b/packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts
@@ -201,7 +201,6 @@ const computeSchemaComponent = ({
const withRequiredFields = !forResponse && !forUpdate;
- // Create a temporary object that looks like ObjectMetadataEntity for the converter
const tempItem = {
...item,
fields: flatFieldMetadatas,
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/services/update-record.service.ts b/packages/twenty-server/src/engine/core-modules/record-crud/services/update-record.service.ts
index e8ac275addc..cdaec0be9c1 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/services/update-record.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/services/update-record.service.ts
@@ -74,7 +74,6 @@ export class UpdateRecordService {
};
}
- // Filter objectRecord to only include fieldsToUpdate
const filteredObjectRecord = Object.keys(objectRecord).reduce(
(acc, key) => {
if (fieldsToUpdateArray.includes(key)) {
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/utils/get-record-display-name.util.ts b/packages/twenty-server/src/engine/core-modules/record-crud/utils/get-record-display-name.util.ts
index c85934850dc..d699bee3e18 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/utils/get-record-display-name.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/utils/get-record-display-name.util.ts
@@ -29,7 +29,6 @@ export const getRecordDisplayName = (
const fieldValue = record[labelIdentifierField.name];
- // Handle FULL_NAME composite type (person, workspaceMember)
if (labelIdentifierField.type === FieldMetadataType.FULL_NAME) {
const nameValue = fieldValue as
| { firstName?: string; lastName?: string }
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/utils/remove-undefined-from-record.util.ts b/packages/twenty-server/src/engine/core-modules/record-crud/utils/remove-undefined-from-record.util.ts
index 94026a67829..056fae931eb 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/utils/remove-undefined-from-record.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/utils/remove-undefined-from-record.util.ts
@@ -19,7 +19,6 @@ export const removeUndefinedFromRecord = <T extends Record<string, unknown>>(
value as Record<string, unknown>,
);
- // Only include the nested object if it has at least one defined property
if (Object.keys(cleaned).length > 0) {
result[key] = cleaned;
}
diff --git a/packages/twenty-server/src/engine/core-modules/record-crud/utils/to-tool-json-schema.util.ts b/packages/twenty-server/src/engine/core-modules/record-crud/utils/to-tool-json-schema.util.ts
index d1643b7b6fc..77adc6e49fd 100644
--- a/packages/twenty-server/src/engine/core-modules/record-crud/utils/to-tool-json-schema.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-crud/utils/to-tool-json-schema.util.ts
@@ -1,6 +1,5 @@
import { z } from 'zod';
-// Converts a Zod schema to a lean JSON Schema for LLM tool optimised consumption.
export const toToolJsonSchema = (schema: z.ZodTypeAny): object => {
const result = z.toJSONSchema(schema, {
io: 'input',
diff --git a/packages/twenty-server/src/engine/core-modules/secret-encryption/branded-strings/__tests__/extract-encrypted-columns.type-test.ts b/packages/twenty-server/src/engine/core-modules/secret-encryption/branded-strings/__tests__/extract-encrypted-columns.type-test.ts
index e1a284a58d9..51544229ddd 100644
--- a/packages/twenty-server/src/engine/core-modules/secret-encryption/branded-strings/__tests__/extract-encrypted-columns.type-test.ts
+++ b/packages/twenty-server/src/engine/core-modules/secret-encryption/branded-strings/__tests__/extract-encrypted-columns.type-test.ts
@@ -25,7 +25,6 @@ class FakeRelatedEntity extends WorkspaceRelatedEntity {
}
type TestedRecord = {
- // Non-EncryptedString fields - must NOT be extracted
plainString: string;
plainStringNullable: string | null;
plainNumber: number;
@@ -41,7 +40,6 @@ type TestedRecord = {
recordWithoutEncryption: { host: string; port: number };
arrayOfPlaintextRecords: Array<{ host: string }>;
- // Direct EncryptedString fields - MUST be extracted
encryptedRequired: EncryptedString;
encryptedNullable: EncryptedString | null;
encryptedUndefinable: EncryptedString | undefined;
@@ -50,7 +48,6 @@ type TestedRecord = {
encryptedUnionWithPrimitive: EncryptedString | string;
encryptedUnionWithPlaintext: EncryptedString | PlaintextString;
- // Nested EncryptedString — MUST be extracted (transitive structural)
connectionParametersLike: EncryptedConnectionParametersLike;
connectionParametersLikeNullable: EncryptedConnectionParametersLike | null;
arrayOfRecordsWithEncrypted: Array<{ secret: EncryptedString }>;
@@ -89,12 +86,10 @@ type Assertions = [
Expect<Equal<ExtractEncryptedColumns<EmptyObject>, never>>,
- // Object with no EncryptedString fields returns never
Expect<
Equal<ExtractEncryptedColumns<{ a: string; b: number; c: '' }>, never>
>,
- // Object with only PlaintextString fields returns never (brands don't cross)
Expect<
Equal<
ExtractEncryptedColumns<{
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-registry.service.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-registry.service.ts
index 6f034e4b845..9e29859db71 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-registry.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-registry.service.ts
@@ -101,7 +101,6 @@ export class ToolRegistryService {
return schemas;
}
- // Hydrate ToolDescriptor[] into an AI SDK ToolSet with thin dispatch closures
hydrateToolSet(
descriptors: ToolDescriptor[],
context: ToolProviderContext,
diff --git a/packages/twenty-server/src/engine/core-modules/user-workspace/guards/upload-profile-picture-permission.guard.ts b/packages/twenty-server/src/engine/core-modules/user-workspace/guards/upload-profile-picture-permission.guard.ts
index 84b02674962..87bd3c740fa 100644
--- a/packages/twenty-server/src/engine/core-modules/user-workspace/guards/upload-profile-picture-permission.guard.ts
+++ b/packages/twenty-server/src/engine/core-modules/user-workspace/guards/upload-profile-picture-permission.guard.ts
@@ -50,7 +50,6 @@ export class UploadProfilePicturePermissionGuard implements CanActivate {
return true;
}
- // Check if user has WORKSPACE_MEMBERS permission (can edit any profile picture)
const hasWorkspaceMembersPermission =
await this.permissionsService.userHasWorkspaceSettingPermission({
userWorkspaceId,
@@ -63,7 +62,6 @@ export class UploadProfilePicturePermissionGuard implements CanActivate {
return true;
}
- // Check if user has PROFILE_INFORMATION permission (can edit their own profile picture)
const hasProfileInformationPermission =
await this.permissionsService.userHasWorkspaceSettingPermission({
userWorkspaceId,
diff --git a/packages/twenty-server/src/engine/core-modules/workspace-invitation/services/workspace-invitation.service.ts b/packages/twenty-server/src/engine/core-modules/workspace-invitation/services/workspace-invitation.service.ts
index 06f62b198e7..accfb991861 100644
--- a/packages/twenty-server/src/engine/core-modules/workspace-invitation/services/workspace-invitation.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/workspace-invitation/services/workspace-invitation.service.ts
@@ -504,7 +504,6 @@ export class WorkspaceInvitationService {
emails: string[],
) {
try {
- //limit invitation sending for specific invite emails
await Promise.all(
emails.map(async (email) => {
await this.throttlerService.tokenBucketThrottleOrThrow(
@@ -520,7 +519,6 @@ export class WorkspaceInvitationService {
}),
);
- //limit invitation sending for a specific workspace
await this.throttlerService.tokenBucketThrottleOrThrow(
`invitation-resending-workspace:throttler:${workspaceId}`,
emails.length,
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/is-workflow-related-object.util.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/is-workflow-related-object.util.ts
index 551cd1f0d31..eb681546cb5 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/is-workflow-related-object.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/is-workflow-related-object.util.ts
@@ -1,6 +1,5 @@
import { STANDARD_OBJECTS } from 'twenty-shared/metadata';
-// All workflow-related standard object IDs that should be filtered out from agent access
const WORKFLOW_STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS = [
STANDARD_OBJECTS.workflow.universalIdentifier,
STANDARD_OBJECTS.workflowRun.universalIdentifier,
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util.ts
index 5ded24dbbd2..84d43a88e00 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util.ts
@@ -102,7 +102,6 @@ export const repairToolCall = async ({
input: JSON.stringify(repairedInput),
};
} catch {
- // If repair fails, return null to let the error propagate
return null;
} finally {
if (billingContext && usage) {
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/chat-system-prompts.const.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/chat-system-prompts.const.ts
index f781e1d7013..a389908dff3 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/chat-system-prompts.const.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/chat-system-prompts.const.ts
@@ -1,4 +1,3 @@
-// System prompts for AI Chat (user-facing conversational interface)
export const CHAT_SYSTEM_PROMPTS = {
BASE: `You are a helpful AI assistant integrated into Twenty, a CRM (similar to Salesforce).
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/utils/infer-model-family.util.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/utils/infer-model-family.util.ts
index 4dd72ad8375..17459fc1b15 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/utils/infer-model-family.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/utils/infer-model-family.util.ts
@@ -1,6 +1,5 @@
import { ModelFamily } from 'src/engine/metadata-modules/ai/ai-models/types/model-family.enum';
-// Maps models.dev provider names to model families.
const NAME_TO_MODEL_FAMILY: Record<string, ModelFamily> = {
openai: ModelFamily.GPT,
anthropic: ModelFamily.CLAUDE,
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/cast-record-typeorm-date-properties-to-string.type-test.ts b/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/cast-record-typeorm-date-properties-to-string.type-test.ts
index 0bd0e001ea8..42b7bb1ce85 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/cast-record-typeorm-date-properties-to-string.type-test.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/cast-record-typeorm-date-properties-to-string.type-test.ts
@@ -8,7 +8,6 @@ type FieldMetadataDateProperties =
// oxlint-disable-next-line unused-imports/no-unused-vars
type Assertions = [
- // FieldMetadataEntity has createdAt and updatedAt Date properties
Expect<
Equal<
FieldMetadataDateProperties,
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/extract-entity-one-to-many-entity-relation-properties.type-test.ts b/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/extract-entity-one-to-many-entity-relation-properties.type-test.ts
index 34b60ef4abb..374a87f71dc 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/extract-entity-one-to-many-entity-relation-properties.type-test.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/extract-entity-one-to-many-entity-relation-properties.type-test.ts
@@ -35,7 +35,6 @@ type Assertions = [
>
>,
- // When filtered by SyncableEntity target, only syncable relations are included
Expect<
Equal<
FieldMetadataOneToManySyncableRelations,
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/types/__tests__/flat-field-metadata.test-type.ts b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/types/__tests__/flat-field-metadata.test-type.ts
index e4deee84db9..504d7563a05 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/types/__tests__/flat-field-metadata.test-type.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/types/__tests__/flat-field-metadata.test-type.ts
@@ -11,7 +11,6 @@ type DefinedRelationIdRecord = {
relationTargetObjectMetadataId: string;
};
-// Non-relation field types have never | null relation IDs
type NotDefinedRelationIdRecord = {
relationTargetFieldMetadataId: never | null;
relationTargetObjectMetadataId: never | null;
@@ -33,7 +32,6 @@ type OneToManyRelationIdArrays = {
// oxlint-disable-next-line unused-imports/no-unused-vars
type RelationIdAssertions = [
- // Non-relation types have undefined relation IDs
Expect<
HasAllProperties<
FlatFieldMetadata<FieldMetadataType.UUID>,
@@ -54,7 +52,6 @@ type RelationIdAssertions = [
>
>,
- // Abstract type has nullable partial relation IDs
Expect<
HasAllProperties<
FlatFieldMetadata,
@@ -69,7 +66,6 @@ type FlatTransformationAssertions = [
Expect<HasAllProperties<FlatFieldMetadata, OneToManyRelationIdArrays>>,
];
-// Any narrowed flatFieldMetadata type should be assignable to non narrowed flatFieldMetadata
type AbstractFlatFieldMetadata = FlatFieldMetadata<FieldMetadataType>;
const _assertion: Record<string, AbstractFlatFieldMetadata> = {
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/recompute-view-groups-on-flat-field-metadata-options-update.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/recompute-view-groups-on-flat-field-metadata-options-update.util.ts
index fdd68bdcef0..1f7c22d0da9 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/recompute-view-groups-on-flat-field-metadata-options-update.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/recompute-view-groups-on-flat-field-metadata-options-update.util.ts
@@ -131,7 +131,6 @@ export const recomputeViewGroupsOnFlatFieldMetadataOptionsUpdate = ({
] ?? 0;
const isVisible = currentVisibleCount < VIEW_GROUP_VISIBLE_OPTIONS_MAX;
- // Increment the count for future iterations if this group will be visible
if (isVisible) {
visibleViewGroupCountByViewUniversalIdentifier[
viewUniversalIdentifier
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/utils/compute-system-view-fields-to-create.util.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/utils/compute-system-view-fields-to-create.util.ts
index 671aa3b0308..64e90abfbc0 100644
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/utils/compute-system-view-fields-to-create.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/utils/compute-system-view-fields-to-create.util.ts
@@ -30,7 +30,6 @@ export const computeSystemViewFieldsToCreate = ({
flatFieldMetadata: field,
labelIdentifierFieldMetadataUniversalIdentifier,
}) &&
- // Exclude label identifier field when requested (e.g., for FIELDS_WIDGET views)
(!excludeLabelIdentifier ||
field.universalIdentifier !==
labelIdentifierFieldMetadataUniversalIdentifier),
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-field-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-field-permission.guard.ts
index 35e39adb10c..20518279cb5 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-field-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-field-permission.guard.ts
@@ -17,7 +17,6 @@ export class CreateViewFieldPermissionGuard implements CanActivate {
let viewId: string | null = null;
- // For GraphQL: extract from args.input or args.inputs
const args = gqlContext.getArgs();
if (typeof args?.input?.viewId === 'string') {
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-group-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-group-permission.guard.ts
index c30c11e7a32..e23e9c474eb 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-group-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-group-permission.guard.ts
@@ -17,7 +17,6 @@ export class CreateViewGroupPermissionGuard implements CanActivate {
let viewId: string | null = null;
- // For GraphQL: extract from args.input or args.inputs
const args = gqlContext.getArgs();
if (typeof args?.input?.viewId === 'string') {
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/services/view-access.service.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/services/view-access.service.ts
index 66a6e496fb0..c0baa0a453f 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/services/view-access.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/services/view-access.service.ts
@@ -88,7 +88,6 @@ export class ViewAccessService {
return true;
}
- // WORKSPACE visibility views require VIEWS permission
const hasPermission = await this.hasViewsPermission(
userWorkspaceId,
workspaceId,
diff --git a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts
index 86fecf415a3..fd6b88aa7d8 100644
--- a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts
@@ -421,7 +421,6 @@ describe('WorkspaceEntityManager', () => {
findColumnWithPropertyPath: jest.fn(),
};
- // Update mockWorkspaceDataSource to include metadata
mockWorkspaceDataSource.getMetadata = jest
.fn()
.mockReturnValue(mockMetadata);
diff --git a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.ts b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.ts
index 9c03db51d63..b46de005f03 100644
--- a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.ts
@@ -705,7 +705,6 @@ export class WorkspaceEntityManager extends EntityManager {
permissionOptions?: PermissionOptions,
selectedColumns: string[] | '*' = '*',
): Promise<UpdateResult> {
- // if user passed empty criteria or empty list of criterias, then throw an error
if (
criteria === undefined ||
criteria === null ||
@@ -756,7 +755,6 @@ export class WorkspaceEntityManager extends EntityManager {
permissionOptions?: PermissionOptions,
selectedColumns: string[] | '*' = '*',
): Promise<UpdateResult> {
- // if user passed empty criteria or empty list of criterias, then throw an error
if (
criteria === undefined ||
criteria === null ||
diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/build-row-level-permission-record-filter.util.ts b/packages/twenty-server/src/engine/twenty-orm/utils/build-row-level-permission-record-filter.util.ts
index f74358bdec0..67703f0a32d 100644
--- a/packages/twenty-server/src/engine/twenty-orm/utils/build-row-level-permission-record-filter.util.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/utils/build-row-level-permission-record-filter.util.ts
@@ -125,7 +125,6 @@ const buildRecordFilterForRole = ({
return null;
}
- // Validate that workspace member enum value is compatible with target field enum options
const isEnumValueCompatible = validateEnumValueCompatibility({
workspaceMemberFieldMetadata,
targetFieldMetadata: fieldMetadata,
diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/format-result.util.ts b/packages/twenty-server/src/engine/twenty-orm/utils/format-result.util.ts
index 746943ef958..3b71726943f 100644
--- a/packages/twenty-server/src/engine/twenty-orm/utils/format-result.util.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/utils/format-result.util.ts
@@ -190,7 +190,6 @@ function formatResultRecursively<T>(
newData[key] = formattedFieldValue;
}
- // After assembling composite fields, handle those with missing required subfields
handleEmptyCompositeFields(
newData,
objectCache.compositeFieldMetadataWithRequiredProperties,
@@ -308,7 +307,6 @@ function getCompositeFieldMetadataMapFromCollection(
if (!compositeType) return [];
- // Map each composite property to a [key, value] pair
return compositeType.properties.map((compositeProperty) => [
computeCompositeColumnName(fieldMetadata.name, compositeProperty),
{
diff --git a/packages/twenty-server/src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository.ts b/packages/twenty-server/src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository.ts
index 11e5be86a86..d5092d652db 100644
--- a/packages/twenty-server/src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository.ts
@@ -264,7 +264,6 @@ export class WorkspaceScopedRepository<T extends WorkspaceScopedEntity> {
return this.repository.createQueryBuilder(alias);
}
- // Returns a wrapper bound to the given EntityManager (transactions).
withManager(manager: EntityManager): WorkspaceScopedRepository<T> {
return new WorkspaceScopedRepository<T>(
manager.getRepository(this.repository.target),
diff --git a/packages/twenty-server/src/engine/workspace-cache/services/workspace-cache.service.ts b/packages/twenty-server/src/engine/workspace-cache/services/workspace-cache.service.ts
index 436cb7e3119..217b05a086f 100644
--- a/packages/twenty-server/src/engine/workspace-cache/services/workspace-cache.service.ts
+++ b/packages/twenty-server/src/engine/workspace-cache/services/workspace-cache.service.ts
@@ -212,7 +212,6 @@ export class WorkspaceCacheService implements OnModuleInit, OnModuleDestroy {
return freshEntries;
}
- // Stage 2: Validate ttl stale keys against Redis hash
const {
validKeys,
keysNeedingDataFromRedis,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/generate-random-users.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/generate-random-users.util.ts
index e400151825a..588756999db 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/generate-random-users.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/generate-random-users.util.ts
@@ -460,7 +460,6 @@ export function generateRandomUsers(): {
'$2b$10$3LwXjJRtLsfx4hLuuXhxt.3mWgismTiZFCZSG3z9kDrSfsrBl0fT6';
for (let i = 1; i <= 1000; i++) {
- // Generate deterministic random indices for names
const firstNameIndex = Math.floor(
seededRandom(i * 1000) * FIRST_NAMES.length,
);
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds-v2.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds-v2.util.ts
index 9c275c3f36f..536627ed94d 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds-v2.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds-v2.util.ts
@@ -97,7 +97,6 @@ export const getPageLayoutWidgetDataSeedsV2 = (
} satisfies SeederFlatPageLayoutWidget)
: null,
- // LINE chart: New Customers Over Time (Customer Overview)
isDefined(companyIdFieldId) && isDefined(companyCreatedAtFieldId)
? ({
id: generateSeedId(
@@ -134,7 +133,6 @@ export const getPageLayoutWidgetDataSeedsV2 = (
} satisfies SeederFlatPageLayoutWidget)
: null,
- // PIE chart: Revenue Distribution (Customer Analytics)
isDefined(companyAnnualRevenueFieldId) && isDefined(companyNameFieldId)
? ({
id: generateSeedId(
@@ -170,7 +168,6 @@ export const getPageLayoutWidgetDataSeedsV2 = (
} satisfies SeederFlatPageLayoutWidget)
: null,
- // PIE chart: Companies by LinkedIn (Customer Overview)
isDefined(companyIdFieldId) && isDefined(companyLinkedinLinkFieldId)
? ({
id: generateSeedId(
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts
index 84385d07350..7ef5657fb57 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts
@@ -57,7 +57,6 @@ const GENERATE_CALENDAR_CHANNEL_EVENT_ASSOCIATION_SEEDS =
];
EVENT_IDS.forEach((eventId, index) => {
- // Distribute events across channels with weighted distribution
let CHANNEL_ID: string;
const CHANNEL_RAND = Math.random();
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts
index 3cb7743e43e..1f94cc721a7 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts
@@ -193,7 +193,6 @@ const GENERATE_CALENDAR_EVENT_SEEDS = (): CalendarEventDataSeed[] => {
const IS_CANCELLED = Math.random() < 0.05;
- // Generate conference link if it's an online meeting
const CONFERENCE_LINK = ['Zoom', 'Teams', 'Google Meet'].includes(
CONFERENCE_SOLUTION,
)
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts
index 96afdc84a47..1e03ff4f194 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts
@@ -87,7 +87,6 @@ const GENERATE_MESSAGE_CHANNEL_MESSAGE_ASSOCIATION_SEEDS =
CHANNEL_ID = MESSAGE_CHANNEL_DATA_SEED_IDS.SALES;
}
- // 50/50 split between incoming and outgoing messages
const DIRECTION: MessageDirection =
Math.random() < 0.5
? MessageDirection.INCOMING
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/opportunity-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/opportunity-data-seeds.constant.ts
index 37d634d6334..79a9df54dc7 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/opportunity-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/opportunity-data-seeds.constant.ts
@@ -62,7 +62,6 @@ const GENERATE_OPPORTUNITY_IDS = (): Record<string, string> => {
export const OPPORTUNITY_DATA_SEED_IDS = GENERATE_OPPORTUNITY_IDS();
-// Credible opportunity names for Apple selling to various companies
const OPPORTUNITY_TEMPLATES = [
{ name: 'Enterprise iPad Deployment', amount: 2500000, stage: 'PROPOSAL' },
{ name: 'MacBook Pro Fleet Upgrade', amount: 1800000, stage: 'MEETING' },
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-data-seeds.constant.ts
index e27858cf8a8..059552d1a08 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-data-seeds.constant.ts
@@ -56,7 +56,6 @@ const GENERATE_TASK_IDS = (): Record<string, string> => {
export const TASK_DATA_SEED_IDS = GENERATE_TASK_IDS();
-// Sample credible task titles and contents for person-related tasks
const PERSON_TASK_TEMPLATES = [
{
title: 'Schedule follow-up call',
@@ -108,7 +107,6 @@ const PERSON_TASK_TEMPLATES = [
},
];
-// Sample credible task titles and contents for company-related tasks
const COMPANY_TASK_TEMPLATES = [
{
title: 'Conduct vendor evaluation',
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-target-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-target-data-seeds.constant.ts
index 907efed39f6..2a931408c8e 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-target-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-target-data-seeds.constant.ts
@@ -45,7 +45,6 @@ const TASK_TARGET_DATA_SEED_IDS = GENERATE_TASK_TARGET_IDS();
const GENERATE_TASK_TARGET_SEEDS = (): TaskTargetDataSeed[] => {
const TASK_TARGET_SEEDS: TaskTargetDataSeed[] = [];
- // Person task targets (link each person task to its corresponding person)
for (let INDEX = 1; INDEX <= 1200; INDEX++) {
TASK_TARGET_SEEDS.push({
id: TASK_TARGET_DATA_SEED_IDS[`ID_${INDEX}`],
@@ -59,7 +58,6 @@ const GENERATE_TASK_TARGET_SEEDS = (): TaskTargetDataSeed[] => {
});
}
- // Company task targets (link each company task to its corresponding company)
for (let INDEX = 1201; INDEX <= 1800; INDEX++) {
const COMPANY_INDEX = INDEX - 1200;
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/dev-seeder-data.service.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/dev-seeder-data.service.ts
index df085da24b8..f7df36e4f19 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/dev-seeder-data.service.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/dev-seeder-data.service.ts
@@ -118,7 +118,6 @@ type RecordSeedConfig = {
recordSeeds: Record<string, unknown>[];
};
-// Organize seeds into dependency batches for parallel insertion
const getRecordSeedsBatches = (
workspaceId: string,
attachmentSeeds: RecordSeedConfig['recordSeeds'],
@@ -443,7 +442,6 @@ export class DevSeederDataService {
)
: join(__dirname, '../sample-files');
- // Read each sample file once and cache the buffer
const sampleFileBuffers: Buffer[] = [];
for (const sampleFile of ATTACHMENT_SAMPLE_FILES) {
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/timeline-activity-seeder.service.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/timeline-activity-seeder.service.ts
index 2cc3c57578f..024e201bf13 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/timeline-activity-seeder.service.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/timeline-activity-seeder.service.ts
@@ -143,7 +143,6 @@ export class TimelineActivitySeederService {
{ type: 'opportunity', seeds: OPPORTUNITY_DATA_SEEDS },
];
- // Calendar events and messages only appear as linked activities
const linkableConfigs: EntityConfig[] = [
{ type: 'calendarEvent', seeds: CALENDAR_EVENT_DATA_SEEDS },
{ type: 'message', seeds: MESSAGE_DATA_SEEDS },
@@ -183,7 +182,6 @@ export class TimelineActivitySeederService {
});
});
- // Create only linked activities for calendar events and messages
linkableConfigs.forEach(({ type, seeds }) => {
seeds.forEach((seed, index) => {
const linkedObjectMetadataId = this.getLinkedObjectMetadataId(
@@ -299,7 +297,6 @@ export class TimelineActivitySeederService {
happensAt: creationDate,
};
- // Set the appropriate target entity ID for entities that have target columns
const entitiesWithTargetColumns = new Set([
'note',
'task',
@@ -594,13 +591,11 @@ export class TimelineActivitySeederService {
happensAt: creationDate,
};
- // Set target ID (person, company, or opportunity)
const targetIdKey = `target${capitalize(targetInfo.targetType)}Id`;
// @ts-expect-error - This is okay for morph
linkedActivity[targetIdKey] = targetInfo.targetId;
- // Only set target activity ID for entities that have corresponding columns
const entitiesWithTargetColumns = new Set(['note', 'task']);
if (entitiesWithTargetColumns.has(activityType)) {
@@ -676,7 +671,6 @@ export class TimelineActivitySeederService {
this.ENTITY_CODES[type as keyof typeof this.ENTITY_CODES] || '0000';
const targetCode =
this.TARGET_CODES[targetType as keyof typeof this.TARGET_CODES] || '0000';
- // Ensure the last segment is exactly 12 hex characters
const indexHex = (index % 0xffffffff).toString(16).padStart(8, '0');
return `${prefix}-${entityCode}-${targetCode}-8001-${indexHex}0001`;
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/extract-jsonb-properties.type-test.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/extract-jsonb-properties.type-test.ts
index 558a162f205..051852533b6 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/extract-jsonb-properties.type-test.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/extract-jsonb-properties.type-test.ts
@@ -61,6 +61,5 @@ type Assertions = [
Expect<Equal<ExtractJsonbProperties<EmptyObject>, never>>,
- // Object with no JsonbProperty fields returns never
Expect<Equal<ExtractJsonbProperties<{ a: string; b: number }>, never>>,
];
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/format-record-serialized-relation-properties.test-type.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/format-record-serialized-relation-properties.test-type.ts
index 79197fee51c..71ed79628c3 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/format-record-serialized-relation-properties.test-type.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/format-record-serialized-relation-properties.test-type.ts
@@ -20,7 +20,6 @@ type BrandedObjectWithRelation = JsonbProperty<ObjectWithRelation>;
// oxlint-disable-next-line unused-imports/no-unused-vars
type ObjectAssertions = [
- // Object with SerializedRelation: Id suffix renamed to UniversalIdentifier, value becomes nullable
Expect<
Equal<
FormatRecordSerializedRelationProperties<ObjectWithRelation>,
@@ -31,7 +30,6 @@ type ObjectAssertions = [
>
>,
- // Branded object with SerializedRelation: renames property, preserves brand key, value becomes nullable
Expect<
Equal<
FormatRecordSerializedRelationProperties<BrandedObjectWithRelation>,
@@ -66,7 +64,6 @@ type PrimitiveAssertions = [
// oxlint-disable-next-line unused-imports/no-unused-vars
type ArrayAssertions = [
- // Array of objects with relation: transforms each element
Expect<
Equal<
FormatRecordSerializedRelationProperties<ObjectWithRelation[]>,
@@ -77,7 +74,6 @@ type ArrayAssertions = [
>
>,
- // Array of objects without relation: passes through unchanged
Expect<
Equal<
FormatRecordSerializedRelationProperties<ObjectWithoutRelation[]>,
@@ -87,7 +83,6 @@ type ArrayAssertions = [
Expect<Equal<FormatRecordSerializedRelationProperties<string[]>, string[]>>,
- // Nested array of objects: transforms innermost elements
Expect<
Equal<
FormatRecordSerializedRelationProperties<ObjectWithRelation[][]>,
@@ -101,7 +96,6 @@ type ArrayAssertions = [
// oxlint-disable-next-line unused-imports/no-unused-vars
type UnionAssertions = [
- // Union with null: transforms object, keeps null
Expect<
Equal<
FormatRecordSerializedRelationProperties<ObjectWithRelation | null>,
@@ -112,7 +106,6 @@ type UnionAssertions = [
>
>,
- // Array of union: transforms elements appropriately
Expect<
Equal<
FormatRecordSerializedRelationProperties<(ObjectWithRelation | null)[]>,
@@ -133,7 +126,6 @@ type MultipleRelationsObject = {
// oxlint-disable-next-line unused-imports/no-unused-vars
type MultipleRelationsAssertions = [
- // Multiple SerializedRelation properties: all get renamed and become nullable
Expect<
Equal<
FormatRecordSerializedRelationProperties<MultipleRelationsObject>,
@@ -188,7 +180,6 @@ type NestedWithArrayOfObjects = {
// oxlint-disable-next-line unused-imports/no-unused-vars
type NestedObjectAssertions = [
- // Simple nested object: transforms relation inside nested object
Expect<
Equal<
FormatRecordSerializedRelationProperties<NestedObjectWithRelation>,
@@ -201,7 +192,6 @@ type NestedObjectAssertions = [
>
>,
- // Deeply nested object: transforms relation at any depth
Expect<
Equal<
FormatRecordSerializedRelationProperties<DeeplyNestedObjectWithRelation>,
@@ -216,7 +206,6 @@ type NestedObjectAssertions = [
>
>,
- // Mixed: transforms both direct and nested relations
Expect<
Equal<
FormatRecordSerializedRelationProperties<MixedNestedObject>,
@@ -231,7 +220,6 @@ type NestedObjectAssertions = [
>
>,
- // Nullable nested object: transforms relation inside, preserves union with null
Expect<
Equal<
FormatRecordSerializedRelationProperties<NullableNestedObject>,
@@ -244,7 +232,6 @@ type NestedObjectAssertions = [
>
>,
- // Nested with array of objects: transforms relations inside array elements
Expect<
Equal<
FormatRecordSerializedRelationProperties<NestedWithArrayOfObjects>,
@@ -290,7 +277,6 @@ type RecordPropertyAssertions = [
>
>,
- // Union type with JSON schema: properties inside schema should stay as 'properties'
Expect<
Equal<
FormatRecordSerializedRelationProperties<JsonSchemaUnion>,
@@ -306,7 +292,6 @@ type RecordPropertyAssertions = [
>
>,
- // Branded JSON schema union: should preserve structure, only add brand
Expect<
Equal<
FormatRecordSerializedRelationProperties<BrandedJsonSchemaUnion>,
@@ -323,7 +308,6 @@ type RecordPropertyAssertions = [
>
>,
- // Plain Record<string, X> should pass through unchanged
Expect<
Equal<
FormatRecordSerializedRelationProperties<
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/jsonb-property.type-test.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/jsonb-property.type-test.ts
index 3008d0a8594..935921d6ccd 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/jsonb-property.type-test.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/jsonb-property.type-test.ts
@@ -12,7 +12,6 @@ type NestedObject = { nested: { deep: number } };
// oxlint-disable-next-line unused-imports/no-unused-vars
type PrimitiveAssertions = [
- // Primitives pass through unchanged (not objects)
Expect<Equal<JsonbProperty<string>, string>>,
Expect<Equal<JsonbProperty<number>, number>>,
Expect<Equal<JsonbProperty<boolean>, boolean>>,
@@ -44,7 +43,6 @@ type ObjectAssertions = [
// oxlint-disable-next-line unused-imports/no-unused-vars
type ArrayAssertions = [
- // Arrays are objects, so they get branded on the array itself
Expect<
Equal<
JsonbProperty<string[]>,
@@ -67,7 +65,6 @@ type ArrayAssertions = [
// oxlint-disable-next-line unused-imports/no-unused-vars
type UnionAssertions = [
- // Union of object and null: object gets branded, null passes through
Expect<
Equal<
JsonbProperty<SimpleObject | null>,
@@ -75,7 +72,6 @@ type UnionAssertions = [
>
>,
- // Union of objects: both get branded (distributive conditional)
Expect<
Equal<
JsonbProperty<SimpleObject | NestedObject>,
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/universal-flat-field-metadata.test-type.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/universal-flat-field-metadata.test-type.ts
index 8bc6529721f..e977a64b1ca 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/universal-flat-field-metadata.test-type.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/universal-flat-field-metadata.test-type.ts
@@ -20,7 +20,6 @@ type DefinedRelationUniversalIdentifierRecord = {
relationTargetObjectMetadataUniversalIdentifier: string;
};
-// Non-relation field types have never | null relation universal identifiers
type NotDefinedRelationUniversalIdentifierRecord = {
relationTargetFieldMetadataUniversalIdentifier: never | null;
relationTargetObjectMetadataUniversalIdentifier: never | null;
@@ -31,7 +30,6 @@ type DatePropertiesCastToString = {
updatedAt: string;
};
-// OneToMany relations become ...UniversalIdentifiers arrays
type OneToManyUniversalIdentifierArrays = {
viewFieldUniversalIdentifiers: string[];
viewFilterUniversalIdentifiers: string[];
@@ -44,7 +42,6 @@ type OneToManyUniversalIdentifierArrays = {
// Narrowed relation universal identifier assertions - verifies conditional typing is preserved
// oxlint-disable-next-line unused-imports/no-unused-vars
type RelationUniversalIdentifierAssertions = [
- // Non-relation types have undefined relation universal identifiers
Expect<
HasAllProperties<
UniversalFlatFieldMetadata<FieldMetadataType.UUID>,
@@ -52,7 +49,6 @@ type RelationUniversalIdentifierAssertions = [
>
>,
- // Relation types have defined relation universal identifiers
Expect<
HasAllProperties<
UniversalFlatFieldMetadata<FieldMetadataType.RELATION>,
@@ -66,7 +62,6 @@ type RelationUniversalIdentifierAssertions = [
>
>,
- // Abstract type has nullable partial relation universal identifiers
Expect<
HasAllProperties<
UniversalFlatFieldMetadata,
@@ -88,7 +83,6 @@ type UniversalFlatTransformationAssertions = [
>,
];
-// JSONB properties are now prefixed with 'universal' in UniversalFlatFieldMetadata
type NarrowedTestCase =
UniversalFlatFieldMetadata<FieldMetadataType.RELATION>['universalSettings'];
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-non-relation-fields-into-object-actions.util.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-non-relation-fields-into-object-actions.util.spec.ts
index a7c51c07e00..c14ed66737b 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-non-relation-fields-into-object-actions.util.spec.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-non-relation-fields-into-object-actions.util.spec.ts
@@ -172,7 +172,6 @@ describe('aggregateNonRelationFieldsIntoObjectActions', () => {
expect(result.objectMetadata.create).toHaveLength(0);
- // Field should remain in field actions (no matching object to merge into)
expect(result.fieldMetadata.create).toMatchObject([
{
flatEntity: { universalIdentifier: fieldUniversalId },
@@ -245,7 +244,6 @@ describe('aggregateNonRelationFieldsIntoObjectActions', () => {
orchestratorActionsReport: input,
});
- // Text field should be merged into object action
expect(result.objectMetadata.create).toMatchObject([
{
universalFlatFieldMetadatas: [
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-relation-field-pairs.util.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-relation-field-pairs.util.spec.ts
index c3b10ea5c60..466e8b19230 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-relation-field-pairs.util.spec.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-relation-field-pairs.util.spec.ts
@@ -57,7 +57,6 @@ describe('aggregateRelationFieldPairs', () => {
orchestratorActionsReport: input,
});
- // Should be bundled into a single action with flatEntity and relatedUniversalFlatFieldMetadata
expect(result.fieldMetadata.create).toMatchObject([
{
flatEntity: { universalIdentifier: targetTaskFieldId },
@@ -100,7 +99,6 @@ describe('aggregateRelationFieldPairs', () => {
orchestratorActionsReport: input,
});
- // Should remain as single action without relatedUniversalFlatFieldMetadata
expect(result.fieldMetadata.create).toMatchObject([
{
flatEntity: { universalIdentifier: fieldUniversalId },
@@ -146,7 +144,6 @@ describe('aggregateRelationFieldPairs', () => {
orchestratorActionsReport: input,
});
- // Should remain as single action without relatedUniversalFlatFieldMetadata (target not being created)
expect(result.fieldMetadata.create).toMatchObject([
{
flatEntity: { universalIdentifier: relationFieldId },
@@ -234,7 +231,6 @@ describe('aggregateRelationFieldPairs', () => {
orchestratorActionsReport: input,
});
- // Should result in 2 bundled actions (one per pair)
expect(result.fieldMetadata.create).toMatchObject([
{
flatEntity: { universalIdentifier: pair1FieldA },
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/validate-flat-entity-circular-dependency.util.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/validate-flat-entity-circular-dependency.util.ts
index d40f492c058..80b2a8e3da3 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/validate-flat-entity-circular-dependency.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/validate-flat-entity-circular-dependency.util.ts
@@ -43,7 +43,6 @@ export const validateFlatEntityCircularDependency = <
};
}
- // Traverse ancestor chain to detect cycles and measure depth
const visited = new Set<string>();
let currentParentUniversalIdentifier: string | null | undefined =
flatEntityParentUniversalIdentifier;
@@ -66,7 +65,6 @@ export const validateFlatEntityCircularDependency = <
};
}
- // Check for cycle in ancestors (already visited node)
if (visited.has(currentParentUniversalIdentifier)) {
return {
status: 'fail',
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/field/types/workspace-migration-field-action.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/field/types/workspace-migration-field-action.ts
index b8b70f0e706..385503f9e93 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/field/types/workspace-migration-field-action.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/field/types/workspace-migration-field-action.ts
@@ -15,7 +15,6 @@ export type UniversalCreateFieldAction =
UniversalFlatFieldMetadata,
ExtractUniversalForeignKeyAggregatorForMetadataName<'fieldMetadata'>
>;
- // Optional ID for the related field (for API metadata).
relatedFieldId?: string;
// IDs for fields created in the same migration, keyed by universal identifier.
fieldIdByUniversalIdentifier?: Record<string, string>;
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/object/types/workspace-migration-object-action.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/object/types/workspace-migration-object-action.ts
index 87363d92977..c0cb2637b42 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/object/types/workspace-migration-object-action.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/object/types/workspace-migration-object-action.ts
@@ -14,7 +14,6 @@ export type UniversalCreateObjectAction =
UniversalFlatFieldMetadata,
ExtractUniversalForeignKeyAggregatorForMetadataName<'fieldMetadata'>
>[];
- // Optional map to provide specific IDs for field creation (for API metadata).
fieldIdByUniversalIdentifier?: Record<string, string>;
};
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-agent-required-properties.util.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-agent-required-properties.util.ts
index 72c8bccec63..c386788b82a 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-agent-required-properties.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-agent-required-properties.util.ts
@@ -16,7 +16,6 @@ export const validateAgentRequiredProperties = ({
}: ValidateAgentRequiredPropertiesArgs): FlatEntityValidationError<AiExceptionCode>[] => {
const errors: FlatEntityValidationError<AiExceptionCode>[] = [];
- // For updates, only validate properties that are being changed
const isUpdate = updatedProperties !== undefined;
const shouldValidateLabel = !isUpdate || 'label' in updatedProperties;
const shouldValidatePrompt = !isUpdate || 'prompt' in updatedProperties;
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/field/services/utils/from-universal-flat-field-metadata-to-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/field/services/utils/from-universal-flat-field-metadata-to-flat-field-metadata.util.ts
index 39ddf309747..fa5c6407b63 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/field/services/utils/from-universal-flat-field-metadata-to-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/field/services/utils/from-universal-flat-field-metadata-to-flat-field-metadata.util.ts
@@ -127,7 +127,6 @@ export const fromUniversalFlatFieldMetadataToFlatFieldMetadata = ({
relationTargetObjectMetadataUniversalIdentifier:
relationTargetObjectMetadataUniversalIdentifier ?? null,
applicationUniversalIdentifier,
- // Empty aggregator arrays for newly created entities
viewFieldIds: [],
viewFilterIds: [],
fieldPermissionIds: [],
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/object/services/utils/from-universal-flat-object-metadata-to-flat-object-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/object/services/utils/from-universal-flat-object-metadata-to-flat-object-metadata.util.ts
index 98a04494f1b..f5d9eda8bf7 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/object/services/utils/from-universal-flat-object-metadata-to-flat-object-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/object/services/utils/from-universal-flat-object-metadata-to-flat-object-metadata.util.ts
@@ -113,7 +113,6 @@ export const fromUniversalFlatObjectMetadataToFlatObjectMetadata = ({
targetTableName: 'DEPRECATED',
imageIdentifierFieldMetadataId,
imageIdentifierFieldMetadataUniversalIdentifier,
- // Empty aggregator arrays for newly created entities
fieldIds: [],
viewIds: [],
indexMetadataIds: [],
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/generate-column-definitions.util.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/generate-column-definitions.util.spec.ts
index b9c8cdd32db..7d9384dba8b 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/generate-column-definitions.util.spec.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/generate-column-definitions.util.spec.ts
@@ -124,7 +124,6 @@ describe('Generate Column Definitions', () => {
workspaceId,
});
- // Relations without join columns must return empty array
expect(columns).toStrictEqual([]);
});
@@ -192,7 +191,6 @@ describe('Generate Column Definitions', () => {
'homeAddressAddressLng',
]);
- // All composite columns must inherit parent nullable constraint
columns.forEach((column) => {
expect(column.isNullable).toBe(true);
expect(column.isPrimary).toBe(false);
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/workspace-schema-enum-operations.util.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/workspace-schema-enum-operations.util.spec.ts
index 623adbc68fd..b31ebca64cb 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/workspace-schema-enum-operations.util.spec.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/workspace-schema-enum-operations.util.spec.ts
@@ -62,7 +62,6 @@ describe('WorkspaceSchemaEnumOperations', () => {
}),
).rejects.toThrow(WorkspaceMigrationActionExecutionException);
- // All operations should be attempted in parallel despite failure
expect(
mockSchemaManagerService.enumManager.createEnum,
).toHaveBeenCalledTimes(3);
@@ -216,7 +215,6 @@ describe('WorkspaceSchemaEnumOperations', () => {
operation: EnumOperation.CREATE,
});
- // Relation fields should not generate enum operations
expect(enumOps).toEqual([]);
});
});
diff --git a/packages/twenty-server/src/modules/dashboard/chart-data/utils/__tests__/fill-date-gaps.util.spec.ts b/packages/twenty-server/src/modules/dashboard/chart-data/utils/__tests__/fill-date-gaps.util.spec.ts
index 4a19de82c5e..ec542a95893 100644
--- a/packages/twenty-server/src/modules/dashboard/chart-data/utils/__tests__/fill-date-gaps.util.spec.ts
+++ b/packages/twenty-server/src/modules/dashboard/chart-data/utils/__tests__/fill-date-gaps.util.spec.ts
@@ -279,7 +279,6 @@ describe('fillDateGapsTwoDimensional', () => {
expect(result.data).toHaveLength(6);
expect(result.wasTruncated).toBe(false);
- // Check that all dates have both secondary values
const day1A = result.data.find(
(d) =>
d.groupByDimensionValues[0] === '2024-01-01' &&
diff --git a/packages/twenty-server/src/modules/dashboard/tools/schemas/widget.schema.ts b/packages/twenty-server/src/modules/dashboard/tools/schemas/widget.schema.ts
index 228f909856f..f7bc6331d94 100644
--- a/packages/twenty-server/src/modules/dashboard/tools/schemas/widget.schema.ts
+++ b/packages/twenty-server/src/modules/dashboard/tools/schemas/widget.schema.ts
@@ -293,7 +293,6 @@ export const widgetTypeSchema = z.enum([
WidgetType.RECORD_TABLE,
]);
-// Graph configuration schema for AGGREGATE type (KPI numbers)
const aggregateChartConfigSchemaBase = z.object({
configurationType: z.literal(WidgetConfigurationType.AGGREGATE_CHART),
aggregateFieldMetadataId: z
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts
index 104f90423f2..98a892ac010 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts
@@ -127,7 +127,6 @@ export class MessagingMessagesImportService {
messageChannel,
);
- // Map external folder IDs to internal folder IDs
const messageFolders = messageChannel.messageFolders ?? [];
const foldersWithExternalId = messageFolders.filter(
(folder): folder is typeof folder & { externalId: string } =>
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/utils/remove-step.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/utils/remove-step.ts
index 2662d072ab1..a5f0628cffe 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/utils/remove-step.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/utils/remove-step.ts
@@ -29,11 +29,7 @@ const computeUpdatedNextStepIds = ({
: [];
return [
- ...new Set([
- ...filteredNextStepIds,
- // We automatically link parent and child steps together
- ...(stepToDeleteChildrenIds || []),
- ]),
+ ...new Set([...filteredNextStepIds, ...(stepToDeleteChildrenIds || [])]),
];
};
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-execute-child-step.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-execute-child-step.util.spec.ts
index 64c831bc3bc..f4d811fff46 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-execute-child-step.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-execute-child-step.util.spec.ts
@@ -441,7 +441,6 @@ describe('shouldExecuteChildStep', () => {
nextStepIds: [],
})) as unknown as WorkflowAction[];
- // All parents stopped or skipped, none succeeded
const stepInfos = Object.fromEntries(
manyParentSteps.map((step, i) => [
step.id,
@@ -519,7 +518,6 @@ describe('shouldExecuteChildStep', () => {
nextStepIds: [],
})) as unknown as WorkflowAction[];
- // First parent succeeded, rest are still running
const stepInfos = Object.fromEntries(
manyParentSteps.map((step, i) => [
step.id,
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-skip-step-execution.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-skip-step-execution.util.spec.ts
index bef6ed14962..032fb1fbde0 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-skip-step-execution.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-skip-step-execution.util.spec.ts
@@ -255,7 +255,6 @@ describe('shouldSkipStepExecution', () => {
}),
).toBe(true);
- // Test case 2: Mixed skipped/stopped - should return true
expect(
shouldSkipStepExecution({
step: steps[3],
@@ -269,7 +268,6 @@ describe('shouldSkipStepExecution', () => {
}),
).toBe(true);
- // Test case 3: One success among skipped - should return false
expect(
shouldSkipStepExecution({
step: steps[3],
@@ -283,7 +281,6 @@ describe('shouldSkipStepExecution', () => {
}),
).toBe(false);
- // Test case 4: One failed among skipped - should return false
expect(
shouldSkipStepExecution({
step: steps[3],
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts
index 023f038b5fb..805d01b52b8 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts
@@ -94,7 +94,6 @@ describe('evaluateFilterConditions', () => {
expect(result).toBe(true);
});
- // Enhanced relation filter tests with object id extraction
it('should extract id from left operand object for relation comparison', () => {
const uuid1 = '550e8400-e29b-41d4-a716-446655440000';
const leftObject = { id: uuid1, name: 'John Doe' };
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/evaluate-filter-conditions.util.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/evaluate-filter-conditions.util.ts
index f139bb7de24..17edd2712fa 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/evaluate-filter-conditions.util.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/evaluate-filter-conditions.util.ts
@@ -137,7 +137,6 @@ function evaluateFilterGroup(
}
function contains(leftValue: unknown, rightValue: unknown): boolean {
- // if two arrays, check if any item is in the other array
if (Array.isArray(leftValue) && Array.isArray(rightValue)) {
return leftValue.some((item) => rightValue.includes(item));
}
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/get-all-step-ids-in-loop.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/get-all-step-ids-in-loop.util.spec.ts
index 3ccc6d8b745..3d4f8edb407 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/get-all-step-ids-in-loop.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/get-all-step-ids-in-loop.util.spec.ts
@@ -359,7 +359,6 @@ describe('getAllStepIdsInLoop', () => {
steps,
});
- // Should still include all steps but not get stuck in infinite loop
expect(result).toEqual(['step2', 'step3', 'step4']);
});
});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/should-execute-iterator-step.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/should-execute-iterator-step.util.spec.ts
index 22c395a0f34..5627863b248 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/should-execute-iterator-step.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/iterator/utils/__tests__/should-execute-iterator-step.util.spec.ts
@@ -378,7 +378,6 @@ describe('shouldExecuteIteratorStep', () => {
stepInfos,
});
- // Should return false because step-2 info is undefined
expect(result).toBe(false);
});
@@ -476,7 +475,6 @@ describe('shouldExecuteIteratorStep', () => {
stepInfos,
});
- // getAllStepIdsInLoop should not be called if initialLoopStepIds is undefined
expect(getAllStepIdsInLoop).not.toHaveBeenCalled();
expect(result).toBe(true);
});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-tools/services/workflow-tool.workspace-service.ts b/packages/twenty-server/src/modules/workflow/workflow-tools/services/workflow-tool.workspace-service.ts
index 04f5c73ab2c..7acd17449ee 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-tools/services/workflow-tool.workspace-service.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-tools/services/workflow-tool.workspace-service.ts
@@ -79,7 +79,6 @@ export class WorkflowToolWorkspaceService {
};
}
- // Generates static workflow tools that don't depend on workspace objects
generateWorkflowTools(
workspaceId: string,
rolePermissionConfig: RolePermissionConfig,
diff --git a/packages/twenty-server/src/modules/workflow/workflow-trigger/utils/assert-form-step-is-valid.util.ts b/packages/twenty-server/src/modules/workflow/workflow-trigger/utils/assert-form-step-is-valid.util.ts
index 8977cb247a5..3489d40a1f8 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-trigger/utils/assert-form-step-is-valid.util.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-trigger/utils/assert-form-step-is-valid.util.ts
@@ -28,7 +28,6 @@ export function assertFormStepIsValid(settings: WorkflowFormActionSettings) {
);
}
- // Check all fields have unique and defined names
const fieldNames = settings.input.map((fieldMetadata) => fieldMetadata.name);
const uniqueFieldNames = new Set(fieldNames);
@@ -42,7 +41,6 @@ export function assertFormStepIsValid(settings: WorkflowFormActionSettings) {
);
}
- // Check all fields have defined labels and types
settings.input.forEach((fieldMetadata) => {
if (
!isNonEmptyString(fieldMetadata.label) ||
diff --git a/packages/twenty-server/src/utils/__test__/get-domain-from-email-or-throw.spec.ts b/packages/twenty-server/src/utils/__test__/get-domain-from-email-or-throw.spec.ts
index f66d3035746..93edb4f459e 100644
--- a/packages/twenty-server/src/utils/__test__/get-domain-from-email-or-throw.spec.ts
+++ b/packages/twenty-server/src/utils/__test__/get-domain-from-email-or-throw.spec.ts
@@ -61,7 +61,6 @@ describe('getDomainFromEmailOrThrow', () => {
}
});
- // Edge cases with weird but potentially valid email formats
it('should handle email with plus addressing', () => {
expect(getDomainFromEmailOrThrow('[email protected]')).toBe(
'example.com',
diff --git a/packages/twenty-server/src/utils/extract-column-names-from-aggregate-expression.util.ts b/packages/twenty-server/src/utils/extract-column-names-from-aggregate-expression.util.ts
index 5329f8ddf62..de8892bd88d 100644
--- a/packages/twenty-server/src/utils/extract-column-names-from-aggregate-expression.util.ts
+++ b/packages/twenty-server/src/utils/extract-column-names-from-aggregate-expression.util.ts
@@ -9,10 +9,8 @@ export const extractColumnNamesFromAggregateExpression = (
const concatMatches = selection.match(/CONCAT\("([^"]+)"(?:,"([^"]+)")*\)/g);
if (concatMatches) {
- // Extract all column names between quotes after CONCAT
const columnNames = selection.match(/"([^"]+)"/g)?.map((match) => {
const fullColumn = match.slice(1, -1);
- // If there's a dot, extract only the column name (part after the dot)
const parts = fullColumn.split('.');
return parts[parts.length - 1];
@@ -28,7 +26,6 @@ export const extractColumnNamesFromAggregateExpression = (
if (tableColumnMatches) {
const columnNames = tableColumnMatches
.map((match) => {
- // Extract the column name from "table"."column" pattern
const columnMatch = match.match(/"[^"]+"\."([^"]+)"/);
return columnMatch ? columnMatch[1] : null;
diff --git a/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts b/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts
index eb5cd0f1e5f..6cf01eb2366 100644
--- a/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts
+++ b/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts
@@ -108,9 +108,7 @@ describe('MCP Controller (integration)', () => {
expect(res.body.jsonrpc).toBe('2.0');
expect(res.body.result).toBeDefined();
expect(Array.isArray(res.body.result.tools)).toBe(true);
- // In a seeded workspace, there should be at least one tool
expect(res.body.result.tools.length).toBeGreaterThanOrEqual(0);
- // If tools exist, they should have name, description and inputSchema
const first = res.body.result.tools[0];
if (first) {
@@ -172,7 +170,6 @@ describe('MCP Controller (integration)', () => {
expect(res.body.jsonrpc).toBe('2.0');
expect(res.body.id).toBe(id);
- // Either a structured result or an error is acceptable depending on validation/business rules
const hasResultContent = !!res.body?.result?.content;
const hasError = !!res.body?.error;
@@ -232,7 +229,6 @@ describe('MCP Controller (integration)', () => {
expect(events.length).toBeGreaterThanOrEqual(1);
- // The last event should be the JSON-RPC response
const lastEvent = events[events.length - 1];
expect(lastEvent).toMatchObject({
@@ -273,7 +269,6 @@ describe('MCP Controller (integration)', () => {
const events = parseSseEvents(res.text);
- // Should have at least a progress notification and the final response
expect(events.length).toBeGreaterThanOrEqual(2);
const progressEvent = events[0];
@@ -288,7 +283,6 @@ describe('MCP Controller (integration)', () => {
},
});
- // Last event should be the final JSON-RPC response
const lastEvent = events[events.length - 1];
expect(lastEvent).toMatchObject({
diff --git a/packages/twenty-server/test/integration/constants/widget-configuration-test-data.constants.ts b/packages/twenty-server/test/integration/constants/widget-configuration-test-data.constants.ts
index c60a1ec302f..b15d154730b 100644
--- a/packages/twenty-server/test/integration/constants/widget-configuration-test-data.constants.ts
+++ b/packages/twenty-server/test/integration/constants/widget-configuration-test-data.constants.ts
@@ -17,8 +17,6 @@ const UNIT_TEST_FIELD_METADATA_ID_1 = '20202020-1111-4111-a111-111111111111';
const UNIT_TEST_FIELD_METADATA_ID_2 = '20202020-2222-4222-a222-222222222222';
const UNIT_TEST_FIELD_METADATA_ID_3 = '20202020-3333-4333-a333-333333333333';
-// --- Static configs (no field metadata IDs) ---
-
export const TEST_IFRAME_CONFIG: IframeConfigurationDTO = {
configurationType: WidgetConfigurationType.IFRAME,
url: 'https://example.com/dashboard',
@@ -49,8 +47,6 @@ export const TEST_STANDALONE_RICH_TEXT_CONFIG_MINIMAL: StandaloneRichTextConfigu
},
};
-// --- Invalid configs (for failure test cases) ---
-
export const INVALID_STANDALONE_RICH_TEXT_CONFIG_MISSING_BODY = {};
export const INVALID_STANDALONE_RICH_TEXT_CONFIG_BODY_WRONG_TYPE = {
@@ -96,8 +92,6 @@ export const INVALID_HORIZONTAL_BAR_CHART_CONFIG_MISSING_GROUP_BY = {
aggregateOperation: AggregateOperations.SUM,
};
-// --- Unit-test-only graph configs (with hardcoded UUIDs, for validation tests) ---
-
export const TEST_NUMBER_CHART_CONFIG: AggregateChartConfigurationDTO = {
configurationType: WidgetConfigurationType.AGGREGATE_CHART,
aggregateFieldMetadataId: UNIT_TEST_FIELD_METADATA_ID_1,
diff --git a/packages/twenty-server/test/integration/graphql/suites/group-by-resolver.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/group-by-resolver.integration-spec.ts
index ac30850c689..3f43ac1acf1 100644
--- a/packages/twenty-server/test/integration/graphql/suites/group-by-resolver.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/group-by-resolver.integration-spec.ts
@@ -579,7 +579,6 @@ describe('group-by resolver (integration)', () => {
expect(groups).toBeDefined();
expect(groups.length).toBe(3);
- // Group starting week of saturday dec 28th, 2024
const saturdayDec28thGroup = groups.find((group: any) =>
group.groupByDimensionValues[0].startsWith('2024-12-28'),
);
@@ -849,7 +848,6 @@ describe('group-by resolver (integration)', () => {
}),
);
- // create a view with a filter: city eq cityToKeep
const { data: createViewData } = await createOneView({
input: {
name: 'People View City Keep',
@@ -1000,7 +998,6 @@ describe('group-by resolver (integration)', () => {
};
beforeAll(async () => {
- // Create companies with different createdAt dates for grouping
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: 'company',
@@ -1362,7 +1359,6 @@ describe('group-by resolver (integration)', () => {
}),
);
- // Create people linked to companies and listings
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: 'person',
@@ -1559,7 +1555,6 @@ describe('group-by resolver (integration)', () => {
}),
);
- // Create pets linked to rockets via morph relation
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: 'pet',
@@ -1667,7 +1662,6 @@ describe('group-by resolver (integration)', () => {
let originalMemberRoleId: string;
beforeAll(async () => {
- // Get the original Member role ID for restoration later
const getRolesQuery = {
query: `
query GetRoles {
@@ -1709,7 +1703,6 @@ describe('group-by resolver (integration)', () => {
petObjectId = petObject.id;
rocketObjectId = rocketObject.id;
- // Create a custom role with pet read permission but no rocket read permission
const createRoleOperation = {
query: gql`
mutation CreateOneRole {
@@ -1736,7 +1729,6 @@ describe('group-by resolver (integration)', () => {
customRoleId = createRoleResponse.body.data.createOneRole.id;
- // Set object permissions: allow reading pets but not rockets
const upsertObjectPermissionsOperation = {
query: gql`
mutation UpsertObjectPermissions(
diff --git a/packages/twenty-server/test/integration/graphql/suites/group-by-with-records-resolver.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/group-by-with-records-resolver.integration-spec.ts
index 12073a2c3ba..316ca034987 100644
--- a/packages/twenty-server/test/integration/graphql/suites/group-by-with-records-resolver.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/group-by-with-records-resolver.integration-spec.ts
@@ -292,7 +292,6 @@ describe('basic group-by with records', () => {
});
it('groups by stage and createdAt with records and filters', async () => {
- // Test with filter to only include NEW stage opportunities
const response = await makeGraphqlAPIRequest({
query: gql`
query OpportunitiesGroupBy(
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/read-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/read-permissions.integration-spec.ts
index 73a3a45c13f..e0055b41d3c 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/read-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/read-permissions.integration-spec.ts
@@ -142,7 +142,6 @@ describe('Field permissions restrictions', () => {
};
beforeAll(async () => {
- // Get the original Member role ID for restoration later
const getRolesQuery = {
query: `
query GetRoles {
@@ -537,7 +536,6 @@ describe('Field permissions restrictions', () => {
restrictedCompanyFieldId,
);
- // Query requesting the aggregate restricted field
const graphqlOperation = {
query: gql`
query Companies {
@@ -561,7 +559,6 @@ describe('Field permissions restrictions', () => {
restrictedPersonFieldId,
);
- // Query requesting the aggregate restricted field
const graphqlOperation = findManyOperationFactory({
objectMetadataSingularName: 'company',
objectMetadataPluralName: 'companies',
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts
index df7b7d84477..5a1f000d3b1 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts
@@ -105,7 +105,6 @@ describe('Field update permissions restrictions', () => {
};
beforeAll(async () => {
- // Get the original Member role ID for restoration later
const getRolesQuery = {
query: `
query GetRoles {
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/granular-object-records-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/granular-object-records-permissions.integration-spec.ts
index 874e3f2af3c..798e08492d4 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/granular-object-records-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/granular-object-records-permissions.integration-spec.ts
@@ -17,7 +17,6 @@ describe('granularObjectRecordsPermissions', () => {
let customRoleId: string;
beforeAll(async () => {
- // Get the original Member role ID for restoration later
const getRolesQuery = {
query: `
query GetRoles {
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/permissions-on-relations.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/permissions-on-relations.integration-spec.ts
index 38058ed40a9..50c0cbd134a 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/permissions-on-relations.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/permissions-on-relations.integration-spec.ts
@@ -23,7 +23,6 @@ describe('permissionsOnRelations', () => {
const personId = randomUUID();
beforeAll(async () => {
- // Get the original Member role ID for restoration later
const getRolesQuery = {
query: `
query GetRoles {
@@ -99,7 +98,6 @@ describe('permissionsOnRelations', () => {
});
it('should throw permission error when querying person with company relation without company read permission', async () => {
- // Create a role with person read permission but no company read permission
const { roleId } = await createCustomRoleWithObjectPermissions({
label: 'PersonOnlyRole',
canReadPerson: true,
@@ -114,7 +112,6 @@ describe('permissionsOnRelations', () => {
workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
});
- // Create GraphQL query that includes company relation
const graphqlOperation = findManyOperationFactory({
objectMetadataSingularName: 'person',
objectMetadataPluralName: 'people',
@@ -130,7 +127,6 @@ describe('permissionsOnRelations', () => {
const response = await makeGraphqlAPIRequestWithJony(graphqlOperation);
- // The query should fail when trying to access company relation without permission
expect(response.body.errors[0].message).toBe(
PermissionsExceptionMessage.PERMISSION_DENIED,
);
@@ -138,7 +134,6 @@ describe('permissionsOnRelations', () => {
});
it('should successfully query person with company relation when having both permissions', async () => {
- // Create a role with both person and company read permissions
const { roleId } = await createCustomRoleWithObjectPermissions({
label: 'PersonAndCompanyRole',
canReadPerson: true,
@@ -153,7 +148,6 @@ describe('permissionsOnRelations', () => {
workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
});
- // Create GraphQL query that includes company relation
const graphqlOperation = findManyOperationFactory({
objectMetadataSingularName: 'person',
objectMetadataPluralName: 'people',
@@ -178,8 +172,6 @@ describe('permissionsOnRelations', () => {
});
it('nested relations - should throw permission error when querying nested opportunity relation without opportunity read permission', async () => {
- // Where user has person and company read permissions but not opportunity read permission
-
const { roleId } = await createCustomRoleWithObjectPermissions({
label: 'PersonCompanyOnlyRole',
canReadPerson: true,
diff --git a/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts
index 74dea0ac97d..ccc6d6e068c 100644
--- a/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts
@@ -41,7 +41,6 @@ describe('Order by relation field (e2e)', () => {
{ id: TEST_COMPANY_IDS.ALPHA, name: 'Alpha Corp' },
{ id: TEST_COMPANY_IDS.BETA, name: 'Beta Inc' },
{ id: TEST_COMPANY_IDS.GAMMA, name: 'Gamma LLC' },
- // Companies for case-insensitive sorting tests (lowercase vs uppercase)
{ id: TEST_COMPANY_IDS.ACME_LOWER, name: 'acme' },
{ id: TEST_COMPANY_IDS.ACME_UPPER, name: 'ACME' },
{ id: TEST_COMPANY_IDS.ZEBRA, name: 'Zebra' },
@@ -51,7 +50,6 @@ describe('Order by relation field (e2e)', () => {
await makeGraphqlAPIRequest(createCompanies);
- // Create test people with company relations and some without (for null testing)
const createPeople = createManyOperationFactory({
objectMetadataSingularName: 'person',
objectMetadataPluralName: 'people',
@@ -63,7 +61,6 @@ describe('Order by relation field (e2e)', () => {
{ id: TEST_PERSON_IDS[3], companyId: TEST_COMPANY_IDS.BETA },
{ id: TEST_PERSON_IDS[4], companyId: TEST_COMPANY_IDS.GAMMA },
{ id: TEST_PERSON_IDS[5], companyId: TEST_COMPANY_IDS.GAMMA },
- // People without companies (for testing NULLS LAST)
{ id: TEST_PERSON_IDS[6], companyId: null },
{ id: TEST_PERSON_IDS[7], companyId: null },
{ id: TEST_PERSON_IDS[8], companyId: null },
@@ -126,7 +123,6 @@ describe('Order by relation field (e2e)', () => {
expect(Array.isArray(edges)).toBe(true);
expect(edges.length).toBeGreaterThan(0);
- // Verify company names are in ascending order (excluding nulls at the end)
const companyNames = edges
.map(
(edge: { node: { company?: { name: string } } }) =>
@@ -180,7 +176,6 @@ describe('Order by relation field (e2e)', () => {
expect(Array.isArray(edges)).toBe(true);
expect(edges.length).toBeGreaterThan(0);
- // Verify company names are in descending order (excluding nulls at the end)
const companyNames = edges
.map(
(edge: { node: { company?: { name: string } } }) =>
@@ -286,7 +281,6 @@ describe('Order by relation field (e2e)', () => {
expect(firstPageEdges.length).toBeGreaterThan(0);
expect(totalCount).toBeGreaterThan(3);
- // Second request using offset (matching frontend behavior)
const secondQueryData = {
query: gql`
query People(
@@ -381,7 +375,6 @@ describe('Order by relation field (e2e)', () => {
expect(pageInfo.hasNextPage).toBe(true);
expect(pageInfo.endCursor).toBeDefined();
- // Try to use cursor with relation orderBy - should fail with clear error
const secondQueryData = {
query: gql`
query People(
@@ -486,7 +479,6 @@ describe('Order by relation field (e2e)', () => {
expect(companyNames.length).toBe(3);
- // Both "acme" and "ACME" should come before "Zebra" in case-insensitive sort
const zebraIndex = companyNames.findIndex(
(name: string) => name.toLowerCase() === 'zebra',
);
@@ -539,7 +531,6 @@ describe('Order by relation field (e2e)', () => {
expect(companyNames.length).toBe(3);
- // In descending case-insensitive order, "Zebra" should come first
const zebraIndex = companyNames.findIndex(
(name: string) => name.toLowerCase() === 'zebra',
);
@@ -549,7 +540,6 @@ describe('Order by relation field (e2e)', () => {
)
.filter((index: number) => index !== -1);
- // Zebra should appear before all ACME variants in descending order
for (const acmeIndex of acmeIndices) {
expect(zebraIndex).toBeLessThan(acmeIndex);
}
diff --git a/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts
index f52c394dc82..ae4ef931911 100644
--- a/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts
@@ -203,7 +203,6 @@ describe('group-by resolvers - order by', () => {
totalCount: g.totalCount,
}));
- // Order by dayOfWeek (chronological) then avgEmployees then city
expect(groupInfos).toEqual([
{
city: 'Dallas',
@@ -283,7 +282,6 @@ describe('group-by resolvers - order by', () => {
totalCount: g.totalCount,
}));
- // Order by dayOfWeek (chronological) then addressCity then avgEmployees
expect(groupInfos).toEqual([
{
city: 'Anvers',
diff --git a/packages/twenty-server/test/integration/graphql/suites/role/object-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/role/object-permissions.integration-spec.ts
index 9b90621eb89..8cafe9307a2 100644
--- a/packages/twenty-server/test/integration/graphql/suites/role/object-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/role/object-permissions.integration-spec.ts
@@ -16,7 +16,6 @@ describe('Object Permissions Validation', () => {
let companyObjectId: string;
beforeAll(async () => {
- // Get object metadata IDs for Person and Company
const getObjectMetadataOperation = {
query: gql`
query {
@@ -325,7 +324,6 @@ describe('Object Permissions Validation', () => {
let roleWithoutPermissions: string;
beforeEach(async () => {
- // Create a role with write permissions as defaults
const roleWithoutPermissionsQuery = createRoleOperation({
label: 'TestRoleWithNoRights',
description: 'Test role with no rights',
diff --git a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts
index 4c3874cdad6..e043f0463cf 100644
--- a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts
@@ -22,7 +22,6 @@ describe('Granular settings permissions', () => {
const createdObjectMetadataIds: string[] = [];
beforeAll(async () => {
- // Get the original Member role ID for restoration later
const memberRole = await findOneRoleByLabel({ label: 'Member' });
originalMemberRoleId = memberRole.id;
@@ -56,7 +55,6 @@ describe('Granular settings permissions', () => {
customRoleId = createRoleResponse.body.data.createOneRole.id;
- // Assign specific setting permissions to the custom role
const upsertSettingPermissionsQuery = {
query: `
mutation UpsertPermissionFlags {
@@ -77,7 +75,6 @@ describe('Granular settings permissions', () => {
.set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
.send(upsertSettingPermissionsQuery);
- // Assign the custom role to JONY (who uses APPLE_JONY_MEMBER_ACCESS_TOKEN)
await updateWorkspaceMemberRole({
input: {
roleId: customRoleId,
@@ -151,7 +148,6 @@ describe('Granular settings permissions', () => {
describe('Workspace Permissions', () => {
it('should allow access to workspace operations when user has WORKSPACE setting permission', async () => {
- // Test updating workspace settings (requires WORKSPACE permission)
const updateWorkspaceQuery = {
query: `
mutation UpdateWorkspace {
@@ -199,7 +195,6 @@ describe('Granular settings permissions', () => {
describe('Workflows Permissions', () => {
it('should allow access to workflows operations when user has WORKFLOWS setting permission', async () => {
- // Test creating a workflow (requires WORKFLOWS permission)
const createWorkflowQuery = {
query: `
mutation CreateWorkflow {
@@ -240,7 +235,6 @@ describe('Granular settings permissions', () => {
describe('Denied Permissions', () => {
it('should deny access to roles operations when user does not have ROLES setting permission', async () => {
- // Test creating a role (requires ROLES permission, which our custom role doesn't have)
const createRoleQuery = {
query: `
mutation CreateOneRole {
@@ -268,7 +262,6 @@ describe('Granular settings permissions', () => {
});
it('should deny access to workspace members operations when user does not have WORKSPACE_MEMBERS setting permission', async () => {
- // Test inviting a workspace member (requires WORKSPACE_MEMBERS permission)
const inviteWorkspaceMemberQuery = {
query: `
mutation SendWorkspaceInvitation {
@@ -325,7 +318,6 @@ describe('Granular settings permissions', () => {
});
it('should deny access to API keys operations when user does not have API_KEYS_AND_WEBHOOKS setting permission', async () => {
- // Test creating an API key (requires API_KEYS_AND_WEBHOOKS permission)
const createApiKeyQuery = {
query: `
mutation GenerateApiKeyToken {
@@ -353,7 +345,6 @@ describe('Granular settings permissions', () => {
describe('Permission Inheritance', () => {
it('should verify that canUpdateAllSettings=false is properly overridden by specific setting permissions', async () => {
- // Verify the role configuration using the new integration test utilities
const { data, errors } = await findRoles({
gqlFields: `
id
@@ -410,7 +401,6 @@ describe('Granular settings permissions', () => {
expect(response.body.errors).toBeUndefined();
expect(response.body.data.upsertPermissionFlags).toHaveLength(3);
- // Verify the permission was added using the new integration test utilities
const { data, errors } = await findRoles({
gqlFields: `
id
@@ -437,7 +427,6 @@ describe('Granular settings permissions', () => {
});
it('should allow removing setting permissions from existing role', async () => {
- // Remove SECURITY permission, keep only DATA_MODEL and WORKSPACE
const upsertReducedPermissionsQuery = {
query: `
mutation UpsertPermissionFlags {
@@ -462,7 +451,6 @@ describe('Granular settings permissions', () => {
expect(response.body.errors).toBeUndefined();
expect(response.body.data.upsertPermissionFlags).toHaveLength(2);
- // Verify SECURITY permission was removed using the new integration test utilities
const { data, errors } = await findRoles({
gqlFields: `
id
diff --git a/packages/twenty-server/test/integration/graphql/suites/soft-deleted-relation.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/soft-deleted-relation.integration-spec.ts
index 7e6a4264496..fcc027e3c0d 100644
--- a/packages/twenty-server/test/integration/graphql/suites/soft-deleted-relation.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/soft-deleted-relation.integration-spec.ts
@@ -43,7 +43,6 @@ describe('soft-deleted relation', () => {
});
afterAll(async () => {
- // Ensure records are not soft-deleted before destroying
await makeGraphqlAPIRequest(
restoreOneOperationFactory({
objectMetadataSingularName: 'company',
diff --git a/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts
index a538fec55bc..3bbc84c1c11 100644
--- a/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts
@@ -93,7 +93,6 @@ describe('deleteUser', () => {
);
});
- // Sign up a new user into the current workspace via public invite link
const testEmail = `test_user_${Date.now()}@example.com`;
const signUpMutation = signUpOperationFactory({
email: testEmail,
@@ -105,7 +104,6 @@ describe('deleteUser', () => {
expect(signUpResponse.status).toBe(200);
expect(signUpResponse.body.errors).toBeUndefined();
- // Query workspace members and find the created user by email to get workspaceMemberId
const newWorkspaceMemberQuery = {
query: `
query WorkspaceMember($workspaceMemberFilter: WorkspaceMemberFilterInput!) {
diff --git a/packages/twenty-server/test/integration/graphql/suites/workspace/successful-user-and-workspace-creation.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/workspace/successful-user-and-workspace-creation.integration-spec.ts
index 4f602820dbc..3b4739b77cb 100644
--- a/packages/twenty-server/test/integration/graphql/suites/workspace/successful-user-and-workspace-creation.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/workspace/successful-user-and-workspace-creation.integration-spec.ts
@@ -391,7 +391,6 @@ describe('Successful user and workspace creation', () => {
expectToFail: false,
});
- // Create a logic function for workspace deletion test
await createOneLogicFunction({
input: {
name: 'test-function-for-deletion',
diff --git a/packages/twenty-server/test/integration/graphql/utils/create-custom-role-with-object-permissions.util.ts b/packages/twenty-server/test/integration/graphql/utils/create-custom-role-with-object-permissions.util.ts
index 1f95166d56d..c58e53f3086 100644
--- a/packages/twenty-server/test/integration/graphql/utils/create-custom-role-with-object-permissions.util.ts
+++ b/packages/twenty-server/test/integration/graphql/utils/create-custom-role-with-object-permissions.util.ts
@@ -36,7 +36,6 @@ export const createCustomRoleWithObjectPermissions = async (options: {
expect(response.body.data.createOneRole).toBeDefined();
const roleId = response.body.data.createOneRole.id;
- // Get object metadata IDs for Person and Company
const getObjectMetadataOperation = {
query: gql`
query {
@@ -67,7 +66,6 @@ export const createCustomRoleWithObjectPermissions = async (options: {
(obj: any) => obj.node.nameSingular === 'opportunity',
)?.node.id;
- // Create object permissions based on the options
const objectPermissions = [];
if (
diff --git a/packages/twenty-server/test/integration/metadata/suites/agent/successful-agent-creation.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/agent/successful-agent-creation.integration-spec.ts
index 7d950c3b184..c2a8978e55b 100644
--- a/packages/twenty-server/test/integration/metadata/suites/agent/successful-agent-creation.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/agent/successful-agent-creation.integration-spec.ts
@@ -166,7 +166,6 @@ describe('Agent creation should succeed', () => {
});
it('should create agent with role assignment', async () => {
- // First, create a role that can be assigned to agents
const { data: roleData } = await createOneRole({
expectToFail: false,
input: {
diff --git a/packages/twenty-server/test/integration/metadata/suites/field-metadata/kanban-aggregate-field-deactivation-nullifies-views-kanban-properties.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/field-metadata/kanban-aggregate-field-deactivation-nullifies-views-kanban-properties.integration-spec.ts
index 20e408005cd..ea715d716e4 100644
--- a/packages/twenty-server/test/integration/metadata/suites/field-metadata/kanban-aggregate-field-deactivation-nullifies-views-kanban-properties.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/field-metadata/kanban-aggregate-field-deactivation-nullifies-views-kanban-properties.integration-spec.ts
@@ -223,7 +223,6 @@ describe('kanban-aggregate-field-deactivation-nullifies-kanban-properties', () =
await verifyKanbanPropertiesAreNull(testSetup.viewWithAggregateId);
- // View without aggregate should remain unchanged
const {
data: { getView: updatedViewWithoutAggregate },
} = await findOneView({
@@ -328,7 +327,6 @@ describe('kanban-aggregate-field-deactivation-nullifies-kanban-properties', () =
await verifyKanbanPropertiesAreNull(testSetup.viewWithAggregateId);
await verifyKanbanPropertiesAreNull(secondViewWithAggregate.id);
- // View without aggregate should remain unchanged
const {
data: { getView: updatedViewWithoutAggregate },
} = await findOneView({
@@ -417,7 +415,6 @@ describe('kanban-aggregate-field-deactivation-nullifies-kanban-properties', () =
await verifyKanbanPropertiesAreNull(viewWithMin.id);
await verifyKanbanPropertiesAreNull(viewWithAvg.id);
- // View without aggregate should remain unchanged
const {
data: { getView: updatedViewWithoutAggregate },
} = await findOneView({
diff --git a/packages/twenty-server/test/integration/metadata/suites/logic-function/logic-function-execution.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/logic-function/logic-function-execution.integration-spec.ts
index 05e34f77f5d..03866ffd9d0 100644
--- a/packages/twenty-server/test/integration/metadata/suites/logic-function/logic-function-execution.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/logic-function/logic-function-execution.integration-spec.ts
@@ -6,7 +6,6 @@ import { updateLogicFunctionSource } from 'test/integration/metadata/suites/logi
import { LogicFunctionExecutionStatus } from 'src/engine/metadata-modules/logic-function/dtos/logic-function-execution-result.dto';
import { LogicFunctionExecutionMode } from 'src/engine/metadata-modules/logic-function/logic-function.entity';
-// Default template function code that matches the expected behavior
const DEFAULT_TEMPLATE_FUNCTION_CODE = `export const main = async (params: { a: string; b: number }): Promise<object> => {
return { message: \`Toto: \${params.a} and \${params.b}\` };
};`;
@@ -45,7 +44,6 @@ describe('Logic Function Execution', () => {
});
it('should execute the default logic function template', async () => {
- // Create the function with default template code
const { data: createData } = await createOneLogicFunction({
input: {
name: 'Test Default Function',
@@ -94,7 +92,6 @@ describe('Logic Function Execution', () => {
});
it('should execute a function with external packages (lodash.groupby)', async () => {
- // Create the function with the external packages code
const { data: createData } = await createOneLogicFunction({
input: {
name: 'External Packages Test',
@@ -157,7 +154,6 @@ describe('Logic Function Execution', () => {
});
it('should create logic function without source', async () => {
- // Create the function with default template code
const { data: createData } = await createOneLogicFunction({
input: {
name: 'Test Default Function',
@@ -193,7 +189,6 @@ describe('Logic Function Execution', () => {
});
it('should create logic function with source', async () => {
- // Create the function with default template code
const { data: createData } = await createOneLogicFunction({
input: {
name: 'Test Default Function',
@@ -255,7 +250,6 @@ describe('Logic Function Execution', () => {
expectToFail: false,
});
- // Execute with shouldFail = false (should succeed)
const { data: successData } = await executeLogicFunction({
input: {
id: functionId,
@@ -271,7 +265,6 @@ describe('Logic Function Execution', () => {
success: true,
});
- // Execute with shouldFail = true (should return error status)
const { data: errorData } = await executeLogicFunction({
input: {
id: functionId,
diff --git a/packages/twenty-server/test/integration/metadata/suites/role/failing-role-update.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/role/failing-role-update.integration-spec.ts
index a099dd39664..af93bb41e99 100644
--- a/packages/twenty-server/test/integration/metadata/suites/role/failing-role-update.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/role/failing-role-update.integration-spec.ts
@@ -41,12 +41,10 @@ describe('Role update should fail', () => {
let existingRoleIdForDuplicate: string;
beforeAll(async () => {
- // Get a non-editable system role (Admin) for testing
const adminRole = await findOneRoleByLabel({ label: 'Admin' });
globalTestContext.nonEditableRoleId = adminRole.id;
- // Create a role that will be used to test duplicate label validation
const { data: duplicateData } = await createOneRole({
expectToFail: false,
input: {
diff --git a/packages/twenty-server/test/integration/metadata/suites/role/successful-role-update.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/role/successful-role-update.integration-spec.ts
index 17e67c7fdaf..ae064bf186b 100644
--- a/packages/twenty-server/test/integration/metadata/suites/role/successful-role-update.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/role/successful-role-update.integration-spec.ts
@@ -195,7 +195,6 @@ describe('Role update should succeed', () => {
});
it('should update role to read=false when explicitly setting all write permissions to false', async () => {
- // First update the role to have write permissions
await updateOneRole({
expectToFail: false,
input: {
@@ -208,7 +207,6 @@ describe('Role update should succeed', () => {
},
});
- // Now update to read=false with all write permissions explicitly set to false
const { data, errors } = await updateOneRole({
expectToFail: false,
input: {
@@ -234,7 +232,6 @@ describe('Role update should succeed', () => {
});
it('should update role from read=true to read=false with all write=false', async () => {
- // Start with read=true, write=false (default from beforeEach)
const { data, errors } = await updateOneRole({
expectToFail: false,
input: {
diff --git a/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-deletion.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-deletion.integration-spec.ts
index fd3b273a8c6..fddf485e21b 100644
--- a/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-deletion.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-deletion.integration-spec.ts
@@ -52,7 +52,6 @@ describe('Skill deletion should fail', () => {
const standardSkill = data.skills.find((skill) => skill.isCustom === false);
- // If there are no standard skills, skip this test
if (!standardSkill) {
return;
}
diff --git a/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-update.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-update.integration-spec.ts
index 3d0ed51cfdc..ae447bc5cb1 100644
--- a/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-update.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-update.integration-spec.ts
@@ -144,7 +144,6 @@ describe('Skill update should fail', () => {
const standardSkill = data.skills.find((skill) => skill.isCustom === false);
- // If there are no standard skills, skip this test
if (!standardSkill) {
return;
}
diff --git a/packages/twenty-server/test/integration/metadata/suites/view-field-group/upsert-fields-widget.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/view-field-group/upsert-fields-widget.integration-spec.ts
index 79575f5d2c1..414aa8c01e9 100644
--- a/packages/twenty-server/test/integration/metadata/suites/view-field-group/upsert-fields-widget.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/view-field-group/upsert-fields-widget.integration-spec.ts
@@ -367,7 +367,6 @@ describe('upsertFieldsWidget', () => {
const groupId = uuidv4();
- // First assign the field to a group so it has a non-null viewFieldGroupId
await upsertFieldsWidget({
expectToFail: false,
input: {
@@ -390,7 +389,6 @@ describe('upsertFieldsWidget', () => {
},
});
- // Now switch to flat fields with different position and visibility
await upsertFieldsWidget({
expectToFail: false,
input: {
diff --git a/packages/twenty-server/test/integration/metadata/suites/view-filter-group/failing-view-filter-group-update-circular-dependency.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/view-filter-group/failing-view-filter-group-update-circular-dependency.integration-spec.ts
index d65807e422d..ea947cded2c 100644
--- a/packages/twenty-server/test/integration/metadata/suites/view-filter-group/failing-view-filter-group-update-circular-dependency.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/view-filter-group/failing-view-filter-group-update-circular-dependency.integration-spec.ts
@@ -48,7 +48,6 @@ describe('View Filter Group update should fail with circular dependency', () =>
createdViewId = viewData?.createView?.id;
jestExpectToBeDefined(createdViewId);
- // Create a standalone view filter group for self-reference test
const { data: filterGroupData } = await createOneViewFilterGroup({
expectToFail: false,
input: {
@@ -71,7 +70,6 @@ describe('View Filter Group update should fail with circular dependency', () =>
parentViewFilterGroupId = parentFilterGroupData?.createViewFilterGroup?.id;
jestExpectToBeDefined(parentViewFilterGroupId);
- // Create child view filter group with parent reference for chain test
const { data: childFilterGroupData } = await createOneViewFilterGroup({
expectToFail: false,
input: {
diff --git a/packages/twenty-server/test/integration/rest/suites/field-permissions.integration-spec.ts b/packages/twenty-server/test/integration/rest/suites/field-permissions.integration-spec.ts
index a2fc7310815..661ec3b820f 100644
--- a/packages/twenty-server/test/integration/rest/suites/field-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/rest/suites/field-permissions.integration-spec.ts
@@ -47,7 +47,6 @@ describe('Restricted fields', () => {
},
});
- // Get object metadata IDs for Person and Company
const getObjectMetadataOperation = {
query: gql`
query {
@@ -124,7 +123,6 @@ describe('Restricted fields', () => {
(role: any) => role.label === 'Member',
)?.id;
- // Create field permission restricting read access to email field
await upsertFieldPermissions({
roleId: memberRoleId,
fieldPermissions: [
@@ -156,7 +154,6 @@ describe('Restricted fields', () => {
describe('updateOne', () => {
it('should hide fields in the response when user has restricted read permissions', async () => {
- // Create field permission restricting update access to phones field
await upsertFieldPermissions({
roleId: memberRoleId,
fieldPermissions: [
@@ -188,7 +185,6 @@ describe('Restricted fields', () => {
});
});
it('should block update when user tries to update non-updatable field', async () => {
- // Create field permission restricting update access to phones field
await upsertFieldPermissions({
roleId: memberRoleId,
fieldPermissions: [
diff --git a/packages/twenty-server/test/integration/rest/suites/rest-api-core-find-many.integration-spec.ts b/packages/twenty-server/test/integration/rest/suites/rest-api-core-find-many.integration-spec.ts
index ab2a91d6f2d..4f1a37aad70 100644
--- a/packages/twenty-server/test/integration/rest/suites/rest-api-core-find-many.integration-spec.ts
+++ b/packages/twenty-server/test/integration/rest/suites/rest-api-core-find-many.integration-spec.ts
@@ -74,7 +74,6 @@ describe('Core REST API Find Many endpoint', () => {
expect(Array.isArray(people)).toBe(true);
expect(people.length).toBeGreaterThanOrEqual(testPersonIds.length);
- // Check that our test people are included in the results
for (const personId of testPersonIds) {
// @ts-expect-error legacy noImplicitAny
const person = people.find((p) => p.id === personId);
diff --git a/packages/twenty-server/test/integration/rest/suites/rest-api-core-group-by.integration-spec.ts b/packages/twenty-server/test/integration/rest/suites/rest-api-core-group-by.integration-spec.ts
index f83a2d33744..afdb5e59664 100644
--- a/packages/twenty-server/test/integration/rest/suites/rest-api-core-group-by.integration-spec.ts
+++ b/packages/twenty-server/test/integration/rest/suites/rest-api-core-group-by.integration-spec.ts
@@ -238,7 +238,6 @@ describe('REST API Core Group By endpoint', () => {
});
it('groups by stage and closeDate with records and filters', async () => {
- // Test with filter to only include NEW stage opportunities
const groupByQuery = JSON.stringify([
{
closeDate: {
diff --git a/packages/twenty-shared/src/ai/types/agent-response-schema.type.ts b/packages/twenty-shared/src/ai/types/agent-response-schema.type.ts
index d2fa3090dcc..f9c8caba55f 100644
--- a/packages/twenty-shared/src/ai/types/agent-response-schema.type.ts
+++ b/packages/twenty-shared/src/ai/types/agent-response-schema.type.ts
@@ -1,6 +1,3 @@
-// Simple agent response schema for AI SDK using JSON Schema format
-
-// Simple primitive types that map to JSON Schema
export type AgentResponseFieldType = 'string' | 'number' | 'boolean';
// Our simplified schema format (flat object with primitives only)
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-agent-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-agent-universal-identifier.util.ts
index c7fa2566836..f5392eae994 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-agent-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-agent-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// An agent is identified by its name within its application.
export const getAgentUniversalIdentifier = ({
applicationUniversalIdentifier,
name,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-application-variable-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-application-variable-universal-identifier.util.ts
index 6257d5bcb42..61066266ebb 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-application-variable-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-application-variable-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// An application variable is identified by its key within its application.
export const getApplicationVariableUniversalIdentifier = ({
applicationUniversalIdentifier,
key,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-command-menu-item-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-command-menu-item-universal-identifier.util.ts
index b646603068c..df019546b0f 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-command-menu-item-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-command-menu-item-universal-identifier.util.ts
@@ -7,7 +7,6 @@ const NAVIGATION_COMMAND_DISCRIMINATOR = 'navigation';
// RECORD_SELECTION, across objects). One util per availabilityType, prefixed by
// the type, with the target object added only for RECORD_SELECTION.
-// GLOBAL: a command available everywhere, identified by its engineComponentKey.
export const getGlobalCommandMenuItemUniversalIdentifier = ({
applicationUniversalIdentifier,
engineComponentKey,
@@ -54,7 +53,6 @@ export const getRecordSelectionCommandMenuItemUniversalIdentifier = ({
applicationUniversalIdentifier,
});
-// An object's singleton navigation command, keyed by the object + the 'navigation' role.
export const getNavigationCommandUniversalIdentifier = ({
applicationUniversalIdentifier,
objectUniversalIdentifier,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-connection-provider-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-connection-provider-universal-identifier.util.ts
index 206154b354e..231d52d8217 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-connection-provider-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-connection-provider-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A connection provider is identified by its name within its application.
export const getConnectionProviderUniversalIdentifier = ({
applicationUniversalIdentifier,
name,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-field-permission-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-field-permission-universal-identifier.util.ts
index 3b7b9ae2e6c..90275853c1e 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-field-permission-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-field-permission-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A field permission is identified by its field (which implies its object), within its role.
export const getFieldPermissionUniversalIdentifier = ({
applicationUniversalIdentifier,
roleUniversalIdentifier,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-front-component-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-front-component-universal-identifier.util.ts
index 02cc2d859be..68bbae78167 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-front-component-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-front-component-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A front component is identified by its component name within its application.
export const getFrontComponentUniversalIdentifier = ({
applicationUniversalIdentifier,
componentName,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-logic-function-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-logic-function-universal-identifier.util.ts
index a7e1ccc5c63..d359fc7b73d 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-logic-function-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-logic-function-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A logic function is identified by its name within its application.
export const getLogicFunctionUniversalIdentifier = ({
applicationUniversalIdentifier,
name,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-navigation-menu-item-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-navigation-menu-item-universal-identifier.util.ts
index 1fd8189121b..105cc7b8cfd 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-navigation-menu-item-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-navigation-menu-item-universal-identifier.util.ts
@@ -5,7 +5,6 @@ import { computeDeterministicUuid } from '@/application/deterministic-identifier
// target, so each variant has its own discriminator (prefixed by the type to
// keep the shared `navigationMenuItem` namespace collision-free).
-// A FOLDER navigation item is identified by its name within its application.
export const getFolderNavigationMenuItemUniversalIdentifier = ({
applicationUniversalIdentifier,
name,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-object-permission-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-object-permission-universal-identifier.util.ts
index 125ad45c423..e7b0e481099 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-object-permission-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-object-permission-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// An object permission is identified by its object, within its role.
export const getObjectPermissionUniversalIdentifier = ({
applicationUniversalIdentifier,
roleUniversalIdentifier,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-object-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-object-universal-identifier.util.ts
index 608fb12dfb6..ec00202323d 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-object-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-object-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// An object is identified by its nameSingular within its application.
export const getObjectUniversalIdentifier = ({
applicationUniversalIdentifier,
nameSingular,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-permission-flag-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-permission-flag-universal-identifier.util.ts
index 94a68292382..b76b8139bef 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-permission-flag-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-permission-flag-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A permission flag is identified by its key within its application.
export const getPermissionFlagUniversalIdentifier = ({
applicationUniversalIdentifier,
key,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-role-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-role-universal-identifier.util.ts
index 4365589da5d..98c58c173a7 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-role-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-role-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A role is identified by its label within its application.
export const getRoleUniversalIdentifier = ({
applicationUniversalIdentifier,
label,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-skill-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-skill-universal-identifier.util.ts
index 97bd5cd6747..f1c400ff16f 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-skill-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-skill-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A skill is identified by its name within its application.
export const getSkillUniversalIdentifier = ({
applicationUniversalIdentifier,
name,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-system-page-layout-tab-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-system-page-layout-tab-universal-identifier.util.ts
index 61a02d12fcf..045e87495a2 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-system-page-layout-tab-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-system-page-layout-tab-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A tab is identified by its title within its page layout.
export const getSystemPageLayoutTabUniversalIdentifier = ({
objectMetadataApplicationUniversalIdentifier,
pageLayoutUniversalIdentifier,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-system-page-layout-widget-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-system-page-layout-widget-universal-identifier.util.ts
index 00b03a4a99e..ea5b47ca492 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-system-page-layout-widget-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-system-page-layout-widget-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A widget is identified by its title within its tab.
export const getSystemPageLayoutWidgetUniversalIdentifier = ({
objectMetadataApplicationUniversalIdentifier,
pageLayoutTabUniversalIdentifier,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-system-view-field-group-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-system-view-field-group-universal-identifier.util.ts
index 9b8c45337f0..59a23d36dac 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-system-view-field-group-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-system-view-field-group-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A view field group is identified by its name within its view.
export const getSystemViewFieldGroupUniversalIdentifier = ({
objectMetadataApplicationUniversalIdentifier,
viewUniversalIdentifier,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-view-field-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-view-field-universal-identifier.util.ts
index 2535a96584d..1282ef42881 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-view-field-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-view-field-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A view field is identified by the field it displays, within its view.
export const getViewFieldUniversalIdentifier = ({
applicationUniversalIdentifier,
viewUniversalIdentifier,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-view-group-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-view-group-universal-identifier.util.ts
index 470afaab328..1555ff57844 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-view-group-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-view-group-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A view group is identified by the field value it groups by, within its view.
export const getViewGroupUniversalIdentifier = ({
applicationUniversalIdentifier,
viewUniversalIdentifier,
diff --git a/packages/twenty-shared/src/application/deterministic-identifier/get-view-sort-universal-identifier.util.ts b/packages/twenty-shared/src/application/deterministic-identifier/get-view-sort-universal-identifier.util.ts
index 5ed7a155927..9e942de45d9 100644
--- a/packages/twenty-shared/src/application/deterministic-identifier/get-view-sort-universal-identifier.util.ts
+++ b/packages/twenty-shared/src/application/deterministic-identifier/get-view-sort-universal-identifier.util.ts
@@ -1,6 +1,5 @@
import { computeDeterministicUuid } from '@/application/deterministic-identifier/compute-deterministic-uuid.util';
-// A view sort is identified by the field it sorts, within its view.
export const getViewSortUniversalIdentifier = ({
applicationUniversalIdentifier,
viewUniversalIdentifier,
diff --git a/packages/twenty-shared/src/types/IndexOf.type.ts b/packages/twenty-shared/src/types/IndexOf.type.ts
index 5b78e61a1bb..2747623337c 100644
--- a/packages/twenty-shared/src/types/IndexOf.type.ts
+++ b/packages/twenty-shared/src/types/IndexOf.type.ts
@@ -1,4 +1,3 @@
-// Finds the index of T in a readonly string tuple.
export type IndexOf<
T extends string,
Arr extends readonly string[],
diff --git a/packages/twenty-shared/src/types/__tests__/extract-serialized-relation-properties.type-test.ts b/packages/twenty-shared/src/types/__tests__/extract-serialized-relation-properties.type-test.ts
index 8187fc42c4d..2c6ca49e141 100644
--- a/packages/twenty-shared/src/types/__tests__/extract-serialized-relation-properties.type-test.ts
+++ b/packages/twenty-shared/src/types/__tests__/extract-serialized-relation-properties.type-test.ts
@@ -12,7 +12,6 @@ type TestedRecord = {
plainStringNullable: string | null;
plainStringOptional?: string;
- // SerializedRelation fields - should be extracted
relation: SerializedRelation;
relationNullable: SerializedRelation | null;
relationUndefinable: SerializedRelation | undefined;
@@ -35,12 +34,10 @@ type Assertions = [
>
>,
- // Object with no SerializedRelation fields returns never
Expect<
Equal<ExtractSerializedRelationProperties<{ a: string; b: number }>, never>
>,
- // Primitives return never (tests T extends object branch)
Expect<Equal<ExtractSerializedRelationProperties<string>, never>>,
Expect<Equal<ExtractSerializedRelationProperties<number>, never>>,
Expect<Equal<ExtractSerializedRelationProperties<null>, never>>,
diff --git a/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts b/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts
index c8a86bc0d1a..a0deb9aa133 100644
--- a/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts
+++ b/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts
@@ -419,7 +419,6 @@ describe('applyDiff', () => {
};
const diffs: Difference[] = [
- // Try to remove forbidden keys (these should be silently skipped)
{ type: 'REMOVE', path: ['__proto__'], oldValue: 'anything' },
{ type: 'REMOVE', path: ['constructor'], oldValue: 'anything' },
{ type: 'REMOVE', path: ['prototype'], oldValue: 'anything' },
@@ -428,7 +427,6 @@ describe('applyDiff', () => {
const result = applyDiff(obj, diffs);
- // Only the safe property should be removed, normalProp should remain
expect(result).toEqual({
normalProp: 'normal',
});
diff --git a/packages/twenty-shared/src/utils/__tests__/safeParseRelativeDateFilterValue.test.ts b/packages/twenty-shared/src/utils/__tests__/safeParseRelativeDateFilterValue.test.ts
index 7a04825a5a6..facfcfc6592 100644
--- a/packages/twenty-shared/src/utils/__tests__/safeParseRelativeDateFilterValue.test.ts
+++ b/packages/twenty-shared/src/utils/__tests__/safeParseRelativeDateFilterValue.test.ts
@@ -520,7 +520,6 @@ describe('safeParseRelativeDateFilterJsonStringified', () => {
unit: 'DAY',
});
- // THIS direction should work with amount present, as the schema allows it
const result = safeParseRelativeDateFilterJsonStringified(input);
expect(result).toEqual({
direction: 'THIS',
diff --git a/packages/twenty-shared/src/utils/applyDiff.ts b/packages/twenty-shared/src/utils/applyDiff.ts
index 02f689ba5a0..a5333474831 100644
--- a/packages/twenty-shared/src/utils/applyDiff.ts
+++ b/packages/twenty-shared/src/utils/applyDiff.ts
@@ -171,7 +171,6 @@ const handleRemoval = (
}
};
-// Handles removal from arrays by marking for deletion and queuing cleanup
const handleArrayRemoval = (
rootObj: MutableData,
fullPath: (string | number)[],
diff --git a/packages/twenty-shared/src/utils/url/normalizeUrl.ts b/packages/twenty-shared/src/utils/url/normalizeUrl.ts
index 76e7c718c38..e307128bd83 100644
--- a/packages/twenty-shared/src/utils/url/normalizeUrl.ts
+++ b/packages/twenty-shared/src/utils/url/normalizeUrl.ts
@@ -1,7 +1,6 @@
import { ensureAbsoluteUrl } from '@/utils/url/ensureAbsoluteUrl';
import { normalizeUrlOrigin } from '@/utils/url/normalizeUrlOrigin';
-// Ensures the URL has a protocol, lowercases the origin, and removes a trailing slash.
export const normalizeUrl = (url: string): string => {
const trimmed = url.trim();
diff --git a/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.record-event.test.ts b/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.record-event.test.ts
index 88e43ad57f6..169ba978fbf 100644
--- a/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.record-event.test.ts
+++ b/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.record-event.test.ts
@@ -28,7 +28,6 @@ describe('searchVariableInOutputSchema - record event output schema', () => {
label: 'Company',
},
fields: {
- // Event-based fields with properties.after prefix
'properties.after.name': {
isLeaf: true,
type: FieldMetadataType.TEXT,
@@ -93,7 +92,6 @@ describe('searchVariableInOutputSchema - record event output schema', () => {
_outputSchemaType: 'RECORD',
},
},
- // Event-based fields with properties.before prefix
'properties.before.name': {
isLeaf: true,
type: FieldMetadataType.TEXT,