Skip to content

The open alternative to Salesforce, designed for AI.

fix(ai-chat): strip NUL bytes from message parts before persisting (#27101)

Etienne83d85c4ea290
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/__tests__/normalize-tool-output-to-json-values.util.spec.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/__tests__/normalize-tool-output-to-json-values.util.spec.ts
index 87f0d90fa91..db33ddb42e2 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/__tests__/normalize-tool-output-to-json-values.util.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/__tests__/normalize-tool-output-to-json-values.util.spec.ts
@@ -43,6 +43,32 @@ describe('normalizeToolOutputToJsonValues', () => {
},
});
});
+
+ it('strips NUL characters from string values', () => {
+ expect(
+ normalizeToolOutputToJsonValues({
+ success: true,
+ message: 'Request successful',
+ result: { body: 'PK\u0003\u0004\u0000\u0000', rows: [['A\u0000']] },
+ }),
+ ).toEqual({
+ success: true,
+ message: 'Request successful',
+ result: { body: 'PK\u0003\u0004', rows: [['A']] },
+ });
+ });
+
+ it('keeps a literal backslash followed by u0000', () => {
+ const literalEscapeOutput = {
+ success: true,
+ message: 'Code executed',
+ result: { code: 'split("\\u0000")' },
+ };
+
+ expect(normalizeToolOutputToJsonValues(literalEscapeOutput)).toEqual(
+ literalEscapeOutput,
+ );
+ });
});
describe('tool output reaching the model', () => {
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/normalize-tool-output-to-json-values.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/normalize-tool-output-to-json-values.util.ts
index 36b0ac566ac..ba435c5c95e 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/normalize-tool-output-to-json-values.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/output-transforms/normalize-tool-output-to-json-values.util.ts
@@ -1,10 +1,19 @@
+import { isString } from '@sniptt/guards';
+
import { type ToolOutput } from 'src/engine/core-modules/tool/types/tool-output.type';
+const stripNulCharacters = (_key: string, value: unknown) =>
+ isString(value) ? value.replace(/\0/g, '') : value;
+
export const normalizeToolOutputToJsonValues = (
output: ToolOutput,
): ToolOutput => {
try {
- return JSON.parse(JSON.stringify(output));
+ const serializedOutput = JSON.stringify(output);
+
+ return serializedOutput.includes('\\u0000')
+ ? JSON.parse(serializedOutput, stripNulCharacters)
+ : JSON.parse(serializedOutput);
} catch {
return output;
}