Skip to content

The open alternative to Salesforce, designed for AI.

Make log console table columns resizable (#29179)

martmull84bac97ba532
diff --git a/packages/twenty-front/src/modules/log-console/components/LogConsoleTable.tsx b/packages/twenty-front/src/modules/log-console/components/LogConsoleTable.tsx
index 49bb653378f..a7bfc81f5f3 100644
--- a/packages/twenty-front/src/modules/log-console/components/LogConsoleTable.tsx
+++ b/packages/twenty-front/src/modules/log-console/components/LogConsoleTable.tsx
@@ -1,19 +1,23 @@
import { SkeletonLine } from '@/ui/feedback/skeleton/components/SkeletonLine';
import { styled } from '@linaria/react';
-import { useLingui } from '@lingui/react/macro';
import { Fragment } from 'react';
import { useInView } from 'react-intersection-observer';
import { isDefined } from 'twenty-shared/utils';
import { themeCssVariables } from 'twenty-ui/theme';
+import { LogConsoleTableHeaderCell } from '@/log-console/components/LogConsoleTableHeaderCell';
import { LOG_CONSOLE_ANIMATION_EASING } from '@/log-console/constants/LogConsoleAnimationEasing';
+import { LOG_CONSOLE_TABLE_HTML_ID } from '@/log-console/constants/LogConsoleTableHtmlId';
import { LOG_CONSOLE_TABLE_SCROLL_WRAPPER_ID } from '@/log-console/constants/LogConsoleTableScrollWrapperId';
+import { logConsoleColumnWidthsFamilyState } from '@/log-console/states/logConsoleColumnWidthsFamilyState';
import { type LogConsoleSource } from '@/log-console/types/LogConsoleSource';
+import { getLogConsoleColumnWidthCSSVariableName } from '@/log-console/utils/getLogConsoleColumnWidthCSSVariableName';
+import { updateLogConsoleTableCSSVariable } from '@/log-console/utils/updateLogConsoleTableCSSVariable';
import { Table } from '@/ui/layout/table/components/Table';
import { TableCell } from '@/ui/layout/table/components/TableCell';
-import { TableHeader } from '@/ui/layout/table/components/TableHeader';
import { TableRow } from '@/ui/layout/table/components/TableRow';
+import { useAtomFamilyState } from '@/ui/utilities/state/jotai/hooks/useAtomFamilyState';
import { ScrollWrapper } from '@/ui/utilities/scroll/components/ScrollWrapper';
import { useScrollWrapperHTMLElement } from '@/ui/utilities/scroll/hooks/useScrollWrapperHTMLElement';
import { type EventLogRecord } from '~/generated-metadata/graphql';
@@ -103,8 +107,6 @@ export const LogConsoleTable = ({
onLoadMore,
onEntryClick,
}: LogConsoleTableProps) => {
- const { t } = useLingui();
-
const { scrollWrapperHTMLElement } = useScrollWrapperHTMLElement(
LOG_CONSOLE_TABLE_SCROLL_WRAPPER_ID,
);
@@ -119,12 +121,54 @@ export const LogConsoleTable = ({
},
});
+ const [columnWidths, setColumnWidths] = useAtomFamilyState(
+ logConsoleColumnWidthsFamilyState,
+ source.id,
+ );
+
const columns = source.columns;
const gridTemplateColumns = columns
- .map((column) => column.gridTrack)
+ .map((column) => {
+ const storedWidth = columnWidths[column.id];
+ const track = isDefined(storedWidth)
+ ? `${storedWidth}px`
+ : column.gridTrack;
+
+ return `var(${getLogConsoleColumnWidthCSSVariableName(column.id)}, ${track})`;
+ })
.join(' ');
+ const clearColumnWidthPreview = (columnId: string) => {
+ updateLogConsoleTableCSSVariable(
+ getLogConsoleColumnWidthCSSVariableName(columnId),
+ null,
+ );
+ };
+
+ const handleColumnWidthPreview = (columnId: string, width: number) => {
+ updateLogConsoleTableCSSVariable(
+ getLogConsoleColumnWidthCSSVariableName(columnId),
+ `${width}px`,
+ );
+ };
+
+ const handleColumnWidthCommitted = (columnId: string, width: number) => {
+ clearColumnWidthPreview(columnId);
+ setColumnWidths((previousColumnWidths) => ({
+ ...previousColumnWidths,
+ [columnId]: width,
+ }));
+ };
+
+ const handleColumnWidthReset = (columnId: string) => {
+ clearColumnWidthPreview(columnId);
+ setColumnWidths(
+ ({ [columnId]: _resetColumnWidth, ...remainingColumnWidths }) =>
+ remainingColumnWidths,
+ );
+ };
+
const isInitialLoading = loading && entries.length === 0;
const isLoadingNextPage = loading && hasNextPage;
@@ -158,15 +202,24 @@ export const LogConsoleTable = ({
return (
<ScrollWrapper componentInstanceId={LOG_CONSOLE_TABLE_SCROLL_WRAPPER_ID}>
- <StyledTable>
+ <StyledTable id={LOG_CONSOLE_TABLE_HTML_ID}>
<StyledHeaderRow
gridTemplateColumns={gridTemplateColumns}
hoverBackgroundColor={themeCssVariables.background.primary}
>
{columns.map((column) => (
- <TableHeader key={column.id} align={column.align}>
- {t(column.label)}
- </TableHeader>
+ <LogConsoleTableHeaderCell
+ key={column.id}
+ column={column}
+ onWidthPreview={(width) =>
+ handleColumnWidthPreview(column.id, width)
+ }
+ onWidthCommitted={(width) =>
+ handleColumnWidthCommitted(column.id, width)
+ }
+ onWidthReset={() => handleColumnWidthReset(column.id)}
+ onResizeEnd={() => clearColumnWidthPreview(column.id)}
+ />
))}
</StyledHeaderRow>
{entries.map((entry, entryIndex) =>
diff --git a/packages/twenty-front/src/modules/log-console/components/LogConsoleTableHeaderCell.tsx b/packages/twenty-front/src/modules/log-console/components/LogConsoleTableHeaderCell.tsx
new file mode 100644
index 00000000000..7010acacc11
--- /dev/null
+++ b/packages/twenty-front/src/modules/log-console/components/LogConsoleTableHeaderCell.tsx
@@ -0,0 +1,121 @@
+import { styled } from '@linaria/react';
+import { useLingui } from '@lingui/react/macro';
+import {
+ type FocusEvent,
+ type MouseEvent,
+ type PointerEvent,
+ useState,
+} from 'react';
+import { isDefined } from 'twenty-shared/utils';
+import { ResizeHandle } from 'twenty-ui/primitives/layout';
+import { themeCssVariables } from 'twenty-ui/theme';
+
+import { LOG_CONSOLE_COLUMN_WIDTH_CONSTRAINTS } from '@/log-console/constants/LogConsoleColumnWidthConstraints';
+import { type LogConsoleColumn } from '@/log-console/types/LogConsoleColumn';
+import { TableHeader } from '@/ui/layout/table/components/TableHeader';
+import { getUiZoom } from '@/ui/theme/utils/getUiZoom';
+
+const StyledTableHeader = styled(TableHeader)`
+ min-width: 0;
+ overflow: hidden;
+ position: relative;
+ white-space: nowrap;
+`;
+
+const StyledResizeHandleBar = styled.div`
+ align-self: stretch;
+ background-color: transparent;
+ margin-block: ${themeCssVariables.spacing[2]};
+ transition: background-color
+ calc(${themeCssVariables.animation.duration.fast} * 1s);
+ width: 1px;
+`;
+
+const StyledResizeHandleContainer = styled.div`
+ bottom: 0;
+ display: flex;
+ justify-content: flex-end;
+ position: absolute;
+ right: 0;
+ top: 0;
+
+ > [role='separator'] {
+ justify-content: flex-end;
+ }
+
+ > [role='separator']:is(:hover, :focus-visible, [data-resizing])
+ > ${StyledResizeHandleBar} {
+ background-color: ${themeCssVariables.border.color.strong};
+ }
+`;
+
+type LogConsoleTableHeaderCellProps = {
+ column: LogConsoleColumn;
+ onWidthPreview: (width: number) => void;
+ onWidthCommitted: (width: number) => void;
+ onWidthReset: () => void;
+ onResizeEnd: () => void;
+};
+
+export const LogConsoleTableHeaderCell = ({
+ column,
+ onWidthPreview,
+ onWidthCommitted,
+ onWidthReset,
+ onResizeEnd,
+}: LogConsoleTableHeaderCellProps) => {
+ const { t } = useLingui();
+ const [width, setWidth] = useState(0);
+
+ const measureHeaderWidth = (handleElement: HTMLElement) => {
+ const headerElement = handleElement.closest<HTMLElement>(
+ '[data-table-header]',
+ );
+
+ if (isDefined(headerElement)) {
+ setWidth(headerElement.offsetWidth);
+ }
+ };
+
+ const measureWidth = (
+ event: PointerEvent<HTMLDivElement> | FocusEvent<HTMLDivElement>,
+ ) => measureHeaderWidth(event.currentTarget);
+
+ const handleDoubleClick = (event: MouseEvent<HTMLDivElement>) => {
+ const handleElement = event.currentTarget;
+
+ onWidthReset();
+ requestAnimationFrame(() => measureHeaderWidth(handleElement));
+ };
+
+ const handleValueChange = (nextWidth: number) => {
+ setWidth(nextWidth);
+ onWidthPreview(nextWidth);
+ };
+
+ const label = t(column.label);
+
+ return (
+ <StyledTableHeader align={column.align}>
+ {label}
+ <StyledResizeHandleContainer>
+ <ResizeHandle
+ axis="x"
+ min={LOG_CONSOLE_COLUMN_WIDTH_CONSTRAINTS.min}
+ max={LOG_CONSOLE_COLUMN_WIDTH_CONSTRAINTS.max}
+ value={width}
+ onValueChange={handleValueChange}
+ onValueCommitted={onWidthCommitted}
+ onResizeEnd={onResizeEnd}
+ onPointerEnter={measureWidth}
+ onFocus={measureWidth}
+ onDoubleClick={handleDoubleClick}
+ aria-label={t`Resize ${label} column`}
+ scale={getUiZoom}
+ >
+ <StyledResizeHandleBar />
+ </ResizeHandle>
+ </StyledResizeHandleContainer>
+ </StyledTableHeader>
+ );
+};
diff --git a/packages/twenty-front/src/modules/log-console/constants/LogConsoleColumnWidthConstraints.ts b/packages/twenty-front/src/modules/log-console/constants/LogConsoleColumnWidthConstraints.ts
new file mode 100644
index 00000000000..cfa5c08bcb1
--- /dev/null
+++ b/packages/twenty-front/src/modules/log-console/constants/LogConsoleColumnWidthConstraints.ts
@@ -0,0 +1,4 @@
+export const LOG_CONSOLE_COLUMN_WIDTH_CONSTRAINTS = {
+ min: 64,
+ max: 1200,
+};
diff --git a/packages/twenty-front/src/modules/log-console/constants/LogConsoleTableHtmlId.ts b/packages/twenty-front/src/modules/log-console/constants/LogConsoleTableHtmlId.ts
new file mode 100644
index 00000000000..9e9d32b98ef
--- /dev/null
+++ b/packages/twenty-front/src/modules/log-console/constants/LogConsoleTableHtmlId.ts
@@ -0,0 +1 @@
+export const LOG_CONSOLE_TABLE_HTML_ID = 'log-console-table';
diff --git a/packages/twenty-front/src/modules/log-console/states/logConsoleColumnWidthsFamilyState.ts b/packages/twenty-front/src/modules/log-console/states/logConsoleColumnWidthsFamilyState.ts
new file mode 100644
index 00000000000..bdfa65b494e
--- /dev/null
+++ b/packages/twenty-front/src/modules/log-console/states/logConsoleColumnWidthsFamilyState.ts
@@ -0,0 +1,12 @@
+import { type LogConsoleSourceId } from '@/log-console/types/LogConsoleSourceId';
+import { createAtomFamilyState } from '@/ui/utilities/state/jotai/utils/createAtomFamilyState';
+
+export const logConsoleColumnWidthsFamilyState = createAtomFamilyState<
+ Record<string, number>,
+ LogConsoleSourceId
+>({
+ key: 'logConsoleColumnWidthsFamilyState',
+ defaultValue: {},
+ useLocalStorage: true,
+ localStorageOptions: { getOnInit: true },
+});
diff --git a/packages/twenty-front/src/modules/log-console/utils/getLogConsoleColumnWidthCSSVariableName.ts b/packages/twenty-front/src/modules/log-console/utils/getLogConsoleColumnWidthCSSVariableName.ts
new file mode 100644
index 00000000000..e22fddef7e0
--- /dev/null
+++ b/packages/twenty-front/src/modules/log-console/utils/getLogConsoleColumnWidthCSSVariableName.ts
@@ -0,0 +1,2 @@
+export const getLogConsoleColumnWidthCSSVariableName = (columnId: string) =>
+ `--log-console-column-${columnId}-width`;
diff --git a/packages/twenty-front/src/modules/log-console/utils/updateLogConsoleTableCSSVariable.ts b/packages/twenty-front/src/modules/log-console/utils/updateLogConsoleTableCSSVariable.ts
new file mode 100644
index 00000000000..64b0156333d
--- /dev/null
+++ b/packages/twenty-front/src/modules/log-console/utils/updateLogConsoleTableCSSVariable.ts
@@ -0,0 +1,18 @@
+import { isDefined } from 'twenty-shared/utils';
+
+import { LOG_CONSOLE_TABLE_HTML_ID } from '@/log-console/constants/LogConsoleTableHtmlId';
+
+export const updateLogConsoleTableCSSVariable = (
+ cssVariableName: string,
+ newValue: string | null,
+) => {
+ const tableElement = document.querySelector<HTMLDivElement>(
+ `#${LOG_CONSOLE_TABLE_HTML_ID}`,
+ );
+
+ if (isDefined(newValue)) {
+ tableElement?.style.setProperty(cssVariableName, newValue);
+ } else {
+ tableElement?.style.removeProperty(cssVariableName);
+ }
+};