Skip to content

The open alternative to Salesforce, designed for AI.

Accessibility fix pass for remaining twenty-ui domains (#21790)

Raphaël Bosi86a4066997d6
diff --git a/packages/twenty-ui/src/data-display/AvatarGroup/__stories__/AvatarGroup.stories.tsx b/packages/twenty-ui/src/data-display/AvatarGroup/__stories__/AvatarGroup.stories.tsx
index cd1ce6ec84f..f65790115f3 100644
--- a/packages/twenty-ui/src/data-display/AvatarGroup/__stories__/AvatarGroup.stories.tsx
+++ b/packages/twenty-ui/src/data-display/AvatarGroup/__stories__/AvatarGroup.stories.tsx
@@ -4,6 +4,7 @@ import { Avatar, type AvatarProps } from '@ui/data-display/Avatar/Avatar';
import { type AvatarSize } from '@ui/data-display/Avatar/types/AvatarSize';
import { type AvatarType } from '@ui/data-display/Avatar/types/AvatarType';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
AVATAR_URL_MOCK,
CatalogDecorator,
ComponentDecorator,
@@ -47,8 +48,7 @@ export const Default: Story = {
export const Catalog: Story = {
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/data-display/Chip/__stories__/Chip.stories.tsx b/packages/twenty-ui/src/data-display/Chip/__stories__/Chip.stories.tsx
index 6f683edca04..f3ac456b91b 100644
--- a/packages/twenty-ui/src/data-display/Chip/__stories__/Chip.stories.tsx
+++ b/packages/twenty-ui/src/data-display/Chip/__stories__/Chip.stories.tsx
@@ -3,6 +3,7 @@ import { IconUser, IconX } from '@ui/icon';
import { Avatar } from '@ui/data-display/Avatar/Avatar';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogStory,
ComponentDecorator,
@@ -64,8 +65,7 @@ export const WithLeftIcon: Story = {
};
export const EmptyLabel: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
label: '',
clickable: true,
@@ -89,8 +89,7 @@ export const Catalog: CatalogStory<Story, typeof Chip> = {
leftComponent: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.active'] },
catalog: {
dimensions: [
@@ -153,8 +152,7 @@ export const WithAvatarCatalog: CatalogStory<Story, typeof Chip> = {
leftComponent: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.active'] },
catalog: {
dimensions: [
diff --git a/packages/twenty-ui/src/data-display/LinkChip/__stories__/LinkChip.stories.tsx b/packages/twenty-ui/src/data-display/LinkChip/__stories__/LinkChip.stories.tsx
index 652748f20c5..e277147afca 100644
--- a/packages/twenty-ui/src/data-display/LinkChip/__stories__/LinkChip.stories.tsx
+++ b/packages/twenty-ui/src/data-display/LinkChip/__stories__/LinkChip.stories.tsx
@@ -2,6 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { IconUser, IconX } from '@ui/icon';
import { Avatar } from '@ui/data-display/Avatar/Avatar';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogStory,
ComponentDecorator,
@@ -75,8 +76,7 @@ export const Catalog: CatalogStory<Story, typeof LinkChip> = {
leftComponent: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.active'] },
catalog: {
dimensions: [
@@ -136,8 +136,7 @@ export const WithAvatarCatalog: CatalogStory<Story, typeof LinkChip> = {
leftComponent: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.active'] },
catalog: {
dimensions: [
diff --git a/packages/twenty-ui/src/data-display/Status/__stories__/Status.stories.tsx b/packages/twenty-ui/src/data-display/Status/__stories__/Status.stories.tsx
index ee96c0edbc9..58bc14798d1 100644
--- a/packages/twenty-ui/src/data-display/Status/__stories__/Status.stories.tsx
+++ b/packages/twenty-ui/src/data-display/Status/__stories__/Status.stories.tsx
@@ -1,5 +1,6 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogStory,
ComponentDecorator,
@@ -44,8 +45,7 @@ export const WithLongText: Story = {
text: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit',
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
container: { width: 100 },
},
};
@@ -55,8 +55,7 @@ export const Catalog: CatalogStory<Story, typeof Status> = {
color: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/data-display/Tag/__stories__/Tag.stories.tsx b/packages/twenty-ui/src/data-display/Tag/__stories__/Tag.stories.tsx
index 611a547addd..e9d0b644349 100644
--- a/packages/twenty-ui/src/data-display/Tag/__stories__/Tag.stories.tsx
+++ b/packages/twenty-ui/src/data-display/Tag/__stories__/Tag.stories.tsx
@@ -3,6 +3,7 @@ import { expect, fn, userEvent, within } from 'storybook/test';
import { IconUser } from '@ui/icon/components/TablerIcons';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogStory,
ComponentDecorator,
@@ -45,8 +46,7 @@ export const WithLongText: Story = {
text: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit',
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
container: { width: 100 },
},
};
@@ -59,8 +59,7 @@ export const WithIcon: Story = {
Icon: IconUser,
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
container: { width: 100 },
},
};
@@ -73,8 +72,7 @@ export const DontShrink: Story = {
preventShrink: true,
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
container: { width: 100 },
},
};
@@ -84,8 +82,7 @@ export const Catalog: CatalogStory<Story, typeof Tag> = {
color: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/feedback/Banner/__stories__/Banner.stories.tsx b/packages/twenty-ui/src/feedback/Banner/__stories__/Banner.stories.tsx
index b768d48583b..93042ddeb81 100644
--- a/packages/twenty-ui/src/feedback/Banner/__stories__/Banner.stories.tsx
+++ b/packages/twenty-ui/src/feedback/Banner/__stories__/Banner.stories.tsx
@@ -2,6 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { IconX } from '@ui/icon';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogStory,
ComponentDecorator,
@@ -111,8 +112,7 @@ export const Catalog: CatalogStory<Story, typeof Banner> = {
</Banner>
),
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/feedback/Callout/__stories__/Callout.stories.tsx b/packages/twenty-ui/src/feedback/Callout/__stories__/Callout.stories.tsx
index 7366659d375..0dba30466ca 100644
--- a/packages/twenty-ui/src/feedback/Callout/__stories__/Callout.stories.tsx
+++ b/packages/twenty-ui/src/feedback/Callout/__stories__/Callout.stories.tsx
@@ -1,5 +1,6 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogStory,
ComponentDecorator,
@@ -17,8 +18,7 @@ export default meta;
type Story = StoryObj<typeof Callout>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
variant: 'neutral',
title: 'This form will appear in workflow runs.',
@@ -46,8 +46,7 @@ export const Catalog: CatalogStory<Story, typeof Callout> = {
variant: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/feedback/CircularProgressBar/__stories__/CircularProgressBar.stories.tsx b/packages/twenty-ui/src/feedback/CircularProgressBar/__stories__/CircularProgressBar.stories.tsx
index 31618545df8..99e95b44f95 100644
--- a/packages/twenty-ui/src/feedback/CircularProgressBar/__stories__/CircularProgressBar.stories.tsx
+++ b/packages/twenty-ui/src/feedback/CircularProgressBar/__stories__/CircularProgressBar.stories.tsx
@@ -1,5 +1,9 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
-import { CatalogDecorator, type CatalogStory } from '@ui/testing';
+import {
+ A11Y_DEFER_COLOR_CONTRAST,
+ CatalogDecorator,
+ type CatalogStory,
+} from '@ui/testing';
import { ComponentDecorator } from '@ui/testing/decorators/ComponentDecorator';
import { CircularProgressBar } from '@ui/feedback/CircularProgressBar/CircularProgressBar';
@@ -26,8 +30,7 @@ export const Default: Story = {
export const Catalog: CatalogStory<Story, typeof CircularProgressBar> = {
argTypes: {},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/feedback/Info/__stories__/Info.stories.tsx b/packages/twenty-ui/src/feedback/Info/__stories__/Info.stories.tsx
index aad143a6302..3867bb446c6 100644
--- a/packages/twenty-ui/src/feedback/Info/__stories__/Info.stories.tsx
+++ b/packages/twenty-ui/src/feedback/Info/__stories__/Info.stories.tsx
@@ -1,5 +1,6 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogStory,
ComponentDecorator,
@@ -16,8 +17,7 @@ export default meta;
type Story = StoryObj<typeof Info>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
accent: 'blue',
text: 'An info component',
@@ -35,8 +35,7 @@ export const Catalog: CatalogStory<Story, typeof Info> = {
accent: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/feedback/ProgressBar/ProgressBar.tsx b/packages/twenty-ui/src/feedback/ProgressBar/ProgressBar.tsx
index ba531cb11f0..7b0274898e7 100644
--- a/packages/twenty-ui/src/feedback/ProgressBar/ProgressBar.tsx
+++ b/packages/twenty-ui/src/feedback/ProgressBar/ProgressBar.tsx
@@ -8,6 +8,7 @@ export type ProgressBarProps = {
barColor?: string;
backgroundColor?: string;
withBorderRadius?: boolean;
+ ariaLabel?: string;
};
export type StyledBarProps = {
@@ -24,11 +25,13 @@ export const ProgressBar = ({
barColor,
backgroundColor = 'none',
withBorderRadius = false,
+ ariaLabel,
}: ProgressBarProps) => (
<div
className={clsx(styles.bar, className)}
data-with-border-radius={withBorderRadius || undefined}
role="progressbar"
+ aria-label={ariaLabel}
aria-valuenow={Math.ceil(value)}
style={
{
diff --git a/packages/twenty-ui/src/feedback/ProgressBar/__stories__/ProgressBar.stories.tsx b/packages/twenty-ui/src/feedback/ProgressBar/__stories__/ProgressBar.stories.tsx
index f704a10a585..3b9e37cba11 100644
--- a/packages/twenty-ui/src/feedback/ProgressBar/__stories__/ProgressBar.stories.tsx
+++ b/packages/twenty-ui/src/feedback/ProgressBar/__stories__/ProgressBar.stories.tsx
@@ -18,10 +18,9 @@ export default meta;
type Story = StoryObj<typeof ProgressBar>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
args: {
value: 75,
+ ariaLabel: 'Progress',
},
};
diff --git a/packages/twenty-ui/src/feedback/SidePanelInformationBanner/__stories__/SidePanelInformationBanner.stories.tsx b/packages/twenty-ui/src/feedback/SidePanelInformationBanner/__stories__/SidePanelInformationBanner.stories.tsx
index 0af66be4dd3..bdc6639c5b7 100644
--- a/packages/twenty-ui/src/feedback/SidePanelInformationBanner/__stories__/SidePanelInformationBanner.stories.tsx
+++ b/packages/twenty-ui/src/feedback/SidePanelInformationBanner/__stories__/SidePanelInformationBanner.stories.tsx
@@ -1,5 +1,5 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
-import { ComponentDecorator } from '@ui/testing';
+import { A11Y_DEFER_COLOR_CONTRAST, ComponentDecorator } from '@ui/testing';
import { SidePanelInformationBanner } from '@ui/feedback/SidePanelInformationBanner/SidePanelInformationBanner';
const meta: Meta<typeof SidePanelInformationBanner> = {
@@ -12,24 +12,21 @@ export default meta;
type Story = StoryObj<typeof SidePanelInformationBanner>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
message: 'Max 200 bars per chart. Consider adding a filter',
},
};
export const ShortMessage: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
message: 'Too many groups',
},
};
export const LongMessage: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
message:
'The chart has exceeded the maximum number of 200 bars. Please consider adding filters to reduce the number of data points displayed.',
diff --git a/packages/twenty-ui/src/json-visualizer/__stories__/JsonTree.stories.tsx b/packages/twenty-ui/src/json-visualizer/__stories__/JsonTree.stories.tsx
index a33e1715bca..915b4109687 100644
--- a/packages/twenty-ui/src/json-visualizer/__stories__/JsonTree.stories.tsx
+++ b/packages/twenty-ui/src/json-visualizer/__stories__/JsonTree.stories.tsx
@@ -1,6 +1,7 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { JsonTree } from '@ui/json-visualizer/components/JsonTree';
import { isTwoFirstDepths } from '@ui/json-visualizer/utils/isTwoFirstDepths';
+import { A11Y_DEFER_COLOR_CONTRAST } from '@ui/testing';
import {
expect,
fn,
@@ -29,8 +30,7 @@ export default meta;
type Story = StoryObj<typeof JsonTree>;
export const String: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: 'Hello',
},
@@ -44,8 +44,7 @@ export const String: Story = {
};
export const StringWithSpecialCharacters: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: 'Merry \n Christmas \t 🎄',
onNodeValueClick: fn(),
@@ -66,8 +65,7 @@ export const StringWithSpecialCharacters: Story = {
};
export const Number: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: 42,
},
@@ -81,8 +79,7 @@ export const Number: Story = {
};
export const Boolean: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: true,
},
@@ -96,8 +93,7 @@ export const Boolean: Story = {
};
export const Null: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: null,
},
@@ -124,8 +120,7 @@ export const ArraySimple: Story = {
};
export const ArrayEmpty: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: [],
},
@@ -139,8 +134,7 @@ export const ArrayEmpty: Story = {
};
export const ArrayNested: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: [1, 2, ['a', 'b', 'c'], 3],
},
@@ -154,8 +148,7 @@ export const ArrayNested: Story = {
};
export const ArrayNestedEmpty: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: [1, 2, [], 3],
},
@@ -173,8 +166,7 @@ export const ArrayNestedEmpty: Story = {
};
export const ArrayWithObjects: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: [
{
@@ -197,8 +189,7 @@ export const ArrayWithObjects: Story = {
};
export const ObjectSimple: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
name: 'John Doe',
@@ -217,8 +208,7 @@ export const ObjectSimple: Story = {
};
export const ObjectEmpty: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {},
},
@@ -232,8 +222,7 @@ export const ObjectEmpty: Story = {
};
export const ObjectNested: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
person: {
@@ -256,8 +245,7 @@ export const ObjectNested: Story = {
};
export const ObjectNestedEmpty: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
person: {},
@@ -277,8 +265,7 @@ export const ObjectNestedEmpty: Story = {
};
export const ObjectWithArray: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
users: [
@@ -303,8 +290,7 @@ export const ObjectWithArray: Story = {
};
export const NestedElementCanBeCollapsed: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
person: {
@@ -334,8 +320,7 @@ export const NestedElementCanBeCollapsed: Story = {
};
export const ExpandingElementExpandsAllItsDescendants: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
person: {
@@ -384,8 +369,7 @@ export const ExpandingElementExpandsAllItsDescendants: Story = {
};
export const ExpandTwoFirstDepths: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
person: {
@@ -421,8 +405,7 @@ export const ExpandTwoFirstDepths: Story = {
};
export const ReallyDeepNestedObject: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
a: {
@@ -543,8 +526,7 @@ export const ReallyDeepNestedObject: Story = {
};
export const LongText: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vestibulum iaculis est tincidunt, sagittis neque vitae, sodales purus.':
@@ -569,8 +551,7 @@ export const LongText: Story = {
};
export const BlueHighlighting: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
name: 'John Doe',
@@ -587,8 +568,7 @@ export const BlueHighlighting: Story = {
};
export const PartialBlueHighlighting: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
name: 'John Doe',
@@ -609,8 +589,7 @@ export const PartialBlueHighlighting: Story = {
};
export const RedHighlighting: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
name: 'John Doe',
@@ -630,8 +609,7 @@ export const RedHighlighting: Story = {
};
export const CopyJsonNodeValue: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
value: {
name: 'John Doe',
diff --git a/packages/twenty-ui/src/json-visualizer/components/JsonNestedNode.tsx b/packages/twenty-ui/src/json-visualizer/components/JsonNestedNode.tsx
index 31f17c71027..a948f203906 100644
--- a/packages/twenty-ui/src/json-visualizer/components/JsonNestedNode.tsx
+++ b/packages/twenty-ui/src/json-visualizer/components/JsonNestedNode.tsx
@@ -8,8 +8,8 @@ import { type JsonValue } from 'type-fest';
import { type IconComponent } from '@ui/icon';
import { JsonArrow } from '@ui/json-visualizer/components/internal/JsonArrow';
import { JsonNodeLabel } from '@ui/json-visualizer/components/internal/JsonNodeLabel';
-import { JsonNodeValue } from '@ui/json-visualizer/components/internal/JsonNodeValue';
import { JsonNode } from '@ui/json-visualizer/components/JsonNode';
+import { JsonValueNode } from '@ui/json-visualizer/components/JsonValueNode';
import { useJsonTreeContextOrThrow } from '@ui/json-visualizer/hooks/useJsonTreeContextOrThrow';
import { type JsonNodeHighlighting } from '@ui/json-visualizer/types/JsonNodeHighlighting';
@@ -45,7 +45,10 @@ export const JsonNestedNode = ({
const renderedChildren = (
<ul className={clsx(styles.list, depth > 0 && styles.nested)}>
{elements.length === 0 ? (
- <JsonNodeValue valueAsString={emptyElementsText} />
+ <JsonValueNode
+ valueAsString={emptyElementsText}
+ highlighting={undefined}
+ />
) : (
elements.map(({ id, label, value }) => {
const nextKeyPath = isNonEmptyString(keyPath)
diff --git a/packages/twenty-ui/src/layout/AnimatedExpandableContainer/__stories__/AnimatedExpandableContainer.stories.tsx b/packages/twenty-ui/src/layout/AnimatedExpandableContainer/__stories__/AnimatedExpandableContainer.stories.tsx
index b954217e248..7337800cfd4 100644
--- a/packages/twenty-ui/src/layout/AnimatedExpandableContainer/__stories__/AnimatedExpandableContainer.stories.tsx
+++ b/packages/twenty-ui/src/layout/AnimatedExpandableContainer/__stories__/AnimatedExpandableContainer.stories.tsx
@@ -1,5 +1,5 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
-import { ComponentDecorator } from '@ui/testing';
+import { A11Y_DEFER_COLOR_CONTRAST, ComponentDecorator } from '@ui/testing';
import { clsx } from 'clsx';
import { useState } from 'react';
import { AnimatedExpandableContainer } from '@ui/layout/AnimatedExpandableContainer/AnimatedExpandableContainer';
@@ -113,8 +113,7 @@ export default meta;
type Story = StoryObj<typeof AnimatedExpandableContainerWithButton>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
isExpanded: false,
dimension: 'height',
@@ -124,8 +123,7 @@ export const Default: Story = {
};
export const FitContent: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
...Default.args,
mode: 'fit-content',
@@ -133,8 +131,7 @@ export const FitContent: Story = {
};
export const CustomDurations: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
...Default.args,
animationDurations: { opacity: 0.8, size: 1.2 },
@@ -142,8 +139,7 @@ export const CustomDurations: Story = {
};
export const WidthAnimation: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
...Default.args,
dimension: 'width',
diff --git a/packages/twenty-ui/src/navigation/ClickToActionLink/__stories__/ClickToActionLink.stories.tsx b/packages/twenty-ui/src/navigation/ClickToActionLink/__stories__/ClickToActionLink.stories.tsx
index 222c5612d61..2ad476dabf2 100644
--- a/packages/twenty-ui/src/navigation/ClickToActionLink/__stories__/ClickToActionLink.stories.tsx
+++ b/packages/twenty-ui/src/navigation/ClickToActionLink/__stories__/ClickToActionLink.stories.tsx
@@ -1,6 +1,6 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import { ClickToActionLink } from '@ui/navigation/ClickToActionLink/ClickToActionLink';
-import { ComponentDecorator } from '@ui/testing';
+import { A11Y_DEFER_COLOR_CONTRAST, ComponentDecorator } from '@ui/testing';
const meta: Meta<typeof ClickToActionLink> = {
title: 'UI/Navigation/ClickToActionLink',
@@ -11,8 +11,7 @@ export default meta;
type Story = StoryObj<typeof ClickToActionLink>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
children: 'Need to reset your password?',
onClick: () => alert('Action link clicked'),
diff --git a/packages/twenty-ui/src/navigation/GithubVersionLink/__stories__/GithubVersionLink.stories.tsx b/packages/twenty-ui/src/navigation/GithubVersionLink/__stories__/GithubVersionLink.stories.tsx
index 9e4d34ef157..d894f806a04 100644
--- a/packages/twenty-ui/src/navigation/GithubVersionLink/__stories__/GithubVersionLink.stories.tsx
+++ b/packages/twenty-ui/src/navigation/GithubVersionLink/__stories__/GithubVersionLink.stories.tsx
@@ -1,6 +1,9 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
-import { ComponentWithRouterDecorator } from '@ui/testing';
+import {
+ A11Y_DEFER_COLOR_CONTRAST,
+ ComponentWithRouterDecorator,
+} from '@ui/testing';
import { GithubVersionLink } from '@ui/navigation/GithubVersionLink/GithubVersionLink';
const meta: Meta<typeof GithubVersionLink> = {
@@ -13,6 +16,6 @@ export default meta;
type Story = StoryObj<typeof GithubVersionLink>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
+ args: { version: '0.1.0' },
};
diff --git a/packages/twenty-ui/src/navigation/MenuItem/__stories__/MenuItem.stories.tsx b/packages/twenty-ui/src/navigation/MenuItem/__stories__/MenuItem.stories.tsx
index 1a6752864dd..79db82a03e4 100644
--- a/packages/twenty-ui/src/navigation/MenuItem/__stories__/MenuItem.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItem/__stories__/MenuItem.stories.tsx
@@ -3,6 +3,7 @@ import { action } from 'storybook/actions';
import { IconBell } from '@ui/icon';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogStory,
ComponentDecorator,
@@ -20,15 +21,14 @@ export default meta;
type Story = StoryObj<typeof MenuItem>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
text: 'Menu item text',
LeftIcon: IconBell,
accent: 'default',
iconButtons: [
- { Icon: IconBell, onClick: action('Clicked') },
- { Icon: IconBell, onClick: action('Clicked') },
+ { Icon: IconBell, onClick: action('Clicked'), ariaLabel: 'Notify' },
+ { Icon: IconBell, onClick: action('Clicked'), ariaLabel: 'Notify' },
],
},
decorators: [ComponentDecorator],
@@ -42,8 +42,7 @@ export const Catalog: CatalogStory<Story, typeof MenuItem> = {
iconButtons: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
@@ -100,10 +99,12 @@ export const Catalog: CatalogStory<Story, typeof MenuItem> = {
{
Icon: IconBell,
onClick: action('Clicked on first icon button'),
+ ariaLabel: 'Notify',
},
{
Icon: IconBell,
onClick: action('Clicked on second icon button'),
+ ariaLabel: 'Notify',
},
],
};
@@ -140,8 +141,7 @@ export const HotKeysCatalog: CatalogStory<Story, typeof MenuItem> = {
iconButtons: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
@@ -204,8 +204,7 @@ export const ContextualTextCatalog: CatalogStory<Story, typeof MenuItem> = {
},
decorators: [CatalogDecorator],
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
@@ -252,6 +251,7 @@ export const ContextualTextCatalog: CatalogStory<Story, typeof MenuItem> = {
{
Icon: IconBell,
onClick: action('Clicked on icon button'),
+ ariaLabel: 'Notify',
},
],
};
@@ -302,8 +302,7 @@ export const SubMenuCatalog: CatalogStory<Story, typeof MenuItem> = {
hasSubMenu: true,
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/navigation/MenuItemDraggable/__stories__/MenuItemDraggable.stories.tsx b/packages/twenty-ui/src/navigation/MenuItemDraggable/__stories__/MenuItemDraggable.stories.tsx
index a4d796b0bc0..14fbd80234f 100644
--- a/packages/twenty-ui/src/navigation/MenuItemDraggable/__stories__/MenuItemDraggable.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemDraggable/__stories__/MenuItemDraggable.stories.tsx
@@ -3,6 +3,7 @@ import { action } from 'storybook/actions';
import { IconBell, IconMinus } from '@ui/icon';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogDimension,
type CatalogOptions,
@@ -21,12 +22,13 @@ export default meta;
type Story = StoryObj<typeof MenuItemDraggable>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
LeftIcon: IconBell,
accent: 'default',
- iconButtons: [{ Icon: IconMinus, onClick: action('Clicked') }],
+ iconButtons: [
+ { Icon: IconMinus, onClick: action('Clicked'), ariaLabel: 'Remove' },
+ ],
onClick: action('Clicked'),
text: 'Menu item draggable',
isDragDisabled: false,
@@ -41,8 +43,7 @@ export const Catalog: Story = {
iconButtons: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'] },
catalog: {
dimensions: [
@@ -99,6 +100,7 @@ export const Catalog: Story = {
{
Icon: IconMinus,
onClick: action('Clicked on minus icon button'),
+ ariaLabel: 'Remove',
},
],
};
@@ -118,20 +120,17 @@ export const Catalog: Story = {
};
export const Grip: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: { ...Default.args, gripMode: 'always', isDragDisabled: false },
};
export const GripOnHover: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: { ...Default.args, gripMode: 'onHover', isDragDisabled: false },
};
export const GripOnHoverWithIconContainer: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
...Default.args,
gripMode: 'onHover',
@@ -141,7 +140,6 @@ export const GripOnHoverWithIconContainer: Story = {
};
export const HoverDisabled: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: { ...Default.args, isHoverDisabled: true },
};
diff --git a/packages/twenty-ui/src/navigation/MenuItemMultiSelect/MenuItemMultiSelect.tsx b/packages/twenty-ui/src/navigation/MenuItemMultiSelect/MenuItemMultiSelect.tsx
index f0dc5360d90..20e3a896ee3 100644
--- a/packages/twenty-ui/src/navigation/MenuItemMultiSelect/MenuItemMultiSelect.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemMultiSelect/MenuItemMultiSelect.tsx
@@ -41,7 +41,7 @@ export const MenuItemMultiSelect = ({
onClick={handleOnClick}
>
<div className={styles.leftContentWithCheckboxContainer}>
- <Checkbox checked={selected} />
+ <Checkbox checked={selected} aria-label={text} />
{color ? (
<Tag color={color} text={text} Icon={LeftIcon} />
) : (
diff --git a/packages/twenty-ui/src/navigation/MenuItemMultiSelect/__stories__/MenuItemMultiSelect.stories.tsx b/packages/twenty-ui/src/navigation/MenuItemMultiSelect/__stories__/MenuItemMultiSelect.stories.tsx
index f1e3a60c063..68077d8e2e3 100644
--- a/packages/twenty-ui/src/navigation/MenuItemMultiSelect/__stories__/MenuItemMultiSelect.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemMultiSelect/__stories__/MenuItemMultiSelect.stories.tsx
@@ -2,6 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { IconBell } from '@ui/icon';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogDimension,
type CatalogOptions,
@@ -20,8 +21,7 @@ export default meta;
type Story = StoryObj<typeof MenuItemMultiSelect>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
text: 'First option',
},
@@ -34,8 +34,7 @@ export const Catalog: CatalogStory<Story, typeof MenuItemMultiSelect> = {
className: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
diff --git a/packages/twenty-ui/src/navigation/MenuItemMultiSelectAvatar/MenuItemMultiSelectAvatar.tsx b/packages/twenty-ui/src/navigation/MenuItemMultiSelectAvatar/MenuItemMultiSelectAvatar.tsx
index e348541e113..f18396268ea 100644
--- a/packages/twenty-ui/src/navigation/MenuItemMultiSelectAvatar/MenuItemMultiSelectAvatar.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemMultiSelectAvatar/MenuItemMultiSelectAvatar.tsx
@@ -41,7 +41,10 @@ export const MenuItemMultiSelectAvatar = ({
isKeySelected={isKeySelected}
>
<div className={styles.leftContentWithCheckboxContainer}>
- <Checkbox checked={selected} />
+ <Checkbox
+ checked={selected}
+ aria-label={text ?? contextualText ?? 'Select item'}
+ />
<StyledMenuItemLeftContent>
{avatar}
<div className={styles.textContainer}>
diff --git a/packages/twenty-ui/src/navigation/MenuItemMultiSelectAvatar/__stories__/MenuItemMultiSelectAvatar.stories.tsx b/packages/twenty-ui/src/navigation/MenuItemMultiSelectAvatar/__stories__/MenuItemMultiSelectAvatar.stories.tsx
index c0fa0c5d7cf..03493e574fa 100644
--- a/packages/twenty-ui/src/navigation/MenuItemMultiSelectAvatar/__stories__/MenuItemMultiSelectAvatar.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemMultiSelectAvatar/__stories__/MenuItemMultiSelectAvatar.stories.tsx
@@ -2,6 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { Avatar } from '@ui/data-display';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
AVATAR_URL_MOCK,
CatalogDecorator,
type CatalogDimension,
@@ -22,8 +23,7 @@ export default meta;
type Story = StoryObj<typeof MenuItemMultiSelectAvatar>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
text: 'First option',
contextualText: 'Contextual text',
@@ -38,8 +38,7 @@ export const Catalog: CatalogStory<Story, typeof MenuItemMultiSelectAvatar> = {
className: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
diff --git a/packages/twenty-ui/src/navigation/MenuItemNavigate/__stories__/MenuItemNavigate.stories.tsx b/packages/twenty-ui/src/navigation/MenuItemNavigate/__stories__/MenuItemNavigate.stories.tsx
index cd6831271fd..40abe1a481d 100644
--- a/packages/twenty-ui/src/navigation/MenuItemNavigate/__stories__/MenuItemNavigate.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemNavigate/__stories__/MenuItemNavigate.stories.tsx
@@ -4,6 +4,7 @@ import { IconBell } from '@ui/icon';
import { MenuItemNavigate } from '@ui/navigation/MenuItemNavigate/MenuItemNavigate';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogDimension,
type CatalogOptions,
@@ -33,8 +34,7 @@ export const Catalog: CatalogStory<Story, typeof MenuItemNavigate> = {
className: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
diff --git a/packages/twenty-ui/src/navigation/MenuItemSelect/__stories__/MenuItemSelect.stories.tsx b/packages/twenty-ui/src/navigation/MenuItemSelect/__stories__/MenuItemSelect.stories.tsx
index ad8a18ea3cd..456254bc362 100644
--- a/packages/twenty-ui/src/navigation/MenuItemSelect/__stories__/MenuItemSelect.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemSelect/__stories__/MenuItemSelect.stories.tsx
@@ -1,6 +1,7 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogDimension,
type CatalogOptions,
@@ -20,8 +21,7 @@ export default meta;
type Story = StoryObj<typeof MenuItemSelect>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
text: 'First option',
LeftIcon: IconBell,
@@ -29,7 +29,14 @@ export const Default: Story = {
argTypes: {
className: { control: false },
},
- decorators: [ComponentDecorator],
+ decorators: [
+ (Story) => (
+ <div role="listbox" aria-label="Options">
+ <Story />
+ </div>
+ ),
+ ComponentDecorator,
+ ],
};
export const Catalog: CatalogStory<Story, typeof MenuItemSelect> = {
@@ -38,8 +45,7 @@ export const Catalog: CatalogStory<Story, typeof MenuItemSelect> = {
className: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
@@ -87,5 +93,12 @@ export const Catalog: CatalogStory<Story, typeof MenuItemSelect> = {
} as CatalogOptions,
},
},
- decorators: [CatalogDecorator],
+ decorators: [
+ (Story) => (
+ <div role="listbox" aria-label="Options">
+ <Story />
+ </div>
+ ),
+ CatalogDecorator,
+ ],
};
diff --git a/packages/twenty-ui/src/navigation/MenuItemSelectAvatar/__stories__/MenuItemSelectAvatar.stories.tsx b/packages/twenty-ui/src/navigation/MenuItemSelectAvatar/__stories__/MenuItemSelectAvatar.stories.tsx
index d8730fbad6d..8b6d79e083d 100644
--- a/packages/twenty-ui/src/navigation/MenuItemSelectAvatar/__stories__/MenuItemSelectAvatar.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemSelectAvatar/__stories__/MenuItemSelectAvatar.stories.tsx
@@ -2,6 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { Avatar } from '@ui/data-display';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
AVATAR_URL_MOCK,
CatalogDecorator,
type CatalogDimension,
@@ -21,8 +22,7 @@ export default meta;
type Story = StoryObj<typeof MenuItemSelectAvatar>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
text: 'First option',
contextualText: 'Contextual text',
@@ -31,7 +31,15 @@ export const Default: Story = {
argTypes: {
className: { control: false },
},
- decorators: [ComponentDecorator, JotaiRootDecorator],
+ decorators: [
+ (Story) => (
+ <div role="listbox" aria-label="Options">
+ <Story />
+ </div>
+ ),
+ ComponentDecorator,
+ JotaiRootDecorator,
+ ],
};
export const Catalog: CatalogStory<Story, typeof MenuItemSelectAvatar> = {
@@ -40,8 +48,7 @@ export const Catalog: CatalogStory<Story, typeof MenuItemSelectAvatar> = {
className: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
@@ -93,5 +100,13 @@ export const Catalog: CatalogStory<Story, typeof MenuItemSelectAvatar> = {
} as CatalogOptions,
},
},
- decorators: [CatalogDecorator, JotaiRootDecorator],
+ decorators: [
+ (Story) => (
+ <div role="listbox" aria-label="Options">
+ <Story />
+ </div>
+ ),
+ CatalogDecorator,
+ JotaiRootDecorator,
+ ],
};
diff --git a/packages/twenty-ui/src/navigation/MenuItemSelectColor/__stories__/MenuItemSelectColor.stories.tsx b/packages/twenty-ui/src/navigation/MenuItemSelectColor/__stories__/MenuItemSelectColor.stories.tsx
index 552d6fa863e..c8c97ba24ed 100644
--- a/packages/twenty-ui/src/navigation/MenuItemSelectColor/__stories__/MenuItemSelectColor.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemSelectColor/__stories__/MenuItemSelectColor.stories.tsx
@@ -2,6 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { type ColorSampleVariant } from '@ui/data-display';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogDimension,
type CatalogOptions,
@@ -29,8 +30,7 @@ export const Default: Story = {
export const Catalog: CatalogStory<Story, typeof MenuItemSelectColor> = {
argTypes: { className: { control: false } },
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
diff --git a/packages/twenty-ui/src/navigation/MenuItemSelectTag/__stories__/MenuItemSelectTag.stories.tsx b/packages/twenty-ui/src/navigation/MenuItemSelectTag/__stories__/MenuItemSelectTag.stories.tsx
index 00f24c5f032..f5d334794a4 100644
--- a/packages/twenty-ui/src/navigation/MenuItemSelectTag/__stories__/MenuItemSelectTag.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemSelectTag/__stories__/MenuItemSelectTag.stories.tsx
@@ -1,6 +1,7 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogDimension,
type CatalogOptions,
@@ -42,8 +43,7 @@ export const Catalog: CatalogStory<Story, typeof MenuItemSelectTag> = {
text: 'Item A',
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: {
hover: ['.hover'],
active: ['.pressed'],
diff --git a/packages/twenty-ui/src/navigation/MenuItemToggle/MenuItemToggle.tsx b/packages/twenty-ui/src/navigation/MenuItemToggle/MenuItemToggle.tsx
index ee6cf061f8d..b505f1d74ea 100644
--- a/packages/twenty-ui/src/navigation/MenuItemToggle/MenuItemToggle.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemToggle/MenuItemToggle.tsx
@@ -57,6 +57,7 @@ export const MenuItemToggle = ({
onChange={disabled ? undefined : onToggleChange}
toggleSize={toggleSize}
disabled={disabled}
+ aria-label={text}
/>
</StyledMenuItemRightContent>
</div>
diff --git a/packages/twenty-ui/src/navigation/MenuItemToggle/__stories__/MenuItemToggle.stories.tsx b/packages/twenty-ui/src/navigation/MenuItemToggle/__stories__/MenuItemToggle.stories.tsx
index f3d8e352b61..81820c8689e 100644
--- a/packages/twenty-ui/src/navigation/MenuItemToggle/__stories__/MenuItemToggle.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuItemToggle/__stories__/MenuItemToggle.stories.tsx
@@ -2,6 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { IconBell } from '@ui/icon';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogDimension,
type CatalogOptions,
@@ -20,8 +21,7 @@ export default meta;
type Story = StoryObj<typeof MenuItemToggle>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
text: 'First option',
},
@@ -34,8 +34,7 @@ export const Catalog: CatalogStory<Story, typeof MenuItemToggle> = {
className: { control: false },
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
pseudo: { hover: ['.hover'], active: ['.pressed'], focus: ['.focus'] },
catalog: {
dimensions: [
diff --git a/packages/twenty-ui/src/navigation/MenuPicker/__stories__/MenuPicker.stories.tsx b/packages/twenty-ui/src/navigation/MenuPicker/__stories__/MenuPicker.stories.tsx
index 2039e59876a..08c0010e393 100644
--- a/packages/twenty-ui/src/navigation/MenuPicker/__stories__/MenuPicker.stories.tsx
+++ b/packages/twenty-ui/src/navigation/MenuPicker/__stories__/MenuPicker.stories.tsx
@@ -2,7 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { IconChartPie } from '@ui/icon';
import { TooltipDelay } from '@ui/surfaces';
import { MenuPicker } from '@ui/navigation/MenuPicker/MenuPicker';
-import { ComponentDecorator } from '@ui/testing';
+import { A11Y_DEFER_COLOR_CONTRAST, ComponentDecorator } from '@ui/testing';
import { type ReactNode } from 'react';
import styles from './MenuPicker.stories.module.scss';
@@ -32,8 +32,7 @@ export default meta;
type Story = StoryObj<typeof MenuPicker>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
};
export const Selected: Story = {
@@ -59,8 +58,7 @@ const SectionTitle = ({ children }: { children?: ReactNode }) => {
};
export const AllStates: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
render: () => (
<div
style={{
diff --git a/packages/twenty-ui/src/surfaces/AppTooltip/__stories__/Tooltip.stories.tsx b/packages/twenty-ui/src/surfaces/AppTooltip/__stories__/Tooltip.stories.tsx
index 10096a782a1..3d70cbe40ba 100644
--- a/packages/twenty-ui/src/surfaces/AppTooltip/__stories__/Tooltip.stories.tsx
+++ b/packages/twenty-ui/src/surfaces/AppTooltip/__stories__/Tooltip.stories.tsx
@@ -1,6 +1,7 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
import {
+ A11Y_DEFER_COLOR_CONTRAST,
CatalogDecorator,
type CatalogStory,
ComponentDecorator,
@@ -155,8 +156,7 @@ export const Catalog: CatalogStory<Story, typeof Tooltip> = {
});
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/surfaces/Modal/Modal.tsx b/packages/twenty-ui/src/surfaces/Modal/Modal.tsx
index b886bbd708a..351a86542f2 100644
--- a/packages/twenty-ui/src/surfaces/Modal/Modal.tsx
+++ b/packages/twenty-ui/src/surfaces/Modal/Modal.tsx
@@ -40,6 +40,7 @@ const OVERLAY_CLASS_NAMES: Record<ModalOverlay, string | undefined> = {
export const Modal = ({
isOpen,
+ ariaLabel,
children,
size = 'medium',
padding = 'medium',
@@ -92,6 +93,7 @@ export const Modal = ({
render={
<div
ref={resolvedRef}
+ aria-label={ariaLabel}
className={clsx(
styles.modal,
styles[size],
diff --git a/packages/twenty-ui/src/surfaces/Modal/__stories__/Modal.stories.tsx b/packages/twenty-ui/src/surfaces/Modal/__stories__/Modal.stories.tsx
index fd5da765750..662d7d95636 100644
--- a/packages/twenty-ui/src/surfaces/Modal/__stories__/Modal.stories.tsx
+++ b/packages/twenty-ui/src/surfaces/Modal/__stories__/Modal.stories.tsx
@@ -4,7 +4,7 @@ import { IconX } from '@ui/icon';
import { H1Title, H1TitleFontColor, H2Title } from '@ui/typography';
import { Button, IconButton } from '@ui/input';
import { Section, SectionAlignment, SectionFontColor } from '@ui/layout';
-import { ComponentDecorator } from '@ui/testing';
+import { A11Y_DEFER_COLOR_CONTRAST, ComponentDecorator } from '@ui/testing';
import { Modal } from '@ui/surfaces/Modal/Modal';
import { ModalContent } from '@ui/surfaces/ModalContent/ModalContent';
@@ -37,8 +37,7 @@ export default meta;
type Story = StoryObj<typeof Modal>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
isOpen: true,
size: 'medium',
@@ -46,7 +45,13 @@ export const Default: Story = {
overlay: 'dark',
},
render: ({ isOpen, size, padding, overlay }) => (
- <Modal isOpen={isOpen} size={size} padding={padding} overlay={overlay}>
+ <Modal
+ isOpen={isOpen}
+ size={size}
+ padding={padding}
+ overlay={overlay}
+ ariaLabel="Edit workspace"
+ >
<ModalHeader>
<H2Title
title="Edit workspace"
@@ -68,8 +73,6 @@ export const Default: Story = {
};
export const Confirmation: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
args: {
isOpen: true,
padding: 'large',
@@ -92,6 +95,7 @@ export const Confirmation: Story = {
isOpen={isOpen}
padding={padding}
overlay={overlay}
+ ariaLabel="Delete record?"
smallBorderRadius={smallBorderRadius}
narrowWidth={narrowWidth}
autoHeight={autoHeight}
@@ -122,8 +126,6 @@ export const Confirmation: Story = {
};
export const Small: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
args: {
isOpen: true,
size: 'small',
@@ -131,7 +133,13 @@ export const Small: Story = {
overlay: 'dark',
},
render: ({ isOpen, size, padding, overlay }) => (
- <Modal isOpen={isOpen} size={size} padding={padding} overlay={overlay}>
+ <Modal
+ isOpen={isOpen}
+ size={size}
+ padding={padding}
+ overlay={overlay}
+ ariaLabel="Archive item"
+ >
<ModalHeader>
<H2Title title="Archive item" />
</ModalHeader>
@@ -147,8 +155,7 @@ export const Small: Story = {
};
export const ExtraLarge: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args: {
isOpen: true,
size: 'extraLarge',
@@ -156,7 +163,13 @@ export const ExtraLarge: Story = {
overlay: 'dark',
},
render: ({ isOpen, size, padding, overlay }) => (
- <Modal isOpen={isOpen} size={size} padding={padding} overlay={overlay}>
+ <Modal
+ isOpen={isOpen}
+ size={size}
+ padding={padding}
+ overlay={overlay}
+ ariaLabel="Import contacts"
+ >
<ModalHeader>
<H2Title
title="Import contacts"
diff --git a/packages/twenty-ui/src/surfaces/Modal/types/ModalProps.ts b/packages/twenty-ui/src/surfaces/Modal/types/ModalProps.ts
index 099e26070ba..e128fda6bd0 100644
--- a/packages/twenty-ui/src/surfaces/Modal/types/ModalProps.ts
+++ b/packages/twenty-ui/src/surfaces/Modal/types/ModalProps.ts
@@ -6,6 +6,7 @@ import { type ModalSize } from '@ui/surfaces/Modal/types/ModalSize';
export type ModalProps = React.PropsWithChildren & {
isOpen: boolean;
+ ariaLabel?: string;
size?: ModalSize;
padding?: ModalPadding;
overlay?: ModalOverlay;
diff --git a/packages/twenty-ui/src/typography/H1Title/__stories__/H1Title.stories.tsx b/packages/twenty-ui/src/typography/H1Title/__stories__/H1Title.stories.tsx
index a52326533ae..11caeb36b4e 100644
--- a/packages/twenty-ui/src/typography/H1Title/__stories__/H1Title.stories.tsx
+++ b/packages/twenty-ui/src/typography/H1Title/__stories__/H1Title.stories.tsx
@@ -1,5 +1,6 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
+import { A11Y_DEFER_COLOR_CONTRAST } from '@ui/testing/a11yParameters';
import { CatalogDecorator } from '@ui/testing/decorators/CatalogDecorator';
import { ComponentDecorator } from '@ui/testing/decorators/ComponentDecorator';
import { type CatalogStory } from '@ui/testing/types/CatalogStory';
@@ -30,8 +31,7 @@ export const Catalog: CatalogStory<Story, typeof H1Title> = {
args,
decorators: [CatalogDecorator],
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/typography/H2Title/__stories__/H2Title.stories.tsx b/packages/twenty-ui/src/typography/H2Title/__stories__/H2Title.stories.tsx
index 0601a1f94d0..d3ac88614cf 100644
--- a/packages/twenty-ui/src/typography/H2Title/__stories__/H2Title.stories.tsx
+++ b/packages/twenty-ui/src/typography/H2Title/__stories__/H2Title.stories.tsx
@@ -1,5 +1,6 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
+import { A11Y_DEFER_COLOR_CONTRAST } from '@ui/testing/a11yParameters';
import { ComponentDecorator } from '@ui/testing/decorators/ComponentDecorator';
import { H2Title } from '@ui/typography/H2Title/H2Title';
@@ -27,8 +28,7 @@ export const Default: Story = {
};
export const WithDescription: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
args,
decorators: [ComponentDecorator],
};
diff --git a/packages/twenty-ui/src/typography/Label/__stories__/Label.stories.tsx b/packages/twenty-ui/src/typography/Label/__stories__/Label.stories.tsx
index 49f77265362..fdeb607afbc 100644
--- a/packages/twenty-ui/src/typography/Label/__stories__/Label.stories.tsx
+++ b/packages/twenty-ui/src/typography/Label/__stories__/Label.stories.tsx
@@ -2,6 +2,7 @@ import { type Meta, type StoryObj } from '@storybook/react-vite';
import { CatalogDecorator } from '@ui/testing/decorators/CatalogDecorator';
import { ComponentDecorator } from '@ui/testing/decorators/ComponentDecorator';
+import { A11Y_DEFER_COLOR_CONTRAST } from '@ui/testing/a11yParameters';
import { type CatalogStory } from '@ui/testing/types/CatalogStory';
import { Label, type LabelVariant } from '@ui/typography/Label/Label';
@@ -17,8 +18,7 @@ export default meta;
type Story = StoryObj<typeof Label>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
decorators: [ComponentDecorator],
args: {
children: 'Label',
@@ -31,8 +31,7 @@ export const Catalog: CatalogStory<Story, typeof Label> = {
children: 'Label',
},
parameters: {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- a11y: { test: 'todo' },
+ a11y: A11Y_DEFER_COLOR_CONTRAST,
catalog: {
dimensions: [
{
diff --git a/packages/twenty-ui/src/typography/SeparatorLineText/__stories__/SeparatorLineText.stories.tsx b/packages/twenty-ui/src/typography/SeparatorLineText/__stories__/SeparatorLineText.stories.tsx
index 63fd095b180..b2e89cb5b11 100644
--- a/packages/twenty-ui/src/typography/SeparatorLineText/__stories__/SeparatorLineText.stories.tsx
+++ b/packages/twenty-ui/src/typography/SeparatorLineText/__stories__/SeparatorLineText.stories.tsx
@@ -1,5 +1,5 @@
import { type Meta, type StoryObj } from '@storybook/react-vite';
-import { ComponentDecorator } from '@ui/testing';
+import { A11Y_DEFER_COLOR_CONTRAST, ComponentDecorator } from '@ui/testing';
import { SeparatorLineText } from '@ui/typography/SeparatorLineText/SeparatorLineText';
@@ -14,6 +14,5 @@ export default meta;
type Story = StoryObj<typeof SeparatorLineText>;
export const Default: Story = {
- // TODO(a11y): violations inherited from deprecated story; fix during a11y pass
- parameters: { a11y: { test: 'todo' } },
+ parameters: { a11y: A11Y_DEFER_COLOR_CONTRAST },
};