The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix(twenty-front): stop unbounded default-view creation on record-index load (#21592)
Félix Malfait87c878b10167
diff --git a/packages/twenty-front/src/modules/views/hooks/useCreateDefaultViewForObject.ts b/packages/twenty-front/src/modules/views/hooks/useCreateDefaultViewForObject.tsindex e37cea48358..ab44b5d700c 100644--- a/packages/twenty-front/src/modules/views/hooks/useCreateDefaultViewForObject.ts+++ b/packages/twenty-front/src/modules/views/hooks/useCreateDefaultViewForObject.ts@@ -2,6 +2,8 @@ import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/Enricheimport { isHiddenSystemField } from '@/object-metadata/utils/isHiddenSystemField';import { usePerformViewAPIPersist } from '@/views/hooks/internal/usePerformViewAPIPersist';import { usePerformViewFieldAPIPersist } from '@/views/hooks/internal/usePerformViewFieldAPIPersist';+import { viewsSelector } from '@/views/states/selectors/viewsSelector';+import { useStore } from 'jotai';import { useCallback } from 'react';import { v4 } from 'uuid';import { ViewType } from '~/generated-metadata/graphql';@@ -15,9 +17,18 @@ const pendingViewCreations = new Set<string>();export const useCreateDefaultViewForObject = () => {const { performViewAPICreate } = usePerformViewAPIPersist();const { performViewFieldAPICreate } = usePerformViewFieldAPIPersist();+ const store = useStore();const createDefaultViewForObject = useCallback(async (objectMetadataItem: EnrichedObjectMetadataItem) => {+ const objectAlreadyHasView = store+ .get(viewsSelector.atom)+ .some((view) => view.objectMetadataId === objectMetadataItem.id);++ if (objectAlreadyHasView) {+ return;+ }+if (pendingViewCreations.has(objectMetadataItem.id)) {return;}@@ -77,7 +88,7 @@ export const useCreateDefaultViewForObject = () => {pendingViewCreations.delete(objectMetadataItem.id);}},- [performViewAPICreate, performViewFieldAPICreate],+ [performViewAPICreate, performViewFieldAPICreate, store],);return {