The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Add Security settings for embedded website media access (#29218)
Raphaël Bosi887478f79c2e
diff --git a/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityIframeMediaPermissionForm.tsx b/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityIframeMediaPermissionForm.tsxnew file mode 100644index 00000000000..4bb48b0f17e--- /dev/null+++ b/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityIframeMediaPermissionForm.tsx@@ -0,0 +1,138 @@+import { useState } from 'react';+import { styled } from '@linaria/react';+import { useLingui } from '@lingui/react/macro';+import { isNonEmptyString } from '@sniptt/guards';+import { type IframeMediaPermission } from 'twenty-shared/types';+import { isDefined, normalizeIframeOrigin } from 'twenty-shared/utils';+import { IconPlus } from 'twenty-ui/icon';+import { Button, Switch } from 'twenty-ui/primitives/input';+import { Text } from 'twenty-ui/primitives/typography';+import { themeCssVariables } from 'twenty-ui/theme';++import { useSettingsSecurityIframeMediaPermissionsOrThrow } from '@/settings/security/contexts/SettingsSecurityIframeMediaPermissionsContext';+import { SettingsTextInput } from '@/ui/input/components/SettingsTextInput';++type SettingsSecurityIframeMediaPermissionFormProps = {+ disabled: boolean;+ permissions: IframeMediaPermission[];+};++const StyledForm = styled.div`+ display: flex;+ flex-direction: column;+ gap: ${themeCssVariables.spacing[3]};+`;++const StyledControls = styled.div`+ align-items: center;+ display: flex;+ flex-wrap: wrap;+ gap: ${themeCssVariables.spacing[4]};+`;++const StyledLabel = styled.label`+ align-items: center;+ display: flex;+ gap: ${themeCssVariables.spacing[2]};+`;++export const SettingsSecurityIframeMediaPermissionForm = ({+ disabled,+ permissions,+}: SettingsSecurityIframeMediaPermissionFormProps) => {+ const { t } = useLingui();+ const { savePermission } = useSettingsSecurityIframeMediaPermissionsOrThrow();+ const [originInput, setOriginInput] = useState('');+ const [isMicrophoneAllowed, setIsMicrophoneAllowed] = useState(false);+ const [isCameraAllowed, setIsCameraAllowed] = useState(false);+ const [error, setError] = useState<string>();+ const hasSelectedCapability = isMicrophoneAllowed || isCameraAllowed;++ const handleAddOrigin = async () => {+ if (disabled || !hasSelectedCapability) {+ return;+ }++ const origin = normalizeIframeOrigin(originInput.trim(), {+ isHttpsOnly: true,+ });++ if (!isDefined(origin)) {+ setError(+ t`Enter an HTTPS origin without a path or wildcard, such as https://workspace.aircall.io.`,+ );+ return;+ }++ if (permissions.some((permission) => permission.origin === origin)) {+ setError(+ t`This origin is already configured. Use its switches to change access.`,+ );+ return;+ }++ if (+ await savePermission({+ origin,+ microphone: isMicrophoneAllowed,+ camera: isCameraAllowed,+ })+ ) {+ setOriginInput('');+ setIsMicrophoneAllowed(false);+ setIsCameraAllowed(false);+ setError(undefined);+ }+ };++ return (+ <StyledForm role="group" aria-label={t`Add embedded website`}>+ <SettingsTextInput+ instanceId="iframe-media-permission-origin"+ label={t`Website origin`}+ placeholder="https://workspace.aircall.io"+ value={originInput}+ disabled={disabled}+ onChange={(value) => {+ setOriginInput(value);+ setError(undefined);+ }}+ onInputEnter={() => void handleAddOrigin()}+ error={error}+ />+ <StyledControls>+ <StyledLabel>+ <Switch+ checked={isMicrophoneAllowed}+ disabled={disabled}+ size="sm"+ onCheckedChange={setIsMicrophoneAllowed}+ />+ <Text render={<span />}>{t`Microphone`}</Text>+ </StyledLabel>+ <StyledLabel>+ <Switch+ checked={isCameraAllowed}+ disabled={disabled}+ size="sm"+ onCheckedChange={setIsCameraAllowed}+ />+ <Text render={<span />}>{t`Camera`}</Text>+ </StyledLabel>+ <Button+ variant="outline"+ size="sm"+ disabled={+ disabled ||+ !isNonEmptyString(originInput.trim()) ||+ !hasSelectedCapability+ }+ startIcon={<IconPlus size={16} />}+ onClick={() => void handleAddOrigin()}+ >+ {t`Add website`}+ </Button>+ </StyledControls>+ </StyledForm>+ );+};diff --git a/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityIframeMediaPermissionRow.tsx b/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityIframeMediaPermissionRow.tsxnew file mode 100644index 00000000000..36588aabc68--- /dev/null+++ b/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityIframeMediaPermissionRow.tsx@@ -0,0 +1,84 @@+import { styled } from '@linaria/react';+import { useLingui } from '@lingui/react/macro';+import { type IframeMediaPermission } from 'twenty-shared/types';+import { IconTrash } from 'twenty-ui/icon';+import { Button, Switch } from 'twenty-ui/primitives/input';+import { Text } from 'twenty-ui/primitives/typography';+import { themeCssVariables } from 'twenty-ui/theme';++import { useSettingsSecurityIframeMediaPermissionsOrThrow } from '@/settings/security/contexts/SettingsSecurityIframeMediaPermissionsContext';++type SettingsSecurityIframeMediaPermissionRowProps = {+ permission: IframeMediaPermission;+ disabled: boolean;+};++const StyledRow = styled.div`+ display: flex;+ flex-direction: column;+ gap: ${themeCssVariables.spacing[2]};+`;++const StyledControls = styled.div`+ align-items: center;+ display: flex;+ flex-wrap: wrap;+ gap: ${themeCssVariables.spacing[4]};+`;++const StyledLabel = styled.label`+ align-items: center;+ display: flex;+ gap: ${themeCssVariables.spacing[2]};+`;++export const SettingsSecurityIframeMediaPermissionRow = ({+ permission,+ disabled,+}: SettingsSecurityIframeMediaPermissionRowProps) => {+ const { t } = useLingui();+ const { savePermission } = useSettingsSecurityIframeMediaPermissionsOrThrow();+ const { origin, microphone, camera } = permission;++ return (+ <StyledRow role="group" aria-label={origin}>+ <Text>{origin}</Text>+ <StyledControls>+ <StyledLabel>+ <Switch+ checked={microphone}+ disabled={disabled || (microphone && !camera)}+ size="sm"+ onCheckedChange={(checked) =>+ void savePermission({ origin, microphone: checked, camera })+ }+ />+ <Text render={<span />}>{t`Microphone`}</Text>+ </StyledLabel>+ <StyledLabel>+ <Switch+ checked={camera}+ disabled={disabled || (camera && !microphone)}+ size="sm"+ onCheckedChange={(checked) =>+ void savePermission({ origin, microphone, camera: checked })+ }+ />+ <Text render={<span />}>{t`Camera`}</Text>+ </StyledLabel>+ <Button+ aria-label={t`Remove media access for ${origin}`}+ disabled={disabled}+ size="sm"+ variant="outline"+ startIcon={<IconTrash size={16} />}+ onClick={() =>+ void savePermission({ origin, microphone: false, camera: false })+ }+ >+ {t`Remove`}+ </Button>+ </StyledControls>+ </StyledRow>+ );+};diff --git a/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityIframeMediaPermissions.tsx b/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityIframeMediaPermissions.tsxnew file mode 100644index 00000000000..43bc7bdd702--- /dev/null+++ b/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityIframeMediaPermissions.tsx@@ -0,0 +1,106 @@+import { useState } from 'react';+import { useMutation } from '@apollo/client/react';+import { styled } from '@linaria/react';+import { useLingui } from '@lingui/react/macro';+import { type IframeMediaPermission } from 'twenty-shared/types';+import { isDefined } from 'twenty-shared/utils';+import { useToast } from 'twenty-ui/components/feedback';+import { Section } from 'twenty-ui/components/layout';+import { Button } from 'twenty-ui/primitives/input';+import { Text } from 'twenty-ui/primitives/typography';+import { themeCssVariables } from 'twenty-ui/theme';++import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';+import { getToastOptionsFromError } from '@/error-handler/utils/getToastOptionsFromError';+import { SettingsSecurityIframeMediaPermissionForm } from '@/settings/security/components/SettingsSecurityIframeMediaPermissionForm';+import { SettingsSecurityIframeMediaPermissionRow } from '@/settings/security/components/SettingsSecurityIframeMediaPermissionRow';+import { SettingsSecurityIframeMediaPermissionsProvider } from '@/settings/security/contexts/SettingsSecurityIframeMediaPermissionsContext';+import { useAtomState } from '@/ui/utilities/state/jotai/hooks/useAtomState';+import { UpdateWorkspaceIframeMediaPermissionsDocument } from '~/generated-metadata/graphql';++const StyledContent = styled.div`+ display: flex;+ flex-direction: column;+ gap: ${themeCssVariables.spacing[4]};+`;++export const SettingsSecurityIframeMediaPermissions = () => {+ const { t } = useLingui();+ const { enqueueToast } = useToast();+ const [hasSavedChanges, setHasSavedChanges] = useState(false);+ const [currentWorkspace, setCurrentWorkspace] = useAtomState(+ currentWorkspaceState,+ );+ const [updatePermissions, { loading: isSaving }] = useMutation(+ UpdateWorkspaceIframeMediaPermissionsDocument,+ );+ const permissions = currentWorkspace?.iframeMediaPermissions ?? [];++ const savePermission = async (permission: IframeMediaPermission) => {+ if (isSaving) {+ return false;+ }++ try {+ const { data } = await updatePermissions({+ variables: { input: permission },+ });++ if (!isDefined(data?.updateWorkspaceIframeMediaPermissions)) {+ return false;+ }++ const { iframeMediaPermissions } =+ data.updateWorkspaceIframeMediaPermissions;++ setCurrentWorkspace((previousWorkspace) =>+ isDefined(previousWorkspace)+ ? { ...previousWorkspace, iframeMediaPermissions }+ : previousWorkspace,+ );+ setHasSavedChanges(true);+ return true;+ } catch (error) {+ enqueueToast(getToastOptionsFromError({ error }));+ return false;+ }+ };++ return (+ <Section.Root>+ <Section.Header+ title={t`Embedded website media access`}+ description={t`Choose which websites embedded in iframe widgets can request microphone or camera access. Members still need to enable access and approve the browser permission.`}+ />+ <StyledContent>+ <SettingsSecurityIframeMediaPermissionsProvider+ value={{ savePermission }}+ >+ {permissions.map((permission) => (+ <SettingsSecurityIframeMediaPermissionRow+ key={permission.origin}+ permission={permission}+ disabled={isSaving}+ />+ ))}+ <SettingsSecurityIframeMediaPermissionForm+ disabled={isSaving}+ permissions={permissions}+ />+ </SettingsSecurityIframeMediaPermissionsProvider>+ {hasSavedChanges && (+ <>+ <Text role="status">{t`Changes saved. Reload open Twenty tabs to apply the updated permissions. Reloading ends active calls and recordings.`}</Text>+ <Button+ variant="outline"+ size="sm"+ onClick={() => window.location.reload()}+ >+ {t`Reload page`}+ </Button>+ </>+ )}+ </StyledContent>+ </Section.Root>+ );+};diff --git a/packages/twenty-front/src/modules/settings/security/components/SettingsSecuritySettings.tsx b/packages/twenty-front/src/modules/settings/security/components/SettingsSecuritySettings.tsxindex d1928acc48f..5b196170df3 100644--- a/packages/twenty-front/src/modules/settings/security/components/SettingsSecuritySettings.tsx+++ b/packages/twenty-front/src/modules/settings/security/components/SettingsSecuritySettings.tsx@@ -11,6 +11,7 @@ import { useSettingsAllRoles } from '@/settings/roles/hooks/useSettingsAllRoles'import { SettingsSecurityAuthBypassOptionsList } from '@/settings/security/components/SettingsSecurityAuthBypassOptionsList';import { SettingsSecurityAuthProvidersOptionsList } from '@/settings/security/components/SettingsSecurityAuthProvidersOptionsList';import { SettingsSecurityEditableProfileFields } from '@/settings/security/components/SettingsSecurityEditableProfileFields';+import { SettingsSecurityIframeMediaPermissions } from '@/settings/security/components/SettingsSecurityIframeMediaPermissions';import { SettingsSecurityIframeOrigins } from '@/settings/security/components/SettingsSecurityIframeOrigins';import { SettingsSsoIdentitiesProvidersListCard } from '@/settings/security/components/sso/SettingsSsoIdentitiesProvidersListCard';import { ssoIdentitiesProvidersState } from '@/settings/security/states/ssoIdentitiesProvidersState';@@ -201,6 +202,7 @@ export const SettingsSecuritySettings = () => {</Section.Root><SettingsRoleDefaultRole roles={roles} /><SettingsSecurityIframeOrigins />+ <SettingsSecurityIframeMediaPermissions />{shouldShowBypassSection && (<Section.Root><StyledContainer>diff --git a/packages/twenty-front/src/modules/settings/security/components/__stories__/SettingsSecurityIframeMediaPermissions.stories.tsx b/packages/twenty-front/src/modules/settings/security/components/__stories__/SettingsSecurityIframeMediaPermissions.stories.tsxnew file mode 100644index 00000000000..98a08c4f7be--- /dev/null+++ b/packages/twenty-front/src/modules/settings/security/components/__stories__/SettingsSecurityIframeMediaPermissions.stories.tsx@@ -0,0 +1,156 @@+import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';+import { SettingsSecurityIframeMediaPermissions } from '@/settings/security/components/SettingsSecurityIframeMediaPermissions';+import { jotaiStore } from '@/ui/utilities/state/jotai/jotaiStore';+import { type Meta, type StoryObj } from '@storybook/react-vite';+import { graphql, HttpResponse } from 'msw';+import { expect, fn, userEvent, waitFor, within } from 'storybook/test';+import { type IframeMediaPermission } from 'twenty-shared/types';+import { ComponentDecorator } from 'twenty-ui/testing';+import {+ type UpdateWorkspaceIframeMediaPermissionsMutation,+ type UpdateWorkspaceIframeMediaPermissionsMutationVariables,+} from '~/generated-metadata/graphql';+import { ToastDecorator } from '~/testing/decorators/ToastDecorator';+import { mockedUserData } from '~/testing/mock-data/users';++const WORKSPACE_ID = 'iframe-media-settings-workspace';+const ORIGIN = 'https://workspace.aircall.io';+const saveRequest = fn();+let permissions: IframeMediaPermission[] = [];++const getUpdatedWorkspace =+ (): UpdateWorkspaceIframeMediaPermissionsMutation['updateWorkspaceIframeMediaPermissions'] => ({+ __typename: 'Workspace',+ id: WORKSPACE_ID,+ iframeMediaPermissions: permissions.map((permission) => ({+ __typename: 'IframeMediaPermission',+ ...permission,+ })),+ });++const meta: Meta<typeof SettingsSecurityIframeMediaPermissions> = {+ title: 'Modules/Settings/Security/IframeMediaPermissions',+ component: SettingsSecurityIframeMediaPermissions,+ decorators: [ToastDecorator, ComponentDecorator],+ beforeEach: () => {+ permissions = [];+ saveRequest.mockClear();+ jotaiStore.set(currentWorkspaceState.atom, {+ ...mockedUserData.currentWorkspace,+ workspaceCustomApplication:+ mockedUserData.currentWorkspace.workspaceCustomApplication ?? null,+ installedApplications: [],+ iframeMediaPermissions: [],+ });+ },+ parameters: {+ msw: {+ handlers: [+ graphql.mutation<+ UpdateWorkspaceIframeMediaPermissionsMutation,+ UpdateWorkspaceIframeMediaPermissionsMutationVariables+ >('UpdateWorkspaceIframeMediaPermissions', ({ variables }) => {+ const permission = variables.input;+ saveRequest(permission);+ permissions = permissions.filter(+ (existingPermission) =>+ existingPermission.origin !== permission.origin,+ );++ if (permission.microphone || permission.camera) {+ permissions.push(permission);+ }++ return HttpResponse.json({+ data: {+ updateWorkspaceIframeMediaPermissions: getUpdatedWorkspace(),+ },+ });+ }),+ ],+ },+ },+};++export default meta;++export const ConfiguresMediaPermissions: StoryObj<typeof meta> = {+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ const form = within(+ canvas.getByRole('group', { name: 'Add embedded website' }),+ );+ const originInput = form.getByRole('textbox');+ const addButton = form.getByRole('button', { name: 'Add website' });++ await waitFor(() => expect(originInput).toBeEnabled());+ await userEvent.type(originInput, 'http://workspace.aircall.io');+ await expect(addButton).toBeDisabled();+ await userEvent.click(form.getByRole('switch', { name: 'Microphone' }));+ await userEvent.click(addButton);+ await expect(+ form.getByText(+ 'Enter an HTTPS origin without a path or wildcard, such as https://workspace.aircall.io.',+ ),+ ).toBeVisible();+ await expect(saveRequest).not.toHaveBeenCalled();++ await userEvent.clear(originInput);+ await userEvent.type(originInput, ORIGIN);+ await userEvent.click(addButton);++ const originRow = within(+ await canvas.findByRole('group', { name: ORIGIN }),+ );+ await expect(saveRequest).toHaveBeenLastCalledWith({+ origin: ORIGIN,+ microphone: true,+ camera: false,+ });+ await expect(+ originRow.getByRole('switch', { name: 'Microphone' }),+ ).toBeChecked();+ const cameraSwitch = originRow.getByRole('switch', { name: 'Camera' });+ const microphoneSwitch = originRow.getByRole('switch', {+ name: 'Microphone',+ });+ await expect(cameraSwitch).not.toBeChecked();+ await waitFor(() => expect(cameraSwitch).toBeEnabled());+ await expect(microphoneSwitch).toHaveAttribute('aria-disabled', 'true');+ await userEvent.click(cameraSwitch);+ await waitFor(() => expect(cameraSwitch).toBeChecked());++ await waitFor(() => expect(microphoneSwitch).toBeEnabled());+ await userEvent.click(microphoneSwitch);+ await waitFor(() => expect(microphoneSwitch).not.toBeChecked());+ await expect(cameraSwitch).toBeChecked();+ await expect(cameraSwitch).toHaveAttribute('aria-disabled', 'true');+ await expect(saveRequest).toHaveBeenLastCalledWith({+ origin: ORIGIN,+ microphone: false,+ camera: true,+ });++ const removeButton = originRow.getByRole('button', {+ name: `Remove media access for ${ORIGIN}`,+ });+ await waitFor(() => expect(removeButton).toBeEnabled());+ await userEvent.click(removeButton);+ await waitFor(() =>+ expect(+ canvas.queryByRole('group', { name: ORIGIN }),+ ).not.toBeInTheDocument(),+ );+ await expect(saveRequest).toHaveBeenLastCalledWith({+ origin: ORIGIN,+ microphone: false,+ camera: false,+ });+ await expect(canvas.getByRole('status')).toHaveTextContent(+ 'Reloading ends active calls and recordings.',+ );+ await expect(+ canvas.getByRole('button', { name: 'Reload page' }),+ ).toBeVisible();+ },+};diff --git a/packages/twenty-front/src/modules/settings/security/contexts/SettingsSecurityIframeMediaPermissionsContext.ts b/packages/twenty-front/src/modules/settings/security/contexts/SettingsSecurityIframeMediaPermissionsContext.tsnew file mode 100644index 00000000000..b467b63cb84--- /dev/null+++ b/packages/twenty-front/src/modules/settings/security/contexts/SettingsSecurityIframeMediaPermissionsContext.ts@@ -0,0 +1,13 @@+import { type IframeMediaPermission } from 'twenty-shared/types';+import { createRequiredContext } from '~/utils/createRequiredContext';++type SettingsSecurityIframeMediaPermissionsContextType = {+ savePermission: (permission: IframeMediaPermission) => Promise<boolean>;+};++export const [+ SettingsSecurityIframeMediaPermissionsProvider,+ useSettingsSecurityIframeMediaPermissionsOrThrow,+] = createRequiredContext<SettingsSecurityIframeMediaPermissionsContextType>(+ 'SettingsSecurityIframeMediaPermissions',+);