The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Fix record title crash on non-string value (trim is not a function) (#23950)
Thomas Trompette8dd2cf31942d
diff --git a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldDisplay.tsx b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldDisplay.tsxindex e476beabb45..938c5a0571c 100644--- a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldDisplay.tsx+++ b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldDisplay.tsx@@ -6,8 +6,8 @@ import { getRecordFieldInputInstanceId } from '@/object-record/utils/getRecordFiimport { useAtomFamilyStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomFamilyStateValue';import { styled } from '@linaria/react';import { t } from '@lingui/core/macro';+import { isNonEmptyString } from '@sniptt/guards';import { useContext } from 'react';-import { isDefined } from 'twenty-shared/utils';import { OverflowingTextWithTooltip } from 'twenty-ui/surfaces';import { themeCssVariables } from 'twenty-ui/theme-constants';@@ -43,7 +43,7 @@ export const RecordTitleCellSingleTextDisplayMode = ({const recordStore = useAtomFamilyStateValue(recordStoreFamilyState, recordId);const fieldValue = recordStore?.[fieldDefinition.metadata.fieldName];- const isEmpty = !isDefined(fieldValue) || fieldValue.trim() === '';+ const isEmpty = !isNonEmptyString(fieldValue) || fieldValue.trim() === '';const { openRecordTitleCell } = useRecordTitleCell();@@ -64,12 +64,7 @@ export const RecordTitleCellSingleTextDisplayMode = ({{isEmpty ? (<StyledEmptyText>{t`Untitled`}</StyledEmptyText>) : (- <OverflowingTextWithTooltip- text={- recordStore?.[fieldDefinition.metadata.fieldName] ||- fieldDefinition.label- }- />+ <OverflowingTextWithTooltip text={fieldValue} />)}</StyledDiv>);