Skip to content

The open alternative to Salesforce, designed for AI.

Reject records-API writes on workflow and workflowVersion (#27855)

Thomas Trompette8e210e55af5a
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/__tests__/workflow-create-many.pre-query.hook.spec.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/__tests__/workflow-create-many.pre-query.hook.spec.ts
deleted file mode 100644
index 44365204518..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/__tests__/workflow-create-many.pre-query.hook.spec.ts
+++ /dev/null
@@ -1,104 +0,0 @@
-import { type CreateManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowStatus } from 'src/engine/core-modules/workflow/enums/workflow-status.enum';
-import { WorkflowCreateManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-create-many.pre-query.hook';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-describe('WorkflowCreateManyPreQueryHook', () => {
- const hook = new WorkflowCreateManyPreQueryHook();
- const authContext = {} as WorkspaceAuthContext;
- const objectName = 'workflow';
-
- const buildPayload = (
- data: Array<Partial<WorkflowWorkspaceEntity>>,
- ): CreateManyResolverArgs<WorkflowWorkspaceEntity> => ({
- data: data as WorkflowWorkspaceEntity[],
- });
-
- // Regression guard: prior to this hook silently stripping `statuses`, passing
- // any non-empty `statuses` array to `createManyWorkflows` made the resolver
- // throw `WorkflowQueryValidationException` ("Statuses cannot be set
- // manually."), which surfaced to clients as a 400 Bad Request and broke
- // workflow creation in prod whenever the client forwarded a default value
- // computed from the multi-select field metadata.
- it('should not respond a 400 when statuses are passed in any entry of the payload (regression)', async () => {
- await expect(
- hook.execute(
- authContext,
- objectName,
- buildPayload([
- { name: 'Workflow 1', statuses: [WorkflowStatus.ACTIVE] },
- { name: 'Workflow 2' },
- { name: 'Workflow 3', statuses: [WorkflowStatus.DRAFT] },
- ]),
- ),
- ).resolves.toBeDefined();
- });
-
- it('should strip statuses from every entry that has it set', async () => {
- const result = await hook.execute(
- authContext,
- objectName,
- buildPayload([
- { name: 'Workflow 1', statuses: [WorkflowStatus.ACTIVE] },
- { name: 'Workflow 2', statuses: [WorkflowStatus.DRAFT] },
- ]),
- );
-
- expect(result.data).toHaveLength(2);
- expect(result.data[0]).not.toHaveProperty('statuses');
- expect(result.data[0].name).toBe('Workflow 1');
- expect(result.data[1]).not.toHaveProperty('statuses');
- expect(result.data[1].name).toBe('Workflow 2');
- });
-
- it('should strip statuses when it is an empty array', async () => {
- const result = await hook.execute(
- authContext,
- objectName,
- buildPayload([{ name: 'Workflow 1', statuses: [] }]),
- );
-
- expect(result.data[0]).not.toHaveProperty('statuses');
- expect(result.data[0].name).toBe('Workflow 1');
- });
-
- it('should leave entries untouched when statuses is not set', async () => {
- const result = await hook.execute(
- authContext,
- objectName,
- buildPayload([{ name: 'Workflow 1' }, { name: 'Workflow 2' }]),
- );
-
- expect(result.data[0]).not.toHaveProperty('statuses');
- expect(result.data[0].name).toBe('Workflow 1');
- expect(result.data[1]).not.toHaveProperty('statuses');
- expect(result.data[1].name).toBe('Workflow 2');
- });
-
- it('should preserve other top-level payload fields (e.g. upsert)', async () => {
- const result = await hook.execute(authContext, objectName, {
- data: [
- {
- name: 'Workflow 1',
- statuses: [WorkflowStatus.ACTIVE],
- } as WorkflowWorkspaceEntity,
- ],
- upsert: true,
- });
-
- expect(result.upsert).toBe(true);
- expect(result.data[0]).not.toHaveProperty('statuses');
- expect(result.data[0].name).toBe('Workflow 1');
- });
-
- it('should return an empty data array unchanged', async () => {
- const result = await hook.execute(
- authContext,
- objectName,
- buildPayload([]),
- );
-
- expect(result.data).toEqual([]);
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/__tests__/workflow-create-one.pre-query.hook.spec.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/__tests__/workflow-create-one.pre-query.hook.spec.ts
deleted file mode 100644
index 828795e3bfc..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/__tests__/workflow-create-one.pre-query.hook.spec.ts
+++ /dev/null
@@ -1,89 +0,0 @@
-import { type CreateOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowStatus } from 'src/engine/core-modules/workflow/enums/workflow-status.enum';
-import { WorkflowCreateOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-create-one.pre-query.hook';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-describe('WorkflowCreateOnePreQueryHook', () => {
- const hook = new WorkflowCreateOnePreQueryHook();
- const authContext = {} as WorkspaceAuthContext;
- const objectName = 'workflow';
-
- const buildPayload = (
- data: Partial<WorkflowWorkspaceEntity>,
- ): CreateOneResolverArgs<WorkflowWorkspaceEntity> => ({
- data: data as WorkflowWorkspaceEntity,
- });
-
- // Regression guard: prior to this hook silently stripping `statuses`, passing
- // any non-empty `statuses` array to `createOneWorkflow` made the resolver
- // throw `WorkflowQueryValidationException` ("Statuses cannot be set
- // manually."), which surfaced to clients as a 400 Bad Request and broke
- // workflow creation in prod whenever the client forwarded a default value
- // computed from the multi-select field metadata.
- it('should not respond a 400 when statuses are passed in the payload (regression)', async () => {
- await expect(
- hook.execute(
- authContext,
- objectName,
- buildPayload({
- name: 'My workflow',
- statuses: [WorkflowStatus.ACTIVE, WorkflowStatus.DRAFT],
- }),
- ),
- ).resolves.toBeDefined();
- });
-
- it('should strip statuses from payload data when statuses is set', async () => {
- const result = await hook.execute(
- authContext,
- objectName,
- buildPayload({
- name: 'My workflow',
- statuses: [WorkflowStatus.ACTIVE],
- }),
- );
-
- expect(result.data).not.toHaveProperty('statuses');
- expect(result.data.name).toBe('My workflow');
- });
-
- it('should strip statuses from payload data when statuses is an empty array', async () => {
- const result = await hook.execute(
- authContext,
- objectName,
- buildPayload({
- name: 'My workflow',
- statuses: [],
- }),
- );
-
- expect(result.data).not.toHaveProperty('statuses');
- expect(result.data.name).toBe('My workflow');
- });
-
- it('should leave payload data untouched when statuses is not set', async () => {
- const result = await hook.execute(
- authContext,
- objectName,
- buildPayload({ name: 'My workflow' }),
- );
-
- expect(result.data).not.toHaveProperty('statuses');
- expect(result.data.name).toBe('My workflow');
- });
-
- it('should preserve other top-level payload fields (e.g. upsert)', async () => {
- const result = await hook.execute(authContext, objectName, {
- data: {
- name: 'My workflow',
- statuses: [WorkflowStatus.DRAFT],
- } as WorkflowWorkspaceEntity,
- upsert: true,
- });
-
- expect(result.upsert).toBe(true);
- expect(result.data).not.toHaveProperty('statuses');
- expect(result.data.name).toBe('My workflow');
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-many.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-many.post-query.hook.ts
deleted file mode 100644
index 9d36a2eb9db..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-many.post-query.hook.ts
+++ /dev/null
@@ -1,76 +0,0 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { RecordPositionService } from 'src/engine/core-modules/record-position/services/record-position.service';
-import { WorkflowCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-core-sync.service';
-import { WorkflowVersionCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-version-core-sync.service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
-import { WorkspaceOrmManager } from 'src/engine/twenty-orm/workspace-orm.manager';
-import {
- WorkflowVersionStatus,
- type WorkflowVersionWorkspaceEntity,
-} from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-@WorkspaceQueryHook({
- key: `workflow.createMany`,
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowCreateManyPostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCoreSyncService: WorkflowCoreSyncService,
- private readonly workspaceOrmManager: WorkspaceOrmManager,
- private readonly recordPositionService: RecordPositionService,
- private readonly workflowVersionCoreSyncService: WorkflowVersionCoreSyncService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCoreSyncService.upsertToCore(
- workspace.id,
- payload.map((workflow) => workflow.id),
- );
-
- const position = await this.workspaceOrmManager.executeInWorkspaceContext(
- () =>
- this.recordPositionService.buildRecordPosition({
- value: 'first',
- objectMetadata: {
- isCustom: false,
- nameSingular: 'workflowVersion',
- },
- workspaceId: workspace.id,
- }),
- authContext,
- );
-
- for (const workflow of payload) {
- await this.workflowVersionCoreSyncService.writeWorkflowVersionAndMirror(
- workspace.id,
- async (workflowVersionRepository) => {
- const insertResult = await workflowVersionRepository.insert({
- workflowId: workflow.id,
- status: WorkflowVersionStatus.DRAFT,
- name: 'v1',
- position,
- });
-
- return (
- insertResult.generatedMaps[0] as WorkflowVersionWorkspaceEntity
- ).id;
- },
- );
- }
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-many.pre-query.hook.ts
index fed9b04f388..c8b702bcb7e 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-many.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-many.pre-query.hook.ts
@@ -2,30 +2,17 @@ import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/works
import { type CreateManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
@WorkspaceQueryHook(`workflow.createMany`)
export class WorkflowCreateManyPreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(
- _authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: CreateManyResolverArgs<WorkflowWorkspaceEntity>,
- ): Promise<CreateManyResolverArgs<WorkflowWorkspaceEntity>> {
- const sanitizedData = payload.data.map((workflow) => {
- const {
- statuses: _statuses,
- coreWorkflowId: _coreWorkflowId,
- lastPublishedVersionId: _lastPublishedVersionId,
- ...workflowWithoutStatuses
- } = workflow; // silent not to break creation from view with filter
-
- return workflowWithoutStatuses as WorkflowWorkspaceEntity;
- });
-
- return {
- ...payload,
- data: sanitizedData,
- };
+ async execute(): Promise<CreateManyResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
}
}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-one.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-one.post-query.hook.ts
deleted file mode 100644
index cbaba628e97..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-one.post-query.hook.ts
+++ /dev/null
@@ -1,44 +0,0 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-core-sync.service';
-import { WorkflowVersionCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-version-core-sync.service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-@WorkspaceQueryHook({
- key: `workflow.createOne`,
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowCreateOnePostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCoreSyncService: WorkflowCoreSyncService,
- private readonly workflowVersionCoreSyncService: WorkflowVersionCoreSyncService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCoreSyncService.upsertToCore(
- workspace.id,
- payload.map((workflow) => workflow.id),
- );
-
- const workflow = payload[0];
-
- await this.workflowVersionCoreSyncService.createInitialDraftVersionForWorkflow(
- workspace.id,
- workflow.id,
- );
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-one.pre-query.hook.ts
index 39270bdc171..40a6b18e0d6 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-create-one.pre-query.hook.ts
@@ -2,26 +2,17 @@ import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/works
import { type CreateOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
@WorkspaceQueryHook(`workflow.createOne`)
export class WorkflowCreateOnePreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(
- _authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: CreateOneResolverArgs<WorkflowWorkspaceEntity>,
- ): Promise<CreateOneResolverArgs<WorkflowWorkspaceEntity>> {
- const {
- statuses: _statuses,
- coreWorkflowId: _coreWorkflowId,
- lastPublishedVersionId: _lastPublishedVersionId,
- ...dataWithoutStatuses
- } = payload.data; // silent not to break creation from view with filter
-
- return {
- ...payload,
- data: dataWithoutStatuses as WorkflowWorkspaceEntity,
- };
+ async execute(): Promise<CreateOneResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
}
}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-many.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-many.post-query.hook.ts
deleted file mode 100644
index 506e0bc9873..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-many.post-query.hook.ts
+++ /dev/null
@@ -1,36 +0,0 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
-
-@WorkspaceQueryHook({
- key: `workflow.deleteMany`,
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowDeleteManyPostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCommonWorkspaceService.handleWorkflowSubEntities({
- workflowIds: payload.map((workflow) => workflow.id),
- workspaceId: workspace.id,
- operation: 'delete',
- });
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-many.pre-query.hook.ts
new file mode 100644
index 00000000000..490be9be8a5
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-many.pre-query.hook.ts
@@ -0,0 +1,18 @@
+import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
+import { type DeleteManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
+
+import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
+
+@WorkspaceQueryHook(`workflow.deleteMany`)
+export class WorkflowDeleteManyPreQueryHook implements WorkspacePreQueryHookInstance {
+ async execute(): Promise<DeleteManyResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
+ }
+}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-one.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-one.post-query.hook.ts
deleted file mode 100644
index e0dcfbfa025..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-one.post-query.hook.ts
+++ /dev/null
@@ -1,36 +0,0 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
-
-@WorkspaceQueryHook({
- key: `workflow.deleteOne`,
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowDeleteOnePostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCommonWorkspaceService.handleWorkflowSubEntities({
- workflowIds: payload.map((workflow) => workflow.id),
- workspaceId: workspace.id,
- operation: 'delete',
- });
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-one.pre-query.hook.ts
new file mode 100644
index 00000000000..949e3802094
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-delete-one.pre-query.hook.ts
@@ -0,0 +1,18 @@
+import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
+import { type DeleteOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
+
+import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
+
+@WorkspaceQueryHook(`workflow.deleteOne`)
+export class WorkflowDeleteOnePreQueryHook implements WorkspacePreQueryHookInstance {
+ async execute(): Promise<DeleteOneResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
+ }
+}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-many.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-many.post-query.hook.ts
deleted file mode 100644
index 169035b6363..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-many.post-query.hook.ts
+++ /dev/null
@@ -1,35 +0,0 @@
-import { WorkflowCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-core-sync.service';
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-@WorkspaceQueryHook({
- key: `workflow.destroyMany`,
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowDestroyManyPostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCoreSyncService: WorkflowCoreSyncService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCoreSyncService.reconcileWorkspaceWorkflows(
- authContext.workspace.id,
- payload.map((workflow) => workflow.id),
- );
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-many.pre-query.hook.ts
index 7f3befa73f4..1f9afd88d23 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-many.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-many.pre-query.hook.ts
@@ -1,34 +1,18 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
import { type DestroyManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-@WorkspaceQueryHook('workflow.destroyMany')
+@WorkspaceQueryHook(`workflow.destroyMany`)
export class WorkflowDestroyManyPreQueryHook implements WorkspacePreQueryHookInstance {
- constructor(
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: DestroyManyResolverArgs<{ id: { in: string[] } }>,
- ): Promise<DestroyManyResolverArgs<{ id: { in: string[] } }>> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCommonWorkspaceService.handleWorkflowSubEntities({
- workflowIds: payload.filter.id.in,
- workspaceId: workspace.id,
- operation: 'destroy',
- });
-
- return payload;
+ async execute(): Promise<DestroyManyResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
}
}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-one.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-one.post-query.hook.ts
deleted file mode 100644
index 6ee9a3b1737..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-one.post-query.hook.ts
+++ /dev/null
@@ -1,35 +0,0 @@
-import { WorkflowCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-core-sync.service';
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-@WorkspaceQueryHook({
- key: `workflow.destroyOne`,
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowDestroyOnePostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCoreSyncService: WorkflowCoreSyncService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCoreSyncService.reconcileWorkspaceWorkflows(
- authContext.workspace.id,
- payload.map((workflow) => workflow.id),
- );
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-one.pre-query.hook.ts
index 261ce163ad6..b22265cb91f 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-destroy-one.pre-query.hook.ts
@@ -1,34 +1,18 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
import { type DestroyOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-@WorkspaceQueryHook('workflow.destroyOne')
+@WorkspaceQueryHook(`workflow.destroyOne`)
export class WorkflowDestroyOnePreQueryHook implements WorkspacePreQueryHookInstance {
- constructor(
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: DestroyOneResolverArgs,
- ): Promise<DestroyOneResolverArgs> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCommonWorkspaceService.handleWorkflowSubEntities({
- workflowIds: [payload.id],
- workspaceId: workspace.id,
- operation: 'destroy',
- });
-
- return payload;
+ async execute(): Promise<DestroyOneResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
}
}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-merge-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-merge-many.pre-query.hook.ts
new file mode 100644
index 00000000000..5a4b148d9e7
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-merge-many.pre-query.hook.ts
@@ -0,0 +1,18 @@
+import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
+import { type MergeManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
+
+import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
+
+@WorkspaceQueryHook(`workflow.mergeMany`)
+export class WorkflowMergeManyPreQueryHook implements WorkspacePreQueryHookInstance {
+ async execute(): Promise<MergeManyResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
+ }
+}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-query-hook.module.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-query-hook.module.ts
index 1f4111eeb20..2346c1dd0d0 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-query-hook.module.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-query-hook.module.ts
@@ -1,90 +1,64 @@
-import { WorkflowCoreModule } from 'src/engine/core-modules/workflow/workflow-core.module';
import { Module } from '@nestjs/common';
-import { CommandMenuItemModule } from 'src/engine/metadata-modules/command-menu-item/command-menu-item.module';
-import { RecordPositionModule } from 'src/engine/core-modules/record-position/record-position.module';
-import { WorkflowVersionCoreModule } from 'src/engine/core-modules/workflow/workflow-version-core.module';
-import { WorkflowCreateManyPostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-create-many.post-query.hook';
import { WorkflowCreateManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-create-many.pre-query.hook';
-import { WorkflowCreateOnePostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-create-one.post-query.hook';
import { WorkflowCreateOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-create-one.pre-query.hook';
-import { WorkflowDeleteManyPostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-delete-many.post-query.hook';
-import { WorkflowDeleteOnePostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-delete-one.post-query.hook';
-import { WorkflowDestroyManyPostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-destroy-many.post-query.hook';
+import { WorkflowDeleteManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-delete-many.pre-query.hook';
+import { WorkflowDeleteOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-delete-one.pre-query.hook';
import { WorkflowDestroyManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-destroy-many.pre-query.hook';
-import { WorkflowDestroyOnePostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-destroy-one.post-query.hook';
import { WorkflowDestroyOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-destroy-one.pre-query.hook';
-import { WorkflowRestoreManyPostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-restore-many.post-query.hook';
-import { WorkflowRestoreOnePostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-restore-one.post-query.hook';
+import { WorkflowMergeManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-merge-many.pre-query.hook';
+import { WorkflowRestoreManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-restore-many.pre-query.hook';
+import { WorkflowRestoreOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-restore-one.pre-query.hook';
import { WorkflowRunCreateManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-run-create-many.pre-query.hook';
import { WorkflowRunCreateOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-run-create-one.pre-query.hook';
import { WorkflowRunDeleteManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-run-delete-many.pre-query.hook';
import { WorkflowRunDeleteOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-run-delete-one.pre-query.hook';
import { WorkflowRunUpdateManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-run-update-many.pre-query.hook';
import { WorkflowRunUpdateOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-run-update-one.pre-query.hook';
-import { WorkflowUpdateManyPostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-update-many.post-query.hook';
import { WorkflowUpdateManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-update-many.pre-query.hook';
-import { WorkflowUpdateOnePostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-update-one.post-query.hook';
import { WorkflowUpdateOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-update-one.pre-query.hook';
import { WorkflowVersionCreateManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-create-many.pre-query.hook';
import { WorkflowVersionCreateOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-create-one.pre-query.hook';
import { WorkflowVersionDeleteManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-delete-many.pre-query.hook';
-import { WorkflowVersionDeleteOnePostQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-delete-one.post-query.hook';
import { WorkflowVersionDeleteOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-delete-one.pre-query.hook';
import { WorkflowVersionDestroyManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-destroy-many.pre-query.hook';
import { WorkflowVersionDestroyOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-destroy-one.pre-query.hook';
+import { WorkflowVersionMergeManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-merge-many.pre-query.hook';
import { WorkflowVersionRestoreManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-restore-many.pre-query.hook';
import { WorkflowVersionRestoreOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-restore-one.pre-query.hook';
import { WorkflowVersionUpdateManyPreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-update-many.pre-query.hook';
import { WorkflowVersionUpdateOnePreQueryHook } from 'src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkflowMetadataReadModule } from 'src/modules/workflow/common/workspace-services/workflow-metadata-read.module';
-import { WorkflowVersionQueryValidationWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service';
@Module({
- imports: [
- WorkflowCoreModule,
- RecordPositionModule,
- CommandMenuItemModule,
- WorkflowVersionCoreModule,
- WorkflowMetadataReadModule,
- ],
providers: [
- WorkflowCreateOnePreQueryHook,
WorkflowCreateManyPreQueryHook,
- WorkflowUpdateOnePreQueryHook,
- WorkflowUpdateManyPreQueryHook,
- WorkflowUpdateOnePostQueryHook,
- WorkflowUpdateManyPostQueryHook,
- WorkflowRunCreateOnePreQueryHook,
+ WorkflowCreateOnePreQueryHook,
+ WorkflowDeleteManyPreQueryHook,
+ WorkflowDeleteOnePreQueryHook,
+ WorkflowDestroyManyPreQueryHook,
+ WorkflowDestroyOnePreQueryHook,
+ WorkflowMergeManyPreQueryHook,
+ WorkflowRestoreManyPreQueryHook,
+ WorkflowRestoreOnePreQueryHook,
WorkflowRunCreateManyPreQueryHook,
- WorkflowRunUpdateOnePreQueryHook,
- WorkflowRunUpdateManyPreQueryHook,
- WorkflowRunDeleteOnePreQueryHook,
+ WorkflowRunCreateOnePreQueryHook,
WorkflowRunDeleteManyPreQueryHook,
- WorkflowRestoreOnePostQueryHook,
- WorkflowRestoreManyPostQueryHook,
- WorkflowVersionCreateOnePreQueryHook,
+ WorkflowRunDeleteOnePreQueryHook,
+ WorkflowRunUpdateManyPreQueryHook,
+ WorkflowRunUpdateOnePreQueryHook,
+ WorkflowUpdateManyPreQueryHook,
+ WorkflowUpdateOnePreQueryHook,
WorkflowVersionCreateManyPreQueryHook,
- WorkflowVersionUpdateOnePreQueryHook,
- WorkflowVersionUpdateManyPreQueryHook,
- WorkflowVersionDeleteOnePreQueryHook,
- WorkflowVersionDeleteOnePostQueryHook,
+ WorkflowVersionCreateOnePreQueryHook,
WorkflowVersionDeleteManyPreQueryHook,
- WorkflowVersionDestroyOnePreQueryHook,
+ WorkflowVersionDeleteOnePreQueryHook,
WorkflowVersionDestroyManyPreQueryHook,
- WorkflowVersionRestoreOnePreQueryHook,
+ WorkflowVersionDestroyOnePreQueryHook,
+ WorkflowVersionMergeManyPreQueryHook,
WorkflowVersionRestoreManyPreQueryHook,
- WorkflowCreateOnePostQueryHook,
- WorkflowCreateManyPostQueryHook,
- WorkflowVersionQueryValidationWorkspaceService,
- WorkflowCommonWorkspaceService,
- WorkflowDeleteManyPostQueryHook,
- WorkflowDeleteOnePostQueryHook,
- WorkflowDestroyOnePreQueryHook,
- WorkflowDestroyManyPreQueryHook,
- WorkflowDestroyOnePostQueryHook,
- WorkflowDestroyManyPostQueryHook,
+ WorkflowVersionRestoreOnePreQueryHook,
+ WorkflowVersionUpdateManyPreQueryHook,
+ WorkflowVersionUpdateOnePreQueryHook,
],
})
export class WorkflowQueryHookModule {}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-many.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-many.post-query.hook.ts
deleted file mode 100644
index 214ef20c899..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-many.post-query.hook.ts
+++ /dev/null
@@ -1,36 +0,0 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
-
-@WorkspaceQueryHook({
- key: 'workflow.restoreMany',
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowRestoreManyPostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCommonWorkspaceService.handleWorkflowSubEntities({
- workflowIds: payload.map((workflow) => workflow.id),
- workspaceId: workspace.id,
- operation: 'restore',
- });
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-many.pre-query.hook.ts
new file mode 100644
index 00000000000..923efa37839
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-many.pre-query.hook.ts
@@ -0,0 +1,18 @@
+import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
+import { type RestoreManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
+
+import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
+
+@WorkspaceQueryHook(`workflow.restoreMany`)
+export class WorkflowRestoreManyPreQueryHook implements WorkspacePreQueryHookInstance {
+ async execute(): Promise<RestoreManyResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
+ }
+}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-one.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-one.post-query.hook.ts
deleted file mode 100644
index 128d6639ba9..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-one.post-query.hook.ts
+++ /dev/null
@@ -1,36 +0,0 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
-
-@WorkspaceQueryHook({
- key: 'workflow.restoreOne',
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowRestoreOnePostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowCommonWorkspaceService.handleWorkflowSubEntities({
- workflowIds: payload.map((workflow) => workflow.id),
- workspaceId: workspace.id,
- operation: 'restore',
- });
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-one.pre-query.hook.ts
new file mode 100644
index 00000000000..312a065d405
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-restore-one.pre-query.hook.ts
@@ -0,0 +1,18 @@
+import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
+import { type RestoreOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
+
+import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
+
+@WorkspaceQueryHook(`workflow.restoreOne`)
+export class WorkflowRestoreOnePreQueryHook implements WorkspacePreQueryHookInstance {
+ async execute(): Promise<RestoreOneResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
+ }
+}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-many.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-many.post-query.hook.ts
deleted file mode 100644
index 5817cfe2640..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-many.post-query.hook.ts
+++ /dev/null
@@ -1,40 +0,0 @@
-import { WorkflowCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-core-sync.service';
-import { isDefined } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-@WorkspaceQueryHook({
- key: `workflow.updateMany`,
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowUpdateManyPostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCoreSyncService: WorkflowCoreSyncService,
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workflowIds = payload
- .map((workflow) => workflow.id)
- .filter(isDefined);
-
- await this.workflowCommonWorkspaceService.syncCommandMenuItemLabelForWorkflows(
- workflowIds,
- authContext,
- );
- await this.workflowCoreSyncService.reconcileWorkspaceWorkflows(
- authContext.workspace.id,
- payload.map((workflow) => workflow.id),
- );
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-many.pre-query.hook.ts
index 1b0f2822c14..8db3dc0b035 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-many.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-many.pre-query.hook.ts
@@ -6,11 +6,10 @@ import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
@WorkspaceQueryHook(`workflow.updateMany`)
export class WorkflowUpdateManyPreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(): Promise<UpdateManyResolverArgs<WorkflowWorkspaceEntity>> {
+ async execute(): Promise<UpdateManyResolverArgs> {
throw new WorkflowQueryValidationException(
'Method not allowed.',
WorkflowQueryValidationExceptionCode.FORBIDDEN,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-one.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-one.post-query.hook.ts
deleted file mode 100644
index f8557f23082..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-one.post-query.hook.ts
+++ /dev/null
@@ -1,40 +0,0 @@
-import { WorkflowCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-core-sync.service';
-import { isDefined } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-@WorkspaceQueryHook({
- key: `workflow.updateOne`,
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowUpdateOnePostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowCoreSyncService: WorkflowCoreSyncService,
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowWorkspaceEntity[],
- ): Promise<void> {
- const workflowIds = payload
- .map((workflow) => workflow.id)
- .filter(isDefined);
-
- await this.workflowCommonWorkspaceService.syncCommandMenuItemLabelForWorkflows(
- workflowIds,
- authContext,
- );
- await this.workflowCoreSyncService.reconcileWorkspaceWorkflows(
- authContext.workspace.id,
- payload.map((workflow) => workflow.id),
- );
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-one.pre-query.hook.ts
index 7b8cea0d9a4..f6c9e047d86 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-update-one.pre-query.hook.ts
@@ -2,33 +2,17 @@ import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/works
import { type UpdateOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-import { assertWorkflowStatusesNotSet } from 'src/modules/workflow/common/utils/assert-workflow-statuses-not-set';
@WorkspaceQueryHook(`workflow.updateOne`)
export class WorkflowUpdateOnePreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(
- _authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: UpdateOneResolverArgs<WorkflowWorkspaceEntity>,
- ): Promise<UpdateOneResolverArgs<WorkflowWorkspaceEntity>> {
- assertWorkflowStatusesNotSet(payload.data.statuses);
-
- if (
- 'coreWorkflowId' in payload.data ||
- 'lastPublishedVersionId' in payload.data
- ) {
- throw new WorkflowQueryValidationException(
- 'Workflow execution links can only be changed through dedicated workflow mutations',
- WorkflowQueryValidationExceptionCode.FORBIDDEN,
- );
- }
-
- return payload;
+ async execute(): Promise<UpdateOneResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
}
}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-create-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-create-many.pre-query.hook.ts
index ce39209c7ef..c58ff64ab47 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-create-many.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-create-many.pre-query.hook.ts
@@ -2,20 +2,14 @@ import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/works
import { type CreateManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
@WorkspaceQueryHook(`workflowVersion.createMany`)
export class WorkflowVersionCreateManyPreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(
- _authContext: WorkspaceAuthContext,
- _objectName: string,
- _payload: CreateManyResolverArgs<WorkflowVersionWorkspaceEntity>,
- ): Promise<CreateManyResolverArgs<WorkflowVersionWorkspaceEntity>> {
+ async execute(): Promise<CreateManyResolverArgs> {
throw new WorkflowQueryValidationException(
'Method not allowed.',
WorkflowQueryValidationExceptionCode.FORBIDDEN,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-create-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-create-one.pre-query.hook.ts
index 6ab88306e8c..d44cd762273 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-create-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-create-one.pre-query.hook.ts
@@ -2,20 +2,14 @@ import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/works
import { type CreateOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
@WorkspaceQueryHook(`workflowVersion.createOne`)
export class WorkflowVersionCreateOnePreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(
- _authContext: WorkspaceAuthContext,
- _objectName: string,
- _payload: CreateOneResolverArgs<WorkflowVersionWorkspaceEntity>,
- ): Promise<CreateOneResolverArgs<WorkflowVersionWorkspaceEntity>> {
+ async execute(): Promise<CreateOneResolverArgs> {
throw new WorkflowQueryValidationException(
'Method not allowed.',
WorkflowQueryValidationExceptionCode.FORBIDDEN,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-many.pre-query.hook.ts
index 62ad3e09d18..7ce11b494ec 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-many.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-many.pre-query.hook.ts
@@ -6,13 +6,10 @@ import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
@WorkspaceQueryHook(`workflowVersion.deleteMany`)
export class WorkflowVersionDeleteManyPreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(): Promise<
- DeleteManyResolverArgs<WorkflowVersionWorkspaceEntity>
- > {
+ async execute(): Promise<DeleteManyResolverArgs> {
throw new WorkflowQueryValidationException(
'Method not allowed.',
WorkflowQueryValidationExceptionCode.FORBIDDEN,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.post-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.post-query.hook.ts
deleted file mode 100644
index c669007c9c9..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.post-query.hook.ts
+++ /dev/null
@@ -1,35 +0,0 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
-import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
-
-import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowVersionCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-version-core-sync.service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
-import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
-
-@WorkspaceQueryHook({
- key: `workflowVersion.deleteOne`,
- type: WorkspaceQueryHookType.POST_HOOK,
-})
-export class WorkflowVersionDeleteOnePostQueryHook implements WorkspacePostQueryHookInstance {
- constructor(
- private readonly workflowVersionCoreSyncService: WorkflowVersionCoreSyncService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: WorkflowVersionWorkspaceEntity[],
- ): Promise<void> {
- const workspace = authContext.workspace;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowVersionCoreSyncService.deleteCoreVersionsByWorkspaceVersionIds(
- workspace.id,
- payload.map((workflowVersion) => workflowVersion.id),
- );
- }
-}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.pre-query.hook.ts
index 49b6737c88e..68688476ee6 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-delete-one.pre-query.hook.ts
@@ -1,33 +1,18 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
import { type DeleteOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkflowVersionQueryValidationWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
@WorkspaceQueryHook(`workflowVersion.deleteOne`)
export class WorkflowVersionDeleteOnePreQueryHook implements WorkspacePreQueryHookInstance {
- constructor(
- private readonly workflowVersionQueryValidationWorkspaceService: WorkflowVersionQueryValidationWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: DeleteOneResolverArgs,
- ): Promise<DeleteOneResolverArgs> {
- const { workspace } = authContext;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowVersionQueryValidationWorkspaceService.validateWorkflowVersionForDeleteOne(
- workspace.id,
- payload,
+ async execute(): Promise<DeleteOneResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
);
-
- return payload;
}
}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-destroy-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-destroy-many.pre-query.hook.ts
index eac35780998..5211411ef4b 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-destroy-many.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-destroy-many.pre-query.hook.ts
@@ -2,7 +2,6 @@ import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/works
import { type DestroyManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
@@ -10,11 +9,7 @@ import {
@WorkspaceQueryHook(`workflowVersion.destroyMany`)
export class WorkflowVersionDestroyManyPreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(
- _authContext: WorkspaceAuthContext,
- _objectName: string,
- _payload: DestroyManyResolverArgs,
- ): Promise<DestroyManyResolverArgs> {
+ async execute(): Promise<DestroyManyResolverArgs> {
throw new WorkflowQueryValidationException(
'Method not allowed.',
WorkflowQueryValidationExceptionCode.FORBIDDEN,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-destroy-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-destroy-one.pre-query.hook.ts
index d15e0765c2c..46102a0a2e7 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-destroy-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-destroy-one.pre-query.hook.ts
@@ -2,7 +2,6 @@ import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/works
import { type DestroyOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
@@ -10,11 +9,7 @@ import {
@WorkspaceQueryHook(`workflowVersion.destroyOne`)
export class WorkflowVersionDestroyOnePreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(
- _authContext: WorkspaceAuthContext,
- _objectName: string,
- _payload: DestroyOneResolverArgs,
- ): Promise<DestroyOneResolverArgs> {
+ async execute(): Promise<DestroyOneResolverArgs> {
throw new WorkflowQueryValidationException(
'Method not allowed.',
WorkflowQueryValidationExceptionCode.FORBIDDEN,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-merge-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-merge-many.pre-query.hook.ts
new file mode 100644
index 00000000000..2367d65e42e
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-merge-many.pre-query.hook.ts
@@ -0,0 +1,18 @@
+import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
+import { type MergeManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
+
+import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
+
+@WorkspaceQueryHook(`workflowVersion.mergeMany`)
+export class WorkflowVersionMergeManyPreQueryHook implements WorkspacePreQueryHookInstance {
+ async execute(): Promise<MergeManyResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
+ );
+ }
+}
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-restore-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-restore-many.pre-query.hook.ts
index 09964c6e2de..f786e501603 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-restore-many.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-restore-many.pre-query.hook.ts
@@ -2,7 +2,6 @@ import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/works
import { type RestoreManyResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
@@ -10,11 +9,7 @@ import {
@WorkspaceQueryHook(`workflowVersion.restoreMany`)
export class WorkflowVersionRestoreManyPreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(
- _authContext: WorkspaceAuthContext,
- _objectName: string,
- _payload: RestoreManyResolverArgs,
- ): Promise<RestoreManyResolverArgs> {
+ async execute(): Promise<RestoreManyResolverArgs> {
throw new WorkflowQueryValidationException(
'Method not allowed.',
WorkflowQueryValidationExceptionCode.FORBIDDEN,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-restore-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-restore-one.pre-query.hook.ts
index c45c2a6ab61..41e1a5dd16a 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-restore-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-restore-one.pre-query.hook.ts
@@ -2,7 +2,6 @@ import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/works
import { type RestoreOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
@@ -10,11 +9,7 @@ import {
@WorkspaceQueryHook(`workflowVersion.restoreOne`)
export class WorkflowVersionRestoreOnePreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(
- _authContext: WorkspaceAuthContext,
- _objectName: string,
- _payload: RestoreOneResolverArgs,
- ): Promise<RestoreOneResolverArgs> {
+ async execute(): Promise<RestoreOneResolverArgs> {
throw new WorkflowQueryValidationException(
'Method not allowed.',
WorkflowQueryValidationExceptionCode.FORBIDDEN,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-many.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-many.pre-query.hook.ts
index 32138864923..b06f2043dcd 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-many.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-many.pre-query.hook.ts
@@ -6,13 +6,10 @@ import {
WorkflowQueryValidationException,
WorkflowQueryValidationExceptionCode,
} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
@WorkspaceQueryHook(`workflowVersion.updateMany`)
export class WorkflowVersionUpdateManyPreQueryHook implements WorkspacePreQueryHookInstance {
- async execute(): Promise<
- UpdateManyResolverArgs<WorkflowVersionWorkspaceEntity>
- > {
+ async execute(): Promise<UpdateManyResolverArgs> {
throw new WorkflowQueryValidationException(
'Method not allowed.',
WorkflowQueryValidationExceptionCode.FORBIDDEN,
diff --git a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook.ts b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook.ts
index 7955a55a4c3..e461eae9f3d 100644
--- a/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook.ts
+++ b/packages/twenty-server/src/modules/workflow/common/query-hooks/workflow-version-update-one.pre-query.hook.ts
@@ -1,36 +1,18 @@
-import { assertIsDefinedOrThrow } from 'twenty-shared/utils';
-
import { type WorkspacePreQueryHookInstance } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/interfaces/workspace-query-hook.interface';
import { type UpdateOneResolverArgs } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
import { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
-import { WorkflowVersionQueryValidationWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service';
-import { WorkspaceNotFoundDefaultError } from 'src/engine/core-modules/workspace/workspace.exception';
+import {
+ WorkflowQueryValidationException,
+ WorkflowQueryValidationExceptionCode,
+} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
@WorkspaceQueryHook(`workflowVersion.updateOne`)
export class WorkflowVersionUpdateOnePreQueryHook implements WorkspacePreQueryHookInstance {
- constructor(
- private readonly workflowVersionQueryValidationWorkspaceService: WorkflowVersionQueryValidationWorkspaceService,
- ) {}
-
- async execute(
- authContext: WorkspaceAuthContext,
- _objectName: string,
- payload: UpdateOneResolverArgs<WorkflowVersionWorkspaceEntity>,
- ): Promise<UpdateOneResolverArgs<WorkflowVersionWorkspaceEntity>> {
- const { workspace } = authContext;
-
- assertIsDefinedOrThrow(workspace, WorkspaceNotFoundDefaultError);
-
- await this.workflowVersionQueryValidationWorkspaceService.validateWorkflowVersionForUpdateOne(
- {
- workspaceId: workspace.id,
- payload,
- },
+ async execute(): Promise<UpdateOneResolverArgs> {
+ throw new WorkflowQueryValidationException(
+ 'Method not allowed.',
+ WorkflowQueryValidationExceptionCode.FORBIDDEN,
);
-
- return payload;
}
}
diff --git a/packages/twenty-server/src/modules/workflow/common/utils/assert-workflow-statuses-not-set.ts b/packages/twenty-server/src/modules/workflow/common/utils/assert-workflow-statuses-not-set.ts
deleted file mode 100644
index 928c3b04543..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/utils/assert-workflow-statuses-not-set.ts
+++ /dev/null
@@ -1,21 +0,0 @@
-import { msg } from '@lingui/core/macro';
-
-import {
- WorkflowQueryValidationException,
- WorkflowQueryValidationExceptionCode,
-} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-import { type WorkflowStatus } from 'src/engine/core-modules/workflow/enums/workflow-status.enum';
-
-export const assertWorkflowStatusesNotSet = (
- statuses?: WorkflowStatus[] | null,
-) => {
- if (statuses) {
- throw new WorkflowQueryValidationException(
- 'Statuses cannot be set manually.',
- WorkflowQueryValidationExceptionCode.FORBIDDEN,
- {
- userFriendlyMessage: msg`Statuses cannot be set manually.`,
- },
- );
- }
-};
diff --git a/packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service.ts b/packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service.ts
deleted file mode 100644
index 0aa1aa4391d..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/workspace-services/workflow-version-query-validation.workspace-service.ts
+++ /dev/null
@@ -1,162 +0,0 @@
-import { Injectable } from '@nestjs/common';
-
-import { msg } from '@lingui/core/macro';
-import { isNonEmptyString } from '@sniptt/guards';
-import { IsNull, Not } from 'typeorm';
-
-import {
- type CreateOneResolverArgs,
- type DeleteOneResolverArgs,
- type UpdateOneResolverArgs,
-} from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
-
-import { WorkspaceOrmManager } from 'src/engine/twenty-orm/workspace-orm.manager';
-import { buildSystemAuthContext } from 'src/engine/twenty-orm/utils/build-system-auth-context.util';
-import {
- WorkflowQueryValidationException,
- WorkflowQueryValidationExceptionCode,
-} from 'src/modules/workflow/common/exceptions/workflow-query-validation.exception';
-import {
- WorkflowVersionStatus,
- type WorkflowVersionWorkspaceEntity,
-} from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
-import { assertWorkflowVersionIsDraft } from 'src/modules/workflow/common/utils/assert-workflow-version-is-draft.util';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-
-@Injectable()
-export class WorkflowVersionQueryValidationWorkspaceService {
- constructor(
- private readonly workflowCommonWorkspaceService: WorkflowCommonWorkspaceService,
- private readonly workspaceOrmManager: WorkspaceOrmManager,
- ) {}
-
- async validateWorkflowVersionForCreateOne(
- workspaceId: string,
- payload: CreateOneResolverArgs<WorkflowVersionWorkspaceEntity>,
- ) {
- if (
- payload.data.status &&
- payload.data.status !== WorkflowVersionStatus.DRAFT
- ) {
- throw new WorkflowQueryValidationException(
- 'Cannot create workflow version with status other than draft',
- WorkflowQueryValidationExceptionCode.FORBIDDEN,
- {
- userFriendlyMessage: msg`Cannot create workflow version with status other than draft`,
- },
- );
- }
-
- const authContext = buildSystemAuthContext(workspaceId);
-
- await this.workspaceOrmManager.executeInWorkspaceContext(async () => {
- const workflowVersionRepository =
- this.workspaceOrmManager.getRepository<WorkflowVersionWorkspaceEntity>(
- 'workflowVersion',
- { shouldBypassPermissionChecks: true },
- );
-
- const workflowAlreadyHasDraftVersion =
- await workflowVersionRepository.exists({
- where: {
- workflowId: payload.data.workflowId,
- status: WorkflowVersionStatus.DRAFT,
- deletedAt: IsNull(),
- },
- });
-
- if (workflowAlreadyHasDraftVersion) {
- throw new WorkflowQueryValidationException(
- 'Cannot create multiple draft versions for the same workflow',
- WorkflowQueryValidationExceptionCode.FORBIDDEN,
- {
- userFriendlyMessage: msg`Cannot create multiple draft versions for the same workflow`,
- },
- );
- }
- }, authContext);
- }
-
- async validateWorkflowVersionForUpdateOne({
- workspaceId,
- payload,
- }: {
- workspaceId: string;
- payload: UpdateOneResolverArgs<WorkflowVersionWorkspaceEntity>;
- }) {
- await this.workflowCommonWorkspaceService.getWorkflowVersionOrFail({
- workspaceId,
- workflowVersionId: payload.id,
- });
-
- const protectedFieldNames = [
- 'steps',
- 'trigger',
- 'status',
- 'position',
- 'workflowId',
- 'coreWorkflowVersionId',
- ];
- const setsProtectedField = protectedFieldNames.some(
- (fieldName) => fieldName in payload.data,
- );
- const clearsName =
- 'name' in payload.data && !isNonEmptyString(payload.data.name);
-
- if (setsProtectedField || clearsName) {
- throw new WorkflowQueryValidationException(
- 'Updating a workflowVersion through the generic mutation is restricted. ' +
- 'steps, trigger, status, position, workflowId and coreWorkflowVersionId cannot be changed, and the name cannot be cleared. ' +
- 'Use the dedicated workflowVersion mutations (createWorkflowVersionStep, updateWorkflowVersionStep, ' +
- 'deleteWorkflowVersionStep, updateWorkflowVersionTrigger, activateWorkflowVersion, ...) instead.',
- WorkflowQueryValidationExceptionCode.FORBIDDEN,
- {
- userFriendlyMessage: msg`This field cannot be updated directly on a workflow version`,
- },
- );
- }
- }
-
- async validateWorkflowVersionForDeleteOne(
- workspaceId: string,
- payload: DeleteOneResolverArgs,
- ) {
- const workflowVersion =
- await this.workflowCommonWorkspaceService.getWorkflowVersionOrFail({
- workspaceId,
- workflowVersionId: payload.id,
- });
-
- assertWorkflowVersionIsDraft(workflowVersion);
-
- const authContext = buildSystemAuthContext(workspaceId);
-
- await this.workspaceOrmManager.executeInWorkspaceContext(async () => {
- const workflowVersionRepository =
- this.workspaceOrmManager.getRepository<WorkflowVersionWorkspaceEntity>(
- 'workflowVersion',
- { shouldBypassPermissionChecks: true },
- );
-
- const otherWorkflowVersionsExist = await workflowVersionRepository.exists(
- {
- where: {
- workflowId: workflowVersion.workflowId,
- deletedAt: IsNull(),
- id: Not(workflowVersion.id),
- },
- },
- );
-
- if (!otherWorkflowVersionsExist) {
- throw new WorkflowQueryValidationException(
- 'The initial version of a workflow can not be deleted',
- WorkflowQueryValidationExceptionCode.FORBIDDEN,
- {
- userFriendlyMessage: msg`The initial version of a workflow can not be deleted`,
- },
- );
- }
- }, authContext);
- }
-}
diff --git a/packages/twenty-server/test/integration/graphql/suites/workflow/utils/update-workflow-version-trigger.util.ts b/packages/twenty-server/test/integration/graphql/suites/workflow/utils/update-workflow-version-trigger.util.ts
deleted file mode 100644
index c201aab13aa..00000000000
--- a/packages/twenty-server/test/integration/graphql/suites/workflow/utils/update-workflow-version-trigger.util.ts
+++ /dev/null
@@ -1,42 +0,0 @@
-import request from 'supertest';
-
-const client = request(`http://localhost:${APP_PORT}`);
-
-export const updateWorkflowVersionTrigger = async ({
- workflowVersionId,
- trigger,
-}: {
- workflowVersionId: string;
- trigger: object;
-}) => {
- const response = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send({
- query: `
- mutation UpdateWorkflowVersionTrigger(
- $input: UpdateWorkflowVersionTriggerInput!
- ) {
- updateWorkflowVersionTrigger(input: $input) {
- trigger
- }
- }
- `,
- variables: {
- input: {
- workflowVersionId,
- trigger,
- },
- },
- });
-
- if (response.body.errors) {
- throw new Error(
- `Failed to update workflow version trigger: ${JSON.stringify(
- response.body.errors,
- )}`,
- );
- }
-
- return response;
-};
diff --git a/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-resolver.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-resolver.integration-spec.ts
index 880a62396e5..bf4ad0300a9 100644
--- a/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-resolver.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/workflow/workflow-resolver.integration-spec.ts
@@ -1,233 +1,116 @@
import request from 'supertest';
-import { updateWorkflowVersionTrigger } from 'test/integration/graphql/suites/workflow/utils/update-workflow-version-trigger.util';
+import {
+ activateCoreWorkflowVersion,
+ coreWorkflowGraphqlRequest,
+ createCoreWorkflow,
+ createCoreWorkflowVersionStep,
+ deactivateCoreWorkflowVersion,
+ deleteCoreWorkflows,
+ findCoreWorkflowVersion,
+ updateCoreWorkflowVersionTrigger,
+} from 'test/integration/graphql/suites/workflow/utils/core-workflow.util';
import { findCommandMenuItems } from 'test/integration/metadata/suites/command-menu-item/utils/find-command-menu-items.util';
import { type CommandMenuItemDTO } from 'src/engine/metadata-modules/command-menu-item/dtos/command-menu-item.dto';
const client = request(`http://localhost:${APP_PORT}`);
-const testWorkflowId = 'd6f9be23-c8e6-42b2-93f5-34ee0f97f1c7';
-
describe('workflowResolver', () => {
- beforeAll(async () => {
- const queryData = {
- query: `
- mutation CreateOneWorkflow {
- createWorkflow(
- data: {
- name: "Custom Test Workflow"
- id: "${testWorkflowId}"
- }
- ) {
- id
- }
- }
- `,
- };
-
- await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send(queryData);
- });
-
- afterAll(async () => {
- const queryData = {
- query: `
- mutation DestroyOneWorkflow {
- destroyWorkflow(id: "${testWorkflowId}") {
- id
- }
- }
- `,
- };
-
- await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send(queryData);
- });
-
- it('should create workflow subEntities', async () => {
- const queryData = {
- query: `
- query FindOneWorkflow {
- workflow(filter: {id: {eq: "${testWorkflowId}"}}) {
- id
- deletedAt
- versions {
- edges {
- node {
- id
- deletedAt
- steps
- }
- }
- }
- }
- }
- `,
- };
-
- const response = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send(queryData);
+ let coreWorkflowId: string;
+ let workspaceWorkflowId: string;
+ let workspaceWorkflowVersionId: string;
- expect(response.status).toBe(200);
- expect(response.body.errors).toBeUndefined();
+ beforeAll(async () => {
+ const createdWorkflow = await createCoreWorkflow({
+ name: 'Records API write rejection',
+ });
+ const { workspaceWorkflowVersionId: draftWorkspaceWorkflowVersionId } =
+ await findCoreWorkflowVersion({
+ coreWorkflowVersionId: createdWorkflow.coreWorkflowVersionId,
+ });
- const workflow = response.body.data.workflow;
+ if (
+ createdWorkflow.workspaceWorkflowId === null ||
+ draftWorkspaceWorkflowVersionId === null
+ ) {
+ throw new Error('Expected the core workflow to have a workspace mirror');
+ }
- expect(workflow.id).toBe(testWorkflowId);
- expect(workflow.deletedAt).toBeNull();
- expect(workflow.versions.edges.length).toBeGreaterThan(0);
- expect(workflow.versions.edges[0].node.deletedAt).toBeNull();
+ coreWorkflowId = createdWorkflow.coreWorkflowId;
+ workspaceWorkflowId = createdWorkflow.workspaceWorkflowId;
+ workspaceWorkflowVersionId = draftWorkspaceWorkflowVersionId;
});
- it('should delete workflow subEntities', async () => {
- const deleteQueryData = {
- query: `
- mutation DeleteOneWorkflow {
- deleteWorkflow(id: "${testWorkflowId}") {
- id
- }
- }
- `,
- };
-
- const deleteResponse = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send(deleteQueryData);
-
- expect(deleteResponse.status).toBe(200);
-
- const queryData = {
- query: `
- query FindWorkflow {
- workflow(filter: {
- id: { eq: "${testWorkflowId}" },
- not: { deletedAt: { is: NULL } }
- }) {
- id
- deletedAt
- }
- }
- `,
- };
-
- const response = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send(queryData);
-
- expect(response.status).toBe(200);
- expect(response.body.errors).toBeUndefined();
-
- const workflow = response.body.data.workflow;
-
- expect(workflow.id).toBe(testWorkflowId);
- expect(workflow.deletedAt).not.toBeNull();
-
- const queryWorkflowVersionsData = {
- query: `
- query FindManyWorkflowVersions {
- workflowVersions(filter: {
- workflowId: { eq: "${testWorkflowId}" },
- not: { deletedAt: { is: NULL } }
- }) {
- edges {
- node {
- id
- deletedAt
- }
- }
- }
- }
- `,
- };
-
- const workflowVersionsResponse = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send(queryWorkflowVersionsData);
-
- expect(workflowVersionsResponse.status).toBe(200);
- expect(workflowVersionsResponse.body.errors).toBeUndefined();
-
- const workflowVersions =
- workflowVersionsResponse.body.data.workflowVersions;
-
- expect(workflowVersions.edges.length).toBeGreaterThan(0);
- expect(workflowVersions.edges[0].node.deletedAt).not.toBeNull();
+ afterAll(async () => {
+ await deleteCoreWorkflows({ coreWorkflowIds: [coreWorkflowId] });
});
- it('should restore workflow subEntities', async () => {
- const restoreQueryData = {
- query: `
- mutation RestoreOneWorkflow {
- restoreWorkflow(id: "${testWorkflowId}") {
- id
- }
- }
- `,
- };
-
- const restoreResponse = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send(restoreQueryData);
-
- expect(restoreResponse.status).toBe(200);
-
- const queryData = {
- query: `
- query FindOneWorkflow {
- workflow(filter: {id: {eq: "${testWorkflowId}"}}) {
- id
- deletedAt
- versions {
- edges {
- node {
- id
- deletedAt
- steps
- }
- }
- }
- }
- }
- `,
- };
-
+ it.each([
+ {
+ operation: 'createWorkflow',
+ buildQuery: () =>
+ 'mutation { createWorkflow(data: { name: "Records API Workflow" }) { id } }',
+ },
+ {
+ operation: 'createWorkflows',
+ buildQuery: () =>
+ 'mutation { createWorkflows(data: [{ name: "Records API Workflow" }]) { id } }',
+ },
+ {
+ operation: 'updateWorkflow',
+ buildQuery: () =>
+ `mutation { updateWorkflow(id: "${workspaceWorkflowId}", data: { name: "Renamed" }) { id } }`,
+ },
+ {
+ operation: 'deleteWorkflow',
+ buildQuery: () =>
+ `mutation { deleteWorkflow(id: "${workspaceWorkflowId}") { id } }`,
+ },
+ {
+ operation: 'destroyWorkflow',
+ buildQuery: () =>
+ `mutation { destroyWorkflow(id: "${workspaceWorkflowId}") { id } }`,
+ },
+ {
+ operation: 'restoreWorkflow',
+ buildQuery: () =>
+ `mutation { restoreWorkflow(id: "${workspaceWorkflowId}") { id } }`,
+ },
+ {
+ operation: 'updateWorkflowVersion',
+ buildQuery: () =>
+ `mutation { updateWorkflowVersion(id: "${workspaceWorkflowVersionId}", data: { name: "Renamed" }) { id } }`,
+ },
+ {
+ operation: 'deleteWorkflowVersion',
+ buildQuery: () =>
+ `mutation { deleteWorkflowVersion(id: "${workspaceWorkflowVersionId}") { id } }`,
+ },
+ {
+ operation: 'destroyWorkflowVersion',
+ buildQuery: () =>
+ `mutation { destroyWorkflowVersion(id: "${workspaceWorkflowVersionId}") { id } }`,
+ },
+ ])('rejects $operation through the records API', async ({ buildQuery }) => {
const response = await client
.post('/graphql')
.set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send(queryData);
-
- expect(response.status).toBe(200);
- expect(response.body.errors).toBeUndefined();
+ .send({ query: buildQuery() });
- const workflow = response.body.data.workflow;
-
- expect(workflow.id).toBe(testWorkflowId);
- expect(workflow.deletedAt).toBeNull();
- expect(workflow.versions.edges.length).toBeGreaterThan(0);
- expect(workflow.versions.edges[0].node.deletedAt).toBeNull();
+ expect(response.body.errors?.[0]?.message).toBe('Method not allowed.');
});
});
const COMMAND_MENU_ITEM_GQL_FIELDS = `
id
- workflowVersionId
+ coreWorkflowVersionId
engineComponentKey
label
shortLabel
`;
const findCommandMenuItemForWorkflowVersion = async (
- workflowVersionId: string,
+ coreWorkflowVersionId: string,
): Promise<CommandMenuItemDTO | undefined> => {
const { data } = await findCommandMenuItems({
input: undefined,
@@ -235,78 +118,38 @@ const findCommandMenuItemForWorkflowVersion = async (
});
return data?.commandMenuItems.find(
- (item) => item.workflowVersionId === workflowVersionId,
+ (item) => item.coreWorkflowVersionId === coreWorkflowVersionId,
);
};
describe('workflowResolver command menu item label', () => {
const initialWorkflowName = 'Command Menu Label Sync Test';
- let createdWorkflowId: string | null = null;
- let createdWorkflowVersionId: string | null = null;
+ let coreWorkflowId: string | null = null;
+ let coreWorkflowVersionId: string | null = null;
const renameWorkflow = async (name: string) => {
- const response = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send({
- query: `
- mutation UpdateWorkflow($id: ID!, $name: String) {
- updateWorkflow(id: $id, data: { name: $name }) {
- id
- name
- }
+ await coreWorkflowGraphqlRequest({
+ query: `
+ mutation UpdateCoreWorkflow($input: UpdateCoreWorkflowInput!) {
+ updateCoreWorkflow(input: $input) {
+ id
}
- `,
- variables: { id: createdWorkflowId, name },
- });
-
- expect(response.body.errors).toBeUndefined();
+ }
+ `,
+ variables: { input: { coreWorkflowId, name } },
+ });
};
beforeAll(async () => {
- const createWorkflowResponse = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send({
- query: `
- mutation CreateWorkflow($name: String!) {
- createWorkflow(data: { name: $name }) {
- id
- }
- }
- `,
- variables: { name: initialWorkflowName },
- });
-
- expect(createWorkflowResponse.body.errors).toBeUndefined();
- createdWorkflowId = createWorkflowResponse.body.data.createWorkflow.id;
-
- const getWorkflowResponse = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send({
- query: `
- query GetWorkflow($id: UUID!) {
- workflow(filter: { id: { eq: $id } }) {
- id
- versions {
- edges {
- node {
- id
- }
- }
- }
- }
- }
- `,
- variables: { id: createdWorkflowId },
- });
+ const coreWorkflow = await createCoreWorkflow({
+ name: initialWorkflowName,
+ });
- createdWorkflowVersionId =
- getWorkflowResponse.body.data.workflow.versions.edges[0].node.id;
+ coreWorkflowId = coreWorkflow.coreWorkflowId;
+ coreWorkflowVersionId = coreWorkflow.coreWorkflowVersionId;
- await updateWorkflowVersionTrigger({
- workflowVersionId: createdWorkflowVersionId!,
+ await updateCoreWorkflowVersionTrigger({
+ coreWorkflowVersionId,
trigger: {
name: 'Manual Trigger',
type: 'MANUAL',
@@ -316,80 +159,27 @@ describe('workflowResolver command menu item label', () => {
},
});
- const createStepResponse = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send({
- query: `
- mutation CreateWorkflowVersionStep($input: CreateWorkflowVersionStepInput!) {
- createWorkflowVersionStep(input: $input) {
- stepsDiff
- }
- }
- `,
- variables: {
- input: {
- workflowVersionId: createdWorkflowVersionId,
- stepType: 'FIND_RECORDS',
- parentStepId: 'trigger',
- position: { x: 200, y: 0 },
- },
- },
- });
-
- expect(createStepResponse.body.errors).toBeUndefined();
-
- const activateResponse = await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send({
- query: `
- mutation ActivateWorkflowVersion($workflowVersionId: UUID!) {
- activateWorkflowVersion(workflowVersionId: $workflowVersionId)
- }
- `,
- variables: { workflowVersionId: createdWorkflowVersionId },
- });
+ await createCoreWorkflowVersionStep({
+ coreWorkflowVersionId,
+ stepType: 'FIND_RECORDS',
+ });
- expect(activateResponse.body.errors).toBeUndefined();
- expect(activateResponse.body.data.activateWorkflowVersion).toBe(true);
+ await activateCoreWorkflowVersion({ coreWorkflowVersionId });
});
afterAll(async () => {
- if (createdWorkflowVersionId) {
- await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send({
- query: `
- mutation DeactivateWorkflowVersion($workflowVersionId: UUID!) {
- deactivateWorkflowVersion(workflowVersionId: $workflowVersionId)
- }
- `,
- variables: { workflowVersionId: createdWorkflowVersionId },
- });
+ if (coreWorkflowVersionId) {
+ await deactivateCoreWorkflowVersion({ coreWorkflowVersionId });
}
- if (createdWorkflowId) {
- await client
- .post('/graphql')
- .set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
- .send({
- query: `
- mutation DestroyWorkflow($id: ID!) {
- destroyWorkflow(id: $id) {
- id
- }
- }
- `,
- variables: { id: createdWorkflowId },
- });
+ if (coreWorkflowId) {
+ await deleteCoreWorkflows({ coreWorkflowIds: [coreWorkflowId] });
}
});
it('labels the command menu item with the workflow name on activation', async () => {
const commandMenuItem = await findCommandMenuItemForWorkflowVersion(
- createdWorkflowVersionId as string,
+ coreWorkflowVersionId as string,
);
expect(commandMenuItem).toBeDefined();
@@ -406,7 +196,7 @@ describe('workflowResolver command menu item label', () => {
await renameWorkflow(renamedWorkflowName);
const commandMenuItem = await findCommandMenuItemForWorkflowVersion(
- createdWorkflowVersionId as string,
+ coreWorkflowVersionId as string,
);
expect(commandMenuItem?.label).toBe(renamedWorkflowName);
@@ -417,7 +207,7 @@ describe('workflowResolver command menu item label', () => {
await renameWorkflow('');
const commandMenuItem = await findCommandMenuItemForWorkflowVersion(
- createdWorkflowVersionId as string,
+ coreWorkflowVersionId as string,
);
expect(commandMenuItem?.label).toBe('Untitled Workflow');