The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Delete side-panel and navigation tests that only exercise their mocks (#25250)
Félix Malfait8f3a491ff0b3
diff --git a/packages/twenty-front/src/modules/navigation/hooks/__tests__/useIsSettingsPage.test.tsx b/packages/twenty-front/src/modules/navigation/hooks/__tests__/useIsSettingsPage.test.tsxdeleted file mode 100644index 13efea2e57f..00000000000--- a/packages/twenty-front/src/modules/navigation/hooks/__tests__/useIsSettingsPage.test.tsx+++ /dev/null@@ -1,31 +0,0 @@-import { MemoryRouter } from 'react-router-dom';-import { renderHook } from '@testing-library/react';--import { useIsSettingsPage } from '@/navigation/hooks/useIsSettingsPage';--const getWrapper =- (initialIndex: 0 | 1) =>- ({ children }: { children: React.ReactNode }) => (- <MemoryRouter- initialEntries={['/settings/', '/tasks']}- initialIndex={initialIndex}- >- {children}- </MemoryRouter>- );--describe('useIsSettingsPage', () => {- it('should return true for pages which has /settings/ in pathname', () => {- const { result } = renderHook(() => useIsSettingsPage(), {- wrapper: getWrapper(0),- });- expect(result.current).toBe(true);- });-- it('should return false for other pages which does not have /settings/ in pathname', () => {- const { result } = renderHook(() => useIsSettingsPage(), {- wrapper: getWrapper(1),- });- expect(result.current).toBe(false);- });-});diff --git a/packages/twenty-front/src/modules/navigation/utils/__tests__/indexAppPath.test.ts b/packages/twenty-front/src/modules/navigation/utils/__tests__/indexAppPath.test.tsdeleted file mode 100644index a71170a8825..00000000000--- a/packages/twenty-front/src/modules/navigation/utils/__tests__/indexAppPath.test.ts+++ /dev/null@@ -1,9 +0,0 @@-import { AppPath } from 'twenty-shared/types';-import indexAppPath from '@/navigation/utils/indexAppPath';--describe('getIndexAppPath', () => {- it('returns the index app path', () => {- const { getIndexAppPath } = indexAppPath;- expect(getIndexAppPath()).toEqual(AppPath.Index);- });-});diff --git a/packages/twenty-front/src/modules/side-panel/components/__tests__/PurposeBuiltSidePanelPageState.test.tsx b/packages/twenty-front/src/modules/side-panel/components/__tests__/PurposeBuiltSidePanelPageState.test.tsxdeleted file mode 100644index b7b9aadc470..00000000000--- a/packages/twenty-front/src/modules/side-panel/components/__tests__/PurposeBuiltSidePanelPageState.test.tsx+++ /dev/null@@ -1,68 +0,0 @@-import { composeEmailConnectedAccountIdComponentState } from '@/side-panel/pages/compose-email/states/composeEmailConnectedAccountIdComponentState';-import { createRelatedRecordTargetComponentState } from '@/side-panel/pages/create-related-record/states/createRelatedRecordTargetComponentState';-import { SidePanelPageComponentInstanceContext } from '@/side-panel/states/contexts/SidePanelPageComponentInstanceContext';-import { WorkspaceSurfaceContext } from '@/ui/layout/contexts/WorkspaceSurfaceContext';-import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';-import { renderHook } from '@testing-library/react';-import { createStore, Provider } from 'jotai';-import { type PropsWithChildren } from 'react';--const PAGE_ID = 'purpose-built-page-id';--describe('purpose-built side-panel page state', () => {- it('reads state seeded with the side-panel page instance ID', () => {- const store = createStore();- const targetRecord = {- id: 'record-id',- targetObjectNameSingular: 'company',- };-- store.set(- composeEmailConnectedAccountIdComponentState.atomFamily({- instanceId: PAGE_ID,- }),- 'connected-account-id',- );- store.set(- createRelatedRecordTargetComponentState.atomFamily({- instanceId: PAGE_ID,- }),- targetRecord,- );-- const wrapper = ({ children }: PropsWithChildren) => (- <Provider store={store}>- <SidePanelPageComponentInstanceContext.Provider- value={{ instanceId: PAGE_ID }}- >- <WorkspaceSurfaceContext.Provider- value={{- type: 'side-panel',- instanceId: PAGE_ID,- ownsRouteLocation: false,- }}- >- {children}- </WorkspaceSurfaceContext.Provider>- </SidePanelPageComponentInstanceContext.Provider>- </Provider>- );-- const { result } = renderHook(- () => ({- connectedAccountId: useAtomComponentStateValue(- composeEmailConnectedAccountIdComponentState,- ),- targetRecord: useAtomComponentStateValue(- createRelatedRecordTargetComponentState,- ),- }),- { wrapper },- );-- expect(result.current).toEqual({- connectedAccountId: 'connected-account-id',- targetRecord,- });- });-});diff --git a/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useOpenCalendarEventInSidePanel.test.tsx b/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useOpenCalendarEventInSidePanel.test.tsxdeleted file mode 100644index 350a10d752a..00000000000--- a/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useOpenCalendarEventInSidePanel.test.tsx+++ /dev/null@@ -1,104 +0,0 @@-import { renderHook } from '@testing-library/react';-import { act } from 'react';--import { ContextStoreViewType } from '@/context-store/types/ContextStoreViewType';-import { SIDE_PANEL_COMPONENT_INSTANCE_ID } from '@/side-panel/constants/SidePanelComponentInstanceId';-import { useOpenCalendarEventInSidePanel } from '@/side-panel/hooks/useOpenCalendarEventInSidePanel';-import {- AppPath,- CoreObjectNameSingular,- SidePanelPages,-} from 'twenty-shared/types';-import { getAppPath } from 'twenty-shared/utils';-import { getJestMetadataAndApolloMocksAndCommandMenuWrapper } from '~/testing/jest/getJestMetadataAndApolloMocksAndCommandMenuWrapper';-import { getTestEnrichedObjectMetadataItemsMock } from '~/testing/utils/getTestEnrichedObjectMetadataItemsMock';--jest.mock('uuid', () => ({- ...jest.requireActual('uuid'),- v4: jest.fn().mockReturnValue('mocked-uuid'),-}));--const mockNavigateSidePanel = jest.fn();-jest.mock('@/side-panel/hooks/useNavigateSidePanel', () => ({- useNavigateSidePanel: () => ({- navigateSidePanel: mockNavigateSidePanel,- }),-}));--jest.mock('@/app/routing/utils/isWorkspaceLocationAvailableOnSurface', () => ({- isWorkspaceLocationAvailableOnSurface: () => true,-}));--const mockOpenNewRecordTitleCell = jest.fn();-jest.mock(- '@/object-record/record-title-cell/hooks/useOpenNewRecordTitleCell',- () => ({- useOpenNewRecordTitleCell: () => ({- openNewRecordTitleCell: mockOpenNewRecordTitleCell,- }),- }),-);--const mockNavigateApp = jest.fn();-jest.mock('~/hooks/useNavigateApp', () => ({- useNavigateApp: () => mockNavigateApp,-}));--const calendarEventMockObjectMetadataItem =- getTestEnrichedObjectMetadataItemsMock().find(- (item) => item.nameSingular === CoreObjectNameSingular.CalendarEvent,- )!;--const wrapper = getJestMetadataAndApolloMocksAndCommandMenuWrapper({- apolloMocks: [],- componentInstanceId: SIDE_PANEL_COMPONENT_INSTANCE_ID,- contextStoreCurrentObjectMetadataNameSingular:- calendarEventMockObjectMetadataItem.nameSingular,- contextStoreCurrentViewId: 'my-view-id',- contextStoreTargetedRecordsRule: {- mode: 'selection',- selectedRecordIds: [],- },- contextStoreNumberOfSelectedRecords: 0,- contextStoreCurrentViewType: ContextStoreViewType.Table,-});--const renderHooks = () => {- const { result } = renderHook(() => useOpenCalendarEventInSidePanel(), {- wrapper,- });- return { result };-};--describe('useOpenCalendarEventInSidePanel', () => {- beforeEach(() => {- jest.clearAllMocks();- });-- it('should open the calendar event as a hosted record page', () => {- const { result } = renderHooks();-- const calendarEventId = 'calendar-event-123';-- act(() => {- result.current.openCalendarEventInSidePanel(calendarEventId);- });-- const recordPath = getAppPath(AppPath.RecordShowPage, {- objectNameSingular: CoreObjectNameSingular.CalendarEvent,- objectRecordId: calendarEventId,- });-- expect(mockNavigateSidePanel).toHaveBeenCalledWith(- expect.objectContaining({- page: SidePanelPages.RoutedPage,- pageTitle: recordPath,- pageId: 'mocked-uuid',- routedLocation: expect.objectContaining({- pathname: recordPath,- state: null,- }),- }),- );- });-});diff --git a/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useOpenUpdateMultipleRecordsPageInSidePanel.test.tsx b/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useOpenUpdateMultipleRecordsPageInSidePanel.test.tsxdeleted file mode 100644index 057d948249a..00000000000--- a/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useOpenUpdateMultipleRecordsPageInSidePanel.test.tsx+++ /dev/null@@ -1,5 +0,0 @@-describe('useOpenUpdateMultipleRecordsPageInSidePanel', () => {- it('should work', () => {- expect(true).toBe(true);- });-});diff --git a/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useSidePanelUpdateNavigationMorphItemsByPage.test.tsx b/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useSidePanelUpdateNavigationMorphItemsByPage.test.tsxdeleted file mode 100644index febb2bc3a8d..00000000000--- a/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useSidePanelUpdateNavigationMorphItemsByPage.test.tsx+++ /dev/null@@ -1,98 +0,0 @@-import { useSidePanelUpdateNavigationMorphItemsByPage } from '@/side-panel/hooks/useSidePanelUpdateNavigationMorphItemsByPage';-import { sidePanelNavigationMorphItemsByPageState } from '@/side-panel/states/sidePanelNavigationMorphItemsByPageState';-import { jotaiStore } from '@/ui/utilities/state/jotai/jotaiStore';-import { renderHook } from '@testing-library/react';-import { Provider as JotaiProvider } from 'jotai';-import { act } from 'react';-const pageId = 'merge-page-id';-const objectMetadataId = 'company-metadata-id';--const Wrapper = ({ children }: { children: React.ReactNode }) => (- <JotaiProvider store={jotaiStore}>{children}</JotaiProvider>-);--const renderHooks = (initialRecordIds: string[]) => {- jotaiStore.set(- sidePanelNavigationMorphItemsByPageState.atom,- new Map([- [- pageId,- initialRecordIds.map((recordId) => ({- objectMetadataId,- recordId,- })),- ],- ]),- );-- return renderHook(- () => {- const { updateSidePanelNavigationMorphItemsByPage } =- useSidePanelUpdateNavigationMorphItemsByPage();-- return {- updateSidePanelNavigationMorphItemsByPage,- };- },- {- wrapper: Wrapper,- },- );-};--describe('useSidePanelUpdateNavigationMorphItemsByPage', () => {- it('should replace existing items for a page instead of appending', async () => {- const { result } = renderHooks(['record-1', 'record-2']);-- await act(async () => {- await result.current.updateSidePanelNavigationMorphItemsByPage({- pageId,- objectMetadataId,- objectRecordIds: ['record-2', 'record-1'],- });- });-- expect(- jotaiStore.get(sidePanelNavigationMorphItemsByPageState.atom).get(pageId),- ).toEqual([- {- objectMetadataId,- recordId: 'record-2',- },- {- objectMetadataId,- recordId: 'record-1',- },- ]);- });-- it('should keep only the latest payload when called twice for the same page', async () => {- const { result } = renderHooks([]);-- await act(async () => {- await result.current.updateSidePanelNavigationMorphItemsByPage({- pageId,- objectMetadataId,- objectRecordIds: ['record-1', 'record-2'],- });- await result.current.updateSidePanelNavigationMorphItemsByPage({- pageId,- objectMetadataId,- objectRecordIds: ['record-2', 'record-1'],- });- });-- expect(- jotaiStore.get(sidePanelNavigationMorphItemsByPageState.atom).get(pageId),- ).toEqual([- {- objectMetadataId,- recordId: 'record-2',- },- {- objectMetadataId,- recordId: 'record-1',- },- ]);- });-});diff --git a/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useUpdateSidePanelPageInfo.test.tsx b/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useUpdateSidePanelPageInfo.test.tsxdeleted file mode 100644index 4784a9a85eb..00000000000--- a/packages/twenty-front/src/modules/side-panel/hooks/__tests__/useUpdateSidePanelPageInfo.test.tsx+++ /dev/null@@ -1,114 +0,0 @@-import { useUpdateSidePanelPageInfo } from '@/side-panel/hooks/useUpdateSidePanelPageInfo';-import {- type SidePanelNavigationStackItem,- sidePanelNavigationStackState,-} from '@/side-panel/states/sidePanelNavigationStackState';-import { jotaiStore } from '@/ui/utilities/state/jotai/jotaiStore';-import { renderHook } from '@testing-library/react';-import { Provider as JotaiProvider } from 'jotai';-import { act } from 'react';-import { SidePanelPages } from 'twenty-shared/types';-import { IconArrowDown, IconDotsVertical } from 'twenty-ui/icon';--const mockedNavigationStack: SidePanelNavigationStackItem[] = [- {- page: SidePanelPages.CommandMenuDisplay,- pageTitle: 'Initial Title',- pageIcon: IconDotsVertical,- pageId: 'test-page-id',- },-];--const Wrapper = ({ children }: { children: React.ReactNode }) => (- <JotaiProvider store={jotaiStore}>{children}</JotaiProvider>-);--describe('useUpdateSidePanelPageInfo', () => {- beforeEach(() => {- jotaiStore.set(sidePanelNavigationStackState.atom, mockedNavigationStack);- });-- const renderHooks = () => {- const { result } = renderHook(- () => {- const { updateSidePanelPageInfo } = useUpdateSidePanelPageInfo();-- return {- updateSidePanelPageInfo,- };- },- { wrapper: Wrapper },- );-- return {- result,- };- };-- it('should update command menu page info with new title and icon', () => {- const { result } = renderHooks();-- act(() => {- result.current.updateSidePanelPageInfo({- pageTitle: 'New Title',- pageIcon: IconArrowDown,- });- });-- const sidePanelNavigationStack = jotaiStore.get(- sidePanelNavigationStackState.atom,- );- expect(sidePanelNavigationStack).toEqual([- {- page: SidePanelPages.CommandMenuDisplay,- pageTitle: 'New Title',- pageIcon: IconArrowDown,- pageId: 'test-page-id',- },- ]);- });-- it('should update command menu page info with new title', () => {- const { result } = renderHooks();-- act(() => {- result.current.updateSidePanelPageInfo({- pageTitle: 'New Title',- });- });-- const sidePanelNavigationStack = jotaiStore.get(- sidePanelNavigationStackState.atom,- );- expect(sidePanelNavigationStack).toEqual([- {- page: SidePanelPages.CommandMenuDisplay,- pageTitle: 'New Title',- pageIcon: IconDotsVertical,- pageId: 'test-page-id',- },- ]);- });-- it('should update command menu page info with new icon', () => {- const { result } = renderHooks();-- act(() => {- result.current.updateSidePanelPageInfo({- pageIcon: IconArrowDown,- });- });-- const sidePanelNavigationStack = jotaiStore.get(- sidePanelNavigationStackState.atom,- );- expect(sidePanelNavigationStack).toEqual([- {- page: SidePanelPages.CommandMenuDisplay,- pageTitle: 'Initial Title',- pageIcon: IconArrowDown,- pageId: 'test-page-id',- },- ]);- });-});diff --git a/packages/twenty-front/src/pages/object-record/__tests__/RecordShowPageHeader.surface.test.tsx b/packages/twenty-front/src/pages/object-record/__tests__/RecordShowPageHeader.surface.test.tsxdeleted file mode 100644index f8929b0103c..00000000000--- a/packages/twenty-front/src/pages/object-record/__tests__/RecordShowPageHeader.surface.test.tsx+++ /dev/null@@ -1,112 +0,0 @@-import { WorkspaceSurfaceContext } from '@/ui/layout/contexts/WorkspaceSurfaceContext';-import { RecordShowPageHeader } from '~/pages/object-record/RecordShowPageHeader';-import { render, screen } from '@testing-library/react';--jest.mock('@/object-metadata/utils/getObjectMetadataIdentifierFields', () => ({- getObjectMetadataIdentifierFields: () => ({- labelIdentifierFieldMetadataItem: { id: 'label-field' },- }),-}));--jest.mock(- '@/object-record/record-show/hooks/useRecordShowPagePagination',- () => ({- useRecordShowPagePagination: () => ({- objectMetadataItem: { labelPlural: 'People' },- }),- }),-);--jest.mock(- '@/object-record/record-show/components/ObjectRecordShowPageBreadcrumb',- () => ({- ObjectRecordShowPageBreadcrumb: () => (- <div data-testid="main-record-breadcrumb" />- ),- }),-);--jest.mock(- '@/object-record/record-show/components/RecordIdentifierBarTitle',- () => ({- RecordIdentifierBarTitle: ({- recordLinkSurface,- }: {- recordLinkSurface?: 'main';- }) => (- <div- data-testid="panel-record-title"- data-record-link-surface={recordLinkSurface}- />- ),- }),-);--jest.mock(- '@/object-record/record-show/components/RecordIdentifierBarCreatedAt',- () => ({- RecordIdentifierBarCreatedAt: () => (- <div data-testid="panel-record-created-at" />- ),- }),-);--jest.mock('@/ui/layout/page/components/PageCardHeader', () => ({- PageCardHeader: ({- actionButton,- breadcrumb,- title,- }: {- actionButton?: React.ReactNode;- breadcrumb?: React.ReactNode;- title?: React.ReactNode;- }) => (- <div>- {breadcrumb}- {title}- {actionButton}- </div>- ),-}));--describe('RecordShowPageHeader workspace surface composition', () => {- const header = (- <RecordShowPageHeader objectNameSingular="person" objectRecordId="record-1">- <div data-testid="main-record-actions" />- </RecordShowPageHeader>- );-- it('keeps the canonical breadcrumb and actions on the main surface', () => {- render(header);-- expect(screen.getByTestId('main-record-breadcrumb')).toBeInTheDocument();- expect(screen.getByTestId('main-record-actions')).toBeInTheDocument();- expect(screen.queryByTestId('panel-record-title')).not.toBeInTheDocument();- });-- it('uses concise record identity chrome on the panel surface', () => {- render(- <WorkspaceSurfaceContext.Provider- value={{- type: 'side-panel',- instanceId: 'side-panel-page-1',- ownsRouteLocation: true,- }}- >- {header}- </WorkspaceSurfaceContext.Provider>,- );-- expect(screen.getByTestId('panel-record-title')).toHaveAttribute(- 'data-record-link-surface',- 'main',- );- expect(- screen.queryByTestId('panel-record-created-at'),- ).not.toBeInTheDocument();- expect(- screen.queryByTestId('main-record-breadcrumb'),- ).not.toBeInTheDocument();- expect(screen.queryByTestId('main-record-actions')).not.toBeInTheDocument();- });-});