Skip to content

The open alternative to Salesforce, designed for AI.

Fix permissions issue with search any field (#26339)

BOHEUS9a0ff987fb0a
diff --git a/packages/twenty-front/src/modules/context-store/utils/__tests__/computeContextStoreFilters.test.ts b/packages/twenty-front/src/modules/context-store/utils/__tests__/computeContextStoreFilters.test.ts
index 38cf7b059ba..18053c3d313 100644
--- a/packages/twenty-front/src/modules/context-store/utils/__tests__/computeContextStoreFilters.test.ts
+++ b/packages/twenty-front/src/modules/context-store/utils/__tests__/computeContextStoreFilters.test.ts
@@ -81,6 +81,39 @@ describe('computeContextStoreFilters', () => {
});
});
+ it('should exclude non-readable fields from the any-field search filter', () => {
+ const contextStoreTargetedRecordsRule: ContextStoreTargetedRecordsRule = {
+ mode: 'exclusion',
+ excludedRecordIds: [],
+ };
+
+ const linkedinLinkField = personObjectMetadataItem.fields.find(
+ (field) => field.name === 'linkedinLink',
+ )!;
+
+ const personObjectMetadataItemWithRestrictedLinkedinLink = {
+ ...personObjectMetadataItem,
+ readableFields: personObjectMetadataItem.readableFields.filter(
+ (field) => field.id !== linkedinLinkField.id,
+ ),
+ };
+
+ const filters = computeContextStoreFilters({
+ contextStoreTargetedRecordsRule,
+ contextStoreFilters: [],
+ contextStoreFilterGroups: [],
+ objectMetadataItem: personObjectMetadataItemWithRestrictedLinkedinLink,
+ fieldMetadataItems: personObjectMetadataItem.fields,
+ filterValueDependencies: mockFilterValueDependencies,
+ contextStoreAnyFieldFilterValue: 'Airtable',
+ });
+
+ const serializedFilters = JSON.stringify(filters);
+
+ expect(serializedFilters).not.toContain('linkedinLink');
+ expect(serializedFilters).toContain('name');
+ });
+
it('should work for exclusion mode', () => {
const contextStoreTargetedRecordsRule: ContextStoreTargetedRecordsRule = {
mode: 'exclusion',
diff --git a/packages/twenty-front/src/modules/context-store/utils/computeContextStoreFilters.ts b/packages/twenty-front/src/modules/context-store/utils/computeContextStoreFilters.ts
index ab6212c092a..c1c688102d4 100644
--- a/packages/twenty-front/src/modules/context-store/utils/computeContextStoreFilters.ts
+++ b/packages/twenty-front/src/modules/context-store/utils/computeContextStoreFilters.ts
@@ -37,7 +37,7 @@ export const computeContextStoreFilters = ({
const { recordGqlOperationFilter: recordGqlFilterForAnyFieldFilter } =
turnAnyFieldFilterIntoRecordGqlFilter({
filterValue: contextStoreAnyFieldFilterValue,
- fields: objectMetadataItem.fields,
+ fields: objectMetadataItem.readableFields,
});
if (contextStoreTargetedRecordsRule.mode === 'exclusion') {
diff --git a/packages/twenty-front/src/modules/object-record/record-calendar/hooks/useRecordCalendarQueryDateRangeFilter.tsx b/packages/twenty-front/src/modules/object-record/record-calendar/hooks/useRecordCalendarQueryDateRangeFilter.tsx
index 78fb7e5acf2..fb72021d757 100644
--- a/packages/twenty-front/src/modules/object-record/record-calendar/hooks/useRecordCalendarQueryDateRangeFilter.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-calendar/hooks/useRecordCalendarQueryDateRangeFilter.tsx
@@ -86,7 +86,7 @@ export const useRecordCalendarQueryDateRangeFilter = (
});
const { recordGqlOperationFilter: anyFieldFilter } =
turnAnyFieldFilterIntoRecordGqlFilter({
- fields: objectMetadataItem.fields,
+ fields: objectMetadataItem.readableFields,
filterValue: anyFieldFilterValue,
});
diff --git a/packages/twenty-front/src/modules/object-record/record-index/hooks/useFindManyRecordIndexTableParams.ts b/packages/twenty-front/src/modules/object-record/record-index/hooks/useFindManyRecordIndexTableParams.ts
index 853f2dc3c7f..b53e693e4f7 100644
--- a/packages/twenty-front/src/modules/object-record/record-index/hooks/useFindManyRecordIndexTableParams.ts
+++ b/packages/twenty-front/src/modules/object-record/record-index/hooks/useFindManyRecordIndexTableParams.ts
@@ -67,7 +67,7 @@ export const useFindManyRecordIndexTableParams = (
const { recordGqlOperationFilter: anyFieldFilter } =
turnAnyFieldFilterIntoRecordGqlFilter({
- fields: objectMetadataItem?.fields ?? [],
+ fields: objectMetadataItem?.readableFields ?? [],
filterValue: anyFieldFilterValue,
});
diff --git a/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordIndexGroupCommonQueryVariables.ts b/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordIndexGroupCommonQueryVariables.ts
index 2502ae769f7..3c093c6e3c3 100644
--- a/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordIndexGroupCommonQueryVariables.ts
+++ b/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordIndexGroupCommonQueryVariables.ts
@@ -55,7 +55,7 @@ export const useRecordIndexGroupCommonQueryVariables = () => {
const { recordGqlOperationFilter: anyFieldFilter } =
turnAnyFieldFilterIntoRecordGqlFilter({
- fields: objectMetadataItem.fields,
+ fields: objectMetadataItem.readableFields,
filterValue: anyFieldFilterValue,
});
diff --git a/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordIndexGroupsAggregatesGroupBy.ts b/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordIndexGroupsAggregatesGroupBy.ts
index 931b6b874e6..361b3b998c3 100644
--- a/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordIndexGroupsAggregatesGroupBy.ts
+++ b/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordIndexGroupsAggregatesGroupBy.ts
@@ -88,7 +88,7 @@ export const useRecordIndexGroupsAggregatesGroupBy = ({
const { recordGqlOperationFilter: anyFieldFilter } =
turnAnyFieldFilterIntoRecordGqlFilter({
- fields: objectMetadataItem.fields,
+ fields: objectMetadataItem.readableFields,
filterValue: anyFieldFilterValue,
});
diff --git a/packages/twenty-front/src/modules/object-record/record-table/record-table-footer/hooks/useAggregateRecordsForRecordTableColumnFooter.tsx b/packages/twenty-front/src/modules/object-record/record-table/record-table-footer/hooks/useAggregateRecordsForRecordTableColumnFooter.tsx
index 73c9385fa06..b02cb833af1 100644
--- a/packages/twenty-front/src/modules/object-record/record-table/record-table-footer/hooks/useAggregateRecordsForRecordTableColumnFooter.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-table/record-table-footer/hooks/useAggregateRecordsForRecordTableColumnFooter.tsx
@@ -110,7 +110,7 @@ export const useAggregateRecordsForRecordTableColumnFooter = (
const { recordGqlOperationFilter: anyFieldFilter } =
turnAnyFieldFilterIntoRecordGqlFilter({
- fields: objectMetadataItem.fields,
+ fields: objectMetadataItem.readableFields,
filterValue: anyFieldFilterValue,
});
diff --git a/packages/twenty-front/src/modules/views/hooks/internal/useGetRecordIndexTotalCount.ts b/packages/twenty-front/src/modules/views/hooks/internal/useGetRecordIndexTotalCount.ts
index 8767949c590..b80397f8dc8 100644
--- a/packages/twenty-front/src/modules/views/hooks/internal/useGetRecordIndexTotalCount.ts
+++ b/packages/twenty-front/src/modules/views/hooks/internal/useGetRecordIndexTotalCount.ts
@@ -52,7 +52,7 @@ export const useGetRecordIndexTotalCount = () => {
const { recordGqlOperationFilter: anyFieldFilter } =
turnAnyFieldFilterIntoRecordGqlFilter({
- fields: objectMetadataItem.fields,
+ fields: objectMetadataItem.readableFields,
filterValue: anyFieldFilterValue,
});