Skip to content

The open alternative to Salesforce, designed for AI.

fix(uploads): cap file size for files-field and application file upload mutations (#25671)

Aditya Mishra9cc50b98cd8b
diff --git a/packages/twenty-server/src/engine/constants/settings/index.ts b/packages/twenty-server/src/engine/constants/settings/index.ts
index 04183256e05..7fa1bf067b6 100644
--- a/packages/twenty-server/src/engine/constants/settings/index.ts
+++ b/packages/twenty-server/src/engine/constants/settings/index.ts
@@ -2,7 +2,7 @@ import { type Settings } from './interfaces/settings.interface';
export const settings: Settings = {
storage: {
- maxFileSize: '10MB',
+ maxFileSize: '100MB',
// Direct uploads (createFileUpload/completeFileUpload) stream to storage
// without transiting the server memory, so they get a much higher cap
// than multipart uploads.
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-development/application-development.resolver.ts b/packages/twenty-server/src/engine/core-modules/application/application-development/application-development.resolver.ts
index e125e846665..2ce3b0a5946 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-development/application-development.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-development/application-development.resolver.ts
@@ -6,12 +6,14 @@ import {
} from '@nestjs/common';
import { Args, Mutation, Query } from '@nestjs/graphql';
+import bytes from 'bytes';
import GraphQLUpload from 'graphql-upload/GraphQLUpload.mjs';
import { PermissionFlagType } from 'twenty-shared/constants';
import type { FileUpload } from 'graphql-upload/processRequest.mjs';
import { MetadataResolver } from 'src/engine/api/graphql/graphql-config/decorators/metadata-resolver.decorator';
+import { settings } from 'src/engine/constants/settings';
import { ApplicationDevelopmentService } from 'src/engine/core-modules/application/application-development/application-development.service';
import { ApplicationFileUploadService } from 'src/engine/core-modules/application/application-development/application-file-upload.service';
import { ApplicationExportDTO } from 'src/engine/core-modules/application/application-development/dtos/application-export.dto';
@@ -104,7 +106,11 @@ export class ApplicationDevelopmentResolver {
applicationUniversalIdentifier,
fileFolder,
filePath,
- getFileBuffer: () => streamToBuffer(createReadStream()),
+ getFileBuffer: () =>
+ streamToBuffer(
+ createReadStream(),
+ bytes(settings.storage.maxFileSize) ?? undefined,
+ ),
});
}
diff --git a/packages/twenty-server/src/engine/core-modules/file/files-field/resolvers/files-field.resolver.ts b/packages/twenty-server/src/engine/core-modules/file/files-field/resolvers/files-field.resolver.ts
index b84fe779d22..1826d2bca24 100644
--- a/packages/twenty-server/src/engine/core-modules/file/files-field/resolvers/files-field.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/file/files-field/resolvers/files-field.resolver.ts
@@ -1,12 +1,14 @@
import { UseFilters, UseGuards, UsePipes } from '@nestjs/common';
import { Args, Mutation } from '@nestjs/graphql';
+import bytes from 'bytes';
import GraphQLUpload from 'graphql-upload/GraphQLUpload.mjs';
import { PermissionFlagType } from 'twenty-shared/constants';
import type { FileUpload } from 'graphql-upload/processRequest.mjs';
import { MetadataResolver } from 'src/engine/api/graphql/graphql-config/decorators/metadata-resolver.decorator';
+import { settings } from 'src/engine/constants/settings';
import { FileWithSignedUrlDTO } from 'src/engine/core-modules/file/dtos/file-with-sign-url.dto';
import { FilesFieldService } from 'src/engine/core-modules/file/files-field/services/files-field.service';
import { PreventNestToAutoLogGraphqlErrorsFilter } from 'src/engine/core-modules/graphql/filters/prevent-nest-to-auto-log-graphql-errors.filter';
@@ -39,7 +41,10 @@ export class FilesFieldResolver {
fieldMetadataUniversalIdentifier: string,
): Promise<FileWithSignedUrlDTO> {
const stream = createReadStream();
- const buffer = await streamToBuffer(stream);
+ const buffer = await streamToBuffer(
+ stream,
+ bytes(settings.storage.maxFileSize) ?? undefined,
+ );
return await this.filesFieldService.uploadFile({
file: buffer,
diff --git a/packages/twenty-server/src/main.ts b/packages/twenty-server/src/main.ts
index 00b79dd7496..270b92b1839 100644
--- a/packages/twenty-server/src/main.ts
+++ b/packages/twenty-server/src/main.ts
@@ -88,6 +88,7 @@ const bootstrap = async () => {
`/${ApiPath.GraphQL}`,
graphqlUploadExpress({
maxFieldSize: bytes(settings.storage.maxFileSize)!,
+ maxFileSize: bytes(settings.storage.maxFileSize)!,
maxFiles: 10,
}),
);
@@ -96,6 +97,7 @@ const bootstrap = async () => {
`/${ApiPath.Metadata}`,
graphqlUploadExpress({
maxFieldSize: bytes(settings.storage.maxFileSize)!,
+ maxFileSize: bytes(settings.storage.maxFileSize)!,
maxFiles: 10,
}),
);