Skip to content

The open alternative to Salesforce, designed for AI.

chore: remove low-value short comments (#24117)

Charles Bochet9ce995114551
diff --git a/packages/twenty-emails/src/utils/email-renderer/renderers/render-mark.tsx b/packages/twenty-emails/src/utils/email-renderer/renderers/render-mark.tsx
index 0892a12e26c..97e6d4d2e82 100644
--- a/packages/twenty-emails/src/utils/email-renderer/renderers/render-mark.tsx
+++ b/packages/twenty-emails/src/utils/email-renderer/renderers/render-mark.tsx
@@ -36,7 +36,6 @@ export const renderMark = (node: JSONContent): ReactNode => {
);
});
- // Apply marks from innermost to outermost
return marks.reduce((children: ReactNode, mark: TipTapMark) => {
if (!isEmailDocumentMarkType(mark.type)) {
// Fallback for unknown mark types - skip unknown marks
diff --git a/packages/twenty-front/.storybook/main.ts b/packages/twenty-front/.storybook/main.ts
index 2a721307df9..de451ed57c4 100644
--- a/packages/twenty-front/.storybook/main.ts
+++ b/packages/twenty-front/.storybook/main.ts
@@ -45,7 +45,6 @@ const config: StorybookConfig = {
'@storybook/addon-links',
'@storybook/addon-coverage',
'storybook-addon-pseudo-states',
- // 'storybook-dark-mode',
'storybook-addon-mock-date',
'@storybook/addon-vitest',
],
diff --git a/packages/twenty-front/.storybook/preview.tsx b/packages/twenty-front/.storybook/preview.tsx
index 1d2b2de6f7e..6410bc1dec6 100644
--- a/packages/twenty-front/.storybook/preview.tsx
+++ b/packages/twenty-front/.storybook/preview.tsx
@@ -37,7 +37,6 @@ import { ThemeProvider } from 'twenty-ui/theme-constants';
// oxlint-disable-next-line no-restricted-imports
import { messages as enMessages } from '../src/locales/generated/en';
-// Initialize i18n globally for all stories
i18n.load({ [SOURCE_LOCALE]: enMessages });
i18n.activate(SOURCE_LOCALE);
import { mockedUserJWT } from '~/testing/mock-data/jwt';
diff --git a/packages/twenty-front/setupTests.ts b/packages/twenty-front/setupTests.ts
index 05d26d92257..9b557c44059 100644
--- a/packages/twenty-front/setupTests.ts
+++ b/packages/twenty-front/setupTests.ts
@@ -13,7 +13,6 @@ import { i18n } from '@lingui/core';
import { SOURCE_LOCALE } from 'twenty-shared/translations';
import { messages as enMessages } from '~/locales/generated/en';
-// Initialize i18n for all tests
i18n.load({ [SOURCE_LOCALE]: enMessages });
i18n.activate(SOURCE_LOCALE);
diff --git a/packages/twenty-front/src/loading/components/__stories__/UserOrMetadataLoader.stories.tsx b/packages/twenty-front/src/loading/components/__stories__/UserOrMetadataLoader.stories.tsx
index 3995ddd6887..bfb7d477bf6 100644
--- a/packages/twenty-front/src/loading/components/__stories__/UserOrMetadataLoader.stories.tsx
+++ b/packages/twenty-front/src/loading/components/__stories__/UserOrMetadataLoader.stories.tsx
@@ -47,7 +47,6 @@ const userMetadataLoaderMocks = {
return HttpResponse.json({
data: {
objects: {
- // simulate no metadata items
edges: [],
},
},
diff --git a/packages/twenty-front/src/modules/activities/emails/hooks/__tests__/useResolveDefaultEmailRecipient.test.ts b/packages/twenty-front/src/modules/activities/emails/hooks/__tests__/useResolveDefaultEmailRecipient.test.ts
index c5f97e1acbf..a2d924a5925 100644
--- a/packages/twenty-front/src/modules/activities/emails/hooks/__tests__/useResolveDefaultEmailRecipient.test.ts
+++ b/packages/twenty-front/src/modules/activities/emails/hooks/__tests__/useResolveDefaultEmailRecipient.test.ts
@@ -149,7 +149,6 @@ describe('useResolveDefaultEmailRecipient', () => {
}),
);
- // Person query should NOT be skipped
const personCall = mockUseFindOneRecord.mock.calls.find(
(call: { objectNameSingular: string }[]) =>
call[0].objectNameSingular === CoreObjectNameSingular.Person,
@@ -157,7 +156,6 @@ describe('useResolveDefaultEmailRecipient', () => {
expect(personCall?.[0].skip).toBe(false);
- // Opportunity query SHOULD be skipped
const oppCall = mockUseFindOneRecord.mock.calls.find(
(call: { objectNameSingular: string }[]) =>
call[0].objectNameSingular === CoreObjectNameSingular.Opportunity,
@@ -165,7 +163,6 @@ describe('useResolveDefaultEmailRecipient', () => {
expect(oppCall?.[0].skip).toBe(true);
- // Company people query SHOULD be skipped
expect(mockUseFindManyRecords.mock.calls[0][0].skip).toBe(true);
});
});
diff --git a/packages/twenty-front/src/modules/activities/timeline-activities/hooks/useTimelineActivities.ts b/packages/twenty-front/src/modules/activities/timeline-activities/hooks/useTimelineActivities.ts
index c1c743d9748..e648f130d7d 100644
--- a/packages/twenty-front/src/modules/activities/timeline-activities/hooks/useTimelineActivities.ts
+++ b/packages/twenty-front/src/modules/activities/timeline-activities/hooks/useTimelineActivities.ts
@@ -15,7 +15,6 @@ import {
} from 'twenty-shared/types';
import { capitalize, isDefined } from 'twenty-shared/utils';
-// do we need to test this?
export const useTimelineActivities = (
targetableObject: ActivityTargetableObject,
) => {
diff --git a/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/DefaultSlashCommands.test.ts b/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/DefaultSlashCommands.test.ts
index 1b62cdf942e..5416b7a2526 100644
--- a/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/DefaultSlashCommands.test.ts
+++ b/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/DefaultSlashCommands.test.ts
@@ -12,7 +12,6 @@ describe('DefaultSlashCommands', () => {
let editor: Editor;
beforeEach(() => {
- // Initialize i18n for tests
i18n.load('en', {});
i18n.activate('en');
@@ -59,7 +58,6 @@ describe('DefaultSlashCommands', () => {
it('should have translatable message descriptors for titles', () => {
DEFAULT_SLASH_COMMANDS.forEach((command) => {
- // MessageDescriptor should have an id property
expect(command.title).toHaveProperty('id');
expect(typeof command.title.id).toBe('string');
});
@@ -109,7 +107,6 @@ describe('DefaultSlashCommands', () => {
// Paragraph command should have a getIsVisible function
expect(typeof paragraphCommand?.getIsVisible).toBe('function');
- // Result should be a boolean
expect(typeof paragraphCommand?.getIsVisible(editor)).toBe('boolean');
});
});
@@ -264,7 +261,6 @@ describe('DefaultSlashCommands', () => {
it('should have heading keywords for heading commands', () => {
const h1Command = DEFAULT_SLASH_COMMANDS.find((cmd) => cmd.id === 'h1');
- // Should have keywords array
expect(h1Command?.keywords.length).toBeGreaterThan(0);
});
diff --git a/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/SlashCommand.test.ts b/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/SlashCommand.test.ts
index d818f4dd789..28a42cae7e0 100644
--- a/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/SlashCommand.test.ts
+++ b/packages/twenty-front/src/modules/advanced-text-editor/extensions/slash-command/__tests__/SlashCommand.test.ts
@@ -12,7 +12,6 @@ describe('SlashCommand', () => {
let editor: Editor;
beforeEach(() => {
- // Initialize i18n for tests
i18n.load('en', {});
i18n.activate('en');
@@ -38,7 +37,6 @@ describe('SlashCommand', () => {
editor.commands.setContent('<p></p>');
editor.commands.focus();
- // Type the slash character
editor.commands.insertContent('/');
// The suggestion plugin should be active
@@ -50,10 +48,8 @@ describe('SlashCommand', () => {
editor.commands.setContent('<p></p>');
editor.commands.focus();
- // Type slash and partial command
editor.commands.insertContent('/head');
- // Content should include the typed text
expect(editor.getText()).toContain('head');
});
});
@@ -63,7 +59,6 @@ describe('SlashCommand', () => {
editor.commands.setContent('<p>Test</p>');
editor.commands.focus();
- // Simulate selecting heading 1 command
editor.chain().focus().setHeading({ level: 1 }).run();
expect(editor.isActive('heading', { level: 1 })).toBe(true);
diff --git a/packages/twenty-front/src/modules/ai/components/__stories__/CodeExecutionDisplay.stories.tsx b/packages/twenty-front/src/modules/ai/components/__stories__/CodeExecutionDisplay.stories.tsx
index cf83a4bd1e7..da27181a750 100644
--- a/packages/twenty-front/src/modules/ai/components/__stories__/CodeExecutionDisplay.stories.tsx
+++ b/packages/twenty-front/src/modules/ai/components/__stories__/CodeExecutionDisplay.stories.tsx
@@ -178,11 +178,9 @@ export const CodeSectionExpanded: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
- // Click to expand the code section
const codeHeader = await canvas.findByText('Code');
await userEvent.click(codeHeader);
- // The code editor should now be visible
expect(await canvas.findByText('Completed')).toBeVisible();
},
};
diff --git a/packages/twenty-front/src/modules/ai/components/__stories__/TerminalOutput.stories.tsx b/packages/twenty-front/src/modules/ai/components/__stories__/TerminalOutput.stories.tsx
index ae9eb23d4aa..61b7e0cbbd6 100644
--- a/packages/twenty-front/src/modules/ai/components/__stories__/TerminalOutput.stories.tsx
+++ b/packages/twenty-front/src/modules/ai/components/__stories__/TerminalOutput.stories.tsx
@@ -50,14 +50,11 @@ export const WithStderr: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
- // Should show stdout by default
expect(await canvas.findByText(/Starting process/)).toBeVisible();
- // Click stderr tab to switch
const stderrTab = await canvas.findByText('stderr');
await userEvent.click(stderrTab);
- // Should now show stderr content
expect(await canvas.findByText(/Connection timeout/)).toBeVisible();
},
};
diff --git a/packages/twenty-front/src/modules/apollo/hooks/useApolloFactory.ts b/packages/twenty-front/src/modules/apollo/hooks/useApolloFactory.ts
index ce4925a0d60..f6c623a33c9 100644
--- a/packages/twenty-front/src/modules/apollo/hooks/useApolloFactory.ts
+++ b/packages/twenty-front/src/modules/apollo/hooks/useApolloFactory.ts
@@ -109,7 +109,6 @@ export const useApolloFactory = (options: Partial<Options> = {}) => {
},
extraLinks: [],
isDebugMode: process.env.IS_DEBUG_MODE === 'true',
- // Override options
...options,
});
diff --git a/packages/twenty-front/src/modules/apollo/optimistic-effect/utils/triggerAttachRelationOptimisticEffect.ts b/packages/twenty-front/src/modules/apollo/optimistic-effect/utils/triggerAttachRelationOptimisticEffect.ts
index c0c0163c07c..191eb06f753 100644
--- a/packages/twenty-front/src/modules/apollo/optimistic-effect/utils/triggerAttachRelationOptimisticEffect.ts
+++ b/packages/twenty-front/src/modules/apollo/optimistic-effect/utils/triggerAttachRelationOptimisticEffect.ts
@@ -104,7 +104,6 @@ export const triggerAttachRelationOptimisticEffect = ({
edges: nextEdges,
};
} else {
- // To one object => attach next relation record
return sourceRecordReference;
}
},
diff --git a/packages/twenty-front/src/modules/apollo/utils/__tests__/hasTokenPair.test.ts b/packages/twenty-front/src/modules/apollo/utils/__tests__/hasTokenPair.test.ts
index 71b4ea98622..930e3dc10f4 100644
--- a/packages/twenty-front/src/modules/apollo/utils/__tests__/hasTokenPair.test.ts
+++ b/packages/twenty-front/src/modules/apollo/utils/__tests__/hasTokenPair.test.ts
@@ -94,7 +94,6 @@ describe('hasTokenPair', () => {
expect(mockGetTokenPair).toHaveBeenCalledTimes(1);
- // Reset and test with valid token
mockGetTokenPair.mockClear();
const validToken = {
accessOrWorkspaceAgnosticToken: {
diff --git a/packages/twenty-front/src/modules/geo-map/components/__tests__/PlaceAutocompleteSelect.test.tsx b/packages/twenty-front/src/modules/geo-map/components/__tests__/PlaceAutocompleteSelect.test.tsx
index 924cd37d821..da974946041 100644
--- a/packages/twenty-front/src/modules/geo-map/components/__tests__/PlaceAutocompleteSelect.test.tsx
+++ b/packages/twenty-front/src/modules/geo-map/components/__tests__/PlaceAutocompleteSelect.test.tsx
@@ -38,7 +38,6 @@ describe('PlaceAutocompleteSelect Component', () => {
const mockOnChange = jest.fn();
const testPlaceId = 'test-place-id';
- // Simulate calling the onChange function
mockOnChange(testPlaceId);
expect(mockOnChange).toHaveBeenCalledWith(testPlaceId);
@@ -173,7 +172,6 @@ describe('PlaceAutocompleteSelect Component', () => {
validDropdownIds.forEach((id) => {
expect(typeof id).toBe('string');
expect(id.length).toBeGreaterThan(0);
- // Should not contain spaces (valid HTML ID)
expect(id).not.toMatch(/\s/);
});
});
diff --git a/packages/twenty-front/src/modules/geo-map/graphql-query/__tests__/geo-map-appolo.api.test.ts b/packages/twenty-front/src/modules/geo-map/graphql-query/__tests__/geo-map-appolo.api.test.ts
index a3e0392e478..faf4e0e8d98 100644
--- a/packages/twenty-front/src/modules/geo-map/graphql-query/__tests__/geo-map-appolo.api.test.ts
+++ b/packages/twenty-front/src/modules/geo-map/graphql-query/__tests__/geo-map-appolo.api.test.ts
@@ -167,7 +167,6 @@ describe('geo-map GraphQL queries', () => {
describe('query validation', () => {
it('should have valid GraphQL syntax for both queries', () => {
expect(() => {
- // This will throw if the query is malformed
expect(GET_AUTOCOMPLETE_QUERY.definitions[0]).toBeDefined();
expect(GET_PLACE_DETAILS_QUERY.definitions[0]).toBeDefined();
}).not.toThrow();
@@ -177,11 +176,9 @@ describe('geo-map GraphQL queries', () => {
const autocompleteQuery = GET_AUTOCOMPLETE_QUERY.definitions[0] as any;
const detailsQuery = GET_PLACE_DETAILS_QUERY.definitions[0] as any;
- // Both should use PascalCase for query names
expect(autocompleteQuery.name.value).toMatch(/^[A-Z][a-zA-Z]*$/);
expect(detailsQuery.name.value).toMatch(/^[A-Z][a-zA-Z]*$/);
- // Both should use camelCase for field names
const autocompleteFields =
autocompleteQuery.selectionSet.selections[0].selectionSet.selections;
const detailsFields =
diff --git a/packages/twenty-front/src/modules/geo-map/types/__tests__/placeApi.test.ts b/packages/twenty-front/src/modules/geo-map/types/__tests__/placeApi.test.ts
index c3e521d21d5..16cf286fe7d 100644
--- a/packages/twenty-front/src/modules/geo-map/types/__tests__/placeApi.test.ts
+++ b/packages/twenty-front/src/modules/geo-map/types/__tests__/placeApi.test.ts
@@ -69,7 +69,6 @@ describe('placeApi types', () => {
token: 'test-token',
};
- // These should be strings
expect(typeof variables.address).toBe('string');
expect(typeof variables.token).toBe('string');
});
@@ -218,7 +217,6 @@ describe('placeApi types', () => {
describe('type compatibility', () => {
it('should work with API response patterns', () => {
- // Simulating API response structure
const apiResponse = {
getAutoCompleteAddress: [
{
diff --git a/packages/twenty-front/src/modules/layout-customization/hooks/__tests__/useIsLayoutCustomizationDirty.test.tsx b/packages/twenty-front/src/modules/layout-customization/hooks/__tests__/useIsLayoutCustomizationDirty.test.tsx
index 3e68dc38075..0a0255972bb 100644
--- a/packages/twenty-front/src/modules/layout-customization/hooks/__tests__/useIsLayoutCustomizationDirty.test.tsx
+++ b/packages/twenty-front/src/modules/layout-customization/hooks/__tests__/useIsLayoutCustomizationDirty.test.tsx
@@ -160,7 +160,6 @@ describe('useIsLayoutCustomizationDirty', () => {
status: 'up-to-date',
});
store.set(isLayoutCustomizationModeEnabledState.atom, true);
- // Nav draft differs from prefetch
store.set(navigationMenuItemsDraftState.atom, []);
const { result } = renderHook(() => useIsLayoutCustomizationDirty(), {
@@ -185,7 +184,6 @@ describe('useIsLayoutCustomizationDirty', () => {
PAGE_LAYOUT_ID_2,
]);
- // First layout is clean
store.set(
pageLayoutPersistedComponentState.atomFamily({
instanceId: PAGE_LAYOUT_ID_1,
diff --git a/packages/twenty-front/src/modules/localization/hooks/useFormatPreferences.ts b/packages/twenty-front/src/modules/localization/hooks/useFormatPreferences.ts
index dbea568c584..867491f93bf 100644
--- a/packages/twenty-front/src/modules/localization/hooks/useFormatPreferences.ts
+++ b/packages/twenty-front/src/modules/localization/hooks/useFormatPreferences.ts
@@ -44,7 +44,6 @@ export const useFormatPreferences = () => {
// Handle system values by detecting the actual format
let resolvedValue = value;
- // This is dirty and will need to be unified
if (
value === 'SYSTEM' ||
value === 'system' ||
diff --git a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts
index 9e1c158c06f..35f3a3603e1 100644
--- a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts
+++ b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectCalendarStartDay.test.ts
@@ -9,7 +9,6 @@ describe('detectCalendarStartDay', () => {
let originalIntlLocale: typeof Intl.Locale;
beforeEach(() => {
- // Reset to default
Object.defineProperty(navigator, 'language', {
writable: true,
value: 'en-US',
diff --git a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectNumberFormat.test.ts b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectNumberFormat.test.ts
index 71b864a11f4..9bd198f1cb9 100644
--- a/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectNumberFormat.test.ts
+++ b/packages/twenty-front/src/modules/localization/utils/detection/__tests__/detectNumberFormat.test.ts
@@ -7,7 +7,6 @@ Object.defineProperty(navigator, 'language', {
describe('detectNumberFormat', () => {
beforeEach(() => {
- // Reset to default
Object.defineProperty(navigator, 'language', {
writable: true,
value: 'en-US',
diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/dnd/hooks/useNavigationMenuItemDndKit.ts b/packages/twenty-front/src/modules/navigation-menu-item/display/dnd/hooks/useNavigationMenuItemDndKit.ts
index 3cdb139236c..631e0d77350 100644
--- a/packages/twenty-front/src/modules/navigation-menu-item/display/dnd/hooks/useNavigationMenuItemDndKit.ts
+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/dnd/hooks/useNavigationMenuItemDndKit.ts
@@ -203,7 +203,6 @@ export const useNavigationMenuItemDndKit = (
const sourceIsSortable = source !== null && isSortable(source);
const resolved = resolveDropTarget(target, getNavItemById, sectionType);
- // Branch 1: sortable-to-sortable
if (
resolved !== null &&
source !== null &&
@@ -234,7 +233,6 @@ export const useNavigationMenuItemDndKit = (
return;
}
- // Branch 3: add-to-nav drag over droppable
if (resolved !== null) {
setAddToNavigationFallbackDestination(resolved.destination);
setActiveDropTargetId(resolved.effectiveDropTargetId);
diff --git a/packages/twenty-front/src/modules/object-metadata/hooks/__tests__/useObjectMetadataItem.test.tsx b/packages/twenty-front/src/modules/object-metadata/hooks/__tests__/useObjectMetadataItem.test.tsx
index 4900f90501e..9410a712ad7 100644
--- a/packages/twenty-front/src/modules/object-metadata/hooks/__tests__/useObjectMetadataItem.test.tsx
+++ b/packages/twenty-front/src/modules/object-metadata/hooks/__tests__/useObjectMetadataItem.test.tsx
@@ -9,7 +9,6 @@ const Wrapper = getJestMetadataAndApolloMocksWrapper({
apolloMocks: [],
});
-// Split into tests for each new hook
describe('useObjectMetadataItem', () => {
const opportunityObjectMetadata =
getTestEnrichedObjectMetadataItemsMock().find(
diff --git a/packages/twenty-front/src/modules/object-record/hooks/__tests__/useIncrementalUpdateManyRecords.test.tsx b/packages/twenty-front/src/modules/object-record/hooks/__tests__/useIncrementalUpdateManyRecords.test.tsx
index c19a2840abd..2ae7addcd20 100644
--- a/packages/twenty-front/src/modules/object-record/hooks/__tests__/useIncrementalUpdateManyRecords.test.tsx
+++ b/packages/twenty-front/src/modules/object-record/hooks/__tests__/useIncrementalUpdateManyRecords.test.tsx
@@ -67,7 +67,6 @@ describe('useIncrementalUpdateManyRecords', () => {
it('should call incrementalFetchAndMutate and execute mutations via useUpdateManyRecords', async () => {
mockIncrementalFetchAndMutate.mockImplementation(async (callback) => {
- // Simulate one batch
await callback({
recordIds: ['1', '2'],
totalCount: 2,
diff --git a/packages/twenty-front/src/modules/object-record/record-field-list/utils/categorizeRelationFields.ts b/packages/twenty-front/src/modules/object-record/record-field-list/utils/categorizeRelationFields.ts
index fa4f17216c7..796e7387ec5 100644
--- a/packages/twenty-front/src/modules/object-record/record-field-list/utils/categorizeRelationFields.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field-list/utils/categorizeRelationFields.ts
@@ -88,7 +88,6 @@ export const categorizeRelationFields = ({
continue;
}
- // Boxed relations need read permission check
if (canReadRelationTarget(field, objectPermissionsByObjectMetadataId)) {
boxedRelationFields.push(field);
}
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormSingleRecordPicker.stories.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormSingleRecordPicker.stories.tsx
index d8cd8c8ef49..2eb6cc3fef3 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormSingleRecordPicker.stories.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/__stories__/FormSingleRecordPicker.stories.tsx
@@ -94,7 +94,6 @@ export const Disabled: Story = {
const variablePicker = canvas.queryByText('VariablePicker');
expect(variablePicker).not.toBeInTheDocument();
- // Clicking should not trigger onChange
if (isDefined(dropdown)) {
await userEvent.click(dropdown);
}
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/SelectFieldInput.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/SelectFieldInput.tsx
index 0384de6a9a7..ca75b9ae544 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/SelectFieldInput.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/SelectFieldInput.tsx
@@ -49,7 +49,6 @@ export const SelectFieldInput = () => {
const selectedOption = selectOptions.find(
(option) => option.value === fieldValue,
);
- // handlers
const handleClearField = () => {
clearField();
onCancel?.();
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/isFieldValueEmpty.test.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/isFieldValueEmpty.test.ts
index 2906582f487..26873bdecd9 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/isFieldValueEmpty.test.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/isFieldValueEmpty.test.ts
@@ -117,7 +117,6 @@ describe('isFieldValueEmpty', () => {
});
it('should return correct value for links field', () => {
- // Empty cases
expect(
isFieldValueEmpty({
fieldDefinition: linksFieldDefinition,
@@ -136,7 +135,6 @@ describe('isFieldValueEmpty', () => {
}),
).toBe(true);
- // Valid primary link only
expect(
isFieldValueEmpty({
fieldDefinition: linksFieldDefinition,
@@ -148,7 +146,6 @@ describe('isFieldValueEmpty', () => {
}),
).toBe(false);
- // Valid secondary link only
expect(
isFieldValueEmpty({
fieldDefinition: linksFieldDefinition,
@@ -162,7 +159,6 @@ describe('isFieldValueEmpty', () => {
}),
).toBe(false);
- // Invalid primary link but valid secondary link
expect(
isFieldValueEmpty({
fieldDefinition: linksFieldDefinition,
@@ -176,7 +172,6 @@ describe('isFieldValueEmpty', () => {
}),
).toBe(false);
- // Valid primary link but invalid secondary link
expect(
isFieldValueEmpty({
fieldDefinition: linksFieldDefinition,
@@ -188,7 +183,6 @@ describe('isFieldValueEmpty', () => {
}),
).toBe(false);
- // All invalid links
expect(
isFieldValueEmpty({
fieldDefinition: linksFieldDefinition,
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/getFileCategoryFromExtension.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/getFileCategoryFromExtension.ts
index 3be6c91b750..e37c450805e 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/getFileCategoryFromExtension.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/getFileCategoryFromExtension.ts
@@ -9,39 +9,32 @@ export const getFileCategoryFromExtension = (
const ext = extension.toLowerCase().replace('.', '');
- // Images
if (
['jpg', 'jpeg', 'png', 'gif', 'bmp', 'svg', 'webp', 'ico'].includes(ext)
) {
return FILE_CATEGORIES.IMAGE;
}
- // Videos
if (['mp4', 'avi', 'mov', 'wmv', 'flv', 'mkv', 'webm', 'm4v'].includes(ext)) {
return FILE_CATEGORIES.VIDEO;
}
- // Audio
if (['mp3', 'wav', 'ogg', 'flac', 'm4a', 'wma', 'aac'].includes(ext)) {
return FILE_CATEGORIES.AUDIO;
}
- // Archives
if (['zip', 'rar', '7z', 'tar', 'gz', 'bz2', 'xz'].includes(ext)) {
return FILE_CATEGORIES.ARCHIVE;
}
- // Spreadsheets
if (['xls', 'xlsx', 'csv', 'ods', 'numbers'].includes(ext)) {
return FILE_CATEGORIES.SPREADSHEET;
}
- // Presentations
if (['ppt', 'pptx', 'odp', 'key'].includes(ext)) {
return FILE_CATEGORIES.PRESENTATION;
}
- // Text documents
if (['doc', 'docx', 'txt', 'rtf', 'odt', 'pdf', 'md'].includes(ext)) {
return FILE_CATEGORIES.TEXT_DOCUMENT;
}
diff --git a/packages/twenty-front/src/modules/object-record/record-group/hooks/useSetRecordGroups.ts b/packages/twenty-front/src/modules/object-record/record-group/hooks/useSetRecordGroups.ts
index 4423f2faf30..464764e3121 100644
--- a/packages/twenty-front/src/modules/object-record/record-group/hooks/useSetRecordGroups.ts
+++ b/packages/twenty-front/src/modules/object-record/record-group/hooks/useSetRecordGroups.ts
@@ -92,7 +92,6 @@ export const useSetRecordGroups = () => {
return;
}
- // Set the record group ids
store.set(
recordGroupIdsComponentState.atomFamily({
instanceId: recordIndexId,
diff --git a/packages/twenty-front/src/modules/object-record/record-index/export/hooks/useRecordIndexExportRecords.ts b/packages/twenty-front/src/modules/object-record/record-index/export/hooks/useRecordIndexExportRecords.ts
index fbfbda3f058..2f3c15196e0 100644
--- a/packages/twenty-front/src/modules/object-record/record-index/export/hooks/useRecordIndexExportRecords.ts
+++ b/packages/twenty-front/src/modules/object-record/record-index/export/hooks/useRecordIndexExportRecords.ts
@@ -89,11 +89,9 @@ export const generateCsv: GenerateExport = ({
const sanitizedRow: Record<string, any> = {};
for (const [key, value] of Object.entries(row)) {
- // Apply ZWJ sanitization to all string values
if (typeof value === 'string') {
sanitizedRow[key] = sanitizeValueForCSVExport(value);
} else if (isDefined(value) && typeof value === 'object') {
- // Handle nested objects (like composite fields)
sanitizedRow[key] = {};
for (const [nestedKey, nestedValue] of Object.entries(value)) {
if (typeof nestedValue === 'string') {
diff --git a/packages/twenty-front/src/modules/object-record/select/hooks/useRecordsForSelect.ts b/packages/twenty-front/src/modules/object-record/select/hooks/useRecordsForSelect.ts
index 437347c143c..a03ca186d1c 100644
--- a/packages/twenty-front/src/modules/object-record/select/hooks/useRecordsForSelect.ts
+++ b/packages/twenty-front/src/modules/object-record/select/hooks/useRecordsForSelect.ts
@@ -70,7 +70,6 @@ export const useRecordsForSelect = ({
const [parentFieldName, subFieldName] = fieldName.split('.');
if (isNonEmptyString(subFieldName)) {
- // Composite field
return {
[parentFieldName]: {
[subFieldName]: {
diff --git a/packages/twenty-front/src/modules/page-layout/utils/__tests__/addWidgetToTab.test.ts b/packages/twenty-front/src/modules/page-layout/utils/__tests__/addWidgetToTab.test.ts
index a3cf0f20535..29e876cc09a 100644
--- a/packages/twenty-front/src/modules/page-layout/utils/__tests__/addWidgetToTab.test.ts
+++ b/packages/twenty-front/src/modules/page-layout/utils/__tests__/addWidgetToTab.test.ts
@@ -80,7 +80,6 @@ describe('addWidgetToTab', () => {
it('should handle non-existent tab ID gracefully', () => {
const result = addWidgetToTab(mockTabs, 'non-existent-tab', mockWidget);
- // All tabs should remain unchanged
expect(result[0].widgets).toHaveLength(0);
expect(result[1].widgets).toHaveLength(0);
});
diff --git a/packages/twenty-front/src/modules/page-layout/utils/__tests__/filterPendingPlaceholderFromLayouts.test.ts b/packages/twenty-front/src/modules/page-layout/utils/__tests__/filterPendingPlaceholderFromLayouts.test.ts
index b611b7554ff..8c3afa61f8a 100644
--- a/packages/twenty-front/src/modules/page-layout/utils/__tests__/filterPendingPlaceholderFromLayouts.test.ts
+++ b/packages/twenty-front/src/modules/page-layout/utils/__tests__/filterPendingPlaceholderFromLayouts.test.ts
@@ -53,7 +53,6 @@ describe('filterPendingPlaceholderFromLayouts', () => {
});
it('should handle missing desktop or mobile layouts', () => {
- // Test with missing desktop property
const layoutsWithoutDesktop = {
mobile: [
{ i: 'widget-1', x: 0, y: 0, w: 1, h: 4 },
@@ -67,7 +66,6 @@ describe('filterPendingPlaceholderFromLayouts', () => {
expect(result1.mobile).toHaveLength(1);
expect(result1.mobile).toEqual([{ i: 'widget-1', x: 0, y: 0, w: 1, h: 4 }]);
- // Test with missing mobile property
const layoutsWithoutMobile = {
desktop: [
{ i: 'widget-1', x: 0, y: 0, w: 4, h: 4 },
diff --git a/packages/twenty-front/src/modules/page-layout/utils/__tests__/prepareGridLayoutItemsWithPlaceholders.test.ts b/packages/twenty-front/src/modules/page-layout/utils/__tests__/prepareGridLayoutItemsWithPlaceholders.test.ts
index 1360bc2d3ca..0478b2950da 100644
--- a/packages/twenty-front/src/modules/page-layout/utils/__tests__/prepareGridLayoutItemsWithPlaceholders.test.ts
+++ b/packages/twenty-front/src/modules/page-layout/utils/__tests__/prepareGridLayoutItemsWithPlaceholders.test.ts
@@ -163,7 +163,6 @@ describe('prepareGridLayoutItemsWithPlaceholders', () => {
id: PENDING_WIDGET_PLACEHOLDER_LAYOUT_KEY,
type: 'placeholder',
});
- // Check that all other items are widgets
for (let i = 0; i < result.length - 1; i++) {
expect(result[i].type).toBe('widget');
}
@@ -233,7 +232,6 @@ describe('prepareGridLayoutItemsWithPlaceholders', () => {
prepareGridLayoutItemsWithPlaceholders(originalWidgets, true);
- // Check that the array wasn't mutated
expect(originalWidgets).toHaveLength(2);
expect(originalWidgets).toEqual(widgetsCopy);
expect(originalWidgets[0]).toBe(widget1);
diff --git a/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx b/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx
index d3a2ef9a7be..536ad0e8e3c 100644
--- a/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx
+++ b/packages/twenty-front/src/modules/page-layout/widgets/components/__stories__/WidgetRenderer.stories.tsx
@@ -74,7 +74,6 @@ const companyPeopleField = getMockFieldMetadataItemOrThrow({
const TEST_RECORD_ID = 'test-record-123';
const TEST_PERSON_RECORD_ID = 'test-person-456';
-// Widget ID constants for stories
const WIDGET_ID_NUMBER_CHART = 'widget-number-chart';
const WIDGET_ID_BAR_CHART = 'widget-bar-chart';
const WIDGET_ID_SMALL = 'widget-small';
diff --git a/packages/twenty-front/src/modules/settings/applications/hooks/__tests__/useComputeObjectAndFieldsContentForApplication.test.tsx b/packages/twenty-front/src/modules/settings/applications/hooks/__tests__/useComputeObjectAndFieldsContentForApplication.test.tsx
index b40a55b2a80..82056eba3ad 100644
--- a/packages/twenty-front/src/modules/settings/applications/hooks/__tests__/useComputeObjectAndFieldsContentForApplication.test.tsx
+++ b/packages/twenty-front/src/modules/settings/applications/hooks/__tests__/useComputeObjectAndFieldsContentForApplication.test.tsx
@@ -310,7 +310,6 @@ describe('useComputeObjectAndFieldsContentForApplication', () => {
{ wrapper },
);
- // Should use installed data, not manifest
expect(result.current.objectRows[0].key).toBe(personObject.nameSingular);
expect(
result.current.objectRows.some((r) => r.key === 'manifestObj'),
diff --git a/packages/twenty-front/src/modules/settings/billing/constants/SettingsBillingComparedPlanKeys.ts b/packages/twenty-front/src/modules/settings/billing/constants/SettingsBillingComparedPlanKeys.ts
index 65248e3a9a1..c41eae44d98 100644
--- a/packages/twenty-front/src/modules/settings/billing/constants/SettingsBillingComparedPlanKeys.ts
+++ b/packages/twenty-front/src/modules/settings/billing/constants/SettingsBillingComparedPlanKeys.ts
@@ -1,6 +1,5 @@
import { BillingPlanKey } from '~/generated-metadata/graphql';
-// Column order of the plan comparison table.
export const SETTINGS_BILLING_COMPARED_PLAN_KEYS = [
BillingPlanKey.PRO,
BillingPlanKey.ENTERPRISE,
diff --git a/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx b/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx
index 0cc319aa613..0e20805e4e2 100644
--- a/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx
+++ b/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx
@@ -61,7 +61,6 @@ export const SettingsDataModelFieldRelationJunctionForm = ({
return null;
}
- // Build options from junction object fields
const junctionFieldOptions: { label: string; value: string }[] = [];
// Add MORPH_RELATION fields (use first field of each morphId group)
diff --git a/packages/twenty-front/src/modules/settings/data-model/fields/forms/select/utils/convertBulkTextToOptions.ts b/packages/twenty-front/src/modules/settings/data-model/fields/forms/select/utils/convertBulkTextToOptions.ts
index a3d355da106..d62d8b74a3d 100644
--- a/packages/twenty-front/src/modules/settings/data-model/fields/forms/select/utils/convertBulkTextToOptions.ts
+++ b/packages/twenty-front/src/modules/settings/data-model/fields/forms/select/utils/convertBulkTextToOptions.ts
@@ -34,7 +34,6 @@ export const convertBulkTextToOptions = (
position: optionIndex,
});
} else {
- // create new option if not found
newBulkSelectOptions.push({
...generateNewSelectOption(newBulkSelectOptions, label),
position: optionIndex,
diff --git a/packages/twenty-front/src/modules/settings/data-model/utils/getFieldPreviewValueFromRecord.ts b/packages/twenty-front/src/modules/settings/data-model/utils/getFieldPreviewValueFromRecord.ts
index d9511c3096b..a0153130911 100644
--- a/packages/twenty-front/src/modules/settings/data-model/utils/getFieldPreviewValueFromRecord.ts
+++ b/packages/twenty-front/src/modules/settings/data-model/utils/getFieldPreviewValueFromRecord.ts
@@ -20,6 +20,5 @@ export const getFieldPreviewValueFromRecord = ({
return recordFieldValue.edges[0]?.node;
}
- // Other fields
return recordFieldValue;
};
diff --git a/packages/twenty-front/src/modules/settings/roles/role-assignment/constants/RoleTargetConfig.ts b/packages/twenty-front/src/modules/settings/roles/role-assignment/constants/RoleTargetConfig.ts
index 0545da9e737..a825e929042 100644
--- a/packages/twenty-front/src/modules/settings/roles/role-assignment/constants/RoleTargetConfig.ts
+++ b/packages/twenty-front/src/modules/settings/roles/role-assignment/constants/RoleTargetConfig.ts
@@ -25,7 +25,6 @@ export const ROLE_TARGET_CONFIG = {
settingsDraftRole.canBeAssignedToUsers,
buttonTitle: () => t`Assign to member`,
dropdownComponent: SettingsRoleAssignmentWorkspaceMemberPickerDropdown,
- // Tooltip configuration for member type
tooltip: {
anchorId: 'assign-member',
content: () => t`All workspace members already have this role`,
@@ -44,7 +43,6 @@ export const ROLE_TARGET_CONFIG = {
settingsDraftRole.canBeAssignedToAgents,
buttonTitle: () => t`Assign to agent`,
dropdownComponent: SettingsRoleAssignmentEntityPickerDropdown,
- // No tooltip for agent type
tooltip: null,
},
apiKey: {
@@ -60,7 +58,6 @@ export const ROLE_TARGET_CONFIG = {
settingsDraftRole.canBeAssignedToApiKeys,
buttonTitle: () => t`Assign to API key`,
dropdownComponent: SettingsRoleAssignmentEntityPickerDropdown,
- // No tooltip for apiKey type
tooltip: null,
},
} as const;
diff --git a/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityAuthProvidersOptionsList.tsx b/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityAuthProvidersOptionsList.tsx
index c62acde1f80..5bc0a259df7 100644
--- a/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityAuthProvidersOptionsList.tsx
+++ b/packages/twenty-front/src/modules/settings/security/components/SettingsSecurityAuthProvidersOptionsList.tsx
@@ -104,7 +104,6 @@ export const SettingsSecurityAuthProvidersOptionsList = () => {
},
},
}).catch((err) => {
- // rollback optimistic update if err
setCurrentWorkspace({
...currentWorkspace,
[key]: !currentWorkspace[key],
diff --git a/packages/twenty-front/src/modules/settings/security/components/Toggle2FA.tsx b/packages/twenty-front/src/modules/settings/security/components/Toggle2FA.tsx
index 3201d84926f..532d1940a08 100644
--- a/packages/twenty-front/src/modules/settings/security/components/Toggle2FA.tsx
+++ b/packages/twenty-front/src/modules/settings/security/components/Toggle2FA.tsx
@@ -24,7 +24,6 @@ export const Toggle2FA = () => {
const newEnforceValue = !currentWorkspace.isTwoFactorAuthenticationEnforced;
try {
- // Optimistic update
setCurrentWorkspace({
...currentWorkspace,
isTwoFactorAuthenticationEnforced: newEnforceValue,
@@ -38,7 +37,6 @@ export const Toggle2FA = () => {
},
});
} catch (err: any) {
- // Rollback optimistic update if error
setCurrentWorkspace({
...currentWorkspace,
isTwoFactorAuthenticationEnforced: !newEnforceValue,
diff --git a/packages/twenty-front/src/modules/settings/two-factor-authentication/components/TwoFactorAuthenticationVerificationForSettings.tsx b/packages/twenty-front/src/modules/settings/two-factor-authentication/components/TwoFactorAuthenticationVerificationForSettings.tsx
index 7a002f4d375..7b21f2bd47b 100644
--- a/packages/twenty-front/src/modules/settings/two-factor-authentication/components/TwoFactorAuthenticationVerificationForSettings.tsx
+++ b/packages/twenty-front/src/modules/settings/two-factor-authentication/components/TwoFactorAuthenticationVerificationForSettings.tsx
@@ -6,7 +6,6 @@ import { themeCssVariables } from 'twenty-ui/theme-constants';
import { TwoFactorAuthenticationVerificationCodeDash } from '@/settings/two-factor-authentication/components/TwoFactorAuthenticationVerificationCodeDash';
import { TwoFactorAuthenticationVerificationCodeSlot } from '@/settings/two-factor-authentication/components/TwoFactorAuthenticationVerificationCodeSlot';
-// OTP Form Types
type OTPFormValues = {
otp: string;
};
diff --git a/packages/twenty-front/src/modules/settings/two-factor-authentication/hooks/useTwoFactorVerificationForSettings.ts b/packages/twenty-front/src/modules/settings/two-factor-authentication/hooks/useTwoFactorVerificationForSettings.ts
index 90955cc6a10..c38f7097714 100644
--- a/packages/twenty-front/src/modules/settings/two-factor-authentication/hooks/useTwoFactorVerificationForSettings.ts
+++ b/packages/twenty-front/src/modules/settings/two-factor-authentication/hooks/useTwoFactorVerificationForSettings.ts
@@ -36,7 +36,6 @@ export const useTwoFactorVerificationForSettings = () => {
message: t`Two-factor authentication setup completed successfully!`,
});
- // Reload current user to refresh 2FA status
await loadCurrentUser();
navigate(SettingsPath.ProfilePage);
@@ -63,7 +62,6 @@ export const useTwoFactorVerificationForSettings = () => {
};
const handleCancel = () => {
- // Reset form and navigate back to profile page
formConfig.reset();
navigate(SettingsPath.ProfilePage);
};
diff --git a/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/__tests__/useChartSettingsValues.test.tsx b/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/__tests__/useChartSettingsValues.test.tsx
index 0d0688f29b7..e910a6ac882 100644
--- a/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/__tests__/useChartSettingsValues.test.tsx
+++ b/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/__tests__/useChartSettingsValues.test.tsx
@@ -655,7 +655,6 @@ describe('useChartSettingsValues', () => {
const { result: horizontalResult } =
renderUseChartSettingsValues(horizontalConfig);
- // Test all setting IDs return IDENTICAL values
const settingIds = [
CHART_CONFIGURATION_SETTING_IDS.SOURCE,
CHART_CONFIGURATION_SETTING_IDS.DATA_ON_DISPLAY_X,
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/steps/components/UploadStep/UploadStep.tsx b/packages/twenty-front/src/modules/spreadsheet-import/steps/components/UploadStep/UploadStep.tsx
index a9550b0d5b4..cdc90acd8eb 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/steps/components/UploadStep/UploadStep.tsx
+++ b/packages/twenty-front/src/modules/spreadsheet-import/steps/components/UploadStep/UploadStep.tsx
@@ -58,7 +58,6 @@ export const UploadStep = ({
data: mappedWorkbook,
});
} else {
- // Automatically select first row as header
const trimmedData = mappedWorkbook.slice(1);
const { importedRows: data, headerRow: headerValues } =
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts
index 1cb2fdb1a5b..e2a6825cf3a 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportDialogOptions.ts
@@ -11,7 +11,6 @@ import { type SpreadsheetImportStep } from '@/spreadsheet-import/steps/types/Spr
export type SpreadsheetImportDialogOptions = {
// callback when RSI is closed before final submit
onClose: () => void;
- // Field description for requested data
spreadsheetImportFields: SpreadsheetImportFields;
// Runs after file upload step, receives and returns raw sheet data
uploadStepHook?: (importedRows: ImportedRow[]) => Promise<ImportedRow[]>;
@@ -30,7 +29,6 @@ export type SpreadsheetImportDialogOptions = {
rowHook?: SpreadsheetImportRowHook;
// Runs after column matching and on entry change
tableHook?: SpreadsheetImportTableHook;
- // Function called after user finishes the flow
onSubmit: (
validationResult: SpreadsheetImportImportValidationResult,
file: File,
@@ -43,7 +41,6 @@ export type SpreadsheetImportDialogOptions = {
customTheme?: object;
// Specifies maximum number of rows for a single import
maxRecords?: number;
- // Maximum upload filesize (in bytes)
maxFileSize?: number;
// Automatically map imported headers to specified fields if possible. Default: true
autoMapHeaders?: boolean;
@@ -54,9 +51,7 @@ export type SpreadsheetImportDialogOptions = {
dateFormat?: string;
// Sets SheetJS "raw" option. If true, parsing will only be applied to xlsx date fields.
parseRaw?: boolean;
- // Use for right-to-left (RTL) support
rtl?: boolean;
- // Allow header selection
selectHeader?: boolean;
availableFieldMetadataItems: FieldMetadataItem[];
};
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportField.ts b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportField.ts
index 96531c0023c..71106065f67 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportField.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportField.ts
@@ -5,19 +5,14 @@ import { type FieldMetadataType } from 'twenty-shared/types';
import { type IconComponent } from 'twenty-ui/icon';
export type SpreadsheetImportField = {
- // Icon
Icon: IconComponent | null | undefined;
- // UI-facing field label
label: string;
- // Field's unique identifier
key: string;
// Field's metadata item id - same for all associated nested fields
fieldMetadataItemId: string;
// UI-facing additional information displayed via tooltip and ? icon
description?: string;
- // Validations used for field entries
fieldValidationDefinitions?: SpreadsheetImportFieldValidationDefinition[];
- // Field entry component, default: Input
fieldType: SpreadsheetImportFieldType;
// Field metadata type
fieldMetadataType: FieldMetadataType;
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportFieldType.ts b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportFieldType.ts
index 7b8af3d2077..c65e9120eb1 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportFieldType.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/types/SpreadsheetImportFieldType.ts
@@ -7,7 +7,6 @@ export type SpreadsheetImportCheckbox = {
export type SpreadsheetImportSelect = {
type: 'select';
- // Options displayed in Select component
options: SelectOption[];
};
diff --git a/packages/twenty-front/src/modules/spreadsheet-import/utils/__tests__/csvSecurity.test.ts b/packages/twenty-front/src/modules/spreadsheet-import/utils/__tests__/csvSecurity.test.ts
index eced5468fdd..a3b56e33894 100644
--- a/packages/twenty-front/src/modules/spreadsheet-import/utils/__tests__/csvSecurity.test.ts
+++ b/packages/twenty-front/src/modules/spreadsheet-import/utils/__tests__/csvSecurity.test.ts
@@ -65,7 +65,6 @@ describe('csvSecurity', () => {
const phoneNumber = '+1-555-123-4567';
const result = sanitizeValueForCSVExport(phoneNumber);
expect(result).toBe(`${CSV_INJECTION_PREVENTION_ZWJ}+1-555-123-4567`);
- // Should be visually identical to user
expect(result.substring(1)).toBe(phoneNumber);
});
@@ -292,7 +291,6 @@ describe('csvSecurity', () => {
expect(sanitized).toBe(CSV_INJECTION_PREVENTION_ZWJ + text);
expect(containsCSVProtectionZWJ(sanitized)).toBe(true);
- // Should restore perfectly
expect(restored).toBe(text);
});
});
@@ -333,7 +331,6 @@ describe('csvSecurity', () => {
['Jane Smith', 'Normal text', '+44-20-1234-5678'],
];
- // Simulate the import cleanup process
const cleanedData = exportedData.map((row) =>
row.map((cell) =>
typeof cell === 'string' ? cleanZWJFromImportedValue(cell) : cell,
diff --git a/packages/twenty-front/src/modules/ui/field/input/hooks/__tests__/useAddressAutocomplete.test.tsx b/packages/twenty-front/src/modules/ui/field/input/hooks/__tests__/useAddressAutocomplete.test.tsx
index 2886fea7100..65d52c603f4 100644
--- a/packages/twenty-front/src/modules/ui/field/input/hooks/__tests__/useAddressAutocomplete.test.tsx
+++ b/packages/twenty-front/src/modules/ui/field/input/hooks/__tests__/useAddressAutocomplete.test.tsx
@@ -248,7 +248,6 @@ describe('useAddressAutocomplete', () => {
const { result } = renderHook(() => useAddressAutocomplete(mockOnChange));
- // Set initial token
act(() => {
result.current.setTokenForPlaceApi('initial-token');
});
diff --git a/packages/twenty-front/src/modules/views/utils/mapViewFieldsToColumnDefinitions.ts b/packages/twenty-front/src/modules/views/utils/mapViewFieldsToColumnDefinitions.ts
index 187fa7b7951..e0aba636ff6 100644
--- a/packages/twenty-front/src/modules/views/utils/mapViewFieldsToColumnDefinitions.ts
+++ b/packages/twenty-front/src/modules/views/utils/mapViewFieldsToColumnDefinitions.ts
@@ -58,7 +58,6 @@ export const mapViewFieldsToColumnDefinitions = ({
})
.filter(isDefined);
- // No label identifier set for this object
if (!labelIdentifierFieldMetadataId) return columnDefinitionsFromViewFields;
const labelIdentifierIndex = columnDefinitionsFromViewFields.findIndex(
diff --git a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx
index 380b454fd46..1c83f519e0d 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx
+++ b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/__stories__/HttpRequestTestVariableInput.stories.tsx
@@ -76,7 +76,6 @@ export const WithVariables: Story = {
expect(await canvas.findByText('user.name')).toBeVisible();
expect(await canvas.findByText('contact.email')).toBeVisible();
- // Should have 4 input fields
const inputs = canvas.getAllByRole('textbox');
expect(inputs).toHaveLength(4);
},
@@ -92,11 +91,9 @@ export const WithManyVariables: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
- // Should have 11 input fields
const inputs = canvas.getAllByRole('textbox');
expect(inputs).toHaveLength(11);
- // Check some of the variable labels
expect(await canvas.findByText('api.host')).toBeVisible();
expect(await canvas.findByText('user.name')).toBeVisible();
expect(await canvas.findByText('current.timestamp')).toBeVisible();
@@ -175,7 +172,6 @@ export const SingleVariable: Story = {
expect(await canvas.findByText('user.id')).toBeVisible();
- // Should have only 1 input field
const inputs = canvas.getAllByRole('textbox');
expect(inputs).toHaveLength(1);
},
@@ -219,7 +215,6 @@ export const ComplexNestedVariables: Story = {
const inputs = canvas.getAllByRole('textbox');
expect(inputs).toHaveLength(10);
- // Check some complex variable paths
expect(await canvas.findByText('user.profile.firstName')).toBeVisible();
expect(await canvas.findByText('user.preferences.theme')).toBeVisible();
expect(await canvas.findByText('current.timestamp')).toBeVisible();
diff --git a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/hooks/__tests__/useTestHttpRequest.test.ts b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/hooks/__tests__/useTestHttpRequest.test.ts
index e9633095b38..08fb0001c58 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/hooks/__tests__/useTestHttpRequest.test.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/hooks/__tests__/useTestHttpRequest.test.ts
@@ -38,7 +38,6 @@ jest.mock('twenty-shared/utils', () => ({
return current;
});
} else if (typeof input === 'object' && input !== null) {
- // Handle object replacement recursively
const result = { ...input };
for (const [key, value] of Object.entries(input)) {
if (typeof value === 'string') {
@@ -275,7 +274,6 @@ describe('useTestHttpRequest', () => {
});
it('should set isTesting to true during request', async () => {
- // Create a promise that we can control
let resolvePromise: (value: any) => void;
const mockPromise = new Promise((resolve) => {
resolvePromise = resolve;
@@ -287,15 +285,12 @@ describe('useTestHttpRequest', () => {
wrapper,
});
- // Start the request
act(() => {
result.current.testHttpRequest(mockFormData, mockVariableValues);
});
- // Should be testing now
expect(result.current.isTesting).toBe(true);
- // Complete the request
await act(async () => {
resolvePromise!({
data: {
@@ -310,7 +305,6 @@ describe('useTestHttpRequest', () => {
await mockPromise;
});
- // Should no longer be testing
expect(result.current.isTesting).toBe(false);
});
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/__tests__/getDayOfMonthDescription.test.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/__tests__/getDayOfMonthDescription.test.ts
index 6fd838c0fba..613d8454694 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/__tests__/getDayOfMonthDescription.test.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/__tests__/getDayOfMonthDescription.test.ts
@@ -85,7 +85,6 @@ describe('getDayOfMonthDescription', () => {
});
it('should handle ordinal numbers correctly', () => {
- // Test ordinal suffix logic
expect(getDayOfMonthDescription('11', options)).toBe(
'on the 11th of the month',
);
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/describeCronExpression.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/describeCronExpression.ts
index ef952648ac8..c2e94fc47a7 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/describeCronExpression.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/describeCronExpression.ts
@@ -40,7 +40,6 @@ export const describeCronExpression = (
mergedOptions,
);
- // Smart logic for time descriptions
if (parts.minutes.includes('/') && parts.hours.includes('-')) {
// Special case: minute intervals with hour ranges (e.g., "*/15 9-17")
if (isDefined(minutesDescription) && minutesDescription !== '') {
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfMonthDescription.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfMonthDescription.ts
index 26cf374bf26..78798774c4e 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfMonthDescription.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfMonthDescription.ts
@@ -15,12 +15,10 @@ export const getDayOfMonthDescription = (
return '';
}
- // Every day
if (dayOfMonth === '*') {
return t`every day`;
}
- // Last day of month
if (dayOfMonth === 'L') {
return t`on the last day of the month`;
}
@@ -89,7 +87,6 @@ export const getDayOfMonthDescription = (
return t`on the ${remainingDays} and ${lastDay ?? ''} of the month`;
}
- // Single day value
const dayNum = parseInt(dayOfMonth, 10);
if (!isNaN(dayNum)) {
const ordinalDay = getOrdinalNumber(dayNum);
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfWeekDescription.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfWeekDescription.ts
index 66fb9a87852..2d70b3347a6 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfWeekDescription.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getDayOfWeekDescription.ts
@@ -12,7 +12,6 @@ const getDayName = (
dayOfWeekStartIndexZero: boolean,
localeCatalog?: Locale,
): string => {
- // Handle both 0 and 7 as Sunday
const normalizedDay = dayNum === 7 ? 0 : dayNum;
// Create a date for the given day (using a Sunday as base: 2024-01-07)
@@ -37,7 +36,6 @@ export const getDayOfWeekDescription = (
return '';
}
- // Every day of week
if (dayOfWeek === '*') {
return '';
}
@@ -113,7 +111,6 @@ export const getDayOfWeekDescription = (
localeCatalog,
);
- // Special case for weekdays
if (start === '1' && end === '5' && dayOfWeekStartIndexZero) {
return t`on weekdays`;
}
@@ -147,7 +144,6 @@ export const getDayOfWeekDescription = (
return t`only on ${remainingDays} and ${lastDay ?? ''}`;
}
- // Single day value
const dayNum = parseInt(dayOfWeek, 10);
if (!isNaN(dayNum)) {
const dayName = getDayName(dayNum, dayOfWeekStartIndexZero, localeCatalog);
diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getMonthsDescription.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getMonthsDescription.ts
index af6745dfea0..486fc911393 100644
--- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getMonthsDescription.ts
+++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/cron-to-human/descriptors/getMonthsDescription.ts
@@ -33,7 +33,6 @@ export const getMonthsDescription = (
return '';
}
- // Every month
if (months === '*') {
return '';
}
@@ -111,7 +110,6 @@ export const getMonthsDescription = (
return t`only in ${remainingMonths} and ${lastMonth ?? ''}`;
}
- // Single month value
const monthNum = parseInt(months, 10);
if (!isNaN(monthNum)) {
const monthName = getMonthName(
diff --git a/packages/twenty-front/src/utils/__tests__/date-utils.test.ts b/packages/twenty-front/src/utils/__tests__/date-utils.test.ts
index b0f10aa5036..82bc870d75f 100644
--- a/packages/twenty-front/src/utils/__tests__/date-utils.test.ts
+++ b/packages/twenty-front/src/utils/__tests__/date-utils.test.ts
@@ -298,7 +298,6 @@ describe('French locale tests', () => {
});
afterAll(() => {
- // Restore English for other tests
i18n.load('en', enMessages);
i18n.activate('en');
});
diff --git a/packages/twenty-front/src/utils/array/arrayToChunks.ts b/packages/twenty-front/src/utils/array/arrayToChunks.ts
index a6f5985bc1b..679844c6514 100644
--- a/packages/twenty-front/src/utils/array/arrayToChunks.ts
+++ b/packages/twenty-front/src/utils/array/arrayToChunks.ts
@@ -1,4 +1,3 @@
-// split an array into subarrays of a given size
export const arrayToChunks = <T>(array: T[], size: number) => {
const arrayCopy = [...array];
const results = [];
diff --git a/packages/twenty-server/jest-integration.config.ts b/packages/twenty-server/jest-integration.config.ts
index 184920b3dd7..b386df1db55 100644
--- a/packages/twenty-server/jest-integration.config.ts
+++ b/packages/twenty-server/jest-integration.config.ts
@@ -5,7 +5,6 @@ import { NodeEnvironment } from 'src/engine/core-modules/twenty-config/interface
import testTokens from './test/integration/constants/test-tokens.json';
-// Load .env vars at jest boot time
if (process.env.NODE_ENV === 'test') {
dotenv.config({ path: '.env.test', override: true });
} else {
diff --git a/packages/twenty-server/src/app.module.ts b/packages/twenty-server/src/app.module.ts
index 0d0d3880567..e64f2625696 100644
--- a/packages/twenty-server/src/app.module.ts
+++ b/packages/twenty-server/src/app.module.ts
@@ -68,7 +68,6 @@ const MIGRATED_REST_METHODS = [
ModulesModule,
// Needed for the user workspace middleware
WorkspaceCacheStorageModule,
- // Api modules
CoreGraphQLApiModule,
MetadataGraphQLApiModule,
AdminPanelGraphQLApiModule,
@@ -78,7 +77,6 @@ const MIGRATED_REST_METHODS = [
JwtModule,
UserSessionModule,
WorkspaceMetadataVersionModule,
- // I18n module for translations
I18nModule,
...AppModule.getConditionalModules(),
],
diff --git a/packages/twenty-server/src/command/command.ts b/packages/twenty-server/src/command/command.ts
index e2685a2e62b..ef9fc10ac85 100644
--- a/packages/twenty-server/src/command/command.ts
+++ b/packages/twenty-server/src/command/command.ts
@@ -26,7 +26,6 @@ async function bootstrap() {
const loggerService = app.get(LoggerService);
const exceptionHandlerService = app.get(ExceptionHandlerService);
- // Inject our logger
app.useLogger(loggerService);
await CommandFactory.runApplication(app);
diff --git a/packages/twenty-server/src/database/clickHouse/clickHouse.service.ts b/packages/twenty-server/src/database/clickHouse/clickHouse.service.ts
index dc34dda8e48..0ba36b6c017 100644
--- a/packages/twenty-server/src/database/clickHouse/clickHouse.service.ts
+++ b/packages/twenty-server/src/database/clickHouse/clickHouse.service.ts
@@ -93,7 +93,6 @@ export class ClickHouseService implements OnModuleInit, OnModuleDestroy {
log: { level: ClickHouseLogLevel.OFF },
});
- // Ping to check connection
await client.ping();
return client;
@@ -115,7 +114,6 @@ export class ClickHouseService implements OnModuleInit, OnModuleDestroy {
async onModuleInit() {
if (this.mainClient) {
- // Just ping to verify the connection
try {
await this.mainClient.ping();
} catch (err) {
@@ -129,7 +127,6 @@ export class ClickHouseService implements OnModuleInit, OnModuleDestroy {
await this.mainClient.close();
}
- // Close all other clients
for (const [, client] of this.clients) {
await client.close();
}
@@ -164,7 +161,6 @@ export class ClickHouseService implements OnModuleInit, OnModuleDestroy {
}
}
- // Method to execute a select query
public async select<T>(
query: string,
// oxlint-disable-next-line typescript/no-explicit-any
diff --git a/packages/twenty-server/src/database/clickHouse/migrations/run-migrations.ts b/packages/twenty-server/src/database/clickHouse/migrations/run-migrations.ts
index 444b143167e..18786bf4d0a 100644
--- a/packages/twenty-server/src/database/clickHouse/migrations/run-migrations.ts
+++ b/packages/twenty-server/src/database/clickHouse/migrations/run-migrations.ts
@@ -114,7 +114,6 @@ async function runMigrations() {
);
for (const statement of statements) {
- // Skip comment-only blocks
const cleanedStatement = statement
.split('\n')
.filter((line) => !line.trim().startsWith('--'))
diff --git a/packages/twenty-server/src/database/commands/database-command.module.ts b/packages/twenty-server/src/database/commands/database-command.module.ts
index 17a7e3368b5..8f191ce8414 100644
--- a/packages/twenty-server/src/database/commands/database-command.module.ts
+++ b/packages/twenty-server/src/database/commands/database-command.module.ts
@@ -62,7 +62,6 @@ import { WorkflowCoreConsistencyModule } from 'src/modules/workflow/workflow-cor
UpgradeVersionCommandModule,
TypeOrmModule.forFeature([WorkspaceEntity, RoleEntity]),
WorkspaceExportModule,
- // Cron command dependencies
MessagingImportManagerModule,
CalendarEventImportManagerModule,
WebhookSubscriptionModule,
@@ -71,7 +70,6 @@ import { WorkflowCoreConsistencyModule } from 'src/modules/workflow/workflow-cor
FileModule,
WorkspaceModule,
WorkflowRunQueueModule,
- // Data seeding dependencies
TypeORMModule,
FieldMetadataModule,
ObjectMetadataModule,
diff --git a/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1764100000000-refactor-agent-chat-entities.ts b/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1764100000000-refactor-agent-chat-entities.ts
index 9017bb64a9c..8d5340a5722 100644
--- a/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1764100000000-refactor-agent-chat-entities.ts
+++ b/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1764100000000-refactor-agent-chat-entities.ts
@@ -12,7 +12,6 @@ export class RefactorAgentChatEntities1764100000000 implements MigrationInterfac
`DROP TABLE IF EXISTS "core"."agentChatMessage" CASCADE`,
);
- // Create agentTurn table
await queryRunner.query(
`CREATE TABLE "core"."agentTurn" ("id" uuid NOT NULL DEFAULT uuid_generate_v4(), "threadId" uuid NOT NULL, "agentId" uuid, "createdAt" TIMESTAMP NOT NULL DEFAULT now(), CONSTRAINT "PK_0e3f599ba7cf6a02fc940d9f18d" PRIMARY KEY ("id"))`,
);
@@ -23,7 +22,6 @@ export class RefactorAgentChatEntities1764100000000 implements MigrationInterfac
`CREATE INDEX "IDX_e6d7c07f32e6f0f08cf639d4f5" ON "core"."agentTurn" ("agentId") `,
);
- // Create agentMessage enum and table
await queryRunner.query(
`CREATE TYPE "core"."agentMessage_role_enum" AS ENUM('user', 'assistant')`,
);
@@ -40,7 +38,6 @@ export class RefactorAgentChatEntities1764100000000 implements MigrationInterfac
`CREATE INDEX "IDX_48c75cb32ff0d2887ef0dc547f" ON "core"."agentMessage" ("agentId") `,
);
- // Create agentMessagePart table
await queryRunner.query(
`CREATE TABLE "core"."agentMessagePart" ("id" uuid NOT NULL DEFAULT uuid_generate_v4(), "messageId" uuid NOT NULL, "orderIndex" integer NOT NULL, "type" character varying NOT NULL, "textContent" text, "reasoningContent" text, "toolName" character varying, "toolCallId" character varying, "toolInput" jsonb, "toolOutput" jsonb, "state" character varying, "errorMessage" text, "errorDetails" jsonb, "sourceUrlSourceId" character varying, "sourceUrlUrl" character varying, "sourceUrlTitle" character varying, "sourceDocumentSourceId" character varying, "sourceDocumentMediaType" character varying, "sourceDocumentTitle" character varying, "sourceDocumentFilename" character varying, "fileMediaType" character varying, "fileFilename" character varying, "fileUrl" character varying, "providerMetadata" jsonb, "createdAt" TIMESTAMP NOT NULL DEFAULT now(), CONSTRAINT "PK_7e8c9f0b1a2b3c4d5e6f7a8b9c0" PRIMARY KEY ("id"))`,
);
@@ -48,7 +45,6 @@ export class RefactorAgentChatEntities1764100000000 implements MigrationInterfac
`CREATE INDEX "IDX_2aff9daad5cc3b5e15ca717334" ON "core"."agentMessagePart" ("messageId") `,
);
- // Add foreign key constraints
await queryRunner.query(
`ALTER TABLE "core"."agentTurn" ADD CONSTRAINT "FK_3be906dca9d5b50fbfe40e33f07" FOREIGN KEY ("threadId") REFERENCES "core"."agentChatThread"("id") ON DELETE CASCADE ON UPDATE NO ACTION`,
);
@@ -64,7 +60,6 @@ export class RefactorAgentChatEntities1764100000000 implements MigrationInterfac
}
public async down(queryRunner: QueryRunner): Promise<void> {
- // Drop foreign key constraints
await queryRunner.query(
`ALTER TABLE "core"."agentMessagePart" DROP CONSTRAINT "FK_2aff9daad5cc3b5e15ca7173342"`,
);
@@ -78,7 +73,6 @@ export class RefactorAgentChatEntities1764100000000 implements MigrationInterfac
`ALTER TABLE "core"."agentTurn" DROP CONSTRAINT "FK_3be906dca9d5b50fbfe40e33f07"`,
);
- // Drop indexes
await queryRunner.query(
`DROP INDEX "core"."IDX_2aff9daad5cc3b5e15ca717334"`,
);
@@ -103,7 +97,6 @@ export class RefactorAgentChatEntities1764100000000 implements MigrationInterfac
await queryRunner.query(`DROP TYPE "core"."agentMessage_role_enum"`);
await queryRunner.query(`DROP TABLE "core"."agentTurn"`);
- // Recreate old tables with enum
await queryRunner.query(
`CREATE TYPE "core"."agentChatMessage_role_enum" AS ENUM('user', 'assistant')`,
);
diff --git a/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1764671363647-renameRoleTargets.ts b/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1764671363647-renameRoleTargets.ts
index 8476cfa8444..b31fe875742 100644
--- a/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1764671363647-renameRoleTargets.ts
+++ b/packages/twenty-server/src/database/typeorm/core/legacy-typeorm-migrations-do-not-add/common/1764671363647-renameRoleTargets.ts
@@ -4,17 +4,14 @@ export class RenameRoleTargets1764671363647 implements MigrationInterface {
name = 'RenameRoleTargets1764671363647';
public async up(queryRunner: QueryRunner): Promise<void> {
- // Rename table from roleTargets to roleTarget
await queryRunner.query(
`ALTER TABLE "core"."roleTargets" RENAME TO "roleTarget"`,
);
- // Rename check constraint
await queryRunner.query(
`ALTER TABLE "core"."roleTarget" RENAME CONSTRAINT "CHK_role_targets_single_entity" TO "CHK_role_target_single_entity"`,
);
- // Rename indexes
await queryRunner.query(
`ALTER INDEX "core"."IDX_ROLE_TARGETS_WORKSPACE_ID" RENAME TO "IDX_ROLE_TARGET_WORKSPACE_ID"`,
);
@@ -25,7 +22,6 @@ export class RenameRoleTargets1764671363647 implements MigrationInterface {
`ALTER INDEX "core"."IDX_ROLE_TARGETS_API_KEY_ID" RENAME TO "IDX_ROLE_TARGET_API_KEY_ID"`,
);
- // FK
await queryRunner.query(
`ALTER TABLE "core"."roleTarget" DROP CONSTRAINT "FK_d5838ba43033ee6266d8928d7d7"`,
);
@@ -53,7 +49,6 @@ export class RenameRoleTargets1764671363647 implements MigrationInterface {
}
public async down(queryRunner: QueryRunner): Promise<void> {
- // FK
await queryRunner.query(
`ALTER TABLE "core"."roleTarget" DROP CONSTRAINT "FK_4b3865868c7da0747ee8e480851"`,
);
@@ -79,7 +74,6 @@ export class RenameRoleTargets1764671363647 implements MigrationInterface {
`ALTER TABLE "core"."roleTarget" ADD CONSTRAINT "FK_d5838ba43033ee6266d8928d7d7" FOREIGN KEY ("roleId") REFERENCES "core"."role"("id") ON DELETE CASCADE ON UPDATE NO ACTION`,
);
- // Rename indexes back
await queryRunner.query(
`ALTER INDEX "core"."IDX_ROLE_TARGET_API_KEY_ID" RENAME TO "IDX_ROLE_TARGETS_API_KEY_ID"`,
);
@@ -90,12 +84,10 @@ export class RenameRoleTargets1764671363647 implements MigrationInterface {
`ALTER INDEX "core"."IDX_ROLE_TARGET_WORKSPACE_ID" RENAME TO "IDX_ROLE_TARGETS_WORKSPACE_ID"`,
);
- // Rename check constraint back
await queryRunner.query(
`ALTER TABLE "core"."roleTarget" RENAME CONSTRAINT "CHK_role_target_single_entity" TO "CHK_role_targets_single_entity"`,
);
- // Rename unique constraints back
await queryRunner.query(
`ALTER TABLE "core"."roleTarget" RENAME CONSTRAINT "IDX_ROLE_TARGET_UNIQUE_API_KEY" TO "IDX_ROLE_TARGETS_UNIQUE_API_KEY"`,
);
@@ -106,7 +98,6 @@ export class RenameRoleTargets1764671363647 implements MigrationInterface {
`ALTER TABLE "core"."roleTarget" RENAME CONSTRAINT "IDX_ROLE_TARGET_UNIQUE_USER_WORKSPACE" TO "IDX_ROLE_TARGETS_UNIQUE_USER_WORKSPACE"`,
);
- // Rename table back
await queryRunner.query(
`ALTER TABLE "core"."roleTarget" RENAME TO "roleTargets"`,
);
diff --git a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query-order/graphql-query-order-group-by.parser.ts b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query-order/graphql-query-order-group-by.parser.ts
index 3bd9d7a4ea9..730c042c823 100644
--- a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query-order/graphql-query-order-group-by.parser.ts
+++ b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query-order/graphql-query-order-group-by.parser.ts
@@ -649,7 +649,6 @@ export class GraphqlQueryOrderGroupByParser {
};
}
- // Handle regular nested fields
if (
typeof nestedFieldOrderByValue === 'string' &&
Object.values(OrderByDirection).includes(
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator.ts
index 2711b8a5af4..75aa609bedf 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator.ts
@@ -23,7 +23,6 @@ export function WorkspaceQueryHook(
? keyOrOptions
: { key: keyOrOptions };
- // Default to PreHook
if (!options.type) {
options.type = WorkspaceQueryHookType.PRE_HOOK;
}
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/storage/workspace-query-hook.storage.ts b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/storage/workspace-query-hook.storage.ts
index 2f760083f2d..25848943fda 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/storage/workspace-query-hook.storage.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/storage/workspace-query-hook.storage.ts
@@ -1,4 +1,3 @@
-// hook-registry.service.ts
import { Injectable } from '@nestjs/common';
import { type Module } from '@nestjs/core/injector/module';
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/workspace-resolver.factory.ts b/packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/workspace-resolver.factory.ts
index 34fbf97f16b..47d6b5b985d 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/workspace-resolver.factory.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/workspace-resolver.factory.ts
@@ -89,7 +89,6 @@ export class WorkspaceResolverFactory {
for (const flatObjectMetadata of Object.values(
flatObjectMetadataMaps.byUniversalIdentifier,
).filter(isDefined)) {
- // Generate query resolvers
for (const methodName of workspaceResolverBuilderMethods.queries) {
const resolverName = getResolverName(flatObjectMetadata, methodName);
const resolverFactory = factories.get(methodName);
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/args-type/args-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/args-type/args-type.generator.ts
index 0e97e300160..caf069c5d1d 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/args-type/args-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/args-type/args-type.generator.ts
@@ -28,7 +28,6 @@ export class ArgsTypeGenerator {
}
const arg = args[key];
- // Argument is a scalar type
if (isDefined(arg.type)) {
const gqlType = applyTypeOptionsForOutputType(arg.type, {
defaultValue: arg.defaultValue,
@@ -41,7 +40,6 @@ export class ArgsTypeGenerator {
};
}
- // Argument is an input type
if (isDefined(arg.kind)) {
const storageKey = computeObjectMetadataInputTypeKey(
objectMetadataSingularName,
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/create-input/composite-field-metadata-create-gql-input-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/create-input/composite-field-metadata-create-gql-input-type.generator.ts
index b9e706d3c2b..8f788a15a9d 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/create-input/composite-field-metadata-create-gql-input-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/create-input/composite-field-metadata-create-gql-input-type.generator.ts
@@ -59,7 +59,6 @@ export class CompositeFieldMetadataCreateGqlInputTypeGenerator {
throw new Error('Relation fields are not supported in composite types');
}
- // Skip hidden fields
if (property.hidden === true || property.hidden === 'input') {
continue;
}
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/filter-input/composite-field-metadata-filter-gql-input-types.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/filter-input/composite-field-metadata-filter-gql-input-types.generator.ts
index 1591ac0a0bc..2e355bbf7a5 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/filter-input/composite-field-metadata-filter-gql-input-types.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/filter-input/composite-field-metadata-filter-gql-input-types.generator.ts
@@ -61,7 +61,6 @@ export class CompositeFieldMetadataFilterGqlInputTypeGenerator {
throw new Error('Relation fields are not supported in composite types');
}
- // Skip hidden fields
if (property.hidden === true) continue;
const key = computeCompositeFieldEnumTypeKey(
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/order-by-input/composite-field-metadata-order-by-gql-input-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/order-by-input/composite-field-metadata-order-by-gql-input-type.generator.ts
index d48b4d100e5..d75b0999d70 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/order-by-input/composite-field-metadata-order-by-gql-input-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/order-by-input/composite-field-metadata-order-by-gql-input-type.generator.ts
@@ -56,7 +56,6 @@ export class CompositeFieldMetadataOrderByGqlInputTypeGenerator {
throw new Error('Relation fields are not supported in composite types');
}
- // Skip hidden fields
if (property.hidden === true) {
continue;
}
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/update-input/composite-field-metadata-update-gql-input-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/update-input/composite-field-metadata-update-gql-input-type.generator.ts
index 4c81da49412..1849c25782f 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/update-input/composite-field-metadata-update-gql-input-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/input-types/update-input/composite-field-metadata-update-gql-input-type.generator.ts
@@ -60,7 +60,6 @@ export class CompositeFieldMetadataUpdateGqlInputTypeGenerator {
throw new Error('Relation fields are not supported in composite types');
}
- // Skip hidden fields
if (property.hidden === true || property.hidden === 'input') {
continue;
}
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/composite-field-metadata-gql-object-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/composite-field-metadata-gql-object-type.generator.ts
index 0da4b84b469..316e27292c6 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/composite-field-metadata-gql-object-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/composite-field-metadata-gql-object-type.generator.ts
@@ -53,7 +53,6 @@ export class CompositeFieldMetadataGqlObjectTypeGenerator {
throw new Error('Relation fields are not supported in composite types');
}
- // Skip hidden fields
if (property.hidden === true || property.hidden === 'output') {
continue;
}
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts
index ab534cc64f5..df89421cff9 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/graphql-type-generators/object-types/object-metadata-with-relations-gql-object-type.generator.ts
@@ -72,7 +72,6 @@ export class ObjectMetadataWithRelationsGqlObjectTypeGenerator {
);
}
- // Extract current object config to extend it
const config = gqlType.toConfig();
// Recreate the same object type with the new fields
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/utils/clean-entity-name.util.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/utils/clean-entity-name.util.ts
index d508ec56d18..0534984475a 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/utils/clean-entity-name.util.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/utils/clean-entity-name.util.ts
@@ -1,10 +1,8 @@
import { camelCase } from 'src/utils/camel-case';
export const cleanEntityName = (entityName: string) => {
- // Remove all leading numbers
let camelCasedEntityName = entityName.replace(/^[0-9]+/, '');
- // Trim the string
camelCasedEntityName = camelCasedEntityName.trim();
camelCasedEntityName = camelCase(camelCasedEntityName);
diff --git a/packages/twenty-server/src/engine/core-entity-cache/services/core-entity-cache.service.ts b/packages/twenty-server/src/engine/core-entity-cache/services/core-entity-cache.service.ts
index 489e856ca3e..e78354be4af 100644
--- a/packages/twenty-server/src/engine/core-entity-cache/services/core-entity-cache.service.ts
+++ b/packages/twenty-server/src/engine/core-entity-cache/services/core-entity-cache.service.ts
@@ -99,7 +99,6 @@ export class CoreEntityCacheService implements OnModuleInit {
const localEntry = this.localCache.get(localKey);
const now = Date.now();
- // Stage 1: Check local TTL
if (
isDefined(localEntry) &&
now - localEntry.lastHashCheckedAt < LOCAL_TTL_MS
@@ -113,7 +112,6 @@ export class CoreEntityCacheService implements OnModuleInit {
}
}
- // Stage 2: Validate against Redis hash
const hashKey = `${localKey}:hash`;
const redisHash = await this.cacheStorage.get<string>(hashKey);
@@ -132,7 +130,6 @@ export class CoreEntityCacheService implements OnModuleInit {
}
}
- // Stage 3: Fetch from Redis
const [redisData, redisDataHash] = await this.cacheStorage.mget<
CacheableValue | string
>([`${localKey}:data`, hashKey]);
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/app.health.spec.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/app.health.spec.ts
index 327bee6875e..7206da2a341 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/app.health.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/app.health.spec.ts
@@ -67,12 +67,10 @@ describe('AppHealthIndicator', () => {
});
it('should maintain state history across health checks', async () => {
- // First check - healthy state
workspaceRepository.count.mockResolvedValue(2);
await service.isHealthy();
- // Second check - error state
workspaceRepository.count.mockRejectedValue(
new Error('Database connection failed'),
);
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/database.health.spec.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/database.health.spec.ts
index 7f46764cbcf..c8d79f87f27 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/database.health.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/database.health.spec.ts
@@ -128,7 +128,6 @@ describe('DatabaseHealthIndicator', () => {
});
it('should maintain state history across health checks', async () => {
- // First check - healthy state
const mockResponses = [
[{ version: 'PostgreSQL 15.6' }],
[{ count: '5' }],
@@ -149,7 +148,6 @@ describe('DatabaseHealthIndicator', () => {
expect(firstResult.database.status).toBe('up');
- // Second check - error state
dataSource.query.mockRejectedValueOnce(
new Error(HEALTH_ERROR_MESSAGES.DATABASE_CONNECTION_FAILED),
);
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/redis.health.spec.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/redis.health.spec.ts
index dc01a25f1c1..cb3c1076586 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/redis.health.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/redis.health.spec.ts
@@ -68,7 +68,6 @@ describe('RedisHealthIndicator', () => {
});
it('should return up status with details when redis responds', async () => {
- // ai generated mock
mockRedis.info
.mockResolvedValueOnce('redis_version:7.0.0\r\n')
.mockResolvedValueOnce(
@@ -127,7 +126,6 @@ describe('RedisHealthIndicator', () => {
});
it('should maintain state history across health checks', async () => {
- // First check - healthy state
mockRedis.info
.mockResolvedValueOnce('redis_version:7.0.0\r\n')
.mockResolvedValueOnce(
@@ -140,7 +138,6 @@ describe('RedisHealthIndicator', () => {
await service.isHealthy();
- // Second check - error state
mockRedis.info.mockRejectedValueOnce(
new Error(HEALTH_ERROR_MESSAGES.REDIS_CONNECTION_FAILED),
);
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-queue.service.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-queue.service.ts
index 82e6c3500b3..cbd4d5786b5 100644
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-queue.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/admin-panel/admin-panel-queue.service.ts
@@ -40,7 +40,6 @@ export class AdminPanelQueueService {
const start = validOffset;
const end = validOffset + validLimit - 1;
- // Convert GraphQL enum to BullMQ state
const bullMQState = jobStateEnumToBullMQ[state];
const jobs = await queue.getJobs([bullMQState], start, end, false);
diff --git a/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/utils/__test__/is-subdomain-valid.util.spec.ts b/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/utils/__test__/is-subdomain-valid.util.spec.ts
index 604b99707b4..720da574270 100644
--- a/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/utils/__test__/is-subdomain-valid.util.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/utils/__test__/is-subdomain-valid.util.spec.ts
@@ -288,19 +288,15 @@ describe('isSubdomainValid', () => {
});
it('should handle boundary length cases precisely', () => {
- // Exactly 1 character (minimum valid)
expect(isSubdomainValid('a')).toBe(true);
- // Exactly 2 characters
expect(isSubdomainValid('ab')).toBe(true);
- // Exactly 30 characters (maximum valid)
const exactly30Chars = 'a'.repeat(28) + 'bc';
expect(exactly30Chars.length).toBe(30);
expect(isSubdomainValid(exactly30Chars)).toBe(true);
- // Exactly 31 characters (first invalid length)
const exactly31Chars = 'a'.repeat(29) + 'bc';
expect(exactly31Chars.length).toBe(31);
@@ -320,11 +316,8 @@ describe('isSubdomainValid', () => {
it('should accept valid subdomains that are similar to reserved ones but not exact matches', () => {
// 'testing' is reserved, but 'testing123' is not
expect(isSubdomainValid('testing123')).toBe(true);
- // 'api' is reserved, but 'myapi' is not
expect(isSubdomainValid('myapi')).toBe(true);
- // 'admin' is reserved, but 'adminpanel' is not
expect(isSubdomainValid('adminpanel')).toBe(true);
- // 'test' is reserved, but 'testapp' is not
expect(isSubdomainValid('testapp')).toBe(true);
});
@@ -360,7 +353,6 @@ describe('isSubdomainValid', () => {
expect(isSubdomainValid('api-test')).toBe(false);
expect(isSubdomainValid('api-123')).toBe(false);
- // But allow 'api' in other positions
expect(isSubdomainValid('myapi')).toBe(true);
});
@@ -368,13 +360,10 @@ describe('isSubdomainValid', () => {
// The regex pattern is: /^(?!api-)[a-z0-9](?:[a-z0-9-]{0,28}[a-z0-9])?$/
// This means: start char + optional (0-28 middle chars + end char) = 1-30 total chars
- // 1 char: start only
expect(isSubdomainValid('a')).toBe(true);
- // 3 chars: start + 1 middle + end
expect(isSubdomainValid('abc')).toBe(true);
- // 30 chars: start + 28 middle + end
const thirtyChars = 'a' + 'b'.repeat(28) + 'c';
expect(thirtyChars.length).toBe(30);
diff --git a/packages/twenty-server/src/engine/core-modules/email/__tests__/email-driver.factory.spec.ts b/packages/twenty-server/src/engine/core-modules/email/__tests__/email-driver.factory.spec.ts
index a56250b1b2a..a13c967fd1d 100644
--- a/packages/twenty-server/src/engine/core-modules/email/__tests__/email-driver.factory.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/email/__tests__/email-driver.factory.spec.ts
@@ -168,14 +168,12 @@ describe('EmailDriverFactory', () => {
});
it('should create new driver when config key changes', () => {
- // First call with logger
jest
.spyOn(twentyConfigService, 'get')
.mockReturnValue(EmailDriver.LOGGER);
const driver1 = factory.getCurrentDriver();
- // Second call with smtp
jest
.spyOn(twentyConfigService, 'get')
.mockImplementation((key: string) => {
diff --git a/packages/twenty-server/src/engine/core-modules/enterprise/constants/enterprise-public-key.constant.ts b/packages/twenty-server/src/engine/core-modules/enterprise/constants/enterprise-public-key.constant.ts
index a07662740a0..f0ec1cb3c8a 100644
--- a/packages/twenty-server/src/engine/core-modules/enterprise/constants/enterprise-public-key.constant.ts
+++ b/packages/twenty-server/src/engine/core-modules/enterprise/constants/enterprise-public-key.constant.ts
@@ -10,7 +10,6 @@ EuZs6PhKiH6l3sXY6kocC0ZV25rFhHgOChVA91BE8a+Wj0MtGGI/UL/b21G3zsr7
6wIDAQAB
-----END PUBLIC KEY-----`;
-// Dev-only
export const ENTERPRISE_JWT_DEV_PUBLIC_KEY = `-----BEGIN PUBLIC KEY-----
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAsHEWc84t399KlYyhRkBO
QCXE8/HE/TKvMk35ccoUeZXnBNhuGpWcHuM6+6ekHiToT239hkBy+Bk/Ybd6wVrs
diff --git a/packages/twenty-server/src/engine/core-modules/event-emitter/utils/object-record-diff-merge.ts b/packages/twenty-server/src/engine/core-modules/event-emitter/utils/object-record-diff-merge.ts
index f64bb2d1158..adab01344d1 100644
--- a/packages/twenty-server/src/engine/core-modules/event-emitter/utils/object-record-diff-merge.ts
+++ b/packages/twenty-server/src/engine/core-modules/event-emitter/utils/object-record-diff-merge.ts
@@ -8,7 +8,6 @@ export function objectRecordDiffMerge(
// oxlint-disable-next-line typescript/no-explicit-any
const result: Record<string, any> = { diff: {} };
- // Iterate over the keys in the oldRecord diff
Object.keys(oldRecord.diff ?? {}).forEach((key) => {
if (newRecord.diff && newRecord.diff[key]) {
// If the key also exists in the newRecord, merge the 'before' from the oldRecord and the 'after' from the newRecord
diff --git a/packages/twenty-server/src/engine/core-modules/file-storage/__tests__/file-storage-driver.factory.spec.ts b/packages/twenty-server/src/engine/core-modules/file-storage/__tests__/file-storage-driver.factory.spec.ts
index 39a759d86f0..fbcadf38c6f 100644
--- a/packages/twenty-server/src/engine/core-modules/file-storage/__tests__/file-storage-driver.factory.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/file-storage/__tests__/file-storage-driver.factory.spec.ts
@@ -211,7 +211,6 @@ describe('FileStorageDriverFactory', () => {
});
it('should create new driver when config key changes', () => {
- // First call with local storage
jest
.spyOn(twentyConfigService, 'get')
.mockImplementation((key: string) => {
@@ -223,7 +222,6 @@ describe('FileStorageDriverFactory', () => {
const driver1 = factory.getCurrentDriver();
- // Second call with different local path
jest
.spyOn(twentyConfigService, 'get')
.mockImplementation((key: string) => {
@@ -241,7 +239,6 @@ describe('FileStorageDriverFactory', () => {
});
it('should create new driver when switching from local to S3', () => {
- // First call with local storage
jest
.spyOn(twentyConfigService, 'get')
.mockImplementation((key: string) => {
@@ -253,7 +250,6 @@ describe('FileStorageDriverFactory', () => {
const driver1 = factory.getCurrentDriver();
- // Second call with S3 storage
jest
.spyOn(twentyConfigService, 'get')
.mockImplementation((key: string) => {
diff --git a/packages/twenty-server/src/engine/core-modules/graphql/utils/graphql-errors.util.ts b/packages/twenty-server/src/engine/core-modules/graphql/utils/graphql-errors.util.ts
index 3cd06ee05e8..e5115a3ab7e 100644
--- a/packages/twenty-server/src/engine/core-modules/graphql/utils/graphql-errors.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/graphql/utils/graphql-errors.util.ts
@@ -282,7 +282,6 @@ export const convertGraphQLErrorToBaseGraphQLError = (
break;
default:
if (httpStatus >= 400 && httpStatus < 500) {
- // Other 4xx errors
errorCode = ErrorCode.BAD_USER_INPUT;
} else {
errorCode = ErrorCode.INTERNAL_SERVER_ERROR;
diff --git a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/constants/yarn-install/index.mjs b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/constants/yarn-install/index.mjs
index f2fc9c9ce33..fed952e4133 100644
--- a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/constants/yarn-install/index.mjs
+++ b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/constants/yarn-install/index.mjs
@@ -48,7 +48,6 @@ const runYarnInstall = async (nodejsDir) => {
throw new Error(`yarn install failed: ${details || error?.message}`);
}
- // Remove everything except node_modules
const entries = await fs.readdir(nodejsDir);
await Promise.all(
diff --git a/packages/twenty-server/src/engine/core-modules/message-queue/message-queue.explorer.ts b/packages/twenty-server/src/engine/core-modules/message-queue/message-queue.explorer.ts
index 333e4a2f794..975402b3ba6 100644
--- a/packages/twenty-server/src/engine/core-modules/message-queue/message-queue.explorer.ts
+++ b/packages/twenty-server/src/engine/core-modules/message-queue/message-queue.explorer.ts
@@ -205,7 +205,6 @@ export class MessageQueueExplorer implements OnModuleInit {
},
);
- // Return early if no matching methods found
if (filteredProcessMethodNames.length === 0) {
return;
}
@@ -216,7 +215,6 @@ export class MessageQueueExplorer implements OnModuleInit {
if (this.moduleRef.registerRequestByContextId) {
this.moduleRef.registerRequestByContextId(
{
- // Add workspaceId to the request object
req: {
workspaceId: job.data?.workspaceId,
},
diff --git a/packages/twenty-server/src/engine/core-modules/open-api/utils/base-schema.utils.ts b/packages/twenty-server/src/engine/core-modules/open-api/utils/base-schema.utils.ts
index f42ebf5444a..ae724aca817 100644
--- a/packages/twenty-server/src/engine/core-modules/open-api/utils/base-schema.utils.ts
+++ b/packages/twenty-server/src/engine/core-modules/open-api/utils/base-schema.utils.ts
@@ -136,7 +136,6 @@ curl -H 'Authorization: Bearer <token>' \\
},
version: API_Version,
},
- // Testing purposes
servers: [
{
url: `${serverUrl}/${ApiPath.Rest}/${schemaName !== 'core' ? schemaName : ''}`,
diff --git a/packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts b/packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts
index bb1f0b34d71..3e719183084 100644
--- a/packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts
+++ b/packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts
@@ -47,7 +47,6 @@ const getSchemaComponentsExample = (
flatFieldMetadatas: FlatFieldMetadata[],
): OpenApiExample => {
return flatFieldMetadatas.reduce((node, field) => {
- // If field is required
if (!field.isNullable && field.defaultValue === null) {
return {
...node,
diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts
index 15981d81964..d41c762bd77 100644
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts
+++ b/packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts
@@ -1391,7 +1391,6 @@ export class ConfigVariables {
options: Object.values(NodeEnvironment),
isEnvOnly: true,
})
- // @CastToUpperSnakeCase()
NODE_ENV: NodeEnvironment = NodeEnvironment.PRODUCTION;
@ConfigVariablesMetadata({
diff --git a/packages/twenty-server/src/engine/core-modules/two-factor-authentication/utils/two-factor-authentication-method.presenter.spec.ts b/packages/twenty-server/src/engine/core-modules/two-factor-authentication/utils/two-factor-authentication-method.presenter.spec.ts
index 06a0e882db2..b515775c8ea 100644
--- a/packages/twenty-server/src/engine/core-modules/two-factor-authentication/utils/two-factor-authentication-method.presenter.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/two-factor-authentication/utils/two-factor-authentication-method.presenter.spec.ts
@@ -108,7 +108,6 @@ describe('buildTwoFactorAuthenticationMethodSummary', () => {
strategy: TwoFactorAuthenticationStrategy.TOTP,
});
- // Ensure other fields are not included
expect(result![0]).not.toHaveProperty('secret');
expect(result![0]).not.toHaveProperty('userWorkspaceId');
expect(result![0]).not.toHaveProperty('userWorkspace');
diff --git a/packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts b/packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts
index b4f3388b053..abaa8c16cc3 100644
--- a/packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts
@@ -310,7 +310,6 @@ export class WorkspaceService {
...payload,
});
} catch (error) {
- // revert custom domain registration on error
if (payload.customDomain && customDomainRegistered) {
this.dnsManagerService
.deleteHostnameSilently(payload.customDomain)
diff --git a/packages/twenty-server/src/engine/core-modules/workspace/workspace.entity.ts b/packages/twenty-server/src/engine/core-modules/workspace/workspace.entity.ts
index 74735d038de..efece966bfa 100644
--- a/packages/twenty-server/src/engine/core-modules/workspace/workspace.entity.ts
+++ b/packages/twenty-server/src/engine/core-modules/workspace/workspace.entity.ts
@@ -74,7 +74,6 @@ registerEnumType(WorkspaceDiscoverability, {
@Entity({ name: 'workspace', schema: 'core' })
@ObjectType('Workspace')
export class WorkspaceEntity {
- // Fields
@Field(() => UUIDScalarType)
@PrimaryGeneratedColumn('uuid')
id: string;
@@ -144,7 +143,6 @@ export class WorkspaceEntity {
@Column({ type: 'integer', default: 90 })
eventLogRetentionDays: number;
- // Relations
@OneToMany(() => AppTokenEntity, (appToken) => appToken.workspace, {
cascade: true,
})
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/chat-system-prompts.const.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/chat-system-prompts.const.ts
index 3f0f15dee03..f781e1d7013 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/chat-system-prompts.const.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/constants/chat-system-prompts.const.ts
@@ -1,6 +1,5 @@
// System prompts for AI Chat (user-facing conversational interface)
export const CHAT_SYSTEM_PROMPTS = {
- // Core chat behavior and tool strategy
BASE: `You are a helpful AI assistant integrated into Twenty, a CRM (similar to Salesforce).
## Plan → Skill → Learn → Execute
@@ -71,7 +70,6 @@ Intent gate: purely informational dashboard questions (e.g. "what is a dashboard
BROWSING_CONTEXT_INSTRUCTION: `A <browsing_context> tag may appear in the user's last message. Only use it when directly relevant to the question.`,
- // Response formatting and record references
RESPONSE_FORMAT: `
Format responses with markdown for clarity (headings, lists, code blocks, tables).
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/types/models-dev-model.type.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/types/models-dev-model.type.ts
index a1cc00e3eb7..d708fda4b54 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/types/models-dev-model.type.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/types/models-dev-model.type.ts
@@ -1,7 +1,6 @@
export type ModelsDevModel = {
// Model id as returned by models.dev (may match the record key in `ModelsDevProvider.models`).
id: string;
- // Human-readable model name from the catalog.
name: string;
family?: string;
status?: 'deprecated' | 'beta';
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/types/__tests__/flat-field-metadata.test-type.ts b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/types/__tests__/flat-field-metadata.test-type.ts
index 2ae64f7c760..e4deee84db9 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/types/__tests__/flat-field-metadata.test-type.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/types/__tests__/flat-field-metadata.test-type.ts
@@ -22,7 +22,6 @@ type DatePropertiesCastToString = {
updatedAt: string;
};
-// OneToMany relations become ...Ids arrays
type OneToManyRelationIdArrays = {
viewFieldIds: string[];
viewFilterIds: string[];
@@ -42,7 +41,6 @@ type RelationIdAssertions = [
>
>,
- // Relation types have defined relation IDs
Expect<
HasAllProperties<
FlatFieldMetadata<FieldMetadataType.RELATION>,
@@ -75,7 +73,6 @@ type FlatTransformationAssertions = [
type AbstractFlatFieldMetadata = FlatFieldMetadata<FieldMetadataType>;
const _assertion: Record<string, AbstractFlatFieldMetadata> = {
- // Primitive types
uuid: {} as FlatFieldMetadata<FieldMetadataType.UUID>,
text: {} as FlatFieldMetadata<FieldMetadataType.TEXT>,
number: {} as FlatFieldMetadata<FieldMetadataType.NUMBER>,
@@ -86,7 +83,6 @@ const _assertion: Record<string, AbstractFlatFieldMetadata> = {
date: {} as FlatFieldMetadata<FieldMetadataType.DATE>,
dateTime: {} as FlatFieldMetadata<FieldMetadataType.DATE_TIME>,
- // Complex types
currency: {} as FlatFieldMetadata<FieldMetadataType.CURRENCY>,
fullName: {} as FlatFieldMetadata<FieldMetadataType.FULL_NAME>,
address: {} as FlatFieldMetadata<FieldMetadataType.ADDRESS>,
@@ -95,7 +91,6 @@ const _assertion: Record<string, AbstractFlatFieldMetadata> = {
phones: {} as FlatFieldMetadata<FieldMetadataType.PHONES>,
actor: {} as FlatFieldMetadata<FieldMetadataType.ACTOR>,
- // Select types
rating: {} as FlatFieldMetadata<FieldMetadataType.RATING>,
select: {} as FlatFieldMetadata<FieldMetadataType.SELECT>,
multiSelect: {} as FlatFieldMetadata<FieldMetadataType.MULTI_SELECT>,
@@ -107,7 +102,6 @@ const _assertion: Record<string, AbstractFlatFieldMetadata> = {
relation: {} as FlatFieldMetadata<FieldMetadataType.RELATION>,
morphRelation: {} as FlatFieldMetadata<FieldMetadataType.MORPH_RELATION>,
- // Special types
files: {} as FlatFieldMetadata<FieldMetadataType.FILES>,
tsVector: {} as FlatFieldMetadata<FieldMetadataType.TS_VECTOR>,
};
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-label.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-label.util.ts
index c3e3a410562..ba1c7c1c446 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-label.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-label.util.ts
@@ -14,9 +14,7 @@ export const validateFlatObjectMetadataLabel = ({
ObjectMetadataMinimalInformation): FlatObjectMetadataValidationError[] => {
const errors: FlatObjectMetadataValidationError[] = [];
- // Validate both labelSingular and labelPlural
for (const label of [labelSingular, labelPlural]) {
- // Length too short check
if (label.length < IDENTIFIER_MIN_CHAR_LENGTH) {
errors.push({
code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,
@@ -26,7 +24,6 @@ export const validateFlatObjectMetadataLabel = ({
});
}
- // Length too long check
if (label.length > IDENTIFIER_MAX_CHAR_LENGTH) {
errors.push({
code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-name.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-name.util.ts
index eb58d2d4d79..90d45a09f33 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-name.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-name.util.ts
@@ -20,9 +20,7 @@ export const validateFlatObjectMetadataNames = ({
ObjectMetadataMinimalInformation) => {
const errors: FlatObjectMetadataValidationError[] = [];
- // Validate both nameSingular and namePlural
for (const name of [nameSingular, namePlural]) {
- // Length too long check
if (name.length > IDENTIFIER_MAX_CHAR_LENGTH) {
errors.push({
code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,
@@ -32,7 +30,6 @@ export const validateFlatObjectMetadataNames = ({
});
}
- // Length too short check
if (name.length < IDENTIFIER_MIN_CHAR_LENGTH) {
errors.push({
code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,
@@ -42,7 +39,6 @@ export const validateFlatObjectMetadataNames = ({
});
}
- // Format check
if (
!name.match(
STARTS_WITH_LOWER_CASE_AND_CONTAINS_ONLY_CAPS_AND_LOWER_LETTERS_AND_NUMBER_STRING_REGEX,
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-update-view-input-to-flat-view-to-update-or-throw.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-update-view-input-to-flat-view-to-update-or-throw.util.ts
index d4c02933180..d95504797d7 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-update-view-input-to-flat-view-to-update-or-throw.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-update-view-input-to-flat-view-to-update-or-throw.util.ts
@@ -177,7 +177,6 @@ export const fromUpdateViewInputToFlatViewToUpdateOrThrow = ({
existingFlatViewToUpdate.visibility === 'WORKSPACE' &&
isDefined(userWorkspaceId)
) {
- // Re-allocate the view to the current user
flatViewToUpdate.createdByUserWorkspaceId = userWorkspaceId;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/page-layout/services/page-layout-update.service.ts b/packages/twenty-server/src/engine/metadata-modules/page-layout/services/page-layout-update.service.ts
index 0e71e9e9367..35d6eecad48 100644
--- a/packages/twenty-server/src/engine/metadata-modules/page-layout/services/page-layout-update.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/page-layout/services/page-layout-update.service.ts
@@ -101,7 +101,6 @@ export class PageLayoutUpdateService {
PageLayoutExceptionCode.PAGE_LAYOUT_NOT_FOUND,
);
}
- ///
const { workspaceCustomFlatApplication } =
await this.applicationService.findWorkspaceTwentyStandardAndCustomApplicationOrThrow(
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-field/filters/view-field-rest-api-exception.filter.ts b/packages/twenty-server/src/engine/metadata-modules/view-field/filters/view-field-rest-api-exception.filter.ts
index 3e0c38e34cb..36c69037830 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-field/filters/view-field-rest-api-exception.filter.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-field/filters/view-field-rest-api-exception.filter.ts
@@ -69,7 +69,6 @@ export class ViewFieldRestApiExceptionFilter implements ExceptionFilter {
}
}
- // Fallback for any other exception type
const unknownException = new UnknownException(
'Internal server error',
'INTERNAL_ERROR',
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-filter-group/filters/view-filter-group-rest-api-exception.filter.ts b/packages/twenty-server/src/engine/metadata-modules/view-filter-group/filters/view-filter-group-rest-api-exception.filter.ts
index 6784629c2b6..397acba9f7b 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-filter-group/filters/view-filter-group-rest-api-exception.filter.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-filter-group/filters/view-filter-group-rest-api-exception.filter.ts
@@ -69,7 +69,6 @@ export class ViewFilterGroupRestApiExceptionFilter implements ExceptionFilter {
}
}
- // Fallback for any other exception type
const unknownException = new UnknownException(
'Internal server error',
'INTERNAL_ERROR',
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-filter/filters/view-filter-rest-api-exception.filter.ts b/packages/twenty-server/src/engine/metadata-modules/view-filter/filters/view-filter-rest-api-exception.filter.ts
index b5a3106743d..ad76709fd49 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-filter/filters/view-filter-rest-api-exception.filter.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-filter/filters/view-filter-rest-api-exception.filter.ts
@@ -69,7 +69,6 @@ export class ViewFilterRestApiExceptionFilter implements ExceptionFilter {
}
}
- // Fallback for any other exception type
const unknownException = new UnknownException(
'Internal server error',
'INTERNAL_ERROR',
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-field-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-field-permission.guard.ts
index b5cda6f4b09..35e39adb10c 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-field-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-field-permission.guard.ts
@@ -31,7 +31,6 @@ export class CreateViewFieldPermissionGuard implements CanActivate {
: null;
}
- // For REST: extract from request body
if (!viewId && typeof request.body?.viewId === 'string') {
viewId = request.body.viewId;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-filter-group-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-filter-group-permission.guard.ts
index f57d6bc02c0..8f57adef333 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-filter-group-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-filter-group-permission.guard.ts
@@ -17,14 +17,12 @@ export class CreateViewFilterGroupPermissionGuard implements CanActivate {
let viewId: string | null = null;
- // For GraphQL: extract from args.input
const args = gqlContext.getArgs();
if (typeof args?.input?.viewId === 'string') {
viewId = args.input.viewId;
}
- // For REST: extract from request body
if (!viewId && typeof request.body?.viewId === 'string') {
viewId = request.body.viewId;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-filter-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-filter-permission.guard.ts
index a94cb91b3f8..1d56c7c0a72 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-filter-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-filter-permission.guard.ts
@@ -17,14 +17,12 @@ export class CreateViewFilterPermissionGuard implements CanActivate {
let viewId: string | null = null;
- // For GraphQL: extract from args.input
const args = gqlContext.getArgs();
if (typeof args?.input?.viewId === 'string') {
viewId = args.input.viewId;
}
- // For REST: extract from request body
if (!viewId && typeof request.body?.viewId === 'string') {
viewId = request.body.viewId;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-group-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-group-permission.guard.ts
index 2ef73d4acbd..c30c11e7a32 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-group-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-group-permission.guard.ts
@@ -31,7 +31,6 @@ export class CreateViewGroupPermissionGuard implements CanActivate {
: null;
}
- // For REST: extract from request body
if (!viewId && typeof request.body?.viewId === 'string') {
viewId = request.body.viewId;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-permission.guard.ts
index b7a482d8acc..c46bdec5227 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-permission.guard.ts
@@ -19,14 +19,12 @@ export class CreateViewPermissionGuard implements CanActivate {
let visibility: ViewVisibility = ViewVisibility.WORKSPACE;
- // For GraphQL: extract from args.input
const args = gqlContext.getArgs();
if (args?.input?.visibility) {
visibility = args.input.visibility as ViewVisibility;
}
- // For REST: extract from request body
if (!args?.input && request.body?.visibility) {
visibility = request.body.visibility as ViewVisibility;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-sort-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-sort-permission.guard.ts
index 33b4d5c7cbd..88aaa3c28f2 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-sort-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/create-view-sort-permission.guard.ts
@@ -17,14 +17,12 @@ export class CreateViewSortPermissionGuard implements CanActivate {
let viewId: string | null = null;
- // For GraphQL: extract from args.input
const args = gqlContext.getArgs();
if (typeof args?.input?.viewId === 'string') {
viewId = args.input.viewId;
}
- // For REST: extract from request body
if (!viewId && typeof request.body?.viewId === 'string') {
viewId = request.body.viewId;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-field-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-field-permission.guard.ts
index 9d6d967928e..377d14bfc05 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-field-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-field-permission.guard.ts
@@ -21,14 +21,12 @@ export class DeleteViewFieldPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.input.id
const args = gqlContext.getArgs();
if (typeof args?.input?.id === 'string') {
entityId = args.input.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-filter-group-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-filter-group-permission.guard.ts
index 1a31c1d8cd3..e7461eb5774 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-filter-group-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-filter-group-permission.guard.ts
@@ -21,14 +21,12 @@ export class DeleteViewFilterGroupPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.id
const args = gqlContext.getArgs();
if (typeof args?.id === 'string') {
entityId = args.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-filter-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-filter-permission.guard.ts
index 82312a22c5e..3d5f732cd54 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-filter-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-filter-permission.guard.ts
@@ -21,14 +21,12 @@ export class DeleteViewFilterPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.input.id
const args = gqlContext.getArgs();
if (typeof args?.input?.id === 'string') {
entityId = args.input.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-group-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-group-permission.guard.ts
index d36398a2794..c98bd1bfb8e 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-group-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-group-permission.guard.ts
@@ -21,14 +21,12 @@ export class DeleteViewGroupPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.input.id
const args = gqlContext.getArgs();
if (typeof args?.input?.id === 'string') {
entityId = args.input.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-permission.guard.ts
index a9324ce4b5d..13cd6316710 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-permission.guard.ts
@@ -17,14 +17,12 @@ export class DeleteViewPermissionGuard implements CanActivate {
let viewId: string | null = null;
- // For GraphQL: extract from args
const args = gqlContext.getArgs();
if (typeof args?.id === 'string') {
viewId = args.id;
}
- // For REST: extract from URL params
if (!viewId && typeof request.params?.id === 'string') {
viewId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-sort-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-sort-permission.guard.ts
index a69a7f59a4a..3d525699a63 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-sort-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/delete-view-sort-permission.guard.ts
@@ -21,14 +21,12 @@ export class DeleteViewSortPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.id
const args = gqlContext.getArgs();
if (typeof args?.id === 'string') {
entityId = args.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-field-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-field-permission.guard.ts
index 93e6c5c64fb..3e19b3f749c 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-field-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-field-permission.guard.ts
@@ -21,14 +21,12 @@ export class DestroyViewFieldPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.input.id
const args = gqlContext.getArgs();
if (typeof args?.input?.id === 'string') {
entityId = args.input.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-filter-group-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-filter-group-permission.guard.ts
index c8366416626..ec6f7a2f3cf 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-filter-group-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-filter-group-permission.guard.ts
@@ -21,14 +21,12 @@ export class DestroyViewFilterGroupPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.id
const args = gqlContext.getArgs();
if (typeof args?.id === 'string') {
entityId = args.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-filter-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-filter-permission.guard.ts
index ef88ae11f54..c5f135052b5 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-filter-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-filter-permission.guard.ts
@@ -21,14 +21,12 @@ export class DestroyViewFilterPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.input.id
const args = gqlContext.getArgs();
if (typeof args?.input?.id === 'string') {
entityId = args.input.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-group-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-group-permission.guard.ts
index b1c83a2da11..36848494c20 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-group-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-group-permission.guard.ts
@@ -21,14 +21,12 @@ export class DestroyViewGroupPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.input.id
const args = gqlContext.getArgs();
if (typeof args?.input?.id === 'string') {
entityId = args.input.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-permission.guard.ts
index d671f858df0..73a91e2f6a3 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-permission.guard.ts
@@ -17,14 +17,12 @@ export class DestroyViewPermissionGuard implements CanActivate {
let viewId: string | null = null;
- // For GraphQL: extract from args
const args = gqlContext.getArgs();
if (typeof args?.id === 'string') {
viewId = args.id;
}
- // For REST: extract from URL params
if (!viewId && typeof request.params?.id === 'string') {
viewId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-sort-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-sort-permission.guard.ts
index 9e3717e38ee..a212241f8e6 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-sort-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/destroy-view-sort-permission.guard.ts
@@ -21,14 +21,12 @@ export class DestroyViewSortPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.id
const args = gqlContext.getArgs();
if (typeof args?.id === 'string') {
entityId = args.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-field-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-field-permission.guard.ts
index 79e5e83c62a..9e4ef56e368 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-field-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-field-permission.guard.ts
@@ -21,14 +21,12 @@ export class UpdateViewFieldPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.input.id
const args = gqlContext.getArgs();
if (typeof args?.input?.id === 'string') {
entityId = args.input.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-filter-group-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-filter-group-permission.guard.ts
index 7280e5ca9d0..08a293e34cd 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-filter-group-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-filter-group-permission.guard.ts
@@ -21,14 +21,12 @@ export class UpdateViewFilterGroupPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.id
const args = gqlContext.getArgs();
if (typeof args?.id === 'string') {
entityId = args.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-filter-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-filter-permission.guard.ts
index 0f17eaccf56..14e41158ae8 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-filter-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-filter-permission.guard.ts
@@ -21,14 +21,12 @@ export class UpdateViewFilterPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.input.id
const args = gqlContext.getArgs();
if (typeof args?.input?.id === 'string') {
entityId = args.input.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-group-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-group-permission.guard.ts
index e2b7ceebe32..578ea68ffe9 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-group-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-group-permission.guard.ts
@@ -21,14 +21,12 @@ export class UpdateViewGroupPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.input.id
const args = gqlContext.getArgs();
if (typeof args?.input?.id === 'string') {
entityId = args.input.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-permission.guard.ts
index 81c803c42f7..24d54cb3013 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-permission.guard.ts
@@ -17,14 +17,12 @@ export class UpdateViewPermissionGuard implements CanActivate {
let viewId: string | null = null;
- // For GraphQL: extract from args
const args = gqlContext.getArgs();
if (typeof args?.id === 'string') {
viewId = args.id;
}
- // For REST: extract from URL params
if (!viewId && typeof request.params?.id === 'string') {
viewId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-sort-permission.guard.ts b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-sort-permission.guard.ts
index f75526014c8..0272648f7f6 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-sort-permission.guard.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-permissions/guards/update-view-sort-permission.guard.ts
@@ -21,14 +21,12 @@ export class UpdateViewSortPermissionGuard implements CanActivate {
let entityId = '';
- // For GraphQL: extract from args.id
const args = gqlContext.getArgs();
if (typeof args?.id === 'string') {
entityId = args.id;
}
- // For REST: extract from URL params
if (!entityId && typeof request.params?.id === 'string') {
entityId = request.params.id;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-sort/filters/view-sort-rest-api-exception.filter.ts b/packages/twenty-server/src/engine/metadata-modules/view-sort/filters/view-sort-rest-api-exception.filter.ts
index caac2915c1d..55e5ed2cad4 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-sort/filters/view-sort-rest-api-exception.filter.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-sort/filters/view-sort-rest-api-exception.filter.ts
@@ -69,7 +69,6 @@ export class ViewSortRestApiExceptionFilter implements ExceptionFilter {
}
}
- // Fallback for any other exception type
const unknownException = new UnknownException(
'Internal server error',
'INTERNAL_ERROR',
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/filters/view-rest-api-exception.filter.ts b/packages/twenty-server/src/engine/metadata-modules/view/filters/view-rest-api-exception.filter.ts
index e969aec36a5..564b35a3847 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/filters/view-rest-api-exception.filter.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/filters/view-rest-api-exception.filter.ts
@@ -75,7 +75,6 @@ export class ViewRestApiExceptionFilter implements ExceptionFilter {
}
}
- // Fallback for any other exception type
const unknownException = new UnknownException(
'Internal server error',
'INTERNAL_ERROR',
diff --git a/packages/twenty-server/src/engine/middlewares/middleware.service.ts b/packages/twenty-server/src/engine/middlewares/middleware.service.ts
index 274e1fa1b64..5b4977d8866 100644
--- a/packages/twenty-server/src/engine/middlewares/middleware.service.ts
+++ b/packages/twenty-server/src/engine/middlewares/middleware.service.ts
@@ -62,7 +62,6 @@ export class MiddlewareService {
public writeRestResponseOnExceptionCaught(res: Response, error: any) {
const statusCode = this.getStatus(error);
- // capture and handle custom exceptions
handleException({
exception: error as CustomException,
exceptionHandlerService: this.exceptionHandlerService,
diff --git a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts
index d10d35a7b4e..86fecf415a3 100644
--- a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts
@@ -426,7 +426,6 @@ describe('WorkspaceEntityManager', () => {
.fn()
.mockReturnValue(mockMetadata);
- // Reset the mock before each test
jest.clearAllMocks();
});
diff --git a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.ts b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.ts
index 4cb7554e9e1..9c03db51d63 100644
--- a/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.ts
@@ -550,7 +550,6 @@ export class WorkspaceEntityManager extends EntityManager {
);
}
- // create query builder and apply find options
return this.createQueryBuilder(
entityClass,
alias,
@@ -571,7 +570,6 @@ export class WorkspaceEntityManager extends EntityManager {
): Promise<Entity | null> {
const metadata = this.connection.getMetadata(entityClass);
- // create query builder and apply find options
return this.createQueryBuilder(
entityClass,
metadata.name,
@@ -1850,8 +1848,6 @@ export class WorkspaceEntityManager extends EntityManager {
return isEntityArray ? formattedResult : formattedResult[0];
}
- // Forbidden methods
-
// oxlint-disable-next-line typescript/no-explicit-any
override query<T = any>(_query: string, _parameters?: any[]): Promise<T> {
throw new PermissionsException(
diff --git a/packages/twenty-server/src/engine/twenty-orm/storage/__tests__/promise-memoizer.storage.spec.ts b/packages/twenty-server/src/engine/twenty-orm/storage/__tests__/promise-memoizer.storage.spec.ts
index c8f2fadb152..8d5e3619934 100644
--- a/packages/twenty-server/src/engine/twenty-orm/storage/__tests__/promise-memoizer.storage.spec.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/storage/__tests__/promise-memoizer.storage.spec.ts
@@ -8,19 +8,16 @@ describe('PromiseMemoizer', () => {
const TTL_MS = 1000; // 1 second TTL for testing
beforeAll(() => {
- // Store the original Date.now function
originalDateNow = Date.now;
});
afterAll(() => {
- // Restore the original Date.now function
global.Date.now = originalDateNow;
});
beforeEach(() => {
jest.clearAllMocks();
- // Start with a fixed timestamp
const currentTimestamp = 1000;
global.Date.now = jest.fn(() => currentTimestamp);
@@ -46,7 +43,6 @@ describe('PromiseMemoizer', () => {
await memoizer.memoizePromiseAndExecute('test-key-1', mockFactory);
- // Move time forward but still within TTL
const currentTime = Date.now();
jest
@@ -67,7 +63,6 @@ describe('PromiseMemoizer', () => {
await memoizer.memoizePromiseAndExecute('test-key-1', mockFactory);
- // Move time beyond TTL
const currentTime = Date.now();
jest
diff --git a/packages/twenty-server/src/engine/utils/global-exception-handler.util.ts b/packages/twenty-server/src/engine/utils/global-exception-handler.util.ts
index 1154d159f3b..031e03c94a0 100644
--- a/packages/twenty-server/src/engine/utils/global-exception-handler.util.ts
+++ b/packages/twenty-server/src/engine/utils/global-exception-handler.util.ts
@@ -153,7 +153,6 @@ const convertHttpExceptionToGraphql = (exception: HttpException) => {
);
}
- // Only show the stack trace in development mode
if (process.env.NODE_ENV === NodeEnvironment.DEVELOPMENT) {
error.stack = exception.stack;
error.extensions['response'] = exception.getResponse();
diff --git a/packages/twenty-server/src/engine/workspace-cache/services/workspace-cache.service.ts b/packages/twenty-server/src/engine/workspace-cache/services/workspace-cache.service.ts
index 57acfeae883..436cb7e3119 100644
--- a/packages/twenty-server/src/engine/workspace-cache/services/workspace-cache.service.ts
+++ b/packages/twenty-server/src/engine/workspace-cache/services/workspace-cache.service.ts
@@ -229,7 +229,6 @@ export class WorkspaceCacheService implements OnModuleInit, OnModuleDestroy {
keysNeedingDataFromRedis,
);
- // Stage 4: Recompute remaining
const keysToRecompute = [...keysNeedingRecompute, ...missingInRedis];
const recomputedEntries = await this.recomputeDataFromProvider(
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/generate-random-users.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/generate-random-users.util.ts
index 559a387ac85..e400151825a 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/generate-random-users.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/generate-random-users.util.ts
@@ -27,7 +27,6 @@ export type RandomWorkspaceMemberData = {
userId: string;
};
-// Hardcoded lists of realistic names
const FIRST_NAMES = [
'James',
'Mary',
@@ -476,7 +475,6 @@ export function generateRandomUsers(): {
const lastName = LAST_NAMES[lastNameIndex];
const email = `${firstName.toLowerCase()}.${lastName.toLowerCase()}${i}@apple.dev`;
- // Generate consistent UUIDs based on index
const userId =
`30303030-${i.toString().padStart(4, '0')}-4000-8000-000000000000`.replace(
/0{4}-4000-8000-000000000000$/,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds-v2.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds-v2.util.ts
index 094de864bfb..9c275c3f36f 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds-v2.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds-v2.util.ts
@@ -60,7 +60,6 @@ export const getPageLayoutWidgetDataSeedsV2 = (
const personJobTitleFieldId = getFieldId(personObject, 'jobTitle');
return [
- // LINE chart: Revenue Forecast (Sales Overview)
isDefined(opportunityAmountFieldId) &&
isDefined(opportunityCloseDateFieldId)
? ({
@@ -208,7 +207,6 @@ export const getPageLayoutWidgetDataSeedsV2 = (
} satisfies SeederFlatPageLayoutWidget)
: null,
- // PIE chart: Contact Roles (Team Metrics)
isDefined(personIdFieldId) && isDefined(personJobTitleFieldId)
? ({
id: generateSeedId(
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds.util.ts
index 3c9cfadc2fb..26f9bc4fb10 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/get-page-layout-widget-data-seeds.util.ts
@@ -148,7 +148,6 @@ export const getPageLayoutWidgetDataSeeds = (
const rocketCreatedAtFieldId = getFieldId(rocketObject, 'createdAt');
const v1Widgets: SeederFlatPageLayoutWidget[] = [
- // Sales Overview Tab Widgets
isDefined(opportunityAmountFieldId)
? ({
id: generateSeedId(
@@ -254,7 +253,6 @@ export const getPageLayoutWidgetDataSeeds = (
} satisfies SeederFlatPageLayoutWidget)
: null,
- // Sales Details Tab Widgets
isDefined(rocketIdFieldId) && isDefined(rocketCreatedAtFieldId)
? ({
id: generateSeedId(
@@ -325,7 +323,6 @@ export const getPageLayoutWidgetDataSeeds = (
} satisfies SeederFlatPageLayoutWidget)
: null,
- // Customer Overview Tab Widgets
isDefined(companyIdFieldId)
? ({
id: generateSeedId(
@@ -358,7 +355,6 @@ export const getPageLayoutWidgetDataSeeds = (
overrides: null,
} satisfies SeederFlatPageLayoutWidget)
: null,
- // Customer Analytics Tab Widgets
isDefined(companyAnnualRevenueFieldId)
? ({
id: generateSeedId(
@@ -424,7 +420,6 @@ export const getPageLayoutWidgetDataSeeds = (
} satisfies SeederFlatPageLayoutWidget)
: null,
- // Team Overview Tab Widgets
isDefined(personIdFieldId)
? ({
id: generateSeedId(workspaceId, PAGE_LAYOUT_WIDGET_SEEDS.TEAM_SIZE),
@@ -454,7 +449,6 @@ export const getPageLayoutWidgetDataSeeds = (
overrides: null,
} satisfies SeederFlatPageLayoutWidget)
: null,
- // Team Metrics Tab Widgets
isDefined(taskIdFieldId)
? ({
id: generateSeedId(
@@ -488,7 +482,6 @@ export const getPageLayoutWidgetDataSeeds = (
} satisfies SeederFlatPageLayoutWidget)
: null,
- // Sales Overview Tab Widgets - Front Component
{
id: generateSeedId(workspaceId, PAGE_LAYOUT_WIDGET_SEEDS.FRONT_COMPONENT),
pageLayoutTabId: generateSeedId(
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-agents.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-agents.util.ts
index 1c4aed3739d..aeec5310fdc 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-agents.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-agents.util.ts
@@ -326,7 +326,6 @@ const seedChatMessages = async ({
);
}
- // Create turns first
const turns = turnIds.map((id, index) => ({
id,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/attachment-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/attachment-data-seeds.constant.ts
index 8819ed5ecb3..d504a3a3426 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/attachment-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/attachment-data-seeds.constant.ts
@@ -96,7 +96,6 @@ export const ATTACHMENT_SAMPLE_FILES = [
];
const FILE_NAME_VARIATIONS = [
- // Documents
{ name: 'Service Agreement.pdf', sampleFileIndex: 0 },
{ name: 'NDA Document.pdf', sampleFileIndex: 0 },
{ name: 'Project Proposal.pdf', sampleFileIndex: 0 },
@@ -104,27 +103,23 @@ const FILE_NAME_VARIATIONS = [
{ name: 'Meeting Notes.pdf', sampleFileIndex: 0 },
{ name: 'Report Final.pdf', sampleFileIndex: 0 },
{ name: 'Contract Signed.pdf', sampleFileIndex: 0 },
- // Spreadsheets
{ name: 'Financial Forecast.xlsx', sampleFileIndex: 1 },
{ name: 'Sales Report Q4.xlsx', sampleFileIndex: 1 },
{ name: 'Team Roster.xlsx', sampleFileIndex: 1 },
{ name: 'Expense Report.xlsx', sampleFileIndex: 1 },
{ name: 'Inventory List.xlsx', sampleFileIndex: 1 },
{ name: 'Data Export.csv', sampleFileIndex: 1 },
- // Presentations
{ name: 'Pitch Deck.pptx', sampleFileIndex: 2 },
{ name: 'Q4 Results.pptx', sampleFileIndex: 2 },
{ name: 'Roadmap 2024.pptx', sampleFileIndex: 2 },
{ name: 'Company Overview.pptx', sampleFileIndex: 2 },
{ name: 'Training Materials.pptx', sampleFileIndex: 2 },
- // Images
{ name: 'Company Logo.png', sampleFileIndex: 3 },
{ name: 'Product Photo.jpg', sampleFileIndex: 3 },
{ name: 'Diagram.png', sampleFileIndex: 3 },
{ name: 'Wireframe.png', sampleFileIndex: 3 },
{ name: 'Mockup Design.png', sampleFileIndex: 3 },
{ name: 'Headshot.jpg', sampleFileIndex: 3 },
- // Archives
{ name: 'Project Files.zip', sampleFileIndex: 4 },
{ name: 'Backup Data.zip', sampleFileIndex: 4 },
{ name: 'Source Code.zip', sampleFileIndex: 4 },
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts
index 01537310570..84385d07350 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-channel-event-association-data-seeds.constant.ts
@@ -56,7 +56,6 @@ const GENERATE_CALENDAR_CHANNEL_EVENT_ASSOCIATION_SEEDS =
CALENDAR_CHANNEL_DATA_SEED_IDS.TEAM_CALENDAR,
];
- // Create associations for each event
EVENT_IDS.forEach((eventId, index) => {
// Distribute events across channels with weighted distribution
let CHANNEL_ID: string;
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts
index 4681fe21805..3cb7743e43e 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant.ts
@@ -184,7 +184,6 @@ const GENERATE_CALENDAR_EVENT_SEEDS = (): CalendarEventDataSeed[] => {
END_TIME.setMinutes(END_TIME.getMinutes() + TEMPLATE.duration);
}
- // Random location and conference solution
const LOCATION =
TEMPLATE.locations[Math.floor(Math.random() * TEMPLATE.locations.length)];
const CONFERENCE_SOLUTION =
@@ -192,7 +191,6 @@ const GENERATE_CALENDAR_EVENT_SEEDS = (): CalendarEventDataSeed[] => {
Math.floor(Math.random() * TEMPLATE.conferenceSolutions.length)
];
- // 5% chance of being cancelled
const IS_CANCELLED = Math.random() < 0.05;
// Generate conference link if it's an online meeting
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-participant-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-participant-data-seeds.constant.ts
index 9705fb39c95..3cbb2979a36 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-participant-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-participant-data-seeds.constant.ts
@@ -177,7 +177,6 @@ const CREATE_EVENT_PARTICIPANT_DATA = (
): EventParticipantData => {
const PARTICIPANT_TYPE = Math.random();
- // Try person participant (40% chance)
if (PARTICIPANT_TYPE < 0.4) {
const PERSON_PARTICIPANT = CREATE_PERSON_EVENT_PARTICIPANT(
personIds,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts
index 137ae8c2b4c..96afdc84a47 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-channel-message-association-data-seeds.constant.ts
@@ -93,7 +93,6 @@ const GENERATE_MESSAGE_CHANNEL_MESSAGE_ASSOCIATION_SEEDS =
? MessageDirection.INCOMING
: MessageDirection.OUTGOING;
- // Generate unique external IDs for email sync
const MESSAGE_EXTERNAL_ID = `msg-${ASSOCIATION_INDEX}-${Date.now()}`;
const MESSAGE_THREAD_EXTERNAL_ID = `thread-${Math.floor(ASSOCIATION_INDEX / 2)}-${Date.now()}`;
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-participant-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-participant-data-seeds.constant.ts
index 4926c9525d8..502b4b41b4a 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-participant-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-participant-data-seeds.constant.ts
@@ -194,7 +194,6 @@ const CREATE_PARTICIPANT_DATA = (
): ParticipantData => {
const PARTICIPANT_TYPE = Math.random();
- // Try person participant (40% chance)
if (PARTICIPANT_TYPE < 0.4) {
const PERSON_PARTICIPANT = CREATE_PERSON_PARTICIPANT(
personIds,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/note-target-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/note-target-data-seeds.constant.ts
index 8b73b19cf07..158760cef15 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/note-target-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/note-target-data-seeds.constant.ts
@@ -76,7 +76,6 @@ const GENERATE_NOTE_TARGET_SEEDS = (): NoteTargetDataSeed[] => {
export const NOTE_TARGET_DATA_SEEDS = GENERATE_NOTE_TARGET_SEEDS();
-// Map for O(1) lookups by note ID
export const NOTE_TARGET_DATA_SEEDS_MAP = new Map<string, NoteTargetDataSeed>(
NOTE_TARGET_DATA_SEEDS.filter((target) => target.noteId !== null).map(
(target) => [target.noteId!, target],
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/person-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/person-data-seeds.constant.ts
index f01a80b306f..d3639f66b2b 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/person-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/person-data-seeds.constant.ts
@@ -20490,7 +20490,6 @@ export const PERSON_DATA_SEEDS: PersonDataSeed[] = PERSON_DATA_SEEDS_RAW.map(
},
);
-// Map for O(1) lookups by person ID
export const PERSON_DATA_SEEDS_MAP = new Map<string, PersonDataSeed>(
PERSON_DATA_SEEDS.map((p) => [p.id, p]),
);
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-target-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-target-data-seeds.constant.ts
index 7d78ef1a07a..907efed39f6 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-target-data-seeds.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/task-target-data-seeds.constant.ts
@@ -80,7 +80,6 @@ const GENERATE_TASK_TARGET_SEEDS = (): TaskTargetDataSeed[] => {
export const TASK_TARGET_DATA_SEEDS = GENERATE_TASK_TARGET_SEEDS();
-// Map for O(1) lookups by task ID
export const TASK_TARGET_DATA_SEEDS_MAP = new Map<string, TaskTargetDataSeed>(
TASK_TARGET_DATA_SEEDS.filter((target) => target.taskId !== null).map(
(target) => [target.taskId!, target],
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/dev-seeder-data.service.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/dev-seeder-data.service.ts
index 4d4bdafb8a1..df085da24b8 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/dev-seeder-data.service.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/dev-seeder-data.service.ts
@@ -198,7 +198,6 @@ const getRecordSeedsBatches = (
pgColumns: MESSAGE_THREAD_DATA_SEED_COLUMNS,
recordSeeds: MESSAGE_THREAD_DATA_SEEDS,
},
- // Junction tables
{
tableName: '_employmentHistory',
pgColumns: EMPLOYMENT_HISTORY_DATA_SEED_COLUMNS,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/timeline-activity-seeder.service.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/timeline-activity-seeder.service.ts
index 8b240fa399b..2cc3c57578f 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/timeline-activity-seeder.service.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/timeline-activity-seeder.service.ts
@@ -128,7 +128,6 @@ export class TimelineActivitySeederService {
schemaName: string;
workspaceId: string;
}) {
- // Get workspace-specific participant data
const calendarEventParticipants =
getCalendarEventParticipantDataSeeds(workspaceId);
const messageParticipants = getMessageParticipantDataSeeds(workspaceId);
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/metadata/services/dev-seeder-metadata.service.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/metadata/services/dev-seeder-metadata.service.ts
index 0f21e7ad592..b8d84e13d09 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/metadata/services/dev-seeder-metadata.service.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/metadata/services/dev-seeder-metadata.service.ts
@@ -81,7 +81,6 @@ export class DevSeederMetadataService {
seed: SURVEY_RESULT_CUSTOM_OBJECT_SEED,
fields: SURVEY_RESULT_CUSTOM_FIELD_SEEDS,
},
- // Junction objects (minimal pivots)
{ seed: EMPLOYMENT_HISTORY_CUSTOM_OBJECT_SEED },
{ seed: PET_CARE_AGREEMENT_CUSTOM_OBJECT_SEED },
],
@@ -100,7 +99,6 @@ export class DevSeederMetadataService {
},
],
junctionFields: [
- // Employment History: Person <-> Company
{
sourceObjectName: 'person',
name: 'previousCompanies',
@@ -119,7 +117,6 @@ export class DevSeederMetadataService {
targetFieldLabel: 'Company',
targetFieldIcon: 'IconBuildingSkyscraper',
},
- // Pet Care Agreement: Pet -> caretakers
{
sourceObjectName: PET_CUSTOM_OBJECT_SEED.nameSingular,
name: 'caretakers',
@@ -131,7 +128,6 @@ export class DevSeederMetadataService {
},
],
junctionConfigs: [
- // Employment History junction configs
{
objectName: 'person',
fieldName: 'previousCompanies',
@@ -142,7 +138,6 @@ export class DevSeederMetadataService {
fieldName: 'previousEmployees',
junctionTargetFieldRef: `${EMPLOYMENT_HISTORY_CUSTOM_OBJECT_SEED.nameSingular}.person`,
},
- // Pet Care Agreement junction configs
{
objectName: PET_CUSTOM_OBJECT_SEED.nameSingular,
fieldName: 'caretakers',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-attachment-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-attachment-standard-flat-field-metadata.util.ts
index b14872dcc3b..cf7948ae531 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-attachment-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-attachment-standard-flat-field-metadata.util.ts
@@ -26,7 +26,6 @@ export const buildAttachmentStandardFlatFieldMetadatas = ({
CreateStandardFieldArgs<'attachment', FieldMetadataType>,
'context'
>): Record<AllStandardObjectFieldName<'attachment'>, FlatFieldMetadata> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
@@ -112,7 +111,6 @@ export const buildAttachmentStandardFlatFieldMetadatas = ({
now,
}),
- // Attachment-specific fields
name: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-blocklist-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-blocklist-standard-flat-field-metadata.util.ts
index 44053fe9380..6832062f496 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-blocklist-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-blocklist-standard-flat-field-metadata.util.ts
@@ -25,7 +25,6 @@ export const buildBlocklistStandardFlatFieldMetadatas = ({
CreateStandardFieldArgs<'blocklist', FieldMetadataType>,
'context'
>): Record<AllStandardObjectFieldName<'blocklist'>, FlatFieldMetadata> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
@@ -194,7 +193,6 @@ export const buildBlocklistStandardFlatFieldMetadatas = ({
now,
}),
- // Blocklist-specific fields
handle: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-company-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-company-standard-flat-field-metadata.util.ts
index 2594e969f3b..1c352c338c0 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-company-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-company-standard-flat-field-metadata.util.ts
@@ -26,7 +26,6 @@ export const buildCompanyStandardFlatFieldMetadatas = ({
CreateStandardFieldArgs<'company', FieldMetadataType>,
'context'
>): Record<AllStandardObjectFieldName<'company'>, FlatFieldMetadata> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
@@ -112,7 +111,6 @@ export const buildCompanyStandardFlatFieldMetadatas = ({
now,
}),
- // Company-specific fields
name: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-dashboard-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-dashboard-standard-flat-field-metadata.util.ts
index 6410d781a94..9b0340e41fd 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-dashboard-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-dashboard-standard-flat-field-metadata.util.ts
@@ -25,7 +25,6 @@ export const buildDashboardStandardFlatFieldMetadatas = ({
CreateStandardFieldArgs<'dashboard', FieldMetadataType>,
'context'
>): Record<AllStandardObjectFieldName<'dashboard'>, FlatFieldMetadata> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
@@ -105,7 +104,6 @@ export const buildDashboardStandardFlatFieldMetadatas = ({
now,
}),
- // Dashboard-specific fields
title: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-note-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-note-standard-flat-field-metadata.util.ts
index e88014059e3..fb2c27b5e17 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-note-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-note-standard-flat-field-metadata.util.ts
@@ -25,7 +25,6 @@ export const buildNoteStandardFlatFieldMetadatas = ({
AllStandardObjectFieldName<'note'>,
FlatFieldMetadata
> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
@@ -111,7 +110,6 @@ export const buildNoteStandardFlatFieldMetadatas = ({
now,
}),
- // Note-specific fields
position: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-note-target-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-note-target-standard-flat-field-metadata.util.ts
index 0c4a7ebcf41..463c0a251fd 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-note-target-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-note-target-standard-flat-field-metadata.util.ts
@@ -26,7 +26,6 @@ export const buildNoteTargetStandardFlatFieldMetadatas = ({
CreateStandardFieldArgs<'noteTarget', FieldMetadataType>,
'context'
>): Record<AllStandardObjectFieldName<'noteTarget'>, FlatFieldMetadata> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-opportunity-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-opportunity-standard-flat-field-metadata.util.ts
index f4195640aa1..fe30cfbfd3c 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-opportunity-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-opportunity-standard-flat-field-metadata.util.ts
@@ -26,7 +26,6 @@ export const buildOpportunityStandardFlatFieldMetadatas = ({
CreateStandardFieldArgs<'opportunity', FieldMetadataType>,
'context'
>): Record<AllStandardObjectFieldName<'opportunity'>, FlatFieldMetadata> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
@@ -112,7 +111,6 @@ export const buildOpportunityStandardFlatFieldMetadatas = ({
now,
}),
- // Opportunity-specific fields
name: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-person-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-person-standard-flat-field-metadata.util.ts
index c417334ff3a..ff13f54c7ac 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-person-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-person-standard-flat-field-metadata.util.ts
@@ -28,7 +28,6 @@ export const buildPersonStandardFlatFieldMetadatas = ({
CreateStandardFieldArgs<'person', FieldMetadataType>,
'context'
>): Record<AllStandardObjectFieldName<'person'>, FlatFieldMetadata> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
@@ -114,7 +113,6 @@ export const buildPersonStandardFlatFieldMetadatas = ({
now,
}),
- // Person-specific fields
name: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-task-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-task-standard-flat-field-metadata.util.ts
index c01f4a327d9..5465b72138a 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-task-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-task-standard-flat-field-metadata.util.ts
@@ -26,7 +26,6 @@ export const buildTaskStandardFlatFieldMetadatas = ({
AllStandardObjectFieldName<'task'>,
FlatFieldMetadata
> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
@@ -112,7 +111,6 @@ export const buildTaskStandardFlatFieldMetadatas = ({
now,
}),
- // Task-specific fields
position: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-task-target-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-task-target-standard-flat-field-metadata.util.ts
index f8acbff5670..1b7871e7b79 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-task-target-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-task-target-standard-flat-field-metadata.util.ts
@@ -26,7 +26,6 @@ export const buildTaskTargetStandardFlatFieldMetadatas = ({
CreateStandardFieldArgs<'taskTarget', FieldMetadataType>,
'context'
>): Record<AllStandardObjectFieldName<'taskTarget'>, FlatFieldMetadata> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-timeline-activity-standard-flat-field-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-timeline-activity-standard-flat-field-metadata.util.ts
index 0726e6eeffb..bb8491a13ec 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-timeline-activity-standard-flat-field-metadata.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-timeline-activity-standard-flat-field-metadata.util.ts
@@ -29,7 +29,6 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
AllStandardObjectFieldName<'timelineActivity'>,
FlatFieldMetadata
> => ({
- // Base fields from BaseWorkspaceEntity
id: createStandardFieldFlatMetadata({
objectName,
workspaceId,
@@ -174,7 +173,6 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
- // TimelineActivity-specific fields
happensAt: createStandardFieldFlatMetadata({
objectName,
workspaceId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-company-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-company-view-fields.util.ts
index 5c264ea0eb7..5814f84bc74 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-company-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-company-view-fields.util.ts
@@ -203,7 +203,6 @@ export const computeStandardCompanyViewFields = (
viewFieldGroupName: 'general',
},
}),
- // Business group
companyRecordPageFieldsAnnualRevenue: createStandardViewFieldFlatMetadata({
...args,
objectName: 'company',
@@ -217,7 +216,6 @@ export const computeStandardCompanyViewFields = (
viewFieldGroupName: 'business',
},
}),
- // Contact group
companyRecordPageFieldsAddress: createStandardViewFieldFlatMetadata({
...args,
objectName: 'company',
@@ -244,7 +242,6 @@ export const computeStandardCompanyViewFields = (
viewFieldGroupName: 'contact',
},
}),
- // System group
companyRecordPageFieldsCreatedAt: createStandardViewFieldFlatMetadata({
...args,
objectName: 'company',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-target-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-target-view-fields.util.ts
index 33158bd8d79..2ecb561691e 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-target-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-target-view-fields.util.ts
@@ -8,7 +8,6 @@ export const computeStandardNoteTargetViewFields = (
args: Omit<CreateStandardViewFieldArgs<'noteTarget'>, 'context'>,
): Record<string, FlatViewField> => {
return {
- // Label identifier for junction tables
allNoteTargetsId: createStandardViewFieldFlatMetadata({
...args,
objectName: 'noteTarget',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-view-fields.util.ts
index d19003ab590..3e8a8d751da 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-note-view-fields.util.ts
@@ -125,7 +125,6 @@ export const computeStandardNoteViewFields = (
},
},
),
- // System group
noteRecordPageFieldsCreatedAt: createStandardViewFieldFlatMetadata({
...args,
objectName: 'note',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-opportunity-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-opportunity-view-fields.util.ts
index 5a47c38e8c4..d1032674431 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-opportunity-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-opportunity-view-fields.util.ts
@@ -258,7 +258,6 @@ export const computeStandardOpportunityViewFields = (
viewFieldGroupName: 'deal',
},
}),
- // Relations group
opportunityRecordPageFieldsCompany: createStandardViewFieldFlatMetadata({
...args,
objectName: 'opportunity',
@@ -299,7 +298,6 @@ export const computeStandardOpportunityViewFields = (
viewFieldGroupName: 'relations',
},
}),
- // System group
opportunityRecordPageFieldsCreatedAt: createStandardViewFieldFlatMetadata({
...args,
objectName: 'opportunity',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts
index 3f7dd3609c9..4945a5736be 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts
@@ -259,7 +259,6 @@ export const computeStandardPersonViewFields = (
viewFieldGroupName: 'general',
},
}),
- // Work group
personRecordPageFieldsCompany: createStandardViewFieldFlatMetadata({
...args,
objectName: 'person',
@@ -286,7 +285,6 @@ export const computeStandardPersonViewFields = (
viewFieldGroupName: 'work',
},
}),
- // Social group
personRecordPageFieldsLinkedinLink: createStandardViewFieldFlatMetadata({
...args,
objectName: 'person',
@@ -300,7 +298,6 @@ export const computeStandardPersonViewFields = (
viewFieldGroupName: 'social',
},
}),
- // System group
personRecordPageFieldsCreatedAt: createStandardViewFieldFlatMetadata({
...args,
objectName: 'person',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-target-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-target-view-fields.util.ts
index 85dd70223ea..e75f0659f25 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-target-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-target-view-fields.util.ts
@@ -8,7 +8,6 @@ export const computeStandardTaskTargetViewFields = (
args: Omit<CreateStandardViewFieldArgs<'taskTarget'>, 'context'>,
): Record<string, FlatViewField> => {
return {
- // Label identifier for junction tables
allTaskTargetsId: createStandardViewFieldFlatMetadata({
...args,
objectName: 'taskTarget',
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-view-fields.util.ts
index 7c635682a80..0340e77e105 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-view-fields.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-task-view-fields.util.ts
@@ -346,7 +346,6 @@ export const computeStandardTaskViewFields = (
},
},
),
- // System group
taskRecordPageFieldsCreatedAt: createStandardViewFieldFlatMetadata({
...args,
objectName: 'task',
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/extract-jsonb-properties.type-test.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/extract-jsonb-properties.type-test.ts
index fb409c14ed3..558a162f205 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/extract-jsonb-properties.type-test.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/extract-jsonb-properties.type-test.ts
@@ -5,7 +5,6 @@ import { type ExtractJsonbProperties } from 'src/engine/workspace-manager/worksp
import { type JsonbProperty } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/jsonb-property.type';
type TestedRecord = {
- // Non-JsonbProperty fields
plainString: string;
plainNumber: number;
plainObject: EmptyObject;
@@ -17,7 +16,6 @@ type TestedRecord = {
jsonbNumber: JsonbProperty<number>;
jsonbull: JsonbProperty<null>;
- // JsonbProperty fields - should be extracted
jsonbPlainObject: JsonbProperty<EmptyObject>;
jsonbPlainArray: JsonbProperty<string[]>;
jsonbPlainObjectNullable: JsonbProperty<EmptyObject | null>;
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/format-record-serialized-relation-properties.test-type.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/format-record-serialized-relation-properties.test-type.ts
index fd0a22d3fa8..79197fee51c 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/format-record-serialized-relation-properties.test-type.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/format-record-serialized-relation-properties.test-type.ts
@@ -43,7 +43,6 @@ type ObjectAssertions = [
>
>,
- // Object without SerializedRelation: no changes
Expect<
Equal<
FormatRecordSerializedRelationProperties<ObjectWithoutRelation>,
@@ -54,11 +53,9 @@ type ObjectAssertions = [
// oxlint-disable-next-line unused-imports/no-unused-vars
type PrimitiveAssertions = [
- // Primitives pass through unchanged
Expect<Equal<FormatRecordSerializedRelationProperties<string>, string>>,
Expect<Equal<FormatRecordSerializedRelationProperties<number>, number>>,
Expect<Equal<FormatRecordSerializedRelationProperties<null>, null>>,
- // SerializedRelation becomes nullable
Expect<
Equal<
FormatRecordSerializedRelationProperties<SerializedRelation>,
@@ -88,7 +85,6 @@ type ArrayAssertions = [
>
>,
- // Array of primitives: passes through unchanged
Expect<Equal<FormatRecordSerializedRelationProperties<string[]>, string[]>>,
// Nested array of objects: transforms innermost elements
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/jsonb-property.type-test.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/jsonb-property.type-test.ts
index 5a22925527a..3008d0a8594 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/jsonb-property.type-test.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/jsonb-property.type-test.ts
@@ -22,7 +22,6 @@ type PrimitiveAssertions = [
// oxlint-disable-next-line unused-imports/no-unused-vars
type ObjectAssertions = [
- // Objects get branded
Expect<
Equal<
JsonbProperty<SimpleObject>,
@@ -85,7 +84,6 @@ type UnionAssertions = [
>
>,
- // Array in union: array gets branded
Expect<
Equal<
JsonbProperty<SimpleObject[] | null>,
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-non-relation-fields-into-object-actions.util.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-non-relation-fields-into-object-actions.util.spec.ts
index a2e296d4944..a7c51c07e00 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-non-relation-fields-into-object-actions.util.spec.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/__tests__/aggregate-non-relation-fields-into-object-actions.util.spec.ts
@@ -57,7 +57,6 @@ describe('aggregateNonRelationFieldsIntoObjectActions', () => {
orchestratorActionsReport: input,
});
- // Field should be merged into object action
expect(result.objectMetadata.create).toMatchObject([
{
universalFlatFieldMetadatas: [
@@ -69,7 +68,6 @@ describe('aggregateNonRelationFieldsIntoObjectActions', () => {
},
]);
- // No remaining field actions
expect(result.fieldMetadata.create).toHaveLength(0);
});
@@ -124,12 +122,10 @@ describe('aggregateNonRelationFieldsIntoObjectActions', () => {
orchestratorActionsReport: input,
});
- // Object action should have no fields merged
expect(result.objectMetadata.create).toMatchObject([
{ universalFlatFieldMetadatas: [] },
]);
- // Relation field should remain in field actions
expect(result.fieldMetadata.create).toMatchObject([
{
flatEntity: { universalIdentifier: relationFieldUniversalId },
@@ -174,7 +170,6 @@ describe('aggregateNonRelationFieldsIntoObjectActions', () => {
orchestratorActionsReport: input,
});
- // No object actions
expect(result.objectMetadata.create).toHaveLength(0);
// Field should remain in field actions (no matching object to merge into)
@@ -259,7 +254,6 @@ describe('aggregateNonRelationFieldsIntoObjectActions', () => {
},
]);
- // Relation field should remain in field actions
expect(result.fieldMetadata.create).toMatchObject([
{
flatEntity: { universalIdentifier: relationFieldUniversalId },
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/compute-ordered-migration-actions.util.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/compute-ordered-migration-actions.util.ts
index d3f7fe9886c..466b26e4c08 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/compute-ordered-migration-actions.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/compute-ordered-migration-actions.util.ts
@@ -8,9 +8,7 @@ export const computeOrderedMigrationActions = (
...aggregatedOrchestratorActionsReport.searchFieldMetadata.delete,
...aggregatedOrchestratorActionsReport.searchFieldMetadata.create,
...aggregatedOrchestratorActionsReport.searchFieldMetadata.update,
- ///
- // Object and fields and indexes
...aggregatedOrchestratorActionsReport.index.delete,
...aggregatedOrchestratorActionsReport.fieldMetadata.delete,
...aggregatedOrchestratorActionsReport.objectMetadata.delete,
@@ -20,9 +18,7 @@ export const computeOrderedMigrationActions = (
...aggregatedOrchestratorActionsReport.fieldMetadata.update,
...aggregatedOrchestratorActionsReport.index.create,
...aggregatedOrchestratorActionsReport.index.update.flat(),
- ///
- // Views
...aggregatedOrchestratorActionsReport.view.create,
...aggregatedOrchestratorActionsReport.view.update,
...aggregatedOrchestratorActionsReport.viewField.delete,
@@ -44,42 +40,32 @@ export const computeOrderedMigrationActions = (
...aggregatedOrchestratorActionsReport.viewSort.update,
...aggregatedOrchestratorActionsReport.viewSort.delete,
...aggregatedOrchestratorActionsReport.view.delete,
- ///
...aggregatedOrchestratorActionsReport.logicFunction.delete,
...aggregatedOrchestratorActionsReport.logicFunction.create,
...aggregatedOrchestratorActionsReport.logicFunction.update,
- ///
- // Roles
...aggregatedOrchestratorActionsReport.role.delete,
...aggregatedOrchestratorActionsReport.role.create,
...aggregatedOrchestratorActionsReport.role.update,
- ///
// Role targets delete before agents (roleTarget may FK to agent)
...aggregatedOrchestratorActionsReport.roleTarget.delete,
- ///
...aggregatedOrchestratorActionsReport.agent.delete,
...aggregatedOrchestratorActionsReport.agent.create,
...aggregatedOrchestratorActionsReport.agent.update,
- ///
- // Role targets create/update after agents exist
...aggregatedOrchestratorActionsReport.roleTarget.create,
...aggregatedOrchestratorActionsReport.roleTarget.update,
- ///
...aggregatedOrchestratorActionsReport.objectPermission.delete,
...aggregatedOrchestratorActionsReport.objectPermission.create,
...aggregatedOrchestratorActionsReport.objectPermission.update,
- ///
...aggregatedOrchestratorActionsReport.fieldPermission.delete,
...aggregatedOrchestratorActionsReport.fieldPermission.create,
...aggregatedOrchestratorActionsReport.fieldPermission.update,
- ///
// Permission flag definitions and their role assignments.
...aggregatedOrchestratorActionsReport.rolePermissionFlag.delete,
@@ -88,43 +74,34 @@ export const computeOrderedMigrationActions = (
...aggregatedOrchestratorActionsReport.rolePermissionFlag.create,
...aggregatedOrchestratorActionsReport.permissionFlag.update,
...aggregatedOrchestratorActionsReport.rolePermissionFlag.update,
- ///
- // Skills
...aggregatedOrchestratorActionsReport.skill.delete,
...aggregatedOrchestratorActionsReport.skill.create,
...aggregatedOrchestratorActionsReport.skill.update,
- ///
...aggregatedOrchestratorActionsReport.frontComponent.delete,
...aggregatedOrchestratorActionsReport.frontComponent.create,
...aggregatedOrchestratorActionsReport.frontComponent.update,
- ///
...aggregatedOrchestratorActionsReport.commandMenuItem.delete,
...aggregatedOrchestratorActionsReport.commandMenuItem.create,
...aggregatedOrchestratorActionsReport.commandMenuItem.update,
- ///
...aggregatedOrchestratorActionsReport.pageLayout.delete,
...aggregatedOrchestratorActionsReport.pageLayout.create,
...aggregatedOrchestratorActionsReport.pageLayout.update,
- ///
...aggregatedOrchestratorActionsReport.pageLayoutTab.delete,
...aggregatedOrchestratorActionsReport.pageLayoutTab.create,
...aggregatedOrchestratorActionsReport.pageLayoutTab.update,
- ///
...aggregatedOrchestratorActionsReport.pageLayoutWidget.delete,
...aggregatedOrchestratorActionsReport.pageLayoutWidget.create,
...aggregatedOrchestratorActionsReport.pageLayoutWidget.update,
- ///
...aggregatedOrchestratorActionsReport.navigationMenuItem.delete,
...aggregatedOrchestratorActionsReport.navigationMenuItem.create,
...aggregatedOrchestratorActionsReport.navigationMenuItem.update,
- ///
...aggregatedOrchestratorActionsReport.rowLevelPermissionPredicateGroup
.delete,
@@ -132,18 +109,14 @@ export const computeOrderedMigrationActions = (
.create,
...aggregatedOrchestratorActionsReport.rowLevelPermissionPredicateGroup
.update,
- ///
...aggregatedOrchestratorActionsReport.rowLevelPermissionPredicate.delete,
...aggregatedOrchestratorActionsReport.rowLevelPermissionPredicate.create,
...aggregatedOrchestratorActionsReport.rowLevelPermissionPredicate.update,
- ///
- // Webhooks
...aggregatedOrchestratorActionsReport.webhook.delete,
...aggregatedOrchestratorActionsReport.webhook.create,
...aggregatedOrchestratorActionsReport.webhook.update,
- ///
...aggregatedOrchestratorActionsReport.applicationVariable.delete,
...aggregatedOrchestratorActionsReport.applicationVariable.create,
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/validate-flat-entity-circular-dependency.util.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/validate-flat-entity-circular-dependency.util.ts
index 5ed5d048878..d40f492c058 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/validate-flat-entity-circular-dependency.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/utils/validate-flat-entity-circular-dependency.util.ts
@@ -36,7 +36,6 @@ export const validateFlatEntityCircularDependency = <
parentUniversalIdentifierKey: K;
flatEntityMaps: UniversalFlatEntityMaps<T>;
}): CircularDependencyValidationResult => {
- // Direct self-reference check
if (flatEntityUniversalIdentifier === flatEntityParentUniversalIdentifier) {
return {
status: 'fail',
@@ -59,7 +58,6 @@ export const validateFlatEntityCircularDependency = <
};
}
- // Check for circular dependency
if (currentParentUniversalIdentifier === flatEntityUniversalIdentifier) {
return {
status: 'fail',
@@ -99,7 +97,6 @@ export const validateFlatEntityCircularDependency = <
depth++;
}
- // Check max depth for the final depth value
if (isDefined(maxDepth) && depth > maxDepth) {
return {
status: 'fail',
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-field-metadata-validator.service.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-field-metadata-validator.service.ts
index 507d4096fbe..66b83d75190 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-field-metadata-validator.service.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-field-metadata-validator.service.ts
@@ -160,7 +160,6 @@ export class FlatFieldMetadataValidatorService {
});
}
}
- ///
if (isDefined(flatEntityUpdate.name)) {
validationResult.errors.push(
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/index/services/update-index-action-handler.service.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/index/services/update-index-action-handler.service.ts
index a99ed69b6d6..3608874cd2e 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/index/services/update-index-action-handler.service.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/action-handlers/index/services/update-index-action-handler.service.ts
@@ -110,7 +110,6 @@ export class UpdateIndexActionHandlerService extends WorkspaceMigrationRunnerAct
const { entityId, updatedFlatIndex } = flatAction;
- // Get the old index to drop it
const flatIndexMetadataToDelete = findFlatEntityByIdInFlatEntityMapsOrThrow(
{
flatEntityId: entityId,
@@ -127,7 +126,6 @@ export class UpdateIndexActionHandlerService extends WorkspaceMigrationRunnerAct
schemaName,
});
- // Create new index
const flatObjectMetadata = findFlatEntityByIdInFlatEntityMapsOrThrow({
flatEntityMaps: flatObjectMetadataMaps,
flatEntityId: updatedFlatIndex.objectMetadataId,
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/workspace-schema-enum-operations.util.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/workspace-schema-enum-operations.util.spec.ts
index d6588b4d0b1..623adbc68fd 100644
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/workspace-schema-enum-operations.util.spec.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/utils/__tests__/workspace-schema-enum-operations.util.spec.ts
@@ -48,7 +48,6 @@ describe('WorkspaceSchemaEnumOperations', () => {
},
];
- // Simulate failure on second enum
(mockSchemaManagerService.enumManager.createEnum as jest.Mock)
.mockResolvedValueOnce(undefined)
.mockRejectedValueOnce(new Error('Enum collision'))
diff --git a/packages/twenty-server/src/instrument.ts b/packages/twenty-server/src/instrument.ts
index 67dc40b8f71..7d9e0db1521 100644
--- a/packages/twenty-server/src/instrument.ts
+++ b/packages/twenty-server/src/instrument.ts
@@ -115,8 +115,6 @@ if (process.env.EXCEPTION_HANDLER_DRIVER === ExceptionHandlerDriver.SENTRY) {
});
}
-// Meter setup
-
const prometheusExporter = meterDrivers.includes(MeterDriver.Prometheus)
? new PrometheusExporter({ port: 9464 })
: null;
diff --git a/packages/twenty-server/src/main.ts b/packages/twenty-server/src/main.ts
index 0ceae3dc602..56568385e75 100644
--- a/packages/twenty-server/src/main.ts
+++ b/packages/twenty-server/src/main.ts
@@ -28,7 +28,6 @@ import { settings } from './engine/constants/settings';
import { enableValidationMetadataCache } from './utils/enable-validation-metadata-cache.util';
import { generateFrontConfig } from './utils/generate-front-config';
-// Trigger
const bootstrap = async () => {
enableValidationMetadataCache();
setPgDateTypeParser();
@@ -75,7 +74,6 @@ const bootstrap = async () => {
// Apply class-validator container so that we can use injection in validators
useContainer(app.select(AppModule), { fallbackOnErrors: true });
- // Use our logger
app.useLogger(logger);
app.useBodyParser('json', { limit: settings.storage.maxFileSize });
@@ -85,7 +83,6 @@ const bootstrap = async () => {
});
app.useBodyParser('text', { type: 'text/plain', limit: '1024kb' });
- // Graphql file upload
app.use(
`/${ApiPath.GraphQL}`,
graphqlUploadExpress({
@@ -102,7 +99,6 @@ const bootstrap = async () => {
}),
);
- // Inject the server url in the frontend page
generateFrontConfig();
const keepAliveTimeout = twentyConfigService.get(
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/google-calendar/utils/format-google-calendar-event.util.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/google-calendar/utils/format-google-calendar-event.util.ts
index 2fdd5ee7154..649cbb62e79 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/google-calendar/utils/format-google-calendar-event.util.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/google-calendar/utils/format-google-calendar-event.util.ts
@@ -26,7 +26,6 @@ const formatGoogleCalendarEvent = (
}
};
- // Create the event object
const calendarEvent: FetchedCalendarEvent = {
title: event.summary ?? '',
isCanceled: event.status === 'cancelled',
diff --git a/packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts b/packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts
index cae3a4eb084..89f202fe8a7 100644
--- a/packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts
+++ b/packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts
@@ -15,13 +15,11 @@ import { type TimelineActivityWorkspaceEntity } from 'src/modules/timeline/stand
import { type WorkspaceMemberWorkspaceEntity } from 'src/modules/workspace-member/standard-objects/workspace-member.workspace-entity';
export class CompanyWorkspaceEntity {
- // Base fields
id: string;
createdAt: string;
updatedAt: string;
deletedAt: string | null;
- // Company-specific fields
name: string | null;
domainName: LinksMetadata;
linkedinLink: LinksMetadata | null;
@@ -34,7 +32,6 @@ export class CompanyWorkspaceEntity {
addressOld: string | null;
searchVector: string;
- // Relations
people: EntityRelation<PersonWorkspaceEntity[]>;
accountOwner: EntityRelation<WorkspaceMemberWorkspaceEntity> | null;
accountOwnerId: string | null;
diff --git a/packages/twenty-server/src/modules/dashboard/chart-data/utils/__tests__/compare-dimension-values.util.spec.ts b/packages/twenty-server/src/modules/dashboard/chart-data/utils/__tests__/compare-dimension-values.util.spec.ts
index d55c0f14042..207fee2dadc 100644
--- a/packages/twenty-server/src/modules/dashboard/chart-data/utils/__tests__/compare-dimension-values.util.spec.ts
+++ b/packages/twenty-server/src/modules/dashboard/chart-data/utils/__tests__/compare-dimension-values.util.spec.ts
@@ -215,7 +215,6 @@ describe('compareDimensionValues', () => {
direction: 'ASC',
});
- // Uses localeCompare on formatted values
expect(result).toBeLessThan(0);
});
});
diff --git a/packages/twenty-server/src/modules/dashboard/tools/schemas/widget.schema.ts b/packages/twenty-server/src/modules/dashboard/tools/schemas/widget.schema.ts
index 5c84036fe00..228f909856f 100644
--- a/packages/twenty-server/src/modules/dashboard/tools/schemas/widget.schema.ts
+++ b/packages/twenty-server/src/modules/dashboard/tools/schemas/widget.schema.ts
@@ -332,7 +332,6 @@ const aggregateChartConfigSchema = aggregateChartConfigSchemaBase.extend({
const aggregateChartConfigSchemaWithoutDefaults =
aggregateChartConfigSchemaBase;
-// Graph configuration schema for BAR charts
const barChartConfigSchemaCore = z.object({
configurationType: z.literal(WidgetConfigurationType.BAR_CHART),
aggregateFieldMetadataId: z
@@ -509,7 +508,6 @@ const lineChartConfigSchema = withRangeMinMaxRefinement(
),
);
-// Graph configuration schema for PIE charts
const pieChartConfigSchemaCore = z.object({
configurationType: z.literal(WidgetConfigurationType.PIE_CHART),
aggregateFieldMetadataId: z
@@ -582,7 +580,6 @@ const recordTableConfigSchema = z.object({
.describe('Maximum number of records displayed in the table widget.'),
});
-// Iframe configuration
const iframeConfigSchema = z.object({
configurationType: z.literal(WidgetConfigurationType.IFRAME),
url: z.string().url().optional().describe('URL to embed'),
@@ -658,5 +655,4 @@ export const widgetConfigurationSchemaWithoutDefaults = z
.optional()
.describe('Widget configuration - structure depends on widget type');
-// Export enums for documentation
export { AggregateOperations, WidgetConfigurationType };
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
index 79a81e9da75..b4fd616af22 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
@@ -53,7 +53,6 @@ const gaxiosErrorMocks = {
response: undefined,
},
- // Timeout Error
timeout: {
code: 'ETIMEDOUT',
name: 'GaxiosError',
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-skip-step-execution.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-skip-step-execution.util.spec.ts
index fe25b007ad3..bef6ed14962 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-skip-step-execution.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/should-skip-step-execution.util.spec.ts
@@ -242,7 +242,6 @@ describe('shouldSkipStepExecution', () => {
createMockCodeStep('step-4', []),
];
- // Test case 1: All skipped - should return true
expect(
shouldSkipStepExecution({
step: steps[3],
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts
index d29fbb4d75e..023f038b5fb 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-filter-conditions.util.spec.ts
@@ -1634,7 +1634,6 @@ describe('evaluateFilterConditions', () => {
50,
'unknown',
);
- // strings are converted to numbers
const filter3 = createFilter(
ViewFilterOperand.GREATER_THAN_OR_EQUAL,
'1234',
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-relative-date-filter.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-relative-date-filter.util.spec.ts
index 4f3b9cb9298..d18cde79980 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-relative-date-filter.util.spec.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/filter/utils/__tests__/evaluate-relative-date-filter.util.spec.ts
@@ -116,7 +116,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'SECOND',
};
- // Dates within the next 3 seconds should match
expect(
evaluateRelativeDateFilter({
dateToCheck: addSeconds(now, 1),
@@ -136,7 +135,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: addSeconds(now, 4),
@@ -158,7 +156,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'MINUTE',
};
- // Dates within the next 3 minutes should match
expect(
evaluateRelativeDateFilter({
dateToCheck: addMinutes(now, 1),
@@ -178,7 +175,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: addMinutes(now, 4),
@@ -194,14 +190,12 @@ describe('Relative Date Filter Utils', () => {
});
it('should return true for dates within the next N hours', () => {
- ///
const relativeDateFilterValue: RelativeDateFilter = {
direction: 'NEXT',
amount: 3,
unit: 'HOUR',
};
- // Dates within the next 3 hours should match
expect(
evaluateRelativeDateFilter({
dateToCheck: addHours(now, 1),
@@ -221,7 +215,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: addHours(now, 4),
@@ -243,7 +236,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'DAY',
};
- // Dates within the next 3 days should match
expect(
evaluateRelativeDateFilter({
dateToCheck: addDays(now, 1),
@@ -263,7 +255,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: addDays(now, 4),
@@ -285,7 +276,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'WEEK',
};
- // Dates within the next 2 weeks should match
expect(
evaluateRelativeDateFilter({
dateToCheck: addWeeks(now, 1),
@@ -299,7 +289,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: addWeeks(now, 3),
@@ -328,7 +317,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'MONTH',
};
- // Dates within the next 2 months should match
expect(
evaluateRelativeDateFilter({
dateToCheck: addMonths(now, 1),
@@ -342,7 +330,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: addMonths(now, 3),
@@ -428,7 +415,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'SECOND',
};
- // Dates within the past 3 seconds should match
expect(
evaluateRelativeDateFilter({
dateToCheck: subSeconds(now, 1),
@@ -448,7 +434,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: subSeconds(now, 4),
@@ -470,7 +455,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'MINUTE',
};
- // Dates within the past 3 minutes should match
expect(
evaluateRelativeDateFilter({
dateToCheck: subMinutes(now, 1),
@@ -490,7 +474,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: subMinutes(now, 4),
@@ -512,7 +495,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'HOUR',
};
- // Dates within the past 3 hours should match
expect(
evaluateRelativeDateFilter({
dateToCheck: subHours(now, 1),
@@ -532,7 +514,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: subHours(now, 4),
@@ -554,7 +535,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'DAY',
};
- // Dates within the past 3 days should match
expect(
evaluateRelativeDateFilter({
dateToCheck: subDays(now, 1),
@@ -574,7 +554,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: subDays(now, 4),
@@ -596,7 +575,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'WEEK',
};
- // Dates within the past 2 weeks should match
expect(
evaluateRelativeDateFilter({
dateToCheck: subWeeks(now, 1),
@@ -610,7 +588,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: subWeeks(now, 3),
@@ -639,7 +616,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'MONTH',
};
- // Dates within the past 2 months should match
expect(
evaluateRelativeDateFilter({
dateToCheck: subMonths(now, 1),
@@ -653,7 +629,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: subMonths(now, 3),
@@ -675,7 +650,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'YEAR',
};
- // Dates within the past year should match
expect(
evaluateRelativeDateFilter({
dateToCheck: subMonths(now, 6),
@@ -689,7 +663,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Dates outside the range should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: subYears(now, 2),
@@ -726,7 +699,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'SECOND',
};
- // Same second should match
expect(
evaluateRelativeDateFilter({
dateToCheck: now,
@@ -734,7 +706,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Different seconds should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: new Date('2024-01-15T08:00:00Z'),
@@ -755,7 +726,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'MINUTE',
};
- // Same minute should match
expect(
evaluateRelativeDateFilter({
dateToCheck: now,
@@ -763,7 +733,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Different minutes should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: new Date('2024-01-15T08:00:00Z'),
@@ -784,7 +753,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'HOUR',
};
- // Same hour should match
expect(
evaluateRelativeDateFilter({
dateToCheck: now,
@@ -792,7 +760,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Different hours should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: new Date('2024-01-15T08:00:00Z'),
@@ -813,7 +780,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'DAY',
};
- // Same day should match
expect(
evaluateRelativeDateFilter({
dateToCheck: now,
@@ -828,7 +794,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Different days should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: subDays(now, 1),
@@ -865,7 +830,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Different weeks should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: new Date('2024-01-13T12:00:00Z'),
@@ -886,7 +850,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'MONTH',
};
- // Same month should match
expect(
evaluateRelativeDateFilter({
dateToCheck: now,
@@ -906,7 +869,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Different months should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: new Date('2023-12-31T12:00:00Z'),
@@ -927,7 +889,6 @@ describe('Relative Date Filter Utils', () => {
unit: 'YEAR',
};
- // Same year should match
expect(
evaluateRelativeDateFilter({
dateToCheck: now,
@@ -947,7 +908,6 @@ describe('Relative Date Filter Utils', () => {
}),
).toBe(true);
- // Different years should not match
expect(
evaluateRelativeDateFilter({
dateToCheck: new Date('2023-12-31T12:00:00Z'),
diff --git a/packages/twenty-server/src/queue-worker/queue-worker.ts b/packages/twenty-server/src/queue-worker/queue-worker.ts
index 777219b6c72..039bbe0c4c7 100644
--- a/packages/twenty-server/src/queue-worker/queue-worker.ts
+++ b/packages/twenty-server/src/queue-worker/queue-worker.ts
@@ -21,7 +21,6 @@ async function bootstrap() {
loggerService = app.get(LoggerService);
exceptionHandlerService = app.get(ExceptionHandlerService);
- // Inject our logger
app.useLogger(loggerService ?? false);
app.enableShutdownHooks();
diff --git a/packages/twenty-server/src/utils/camel-case.ts b/packages/twenty-server/src/utils/camel-case.ts
index 3d0403bb471..f7bbe50fec8 100644
--- a/packages/twenty-server/src/utils/camel-case.ts
+++ b/packages/twenty-server/src/utils/camel-case.ts
@@ -6,12 +6,10 @@ export const camelCase = <T>(text: T) =>
lodashCamelCase(text as unknown as string) as CamelCase<T>;
export const camelCaseDeep = <T>(value: T): CamelCasedPropertiesDeep<T> => {
- // Check if it's an array
if (Array.isArray(value)) {
return value.map(camelCaseDeep) as CamelCasedPropertiesDeep<T>;
}
- // Check if it's an object
if (isObject(value)) {
// oxlint-disable-next-line typescript/no-explicit-any
const result: Record<string, any> = {};
diff --git a/packages/twenty-server/src/utils/extract-request.ts b/packages/twenty-server/src/utils/extract-request.ts
index 14372e40771..876e1f9fedd 100644
--- a/packages/twenty-server/src/utils/extract-request.ts
+++ b/packages/twenty-server/src/utils/extract-request.ts
@@ -7,7 +7,6 @@ export const getRequest = (context: ExecutionContext) => {
if (context.getType() === 'http') {
request = context.switchToHttp().getRequest();
} else if (context.getType<GqlContextType>() === 'graphql') {
- // if context is a graphql request
const graphQLContext = GqlExecutionContext.create(context);
const { req, connection } = graphQLContext.getContext();
@@ -17,7 +16,6 @@ export const getRequest = (context: ExecutionContext) => {
? connection.context
: req;
} else if (context.getType() === 'rpc') {
- // if context is a rpc request
throw new Error('Not implemented');
}
diff --git a/packages/twenty-server/src/utils/kebab-case.ts b/packages/twenty-server/src/utils/kebab-case.ts
index 2719d747644..b10d82e738b 100644
--- a/packages/twenty-server/src/utils/kebab-case.ts
+++ b/packages/twenty-server/src/utils/kebab-case.ts
@@ -6,12 +6,10 @@ export const kebabCase = <T>(text: T) =>
lodashKebabCase(text as unknown as string) as KebabCase<T>;
export const kebabCaseDeep = <T>(value: T): KebabCasedPropertiesDeep<T> => {
- // Check if it's an array
if (Array.isArray(value)) {
return value.map(kebabCaseDeep) as KebabCasedPropertiesDeep<T>;
}
- // Check if it's an object
if (isObject(value)) {
// oxlint-disable-next-line typescript/no-explicit-any
const result: Record<string, any> = {};
diff --git a/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts b/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts
index c3ee868bbec..eb5cd0f1e5f 100644
--- a/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts
+++ b/packages/twenty-server/test/integration/ai/suites/mcp.controller.integration-spec.ts
@@ -276,7 +276,6 @@ describe('MCP Controller (integration)', () => {
// Should have at least a progress notification and the final response
expect(events.length).toBeGreaterThanOrEqual(2);
- // First event should be a progress notification
const progressEvent = events[0];
expect(progressEvent).toMatchObject({
@@ -297,7 +296,6 @@ describe('MCP Controller (integration)', () => {
jsonrpc: '2.0',
});
- // Should have either result.content or error
const hasResultContent = !!(lastEvent as any)?.result?.content;
const hasError = !!(lastEvent as any)?.error;
diff --git a/packages/twenty-server/test/integration/graphql/codegen/index.ts b/packages/twenty-server/test/integration/graphql/codegen/index.ts
index 5b4c599437f..3695a5026ff 100644
--- a/packages/twenty-server/test/integration/graphql/codegen/index.ts
+++ b/packages/twenty-server/test/integration/graphql/codegen/index.ts
@@ -208,8 +208,6 @@ const generateTests = async (force = false) => {
}
};
-// Basic command-line argument parsing
const forceArg = process.argv.includes('--force');
-// Call the function with the parsed argument
void generateTests(forceArg);
diff --git a/packages/twenty-server/test/integration/graphql/suites/files-field/files-field-download.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/files-field/files-field-download.integration-spec.ts
index 16df5230662..fc8cc276551 100644
--- a/packages/twenty-server/test/integration/graphql/suites/files-field/files-field-download.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/files-field/files-field-download.integration-spec.ts
@@ -191,7 +191,6 @@ describe('file-by-id.controller - GET /file/:fileFolder/:id', () => {
expect(fileUrl).toBeDefined();
expect(fileId).toBe(textFile.id);
- // Extract path from full URL (remove domain)
const urlPath = new URL(fileUrl).pathname + new URL(fileUrl).search;
const downloadResponse = await request(global.app.getHttpServer()).get(
@@ -246,7 +245,6 @@ describe('file-by-id.controller - GET /file/:fileFolder/:id', () => {
expect(fileUrl).toBeDefined();
expect(createdRecord.filesField[0].extension).toBe('.txt');
- // Extract path from full URL (remove domain)
const urlPath = new URL(fileUrl).pathname + new URL(fileUrl).search;
const downloadResponse = await request(global.app.getHttpServer()).get(
diff --git a/packages/twenty-server/test/integration/graphql/suites/group-by-resolver.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/group-by-resolver.integration-spec.ts
index 4e6a2eb9b53..ac30850c689 100644
--- a/packages/twenty-server/test/integration/graphql/suites/group-by-resolver.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/group-by-resolver.integration-spec.ts
@@ -411,7 +411,6 @@ describe('group-by resolver (integration)', () => {
expect(groups).toBeDefined();
expect(groups.length).toBe(4);
- // Group starting week of monday dec 30th, 2024
const mondayDec30thGroup = groups.find((group: any) =>
group.groupByDimensionValues[0].startsWith('2024-12-30'),
);
@@ -420,7 +419,6 @@ describe('group-by resolver (integration)', () => {
expect(mondayDec30thGroup.edges[0].node.id).toBe(idJan2);
expect(mondayDec30thGroup.totalCount).toBe(1);
- // Group starting week of monday jan 6th, 2025
const mondayJan6thGroup = groups.find((group: any) =>
group.groupByDimensionValues[0].startsWith('2025-01-06'),
);
@@ -429,7 +427,6 @@ describe('group-by resolver (integration)', () => {
expect(mondayJan6thGroup.edges[0].node.id).toBe(idJan8);
expect(mondayJan6thGroup.totalCount).toBe(1);
- // Group starting week of monday feb 24th, 2025
const mondayFeb24thGroup = groups.find((group: any) =>
group.groupByDimensionValues[0].startsWith('2025-02-24'),
);
@@ -496,7 +493,6 @@ describe('group-by resolver (integration)', () => {
expect(groups).toBeDefined();
expect(groups.length).toBe(4);
- // Group starting week of sunday dec 29th, 2024
const sundayDec29thGroup = groups.find((group: any) =>
group.groupByDimensionValues[0].startsWith('2024-12-29'),
);
@@ -507,7 +503,6 @@ describe('group-by resolver (integration)', () => {
sundayDec29thGroup.edges.find((edge: any) => edge.node.id === idJan2),
).toBeDefined();
- // Group starting week of sunday jan 5th, 2025
const sundayJan5thGroup = groups.find((group: any) =>
group.groupByDimensionValues[0].startsWith('2025-01-05'),
);
@@ -518,7 +513,6 @@ describe('group-by resolver (integration)', () => {
sundayJan5thGroup.edges.find((edge: any) => edge.node.id === idJan8),
).toBeDefined();
- // Group starting week of sunday feb 23rd, 2025
const sundayFeb23rdGroup = groups.find((group: any) =>
group.groupByDimensionValues[0].startsWith('2025-02-23'),
);
@@ -598,7 +592,6 @@ describe('group-by resolver (integration)', () => {
),
).toBeDefined();
- // Group starting week of saturday jan 4th, 2025
const saturdayJan4thGroup = groups.find((group: any) =>
group.groupByDimensionValues[0].startsWith('2025-01-04'),
);
@@ -911,7 +904,6 @@ describe('group-by resolver (integration)', () => {
expect.objectContaining({ groupByDimensionValues: [cityToKeep] }),
]),
);
- // Ensure excluded city is not present
expect(groups).toEqual(
expect.not.arrayContaining([
expect.objectContaining({ groupByDimensionValues: [cityToExclude] }),
@@ -945,7 +937,6 @@ describe('group-by resolver (integration)', () => {
}),
);
- // create a view with any field filter
const { data: createViewData } = await createOneView({
input: {
name: 'People View City Keep',
@@ -977,7 +968,6 @@ describe('group-by resolver (integration)', () => {
expect.objectContaining({ groupByDimensionValues: [cityA] }),
]),
);
- // Ensure excluded city is not present
expect(groups).toEqual(
expect.not.arrayContaining([
expect.objectContaining({ groupByDimensionValues: [cityB] }),
@@ -1041,7 +1031,6 @@ describe('group-by resolver (integration)', () => {
}),
);
- // Create people linked to companies
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: 'person',
@@ -1319,7 +1308,6 @@ describe('group-by resolver (integration)', () => {
listingObjectMetadataId = createListingObjectData.createOneObject.id;
- // Create relation from person to listing
const personlistingRelation = await createRelationBetweenObjects({
objectMetadataId: personObject.id,
targetObjectMetadataId: listingObjectMetadataId,
@@ -1330,7 +1318,6 @@ describe('group-by resolver (integration)', () => {
personlistingRelationFieldId = personlistingRelation.id;
- // Create companies
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: 'company',
@@ -1353,7 +1340,6 @@ describe('group-by resolver (integration)', () => {
}),
);
- // Create listings
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: 'listing',
@@ -1551,7 +1537,6 @@ describe('group-by resolver (integration)', () => {
};
beforeAll(async () => {
- // Create rockets with different names
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: 'rocket',
@@ -1798,7 +1783,6 @@ describe('group-by resolver (integration)', () => {
workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
});
- // Create a rocket
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: 'rocket',
@@ -1810,7 +1794,6 @@ describe('group-by resolver (integration)', () => {
}),
);
- // Create a pet linked to the rocket
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: 'pet',
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-generated/nested-relation-queries.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-generated/nested-relation-queries.integration-spec.ts
index f00c58f6058..2de9ae6731c 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-generated/nested-relation-queries.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-generated/nested-relation-queries.integration-spec.ts
@@ -608,7 +608,6 @@ describe('relation connect in workspace createOne/createMany resolvers (e2e)',
const TEST_PET_ID = TEST_PET_ID_1;
const TEST_SURVEY_RESULT_ID = TEST_SURVEY_RESULT_1_ID;
- // Create the survey result record first
await makeGraphqlAPIRequest(
createOneOperationFactory({
objectMetadataSingularName: SURVEY_RESULT_OBJECT_NAME,
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/read-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/read-permissions.integration-spec.ts
index 5cfccd1bff3..73a3a45c13f 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/read-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/read-permissions.integration-spec.ts
@@ -162,7 +162,6 @@ describe('Field permissions restrictions', () => {
(role: any) => role.label === 'Member',
).id;
- // Create a company and a person
companyId = randomUUID();
personId = randomUUID();
const createCompanyOp = createOneOperationFactory({
@@ -432,7 +431,6 @@ describe('Field permissions restrictions', () => {
restrictedPersonFieldId,
);
- // Query NOT requesting the restricted field
const graphqlOperation = findManyOperationFactory({
objectMetadataSingularName: 'company',
objectMetadataPluralName: 'companies',
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts
index 20d975a7d6c..df7b7d84477 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/fields-permissions/update-permissions.integration-spec.ts
@@ -125,7 +125,6 @@ describe('Field update permissions restrictions', () => {
(role: any) => role.label === 'Member',
).id;
- // Create a company and a person
companyId = randomUUID();
personId = randomUUID();
const createCompanyOp = createOneOperationFactory({
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/permissions-on-relations.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/permissions-on-relations.integration-spec.ts
index e4a9351e408..38058ed40a9 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/permissions-on-relations.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/permissions-on-relations.integration-spec.ts
@@ -44,7 +44,6 @@ describe('permissionsOnRelations', () => {
(role: any) => role.label === 'Member',
).id;
- // Create a person record
const companyId = randomUUID();
const graphqlOperationForCompanyCreation = createOneOperationFactory({
objectMetadataSingularName: 'company',
@@ -170,7 +169,6 @@ describe('permissionsOnRelations', () => {
const response = await makeGraphqlAPIRequestWithJony(graphqlOperation);
- // The query should succeed
expect(response.body.data).toBeDefined();
expect(response.body.data.people).toBeDefined();
const person = response.body.data.people.edges[0].node;
@@ -197,7 +195,6 @@ describe('permissionsOnRelations', () => {
workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
});
- // Create a query with nested relations
const graphqlOperation = findOneOperationFactory({
objectMetadataSingularName: 'person',
gqlFields: `
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/restore-many-object-records-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/restore-many-object-records-permissions.integration-spec.ts
index 1c23f68829c..92cf6abc012 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/restore-many-object-records-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/restore-many-object-records-permissions.integration-spec.ts
@@ -15,7 +15,6 @@ describe('restoreManyObjectRecordsPermissions', () => {
const personId2 = randomUUID();
beforeAll(async () => {
- // Create people
const createGraphqlOperation = createManyOperationFactory({
objectMetadataSingularName: 'person',
objectMetadataPluralName: 'people',
@@ -32,7 +31,6 @@ describe('restoreManyObjectRecordsPermissions', () => {
await makeGraphqlAPIRequest(createGraphqlOperation);
- // Delete people
const deleteGraphqlOperation = deleteManyOperationFactory({
objectMetadataSingularName: 'person',
objectMetadataPluralName: 'people',
diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/restore-one-object-records-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/restore-one-object-records-permissions.integration-spec.ts
index 915b689924d..3517eeb8382 100644
--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/restore-one-object-records-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/restore-one-object-records-permissions.integration-spec.ts
@@ -14,7 +14,6 @@ describe('restoreOneObjectRecordsPermissions', () => {
const personId = randomUUID();
beforeAll(async () => {
- // Create a person
const createGraphqlOperation = createOneOperationFactory({
objectMetadataSingularName: 'person',
gqlFields: PERSON_GQL_FIELDS,
@@ -25,7 +24,6 @@ describe('restoreOneObjectRecordsPermissions', () => {
await makeGraphqlAPIRequest(createGraphqlOperation);
- // Delete the person
const deleteGraphqlOperation = deleteOneOperationFactory({
objectMetadataSingularName: 'person',
gqlFields: PERSON_GQL_FIELDS,
diff --git a/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts
index 860e15c80fe..74dea0ac97d 100644
--- a/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/order-by-relation-field.integration-spec.ts
@@ -6,7 +6,6 @@ const TEST_COMPANY_IDS = {
ALPHA: '20202020-aaaa-4000-8000-000000000001',
BETA: '20202020-aaaa-4000-8000-000000000002',
GAMMA: '20202020-aaaa-4000-8000-000000000003',
- // Companies for case-insensitive sorting tests
ACME_LOWER: '20202020-aaaa-4000-8000-000000000004',
ACME_UPPER: '20202020-aaaa-4000-8000-000000000005',
ZEBRA: '20202020-aaaa-4000-8000-000000000006',
@@ -58,7 +57,6 @@ describe('Order by relation field (e2e)', () => {
objectMetadataPluralName: 'people',
gqlFields: 'id',
data: [
- // People with companies (for testing sorting)
{ id: TEST_PERSON_IDS[0], companyId: TEST_COMPANY_IDS.ALPHA },
{ id: TEST_PERSON_IDS[1], companyId: TEST_COMPANY_IDS.ALPHA },
{ id: TEST_PERSON_IDS[2], companyId: TEST_COMPANY_IDS.BETA },
@@ -70,7 +68,6 @@ describe('Order by relation field (e2e)', () => {
{ id: TEST_PERSON_IDS[7], companyId: null },
{ id: TEST_PERSON_IDS[8], companyId: null },
{ id: TEST_PERSON_IDS[9], companyId: null },
- // People for case-insensitive sorting tests
{
id: CASE_INSENSITIVE_TEST_PERSON_IDS[0],
companyId: TEST_COMPANY_IDS.ACME_LOWER,
@@ -237,7 +234,6 @@ describe('Order by relation field (e2e)', () => {
expect(Array.isArray(edges)).toBe(true);
expect(edges.length).toBeGreaterThan(0);
- // Check that null companies appear at the end
let seenNull = false;
for (const edge of edges) {
@@ -251,7 +247,6 @@ describe('Order by relation field (e2e)', () => {
});
it('should work with offset pagination', async () => {
- // First request to get initial data
const firstQueryData = {
query: gql`
query People(
@@ -349,7 +344,6 @@ describe('Order by relation field (e2e)', () => {
});
it.skip('should return clear error when using cursor pagination with relation orderBy', async () => {
- // First get a cursor by fetching records
const firstQueryData = {
query: gql`
query People(
@@ -502,7 +496,6 @@ describe('Order by relation field (e2e)', () => {
)
.filter((index: number) => index !== -1);
- // All ACME variants should appear before Zebra
for (const acmeIndex of acmeIndices) {
expect(acmeIndex).toBeLessThan(zebraIndex);
}
diff --git a/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts
index 9005c3cf5ca..f52c394dc82 100644
--- a/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/order-by-with-group-by.integration-spec.ts
@@ -195,7 +195,6 @@ describe('group-by resolvers - order by', () => {
expect(groups).toBeDefined();
expect(Array.isArray(groups)).toBe(true);
- // Extract group info for easier assertions
const groupInfos = groups.map((g: any) => ({
city: g.groupByDimensionValues?.[0],
dayOfWeek: g.groupByDimensionValues?.[1],
diff --git a/packages/twenty-server/test/integration/graphql/suites/search/search-resolver.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/search/search-resolver.integration-spec.ts
index e62adbd6537..d48d51cef04 100644
--- a/packages/twenty-server/test/integration/graphql/suites/search/search-resolver.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/search/search-resolver.integration-spec.ts
@@ -177,7 +177,6 @@ describe('SearchResolver', () => {
await deleteAllRecords('_pet');
await deleteAllRecords('_surveyResult');
await deleteAllRecords('_rocket');
- ///
await createManyOperation({
objectMetadataSingularName: 'pet',
diff --git a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts
index 8511ba19f0f..4c3874cdad6 100644
--- a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.integration-spec.ts
@@ -88,7 +88,6 @@ describe('Granular settings permissions', () => {
});
afterAll(async () => {
- // Restore JONY's original Member role
await updateWorkspaceMemberRole({
input: {
workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
@@ -178,7 +177,6 @@ describe('Granular settings permissions', () => {
'Updated Test Workspace',
);
- // Restore original workspace name
const restoreWorkspaceQuery = {
query: `
mutation UpdateWorkspace {
@@ -388,7 +386,6 @@ describe('Granular settings permissions', () => {
describe('Dynamic Permission Updates', () => {
it('should allow adding new setting permissions to existing role', async () => {
- // Add SECURITY permission to the custom role
const upsertSecurityPermissionQuery = {
query: `
mutation UpsertPermissionFlags {
diff --git a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/roles.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/roles.integration-spec.ts
index 0d3f72901dc..687a3c8caab 100644
--- a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/roles.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/roles.integration-spec.ts
@@ -263,7 +263,6 @@ describe('roles permissions', () => {
);
});
- // Clean
const rollbackRoleUpdateQuery = {
query: `
mutation UpdateWorkspaceMemberRole {
@@ -327,7 +326,6 @@ describe('roles permissions', () => {
const createdRoleId = result.body.data.createOneRole.id;
- // Clean
const deleteOneRoleQuery = deleteOneRoleOperationFactory(createdRoleId);
await client
diff --git a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/security.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/security.integration-spec.ts
index 0eb12859d84..0bbabb9da81 100644
--- a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/security.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/security.integration-spec.ts
@@ -21,7 +21,6 @@ describe('Security permissions', () => {
let originalWorkspaceState: Record<string, unknown>;
beforeAll(async () => {
- // Store original workspace state
const query = gql`
query getWorkspace {
currentWorkspace {
@@ -43,7 +42,6 @@ describe('Security permissions', () => {
});
afterAll(async () => {
- // Restore workspace state
const restoreQuery = gql`
mutation updateWorkspace {
updateWorkspace(data: {
diff --git a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/workspace.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/workspace.integration-spec.ts
index 29aff9abae4..cd2010fb1c7 100644
--- a/packages/twenty-server/test/integration/graphql/suites/settings-permissions/workspace.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/settings-permissions/workspace.integration-spec.ts
@@ -23,7 +23,6 @@ describe('workspace permissions', () => {
let originalWorkspaceState: Record<string, unknown>;
beforeAll(async () => {
- // Store original workspace state
const query = gql`
query getWorkspace {
currentWorkspace {
@@ -44,7 +43,6 @@ describe('workspace permissions', () => {
});
afterAll(async () => {
- // Restore workspace state
const restoreQuery = gql`
mutation updateWorkspace {
updateWorkspace(data: {
diff --git a/packages/twenty-server/test/integration/graphql/suites/upsert/upsert.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/upsert/upsert.integration-spec.ts
index 88d91d293df..d2defba17fc 100644
--- a/packages/twenty-server/test/integration/graphql/suites/upsert/upsert.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/upsert/upsert.integration-spec.ts
@@ -118,7 +118,6 @@ describe('upsert (createMany with upsert:true)', () => {
});
it('should update many records', async () => {
- // Create 2 records
await makeGraphqlAPIRequest({
query: createRecordsQuery,
variables: {
@@ -138,7 +137,6 @@ describe('upsert (createMany with upsert:true)', () => {
},
});
- // Update 2 records using upsert
const updatedRecordsResponse = await makeGraphqlAPIRequest({
query: createRecordsQuery,
variables: {
diff --git a/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts
index 8e4977f4971..a538fec55bc 100644
--- a/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts
+++ b/packages/twenty-server/test/integration/graphql/suites/user.integration-spec.ts
@@ -136,7 +136,6 @@ describe('deleteUser', () => {
expect(createdMember).toBeDefined();
const createdWorkspaceMemberId = createdMember.id;
- // 2. Act
const deleteUserFromWorkspaceMutation = {
query: `
mutation DeleteUserFromWorkspace {
@@ -156,7 +155,6 @@ describe('deleteUser', () => {
expect(deleteResponse.body.errors).toBeUndefined();
- // 3. Assert
const membersAfterDeletionResponse = await client
.post('/graphql')
.set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
diff --git a/packages/twenty-server/test/integration/metadata/suites/agent/failing-agent-creation.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/agent/failing-agent-creation.integration-spec.ts
index 66a57f646e1..1905266ffae 100644
--- a/packages/twenty-server/test/integration/metadata/suites/agent/failing-agent-creation.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/agent/failing-agent-creation.integration-spec.ts
@@ -49,7 +49,6 @@ describe('Agent creation should fail', () => {
});
const failingAgentCreationTestCases: CreateOneAgentTestingContext = [
- // Missing required properties tests
{
title: 'when label is missing',
context: {
@@ -107,7 +106,6 @@ describe('Agent creation should fail', () => {
},
},
},
- // Name uniqueness test
{
title: 'when computed name already exists',
context: {
@@ -118,7 +116,6 @@ describe('Agent creation should fail', () => {
},
},
},
- // Invalid response format tests
{
title: 'when responseFormat has invalid type',
context: {
diff --git a/packages/twenty-server/test/integration/metadata/suites/agent/successful-agent-creation.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/agent/successful-agent-creation.integration-spec.ts
index 16e4e234d2f..7d950c3b184 100644
--- a/packages/twenty-server/test/integration/metadata/suites/agent/successful-agent-creation.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/agent/successful-agent-creation.integration-spec.ts
@@ -186,7 +186,6 @@ describe('Agent creation should succeed', () => {
const createdRoleId = roleData?.createOneRole?.id;
- // Create agent with role assignment
const { data } = await createOneAgent({
expectToFail: false,
input: {
diff --git a/packages/twenty-server/test/integration/metadata/suites/application/successful-manifest-reparent-view-children.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/application/successful-manifest-reparent-view-children.integration-spec.ts
index 9468b2cdc0e..4e8da09e6ec 100644
--- a/packages/twenty-server/test/integration/metadata/suites/application/successful-manifest-reparent-view-children.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/application/successful-manifest-reparent-view-children.integration-spec.ts
@@ -282,7 +282,6 @@ describe('Manifest reparent - all view children are reparentable', () => {
await findReparentViews(personObjectId);
for (const childCollectionKey of CHILD_COLLECTION_KEYS) {
- // The source view no longer owns any child.
expect(sourceAfterReparent[childCollectionKey]).toHaveLength(0);
// The target view now owns exactly the same row (same id), proving the
@@ -333,7 +332,6 @@ describe('Manifest reparent - all view children are reparentable', () => {
(view) => view.name === TARGET_VIEW_NAME,
);
- // The source view has been deleted.
expect(sourceAfterReparent).toBeUndefined();
if (!targetAfterReparent) {
diff --git a/packages/twenty-server/test/integration/metadata/suites/field-metadata/enum/successful-remove-multi-select-option-side-effect-on-records.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/field-metadata/enum/successful-remove-multi-select-option-side-effect-on-records.integration-spec.ts
index 7283a5fea6b..38314178faf 100644
--- a/packages/twenty-server/test/integration/metadata/suites/field-metadata/enum/successful-remove-multi-select-option-side-effect-on-records.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/field-metadata/enum/successful-remove-multi-select-option-side-effect-on-records.integration-spec.ts
@@ -133,7 +133,6 @@ describe('remove multi-select option with side effect on records', () => {
const removedOnlyRecordId = removedOnlyData.createOneResponse.id;
- // Record with only surviving options
const { data: survivingData } = await createOneOperation({
expectToFail: false,
objectMetadataSingularName: TEST_OBJECT_NAME_SINGULAR,
@@ -143,7 +142,6 @@ describe('remove multi-select option with side effect on records', () => {
const survivingRecordId = survivingData.createOneResponse.id;
- // Remove OPTION_2 -- keep OPTION_1 and OPTION_3
const { data: updateData, errors: updateErrors } =
await updateOneFieldMetadata({
expectToFail: false,
@@ -198,7 +196,6 @@ describe('remove multi-select option with side effect on records', () => {
removedOnlyTagField === null || removedOnlyTagField.length === 0,
).toBe(true);
- // Surviving record: should be unchanged
const { data: survivingAfter } = await findOneOperation({
expectToFail: false,
objectMetadataSingularName: TEST_OBJECT_NAME_SINGULAR,
diff --git a/packages/twenty-server/test/integration/metadata/suites/field-metadata/morph-relation/successful-update-one-field-metadata-morph-relation-v2.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/field-metadata/morph-relation/successful-update-one-field-metadata-morph-relation-v2.integration-spec.ts
index 2c2366db025..d97725af635 100644
--- a/packages/twenty-server/test/integration/metadata/suites/field-metadata/morph-relation/successful-update-one-field-metadata-morph-relation-v2.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/field-metadata/morph-relation/successful-update-one-field-metadata-morph-relation-v2.integration-spec.ts
@@ -215,7 +215,6 @@ describe('updateOne FieldMetadataService morph relation fields v2', () => {
({ targetFieldMetadata }) => targetFieldMetadata.id,
);
- /// ASSERT
{
const morphRelationFieldsBeforeUpdate = (await findManyFieldsMetadata({
input: {
@@ -274,7 +273,6 @@ describe('updateOne FieldMetadataService morph relation fields v2', () => {
expect(aggregatedRelationFieldMetadataDtos).toMatchSnapshot();
}
- // UPDATE
const input = {
idToUpdate: createdFieldMetadataId,
updatePayload: {
diff --git a/packages/twenty-server/test/integration/metadata/suites/field-metadata/relation/successful-field-metadata-relation-update.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/field-metadata/relation/successful-field-metadata-relation-update.integration-spec.ts
index d5f7dcabab3..f7fe7b9ce7e 100644
--- a/packages/twenty-server/test/integration/metadata/suites/field-metadata/relation/successful-field-metadata-relation-update.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/field-metadata/relation/successful-field-metadata-relation-update.integration-spec.ts
@@ -316,7 +316,6 @@ describe('Field metadata self-relation update should succeed', () => {
const mentorFieldId = createdField.id;
const menteesFieldId = createdField.relation.targetFieldMetadata.id;
- // Update the MANY_TO_ONE side
const { data: mentorUpdateData } = await updateOneFieldMetadata({
expectToFail: false,
input: {
@@ -339,7 +338,6 @@ describe('Field metadata self-relation update should succeed', () => {
description: 'The mentor of this person',
});
- // Update the ONE_TO_MANY side
const { data: menteesUpdateData } = await updateOneFieldMetadata({
expectToFail: false,
input: {
diff --git a/packages/twenty-server/test/integration/metadata/suites/logic-function/logic-function-execution.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/logic-function/logic-function-execution.integration-spec.ts
index 886158e61f4..05e34f77f5d 100644
--- a/packages/twenty-server/test/integration/metadata/suites/logic-function/logic-function-execution.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/logic-function/logic-function-execution.integration-spec.ts
@@ -21,7 +21,6 @@ export const main = async (params: { items: Array<{ category: string; name: stri
};
};`;
-// Test function that throws an error
const ERROR_FUNCTION_CODE = `export const main = async (params: { shouldFail: boolean }): Promise<object> => {
if (params.shouldFail) {
throw new Error('Intentional test error');
@@ -118,7 +117,6 @@ describe('Logic Function Execution', () => {
expectToFail: false,
});
- // Execute the function with items to group
const { data: executeData } = await executeLogicFunction({
input: {
id: functionId,
@@ -235,7 +233,6 @@ describe('Logic Function Execution', () => {
});
it('should handle errors thrown by logic functions', async () => {
- // Create the function with error-throwing code
const { data: createData } = await createOneLogicFunction({
input: {
name: 'Error Test Function',
diff --git a/packages/twenty-server/test/integration/metadata/suites/role/failing-role-creation.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/role/failing-role-creation.integration-spec.ts
index 1c9de7c7593..1ea02fb6d5c 100644
--- a/packages/twenty-server/test/integration/metadata/suites/role/failing-role-creation.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/role/failing-role-creation.integration-spec.ts
@@ -53,7 +53,6 @@ describe('Role creation should fail', () => {
});
const failingRoleCreationTestCases: CreateOneRoleTestingContext = [
- // Missing required properties tests
{
title: 'when label is missing',
context: {
@@ -67,7 +66,6 @@ describe('Role creation should fail', () => {
} as CreateRoleInput,
},
},
- // Label uniqueness test
{
title: 'when label already exists',
context: {
@@ -82,7 +80,6 @@ describe('Role creation should fail', () => {
},
},
},
- // Read/Write permissions consistency tests
{
title:
'when canReadAllObjectRecords is false but canUpdateAllObjectRecords is true',
diff --git a/packages/twenty-server/test/integration/metadata/suites/role/failing-role-update.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/role/failing-role-update.integration-spec.ts
index a9991668804..a099dd39664 100644
--- a/packages/twenty-server/test/integration/metadata/suites/role/failing-role-update.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/role/failing-role-update.integration-spec.ts
@@ -64,7 +64,6 @@ describe('Role update should fail', () => {
});
beforeEach(async () => {
- // Create a role for each test
const { data } = await createOneRole({
expectToFail: false,
input: {
@@ -104,7 +103,6 @@ describe('Role update should fail', () => {
let roleWithWritePermissionsId: string;
beforeEach(async () => {
- // Create a role with read=true and write=true
const { data } = await createOneRole({
expectToFail: false,
input: {
@@ -169,7 +167,6 @@ describe('Role update should fail', () => {
}),
},
},
- // Read/Write permissions consistency tests
{
title:
'when updating canReadAllObjectRecords to false while canUpdateAllObjectRecords is true',
diff --git a/packages/twenty-server/test/integration/metadata/suites/role/successful-update-workspace-member-role.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/role/successful-update-workspace-member-role.integration-spec.ts
index ce57814d1f7..ca5353eb6da 100644
--- a/packages/twenty-server/test/integration/metadata/suites/role/successful-update-workspace-member-role.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/role/successful-update-workspace-member-role.integration-spec.ts
@@ -11,7 +11,6 @@ describe('Workspace member role update should succeed', () => {
let shouldRestorePhilRole: boolean = false;
beforeAll(async () => {
- // Get the Admin, Guest, and Member role IDs
const adminRole = await findOneRoleByLabel({ label: 'Admin' });
const guestRole = await findOneRoleByLabel({ label: 'Guest' });
const memberRole = await findOneRoleByLabel({ label: 'Member' });
diff --git a/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-creation.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-creation.integration-spec.ts
index 59bcf939726..321365caca0 100644
--- a/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-creation.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/skill/failing-skill-creation.integration-spec.ts
@@ -51,7 +51,6 @@ describe('Skill creation should fail', () => {
});
const failingSkillCreationTestCases: CreateSkillTestingContext = [
- // Missing required properties tests
{
title: 'when label is missing',
context: {
@@ -99,7 +98,6 @@ describe('Skill creation should fail', () => {
},
},
},
- // Name uniqueness test
{
title: 'when name already exists',
context: {
diff --git a/packages/twenty-server/test/integration/metadata/suites/view-field-group/upsert-fields-widget.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/view-field-group/upsert-fields-widget.integration-spec.ts
index 57e1f373368..79575f5d2c1 100644
--- a/packages/twenty-server/test/integration/metadata/suites/view-field-group/upsert-fields-widget.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/view-field-group/upsert-fields-widget.integration-spec.ts
@@ -124,7 +124,6 @@ describe('upsertFieldsWidget', () => {
});
it('should hard-delete groups not included in the input', async () => {
- // First, create a group via upsert
const groupToDeleteId = uuidv4();
const groupToKeepId = uuidv4();
@@ -165,7 +164,6 @@ describe('upsertFieldsWidget', () => {
},
});
- // Now upsert again without the first group
await upsertFieldsWidget({
expectToFail: false,
input: {
@@ -281,7 +279,6 @@ describe('upsertFieldsWidget', () => {
});
it('should hard-delete all existing groups when using flat fields', async () => {
- // First create a group via upsert
const groupId = uuidv4();
const targetField = testSetup.viewFields[0];
@@ -319,7 +316,6 @@ describe('upsertFieldsWidget', () => {
expect(groupBefore).toBeDefined();
- // Now upsert with flat fields
await upsertFieldsWidget({
expectToFail: false,
input: {
diff --git a/packages/twenty-server/test/integration/oauth/suites/oauth.integration-spec.ts b/packages/twenty-server/test/integration/oauth/suites/oauth.integration-spec.ts
index 469a86733d7..fd1c5571a45 100644
--- a/packages/twenty-server/test/integration/oauth/suites/oauth.integration-spec.ts
+++ b/packages/twenty-server/test/integration/oauth/suites/oauth.integration-spec.ts
@@ -783,7 +783,6 @@ describe('OAuth (integration)', () => {
createdEntityIds.tokens.push(tokenId);
- // First use succeeds
await postToken({
grant_type: 'authorization_code',
code,
@@ -792,7 +791,6 @@ describe('OAuth (integration)', () => {
redirect_uri: 'https://example.com/callback',
}).expect(200);
- // Second use detects replay
const res = await postToken({
grant_type: 'authorization_code',
code,
diff --git a/packages/twenty-server/test/integration/rest/suites/field-permissions.integration-spec.ts b/packages/twenty-server/test/integration/rest/suites/field-permissions.integration-spec.ts
index 558786c9f09..a2fc7310815 100644
--- a/packages/twenty-server/test/integration/rest/suites/field-permissions.integration-spec.ts
+++ b/packages/twenty-server/test/integration/rest/suites/field-permissions.integration-spec.ts
@@ -107,7 +107,6 @@ describe('Restricted fields', () => {
field.node.object.nameSingular === 'person',
).node.id;
- // Get member role ID
const getRolesOperation = {
query: gql`
query {
@@ -223,7 +222,6 @@ describe('Restricted fields', () => {
});
it('should allow update when user has no restricted update permissions', async () => {
- // Remove field permission restrictions
await upsertFieldPermissions({
roleId: memberRoleId,
fieldPermissions: [
diff --git a/packages/twenty-server/test/integration/rest/suites/rest-api-core-find-many.integration-spec.ts b/packages/twenty-server/test/integration/rest/suites/rest-api-core-find-many.integration-spec.ts
index 7b8c1d3d151..ab2a91d6f2d 100644
--- a/packages/twenty-server/test/integration/rest/suites/rest-api-core-find-many.integration-spec.ts
+++ b/packages/twenty-server/test/integration/rest/suites/rest-api-core-find-many.integration-spec.ts
@@ -83,7 +83,6 @@ describe('Core REST API Find Many endpoint', () => {
expect(person.jobTitle).toBe(testPersonJobTitles[personId]);
}
- // Check pagination metadata
expect(pageInfo).toBeDefined();
expect(pageInfo.startCursor).toBeDefined();
expect(pageInfo.endCursor).toBeDefined();
diff --git a/packages/twenty-server/test/integration/rest/suites/view-group.integration-spec.ts b/packages/twenty-server/test/integration/rest/suites/view-group.integration-spec.ts
index 9d0102c68a2..874c244cfd5 100644
--- a/packages/twenty-server/test/integration/rest/suites/view-group.integration-spec.ts
+++ b/packages/twenty-server/test/integration/rest/suites/view-group.integration-spec.ts
@@ -136,7 +136,6 @@ describe('View Group REST API', () => {
// For a nullable field with three options, we expect groups for OPTION_1, OPTION_2, OPTION_3, and '' (empty string)
const expectedFieldValues = ['OPTION_1', 'OPTION_2', 'OPTION_3', ''];
- // Check structure and visibility for each group
expectedFieldValues.forEach((expectedFieldValue) => {
const group = returnedViewGroups.find(
(group) => group.fieldValue === expectedFieldValue,
diff --git a/packages/twenty-shared/scripts/generateBarrels.ts b/packages/twenty-shared/scripts/generateBarrels.ts
index 1f2ce155e0d..61553507e53 100644
--- a/packages/twenty-shared/scripts/generateBarrels.ts
+++ b/packages/twenty-shared/scripts/generateBarrels.ts
@@ -397,7 +397,6 @@ const extractExportsFromSourceFile = (sourceFile: ts.SourceFile) => {
const isTypeExport =
node.isTypeOnly || ts.isTypeOnlyExportDeclaration(node);
if (isTypeExport) {
- // should handle kind
exports.push({
kind: 'type',
name: exportName,
diff --git a/packages/twenty-shared/src/ai/types/DataMessagePart.ts b/packages/twenty-shared/src/ai/types/DataMessagePart.ts
index 90c218f552b..cf2b9b28868 100644
--- a/packages/twenty-shared/src/ai/types/DataMessagePart.ts
+++ b/packages/twenty-shared/src/ai/types/DataMessagePart.ts
@@ -73,7 +73,6 @@ export type DataMessagePart = {
routingCostInCredits?: number;
agentCostInCredits?: number;
totalCostInCredits?: number;
- // Plan execution
planReasoning?: string;
totalSteps?: number;
steps?: Array<{
diff --git a/packages/twenty-shared/src/constants/PermissionFlagType.ts b/packages/twenty-shared/src/constants/PermissionFlagType.ts
index 6234fd0cfb9..da0ad498255 100644
--- a/packages/twenty-shared/src/constants/PermissionFlagType.ts
+++ b/packages/twenty-shared/src/constants/PermissionFlagType.ts
@@ -1,5 +1,4 @@
export enum PermissionFlagType {
- // Settings permissions
API_KEYS_AND_WEBHOOKS = 'API_KEYS_AND_WEBHOOKS',
WORKSPACE = 'WORKSPACE',
WORKSPACE_MEMBERS = 'WORKSPACE_MEMBERS',
@@ -15,7 +14,6 @@ export enum PermissionFlagType {
BILLING = 'BILLING',
AI_SETTINGS = 'AI_SETTINGS',
- // Tool permissions
AI = 'AI',
VIEWS = 'VIEWS',
UPLOAD_FILE = 'UPLOAD_FILE',
diff --git a/packages/twenty-shared/src/types/__tests__/extract-serialized-relation-properties.type-test.ts b/packages/twenty-shared/src/types/__tests__/extract-serialized-relation-properties.type-test.ts
index 1d4959b4bac..8187fc42c4d 100644
--- a/packages/twenty-shared/src/types/__tests__/extract-serialized-relation-properties.type-test.ts
+++ b/packages/twenty-shared/src/types/__tests__/extract-serialized-relation-properties.type-test.ts
@@ -3,7 +3,6 @@ import { type ExtractSerializedRelationProperties } from '@/types/ExtractSeriali
import { type SerializedRelation } from '@/types/SerializedRelation.type';
type TestedRecord = {
- // Non-SerializedRelation fields
plainString: string;
plainNumber: number;
plainBoolean: boolean;
@@ -46,10 +45,8 @@ type Assertions = [
Expect<Equal<ExtractSerializedRelationProperties<number>, never>>,
Expect<Equal<ExtractSerializedRelationProperties<null>, never>>,
- // Empty object returns never
Expect<Equal<ExtractSerializedRelationProperties<object>, never>>,
- // Union types distribute correctly
Expect<
Equal<
ExtractSerializedRelationProperties<
@@ -59,7 +56,6 @@ type Assertions = [
>
>,
- // Mixed union with object and primitive
Expect<
Equal<
ExtractSerializedRelationProperties<{ rel: SerializedRelation } | string>,
diff --git a/packages/twenty-shared/src/types/__tests__/index-of.type-test.ts b/packages/twenty-shared/src/types/__tests__/index-of.type-test.ts
index b9376f0c53e..4e25dcbeca7 100644
--- a/packages/twenty-shared/src/types/__tests__/index-of.type-test.ts
+++ b/packages/twenty-shared/src/types/__tests__/index-of.type-test.ts
@@ -11,12 +11,9 @@ type Assertions = [
Expect<Equal<IndexOf<'1.22.0', Versions>, 2>>,
Expect<Equal<IndexOf<'1.23.0', Versions>, 3>>,
- // Not found resolves to never
Expect<Equal<IndexOf<'1.99.0', Versions>, never>>,
- // Single element tuple
Expect<Equal<IndexOf<'a', readonly ['a']>, 0>>,
- // Empty tuple
Expect<Equal<IndexOf<'a', readonly []>, never>>,
];
diff --git a/packages/twenty-shared/src/types/__tests__/is-greater-or-equal.type-test.ts b/packages/twenty-shared/src/types/__tests__/is-greater-or-equal.type-test.ts
index f695eaf10e8..9767d95a06f 100644
--- a/packages/twenty-shared/src/types/__tests__/is-greater-or-equal.type-test.ts
+++ b/packages/twenty-shared/src/types/__tests__/is-greater-or-equal.type-test.ts
@@ -4,16 +4,13 @@ import { type IsGreaterOrEqual } from '@/types/IsGreaterOrEqual.type';
// oxlint-disable-next-line unused-imports/no-unused-vars
type Assertions = [
- // Equal values
Expect<Equal<IsGreaterOrEqual<0, 0>, true>>,
Expect<Equal<IsGreaterOrEqual<3, 3>, true>>,
- // A > B
Expect<Equal<IsGreaterOrEqual<3, 0>, true>>,
Expect<Equal<IsGreaterOrEqual<3, 2>, true>>,
Expect<Equal<IsGreaterOrEqual<1, 0>, true>>,
- // A < B
Expect<Equal<IsGreaterOrEqual<0, 1>, false>>,
Expect<Equal<IsGreaterOrEqual<0, 3>, false>>,
Expect<Equal<IsGreaterOrEqual<2, 3>, false>>,
diff --git a/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts b/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts
index 2767764a77c..c8a86bc0d1a 100644
--- a/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts
+++ b/packages/twenty-shared/src/utils/__tests__/applyDiff.test.ts
@@ -368,18 +368,15 @@ describe('applyDiff', () => {
const obj = { safe: 'value' };
const unicodeBypassAttempts = [
- // __proto__ with Unicode escapes
'__\u0070roto__', // \u0070 = 'p'
'__\u{70}roto__', // ES6 syntax
'__pr\u006fto__', // \u006f = 'o'
'__proto\u005f\u005f', // \u005f = '_'
- // constructor with Unicode escapes
'construc\u0074or', // \u0074 = 't'
'constr\u0075ctor', // \u0075 = 'u'
'\u0063onstructor', // \u0063 = 'c'
- // prototype with Unicode escapes
'proto\u0074ype', // \u0074 = 't'
'prototy\u0070e', // \u0070 = 'p'
'\u0070rototype', // \u0070 = 'p'
@@ -426,7 +423,6 @@ describe('applyDiff', () => {
{ type: 'REMOVE', path: ['__proto__'], oldValue: 'anything' },
{ type: 'REMOVE', path: ['constructor'], oldValue: 'anything' },
{ type: 'REMOVE', path: ['prototype'], oldValue: 'anything' },
- // Remove a normal property (this should work)
{ type: 'REMOVE', path: ['safe'], oldValue: 'value' },
];
@@ -518,7 +514,6 @@ describe('applyDiff', () => {
};
const diffs: Difference[] = [
- // Update trigger settings
{
type: 'CHANGE',
path: ['trigger', 'settings', 'table'],
@@ -526,14 +521,12 @@ describe('applyDiff', () => {
value: 'contacts',
},
{ type: 'REMOVE', path: ['steps', 0], oldValue: '1' },
- // Update remaining step
{
type: 'CHANGE',
path: ['steps', 1, 'settings', 'to'],
oldValue: '[email protected]',
},
- // Add new step
{
type: 'CREATE',
path: ['steps', 2],
@@ -581,14 +574,12 @@ describe('applyDiff', () => {
{ type: 'REMOVE', path: ['items', 1], oldValue: 'Item 2' },
{ type: 'REMOVE', path: ['items', 3], oldValue: 'Item 4' },
{ type: 'REMOVE', path: ['items', 3], oldValue: 'Item 4' },
- // Update remaining item
{
type: 'CHANGE',
path: ['items', 0, 'name'],
oldValue: 'Item 1',
value: 'Updated Item 1',
},
- // Add new item
{
type: 'CREATE',
path: ['items', 5],
diff --git a/packages/twenty-shared/src/utils/__tests__/uuidToBase36.test.ts b/packages/twenty-shared/src/utils/__tests__/uuidToBase36.test.ts
index c807b82db8d..f95866ef9c5 100644
--- a/packages/twenty-shared/src/utils/__tests__/uuidToBase36.test.ts
+++ b/packages/twenty-shared/src/utils/__tests__/uuidToBase36.test.ts
@@ -7,7 +7,6 @@ describe('uuidToBase36', () => {
expect(typeof result).toBe('string');
expect(result.length).toBeGreaterThan(0);
- // base36 only contains alphanumeric characters
expect(result).toMatch(/^[0-9a-z]+$/);
});
diff --git a/packages/twenty-shared/src/utils/deepMerge.ts b/packages/twenty-shared/src/utils/deepMerge.ts
index 9f7ee5bb032..3339d7c6ae4 100644
--- a/packages/twenty-shared/src/utils/deepMerge.ts
+++ b/packages/twenty-shared/src/utils/deepMerge.ts
@@ -15,14 +15,11 @@ export const deepMerge = <T extends object>(
source: Required<T>,
target: Required<T>,
): T => {
- // Handle null/undefined cases
if (!source) return target as T;
if (!target) return source;
- // Create a new object to avoid mutations
const output = { ...source };
- // Iterate through all keys in target
Object.keys(target).forEach((key) => {
const sourceValue = source[key as keyof T];
const targetValue = target[key as keyof T];
@@ -31,13 +28,11 @@ export const deepMerge = <T extends object>(
return;
}
- // Handle null values - explicitly assign them
if (targetValue === null) {
output[key as keyof T] = null as T[keyof T];
return;
}
- // Handle arrays - concatenate them
if (Array.isArray(sourceValue) && Array.isArray(targetValue)) {
output[key as keyof T] = [...sourceValue, ...targetValue] as T[keyof T];
return;
@@ -54,7 +49,6 @@ export const deepMerge = <T extends object>(
return;
}
- // Handle nested objects - recurse
if (
sourceValue &&
targetValue &&
@@ -70,7 +64,6 @@ export const deepMerge = <T extends object>(
return;
}
- // For primitives
output[key as keyof T] = targetValue as T[keyof T];
});
diff --git a/packages/twenty-shared/src/utils/filter/utils/__tests__/arrayOfUuidOrVariableSchema.test.ts b/packages/twenty-shared/src/utils/filter/utils/__tests__/arrayOfUuidOrVariableSchema.test.ts
index 04668ee53eb..4a2f02028fc 100644
--- a/packages/twenty-shared/src/utils/filter/utils/__tests__/arrayOfUuidOrVariableSchema.test.ts
+++ b/packages/twenty-shared/src/utils/filter/utils/__tests__/arrayOfUuidOrVariableSchema.test.ts
@@ -9,14 +9,12 @@ describe('arrayOfUuidOrVariableSchema', () => {
];
validUuids.forEach((uuid) => {
- // Test as single value
const singleResult = arrayOfUuidOrVariableSchema.safeParse(uuid);
expect(singleResult.success).toBe(true);
if (singleResult.success) {
expect(singleResult.data).toEqual([uuid]);
}
- // Test as array
const arrayResult = arrayOfUuidOrVariableSchema.safeParse([uuid]);
expect(arrayResult.success).toBe(true);
if (arrayResult.success) {
@@ -35,14 +33,12 @@ describe('arrayOfUuidOrVariableSchema', () => {
];
invalidUuids.forEach((uuid) => {
- // Test as single value
const singleResult = arrayOfUuidOrVariableSchema.safeParse(uuid);
expect(singleResult.success).toBe(true);
if (singleResult.success) {
expect(singleResult.data).toEqual([]);
}
- // Test as array
const arrayResult = arrayOfUuidOrVariableSchema.safeParse([uuid]);
expect(arrayResult.success).toBe(true);
if (arrayResult.success) {
@@ -61,14 +57,12 @@ describe('arrayOfUuidOrVariableSchema', () => {
];
validVariables.forEach((variable) => {
- // Test as single value
const singleResult = arrayOfUuidOrVariableSchema.safeParse(variable);
expect(singleResult.success).toBe(true);
if (singleResult.success) {
expect(singleResult.data).toEqual([variable]);
}
- // Test as array
const arrayResult = arrayOfUuidOrVariableSchema.safeParse([variable]);
expect(arrayResult.success).toBe(true);
if (arrayResult.success) {
@@ -81,14 +75,12 @@ describe('arrayOfUuidOrVariableSchema', () => {
const invalidVariables = ['{{variable', 'variable}}', '{{}}', '{{', '}}'];
invalidVariables.forEach((variable) => {
- // Test as single value
const singleResult = arrayOfUuidOrVariableSchema.safeParse(variable);
expect(singleResult.success).toBe(true);
if (singleResult.success) {
expect(singleResult.data).toEqual([]);
}
- // Test as array
const arrayResult = arrayOfUuidOrVariableSchema.safeParse([variable]);
expect(arrayResult.success).toBe(true);
if (arrayResult.success) {
diff --git a/packages/twenty-shared/src/utils/url/__tests__/isValidUrl.test.ts b/packages/twenty-shared/src/utils/url/__tests__/isValidUrl.test.ts
index 95798acc51c..544280a7a67 100644
--- a/packages/twenty-shared/src/utils/url/__tests__/isValidUrl.test.ts
+++ b/packages/twenty-shared/src/utils/url/__tests__/isValidUrl.test.ts
@@ -2,7 +2,6 @@ import { isValidUrl } from '@/utils/url/isValidUrl';
describe('isValidUrl', () => {
it('test cases', () => {
- // Truthy
expect(isValidUrl('https://www.example.com')).toBe(true);
expect(isValidUrl('http://192.168.2.0:3000')).toBe(true);
expect(isValidUrl('http://localhost')).toBe(true);
@@ -18,7 +17,6 @@ describe('isValidUrl', () => {
expect(isValidUrl('192.168.2.0')).toBe(true);
expect(isValidUrl('3.com')).toBe(true);
- // Falsy
expect(isValidUrl('?o')).toBe(false);
expect(isValidUrl('')).toBe(false);
expect(isValidUrl('\\')).toBe(false);
diff --git a/packages/twenty-shared/src/utils/validation/__tests__/normalizeLocale.test.ts b/packages/twenty-shared/src/utils/validation/__tests__/normalizeLocale.test.ts
index 9f1b27a97d1..79652fe778e 100644
--- a/packages/twenty-shared/src/utils/validation/__tests__/normalizeLocale.test.ts
+++ b/packages/twenty-shared/src/utils/validation/__tests__/normalizeLocale.test.ts
@@ -7,21 +7,18 @@ describe('normalizeLocale', () => {
});
it('should return the locale when there is a direct match in APP_LOCALES', () => {
- // Test a few valid locales
expect(normalizeLocale('en')).toBe('en');
expect(normalizeLocale('fr-FR')).toBe('fr-FR');
expect(normalizeLocale('es-ES')).toBe('es-ES');
});
it('should handle case-insensitive matches', () => {
- // Test with lowercase variants of the locales
expect(normalizeLocale('fr-fr')).toBe('fr-FR');
expect(normalizeLocale('es-es')).toBe('es-ES');
expect(normalizeLocale('DE-de')).toBe('de-DE');
});
it('should match just the language part if full locale not found', () => {
- // Test with just the language code
expect(normalizeLocale('fr')).toBe('fr-FR');
expect(normalizeLocale('es')).toBe('es-ES');
expect(normalizeLocale('de')).toBe('de-DE');
diff --git a/packages/twenty-shared/src/utils/validation/normalizeLocale.ts b/packages/twenty-shared/src/utils/validation/normalizeLocale.ts
index 66ffa57797c..5c9c96575fc 100644
--- a/packages/twenty-shared/src/utils/validation/normalizeLocale.ts
+++ b/packages/twenty-shared/src/utils/validation/normalizeLocale.ts
@@ -26,7 +26,6 @@ export const normalizeLocale = (value: string | null): AppLocale => {
return SOURCE_LOCALE;
}
- // Direct match in our supported locales
if (value in APP_LOCALES) {
return value as AppLocale;
}
diff --git a/packages/twenty-shared/src/workflow/utils/variable-path.util.ts b/packages/twenty-shared/src/workflow/utils/variable-path.util.ts
index 11c949b1059..673783842ea 100644
--- a/packages/twenty-shared/src/workflow/utils/variable-path.util.ts
+++ b/packages/twenty-shared/src/workflow/utils/variable-path.util.ts
@@ -41,7 +41,6 @@ export const parseVariablePath = (path: string): string[] => {
current = '';
inBracket = false;
segmentIndex++;
- // Skip the following dot if present
if (segmentIndex < path.length && path[segmentIndex] === '.') {
segmentIndex++;
}
diff --git a/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.form.test.ts b/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.form.test.ts
index 274e2c41a38..c7774ea98e0 100644
--- a/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.form.test.ts
+++ b/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.form.test.ts
@@ -60,28 +60,24 @@ describe('searchVariableInOutputSchema - form output schema', () => {
};
const mockFormSchema: FormOutputSchema = {
- // Simple text field
companyName: {
isLeaf: true,
type: FieldMetadataType.TEXT,
label: 'Company Name',
value: 'Acme Corp',
},
- // Number field
revenue: {
isLeaf: true,
type: FieldMetadataType.NUMBER,
label: 'Annual Revenue',
value: 1000000,
},
- // Email field
contactEmail: {
isLeaf: true,
type: FieldMetadataType.EMAILS,
label: 'Contact Email',
},
- // Record field (nested record)
contactPerson: {
isLeaf: false,
label: 'Contact Person',
diff --git a/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.record.test.ts b/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.record.test.ts
index 987ba80682d..0b4318f7c26 100644
--- a/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.record.test.ts
+++ b/packages/twenty-shared/src/workflow/workflow-schema/utils/__tests__/search-variable-in-output-schema.record.test.ts
@@ -52,7 +52,6 @@ describe('searchVariableInOutputSchema - record output schema', () => {
},
},
},
- // Record field (nested record)
owner: {
isLeaf: false,
label: 'Owner',
diff --git a/packages/twenty-shared/src/workflow/workflow-schema/utils/search-variable-in-output-schema.ts b/packages/twenty-shared/src/workflow/workflow-schema/utils/search-variable-in-output-schema.ts
index 112c2cbf4e5..26100419b38 100644
--- a/packages/twenty-shared/src/workflow/workflow-schema/utils/search-variable-in-output-schema.ts
+++ b/packages/twenty-shared/src/workflow/workflow-schema/utils/search-variable-in-output-schema.ts
@@ -52,8 +52,6 @@ const stripBrackets = (rawVariableName: string): string =>
(_, variableName) => variableName,
);
-// Record output schema navigation
-
const getFieldFromSchema = (
fieldKey: string,
recordSchema: RecordFieldNodeValue,
@@ -177,8 +175,6 @@ export const searchRecordOutputSchema = ({
);
};
-// Base output schema navigation
-
const navigateBaseToTargetField = (
startingSchema: BaseOutputSchemaV2,
pathSegments: string[],
@@ -241,8 +237,6 @@ const searchBaseOutputSchema = ({
};
};
-// Per-schema-type search functions
-
const searchThroughRecordOutputSchema = ({
stepName,
recordOutputSchema,
@@ -663,8 +657,6 @@ const searchThroughManualTriggerOutputSchema = ({
return EMPTY_RESULT;
};
-// Main dispatcher
-
export const searchVariableInOutputSchema = ({
schema,
stepType,
diff --git a/packages/twenty-ui/scripts/generateBarrels.ts b/packages/twenty-ui/scripts/generateBarrels.ts
index 4458263b307..53f5c375943 100644
--- a/packages/twenty-ui/scripts/generateBarrels.ts
+++ b/packages/twenty-ui/scripts/generateBarrels.ts
@@ -400,7 +400,6 @@ function extractExportsFromSourceFile(sourceFile: ts.SourceFile) {
const isTypeExport =
node.isTypeOnly || ts.isTypeOnlyExportDeclaration(node);
if (isTypeExport) {
- // should handle kind
exports.push({
kind: 'type',
name: exportName,
diff --git a/packages/twenty-ui/src/theme/constants/MainColorsDark.ts b/packages/twenty-ui/src/theme/constants/MainColorsDark.ts
index cd76aba2a4c..9d5e8ccde46 100644
--- a/packages/twenty-ui/src/theme/constants/MainColorsDark.ts
+++ b/packages/twenty-ui/src/theme/constants/MainColorsDark.ts
@@ -2,38 +2,32 @@ import * as RadixColors from '@radix-ui/colors';
import { GRAY_SCALE_DARK } from '@ui/theme/constants/GrayScaleDark';
export const MAIN_COLORS_DARK = {
- // Reds
red: RadixColors.redDarkP3.red9,
ruby: RadixColors.rubyDarkP3.ruby9,
crimson: RadixColors.crimsonDarkP3.crimson9,
tomato: RadixColors.tomatoDarkP3.tomato9,
- // Oranges & Yellows
orange: RadixColors.orangeDarkP3.orange9,
amber: RadixColors.amberDarkP3.amber9,
yellow: RadixColors.yellowDarkP3.yellow9,
- // Greens
lime: RadixColors.limeDarkP3.lime9,
grass: RadixColors.grassDarkP3.grass9,
green: RadixColors.greenDarkP3.green9,
jade: RadixColors.jadeDarkP3.jade9,
mint: RadixColors.mintDarkP3.mint9,
- // Cyans & Blues
turquoise: RadixColors.tealDarkP3.teal9,
cyan: RadixColors.cyanDarkP3.cyan9,
sky: RadixColors.skyDarkP3.sky9,
blue: RadixColors.indigoDarkP3.indigo9,
- // Purples & Pinks
iris: RadixColors.irisDarkP3.iris9,
violet: RadixColors.violetDarkP3.violet9,
purple: RadixColors.purpleDarkP3.purple9,
plum: RadixColors.plumDarkP3.plum9,
pink: RadixColors.pinkDarkP3.pink9,
- // Earth tones & Neutrals
bronze: RadixColors.bronzeDarkP3.bronze9,
gold: RadixColors.goldDarkP3.gold9,
brown: RadixColors.brownDarkP3.brown9,
diff --git a/packages/twenty-ui/src/theme/constants/MainColorsLight.ts b/packages/twenty-ui/src/theme/constants/MainColorsLight.ts
index 4a00386d134..737f0f3b4eb 100644
--- a/packages/twenty-ui/src/theme/constants/MainColorsLight.ts
+++ b/packages/twenty-ui/src/theme/constants/MainColorsLight.ts
@@ -2,38 +2,32 @@ import * as RadixColors from '@radix-ui/colors';
import { GRAY_SCALE_LIGHT } from './GrayScaleLight';
export const MAIN_COLORS_LIGHT = {
- // Reds
red: RadixColors.redP3.red9,
ruby: RadixColors.rubyP3.ruby9,
crimson: RadixColors.crimsonP3.crimson9,
tomato: RadixColors.tomatoP3.tomato9,
- // Oranges & Yellows
orange: RadixColors.orangeP3.orange9,
amber: RadixColors.amberP3.amber9,
yellow: RadixColors.yellowP3.yellow9,
- // Greens
lime: RadixColors.limeP3.lime9,
grass: RadixColors.grassP3.grass9,
green: RadixColors.greenP3.green9,
jade: RadixColors.jadeP3.jade9,
mint: RadixColors.mintP3.mint9,
- // Cyans & Blues
turquoise: RadixColors.tealP3.teal9,
cyan: RadixColors.cyanP3.cyan9,
sky: RadixColors.skyP3.sky9,
blue: RadixColors.indigoP3.indigo9,
- // Purples & Pinks
iris: RadixColors.irisP3.iris9,
violet: RadixColors.violetP3.violet9,
purple: RadixColors.purpleP3.purple9,
plum: RadixColors.plumP3.plum9,
pink: RadixColors.pinkP3.pink9,
- // Earth tones & Neutrals
bronze: RadixColors.bronzeP3.bronze9,
gold: RadixColors.goldP3.gold9,
brown: RadixColors.brownP3.brown9,